[04:32:44] (03PS1) 10Shirayuki: Fix double-space [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95979 [04:37:54] (03PS1) 10Amire80: Set up GENDER for two messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95980 [05:46:42] kaldari: Hi [05:46:55] howdy :) [05:47:08] hie [05:47:13] just wanted to let you know I have parsoid and desktop VisualEditor running locally nowe [05:47:30] rmoen: you still working on the merge of the new stuff? [05:47:42] kaldari: yes, i am ;/ [05:48:00] kaldari: one sec [05:49:39] kaldari, have you managed to run VE on mobile with rmoen's patch? [05:50:04] jgonera: no, is that the one he's merging now? [05:50:26] jgonera, kaldari: I guess it doesn't need to be merged or rebased to test. [05:50:38] well, I don't think he's merging it because it would be a self-merge ;) [05:50:41] no, it doesn't [05:50:50] rmoen, you're just rebasing now, right? [05:50:54] kaldari: yeah i'm not going to merge it yet as it is a wip [05:51:02] jgonera: indeed [05:51:22] kaldari: Also, yeah probably can't self merge ;/ [05:53:37] rmoen: what's the URL for the patch? [05:55:01] kaldari, https://gerrit.wikimedia.org/r/93916 [05:55:06] kaldari: https://gerrit.wikimedia.org/r/#/c/93916/ [05:55:10] ;) [05:55:13] ty jgonera [05:55:16] jinx [05:55:19] you also need a patch in core and ve itself [05:55:33] kaldari, jgonera: yes, there are links to the deps [05:55:37] in the patch [05:56:03] (commit message) [06:19:13] rmoen, jgonera: After adding all the dependencies, I get "Error: Unknown dependency: oojs" [06:22:15] you sure you checked out the core patch kaldari ? [06:23:46] jgonera: yeah, I applied change 93915 to core [06:27:39] kaldari, must be one of the changes is not applied (maybe the VE one?) [06:27:53] kaldari, maybe you checked it out in a wrong repo? ;) [06:28:04] checking them now [06:28:27] where is oojs supposed to be defined currently? in VisualEditor or core? [06:34:38] rmoen, jgonera: I made sure all the patches were applied. It seems to work fine in Safari, but give the RL error in Firefox. [06:35:06] kaldari: Ahh i have not tested in FF ;/ [06:35:12] funny... good catch, I haven't tested in FF [06:35:22] jgonera: kaldari: I will try to debug [06:38:12] rmoen: the bug is apparenetly in VE code [06:40:52] kaldari: eek! Yeah this has to do withe oojs split [06:41:20] kaldari: broken in chrome too.. I think i know the issue [06:46:54] kaldari: fixing all the OO errors, I should have it amended in a sec [06:47:06] cool [06:54:36] kaldari: I'm close. I'm having an unknown dependency issue at the moment. [06:55:20] it looks like the errors were coming from when it loads ext.visualEditor.base. I stopped debugging after that though. [06:55:42] rmoen: let me know if you want any help [06:55:51] kaldari: I found it [06:59:35] kaldari: i still have an error :( i have resolved the OO dependencies though still have an error with doc.getStore. apparently, it is undefined? I'm guessing still a dep issue. [07:00:14] you're probably unravelling a sweater :) [07:00:22] kaldari: new fixes are in gerrit if you want to pull and assist [07:02:59] kaldari: Pinging roan, maybe he has a clue [07:07:54] rmoen: looks like progress. Now I get TypeError: mw.util.getUrl is not a function, which is due to a recent core merge [07:08:05] probably just need to cherry pick a core change [07:08:21] kaldari: Yeah its is a core problem, I had to pull core [07:08:26] and rebase my core change [07:08:35] rmoen: that should fix it [07:08:58] kaldari: Still another issue after that one [07:09:11] kaldari: i have a clue what it is [07:09:51] rmoen: we should probably grab some lunch too :) [07:10:02] kaldari: indeed [07:12:26] kaldari: there were alot of changes to the api [08:12:03] (03PS1) 10JGonera: Don't run Router#checkRoutes externally [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95988 [08:49:25] (03PS7) 10Robmoen: WIP: VE editing on tablets in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 [08:57:18] (03CR) 10JGonera: [C: 032] "Good catch, that's actually needed in Polish too." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95980 (owner: 10Amire80) [08:57:59] (03Merged) 10jenkins-bot: Set up GENDER for two messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95980 (owner: 10Amire80) [09:47:45] jgonera: any idea what the minimum screen width we're shooting to accommodate with mobile VE is going to be? [09:48:20] there's a variable for that [09:48:22] hey, India gang!:) [09:48:22] let me check [09:48:26] hey MaxSem [09:48:53] how is it like so far? [09:49:22] kaldari, grep -nr wgMFDeviceWidthTablet . [09:49:38] no, that's not the width I'm looking for [09:50:02] MaxSem, pretty good, I learned how screwed up implementing other input methods is for some languages [09:50:14] kaldari, no? [09:50:24] jgonera: I guess I need to create a new variable [09:50:43] kaldari, but why? this is the one we use to decide if a device is a tablet or not [09:50:48] gMFDeviceWidthTablet would be the maximum width, I'm looking for the minimum width [09:51:10] and actually I don't really need a variable for it, I just need to know what it is [09:51:12] maximum? there's no such thing [09:51:33] let's talk later and gesticulate because I can't understand ;) [09:51:38] that would be the maximum width at which we are displaying the mobile visual editor, right? [09:59:10] jgonera: nevermind, I didn't realize we were only loading it on tablet view currently [10:03:08] (03PS1) 10Shirayuki: Fix double-space [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96006 [11:17:40] violetto, you're not in SF? [11:20:14] in the land of dreams?:) [11:40:31] kaldari, rmoen I have the editor patch almost finished, just need to finish styling/i18n changes [11:41:30] jgonera: Sweet. I'm pretty much revising our entire integration per some comments that roan had. Basically, I need to completely separate the view specific functionality [11:41:35] kaldari: ^^ [11:42:28] jgonera: cool, I did a review of the VisualEditor patch and gave rob some feedback that he's working on currently. He suggested that he implement it himself since he needs to refactor a lot of that code anyway. [11:43:03] per Roan's suggestions [11:44:56] Yes, it totally makes sense not to be working on the same file at this point as it is getting completely gutted [11:46:17] (03PS1) 10Mhurd: Initial implementation using ops for search with images. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96015 [11:49:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [11:49:32] (03CR) 10Siebrand: [C: 04-1] Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [12:00:11] (03CR) 10Dr0ptp4kt: [C: 032] Fix double-space [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96006 (owner: 10Shirayuki) [12:00:49] (03Merged) 10jenkins-bot: Fix double-space [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96006 (owner: 10Shirayuki) [15:40:23] (03PS3) 10Jdlrobson: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 [16:39:47] (03PS1) 10Zfilipin: Added tags to all feature files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96045 [16:40:52] (03PS1) 10Zfilipin: Whitespace cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96046 [16:45:19] (03PS2) 10Zfilipin: Added tags to all feature files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96045 [16:47:04] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96045 (owner: 10Zfilipin) [16:47:35] (03Merged) 10jenkins-bot: Added tags to all feature files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96045 (owner: 10Zfilipin) [16:51:23] (03PS2) 10Cmcmahon: Whitespace cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96046 (owner: 10Zfilipin) [16:52:01] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96046 (owner: 10Zfilipin) [16:56:02] (03Merged) 10jenkins-bot: Whitespace cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96046 (owner: 10Zfilipin) [17:57:59] (03PS2) 10Jdlrobson: Fix double-space [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95979 (owner: 10Shirayuki) [17:58:06] (03CR) 10Jdlrobson: [C: 032] i18n: Fix double-space [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95979 (owner: 10Shirayuki) [17:59:29] (03Merged) 10jenkins-bot: i18n: Fix double-space [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95979 (owner: 10Shirayuki) [18:20:10] (03CR) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [18:22:23] (03PS4) 10Jdlrobson: Separate stable and beta search JS code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 (owner: 10JGonera) [18:25:59] (03PS2) 10Mhurd: Initial implementation using ops for search with images. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96015 [18:26:42] (03CR) 10Jdlrobson: [C: 032] Separate stable and beta search JS code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 (owner: 10JGonera) [18:27:54] brion: should be review-able now :) [18:28:12] whee [18:29:18] (03CR) 10Jdlrobson: [C: 032] Don't run Router#checkRoutes externally [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95988 (owner: 10JGonera) [18:30:36] (03Merged) 10jenkins-bot: Separate stable and beta search JS code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94078 (owner: 10JGonera) [18:32:50] (03Merged) 10jenkins-bot: Don't run Router#checkRoutes externally [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95988 (owner: 10JGonera) [18:49:59] brion: oh turns out unit test only runs properly w ios7 simulator... in case you run into weirdness [18:50:10] yep [18:56:13] brion: i love the thumbnail for the "tooth" article [18:56:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] "whee" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/95659 (owner: 10Mhurd) [18:59:03] thanks brion! [18:59:16] :) [19:22:00] (03CR) 10Brion VIBBER: [C: 04-1] "Basics work! A few notes inline about double-encoding and ordering problems, which should be easy to fix. Also noted a couple things we mi" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96015 (owner: 10Mhurd) [19:33:45] brion, got a few minutes to do a google hangout re: latest ffos wikipedia commit? [19:44:19] brion: do you want that placeholder changed now or can that come later? [19:44:28] mhurd: that can be later, no rush [19:44:37] brion: k [19:44:53] dr0ptp4kt: sure lemme know [19:47:18] vbamba: https://bugzilla.wikimedia.org/show_bug.cgi?id=56818 [19:51:59] (03PS3) 10Mhurd: Initial implementation using ops for search with images. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96015 [19:52:19] brion: i amended w encoding fixes [19:58:04] vbamba: another blocker - https://bugzilla.wikimedia.org/show_bug.cgi?id=57043 [20:01:06] brion: mmm lunch - ok to get search order stuff straightened out in separate patch? [20:01:11] yeah [20:02:30] (03PS5) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 [20:13:31] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok this fixes the encoding which was the worst problem. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96015 (owner: 10Mhurd) [20:14:24] (03PS1) 10Jdlrobson: Last modified bar tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96080 [20:14:25] (03PS1) 10Jdlrobson: Stop flash of last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96081 [20:14:26] (03PS1) 10Jdlrobson: Make last modified bar green until page is >= 24 hours [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96082 [20:14:59] Some nice things… [20:15:12] (03PS4) 10Brion VIBBER: Work in progress: search thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 [20:23:00] (03CR) 10Brion VIBBER: "Quick update to use Picasso for image loading; don't need the full MediaWikiImageView yet as we get a full URL out of PageImages." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 (owner: 10Brion VIBBER) [20:23:23] (03CR) 10Brion VIBBER: "Oh and I HAVE BEEN CONVERTED TO MAVEN. Adding a library dependency was super-easy!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 (owner: 10Brion VIBBER) [22:32:17] (03PS6) 10Jdlrobson: Alpha: Use the same chrome on special pages as article pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 [22:40:49] (03PS2) 10Yurik: When proxied, don't show banners unless proxy is known to be zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95050 (owner: 10Dr0ptp4kt) [22:45:49] (03PS1) 10Jdlrobson: Style errors on profile better [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96163 [23:13:49] (03PS1) 10Jdlrobson: Use prefixed title in Special:History banner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96166 [23:16:54] (03CR) 10Dr0ptp4kt: [C: 031] "DO NOT MERGE until https://gerrit.wikimedia.org/r/#/c/88261/ is merged and deployed." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95050 (owner: 10Dr0ptp4kt) [23:29:45] (03PS1) 10Mhurd: Search results now retain relative order. Faster display of search titles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96169 [23:31:35] (03PS1) 10Jdlrobson: Stop SHOUTING in special page headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96171 [23:53:51] (03PS1) 10Jdlrobson: Allow filtering of revisions by namespace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96172