[00:14:23] (03PS1) 10Jdlrobson: Alpha: Allow users to add their own mobile.js and mobile.css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96175 [00:16:13] omg customizability! herecy! :P [03:23:01] (03PS2) 10Mhurd: Search results now retain relative order. Faster display of search titles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96169 [03:50:53] (03CR) 10Amire80: [C: 031] Stop SHOUTING in special page headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96171 (owner: 10Jdlrobson) [05:11:07] [[Zero:401-01]]; Yurik; Added IP ranges and enabled testing per partner req; https://meta.wikimedia.org/w/index.php?diff=6425270&oldid=6292921&rcid=4676135 [05:11:56] [[Zero:401-01]]; Yurik; removed ip dups; https://meta.wikimedia.org/w/index.php?diff=6425274&oldid=6425270&rcid=4676137 [06:32:42] (03PS3) 10JGonera: Story 1099: Better search UX [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 [06:32:43] (03PS1) 10JGonera: Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 [06:33:05] (03CR) 10JGonera: [C: 04-1] "Jon's comments still not addressed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [06:34:01] rmoen, kaldari, this is probably almost final patch of the new editor overlay: https://gerrit.wikimedia.org/r/#/c/96209/ [06:34:13] jgonera: Nice! [06:34:21] yay, I'll take look [06:38:54] (03CR) 10jenkins-bot: [V: 04-1] Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [06:39:42] (03PS2) 10JGonera: Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 [06:40:25] also, rmoen have you tested your VE in alpha with captcha and abusefilter enabled? [06:41:15] (03CR) 10jenkins-bot: [V: 04-1] Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [06:41:16] jgonera: no, captcha & abuse filter are not implemented [06:42:21] jgonera: These are integrated in Desktop VE but for the spike they were not implemented. [07:08:55] 01[13WikipediaMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/8BAvkA [07:08:55] 13WikipediaMobile/06master 14fef4654 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [07:09:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [07:10:53] 01[13WLMMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/5pZH5g [07:10:53] 13WLMMobile/06master 1499d9737 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [09:26:21] (03PS8) 10Robmoen: WIP: VE editing on tablets in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 [10:53:24] (03CR) 10JGonera: [C: 04-1] "It all looks pretty good. I added some comments, although most of them are more of a TODOs. I know it's not finished yet. Let me know if y" (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [11:07:43] (03PS3) 10JGonera: Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 [11:07:44] (03PS4) 10JGonera: Story 1099: Better search UX [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 [11:15:13] (03PS4) 10JGonera: Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 [11:15:31] (03CR) 10JGonera: "All three points raised by Jon should be addressed now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [12:24:13] jgonera: Place to stay in Agra: Saniya Palace [12:31:49] rmoen, thanks [17:03:34] (03PS1) 10Jdlrobson: Fix regression in HTML markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96274 [17:41:30] Hi dib96, what are your questions about PROPOSE A PLAN TO SORT OUT OUR MOBILE RELATED PAGES http://www.google-melange.com/gci/task/view/google/gci2013/5073519507406848 ? [17:42:02] (Background for the room: dib96 is a GCI student and he asked at #wikimedia-dev . I recommended him to discuss here. Feel free to listen & answer. [17:43:22] 1 min... [17:43:45] Am I supposed to create an alternative page for the main Mobile Engineering page or just propose my ideas for improving the page ? [17:45:50] Further , can I suggest new features that I think should be included in the proposed projects ? [17:50:59] back dib96 [17:51:30] dib96, like the task says, Draft an alternative proposal at a subpage under your mediawiki.org user page [17:51:56] Is this part clear? [17:54:24] dib96, "It should be ready to substitute the current page, or to become the new main page for mobile projects." [17:54:53] You can use the discussion page related to that page to add your thoughts, interesting links to illustrate your points etc [17:55:22] About suggesting new features, do you mean features for th mobile projects themselves? [18:02:07] Alright ! Thank you! [18:04:40] dib96, you and anybody can propose enhancement requests for any software project at http://bugzilla.wikimedia.org -- but that is NOT part of the scope of this task. :) [18:06:24] Oh!I did not mean to it to be a part of the task.It was just a personal interest of mine. [18:07:19] (03PS4) 10Jdlrobson: Alpha: Experiment to collapse sections in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94245 [18:15:53] brion: got the search results order straightened out: https://gerrit.wikimedia.org/r/96169 [18:15:58] \o/ [18:16:15] brion: also, good morning! :) [18:17:11] :D [18:17:18] moving end of this weeeeeeeeeek i'm so excited [18:17:57] move all the things! [18:23:27] brion, jdlrobson head's up that rachel just moved the scrum of scrums to r32 [18:24:07] rfarrand: does r32 have a remote participation set up? [18:24:36] awjr: it should be R35 and it does. S is in there getting everything going now [18:24:44] oh ok, great thanks rfarrand [18:24:50] brion, jdlrobson, make it r35 :p [18:25:04] i'm remote today, it's all good :D [18:25:08] awjr: we are already there [18:25:13] groovy [18:25:46] awjr: strange I just updated it to be R35 and just checked back and it was listed as R32. Not sure what happened but I just changed it agian. [18:25:59] rfarrand: thanks :) [18:26:17] awjr: we are waiting for you :) [18:26:39] i am coming jdlrobson, start time is 1030 [18:26:43] (that said i know you shave 4 mins ;-)) [18:26:48] :) [18:26:50] just wanted to check you weren't in the wrong hangout [18:26:57] just getting off the phone with mortgage people [18:32:33] YuviPanda: has your exam passed ? [18:33:06] mhurd: brion YuviPanda : reminder more day before we cut this build https://trello.com/b/buxMRu19/mobile-app-sprint-18-search-connectivity , i only see iOS in the review column [18:48:09] yurik, would you mind posting a status update at https://bugzilla.wikimedia.org/show_bug.cgi?id=54822 ? paravoid asked to have the Bugzilla bug updated. [18:52:58] hey jdlrobson, I'm in the hangout if you wanted to get started early [18:53:06] milimetric: sure thang [18:56:01] dr0ptp4kt: done [18:56:26] yurik_ thx [19:00:10] [[Zero:436-01]]; ABaso(WMF); Launch.; https://meta.wikimedia.org/w/index.php?diff=6436349&oldid=6376130&rcid=4679939 [19:14:38] jdlrobson: ping - how's it going? [19:17:28] awjr: so we're probably going to have to have a big overhaul of the limn graphs in december when milimetric is in the office [19:17:43] who is milimetric irl? [19:17:47] :) dan [19:17:51] (andreescu) [19:17:54] hi dan! [19:17:55] * awjr waves [19:17:58] in the mean time milimetric is going to look at optimizing the sql query whilst i will have a look at making the script a bit more cleverer in terms of knowing how often to run a query [19:17:58] hi [19:18:30] that sounds great; so the idea is to try to make some temporary improvements for now; overhaul in dec? [19:19:15] yes awjr [19:19:17] hi, fyi I have bugged Kenan about getting five Google Code-in mobile tasks backed by two mentors. [19:19:21] groovy :) [19:19:39] hi awjr. would you like to meet for lunch or something one of these days? I'm actually in Tucson now, I think it might be valuable to talk about what happens with Michelle leaving. [19:19:52] chrismcmahon: sure! have you had lunch yet today ): [19:19:54] :) [19:19:59] i keep diong backwards smilies :( [19:20:11] I'm SO sure that you can get many little Android / iOS bugs and enhancements completed by GCI students [19:20:26] qgil: are you hoping for apps-focus, web-focus, both? [19:20:31] awjr: today is spoken for I'm afraid. tomorrow would be good though. [19:20:38] qgil: and do you need anything specifically from engineers, or just from kenanwang? [19:20:58] i have too many mtgs tomorrow chrismcmahon, how about thursday? [19:21:15] awjr, I don't see any reason to discriminate teams. :) As opposed to GSoC / OPW this is about little tasks and everybody has many of those, plus some time to evaluate the bugfixes [19:21:34] cool [19:21:39] awjr, Kenan is the messenger: we need the developers! [19:21:48] hehe ok :) [19:22:25] chrismcmahon: thurs or fri this week are good for me [19:22:49] awjr: you're on for Thu! I'm way out on the east side of town... [19:23:32] chrismcmahon: ok, im basically downtown. anywhere in particular you want to meet? or a particular cuisine? cross streets? [19:24:32] awjr: I just arrived on Friday, suggestions welcome... [19:24:56] hehe ok chrismcmahon; if you give me your cross streets i can probably come up with some suggestions somewhere between us [19:25:15] awjr: so say I head west on Speedway toward downtown then [19:25:55] how far east are you, like old spanish trail? or closer in, like wilmot? [19:26:30] awjr: I'm out Speedway past Houghton, where there are no traffic lights [19:26:34] :) [19:26:39] ok, lemme think for a minute [19:26:49] it's friggin gorgeous out there, chrismcmahon [19:26:56] i used to live out that way when i was kid [19:27:25] awjr: yes, yes it is. :-) [19:29:25] chrismcmahon: any particular cuisine? there's an awful lot between us. off the top of my head, i can think of a decent sandiwch joint, a couple of mexican restaurants, a thai joint and a korean/japanese place that's pretty good roughly halfway [19:30:12] awjr: I'll vote for Mexican I think [19:31:24] doh the place i was thinking of doesn't exist anymore :( [19:31:43] awjr: I've only been here since Friday, but Tucson Tamale Co. was good. [19:32:13] awjr: 2545 E. Broadway [19:33:50] oh yeah, that place is pretty good chrismcmahon, conveniently close to me, very far from you though :) [19:33:59] there's a place i used to go to when i was little called 'casa molina' on speedway near wilmot [19:34:09] i remember it being really good; it was my mom's fav [19:34:13] http://www.yelp.com/biz/casa-molina-tucson#query:mexican%20food [19:34:19] it's about halfway between us chrismcmahon ^ [19:34:39] it's a really classic place [19:36:51] how does that sound chrismcmahon? it's classic sonoran style mexican [19:37:06] awjr: sounds great! [19:37:14] cool! does 1230 local work for you? [19:37:42] awjr: it should. I have a video meeting at 2PM [19:37:52] cool! [19:39:28] awjr: human contact! how unusual! [19:39:33] hahaha [19:39:37] i look forward to it chrismcmahon :) [19:42:11] jdlrobson: it looks like spagewmf sent in a pull request for bingle that may resolve the issue we've been seeing with dupes :) [19:49:46] kenanwang: how are we looking at getting designs for https://trello.com/b/h0B6QYBo/wikipedia-app-backlog ? [19:51:58] milimetric think i've done it :) [19:52:01] patch on the way [19:53:10] tfinc I'm gonna chat with kaity in a couple hours and was going to ask her about it then [19:53:23] awesome [19:53:50] i got pulled into a meeting, sorry, I'm looking at sql ... now :) [19:54:08] kenanwang: thanks. our story review is one thursday 11-2 so you still have two full days to refine [19:54:21] lets not run past it [20:00:29] milimetric: https://gerrit.wikimedia.org/r/96315 [20:01:11] mhurd: did you see the spiffy new mockup at https://upload.wikimedia.org/wikipedia/commons/c/c8/Search-overlay-01.png ? [20:01:44] looking jdlrobson [20:01:48] brion: that's awesome!!!! [20:02:18] it's beautifulllllll [20:02:26] brion: agreed [20:02:50] brb lunch [20:03:56] kaity: are assets for the icons for that available, or should we snatch the equivalent images from mobilefrontend for now? [20:09:37] hmm "Sorry! Your web browser doesn't support Wikipedia Nearby." at https://en.m.wikipedia.org/wiki/Special:Nearby [20:09:38] brion: just added assets to the trello cars [20:09:38] https://trello.com/b/buxMRu19/mobile-app-sprint-18-search-connectivity [20:09:42] yay thanks! [20:09:45] *cards [20:09:51] is a dropbox link ok? [20:10:30] yeah that's fine [20:10:41] as long as things come as svg i don't care where :D [20:11:07] svgs for sure [20:13:33] kaity: do you have one for the image upload icon? [20:14:25] though since we won't have upload in it yet maybe we should take out the + [20:14:32] * brion hmms :D [20:16:30] psssh... cat's being all cuddly and nuzzling my foot. doesn't make up for throwing up on the couch earlier >:( [20:19:40] I added it to the folder [20:20:12] whee thanks [20:20:13] though it may be a bit confusing - those icons are just when there is no image associated with the article [20:20:26] brion, able to spare a few minutes for a hangout? [20:20:27] usually that location would show article image [20:20:32] dropbox could sure use better svg support, it doesn't show them in the browser :P [20:20:53] dr0ptp4kt: sure lemme run downstairs [20:21:49] kaity: ok downloaded thanks! [20:21:57] :) [20:23:13] brion, cool, hit me up once you're back [20:23:39] dr0ptp4kt: ok should be online now. [20:25:09] dr0ptp4kt: i seem to have "answered" into an empty hangout lol [20:25:17] internetz [20:25:25] innertubez [20:25:28] hehe [20:26:00] same issue? [20:26:03] yeah [20:26:09] i may or may not have invited you back into the empty hangout [20:40:24] ah technology :D [20:42:23] Actually updating the spec to include wikidata descriptions [20:43:13] brion: awjr MaxSem if one of you could review https://gerrit.wikimedia.org/r/#/c/96274/ and merge it i would be most grateful - mobilefrontend currently undeployable [20:43:35] looking jdlrobson [20:43:40] thanks [20:43:42] brion: sorry for the change [20:44:00] no worries [20:44:27] removed too much, jdlrobson?:) [20:44:30] jdlrobson: is there a trivial way to replicate the problem from a user's perspective? [20:44:46] awjr: actually i clean up this diff a lot more than i have [20:44:47] give me one second [20:46:31] (03PS1) 10Yurik: Removed funky redirect to default, code cleanup [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96357 [20:47:03] jdlrobson: i've got flake8 running in my vim so I compulsively fixed some style problems, and a few little nitpicks [20:47:05] awjr: you need to load the page on a phone [20:47:06] but it looked good [20:47:07] dr0ptp4kt: ok you _might_ have to separately log in at https://marketplace.firefox.com/developers/ once ? but i'm not sure [20:47:13] back to the query now [20:47:16] awjr: i have a /much/ simpler solution though [20:47:32] ok jdlrobson, i'll wait [20:49:08] (03PS2) 10Jdlrobson: Fix regression in HTML markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96274 [20:49:09] ^ awjr much simpler :) [20:49:17] really it's just a case of order of execution [20:50:22] milimetric: sweet thanks for the fixes [20:51:17] milimetric: although technically i personally like unrelated style fixes to happen in separate patches [20:51:30] oh yea, I'm like the world's worst gerrit user [20:51:33] brion, ok, i just signed into https://marketplace.firefox.com/developers/ . nothing listed in 'my apps' at the moment, though [20:51:44] brion, signed out. i just pushed that change to github [20:51:47] I'm happy to abandon my patchset and do that separately [20:52:33] yurik, this one? https://gerrit.wikimedia.org/r/#/c/96357/ [20:52:48] ^ yurik_ [20:57:11] brion, lost connection for a couple minutes, sorry if i missed any messages (pls resend if so). [20:57:30] ^yurik, yurik_ also - re: your zrma update. am i looking at the right one? [20:58:52] yep [20:59:12] dr0ptp4kt: ok i think i added you to the listing entry now [20:59:22] see if you see it under my submissions... [20:59:27] brion, one sec, will check. [21:01:40] brion, i'm in and i see Wikipedia in there. cool [21:01:48] \o/ woohoo [21:04:17] dr0ptp4kt: ok merged to https://github.com/wikimedia/WikipediaMobileFirefoxOS [21:04:25] thanks! [21:04:37] thanks for fixing those bugs :D [21:04:45] brion, thanks for gently guiding me through it [21:04:54] :) [21:05:04] i hope we can do business again. that actually reminds me... [21:05:30] on the iOS and Android apps is there sufficient flexibility (or ability to build in flexibility) to modify URLs and such for W0? [21:06:08] probably... switching prefixes is relatively easy. what do you have in mind? [21:12:30] in a nutshell, hit the api endpoint to determine the w0 configuration for the user's network. to keep it simple, in the short run (maybe shortly after the initial first release), maybe we only add the banner if the carrier's config supports ip address-based zero rating with images on all languages. but then later on, 3-4 months let's say, if we still have a significant portion of carriers not on the "deluxe" zero rating program, we add some [21:12:30] (03CR) 10MaxSem: [C: 032] Don't load beta features code on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95568 (owner: 10Jdlrobson) [21:12:30] tweaks to allow API calls over cleartext HTTP (ugly, because it breaks login...hence the deferred decision). [21:12:36] ^^brion [21:13:11] *shudder* cleartext [21:13:27] brion, yeah, me too. me three. me four. [21:14:08] we should get some zero partners in china ;) [21:14:37] weibo! [21:14:44] thanks MaxSem [21:15:07] welcome:) [21:15:54] dr0ptp4kt: so yeah, switching domains is super easy, we already need infrastructure to swap the domain per language so bumping the protocol or using zero. if necessary should not be hard to rig up [21:18:36] mhurd: brion : iPad Mini's will be here on 11/26 [21:18:43] w/ Retina [21:18:43] :) [21:18:47] tfinc: nice! [21:19:52] greg-g: mw.org is exploding . anyone deploying ? [21:20:01] good deal. thanks. a hook / for topViewPort:^contentGenerator and urlOnClickDecorator:^decorator would additionally be ideal i guess. even if topBanner:^contentGenerator and urlOnClickDecorator:^decorator do nothing for the time being (save maybe something for CentralNotice for topBanner:^contentGenerator). [21:20:05] yeah [21:20:08] i see it now require_once() [function.require]: Failed opening required '/usr/local/apache/common-local/php-1.23wmf4/extensions/VectorBeta/VectorBeta.php' (include_path='/usr/local/apache/common-local/php-1.23wmf4/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/usr/local/apache/common-local/php-1.23wmf4:/usr/local/lib/php:/usr/share/php') [21:20:17] brion ^^^ [21:20:20] jdlrobson: --^ [21:20:26] yeah, htey're on it [21:20:28] sweet [21:20:29] see -operations [21:20:30] thanks all [21:20:50] oops, meant "topBanner", not "topViewPort" in that last message, brion. [21:21:28] tfinc: we're on it [21:21:47] fixed? [21:22:39] ie: can you test (I'm on a call) [21:25:53] awjr: hey there are a lot of "tasks" in the ready for sign off column in mingle [21:26:01] how do you think we should handle those? [21:26:10] good question kenanwang - lemme take a look [21:26:32] ah yeah most of the tasks are sub-tasks for particular storis [21:26:34] *stories [21:27:42] so kenanwang, the easiest thing is probably to just look at the related story. if you accept the story, then its assocaited tasks should be acepted as well (unless the task is something like 'deploy to english wikipedia', in which case, we should probably double check that it's true before accepting) [21:27:50] does that make sense kenanwang? [21:28:13] yeah ok makes sense [21:31:40] (03Merged) 10jenkins-bot: Don't load beta features code on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95568 (owner: 10Jdlrobson) [21:33:13] dr0ptp4kt: yeah, that reminds me we need to think about how to handle notice banners [21:34:17] (03PS1) 10Jdlrobson: i18n: Tweak language of Nearby pages beta feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96371 [21:34:17] jdlrobson: need more time to wrap up your deployment ? [21:34:52] (03PS2) 10Jdlrobson: i18n: Tweak language of Nearby pages beta feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96371 [21:39:57] tfinc: almost done [21:40:06] take your time to let things settle down [21:40:09] i'm free till 4:30 [21:40:43] tfinc: should be good for 2 [21:40:47] ok [21:46:25] (03PS1) 10Brion VIBBER: Remediate a number of bugs. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/96377 [21:47:03] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Merging Adam's last set of fixes from github, we're now on gerrit \o/" [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/96377 (owner: 10Brion VIBBER) [21:47:10] dr0ptp4kt: ^ whee [21:49:19] (03PS3) 10Mhurd: Search results now retain relative order. Faster display of search titles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96169 [21:50:04] brion, sweet. [21:50:07] brion: i amended ^ making search results look more like mockup. i still need to adjust look of search bar itself to do the same [21:50:20] awesome! i'll review that in a moment [21:50:26] brion: yay! [21:55:37] (03PS1) 10Brion VIBBER: readme updates [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/96379 [21:56:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] readme updates [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/96379 (owner: 10Brion VIBBER) [22:02:47] running to grab lunch [22:05:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Nice!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96169 (owner: 10Mhurd) [22:20:59] ooooh native Google Glass development kit preview is out [22:21:06] i'm gonna have fun with that later :D [22:21:20] (03CR) 10Dr0ptp4kt: "It seems good, but let's go over my two comments first." (032 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96357 (owner: 10Yurik) [22:21:23] speaking off native and google. [22:21:48] anyone per chance ever did ndk debugging of an android lib from a junit test in another project ? [22:22:09] i haven't done much w/ ndk yet [22:22:43] it's quite nice actually. [22:23:14] except if stuff is spread over multiple projects :D [22:23:14] i just shudder when i hear "JNI" :) [22:23:19] heh [22:23:35] it's really quite easy [22:24:01] (03CR) 10MarkTraceur: [C: 04-1] i18n: Tweak language of Nearby pages beta feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96371 (owner: 10Jdlrobson) [22:24:04] only structs require you to pay a bit extra attention. [22:24:32] and it's fast. [22:25:11] if you'd strip the java part out of android, they would be rediciously fast machines I suspect. [22:25:57] :) [22:30:38] argh my ISP has been flapping all day :( [22:31:21] :( [22:32:11] just when i think it's working i try a git pull [22:32:22] sigh. [22:34:53] (03PS1) 10Yurik: Handle case when 'language_urls' does not exist [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96387 [22:38:01] (03CR) 10Dr0ptp4kt: [C: 032] Handle case when 'language_urls' does not exist [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96387 (owner: 10Yurik) [22:38:03] (03Merged) 10jenkins-bot: Handle case when 'language_urls' does not exist [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96387 (owner: 10Yurik) [22:40:37] (03CR) 10Awjrichards: [C: 032] Fix regression in HTML markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96274 (owner: 10Jdlrobson) [22:40:42] jdlrobson: ^ [22:40:50] phew :) [22:41:13] (03Merged) 10jenkins-bot: Fix regression in HTML markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96274 (owner: 10Jdlrobson) [22:41:33] i shouldda tested your refactor in a device rather than desktop browser [22:41:35] oh well [22:41:38] thanks for fixing that, jdlrobson [22:41:47] congrats on the house dude [22:41:51] :D [22:41:54] thanks! [22:42:00] awjr: it's my bad rearly i should have diffed a page before and after [22:42:21] we still have until 12/23 for things to go sideways [22:42:29] but so far, everything is in order :) now we just wait. [22:43:41] awjr: is 'focussed' one of these other us spellings? [22:43:51] i always spell it "focused" [22:44:25] heh jdlrobson according to http://answers.yahoo.com/question/index?qid=20070807080640AAb6d8p focussed is the british spelling, focused in the us spelling :p [22:44:35] o_O [22:44:41] awjr: you are using yahoo answers as a reference?! [22:44:53] hey man, it was the first google result [22:44:58] i don't discriminate :p [22:45:09] awjr: i'll correct your blog post then ;-) [22:45:17] hahaha [22:45:18] ty [22:48:36] jdlrobson: i forget is the uploads tutorial on special:uploads spuposed to be in stable, or beta? [22:48:50] awjr: you mention house of air - is it preferable to link to their website or simply say a trampoline park or link to the trampoline article on wiki? [22:49:07] (03CR) 10Yurik: Removed funky redirect to default, code cleanup (032 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96357 (owner: 10Yurik) [22:49:19] that is a good question jdlrobson, idk. i might leave it up to the communications team [22:49:58] i wanted to mention something about obliterating the little kids in trampoline dodgeball but figured the post was not the best place to broadcast that [22:50:06] (03CR) 10Dr0ptp4kt: [C: 032] Removed funky redirect to default, code cleanup [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96357 (owner: 10Yurik) [22:50:09] (03Merged) 10jenkins-bot: Removed funky redirect to default, code cleanup [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96357 (owner: 10Yurik) [22:54:46] (03PS4) 10Awjrichards: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 (owner: 10Jdlrobson) [22:55:18] awjr: https://meta.wikimedia.org/w/index.php?title=Wikimedia_Blog%2FDrafts%2FDeveloping_Distributedly%2C_Part_2&diff=6438589&oldid=6438178 [22:56:29] jdlrobson: the patch in https://bugzilla.wikimedia.org/show_bug.cgi?id=57192 results in some weird artifacts [22:56:32] let me send you a screenshot [22:57:21] thanks for the fixes jdlrobson [22:59:40] (03CR) 10Awjrichards: [C: 04-1] "see https://bugzilla.wikimedia.org/show_bug.cgi?id=57192#c4" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 (owner: 10Jdlrobson) [23:00:52] awjr: that's weird - what mode was that? [23:01:01] stable i htink jdlrobson [23:01:08] let me look again [23:01:40] oh, actually beta jdlrobson [23:04:36] (03PS1) 10Yurik: Landing page URL parameter "isroot" to redirect to proper language landing page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96393 [23:06:08] awjr: i think we need to disable the info box experiment [23:06:11] it's generating way too much data [23:06:22] i screwed up here - we should have sampled it [23:07:41] awjr: you there? [23:17:43] tfinc: got a clamshell cover for the air [23:23:38] awjr: ping [23:24:20] awjr: congrats [23:31:29] awjr: ping me when you're back quite urgent [23:44:43] (03PS1) 10Jdlrobson: Remove infobox experiment from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96397 [23:46:04] (03CR) 10Dr0ptp4kt: [C: 032] Landing page URL parameter "isroot" to redirect to proper language landing page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96393 (owner: 10Yurik) [23:46:07] (03Merged) 10jenkins-bot: Landing page URL parameter "isroot" to redirect to proper language landing page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96393 (owner: 10Yurik) [23:46:14] jdlrobson: back [23:46:16] tfinc thanks :D [23:46:22] jdlrobson: what's up? [23:46:23] awjr: so we have a bit of a situation [23:46:37] the info box experiment is generate a f**k ton of data and we should turn it off [23:46:47] ori-l pushed a config change to disable it [23:47:00] but the code has been cached so events are still being triggered [23:47:17] JS code? [23:47:45] 24gb of data collected in a day o_O [23:47:52] awjr: yeh JS code [23:47:58] awjr: specifically https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=mobile.infoboxTracking&only=scripts&skin=mobile&target=mobile&* [23:48:00] js should only be cached for ~5 mins [23:49:09] although… is the config change in PHP? [23:49:11] jdlrobson: ^ [23:49:34] it's been longer than 5 minutes awjr [23:49:44] according to ori-l it's not going to explode [23:49:53] well that is a relief :) [23:49:54] the config change is in php yeh [23:50:13] so php dictates whether or not the JS does anything? [23:50:13] i'll send a mail to mobile-tech to summarise [23:50:26] but i feel terrible as this is sloppiness on our part (mine especially since i wrote the code) [23:50:35] awjr: PHP dictates whether that JS is included [23:50:39] ahha [23:50:46] that's why you're seeing the caching problem [23:50:48] the JS appears to still be running suggesting it is in browser cache [23:50:55] (or in the page html itself) [23:50:55] that PHP won't run on a page cached in varnish [23:51:04] yeah [23:51:06] awjr: i'm not sure if https://gerrit.wikimedia.org/r/96397 will hlep [23:51:20] probably not [23:51:28] even if if the user is forced to load the new JS they still might have it locally cached [23:51:28] jdlrobson: if you erally want to turn it off fast, do it in JS [23:52:12] if you bust the RL cache by changing the JS code, it should be fine - the client has to revalidate [23:53:04] so yeah, i think the fastest way to disable it is to brute-force disable it in JS and deploy that change everywhere [23:54:11] awjr: ori is going to try touching startup.js [23:54:50] i wonder if that would work [23:54:59] that actually might [23:57:44] ori isn't happy with me :( [23:57:57]