[00:08:37] jdlrobson: have you let kenan know about the infobox issue yet/ [00:08:47] awjr: not yet still fire fighting [00:08:50] ok [00:09:38] (03PS2) 10Jdlrobson: Remove infobox experiment from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96397 [00:11:06] awjr: i think we need to deploy urgently [00:11:08] awjr: are you able to? [00:11:20] im already reviewing jdlrobson [00:11:21] we need to kill this code asap [00:11:27] awjr: would you be able to deploy it? [00:11:30] i should be able to but it will take me a while to get set up [00:11:43] my deployment branches are massively out of date [00:11:54] is ori still around/willing? [00:12:14] if not i can do it [00:12:31] awjr: it would be easier for you to do i think [00:12:38] ok [00:12:59] greg-g: we need to do a deployment to disable a feature that's causing some problems [00:12:59] awjr: i'm talking with ori now i might be able to do it [00:13:06] awjr: greg-g is aware of it [00:13:08] ok [00:13:25] jdlrobson: greg-g: is ok if we go ahead and deploy asap? [00:13:52] awjr we already have permission [00:13:57] great [00:14:28] ok i think the change looks ok, let me just do some quick testing [00:14:47] (03PS1) 10Ori.livneh: Disable MobileWebInfobox's attemptLogEvent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96399 [00:15:23] (03CR) 10jenkins-bot: [V: 04-1] Disable MobileWebInfobox's attemptLogEvent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96399 (owner: 10Ori.livneh) [00:15:23] jdlrobson: ori's apporach is a little less terrifying ^ [00:15:30] (03CR) 10Jdlrobson: [C: 032] Disable MobileWebInfobox's attemptLogEvent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96399 (owner: 10Ori.livneh) [00:16:09] (03CR) 10jenkins-bot: [V: 04-1] Disable MobileWebInfobox's attemptLogEvent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96399 (owner: 10Ori.livneh) [00:16:16] jdlrobson: it's not going to merge due to jenkins [00:17:03] (03PS2) 10Jdlrobson: Disable MobileWebInfobox's attemptLogEvent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96399 (owner: 10Ori.livneh) [00:17:14] (03CR) 10Jdlrobson: [C: 032] Disable MobileWebInfobox's attemptLogEvent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96399 (owner: 10Ori.livneh) [00:18:37] (03Merged) 10jenkins-bot: Disable MobileWebInfobox's attemptLogEvent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96399 (owner: 10Ori.livneh) [00:18:55] (03PS1) 10Ori.livneh: Disable MobileWebInfobox's attemptLogEvent [extensions/MobileFrontend] (wmf3) - 10https://gerrit.wikimedia.org/r/96400 [00:18:59] jdlrobson: do you need to me to do the deployment? im updating my deployment branhces now [00:19:22] awjr: it looks like ori should be able to do it but can you update them just in case? [00:19:24] (03CR) 10Ori.livneh: [C: 032 V: 032] "With Jon's approval." [extensions/MobileFrontend] (wmf3) - 10https://gerrit.wikimedia.org/r/96400 (owner: 10Ori.livneh) [00:19:29] yes [00:20:01] it looks like there is something screwed up with the code and it is logging events when it shouldn't be [00:20:45] awjr: possibly what is happening is there are tiny infoboxes that don't involve any scrolling whatsoever [00:20:54] @_@ [00:22:06] awjr: https://gerrit.wikimedia.org/r/#/c/96401/ [00:23:11] jdlrobson: wait [00:23:16] don't do that [00:23:28] we just want to cherry pick the change not update to master [00:23:36] that's what I did [00:23:43] (also, hi awjr) [00:24:32] awjr: ? [00:24:35] ah i see ori-l, yeah that looks ok - sorry, jumped to conclusions by misreading the log msg :) [00:24:40] and hi :) [00:24:50] np [00:24:55] you have to cane jon next time you see him [00:25:09] we may have to settle for an e-caning until late dec [00:25:13] not playfully, either -- real, earnest caning [00:25:39] i'm just kidding [00:25:42] it's not a big deal [00:25:45] i've done worse :) [00:26:24] hehehehehe [00:26:27] awjr: definitely some dodgy code / browser quirk at play here - i'm seeing events that have the same start and end log time meaning they are instantly logging for some reason [00:26:50] you cant really call yourself an engineer until you've done something that requires a caning [00:26:58] or at least taken down enwiki [00:27:10] jdlrobson: :( [00:27:26] perhaps we should focus on cleaning up the eventlogging related code for next hygiene [00:28:34] ori-l: are you deploying? [00:28:52] im still waiting for my deployment branches to finish updating :| [00:29:28] I deployed it [00:29:30] ok [00:29:37] sorry, I thought that is what you and jon negotiated [00:29:58] yes ori-l he asked me to be on standby, i just wasn't sure of the ultimate outecome [00:30:09] jdlrobson: ori-l if you guys have a handle on the situation, im about to duck into a meeting but i'll keep an eye on IRC if you need anything [00:30:17] please do [00:30:20] thanks for all your help ori-l :) [00:30:29] np, thank you [00:34:35] tfinc: idk what just happened, i got randomly logged out [00:37:42] awjr: jon and i confirmed the fix [00:37:52] things are back to normal now [00:43:40] phew [00:59:20] tfinc: you frozed :( [01:00:06] awjr: as we pantomime :) [01:02:18] awjr: still there? [01:13:51] !logs [01:14:06] (03PS1) 10Mhurd: Search term now highlighted in titles of search results. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96406 [01:25:27] ori-l: aye [01:25:49] YuviPanda: you done with your test ? [01:25:56] tfinc: hey [01:25:59] yup [01:26:04] ori-l: did i miss you? [01:26:07] still recovering from the hand pain, but done [01:26:18] just woke up [01:26:29] awjr: no big deal. the leftover hack in MediaWiki:Mobile.js on enwiki disabled all EventLogging logging; I asked StevenW to revert it [01:26:50] right on [01:27:47] awjr: mobile targets for RL modules are still required for a module to load on mobile, right? [01:27:57] yes ori-l [01:28:06] k, just checking (not related) [01:28:31] np [01:28:36] ok, im heading out - goodnight everyone [01:32:58] good night [04:50:11] (03PS1) 10Yuvipanda: Delay typeahead by 300ms [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96426 [04:50:17] brion: ^ [04:50:50] brion: search feels much faster with this [04:51:03] nice [04:51:30] brion: also on iOS the serach will have to be reworked again when that wikidata patch lands [04:51:34] I guess? [04:53:20] (03PS1) 10Yuvipanda: Have the shadow be under the search bar when showing results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96427 [04:57:48] YuviPanda: How did your final go boss / [04:57:49] ? [04:57:54] rmoen: should pass boss [04:58:04] rmoen: although my hand is in a world of pain now [04:58:33] should probably stop using the keyboard [05:04:12] * rmoen crosses fingers [05:04:30] rmoen: still in India? [05:04:34] rmoen: got chicken 65? [05:04:35] :P [05:04:52] YuviPanda: Dude, chicken 65, hyderabadi style is spicy as hell [05:05:14] Wrecked my stomach, Im staying away [05:05:19] rmoen: i know. " hyderabadi style" is supposed to be spicy as hell. [05:05:25] i don't like them too much either [05:05:28] rmoen: :( [05:05:44] YuviPanda: I know, I found that out. Working at RedHat today [05:06:19] rmoen: ah sweet [05:08:22] (03PS1) 10Brion VIBBER: Very very quick stub project for Glass [apps/glass/wikipedia] - 10https://gerrit.wikimedia.org/r/96430 [05:08:29] YuviPanda: ^ :DDD [05:08:39] ok back to real android for a moment :) [05:08:43] brion: me jelly [05:08:45] :D [05:09:42] brion: I'm going to make it fetch the entire page next. Right now you only see the lead section [05:10:13] nice [05:10:30] how's exams? [05:10:52] brion: should pass but my hand is in a lot of pain [05:11:02] brion: with the kinesis it makes no difference if I am typing tho [05:11:02] :) :( [05:11:20] brion: although it does suck. I'll head off in about 5 mins, once I get those two reviewed :D [05:12:06] moment :D [05:14:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I can now type "batman" without it crashing etc :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96426 (owner: 10Yuvipanda) [05:17:14] (03CR) 10Brion VIBBER: [C: 04-1] "This shows a gap between the search bar and the search results list content when you scroll down a little (so some of one of the results s" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96427 (owner: 10Yuvipanda) [05:17:59] (03PS2) 10Yuvipanda: Have the shadow be under the search bar when showing results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96427 [05:18:42] brion: hmm I see what you mean. [05:19:07] brion: although the new patchset is meant for so mething else (overlay on an existing article made it look terrible) [05:19:14] brion: I'll think about it. I'm off now [05:19:21] ok :D [05:19:24] see ya [05:19:29] good luck! [05:19:33] brion: ty [05:19:39] and feel better [11:31:37] (03PS2) 10Brion VIBBER: Very quick stub project for Glass [apps/glass/wikipedia] - 10https://gerrit.wikimedia.org/r/96430 [11:34:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] "First stub commit. Ok, now back to regular Android for a while. :D" [apps/glass/wikipedia] - 10https://gerrit.wikimedia.org/r/96430 (owner: 10Brion VIBBER) [15:09:13] [[Zero:623-03]]; Yurik; enabling test per partner request, removed same as default - bannerWarning & showImages; https://meta.wikimedia.org/w/index.php?diff=6446856&oldid=6219721&rcid=4682139 [15:21:01] [[Zero:401-01]]; Yurik; disabled - partner finished testing; https://meta.wikimedia.org/w/index.php?diff=6447031&oldid=6425274&rcid=4682171 [16:02:39] (03PS1) 10Yurik: Allow external home script to access landing URL logic [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96503 [16:12:47] (03CR) 10Dr0ptp4kt: [C: 032] Allow external home script to access landing URL logic [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96503 (owner: 10Yurik) [16:13:06] (03Merged) 10jenkins-bot: Allow external home script to access landing URL logic [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96503 (owner: 10Yurik) [16:39:28] MaxSem, would you be able to be "on call" for the w0 deployment window? that is, after the mobile web standup around 1015 pacific time? during the w0 deployment window from 1000-1100 pacific time yurik / yurik_ is going to deploy the latest Firefox OS Wikipedia app (git submodule of mediawiki-config) into tin:/a/common/docroot/bits/WikipediaMobileFirefoxOS. to make things exciting, the repo is now in gerrit (not [16:39:29] GitHub) and to make things even more exciting, the submodule itself has a submodule, MF, pinned to a particular commit within MF (we need to keep it there to ensure no breakage). the first 15 minutes of the deployment window will be mostly file prep i think. [16:40:32] ffs [16:40:47] don't they have a marketplace of something? [16:41:11] its a web app, loaded dynamically i think :) [16:42:05] http://fearless-selling.ca/wp-content/uploads/2012/04/bush_doing_it_wrong.jpg [16:43:20] hehe [16:53:26] but yeah, I'm happy to help as much as I can [17:02:34] MaxSem, thank you. yurik_ here's the mediawiki-config change for the deployment https://gerrit.wikimedia.org/r/96517 [17:13:11] yurik, the MF commit is 38949db705ebeca2e8333f2a2099f9cd1f1d9ddc [17:13:16] ^yurik_ [17:34:53] MaxSem: can we do sync-dir on wmf-config/submodule ? [17:35:07] yes [17:35:08] because the guide say we should only do it one file at a time [17:54:19] (03CR) 10Jdlrobson: i18n: Tweak language of Nearby pages beta feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96371 (owner: 10Jdlrobson) [18:02:17] MaxSem: hangout? [18:02:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] Search term now highlighted in titles of search results. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96406 (owner: 10Mhurd) [18:02:32] yurik_, sure [18:13:42] brion: hey! thanks for merging the search term stuff! [18:13:55] who thing :D [18:14:05] *sho thing [18:15:46] mhurd: are they running late on their standup? :) [18:18:52] (03CR) 10Amire80: i18n: Tweak language of Nearby pages beta feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96371 (owner: 10Jdlrobson) [18:22:00] (03PS5) 10Jdlrobson: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 [18:22:35] jdlrobson: dunno if you already noticed but looks like juliusz took care of the issues you raised in https://gerrit.wikimedia.org/r/#/c/95318/ [18:22:48] awjr: yeh i saw [18:25:16] whee [18:25:40] mhurd: oh when we have time next week i gotta show you the Google Glass thing, i've been playing with the dev kit :D [18:26:09] brion: yay! that should be fun! [18:27:05] jdlrobson: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1345 is supposed to be in beta only, correct? [18:27:25] awjr: correct [18:27:30] is it not? [18:27:41] havent tested it yet; looks like it is in the code [18:27:48] but its just not mentioned in the card so i wanted to dbl check [18:28:34] brion: oh, there's an issue the bridge i was wondering if you could take a look at - tapping links no longer seems to work and i'm not sure what's going on [18:28:58] mhurd: ok, in current master or a branch? [18:29:00] lemme fire it up [18:29:07] brion: ya current master [18:30:19] ok.... looking at the log output... [18:30:49] looks like we're not capturing the click events inside the web view yet [18:31:06] and we have a generic URL that gives wrong links when the relative links are clicked for a manual load [18:31:30] lemme see if we finished that part on android, if so it'll be easy to copy :D [18:31:33] ya i tried changing the base url but to no avail [18:32:29] ok here's what you need: [18:32:51] https://github.com/wikimedia/apps-android-wikipedia/blob/master/wikipedia/assets/main.js <- copy the document.onclick handler from here into the bridge code for iOS [18:33:24] and then set up an event handler on the Obj-C side that takes the link URL, removes the /wiki/ prefix, and launches it as a page [18:33:50] brion: k thx! [18:36:19] (03PS1) 10Jdlrobson: Cleanup this page has issues initialisation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96537 [18:37:04] brion: oh, about the wrong images sometimes appearing in android - i noticed on iOS that setting image view's "image" property needed to actually be synchronous or i sometimes saw the same problem. all the retrieval stuff was async tho of course :) [18:37:40] jdlrobson: q - is there a functional difference between mw.config.get('wgMFMode') and M.assertMode()? [18:37:41] yeah, the actual loading is being done by a library which *claims* to handle that for me ... i'm suspicious of it though ;) [18:37:56] awjr: yes [18:38:08] mw.config.get('wgMFMode') tells you which mode you are currently in [18:38:19] i mean besides one returns a specific value and the other performing an assertion [18:38:35] assertMode is used to prevent code leakage into environments it doesn't belong [18:38:48] if I try to run alpha code in stable it will throw an exception and stop any JavaScript running [18:38:51] what happens when assertMode is false? [18:38:54] ah ok [18:38:56] so it excepts [18:38:59] it's like a check [18:39:12] it basically says "Hey mobile I'm about to run some alpha / beta code" [18:39:23] then mobile say woooooohhh dude don't do that you're in stable and punches it in the face [18:39:41] so you use it more as a gatekeeper whereas you may use mw.config.get('wgMFMode') as a switch [18:42:52] (03CR) 10Awjrichards: Story 1345: Redesign notifications overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95482 (owner: 10Jdlrobson) [18:43:03] awjr: errr… https://en.m.wikipedia.org/wiki/Special:MobileDiff/582451174...582457500 [18:43:07] looks like we had a regression? [18:43:24] what is the regression jdlrobson? [18:43:29] awjr: i see a search box [18:43:51] ah yeah; but that change would not have gone out to enwiki yet, correct? [18:44:01] awjr: this is a mistake [18:44:01] do you see that on mw.o too? [18:44:16] diffs should look like all the other special pages [18:44:20] it looks a bit funky [18:44:33] vbamba: https://en.m.wikipedia.org/wiki/Special:MobileDiff/57569551...575724873 how bad is this that it i styled like an article page? [18:45:20] awjr: mediawiki.org looks fine https://m.mediawiki.org/wiki/Special:MobileDiff/823366 [18:45:26] so i guess enwiki will get fixed tomorrow? [18:47:35] (03CR) 10Jdlrobson: [C: 032] Story 1099: Better search UX [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [18:51:12] (03Merged) 10jenkins-bot: Story 1099: Better search UX [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [18:51:22] (03PS5) 10Jdlrobson: Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [18:52:06] ok got the search cards split out [18:57:47] awjr: shoot.. https://commons.wikimedia.org/wiki/Special:Nearby class name wars :( [19:00:37] argh [19:00:49] jdlrobson: yeah enwiki should get fixed tomorrow [19:01:05] iirc that change got on the train last week, so yeah [19:06:11] jdlrobson: i am mildly concerned about the use of mw.config.get( 'wgMFMode' ) !== 'stable' in the js [19:06:28] i know it's nitpicky, and seems like this is the convention you've been using [19:06:55] but since the value of wgMFMode can be an arbitrary string, this seems like there's potential for danger and things to go wonky [19:07:08] it seems more prudent to me to check explicitly for alpha/beta [19:07:50] jdlrobson: also i've noticed the use of New as a naming convention for new overlay stuff [19:08:02] i presume you are planning to drop the 'new' once these things graduate? [19:08:35] i am generally wary of naming things with 'new' as 'new' is a relative term - if that code still exists months from now, it won't be so 'new' anymore :p [19:10:14] awjr: correct [19:10:34] i suggested beta but juliusz went with new and i didn't want to bike shed over something trivial [19:10:45] kk [19:11:13] awjr: in terms of mw.config.get( 'wgMFMode' ) === 'stable' there is a patch somewhere in gerrit that adds isBetaGroupMember and isAlphaGroupMember methods [19:11:19] * somewhere in gerrit [19:11:31] that sounds nice :) [19:11:49] ok i won't worry about it for now then but we should hygeiene on that because that seems fragile as is [19:12:06] (03CR) 10Raimond Spekking: "i18n review" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [19:13:49] jdlrobson: i started resolving merge conflicts in https://gerrit.wikimedia.org/r/#/c/95314/7 during rebase, but im getting nervous about really f'ing stuff up - can you take alook so we can get that merged? [19:14:37] awjr: you want me to rebase? [19:14:42] plz jdlrobson [19:15:37] (03CR) 10Jdlrobson: "Thanks Raimond - I'll try and fix these up - you are right on all 3 counts. Feel free to submit a patch if you have time and I'll merge it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [19:15:51] awjr: k 1s [19:15:57] also heading to wikia office in a bit fyi [19:17:34] k are you going to be around for review/estimation jdlrobson? [19:20:16] (03PS8) 10Jdlrobson: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 [19:20:26] (03PS5) 10Jdlrobson: Hygiene: Cleanup enwp.less prepare to destroy it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95452 [19:22:32] (03PS5) 10Jdlrobson: Story 1347 2/2: Update this page has issues in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95453 [19:26:10] (03CR) 10Awjrichards: [C: 032] Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 (owner: 10Jdlrobson) [19:27:16] (03CR) 10Awjrichards: [C: 032] Hygiene: Cleanup enwp.less prepare to destroy it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95452 (owner: 10Jdlrobson) [19:27:47] jdlrobson: if you have a moment, https://gerrit.wikimedia.org/r/#/c/95482/ needs rebase too [19:27:55] awjr: i'm already looking at it [19:27:57] it's trickier [19:28:00] yah [19:28:01] k [19:31:26] (03Merged) 10jenkins-bot: Story 1347 1/2: Use new overlay for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95314 (owner: 10Jdlrobson) [19:32:13] (03Merged) 10jenkins-bot: Hygiene: Cleanup enwp.less prepare to destroy it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95452 (owner: 10Jdlrobson) [19:32:16] bah gerrit is too dangerous, i get lost in code review while looking for my own stuff ;) [19:33:02] (03PS4) 10Jdlrobson: Story 1345: Redesign notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95482 [19:34:55] (03CR) 10Awjrichards: [C: 032] Story 1347 2/2: Update this page has issues in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95453 (owner: 10Jdlrobson) [19:35:16] (03PS6) 10Jdlrobson: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 [19:35:25] jdlrobson: do you know of an article on betalabs with a 'this page issues'? [19:35:55] awjr: not of top of my head - create one :) [19:35:59] awjr: i just noticed a quite serious bug - upload button not working for new users [19:36:18] (beta only though) [19:36:35] in production or master jdlrobson? [19:37:32] master awjr [19:37:45] i'll take a look - i've got to head to the wikia office now i said i'd meet christian for lunch [19:37:45] k let's get that fixed before tomorrow jdlrobson [19:37:49] kk [19:37:53] awjr: sure it's my top priority [19:37:57] word [19:38:20] (03CR) 10Jdlrobson: [C: 04-1] "Still some funkiness - if I go to a page in beta mode as a new editor and click the upload button no tutorial is showing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 (owner: 10Jdlrobson) [19:38:32] ^ awjr that's the patch i need to fix [19:40:00] (03Merged) 10jenkins-bot: Story 1347 2/2: Update this page has issues in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95453 (owner: 10Jdlrobson) [19:41:04] (03CR) 10jenkins-bot: [V: 04-1] Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 (owner: 10Jdlrobson) [19:46:06] mhurd: how's it going? [19:46:58] brion: bridge works, but after clicking on links within article tapping search results no longer loads article. think i have to re-attach listeners after page load? [19:47:22] hmm, shouldn't have to as long as we're canceling the default navigation handling inside the webview [19:47:31] brion: huh [19:47:34] mhurd: when you get a chance branch that up and i'll take a peek [19:48:01] brion: 2 minutes [19:48:39] ok [19:49:15] (03PS1) 10Mhurd: Fix for link taps which weren't working. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96571 [19:49:22] brion: ^ [19:49:52] (03CR) 10Awjrichards: [C: 032] Story 1345: Redesign notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95482 (owner: 10Jdlrobson) [19:50:29] (03Merged) 10jenkins-bot: Story 1345: Redesign notifications overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95482 (owner: 10Jdlrobson) [19:50:30] brion: i need to pull the url out into define. oh, it also jumps back to the mobile site after first link tapped even if i remove ".m" from url [19:50:54] hmm that sounds like we're not stopping the default navigation properly [19:51:24] (03PS3) 10Awjrichards: Story 1360: Add paging to Special:History and enable link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95561 (owner: 10Jdlrobson) [19:52:41] brion: it seems "event.preventDefault();" is happening though... [19:52:55] (03CR) 10JGonera: "You're right about article->page. I noticed that but forgot to tell Kaity about it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [19:53:44] brion: is it being redirected based on mobile safari user-agent? [19:54:10] mhurd: probably, but we shouldn't be allowing that navigation to happen in the first place so it should never happen...? [19:57:25] (03CR) 10Awjrichards: [C: 04-1] Story 1360: Add paging to Special:History and enable link (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95561 (owner: 10Jdlrobson) [19:57:33] brion: i must be doing something silly [19:59:25] (03PS4) 10Awjrichards: Story 1360: Add paging to Special:History and enable link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95561 (owner: 10Jdlrobson) [19:59:49] (03CR) 10Awjrichards: "I updated the i18n file to keep the 404-title message in addition to the new no-results message." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95561 (owner: 10Jdlrobson) [20:06:26] (03PS4) 10Brion VIBBER: Refactor SearchArticlesTask to produce a base ApiTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95700 [20:06:27] (03PS5) 10Brion VIBBER: Search thumbnails for Android [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 [20:06:52] all productions of bases belong to me [20:06:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] Refactor SearchArticlesTask to produce a base ApiTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95700 (owner: 10Brion VIBBER) [20:08:02] ok, view reuse seems less buggy with the placeholder image [20:08:09] but it's still a bit flaky in selecting images, weird [20:11:43] brion: oh god i was doing something stupid - amending... [20:12:12] ? [20:13:12] (03PS6) 10Brion VIBBER: Search thumbnails for Android [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 [20:13:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok still not perfect but it's not exploding, and that's a plus! Merge for now, fix later. ;)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 (owner: 10Brion VIBBER) [20:15:48] (03PS2) 10Mhurd: Fix for link taps which weren't working. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96571 [20:15:58] brion: ^ should be a bit better now [20:16:07] \o/ lemme look [20:16:32] aha, loading the page the right way should help yes :DD [20:16:45] brion: external links to things like wikionary are broken, but that can be fixed later [20:16:54] brion: haha [20:17:07] mhurd: how about we do a quick check for [href hasPrefix:@"/wiki/"]? [20:17:07] brion: i need a nap [20:17:10] haha [20:17:15] brion: will do [20:17:18] spiff [20:17:25] external links are easy to hand off to UIApplication [20:17:31] so may as well throw it in while we're there :D [20:21:11] (03PS1) 10Brion VIBBER: For consistency use Picasso for the static palceholder case as well [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96580 [20:22:21] (03PS2) 10Brion VIBBER: For consistency use Picasso for the static palceholder case as well [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96580 [20:22:32] (03CR) 10Brion VIBBER: [C: 032 V: 032] For consistency use Picasso for the static palceholder case as well [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96580 (owner: 10Brion VIBBER) [20:35:48] (03PS1) 10Yurik: Minor fix of the special case when executing from shell/contrived environment. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96586 [20:36:52] (03PS1) 10Brion VIBBER: Fixes for missing entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96587 [20:37:01] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fixes for missing entries [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96587 (owner: 10Brion VIBBER) [20:38:56] mhurd: ping me when ready, i'm gonna make a sandwich :D [20:39:06] brion: k [20:39:38] keeping fingers crossed for no rain on friday, that's going to be the bulk of my move \o/ [20:45:02] (03CR) 10Dr0ptp4kt: [C: 032] Minor fix of the special case when executing from shell/contrived environment. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96586 (owner: 10Yurik) [20:46:36] (03Merged) 10jenkins-bot: Minor fix of the special case when executing from shell/contrived environment. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96586 (owner: 10Yurik) [20:54:01] (03PS3) 10Mhurd: Fix for link taps which weren't working. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96571 [20:54:45] brion: ^ was taking too long so i just put a js popup as a "fix me" reminder when external links are tapped [20:56:35] heh :D [20:56:38] that should work [20:56:40] lemme review [20:57:50] brion: if there's a quick fix lemme know and i'll add it real fast. coffee having little effect today haha [20:59:04] brion: do i maybe need a new bridge listener for simply navigating to external url? [21:02:14] mhurd: might be the way to go [21:02:17] let's merge this for now tho [21:02:24] brion: k [21:02:32] brion: it's less broken than it was :) [21:02:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok let's merge as is, then clean up later :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96571 (owner: 10Mhurd) [21:02:40] hehe [21:02:47] shoot for the stars, my friend [21:02:55] brion: lol [21:04:31] mhurd: too coffeed up to do the test flight build, or you want to give it a whirl for practice? :D [21:04:49] brion: i can try... i still have notes [21:05:10] ok :) [21:05:14] brion: found em... trying [21:05:21] lemme know if i have to break out the hangout screen sharing [21:05:34] brion: will od [21:05:37] *do [21:09:57] brion: produced the ipa. but when i log in to test flight i only have a commons app... [21:10:31] hm, we may have to add it [21:10:33] lemme check [21:11:50] mhurd: ok see if you see it now [21:11:55] brion: k [21:17:31] brion: when i try to upload test flight tells me 'Invalid Profile: does not contain provisioned devices, are you sure this is not a developer profile?' [21:17:45] * brion hmms [21:17:58] mhurd: did you export it for Ad-Hoc distribution? [21:18:00] brion: i typed up some release notes: Very early test release of from-scratch re-write of iOS Wikipedia app. [21:18:01] -Network connectivity and search were the focus of this first development sprint. [21:18:03] -Search results display as you type [21:18:04] -Search results show image thumbnail [21:18:05] -Article loads when search result tapped (pretty article formatting has not yet been implemented) [21:18:06] -Links to other wiki articles should work when tapped (external links coming soon) [21:18:07] oh we might need to create a profile [21:18:22] brion: opps forgot about multi-line [21:18:28] :D [21:19:19] mhurd: ok looks like we need a new distribution profile, the old ad-hoc generic is expired and the commons one is specific to the other app [21:19:21] lemme poke it [21:19:28] ah [21:22:04] mhurd: ok try refreshing the profile/certs/whatever info in the Xcode prefs accounts tab [21:22:13] and see if it shows up a new 'Wikimedia Ad Hoc' profile [21:22:32] k [21:36:28] brion: at wit's end... would you mind taking a stab at it [21:36:41] sure moment [21:37:05] brion: thanks! i emailed you the release notes i'd typed up [21:39:25] ok looks like i made the profile with the wrong private key [21:39:26] wheeee [21:43:22] ok something about application prefix keychain-access-groups whee [21:43:27] lemme hammer that into shape [21:43:32] i just looooove code signing :P [21:47:00] brion: i love it not [21:52:29] mhurd: ok i think i got it uploaded correctly :D https://www.testflightapp.com/dashboard/builds/edit/7937690/ [21:53:03] (03PS1) 10Brion VIBBER: *poke poke code signing settings* [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96644 [21:53:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] *poke poke code signing settings* [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/96644 (owner: 10Brion VIBBER) [21:55:43] (03PS7) 10Jdlrobson: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 [21:56:03] now to make an android build .... [21:57:47] ok built :D [21:57:58] i'll test em both then send out announced on the mobile-l and mobile-tech and whatnot [22:00:24] brion: awesome!! [22:00:39] brion, are youattending the architecture meeting? [22:01:31] (03PS1) 10Shirayuki: i18n: use "int:" for consistency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96648 [22:01:42] brion, #wikimedia-meetbot -- is starting now [22:31:21] brion: let the fun begin :) https://gerrit.wikimedia.org/r/#/c/96654/ [22:31:35] * yurik_ loves hacks [22:32:03] awjr|lunch: https://gerrit.wikimedia.org/r/95636 is a patch we need to ensure we get merged before end of day [22:32:16] (03PS6) 10Jdlrobson: Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [22:32:27] yeah jdlrobson, i'll look at that after i finish looking at the Special:History patch [22:32:31] im testing that one right now [22:32:34] thanks awjr [22:32:49] np jdlrobson [22:32:56] i'll probably have to stop doing CR after that though [22:32:59] jdlrobson: according to paravoid, all mobile depls are frozen [22:33:03] unless there's anything else mega-urgent for tomorrow [22:33:29] yurik_: ? [22:33:30] yurik_: huh? [22:33:41] that's what paravoid just said on ops [22:34:44] yurik_: mobile web deploys on the deployment train [22:35:06] oh, sorry, i thought you were doing depl window [22:36:20] np [22:36:30] why did they freeze mobile deployments tho? [22:36:33] yurik_: ^ [22:39:23] awjr: because there is some weird 503 issue that noone knows where its coming from [22:40:36] oh fun [22:40:50] where is this happening yurik_? [22:42:16] awjr: apparently they are simply observing that in garphs [22:43:00] (03CR) 10Awjrichards: [C: 032] Story 1360: Add paging to Special:History and enable link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95561 (owner: 10Jdlrobson) [22:43:12] i haven't really looked at it - no idea what URL is even causing it [22:43:14] brion: oh Xcode 5.1 preview is out [22:43:36] (03Merged) 10jenkins-bot: Story 1360: Add paging to Special:History and enable link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95561 (owner: 10Jdlrobson) [22:43:51] jdlrobson: ok, i merged the code for story 1360; i've reviewed all the story-related code i feel comfortable reviewing, which elaves just the edit overlay UI overhaul [22:44:03] jdlrobson: are any of those bugs (Besides the tutorial issue) particularly urgent? [22:44:11] (03CR) 10Jdlrobson: [C: 04-1] "A few issues:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [22:44:18] awjr: looking [22:45:33] nothing super urgent that one aside awjr [22:45:43] although bug fixes are obviously always good to get out asap [22:45:46] ok jdlrobson [22:45:47] aye [22:45:55] i've just got a ton of other stuff i gotta deal with [22:50:07] (03CR) 10Jdlrobson: [C: 04-1] i18n: use "int:" for consistency (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96648 (owner: 10Shirayuki) [22:53:53] (03CR) 10Awjrichards: [C: 04-1] "This seems to work... ish. It loads the tutorial beneath the fold. When I tap on 'contribute an image', i see a brief flash, then the stan" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 (owner: 10Jdlrobson) [22:54:05] awjr: i'll take another look then :) [22:54:15] awjr: stable, beta or alpha? and which page? [22:54:28] jdlrobson: beta, this is on Special:Upload [22:54:37] per the bug [22:56:52] mm.. awjr it's working for me [22:57:00] jdlrobson: let me try a different device [22:58:10] (03PS8) 10Jdlrobson: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 [22:58:25] awjr: might be caching - ensure you've cleared your cache [23:04:16] jdlrobson: i think you're right [23:04:21] clearing cache seemed to make it all work OK [23:04:24] sweet [23:04:35] i tested on two android devices and the same ios device with cache cleared [23:05:35] (03CR) 10Awjrichards: [C: 032] "i take it back - it was a caching issue. lgtm." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 (owner: 10Jdlrobson) [23:06:33] (03Merged) 10jenkins-bot: Strengthen .tutorial selector [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95636 (owner: 10Jdlrobson) [23:26:53] (03PS7) 10Jdlrobson: Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [23:27:56] (03CR) 10Jdlrobson: [C: 031] "Seems that point 2 is already a problem in stable overlays. I made a slight tweak to fix point 1 (now there is a mobile.editing module as " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera)