[00:32:30] jdlrobson: are you going to be around next weds? [00:32:39] awjr: yes why? [00:32:54] jdlrobson: i am on vacation that day - would you mind running standup and the prioritization mtg? [00:33:10] sure [00:33:14] :D [00:43:19] vi [00:43:23] oops [00:52:13] brion: mhurd YuviPanda|zzz : how are our releases doing ? [00:57:46] (03PS1) 10Jdlrobson: Add all logic for edit profile pages in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96681 [01:02:51] (03PS2) 10Jdlrobson: Add all logic for edit profile pages in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96681 [01:04:04] (03PS3) 10Jdlrobson: Add all logic for edit profile pages in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96681 [01:23:49] (03CR) 10Jdlrobson: WIP: VE editing on tablets in alpha (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [01:23:55] (03PS9) 10Jdlrobson: WIP: VE editing on tablets in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [01:55:28] back [01:55:34] ok where was i when i left off... [01:58:01] incidentally, i now have a PDF of my lease :D [02:06:03] (03PS1) 10Yurik: Added ZERO API type=proxies and type=carriers to get only pages of needed type [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96686 [05:26:45] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [05:26:50] (03CR) 10Siebrand: [C: 031] Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [05:47:57] (03CR) 10Yuvipanda: "Boo self merge! :(" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95722 (owner: 10Brion VIBBER) [05:50:45] (03PS1) 10Yuvipanda: Actually add dependency on Picasso [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96696 [06:25:54] (03PS1) 10Yuvipanda: Do not reinvent TextUtils [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96699 [07:03:24] 01[13WikipediaMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/XZBTFQ [07:03:24] 13WikipediaMobile/06master 14486c26a 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [07:06:50] 01[13WLMMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/DVKDZA [07:06:50] 13WLMMobile/06master 14ad750b2 15Siebrand Mazeland: Localisation updates from http://translatewiki.net. [10:11:33] (03PS1) 10Yuvipanda: Remove excess padding in search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96728 [10:26:22] (03PS1) 10Yuvipanda: Make Parcelable LruCache support Strings as values [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96734 [10:43:05] (03PS1) 10Yuvipanda: Redo Image Fetching to be less linear. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96737 [11:19:12] (03CR) 10Siebrand: [C: 04-1] "Likely that the current string has to be changed. See inline." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96648 (owner: 10Shirayuki) [11:50:55] (03PS1) 10Siebrand: article -> page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96747 [11:51:29] (03CR) 10Siebrand: "Follow-up in https://gerrit.wikimedia.org/r/#/c/96747/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95318 (owner: 10JGonera) [11:52:59] (03CR) 10Raimond Spekking: [C: 032] article -> page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96747 (owner: 10Siebrand) [11:53:30] (03Merged) 10jenkins-bot: article -> page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96747 (owner: 10Siebrand) [12:06:40] (03CR) 10Siebrand: [C: 04-1] i18n: Tweak language of Nearby pages beta feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96371 (owner: 10Jdlrobson) [12:39:00] (03PS1) 10Yuvipanda: Fix copypasta errors in the ApiTask refactor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96749 [12:56:04] (03PS2) 10Yuvipanda: Fix copypasta errors in the ApiTask refactor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96749 [13:27:07] [[Zero:401-01]]; ABaso(WMF); Launch (PR to follow next week).; https://meta.wikimedia.org/w/index.php?diff=6459291&oldid=6447031&rcid=4684829 [14:34:36] good moooorning [14:37:11] hello brion [14:37:26] brion: Y U SELF MERGE :( [14:37:33] CUZ U NO THERE [14:37:37] :D [14:37:49] heh yeah ok [14:37:51] we'll have better merge discipline when we're not in a combination of moving, exams, and events ;) [14:38:00] brion: yeah, hopefully [14:38:12] brion: fair number of issues with those patches, tho. I submitted followup fixes but [14:38:16] brion: take a look? [14:38:21] yeah i was rushing a bit getting those in [14:38:22] will do [14:38:30] brion: why the rush? [14:38:41] wanted to get pictures in :D [14:38:48] booo! :P [14:38:52] hehe [14:39:18] oh no i did the maven thing wrong? darn [14:39:25] brion: hehe :D [14:39:32] it was so easy :D [14:39:39] brion: I think you just didn't commit it [14:39:44] yeah musta [14:39:46] dang :D [14:39:53] git commit -p FTW [14:40:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Somehow this didn't make it into the commit before. :( Thanks for the fix!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96696 (owner: 10Yuvipanda) [14:40:34] oh heyyyyyy android.text.TextUtils [14:40:38] that's good to know about [14:40:42] brion: :D [14:40:44] ya [14:41:02] WHY IS THAT NOT PART OF THE FUCKING JAVA STRING CLASS [14:41:14] :D [14:41:14] you should see NSString in Objective-C, seriously it does everything [14:41:38] NSStringClassThatAlsoDoesEverything :D [14:41:44] hehe [14:42:00] brion: also I believe that TextUtils is inlined or somesuch, so should be faster [14:42:04] obj-c also lets you monkey-patch existing classes though, which can get confusing :D [14:42:06] ooh nice [14:42:07] might be wrong but just not reinventing wheel is good [14:42:36] not inlined actually https://android.googlesource.com/platform/frameworks/base/+/e6d368218918f911b1954296dab25bf84147b4c6/core/java/android/text/TextUtils.java [14:42:41] just well optimized Java [14:43:30] ah good, you added the toString() too, ok that should work \o/ and much cleaner thanks [14:43:36] :D [14:43:46] see this is why we need you around dude :D [14:44:22] brion: :D I'll be around more from now, I think :D [14:44:27] \o/ [14:44:40] i'll be busy a lot today and tomorrow moving but then i should be back on schedule as well [14:45:02] brion: yeah figured. Think you'll have time for another round of Code Review? [14:45:09] brion: will have full page fetching in by then [14:45:12] i sure will [14:45:14] awesome! [14:45:32] and then figure out how to make sure you don't lose your scroll position :) [14:45:38] hehe [14:45:51] wonder if we can get that from the web view or if we have to dive in with javascript :P [14:45:53] brion: anyway, moar patches! merge merge! :) [14:45:58] can get scroll position in JS anyway [14:46:16] brion: sortof both, since you first need to expand appropriate sections before scrolling [14:46:24] hah true [14:46:42] so the java side needs to have a list of expanded sections and the scroll position so it can persist it [14:46:52] should be doable [14:47:03] brion: I also redid the way the image requests were being fetched :) [14:47:09] \o/ [14:47:27] 'USB device not found' wtf? [14:47:29] * brion checks plugs [14:49:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Much cleaner yay!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96699 (owner: 10Yuvipanda) [14:50:22] brion: I like the process of greeting you with 6-7 patches when you wake up :) [14:50:28] ooh and we should have a separate placeholder image from the blank image [14:50:29] haha [14:50:32] timezones :D [14:50:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] "mmmm, pretty" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96728 (owner: 10Yuvipanda) [14:51:13] ah i broke rotation didn't i? [14:51:19] brion: yup :P [14:51:30] heh [14:51:33] brion: I've the 'kill activities when you stop seeing them' setting on [14:51:36] so easier to spot [14:51:49] oh that reminds me -- we should mark the input box so it doesn't take over full screen in landscape [14:51:53] ah wise [14:51:59] yeah will figure that out [14:52:15] oh that reminds me [14:52:35] YuviPanda: for the images i was initially storing in a HashMap [14:52:42] but I wasn't sure that using PageTitles as keys was safe [14:52:49] so it's using strings for now [14:52:59] brion: they are not safe, since we didn't override hashCode [14:53:08] bingo, that's what we needed [14:53:09] brion: strings are fine, IMO [14:53:16] i was vaguely remembering there was something special one had to do [14:53:19] ok :D [14:53:19] :D [14:53:31] oh dear god I know Java :| [14:53:35] that sucks! [14:53:36] lol [14:53:46] i suppose if we go fancy like including multilingual search results we might need PageTitles with sites attached [14:53:50] but we'll burn that bridge when we get to it [14:53:55] exactly [14:54:05] brion: I'm also loathe to touch it too much because wikidata [14:54:12] :) [14:55:10] brion: also going to setup a version of autoupdate that does not require testflight or anything :D [14:55:18] \o/ [14:55:19] a little support ifrastructure on toollabs and boom it's done [14:55:24] awesome [14:55:26] that'll be nice [14:55:33] brion: although we might want to share debug keys or something [14:56:03] yeah that might simplify things :D [14:56:08] rather than having to manually uninstall all the time [14:56:59] brion: yup [14:57:30] (03PS1) 10Yuvipanda: Rename PageFetchTask to SectionsFetchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96768 [14:57:35] heh one more :) [14:57:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Doesn't seem to explode \o/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96734 (owner: 10Yuvipanda) [14:58:14] ah good, you added a cache for the page images call [14:58:19] i was going to do that but totally forgot :D [14:58:44] :) [14:58:55] brion: I need to make the size take into account density [14:59:01] in a new patch tho [14:59:24] yeah that should be easy enough [15:00:42] pooh Map.entrySet() [15:00:48] that's a nice one i hadn't known about [15:00:50] *ooh [15:03:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] "excellent refactor; much more responsive with the image lookup cache in and delaying the fetch" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96737 (owner: 10Yuvipanda) [15:04:40] (03PS1) 10Yuvipanda: Make PageImages fetching adjust to screen density [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96769 [15:05:04] brion: ^ too :) [15:05:12] brion: also will you be around for the estimation meeting? [15:05:33] yes [15:05:41] brion: sweet [15:05:45] brion: in person or? [15:05:57] no remote [15:06:05] ah sweet [15:06:31] brion: I'll try to get the latest stuff to kaity|away and violetto so they can take a look [15:06:35] not sure yet from where, schedule is still fluid for today :D [15:06:37] great [15:06:41] I think the search results will probably get a little more padding [15:06:52] although not as much as before [15:07:54] yeah i like the pictures big :D [15:07:59] no need for much padding [15:09:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "nom nom refactoring" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96749 (owner: 10Yuvipanda) [15:09:46] note to self: to get yuvi working hard, commit bad code that will force him to fix it :) [15:10:14] bad brion, bad! [15:10:18] :P [15:10:23] lol [15:11:24] (03CR) 10Brion VIBBER: [C: 04-1] Rename PageFetchTask to SectionsFetchTask (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96768 (owner: 10Yuvipanda) [15:14:03] * brion tries to think if there's any weird way for android to end up with multiple or changing screen densities over time [15:14:13] i ..... don't think so. should be safe to save it in a variable :D [15:16:07] (03CR) 10Brion VIBBER: [C: 04-2] "Also, SectionsFetchTask seems to be missing." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96768 (owner: 10Yuvipanda) [15:16:20] YuviPanda: ^ :) [15:16:53] brion: ah, missed add [15:17:02] :D [15:20:21] brion: done [15:20:23] (03PS2) 10Yuvipanda: Rename PageFetchTask to SectionsFetchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96768 [15:20:25] (03PS2) 10Yuvipanda: Make PageImages fetching adjust to screen density [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96769 [15:20:34] brion: a disadvantage of doing git commit -p. You forget to track renames [15:21:10] hehe [15:23:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] Rename PageFetchTask to SectionsFetchTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96768 (owner: 10Yuvipanda) [15:25:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make PageImages fetching adjust to screen density [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96769 (owner: 10Yuvipanda) [15:25:39] brion: you need to hit 'submit' [15:25:44] yeah i saw :D [15:28:01] lol [15:28:13] i accidentally installed the android app on Glass [15:28:18] i don't think i can get in the input box with that :D [15:28:23] but it launches the activity ;) [15:28:26] :D [15:28:54] need to reenable debug on the nexus7... [15:29:45] 'i wish the device chooser showed device types andf not just serial numbers [15:30:21] there we go... testing that nothing goes wonky on the device with a weird pixel ratio [15:30:49] ok yeah looks good [15:30:54] :D [15:31:08] (int)(48f * 1.333 ) should round to 64, and it doesn't explode or anything [15:31:13] yay [15:31:34] :D [15:50:39] ok good i still have money in bank. new apartment will want some of that \o/ [15:51:12] ok now i'm going to go hyperventilate for a while cause MOVING YAY [15:58:31] Hi! About the Android Wikipedia app, do you plan to use Android action bar? [16:06:46] Tpt_: hey [16:06:48] Tpt_: we'll use the ActionBar pattern, but probably not the ActionBar and related classes themselves [16:06:50] Tpt_: unclear yet [16:06:54] Tpt_: and I will review your code today :) [16:06:56] actually let me do the review nwo [16:06:58] *now [16:07:13] YuviPanda: Thanks [16:07:40] Tpt_: they need manual rebasing :( [16:07:44] Tpt_: can you rebase? [16:08:01] sorry, will try to merge them sooner next time. I was out of action until yesterday so things piled up [16:08:01] Yes [16:08:12] No problem :-) [16:12:54] (03PS2) 10Tpt: Make code site relative [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95801 [16:13:29] (03CR) 10Tpt: "rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95801 (owner: 10Tpt) [16:15:15] (03PS3) 10Tpt: Allows to remain in the app while going to an other language wikipedia [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95819 [16:15:24] (03CR) 10Tpt: "rebase" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95819 (owner: 10Tpt) [16:17:30] (03CR) 10Yuvipanda: [C: 032 V: 032] "Thank you very much! Sorry about the delay in reviewing." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95801 (owner: 10Tpt) [16:18:12] Tpt_: https://gerrit.wikimedia.org/r/#/c/95819/3 still not split up [16:18:28] Tpt_: I see the deletion and modification of the test files still there [16:19:01] YuviPanda: Sorry, I've used for the rebase PS1 and not PS2 :-( [16:19:10] ah, right [16:19:22] can you fix it? [16:22:27] (03PS4) 10Tpt: Allows to remain in the app while going to an other language wikipedia [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95819 [16:23:04] (03CR) 10Tpt: "rebase the good patch set" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95819 (owner: 10Tpt) [16:24:05] YuviPanda: Fixed [16:24:13] Tpt_: looking [16:26:02] Tpt_: hmm, I see SiteTests still gets added but that's okay I guess [16:26:04] let me test [16:26:44] YuviPanda: Yes, it's for other methods tests [16:27:06] yeah 'tis fine :) [16:29:13] (03PS2) 10Tpt: Split EqualityTests inside of classes tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95844 [16:50:20] (03CR) 10Yuvipanda: [C: 032 V: 032] Allows to remain in the app while going to an other language wikipedia [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95819 (owner: 10Tpt) [16:52:24] (03CR) 10Yuvipanda: [C: 032 V: 032] Split EqualityTests inside of classes tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/95844 (owner: 10Tpt) [16:52:28] Tpt_: all done! [16:52:31] thanks for the patches [16:52:40] YviPanda: Thanks :-) [16:52:48] :) [16:53:04] Tpt_: we use trello.com/wikimediafoundation to track what we are going to be working on [16:53:47] YuviPanda: Thanks [16:54:01] Tpt_: :) Thanks for the patches! [16:54:59] brion-away: I also think we should always use strings as keys (re: dictionaries), and use Bundles than HashMap [16:55:02] faster, also parcelable [17:13:12] YuviPanda: im trying to add spagewmf to bingle in tools but it doesnt seem to be finding him [17:13:42] you got a sec to help me out? [17:13:58] sure [17:14:01] :D [17:14:03] moment [17:14:10] awjr: I actually have admin on tools now :D [17:14:17] woohoo! [17:14:58] his username is spage [17:15:12] awjr: add3ed [17:15:14] added [17:15:33] spagewmf: try logging in and 'become bingle'? [17:19:12] (03CR) 10Dr0ptp4kt: [C: 032] Added ZERO API type=proxies and type=carriers to get only pages of needed type [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96686 (owner: 10Yurik) [17:20:00] (03Merged) 10jenkins-bot: Added ZERO API type=proxies and type=carriers to get only pages of needed type [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/96686 (owner: 10Yurik) [17:31:31] YuviPanda: thanks a bunch [17:31:36] yw [18:06:29] brion: YuviPanda : kenanwang reminder that we have our Story review and estimation today @ 11 [18:06:40] yep [18:06:44] tfinc: yup, in about an hour right? [18:06:48] YuviPanda: yes [18:06:52] yup [18:07:07] as always take a pass through both the backlog and *bugs* to see if you want anything included and then kenan can make a call on it [18:07:22] yeah afaik no new bugs but will take a look [18:07:46] kenanwang: can you move the stories you want in the sprint to https://trello.com/b/Q1pNIFXm/mobile-app-sprint-19 ? [18:08:48] * YuviPanda waves at mhurd [18:13:30] YuviPanda: hey! [18:13:55] mhurd: am back! :D got a dozen patches merged today, so yay [18:14:47] YuviPanda: whoa! awesome! [18:15:06] mhurd: are you using wikidata for search on iOS? [18:15:11] by doing two queries? [18:15:48] YuviPanda: using opensearch presently [18:15:49] so far just using open search iirc [18:15:54] ah ok [18:16:03] mhurd: saw the wikidata comments on the iOS card and was a bit confused :D [18:16:54] YuviPanda: soon :) [18:17:06] mhurd: I still haven't gotten back to that patch yet. tomorrow maybe [18:18:13] * YuviPanda waves at violetto [18:21:49] YuviPanda: will the wikidata patch hopefully be live in a week or 2? [18:22:02] mhurd: yeah, it is like 3 hours of work [18:22:07] and then a week of waiting [18:22:21] mhurd: hopefully it'll get on t he deployment on wednesday [18:22:26] 2weeks sounds about right [18:22:41] YuviPanda: very exciting :) [18:23:29] mhurd: yeah! [18:23:45] mhurd: I see you've the spike card. are you playing around with the 'stream XML' soluton? [18:24:10] or you could stream json ;) [18:25:12] brion: heh :D [18:26:45] oh no: http://hat.jit.su/ [18:26:50] YuviPanda: ah i grabbed that iOS card, but spent most of yesterday polishing the search stuff [18:27:02] brion: mhurd YuviPanda --^ we should get our own instance up [18:27:17] mhurd: ah, ok! [18:27:32] mhurd: do let me know if you try something there [18:27:33] :) [18:27:40] YuviPanda: will poke more at it this morning [18:27:42] or we could say numbers :) [18:27:45] who's up for staging this on labs https://github.com/richarcher/Hatjitsu ? [18:27:51] brion: :) [18:27:57] brion: mhurd YuviPanda --^ [18:28:05] * YuviPanda volunteers mhurd for hatjitsu on labs so he can try out labs :D [18:28:25] hatjitsu! [18:28:42] tfinc: i talked with henrik from spotify last night - it was an awesome conversation [18:29:20] he revealed some interesting parallels between their growth and where we're at now. i used to think WMF grew quickly, but they've been doubling in size every year [18:29:38] awjr: i love spotify [18:30:02] mhurd: me too :) [18:30:10] I would if only I could use [18:30:11] it [18:30:14] :( [18:30:20] it is a really amazing product [18:30:22] they won't even let me buy a gift card for a friend who is in the US [18:30:27] proving the impossible! [18:30:35] stupid ilcensing law [18:30:35] s [18:30:45] 'tis okay, I'm used to reading / listening to people rave about awesome things I can't have :P [18:30:50] awjr: we've grown very slowly compared to most tech companies [18:31:02] mhurd: the way spotify is organized internally and how they get sh*t done is also really incredible [18:31:05] compared to any place that i've been it its been snail pace at best [18:31:27] tfinc: aye, i am realizing this. it felt really fast and big to me, but i didnt know any better :p [18:31:32] were at a good point now but i would have killed for these kinds of resources back in 2008 when i really needed them [18:31:39] awjr: i had no idea... must read up [18:31:40] yah [18:32:03] mhurd: there's a paper that inspired me to reach out to this guy - lemme dig it up for ya [18:32:09] tfinc, are we having a 1:1? [18:32:13] mhurd: https://dl.dropbox.com/u/1018963/Articles/SpotifyScaling.pdf [18:32:15] quickr ead [18:32:17] *read [18:32:44] awjr: whoa thanks!!! [18:32:54] brion: mhurd YuviPanda any takers on stagine Hatjitsu on labs? its really easy [18:33:14] (03CR) 10Jdlrobson: i18n: use "int:" for consistency (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96648 (owner: 10Shirayuki) [18:33:22] tool labs or needs its own instance? [18:33:30] brion: node, so no toollabs [18:33:37] which is also why I'm not volunteering :P [18:33:48] brion: ^ [18:33:59] YuviPanda: why not tool labs ? [18:34:14] tfinc: toollabs doesn't support running node based web services yet [18:34:23] why not, what breaks down ? [18:34:33] tfinc: so they put apache in front of everything [18:34:41] and that's a nono with node [18:34:45] they also expect you to use CGI [18:34:52] can't set it up to proxy? [18:35:04] brion: the current proxy is apache :P [18:35:34] brion: I rewrote the proxy with nginx, and that'll support node, but I need to spend some time fixing it before it can get deployed for toollabs [18:35:48] lemme see if i can toss it up on my private server :) [18:36:06] brion: yeah that should be far simpler [18:36:06] (03PS3) 10Jdlrobson: i18n: Tweak language of Nearby pages beta feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96371 [18:36:11] just run it in screen! [18:37:26] (03CR) 10Jdlrobson: [C: 032] Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [18:38:26] Error: Cannot find module '/srv/hatjitsu/app' [18:38:27] wtf [18:38:42] brion: trying out Xcode 5.1 - *really* nice improvements to interface builder's handling of constraint settings [18:38:52] oooooh [18:38:55] i'll have to dl that [18:38:56] brion: hehe hardcoded paths :D [18:39:05] mhurd: dev preview still? [18:39:06] YuviPanda: but aren't they just virts at the end of the day ? [18:39:10] brion: ya [18:39:11] why can't we install what we need ? [18:39:20] tfinc: err, toollabs != labs. [18:39:25] true in labs, not the case in toollabs. [18:39:34] YuviPanda: no that seems to be my actual path [18:39:35] worst naming decision ever since mediawiki/wikimedia/wikipedia [18:39:36] YuviPanda: then just put it up in labs [18:39:39] so i'm confused as to why it's failing [18:39:43] maybe i have to upgrade node [18:40:22] brion: if you are on precise, Ubuntu has node 0.8, and apps sometimes expect 0.10 [18:41:07] i've got 0.10 (from source) but a slightly outdated copy [18:41:26] tfinc: I could take a shot but over the weekend or something. Not in time for this meeting tho. [18:41:26] (03Merged) 10jenkins-bot: Story 1346: Edit overlay UI overhaul [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96209 (owner: 10JGonera) [18:41:55] tfinc: everything on labs must go through Puppet or Ryan_Lane will be unhappy (With good reason :P) [18:43:16] ok so if i run 'node server.js' it claims to be listening [18:43:17] YuviPanda: i'm all for puppetizing it when we know it works and its what we need [18:43:24] but not to just try it out [18:43:34] brion: you setting it up in labs ? [18:43:39] http://brionv.com:5000/46815 [18:43:46] tfinc: on my personal server for the moment [18:43:51] will fiddle with labs when i have more time :D [18:45:57] jdlrobson: i saw that you merged https://gerrit.wikimedia.org/r/#/c/96209/ :) is tehre anything else that needs to be done for story 1346? [18:46:24] awjr: i figured if juliusz really disliked it we could always fix it up later - new editor overlay in production seemed more important :) [18:46:39] awjr: just the bugs [18:46:40] jdlrobson: yeah and unblocking VE in alpha [18:46:42] kk [18:47:02] awjr: i'd like to see Bug 56862 merged [18:47:08] and Bug 56861 fix [18:47:15] jdlrobson: can you move #1346 into ready for testing? [18:47:18] and [Bug 57023 if possible [18:47:26] already have awjr [18:47:28] i'll take a look now; not sure if we'll get them merged in time [18:47:29] kk [18:47:34] but according to the story wall the edit feedback bug is more impoprtant [18:47:44] brion: can I distract you with https://gerrit.wikimedia.org/r/#/c/96175/? [18:48:47] moment [18:50:09] (03PS2) 10Yurik: WIP: DO NOT MERGE! Supported flagged revisions of W0 configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95657 (owner: 10Dr0ptp4kt) [18:50:14] (03CR) 10jenkins-bot: [V: 04-1] WIP: DO NOT MERGE! Supported flagged revisions of W0 configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95657 (owner: 10Dr0ptp4kt) [18:53:24] im not sure the fix for bug 57023 is going to work jdlrobson [18:53:26] brion: thanks! [18:53:37] the resulting sql from that join is not going to be performant [18:54:13] it results in a filesort [18:54:56] it would be nice if we just had a key/value store of the last main namespace edit a user made that gets updated whenever a user makes a main ns edit [18:55:20]