[00:01:57] (03CR) 10Dr0ptp4kt: [C: 032] Optimizations for zero config editing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97484 (owner: 10Yurik) [00:02:05] (03Merged) 10jenkins-bot: Optimizations for zero config editing [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97484 (owner: 10Yurik) [00:22:00] dr0ptp4kt, are you reviewing the second one as well? [00:22:21] (03CR) 10Dr0ptp4kt: [C: 032] Config edit checks and visualizations [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97651 (owner: 10Yurik) [00:22:25] (03Merged) 10jenkins-bot: Config edit checks and visualizations [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97651 (owner: 10Yurik) [00:22:28] ^yurik [00:22:33] hehe [00:22:36] th x [00:23:02] i wonder when should we deploy reviews [00:23:18] dr0ptp4kt, i guess we can do it during our depl window next wed [00:23:43] yeah, next week [00:23:57] yurik, should be an exciting week [00:24:20] oh yeah, we haven't had any crashes lately, time to break that streak [00:24:28] :) [00:40:03] (03CR) 10Awjrichards: [C: 04-1] "Just reiterating jdlrobson's -1 which was lost with the rebase. Please clarify commit message." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96962 (owner: 10Mgrover) [00:40:52] dr0ptp4kt, are you implementing js optional loading of the zero config? [00:41:05] because i want to add the "don't bug me again" there :) [00:42:07] (03CR) 10Awjrichards: [C: 031] Adding default styling for tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97518 (owner: 10Kaldari) [00:42:49] yurik, are you saying you want the javascript to have a "don't bug me again" thing added to it, just as the version for non-JS users would have such a feature? [00:43:05] dr0ptp4kt, correct [00:43:11] and i think its more important for js [00:43:25] because if you have a js capable phone ,you are more likely not to care :) [00:44:44] awjr: today was bugs in beta and Flow and VE and Google Code-in, but I should be able to address that failing Mobile browser test before y'all sign in to irc tomorrow [00:45:09] which one was that chrismcmahon? [00:45:26] i think there are a few :) [00:45:59] yurik, yeah, i get it. okay, so we'd just do it as a js feature. what does "implementing js optional loading of the zero config" have to do with it, though? or is "implementing js optional loading of the zero config" the exact feature that we're discussing? wasn't sure if it was having to do with something else. [00:46:29] I think the one for the Upload tutorial for new user needs maintenance, but haven't looked too closely just yet. [00:46:30] i was thinking of taking a crack at it, but didn't want to step on your toes as i suspect you would be changing related code [00:46:33] dr0ptp4kt, ^ [00:46:35] awjr: ^^ [00:47:09] ah yeah chrismcmahon; i think michelle committed a fix for the test to update the selectors, and we need to get the bug fix deployed to enwiki (i believe it's already deployed to the other wikis) [00:47:31] awjr: glad you didn't freeze or get hit by a car, Saturday was miserable on a bike [00:48:00] chrismcmahon: ha me too! yeah, riding conditions were pretty gnarly [00:48:26] yurik, feel free to hack on the js if that's what you're saying. [00:48:50] chrismcmahon: i think it helped me ride way faster than usual though :p [00:48:51] dr0ptp4kt, ok, just didn't want to do it at the same time as when you will implement optional config loading [00:49:06] jdlrobson, would it be easy to have some sort of an icon in the mobile interface, somewhere in the top right corner i think, to show that its free (when they have hidden the banner) [00:49:12] (03CR) 10Awjrichards: [C: 04-1] "Messages should also be deleted from i18n file since they are no longer used with this patch." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97145 (owner: 10Jdlrobson) [00:49:21] yurik, yeah. i'm just gonna wait on that change until i know what's happening in vcl (the message i emailed on friday). [00:49:35] dr0ptp4kt, why is it related to VCL? [00:50:54] yurik, carrier tagging needs to be turned on for https in order for zrma to rewrite the page and call the js. i figure enough stuff could change between now and then that i'll just touch the file when it's time. the https toggling will be easy as long as we use isHttpsFree or whatever it's called. [00:51:16] yurik, anyhow, your work on the js part of the prompt doesn't depend on https carrier tagging. [00:52:08] gotcha, thx [00:52:37] (03CR) 10Awjrichards: [C: 04-1] "Please update comment associated with regex. Also, please update commit message to reflect the addition of eventlogging stuff - or split t" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96882 (owner: 10Jdlrobson) [00:53:41] (03CR) 10Awjrichards: [C: 031] Hygiene: Fix references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97143 (owner: 10Jdlrobson) [00:54:47] (03CR) 10Awjrichards: [C: 031] Beta Feature: Nearby pages list design tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97070 (owner: 10Jdlrobson) [00:54:57] (03CR) 10Awjrichards: [C: 031] Desktop: Add Vector specific Special:Nearby tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97142 (owner: 10Jdlrobson) [00:55:49] (03CR) 10Awjrichards: [C: 031] Beta Feature: Button styling on desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97069 (owner: 10Jdlrobson) [00:56:38] (03CR) 10Jdlrobson: [C: 032] Adding default styling for tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97518 (owner: 10Kaldari) [00:57:40] (03Merged) 10jenkins-bot: Adding default styling for tables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97518 (owner: 10Kaldari) [01:02:04] okayyyy, fixed solr in betalabs [01:02:12] (don't ask me how) [01:02:25] magic maxsem dust [01:03:07] lol, I already wrote an RT ticket, decided to poke for another minute before submitting:P [01:08:16] (03CR) 10Awjrichards: [C: 04-1] "also please rebase and fix merge conflicts :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [01:12:35] jdlrobson: has kenan ok'd the language/approach here? https://gerrit.wikimedia.org/r/#/c/96163/1 [01:13:42] (03CR) 10Awjrichards: "does this really need to be dependent on https://gerrit.wikimedia.org/r/#/c/94435/6?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96163 (owner: 10Jdlrobson) [01:19:47] (03CR) 10Dr0ptp4kt: [C: 04-1] New warning page (035 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [01:20:54] (03CR) 10Jdlrobson: "Yes it makes life a lot easier and https://gerrit.wikimedia.org/r/#/c/94435/6 is not really as scary as it looks.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96163 (owner: 10Jdlrobson) [01:21:08] dr0ptp4kt, less? [01:21:25] (03CR) 10Awjrichards: [C: 032] Use prefixed title in Special:History banner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96166 (owner: 10Jdlrobson) [01:21:42] yurik, it's a thing that plugs in repeated strings. one sec [01:21:47] awjr is on fire :D [01:22:12] yurik, https://www.mediawiki.org/wiki/LESS#Less - lemme know if you need a hand. you'll just need to move some stuff to different files [01:22:13] (03Merged) 10jenkins-bot: Use prefixed title in Special:History banner [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96166 (owner: 10Jdlrobson) [01:22:25] makes me happy :) [01:22:34] dr0ptp4kt, feel free to change it any way you like :) [01:22:38] i have to leave anyway [01:22:40] (03PS3) 10Jdlrobson: Hygiene: Simplify History error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97145 [01:22:44] (03CR) 10Awjrichards: "Siebrand, I created a bug for the issue you raised: https://bugzilla.wikimedia.org/show_bug.cgi?id=57574" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96166 (owner: 10Jdlrobson) [01:23:06] yurik, ok, lemme see what i can do before i wrap up in 40 mins. have a good night pal [01:23:16] thx , u 21 [01:23:18] u 2 [01:23:19] (03CR) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [01:23:20] :) [01:23:52] (03CR) 10Awjrichards: [C: 032] Hygiene: Remove console.log statement [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96921 (owner: 10Jdlrobson) [01:24:29] (03Merged) 10jenkins-bot: Hygiene: Remove console.log statement [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96921 (owner: 10Jdlrobson) [01:26:43] (03PS5) 10Jdlrobson: Beta Feature: Switch from + to * in regex [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96882 [01:28:41] dr0ptp4kt, was reading http://lesscss.org/ - interesting... as they say, any problem in CS can be solved with yet another level of indirection... wasn't CSS designed for that? [01:29:21] yurik, ha [01:34:55] (03CR) 10Awjrichards: [C: 04-1] "This doesn't seem to address the concern of the bug poster, which is that tapping an edit link when not logged in on a fishbowl wiki only " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 (owner: 10Jdlrobson) [01:37:43] (03CR) 10Jdlrobson: "Define fishbowl wiki... maybe I've misunderstood it? I was assuming it was a wiki where all users have to an account in order to edit? If " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 (owner: 10Jdlrobson) [01:46:22] (03CR) 10Awjrichards: "yeah, you're correct, but $wgGroupPermissions['*']['edit'] = true; means anyone can edit (even though we blindly disobey this in MobileFro" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 (owner: 10Jdlrobson) [01:50:53] (03CR) 10Awjrichards: "'meta' seems like an unusual, or at least non-obvious, class name?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95186 (owner: 10Jdlrobson) [01:51:33] (03CR) 10Awjrichards: [C: 032] Hygiene: Remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95649 (owner: 10Jdlrobson) [01:51:46] (03PS3) 10Awjrichards: Redirect action=history links to mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 (owner: 10Jdlrobson) [01:52:18] (03Merged) 10jenkins-bot: Hygiene: Remove unused code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95649 (owner: 10Jdlrobson) [01:54:24] (03CR) 10Awjrichards: [C: 04-1] Redirect action=history links to mobile view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 (owner: 10Jdlrobson) [01:57:15] (03CR) 10Awjrichards: [C: 031] Stop flash of last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96081 (owner: 10Jdlrobson) [01:59:01] (03CR) 10Awjrichards: [C: 031] Make last modified bar green until page is >= 24 hours [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96082 (owner: 10Jdlrobson) [02:00:43] (03PS7) 10Dr0ptp4kt: New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [05:32:01] For KeepGoing, is it a high-priority to let the user choose between task types? [05:32:18] On the desktop, we're emphasizing copyedit for now, though it may change/vary by wiki. [05:32:34] I'm trying to prioritize between the task selection API and a possible API for listing task types. [05:53:18] Alright, I'm going to do "get a task" first, and will follow up tomorow. [06:11:46] (03CR) 10JGonera: [C: 04-1] "Can you elaborate a bit more in the commit message what this is for?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97069 (owner: 10Jdlrobson) [06:14:48] (03CR) 10JGonera: [C: 04-1] Hygiene: Simplify History error handling (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97145 (owner: 10Jdlrobson) [06:17:09] (03CR) 10JGonera: [C: 032] Hygiene: Cleanup diff css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95186 (owner: 10Jdlrobson) [06:17:47] (03Merged) 10jenkins-bot: Hygiene: Cleanup diff css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95186 (owner: 10Jdlrobson) [06:18:47] (03CR) 10JGonera: [C: 032] Beta Feature: Switch from + to * in regex [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96882 (owner: 10Jdlrobson) [06:19:24] (03Merged) 10jenkins-bot: Beta Feature: Switch from + to * in regex [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96882 (owner: 10Jdlrobson) [06:19:30] (03PS5) 10Jdlrobson: Beta Feature: Button styling on desktop [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97069 [06:23:35] (03CR) 10JGonera: [C: 04-1] "Uncaught Error: Unknown dependency: ext.visualEditor.mobileViewTarget" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [06:26:11] (03CR) 10JGonera: [C: 032] Cleanup this page has issues initialisation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96537 (owner: 10Jdlrobson) [06:26:49] (03Merged) 10jenkins-bot: Cleanup this page has issues initialisation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96537 (owner: 10Jdlrobson) [08:30:29] * yuvipanda waves at MaxSem [08:30:38] hey [08:32:26] MaxSem: so.... API? :D [08:32:41] yer boring:P [08:33:45] MaxSem: i know :D [08:33:53] * yuvipanda sips coke, continues puppet patch [08:34:35] MaxSem: add a different prop= that doesn't give me all sections? [09:33:58] (03CR) 10Robmoen: "Be sure you have the latest I786b63ab57518fc6af7761501259ed66592f70e3 checked out" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [09:42:23] (03CR) 10Robmoen: "Again, i'm testing in latest core with chrome and firefox and I do not have this problem." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [10:03:56] (03PS1) 10Shirayuki: Fix getErrorMessage() [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97703 [10:19:32] (03CR) 10Shirayuki: "qqq should be updated." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96648 (owner: 10Shirayuki) [12:34:32] (03CR) 10Shirayuki: "Updated, AFAIK." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96648 (owner: 10Shirayuki) [15:10:08] (03PS2) 10Hashar: browsertests: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 [15:11:11] (03PS3) 10Hashar: browsertests: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 [15:13:07] (03PS4) 10Hashar: browsertests: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 [15:13:34] (03CR) 10Hashar: "Did the same on ULS with https://gerrit.wikimedia.org/r/#/c/97487/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [15:23:24] (03CR) 10Hashar: "Most of the tests do not work against a freshly installed wiki. Either because of Watir timeout or because the test is expecting something" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [15:44:23] (03PS3) 10Cmcmahon: fixing automation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96962 (owner: 10Mgrover) [15:48:10] (03PS1) 10Cmcmahon: update locator for tutorial overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97744 [15:48:44] (03CR) 10Cmcmahon: [C: 032] "maintenance, no change to function" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97744 (owner: 10Cmcmahon) [15:49:23] (03Merged) 10jenkins-bot: update locator for tutorial overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97744 (owner: 10Cmcmahon) [15:49:37] (03Abandoned) 10Cmcmahon: fixing automation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96962 (owner: 10Mgrover) [16:12:41] chrismcmahon: thanks for https://gerrit.wikimedia.org/r/#/c/97744/1 i am glad that will be fixed :) [16:12:54] hi awjr [16:14:30] awjr: still just got a mysterious 503 from beta just now, but I don't think it's a Mobile problem [16:14:42] chrismcmahon: on a big article? [16:14:51] eg barack obama? [16:15:06] awjr: why, yes. but it was OK when I did it manually [16:15:24] i wonder if we should consider using a smaller article [16:15:50] that happens a lot for me on the BO article on betalabs [16:16:06] eh. we shouldn't be getting 503s regardless [16:16:21] well that's true, but it's probably ar esult of how things are architected [16:16:40] my guess is if there's load and there's a cache miss on the BO article (like if you're logged in), it times out [16:16:53] it happens on my local virtual machine often [16:17:20] chrismcmahon: is there a bug open for that by any chance? [16:17:32] afaik it's been a consistent problem [16:17:37] awjr: I don't believe so [16:17:45] i will open one chrismcmahon [16:17:54] awjr: we've had 503s in prod recently as well, right? [16:18:15] for mobile yeah [16:18:46] my guess is it was the result of a different issue [16:19:43] chrismcmahon: email to ops list subject 'Mobile esams intermittent failures, 2013-11-20' [16:20:14] chrismcmahon: have you been getting 503s on other pages on betalabs, or just barack bama? [16:20:51] awjr: I have not noticed 503s in particular at all, other than actual bugs [16:21:12] awjr: might be varnish? [16:21:22] could be [16:22:55] also 503 for non mobile [16:23:22] there were issues with transatlantic connections yesterday. and there were issues with saving large articles causing 503s [16:23:37] these are the most annoying bugs [16:24:21] awjr: aren't you in a hospital? [16:24:27] yuvipanda: no [16:24:42] yuvipanda: im waiting for a call from the hospital to tell me when they can see me [16:24:47] oh [16:24:49] it's much fancier than it used to be! [16:25:01] it's much better to wait at home than go to sit in a waiting room for 4 hours [16:25:01] better than waiting in a room with screaming babies [16:25:04] yes [16:25:04] yeah [16:26:22] chrismcmahon: you opened https://bugzilla.wikimedia.org/show_bug.cgi?id=57249 last week, i just added a comment to that for now [16:27:21] awjr: busy busy busy :-) thanks for commenting [16:32:18] chrismcmahon: is it possible to have browser tests retry on timeout or something? [16:33:21] awjr: I have done that in the past with custom testrunner frameworks. it is probably possible in Jenkins, but I haven't looked too closely. [16:33:56] awjr: all in all, I would rather fix the problems that cause the timeout, whether they be in the environment or in the tests themselves. [16:34:03] yes [16:57:40] (03PS1) 10Cmcmahon: password for Selenium_newuser is the same as for Selenium_user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 [16:58:22] (03CR) 10jenkins-bot: [V: 04-1] password for Selenium_newuser is the same as for Selenium_user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 (owner: 10Cmcmahon) [17:07:44] (03PS2) 10Cmcmahon: password for Selenium_newuser is the same as for Selenium_user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 [17:20:25] The save button on the settings page isn't working for me in stable on enwiki, jdlrobson [17:20:41] That is, it does nothing when I tap [17:21:09] I'm trying from my phone - can you dbl check if it happens for you? [17:22:41] WFM awjr [17:23:07] Wfm in dolphin but not in Chrome :| [17:23:26] mm odd - not sure why that would not work [17:23:30] it's just a form [17:24:06] Huh, closed AL tabs and tried again, worked this time [17:24:22] Weired [17:29:04] how are you feeling dude [17:29:12] foot pain still? [17:31:13] awjr: ^ [17:32:36] (03CR) 10Zfilipin: [C: 04-1] password for Selenium_newuser is the same as for Selenium_user (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 (owner: 10Cmcmahon) [17:34:04] Jdlrobson yeah still waiting to get seen [17:34:24] I'm worried I have a stress fracture [17:37:35] :( [17:38:41] awjr: sent you a mail [17:38:55] showing you the awesomeness that i've been working on and not sleeping over [17:38:56] :) [17:39:08] Hehe sweet [17:40:00] Lol awesome jdlrobson [17:41:02] Land of database Giants [17:42:21] (03PS3) 10Cmcmahon: password for Selenium_newuser is the same as for Selenium_user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 [17:43:52] (03CR) 10Cmcmahon: "answered the comment" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 (owner: 10Cmcmahon) [17:44:21] A1size awjr :) [17:44:34] it's an epic map with a hell of a lot of in jokes in there :) [17:45:21] Nice jdlrobson [17:45:58] When you are done you should scan it and use that huge format printer in comms to print out a giant copy [17:47:37] awjr: yeh that's what tomasz suggested [17:47:57] i'm running out of jokes though and there are still lands needed [17:48:05] jokes and historic artifacts [17:48:42] (03PS4) 10Cmcmahon: password for Selenium_newuser is the same as for Selenium_user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 [17:50:18] :-) [17:50:30] (03CR) 10Zfilipin: [C: 032] password for Selenium_newuser is the same as for Selenium_user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 (owner: 10Cmcmahon) [17:52:47] (03Merged) 10jenkins-bot: password for Selenium_newuser is the same as for Selenium_user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97754 (owner: 10Cmcmahon) [18:16:03] (03PS4) 10Jdlrobson: Hygiene: Remove title exists check on Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97145 [18:16:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove title exists check on Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97145 (owner: 10Jdlrobson) [18:19:12] (03PS4) 10Jdlrobson: Redirect action=history links to mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 [18:19:15] (03CR) 10Jdlrobson: Redirect action=history links to mobile view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 (owner: 10Jdlrobson) [18:20:35] (03CR) 10Jdlrobson: "ahh ok yeh I think I got confused in the code review with legoktm :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 (owner: 10Jdlrobson) [18:26:47] YuviPanda: heya! [18:26:53] * yuvipanda waves [18:27:02] how goes it? [18:27:34] mhurd: not bad. eating ice cream :D [18:27:48] and writing up SQLite schemas for storage. [18:28:03] YuviPanda: me too! except the ice cream part :) [18:28:06] heh :D [18:28:19] mhurd: I just realized that the mockup didn't have the 'context' part for links [18:28:28] the sentence / few words before/after of when the link was clicked [18:28:32] kaity: violetto ^ [18:29:00] YuviPanda: can we reliably extract that? [18:29:05] mhurd: yup [18:29:20] how? [18:29:20] mhurd: when in js you get a click event, you can get its 'siblings' [18:29:28] mhurd: find text of preceeding sibling and next one, pick out a few words. [18:29:35] oh client side [18:29:45] yup :D [18:29:58] fair enough :) [18:30:19] wanna start simple and add that later? [18:30:42] mhurd: it's not that hard to add, and I think how we want to display that will affect the underlying schema etc [18:31:04] mhurd: can you poke kaity or may in person? :) [18:31:27] i think they're in a meeting in r33... [18:31:41] ah, yes [18:31:42] we will talk about it now [18:31:46] ok! [18:35:34] YuviPanda: i hadn't considered the before/after text in my schema... def needed now that you mention it! [18:35:45] mhurd: :D yeah [18:35:56] mhurd: we also need to figure out how to represent 'back' actions [18:36:00] kaity: ^ [18:36:04] got my computer stuff mostly unpacked \o/ [18:36:07] back to multiple monitors :D [18:36:34] yes [18:36:38] moar screens! [18:38:20] anybody from wikipedia zero team here? [18:38:53] we have an open bug that was requested by somebody from wikipedia zero, but I have forgot who [18:38:53] https://bugzilla.wikimedia.org/show_bug.cgi?id=48218 [18:39:13] I do not know if they still need to fake HTTP headers [18:39:25] dr0ptp4kt: yurik ^ [18:39:32] if not, we should close the bug [18:39:41] if yes, feel free to add any relevant data [18:39:57] the bug is part of google code-in and we have students doing good work [18:40:13] so the bug could be resolved these days, maybe even today [18:40:28] zeljkof, yep, would still be useful to us :) [18:40:39] currently we are forced to do our own testing [18:40:50] which is obviously not as good as having a real testing framework [18:41:20] without being able to fake a few headers, we can't really use selenium [18:41:34] we don't care about being able to READ headers, only to set them [18:42:00] yuvipanda: do we still need to tweak https://gerrit.wikimedia.org/r/#/c/96427/ or is that obsoleted by other code? [18:42:32] brion: needs tweaking [18:43:05] yurik: could you please add that info to the bug? [18:43:32] YuviPanda: brion: thoughts on this as a first hack at core-data article storage schema: https://gist.github.com/montehurd/7663582 [18:43:45] looking [18:45:01] yuvipanda: were the section objects in your android code recursive? (top-level section object holds subsections) i forget [18:45:07] brion: yup [18:45:10] recursive [18:45:37] do we want to maintain that subsection identity or just treat things as top-level sections? [18:45:45] it might be best to keep the subsections for granularity in ToC display [18:45:56] yes exactly my thinking [18:46:26] mhurd: mine is simpler, let me do a paste [18:46:28] mhurd: i'm not sure i understand the discoveryContext can you give example? [18:46:49] oh when user clicks on link a bit of text before and after the link [18:47:24] so history could show some context [18:47:28] interesting [18:47:54] yuvi pointed out we can get this via js at time of click [18:47:55] (03PS3) 10Jdlrobson: Enable editing on fishbowl wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 [18:48:15] yeah that's a cool idea [18:48:50] i wonder if we can retain information about where you came from (page/section/approx scroll position) to put you back there on a tap :D [18:48:57] oooh! [18:49:00] good idea [18:49:07] will add [18:49:12] yuvipanda: yes we will have context to the browser history. one way of another! [18:49:14] pick up where you left off and find more links :D [18:49:24] sweeeeet [18:49:25] violetto1: THAT'S THE SPIRIT! :D [18:49:33] :) [18:50:13] yuvipanda: your cts is contagious [18:50:21] so i guess the scroll location could just go in the articles table [18:50:23] violetto1: ow :( that's terrible to hear :( [18:50:23] thanks dr0ptp4kt for running that :) [18:50:58] brion: mhurd for Android https://dpaste.de/OIOc [18:51:09] yuvipanda: yep you shouldn't have mentioned it. i can get overly empathetic ;P [18:51:15] mhurd: well, last-seen-position maybe but if you want to store the position-at-link-click-time that should probably go in the discoveryContext [18:51:17] (03PS1) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97765 [18:51:19] is the browser history view still going to show how you got there - i saw some mockups that showed link icons and random icon and search and is seemed a bit surplus.. [18:51:20] jdlrobson, sure thing! [18:51:24] ^ violetto1 [18:51:28] brion: mhurd mine is more... denormalized [18:51:53] jdlrobson: https://trello-attachments.s3.amazonaws.com/528e4a6bd7ccc8643b004e68/527010eadadfdccc05000880/590c9b089a051b81057c0d41ab0fe498/browser-history-03.png [18:51:56] yuvipanda: that reminds me do we have a nice abstraction for the SQL stuff? maintaining manual schema definitions is kind of primitive feeling [18:52:12] though at least we had some boilerplate helper classes in commons [18:52:14] YuviPanda: yeh that's the one i saw. I think the icons are unnecessary though [18:52:23] jdlrobson: we're adding even more context, actually [18:52:36] what kind of context YuviPanda ? [18:52:44] let's make sure we don't clutter the visuals tho :D [18:52:51] jdlrobson: if you clicked a link, a few words before and after the link you clicked [18:52:59] brion: yeah, don't think that would be a problem yet :) [18:53:05] jdlrobson: how would you get away without icons with showing how you got there? [18:53:16] violetto1: why does it matter? [18:53:43] jdlrobson: the interesting thing about having that discovery context can be that you can get *back* to it [18:53:45] brion: true, but most of those helpers are built into the platform itself. we ourselves didn't have much [18:53:47] if i'm looking at browsing history i would say the purpose of my visit is to find a page I was reading yesterday / a week ago [18:53:53] how i got there doesn't really matter [18:54:17] but i can deduce the history without icons [18:54:33] another alternative might be to retain the view history state with your bookmark [18:54:34] you can also remember where you were yesterday with your memory [18:54:37] for instance yosemite value -> chess that's got to be a search or a random button click [18:54:40] so you can go to X, then go back to Y [18:54:50] anyway, wacky fun ideas :D [18:54:54] ethiopia -> kingdom of aksum those two are related i probably clicked a link [18:54:59] brion: btw, a more fundamental problem is *how* we are going to store 'scroll position' [18:55:05] but i can see that brion in the view by the order of visits :) [18:55:11] yuvipanda: yeah that's a non-trivial problem :D [18:55:20] brion: since just scrollY is going to change with orientation [18:55:27] the icon isn't adding anything to my experience so this is why i'm questioning it - it seems that space would be more useful to show the time for example [18:55:30] not only will it change with orientation, it'll change with content [18:55:38] and it'll change across devices, should you sync things in future [18:56:10] the thing i like about my version is easy mining for things like table of contents menus and such and that whether it's in the history or saved pages is just a property of the article record [18:56:16] i'm thinking it might be best to use the space minimally for a disclosure triangle which gives you more context. [18:56:57] anyway i'm not convinced by it.. it seems like you're creating work for yourself to store this kind of meta information which i argue is not very useful :-) [18:57:15] jdlrobson: it's a lot easier to do this on the apps than on the web :P [18:57:33] and I personally think that having context of where you clicked links will be super helpful [18:57:39] well, basically we have to reproduce the browser's existing history functionality as it is, because we're not in a browser [18:57:50] YuviPanda: you have context though that's what i'm saying! [18:57:51] if we can make that Awesomer, hey bonus [18:57:54] just look at the link before :) [18:57:57] jdlrobson: from your memory! [18:58:02] also relevant xkcd http://xkcd.com/214/ [18:58:05] but yeah we might want to scale back immediate work and do more experiments later :D [18:58:20] anyway you're talking to a person who rarely uses browser history [18:58:38] indeed, and we should also shut down all non-english wikipedias :P [18:58:40] * yuvipanda runs away [18:58:46] and when i do i'm literally just there to find the website of something i've forgotten and for that the name is the only important thing [18:58:48] oh i use browser history all the time -- just not in a big list [18:58:54] i search it in the firefox AwesomeBar [18:59:23] brion: actually that's an interesting idea - somehow combining it with search [18:59:25] brion: we should probably do that too. [18:59:29] mmmmmmmm yes [18:59:34] i think there's some possibilities here :D [18:59:36] 'you viewed this 5 days ago' [18:59:43] brion: although i'm not sure how to display it properly, since all you have is half a screen to display search results [18:59:57] a dedicated page might be heavy weight as you have to find somewhere in the ui to put it [19:00:04] "why the hell is XYZ on my watch list?" is a question i sometimes want answered :D [19:00:06] jdlrobson: sorry in a meeting i'll talk more later [19:00:09] brion: will there be click tracking in the app? I'd be interested to know how popular features are [19:00:25] yes we plan eventloggig on feature usage [19:00:27] jdlrobson: yup, there will be [19:00:32] we're not gonna fly totally blind this time :D [19:00:39] brion: that's a compelling usecase yes [19:00:39] yeshhh [19:00:42] I hope to god that Saved pages aren't used that much so we can kill that goddamn thing with FIRE [19:00:51] lol [19:01:16] brion: i sometimes wonder how things got on my watchlist [19:01:21] brion: YuviPanda: updated. changed mind about isSaved flag. https://gist.github.com/montehurd/7663582 [19:01:25] that seems somewhat different to browser history though [19:01:53] mhurd: wah, more tables :D [19:02:01] YuviPanda: i was looking at the xkcd a couple of days ago [19:02:05] YuviPanda: tables are your friend! [19:02:10] mhurd: hmm, i'd put last scroll location in the history and saved contexts [19:02:11] wait till you see the awesomeness i've been working on - you're going to love it [19:02:17] we also need a good representation for scroll position [19:02:21] mhurd: did you see mine? https://dpaste.de/OIOc [19:02:32] section, relative position within section, maybe ..... which paragraph is on top... [19:02:34] brion: mhurd yeah, we can't simply use 'pixels from top of document', since orientation [19:02:51] brion: number of paragraphs from closest section to the top? [19:03:01] mm wheres jgonera i need him [19:03:07] yeah that might work [19:03:08] or... [19:03:14] it's ju ju o clock he should be here ;-) [19:03:19] if we know what link was clicked, we can center you back on that link somehow? [19:03:24] brion: but if you, say, back up to a previous article, the scroll position is of the entire article, not section. [19:03:34] brion: what's the easiest way to setup captcha with one captcha? [19:03:43] brion: https://bugzilla.wikimedia.org/show_bug.cgi?id=51482 < need to help this volunteer out [19:03:57] YuviPanda: looking... [19:04:13] mhurd: what happens when you go forward, change orientation, then go back? the old 'scroll position' is now useless :D [19:04:22] jdlrobson: using FancyCaptcha .... uh, hope the documentation is reasonable, try to follow it, and run the python script to create captcha images with appropriate option to create just one [19:04:24] jdlrobson: i just saw the ju! [19:04:33] he's having issues generating the pngs brion [19:04:39] bleah [19:04:48] is there a way he can just add a dummy png and a single message that is always the captcha? [19:04:49] YuviPanda: store position as percent not pixel [19:04:57] YuviPanda: maybe? [19:05:01] mhurd: tried it :P [19:05:03] doesn't wo rk [19:05:12] (03PS8) 10Dr0ptp4kt: New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [19:05:35] mhurd: I also tried scaling it by width of the view at point of loading, but that also doesn't work [19:05:38] jdlrobson: yeah you can probably do that, offhand not sure what the appropriate identifiers/filenames would be though [19:05:44] YuviPanda: ? i've done this before. worked fine unless i'm thinking about something different [19:05:47] mhurd: some elements take more or less space because of linebreaking etc [19:05:51] ^^^^^yurik, that's the general nature of less. i removed some stuff that didn't look necessary, but if there's some magic happening, feel free to add stuff back in. [19:05:54] dr0ptp4kt, i think we should make that page identical to javascript one [19:05:56] violetto1: can you poke ju ju i need his captcha knowledge i think he has sset this up [19:06:21] jdlrobson: he's in the kitchen im still in meeting [19:06:22]