[00:04:26] siebrand's patch changing "Articles" to "Content pages" kind of broke the design on the mobile watchlist [00:05:11] (03PS11) 10Yurik: New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 [00:06:20] (03CR) 10Yurik: [C: 031] New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [00:06:27] dr0ptp4kt, feel free to +2 [00:08:22] hey yurik whats up [00:08:45] jdlrobson, was wondering if you know an easy way to disable
[00:08:50] from being incloded [00:09:00] the div with class header? [00:09:15] eg. with search and hamburger icon? [00:09:57] (03CR) 10Dr0ptp4kt: [C: 032] New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [00:10:05] ^yurik, i +2'd [00:10:06] (03Merged) 10jenkins-bot: New warning page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/90881 (owner: 10Yurik) [00:10:32] dr0ptp4kt, thx [00:10:38] jdlrobson, the like i sent to max above [00:10:52] that page shows an empty gray header [00:10:55] yurik: link? [00:11:06] http://api.beta.wmflabs.org/w/index.php?title=Special:ZeroRatedMobileAccess&from=Main_Page&to=https://lists.wikimedia.org/mailman/listinfo/mediawiki-announce&X-CS=250-99 [00:11:15] make sure you browse as moblie [00:11:24] (user-agent=android) [00:12:03] yurik: it's because it's a special page [00:12:30] jdlrobson, i know - i am generating it. The question is if i can somehow supress outputing that div [00:12:55] yurik: shouldn't it have a header? just playing devils advocate.. e.g. a header saying "Leaving Wikipedia Zero" [00:13:08] as that would be a lot easier [00:13:09] we could ... [00:13:14] hehe [00:13:22] otherwise the best way is probably to add a stylesheet to this page only [00:13:27] "Leaving so soon?" [00:13:32] using addModuleStyles - but seems very heavy weight [00:13:35] yurik: +1 i like that [00:13:54] yurik: might be worth chatting to violetto or kaity about the design [00:13:58] heh, yeah, that's how dr0ptp4kt implemented it, but i don't like doing it in CSS [00:14:12] or vbamba [00:14:15] hehe, ok, will postpone it for now i think - not urgent really [00:14:27] yurik: yeh i know - css wouldn't be ideal here [00:14:39] yurik: so actually there might be one other way.. [00:14:55] if you can check you are in the mobile skin... [00:15:10] jdlrobson, how would i set text in that box btw? [00:15:22] in case we decide to put something there :) [00:15:23] yurik: it's just setPageTitle i thonk [00:15:52] heh, maybe i will add another message like "Leaving Wikipedia..." [00:16:02] dr0ptp4kt, what do you think? [00:16:27] we would add it to both the backend and the jscript warning screens [00:17:25] actually yurik try $out->setProperty( 'mobile.htmlHeader' ,''); [00:17:27] yurik, i think that's a great idea. jdlrobson, good thinking. it's like the navigation controller in iOS. mhurd, "navigation controllers are good, right?" "right." [00:17:58] but yeh i prefer the Leaving Wikipedia header - if you want to use that try $out->setPageTitle [00:18:15] dr0ptp4kt: hehe [00:18:16] dr0ptp4kt, which do you prefer - minimalist or with the header? [00:18:45] mhurd: yuvipanda For the browser history, we decided to just go with the design as it is now [00:18:51] yurik: semantically i think a heading is better [00:18:53] kaity: why [00:19:11] jdlrobson, what about "you are about to view an image which is not free"? [00:19:13] we'll come back to adding context for sure, we just need to work on it a bit more [00:19:13] kaity: k. can always update later [00:19:20] "Charges warning..."? [00:19:30] "Free no more..." [00:19:41] "Free lunch has ended..." [00:19:42] kaity: well, I'll build it in anyway, have that built out. we can tweak the visuals later. [00:19:49] haha ok [00:19:53] yurik, i'm indifferent [00:20:18] OH one thing was: if you tap on an item in your history, it could go to the section within that article that you were last reading [00:21:21] (03CR) 10JGonera: [C: 04-1] "This just doesn't look right... I don't think it's a change that can be made so lightly. From what I heard we will probably work on this i" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 (owner: 10Jdlrobson) [00:21:35] kaity: :) [00:22:24] (03CR) 10Jdlrobson: Stop flash of last modified bar (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96081 (owner: 10Jdlrobson) [00:22:27] jgonera> jdlrobson, do you want me to move decodeURIComponent to L58 instead? [00:22:28] in https://gerrit.wikimedia.org/r/#/c/97828/1/javascripts/modules/mediaViewer.js [00:25:52] (03CR) 10JGonera: [C: 04-1] "I did this, exactly the same behaviour on master and with this patch - a toast saying "You are not allowed to edit this page."" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 (owner: 10Jdlrobson) [00:27:30] (03PS2) 10Jdlrobson: Stop flash of last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96081 [00:27:32] (03CR) 10JGonera: [C: 032] BF: Hide nearby button on VE mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97770 (owner: 10Jdlrobson) [00:27:38] jgonera: hang on i'll get to that in a bit :) [00:29:08] (03Merged) 10jenkins-bot: BF: Hide nearby button on VE mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97770 (owner: 10Jdlrobson) [00:29:48] (03CR) 10Jdlrobson: Redirect action=history links to mobile view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 (owner: 10Jdlrobson) [00:30:36] (03CR) 10JGonera: [C: 032] Hygiene: Fix references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97143 (owner: 10Jdlrobson) [00:31:13] (03Merged) 10jenkins-bot: Hygiene: Fix references [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97143 (owner: 10Jdlrobson) [00:31:26] yuvipanda, is the parsoid server being accessed by client-side code? or is that all server-side mediated? [00:31:41] yurik: "Show me the money!" ;-) [00:31:52] hey dr0ptp4kt [00:31:54] dr0ptp4kt: we don't know yet [00:31:56] dr0ptp4kt: sorry I didn't reply to that yet [00:32:18] jdlrobson, hehe [00:32:19] yuvipanda, i know which irc channel you frequent ;) [00:32:19] dr0ptp4kt: it's just... there. We have to investigate using it, and then see if we want to use it. [00:32:19] dr0ptp4kt: nothing's gonna change for the next 4-6 months, so don't worry :) [00:32:19] I'll let you know if that changes [00:32:25] dr0ptp4kt: :D [00:32:31] jgonera: I think it should be moved into the route [00:32:48] e.g. M.router.route( /^image\/(.+)$/, function( hrefPart ) { [00:33:04] new ImageOverlay({ title: decodeURIComponent [00:33:12] as that's /why/ you need to decode it.. [00:34:29] yuvipanda, i guess if it gets a production ip address it should just be added to the text load balancer. i'm gonna send you a url for what we have. [00:35:34] (03PS1) 10Jdlrobson: Regression: Fix nearby pages overlay page list styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97867 [00:36:17] (03CR) 10Jdlrobson: Fix media viewer for images with unicode characters (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97828 (owner: 10JGonera) [00:37:13] jdlrobson, ok, makes sense [00:37:58] (03PS5) 10Jdlrobson: Hygiene: Remove title exists check on Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97145 [00:38:32] (03CR) 10Jdlrobson: [C: 032] "rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97145 (owner: 10Jdlrobson) [00:39:19] (03Merged) 10jenkins-bot: Hygiene: Remove title exists check on Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97145 (owner: 10Jdlrobson) [00:42:21] (03CR) 10Jdlrobson: [C: 04-1] "This is not the solution you are looking for" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97867 (owner: 10Jdlrobson) [00:42:31] (03Abandoned) 10Jdlrobson: Regression: Fix nearby pages overlay page list styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97867 (owner: 10Jdlrobson) [00:42:47] (03PS2) 10JGonera: Fix media viewer for images with unicode characters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97828 [00:43:54] (03CR) 10JGonera: [C: 032] Redirect action=history links to mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 (owner: 10Jdlrobson) [00:44:08] jdlrobson, jgonera, MaxSem, tfinc anything you need from me before i head out? [00:44:16] awjr: i'm good [00:44:32] (03Merged) 10jenkins-bot: Redirect action=history links to mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/95562 (owner: 10Jdlrobson) [00:44:32] awjr, https://gerrit.wikimedia.org/r/97783 :) [00:44:44] @_@ [00:45:03] MaxSem: i can't promise i'll get through it but i'll try [00:46:29] (03CR) 10JGonera: [C: 04-1] "Feel free to merge after fixing." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96081 (owner: 10Jdlrobson) [00:48:09] oh it's not so bad MaxSem, i should be able to get through this now [00:51:53] (03PS1) 10Jdlrobson: Remove pagelist overlay styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97869 [00:51:54] (03PS1) 10Jdlrobson: Don't show the existing page in list of results of nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97870 [00:55:32] (03PS1) 10MaxSem: WIP: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [00:55:48] (03PS3) 10Jdlrobson: Stop flash of last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96081 [00:56:15] (03CR) 10Jdlrobson: [C: 032] Stop flash of last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96081 (owner: 10Jdlrobson) [00:56:29] (03PS3) 10Jdlrobson: Make last modified bar green until page is >= 24 hours [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96082 [00:56:51] (03CR) 10Jdlrobson: [C: 032] "rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96082 (owner: 10Jdlrobson) [00:57:11] i wish there were a better way to do db-related stuff with mw phpunit tests [00:57:57] (03Merged) 10jenkins-bot: Stop flash of last modified bar [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96081 (owner: 10Jdlrobson) [00:58:45] MaxSem: https://gerrit.wikimedia.org/r/#/c/97783/2 is related to that api bug right? [00:58:53] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1442 [00:59:27] i mean i know it doesnt solve it but it was work to be done first? [00:59:36] awjr, yep - I need a testing infrastructure first [00:59:41] (03Merged) 10jenkins-bot: Make last modified bar green until page is >= 24 hours [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96082 (owner: 10Jdlrobson) [01:00:01] (03PS3) 10Awjrichards: Basic mobileview test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97783 (owner: 10MaxSem) [01:00:08] (03CR) 10Awjrichards: [C: 032] Hygiene: Basic mobileview test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97783 (owner: 10MaxSem) [01:00:09] (03PS2) 10Jdlrobson: Style errors on profile better [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96163 [01:00:15] there you go MaxSem :) [01:00:23] thanks a lot, awjr [01:00:25] ok im out - have a great thanksiginv everyone [01:00:29] see you next week! [01:02:48] (03PS2) 10Jdlrobson: Limit pagelist overlay styles to search in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97869 [01:04:03] (03Merged) 10jenkins-bot: Hygiene: Basic mobileview test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97783 (owner: 10MaxSem) [01:05:43] (03CR) 10JGonera: [C: 04-1] "I don't quite understand what is the difference between Special:RecentChanges and Special:Contributions on mobile... Also, why does Specia" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [01:11:07] (03CR) 10JGonera: [C: 032] Don't show the existing page in list of results of nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97870 (owner: 10Jdlrobson) [01:11:16] (03CR) 10Jdlrobson: "Special:RecentChanges is a history feed for ALL pages. It therefore redirects to Special:History" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [01:11:28] brb [01:17:46] (03PS1) 10JGonera: Story 1408: Resolve Edit Tutorial A/B Test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97872 [01:18:38] tfinc: climb climb climby climb? [01:20:18] kaity, one question regarding https://www.dropbox.com/s/s0lzlo5oeyyabmf/language-overlay-01.png - why is the left margin for list istems bigger than left margin for the input field? [03:37:15] (03CR) 10Tholam: Add refresh functionality on fancycaptcha for mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97854 (owner: 10Tholam) [03:40:22] (03PS5) 10Tholam: Add refresh functionality on fancycaptcha for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97854 [10:42:25] (03CR) 10Zfilipin: [C: 04-1] "Just a couple of changes in one file and this is done! :)" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97765 (owner: 10Mayankmadan) [11:25:18] (03PS2) 10Mayankmadan: Prefer double-quoted strings in Ruby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97765 [11:36:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96163 (owner: 10Jdlrobson) [12:00:48] (03PS1) 10Yuvipanda: Fix spacing for NewWikiPageNavigationEvent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/97905 [12:11:49] (03PS3) 10Zfilipin: Prefer double-quoted strings in Ruby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97765 (owner: 10Mayankmadan) [12:12:33] (03CR) 10Zfilipin: "Added QA to the commit message as suggested by Jdlrobson[1]" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97765 (owner: 10Mayankmadan) [12:12:50] (03PS5) 10Zfilipin: browsertests: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [12:12:57] (03CR) 10Zfilipin: "Added QA to the commit message as suggested by Jdlrobson[1]" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [12:13:23] (03PS5) 10Zfilipin: WIP QA: Basic tests for Nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92018 (owner: 10Jdlrobson) [12:13:35] (03CR) 10Zfilipin: "Added QA to the commit message as suggested by Jdlrobson[1]" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92018 (owner: 10Jdlrobson) [12:55:32] (03CR) 10Zfilipin: [C: 031] QA: prefer double-quoted strings in Ruby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97765 (owner: 10Mayankmadan) [15:25:03] (03PS1) 10Yuvipanda: Addes HistoryEntry object and related tests. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/97920 [15:55:29] (03CR) 10Kaldari: [C: 04-1] "I'm not really sure I agree that this should be a 404 error, but regardless, the page still needs to have some WMF branding. See https://e" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96163 (owner: 10Jdlrobson) [16:05:11] (03CR) 10Kaldari: [C: 032] Desktop: Add Vector specific Special:Nearby tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97142 (owner: 10Jdlrobson) [16:07:40] (03Merged) 10jenkins-bot: Desktop: Add Vector specific Special:Nearby tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97142 (owner: 10Jdlrobson) [16:25:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix spacing for NewWikiPageNavigationEvent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/97905 (owner: 10Yuvipanda) [16:30:40] (03CR) 10Brion VIBBER: Addes HistoryEntry object and related tests. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/97920 (owner: 10Yuvipanda) [16:31:29] (03CR) 10Yuvipanda: Addes HistoryEntry object and related tests. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/97920 (owner: 10Yuvipanda) [16:38:21] (03CR) 10Jhall: [C: 031] QA: prefer double-quoted strings in Ruby code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97765 (owner: 10Mayankmadan) [17:34:35] (03PS2) 10MaxSem: Always remove headings if requested [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97080 [17:41:56] YuviPanda, review ^^^ ? :) [17:43:08] MaxSem: I don't think I know enough about that code to be able to do that :( [17:43:14] MaxSem: who usually merges your php patches? [17:43:32] Arthur (on vacation) or Ryan (ill) [17:44:10] since you have PHP dev aspirations, a good chance for you:D [17:44:47] MaxSem: :P I will, but currently debating an ops thing with... ops :P [17:45:07] MaxSem: trying to get one of my (and analytics') pet project not vetoed. [17:45:16] MaxSem: I'll take a look after that if possible, but dunno if I can do that today [17:45:24] MaxSem: also kaldari did a bunch of merges a few hours ago :P [18:16:09] YuviPanda: poke poke [18:16:16] brion: dammit [18:16:21] brion: moment [18:26:16] dammit, wikiplague reaches Russia [18:26:24] * MaxSem dives into hot bathtub [18:27:05] jdlrobson, there's a layout bug in the watchlist after siebrand changed "Articles" to "Content pages", but I'm not sure if we want to fix it if we will work on a new layout there in the next iteration [18:27:55] oohhh dears [18:28:06] jgonera: when did this get merged? [18:28:49] jgonera: has it hit any servers yet? [18:28:58] we should revert the change in the meantime [18:29:01] brion: Hey can you send me the link for the multimedia roundtable hangout? [18:29:18] kenanwang: PMd it to ya [18:29:25] coo [18:29:26] jgonera: i'll prepare a patch now [18:29:29] dr0ptp4kt: dr0ptp4kt: this talks about it a bit: http://blackpixel.com/blog/2012/05/caching-and-nsurlconnection.html [18:29:39] jdlrobson, no idea, you can probably do git blame ...i18n... | grep "Content pages" [18:29:52] mhurd, thx [18:31:55] * jgonera goes to bed [18:33:17] doh [18:33:18] (03PS1) 10Jdlrobson: i18n: Revert watchlist damage caused by two word tab name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97935 [18:34:17] (03PS2) 10Jdlrobson: Don't show the existing page in list of results of nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97870 [18:34:22] (03CR) 10Jdlrobson: [C: 032] Don't show the existing page in list of results of nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97870 (owner: 10Jdlrobson) [18:35:44] (03Merged) 10jenkins-bot: Don't show the existing page in list of results of nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97870 (owner: 10Jdlrobson) [18:37:09] MaxSem: do you still need a reviewer for https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1442 ? [18:37:55] (03CR) 10Jdlrobson: "This should be merged before we get on the deployment train as the watchlist view now looks very broken (there is word wrap on these tabs!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97935 (owner: 10Jdlrobson) [18:39:04] (03CR) 10Jdlrobson: "This causes a rather ugly regression on the watchlist view." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96747 (owner: 10Siebrand) [18:40:14] (03CR) 10Jdlrobson: "huh? The 404 error page is provided by the website hosting the website - MobileFrontend shouldn't provide a default...." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96163 (owner: 10Jdlrobson) [18:40:53] (03CR) 10Jdlrobson: "If you don't agree this should be a 404 what would you suggest instead?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96163 (owner: 10Jdlrobson) [18:43:06] (03CR) 10Siebrand: "This should not be a permanent solution. See motivation inline." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97935 (owner: 10Jdlrobson) [18:45:59] (03CR) 10Jdlrobson: i18n: Revert watchlist damage caused by two word tab name (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97935 (owner: 10Jdlrobson) [18:46:18] * YuviPanda waves at brion [18:46:33] yo yo YuviPanda [18:46:55] (03CR) 10Jdlrobson: "and yes this patch in existing form doesn't need to be a permanent solution." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97935 (owner: 10Jdlrobson) [18:47:41] brion: so I'm going to use contenthandler for all db things [18:47:44] brion: objections? [18:47:57] (03CR) 10Jdlrobson: [C: 032] Fix media viewer for images with unicode characters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97828 (owner: 10JGonera) [18:47:59] YuviPanda: that feels fairly android :) [18:48:03] *androidy [18:48:24] brion: sweset [18:48:27] gonna use something to wrap the SQL table def generation, or just stick with the method we used on commons? (it's probably good enough) [18:48:33] (03Merged) 10jenkins-bot: Fix media viewer for images with unicode characters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97828 (owner: 10JGonera) [18:48:34] brion: same thing. [18:48:43] brion: that's androidy enough and i bet we don't change it enough [18:49:13] hehe yeah [18:58:29] (03PS1) 10Jdlrobson: Hack: Add hack so modules that use mw.Api can work on mobile in limited form [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97940 [19:02:31] tfinc, yes [19:02:47] MaxSem: pass me the CR link [19:03:08] tfinc, https://gerrit.wikimedia.org/r/#/c/97080/ [19:03:23] MaxSem: also needs fix for the sections= thing [19:03:24] brion: can you help review the above CR --^ ? [19:03:47] looking [19:04:11] YuviPanda, yep - I was first blocked on tests then would like the above merged first to avoid conflicts [19:04:17] okay! [19:06:13] (03CR) 10Brion VIBBER: "The description in the commit message doesn't seem to match the description of bug 57402; what exactly is this meant to do?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97080 (owner: 10MaxSem) [19:06:52] (03CR) 10MaxSem: "Yep - edit links are part of headings;)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97080 (owner: 10MaxSem) [19:06:59] brion, ^ [19:07:35] MaxSem: i don't understand [19:07:54] does this patch remove the edit link from the text of the section? or remove the section heading entirely when not asked for it? or something else? [19:08:16] brion, Yuvi noticed that edit links are presentm however other parts of heaing HTML was also there:) [19:13:30] MaxSem: do you have any views on https://bugzilla.wikimedia.org/show_bug.cgi?id=57091 ? [19:13:44] i'm not sure if you caught up with the phantom language problem on mobile [19:16:29] jdlrobson, make ULS STFU on mobile? [19:16:37] (03PS2) 10Jdlrobson: Hack: Add hack so modules that use mw.Api can work on mobile in limited form [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97940 [19:16:47] MaxSem: it's Wikibase as well [19:16:59] both extensions add items to the list of languages which are not languages [19:17:07] meaning the "Read in another language" section shows up on mobile [19:17:10] but is an empty list. [19:17:16] we have a couple of hacks to delete those nodes [19:19:11] jdlrobson, we should not use #p-lang if it has different semantics for us [19:21:33] hmm, but it's not set by JS [19:23:40] funnily, my 2 least liked MW extensions are messing with it:P [19:25:41] a crappy solution would be to filter non-standard links out [19:32:13] jdlrobson, mebbe hide with CSS? [19:35:07] kenanwang: i need to be out by 2 so i'm removing our 3-4. happy to chat about anything after the multimedia round table is over [19:35:23] brion: when's the multimedia roundtable? and is it happening in person or on IRC? [19:35:55] YuviPanda: been going for an hour and a half. combination of in person and hangout [19:36:02] brion: ah, alright then [19:41:50] ok yeah there was something I wanted to chat with you about tfinc trying to recall what it was [19:42:04] MaxSem: not possible in current form - whole thing would need a serious rethink [19:42:49] why? [19:43:06] get wikidata work on mobile, kill ULS:P [19:43:40] YuviPanda: there is another one next week [19:44:01] brion: let me know if you can't finish up the review for max [19:44:19] ah lemme test it real quick, got distracted back by the media stuff [19:44:44] brion: omg core data is great [19:44:56] mhurd: seriously! it's awesome [19:45:25] mhurd: brion you kids and your fancy toys! [19:45:28] hmpf! :P [19:51:03] brion: YuviPanda core data + me = http://i.imgur.com/j74SykU.gif [19:51:12] heh :D [19:51:32] (03CR) 10Brion VIBBER: [C: 04-1] "This seems to fix the problem that 'noheadings' didn't work, but doesn't fix the problem that you get edit links if you do ask for heading" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97080 (owner: 10MaxSem) [19:53:09] MaxSem, YuviPanda: am I just being mislead by the bug title? [19:53:24] does this fix the bug, but the bug is described as something more specific than what y'all were trying to fix? [19:53:25] brion: what you identified is an issue too, that shouldn't be doing that [19:53:47] brion: it fixes the part of the bug that affects me, I think [19:53:50] brion, here's Yuvi's request: get wikidata work on mobile [19:53:57] grr [19:53:59] https://dpaste.de/4rYq/raw [19:54:06] paste fail [19:54:18] :) [19:54:32] MaxSem: YuviPanda : ok let's update the bug summary and make a separate bug about the other issue [19:54:35] and i'll +2 this one :D [19:55:34] (03CR) 10Brion VIBBER: [C: 032] "Ok per IRC discussion, the bug is kind of oddly labeled which was throwing me off. This does fix the actual problem at hand, which was tha" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97080 (owner: 10MaxSem) [19:55:54] tfinc: ok we got that one resolved \o/ [19:56:13] thanks brion:) [19:56:14] thanks brion. YuviPanda kenanwang --^ [19:56:14] (03Merged) 10jenkins-bot: Always remove headings if requested [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97080 (owner: 10MaxSem) [19:57:28] MaxSem: ty :) prop=sections now :D [19:57:49] you mean prop=requestedsections?:P [19:58:27] or a flag parameter would make more sense? [19:58:41] MaxSem: a flag, perhaps [19:58:45] onlyrequested [19:58:50] onlyrequestedsections [19:58:55] cool [20:00:23] (03PS4) 10Jdlrobson: Enable editing on fishbowl wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 [20:01:13] mtg anyone? [20:03:11] running to lunch - back@1 [20:04:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Let's merge this for now :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/97920 (owner: 10Yuvipanda) [20:05:53] ok gonna head downtown and check in with monte :D [20:15:33] when viewing a diff on mobile watchlist, i often tap on the link to autopatroller or rollback or whatever. [20:16:02] that's never my intention, but the links are near the username. [20:38:58] ragesoss: can you raise a bug? [20:39:45] jdlrobson: once I'm not on a mobile device, i will. [20:39:53] thanks ragesoss :D [20:41:56] rmoen: yo [20:42:08] tfinc: hey boss [20:42:20] rmoen: yuvi mailed back some good glass ideas. your turn now [20:42:32] send them on list please [20:42:32] tfinc: actually just typing up my ideas [20:42:36] perfect [20:42:38] tfinc: sitting here at O'hare [20:42:52] rmoen: you flying back from India ? [20:43:08] tfinc: London, but yeah just now getting back to the States [20:43:16] solid. welcome back [20:43:21] tfinc: ty :) [20:43:33] rmoen: I had chicken 65 today [20:43:36] tfinc: really glad to be back [20:43:48] YuviPanda: Too soon boss... too sooon.. [20:43:56] rmoen: :) :( [20:44:01] rmoen: fully recovered? [20:44:11] YuviPanda: Last bit of spice i had was too much [20:44:28] rmoen: yeah, punjabi spice. I wasn't too much of a fan of that particular place [20:45:00] YuviPanda: Yeah that place got me everytime... I won't go into detail [20:45:20] rmoen: sympathies. Don't let that put you off chicken 65 in general forever though [21:06:51] YuviPanda: Dude, next time I eat chicken65 it will hopefully be with you :) [21:07:00] rmoen: +1 :) [21:08:24] YuviPanda, tfinc: Alright, I'm about to board my flight. I'll probably surface again after the weekend. Ciao [21:08:33] rmoen: ciao! [21:39:34] damn our apple ad-hoc distribution device list is full now :( [21:39:43] hopefully it'll clear at jan 1 and not wait until february [21:40:22] brion: so I changed my mind re: reusing the same things from Commons [21:40:34] brion: writing a 'Persister' base class from which we'll have HistoryEntry persister, etc [21:40:46] brion: will be responsible for getting them to and from cursors [21:40:56] brion: I want to keep the objects as pure value objects. [21:41:56] brion: also no need to construct SQL by hand [21:42:04] ooooh [21:42:06] excellent :D [21:42:07] brion: you can return a 2D string array of (name, type) [21:42:13] \o/ [21:42:15] brion: and have it constructed for you :) [21:42:21] brion: I'm also now thinking on how to handle updates. [21:42:26] brion: Updates are usually just... additions. [21:42:33] brion: so I might just make that happen [21:42:52] :D [21:43:02] you can model updates as replacements perhaps [21:43:27] brion: so I am thinking you can give it a number and it returns a 2D array of things to be appended [21:43:36] CoreData uses stateful objects connected to a context object, which you save as a unit [21:44:05] but i do like immutable value objects :) [21:44:10] brion: that's what we did in Commons, but the fact that we need to keep giving it the context made me gah [21:44:20] brion: and I don't like tying up my immutable value objects with contexts [21:44:22] exactly :D [21:44:25] yeah [21:45:44] brion: the COLUMN_ID, COLUMN_NAME things from Commons weren't making me happy at all, so trying to kill those :) [21:45:50] \o/ [21:45:56] death to CAPITALIZED_CONSTANT_FIELDS [21:46:02] INDEED [21:46:11] Mr. I AM TOO GOOD FOR ENUMS JAVAA [21:46:56] haha [21:47:15] brion: I also set my coding font up to 14pts. EVERYTHING IS SO MUCH BETTER [21:47:20] brion: maybe I"m going old :( [21:47:36] can't you emulate enums by creating static member variables that are instances of a class wrapping the constant, so you at least get type safety? but that's just lame :D [21:47:53] hehe [21:47:57] brion: 1. ewwwww 2. THE OVERHEAD! THINK OF THE CHILDREN! [21:48:14] wrists, eyes, soon the brain goes and you get force-retired ;) [21:48:23] brion: heh [21:48:47] brion: sometimes, when I'm doing nothing (I try not to!), I think that is what'll happen and that's very depresssing [21:49:04] such is the fate of all mankind [21:49:11] indeed [21:49:31] so let's prototype some wearable computers while we're still alive! wooooooooo [21:49:38] brion: +1 [21:52:05] :D [21:52:12] maybe i should get a samsung smart watch ;) [21:53:02] brion: hah :D [21:53:09] brion: get the pebble [21:53:22] brion: nicer, less shittier, and I think much more in tune with how future wearables will be like [21:53:26] also has SDK [21:53:42] I just set IRC also to 14pt, and life's better [21:53:45] gah [21:54:27] YuviPanda: you running at the native "1440x900" HiDPI or scaled resolution? [21:54:33] brion: native [21:54:42] it's beautiful isn't it :D [21:54:50] but you might need new glasses ;) [21:54:57] brion: that. [21:55:00] probably [21:55:04] hehe [21:55:08] brion: I hate wearing glasses while at home [21:55:17] I'm in my pjs I shouldn't need glasses! [21:55:26] brion: might do Lasik a few months later. Not sure yet [21:55:47] well i've heard good things from people who've had it done [21:56:04] my vision's just good enough i can't convince myself to slice up my eyes with lasers yet [21:56:08] brion: yeah, me too. Only question is if I want to do it here or wait to move to the US [21:56:12] heh [21:56:28] well either way it'll probably be an indian doctor or tech ;) [21:56:29] brion: I'm blind for everything other than reading text on a computer, and now it looks like even that is going [21:56:47] yeah you should either wear the glasses or get the lasik ;) [21:56:54] yeah [21:58:37] grumble i gotta update my address everywhere again [21:58:43] brion: heh [21:59:18] bloody hell [21:59:32] i forgot to set up my transit card to load from pre-tax funds [21:59:43] lemme fix that in a bit [22:02:27] (03PS1) 10MaxSem: Introduce new mobileview parameter, onlyrequestedsections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98006 [22:02:28] YuviPanda, ^^^ [22:06:14] (03CR) 10Jdlrobson: [C: 04-1] "Marked as a WIP so -1ing" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 (owner: 10MaxSem) [22:06:55] MaxSem: ugly indeed [22:07:42] (03CR) 10Yuvipanda: [C: 031] "Looks good to me but haven't tested." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98006 (owner: 10MaxSem) [22:08:14] brion: I'm getting sucked in. Considering creating a 'Column' object now [22:08:18] but I think I'll resist [22:08:27] or should I? [22:08:29] * YuviPanda considers [22:11:30] (03CR) 10MaxSem: WIP: Inline diffs (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 (owner: 10MaxSem) [22:14:09] YuviPanda: what would it look like? (Column) [22:14:26] brion: so far? type and name. Might add a primary key field [22:14:40] brion: used only for constructing scemas [22:14:44] I'm conflicted [22:15:04] * brion whispers "descriptions and foreign keys" :D [22:15:54] brion: heh :D [22:15:57] we can add those later [22:16:02] okay Column class it is [22:16:13] :D [22:16:53] brion: no way to add an array into an arraylist [22:16:55] grrrJava [22:17:22] lol [22:17:31] arrays suck, just don't use them ever [22:18:01] brion: they're the only thing with literal syntax, and I'm *not* going to write x.add(new Column(x, y)) [22:18:26] you could use a java source preprocessor ;) [22:19:11] (03PS6) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 [22:27:56] (03CR) 10Jdlrobson: Add all logic for edit profile pages in JavaScript (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96681 (owner: 10Jdlrobson) [22:28:01] (03PS5) 10Jdlrobson: Add all logic for edit profile pages in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96681 [22:30:48] (03CR) 10Jdlrobson: [C: 032] Story 1408: Resolve Edit Tutorial A/B Test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97872 (owner: 10JGonera) [22:31:07] rmoen|away: what's the status of VE in mobile? [22:31:24] (03Merged) 10jenkins-bot: Story 1408: Resolve Edit Tutorial A/B Test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97872 (owner: 10JGonera) [22:32:26] jdlrobson: rmoen|away is in a flight apparently [22:32:33] booo hoo [22:37:07] brion: re: 'java source preprocessor', http://kotlin.jetbrains.org/ [22:37:59] heh nice [22:38:49] brion: it's from the same guys who make IntelliJ [22:41:44] (03CR) 10JGonera: [C: 032] Hack: Add hack so modules that use mw.Api can work on mobile in limited form [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97940 (owner: 10Jdlrobson) [22:42:19] (03Merged) 10jenkins-bot: Hack: Add hack so modules that use mw.Api can work on mobile in limited form [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97940 (owner: 10Jdlrobson) [22:43:03] (03CR) 10JGonera: [C: 032] "Siebrand, we will be redesigning watchlist soon, so this should get fixed then." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97935 (owner: 10Jdlrobson) [22:43:38] jgonera: i just realized that hack might be too brute force.. [22:43:39] (03Merged) 10jenkins-bot: i18n: Revert watchlist damage caused by two word tab name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97935 (owner: 10Jdlrobson) [22:43:59] (03CR) 10JGonera: [C: 032] Limit pagelist overlay styles to search in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97869 (owner: 10Jdlrobson) [22:43:59] jgonera: i should only hijack it if it is undefined [22:44:08] mw.Api? [22:44:19] (03CR) 10Hashar: "@JGonera that is still a work in progress. There are still some scenario which are not passing on a freshly installed wiki (i.e. with no " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [22:44:33] (03Merged) 10jenkins-bot: Limit pagelist overlay styles to search in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97869 (owner: 10Jdlrobson) [22:44:50] it's temporary anyway, I don't think mw.Api will be defined on mobile in any case until we fix this bug [22:44:58] kaity, are you in the office? [22:45:09] yes i am jgonera [22:45:29] no, you are kaity! [22:45:40] haha [22:45:50] yes i am, YuviPanda [22:45:51] jgonera: kaity is [22:45:56] :D [22:46:02] jgonera: i just realized though this could fuck with desktop since nearby loads there [22:46:12] can we move the profiles thing a little bit? I'll go to the office now for to get my work laptop so I should get there by 3.30 [22:46:24] jdlrobson, oh... [22:46:30] (03PS1) 10Jdlrobson: Conditionally hack mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98017 [22:46:30] ^ jgonera [22:46:32] make a followup [22:46:57] (03CR) 10JGonera: [C: 032] Conditionally hack mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98017 (owner: 10Jdlrobson) [22:47:31] kaity, ^ [22:47:51] (03Merged) 10jenkins-bot: Conditionally hack mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98017 (owner: 10Jdlrobson) [22:47:57] jgonera: we could also do it monday [22:48:49] whatever you prefer, I want to get my laptop just in case anyway [22:49:09] jgonera: how are you feeling? [22:49:31] jdlrobson, better, I took aspirin and vit C in the morning and I feel mostly OK [22:49:36] garlic? [22:50:05] haha, that too, yesterday night when I felt something was coming up [22:50:41] ok yes lets do monday [22:50:45] jgonera: [22:51:14] (03PS3) 10Jdlrobson: Remove infobox experiment from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96397 [22:58:11] (03PS2) 10MaxSem: WIP: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [22:59:04] jdlrobson, http://staging.wmflabs.org/wiki/Special:MobileDiff/12116...12146?useformat=mobile [23:09:08] (03PS1) 10Jdlrobson: Click tracking on Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98023 [23:10:34] (03CR) 10Jdlrobson: [C: 04-1] "We might be able to do this without using EventLogging so -1ing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98023 (owner: 10Jdlrobson) [23:11:16] MaxSem: the JavaScript is still running :) [23:11:47] not if you disable beta [23:11:49] MaxSem: also the result is different from what the JavaScript does - but I guess you know that? :) [23:12:52] my diff shows context [23:13:12] MaxSem: but that is inconsistent with the story [23:13:35] (or the story is unclear) [23:14:05] depends how a paragraph is defined [23:15:15] then the story has to be fixed, lack of context is a severe problem to readability of diff [23:17:06] btw, the JS diff also contradicts the story;) [23:26:12] (03PS2) 10Jdlrobson: Click tracking on Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98023 [23:26:23] (03CR) 10Jdlrobson: [C: 04-1] Click tracking on Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98023 (owner: 10Jdlrobson)