[09:32:37] (03PS2) 10Yurik: Zero Config cleanup [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98480 [10:36:14] (03CR) 10Siebrand: Added a welcome message at the top of the landing page. (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [10:38:57] (03PS2) 10Yurik: Added a welcome message at the top of the landing page. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 [11:54:48] (03CR) 10Siebrand: [C: 04-1] Added a welcome message at the top of the landing page. (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [12:25:24] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [12:29:36] (03CR) 10Siebrand: Story 1218: Allow users to modify their UserProfile intro (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93018 (owner: 10Kaldari) [12:32:39] (03CR) 10Siebrand: "Was merged with i18n issue." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94434 (owner: 10Jdlrobson) [12:53:53] (03PS1) 10Lut4rp: Added a gitignore file. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98506 [13:12:27] (03PS3) 10Yurik: Added a welcome message at the top of the landing page. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 [13:56:42] (03CR) 10Siebrand: [C: 031] "L10n/i18n reviewed." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [15:07:09] awjr: are you around? [15:53:36] chrismcmahon, maybe I can help you? [15:54:24] hi MaxSem thanks, nope, just a general question for awjr [16:00:21] (03CR) 10MaxSem: [C: 04-1] Added a welcome message at the top of the landing page. (032 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [16:15:50] (03CR) 10MaxSem: "These messages are also present in ZeroConfig.i18n.php - need to be nuked too." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98481 (owner: 10Yurik) [16:26:32] (03CR) 10Hashar: [C: 04-1] "Waiting for similar change against ULS to be merged in https://gerrit.wikimedia.org/r/#/c/97487/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [16:36:04] (03CR) 10MaxSem: [C: 04-1] Fix getErrorMessage() (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97703 (owner: 10Shirayuki) [16:41:40] (03PS1) 10MaxSem: Avoid HTTP redirects in links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98539 [16:46:32] (03CR) 10Zfilipin: "Chris, Jeff, please merge this into master if you do not have any complains." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97765 (owner: 10Mayankmadan) [16:53:30] (03CR) 10Siebrand: [C: 04-1] Added a welcome message at the top of the landing page. (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [17:25:08] (03CR) 10Yuvipanda: [C: 032 V: 032] "Thanks for the patch!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98506 (owner: 10Lut4rp) [17:50:12] (03CR) 10Jdlrobson: [C: 032] Avoid HTTP redirects in links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98539 (owner: 10MaxSem) [17:50:53] (03Merged) 10jenkins-bot: Avoid HTTP redirects in links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98539 (owner: 10MaxSem) [18:16:35] chrismcmahon: hihi [18:16:43] im around now [18:16:52] hi awjr, one sec... [18:17:21] mhurd: you about ? [18:18:56] awjr & kaldari: https://gerrit.wikimedia.org/r/#/c/94178/ pretty please:) [18:19:13] looking [18:22:06] (03PS1) 10Siebrand: Add missing explicit GENDER parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98561 [18:22:41] MaxSem: Is this related to an API schema change in PageImages or was this just broken? [18:23:15] just broken [18:24:14] MaxSem: +2 hammer dropped [18:24:30] MaxSem: is there a bug open for that? [18:24:48] and does that need to be deployed asap? [18:25:45] no [18:25:55] but it's been waiting for almost a month [18:32:02] brion: mhurd YuviPanda : reminder that we have a prioritzation meeting @ 12 today [18:32:08] yup [18:32:10] tfinc: ya [18:32:13] hour and a half from now, IIRC [18:32:21] spiffy [18:33:21] hmmmm should i update the nexus 4 to kitkat or leave it on 4.3 [18:37:26] Have you got a Nexus 5 yet? :p [18:38:03] Reedy: yes :) [18:38:22] brion: leave it on 4.3 :) [18:38:25] brion: because chromium [18:38:37] the n5 actually solves several annoying design flaws in the n4: no "slides off your desk" glass back, you can actually tell top from bottom by hand in your pocket [18:38:44] ah yeah the different webview [18:38:55] yeah should keep a high-quality device around on 4.3 for that [18:39:17] brion: yeah [18:39:26] i'm still not sure i see the need for 1080p in a smartphone though, and I'm like "mr. retina" [18:40:03] YuviPanda: got anything in gerrit for me? i'm catching up from the weekend :D [18:40:17] brion: not yet. I've rewritten this like 3 times now :| [18:40:21] brion: currently has 3 layers of classes. ugh [18:40:24] hah [18:40:33] ok let me know if you want me to look it over [18:40:41] brion: but I"m trying to make sure that what we did in the Commons app - copypasting stuff, doesn't happen again [18:40:48] yeah [18:41:13] just don't get too lost in refactoring to the perfect form [18:41:23] brion: yeah, won't :) [18:41:28] brion: trying to make it work now :P [18:56:35] (03CR) 10JGonera: [C: 04-1] RTL beta icon for nearby (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 (owner: 10Amire80) [18:58:38] (03CR) 10JGonera: [C: 032] Add margins when floating thumbnails in mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98098 (owner: 10TheDJ) [19:01:44] (03CR) 10Amire80: "Oh." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 (owner: 10Amire80) [19:05:03] MaxSem: did you have a chance to catch up with kenan about the diff story? [19:05:10] (03Merged) 10jenkins-bot: Add margins when floating thumbnails in mobile view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98098 (owner: 10TheDJ) [19:05:11] dr0ptp4kt, ready to deploy? :) [19:05:29] awjr, we'll have a design sync hangout @11:30 [19:05:33] jdlrobson: same q for you - were you able to sync up with kenan about the bug/back behavior story? [19:05:35] yurik, ha [19:05:37] cool MaxSem [19:05:45] awjr: i setup a design sync hangout at 11.30 [19:05:51] perfect :d [19:05:52] er [19:05:53] :D [19:05:56] dr0ptp4kt, i asked for another depl window today 11-1 [19:06:35] yurik, did you get it? i'm at a lunch at 12 [19:06:42] kaldari: looks like you picked up card 1448 - did you get what you needed form kaity? [19:06:45] dr0ptp4kt, yep [19:06:51] trying to get rev flags out) [19:07:08] awjr: kaity suggested I ask Vibha about it when she gets in [19:10:15] yurik, okay, well, lemme know if you want me to do some rough functionality tests once in prod during the next 30 mins or so. [19:10:39] yurik, the mediawiki-config change may have some stipulations around modification of a dblist file - check that page on wikitech for config changes [19:10:51] dr0ptp4kt, ok, i will push our current master for now [19:10:58] and try to get db schema changed [19:12:00] (03PS1) 10Brion VIBBER: Add 'W' icon to replace black square placeholder [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98578 [19:12:01] (03PS1) 10Brion VIBBER: Use empty placeholder while loading, CTA placeholder only for known missing images [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98579 [19:13:02] dr0ptp4kt, please monitor ops [19:28:54] jdlrobson, I can haz hangout link? [19:31:40] MaxSem: i'm still waiting for kenan to show up in the office…. [19:31:55] jdlrobson, add it to calendar [19:32:07] MaxSem: i'm not sure this meeting is going to happen [19:32:12] he said he'd be in at 11 [19:32:14] :) [19:32:19] okay [19:32:28] ping me when/if... [19:32:35] will do.. i give him 5 mins [19:32:54] jdlrobson: his mobile # is on the office contact list - maybe give him a call? [19:35:17] MaxSem: link on invite [19:35:21] ken an is apparently on his way [19:35:29] thnx [19:43:21] brion: still not complete, but pushing anyway [19:43:21] (03PS1) 10Yuvipanda: WIP: Add support for getting data in and out of SQLite [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98590 [19:43:30] ok [19:43:38] brion: do take a look [19:44:11] brion: question when u have a second [19:46:02] MaxSem, can i use your review and depl skills in 10ish min? [19:46:20] sorry, I'm in a mtg [19:48:11] brion: you might like http://www.amazon.com/Seiki-Digital-SE39UY04-39-Inch-Ultra/dp/B00DOPGO2G/ [19:48:24] yurik: we have other deployers lurking around though - what's going on? [19:48:43] awjr, i' mdeploying something until 1pm [19:48:54] do we have a scheduling conflict? [19:49:35] no yurik, i was just suggesting that there are other folks lurking around who have deployment experience who may be able to help since max is busy [19:50:03] oh, sure, sorry :) [19:50:22] misread [19:50:57] np :) [19:50:58] yurik, I'm feee now [19:52:39] MaxSem, syncing zero, in about 5 min i wanted to deploy https://gerrit.wikimedia.org/r/#/c/98576/ [19:52:56] okay [19:53:12] looks trivial [19:53:27] is there anything you're worried about? [19:53:30] (03CR) 10Brion VIBBER: "Liking this so far; couple quick notes inline" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98590 (owner: 10Yuvipanda) [19:53:31] yurik, ^ [19:53:49] and Reedy said i needed to use sync-docroot, but according to the doc, i should use sync-common-file -- hence a bit confused :) [19:53:54] https://wikitech.wikimedia.org/wiki/Wikimedia_binaries#sync-docroot [19:54:04] Use either [19:54:07] Doesn't really matter [19:54:26] YuviPanda: regarding title objects losing their site identity; we could either store title+site as two columns, or have another string serialization form for titles that includes the site id [19:54:45] neither should be super hard to do [19:54:46] use one of them -> see wp broken -> use the right one:P [19:55:14] jdlrobson: where did you see the plaintext password in the jenkins/test emails? [19:55:33] all im seeing are variables for passwords but maybe im not looking in the right spot [19:56:56] Reedy, MaxSem, thx, can you +2 it pls [19:57:51] chrismcmahon: i am still seeing betalabs 503 on big articles like barack obama, which is still cauisng test failures. have you heard anything more about resolving the 503s? [19:58:24] brion: saw the multiple layers? [19:58:31] brion: helper, persister, contentprovider [19:58:41] YuviPanda: yeah i think it's starting to make sense to me :D [19:58:47] awjr: other than the thread on @engineering mail list today, no [19:58:54] :| [19:59:23] trying to decide if it's worth making any of those static inner classes or if it's easier to keep them fully separate [19:59:30] probably easier to keep em separate [19:59:39] inner classes bigger than a callback always end up confusing me :D [19:59:42] chrismcmahon: i have a feeling it's not going to get resolved quickly. is there a way we can point tests to smaller articles less likely to cause 503s, or think of another way to keep those tests from consistently failing? [20:00:50] MaxSem: maybe you can sneak that patch to deploy into the 0 deployment? [20:01:07] if yurik doesn't mind [20:01:27] * MaxSem scratches his head to recall what needed to be deployyed exactly [20:01:33] i've got a link somewhere... [20:01:50] MaxSem, sure, i'm finishing up with zero [20:02:04] need to change config though, and do db updates... :) [20:02:37] MaxSem: i think there were two patches [20:02:38] here's one: https://gerrit.wikimedia.org/r/#/c/95636/ [20:02:50] brion: where you guys at? [20:02:54] YuviPanda and i are lonely [20:03:11] i think the other one was a fix for the test from michelle [20:04:01] MaxSem: and https://gerrit.wikimedia.org/r/#/c/97744/ [20:04:40] awjr, I presume we don't need to deploy the ruby change? [20:05:01] im actually not sure how that works MaxSem; chrismcmahon would know [20:05:17] but i imagine you're right [20:06:20] brion: we do store them, don't we? [20:06:21] brion: I thought I had a site column [20:07:31] (03PS1) 10MaxSem: Strengthen .tutorial selector [extensions/MobileFrontend] (wmf5) - 10https://gerrit.wikimedia.org/r/98600 [20:07:52] Mmm, can't cherrypick for wmf4 [20:07:58] * MaxSem tries manually [20:08:19] MaxSem: yeah, no need to deploy purely test code [20:08:34] does that get applied automatically wherever it needs to when merged, chrismcmahon? [20:09:56] awjr: it does. as soon as the browser test codes gets +2 and merged, it is automatically picked up by Jenkins at run time with a git request from the MobileFrontend repo [20:10:03] cool chrismcmahon [20:10:38] awjr: that code has no use on a production server, it just gets used by Jenkins and by people using the tests locally [20:10:44] aye [20:10:52] violetto: my connection is a bit laggy. just a fy [20:10:52] i [20:12:17] violetto: noted [20:12:29] chrismcmahon: any thoughts on how we can reduce the noise generated by tests that get hit by the 503 on betalabs? [20:12:46] im not convinced the 503 issue is going to be fixed quickly [20:12:55] awjr: bah [20:13:06] brion: where are you IRCing from? [20:13:14] brion: am I so lagged? I don't see your hands on a keyboard [20:14:39] MaxSem, this patch really doesn't like me :( https://gerrit.wikimedia.org/r/#/c/97107/ [20:15:35] ask hashar? [20:16:49] holy fuck is IRC lagged [20:19:30] (03PS1) 10MaxSem: Strengthen .tutorial selector [extensions/MobileFrontend] (wmf4) - 10https://gerrit.wikimedia.org/r/98606 [20:20:04] mhurd: did kenan say somethign at the end of that ? [20:20:05] (03CR) 10MaxSem: [C: 032] Strengthen .tutorial selector [extensions/MobileFrontend] (wmf5) - 10https://gerrit.wikimedia.org/r/98600 (owner: 10MaxSem) [20:20:24] (03CR) 10MaxSem: [C: 032] Strengthen .tutorial selector [extensions/MobileFrontend] (wmf4) - 10https://gerrit.wikimedia.org/r/98606 (owner: 10MaxSem) [20:20:45] (03CR) 10MaxSem: [V: 032] Strengthen .tutorial selector [extensions/MobileFrontend] (wmf4) - 10https://gerrit.wikimedia.org/r/98606 (owner: 10MaxSem) [20:21:02] !logs [20:23:00] brion: sorry, my IRC bouncer seems to be super laggy [20:23:01] to say the least [20:23:25] brion: got your messages only when we were half way through the call, and was wondering how you managed to type without your hands on the keyboard [20:26:40] !logs [20:26:51] ok, seems less laggy now [20:26:56] I think [20:31:26] heh [20:31:46] brion: new ISP. promised us 16mbps, right now getting 2 [20:32:25] brion: which is shared among 4 people. all programmers. [20:33:59] ugh that's not cool [20:34:13] * jgonera feeling better, going to the office [20:34:49] brion: this many classes makes me feel very queasy, but can't think of any other way [20:36:03] kaity, violetto: hey do we have app icons ready for android & ios, or should I use the old ones as temp icons for now? i notice we're still on generic icons :D [20:36:30] brion: you can use what we have for now. :) [20:36:39] ok :D [20:37:10] ooh [20:37:19] i should record screencasts for our wednesday update [20:37:29] brion: should write a small script that takes svg and puts out appropriately sized things [20:37:31] link those out on the mailing list :D [20:37:32] things as in icons [20:37:38] I keep saying things, don't I [20:37:38] oh yeah we totally should [20:37:53] i'm doing that manually in inkscape right now which is lame [20:38:02] brion: yeah. imagemagick or rsvg [20:38:20] not sure i trust imagemagick with svg rendering, but it probably sucks a lot less than it did a few years ago :D [20:38:26] brion: heh. rsvg? [20:38:32] could also call imagemagick from CLI [20:38:35] er [20:38:37] *inkscape [20:38:38] brion: upload to commons, fetch sizes? :D [20:38:41] lol [20:38:49] well that saves the trouble of compiling librsvg ;) [20:38:57] brion: yeah, and also has permanent record :D [20:39:03] home-brew has librsvg though so that's easy [20:39:04] brion: +1 for commons! [20:39:09] \o/ [20:39:26] yeah until some a-hole deletes your image for being copyrighted by the foundation and not properly labeled ;) [20:40:03] brion: yeah, *that* [20:40:08] brion: we can put it on mw.org :P [20:40:11] :D [20:40:20] we know all the assholes on mw.org, unlike on commons :P [20:40:38] haha [20:41:03] oh yeah and sizes go up to xxhdpi now thanks to those 1080p phones [20:41:10] so that's a lot of repetitive resizing [20:41:23] brion: yeah. [20:41:27] (03PS1) 10Yuvipanda: Add COPYING file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98674 [20:42:07] brion: ^ trivial merge [20:42:22] brion: do it before a licensing bikeshed starts! :D [20:42:47] YuviPanda: simplest thing might be: make a script that calls rsvg or inkscape to resize a bunch of files sitting in res-source/drawable-svg/* and export them into res/drawable-*dpi/* [20:42:48] lol [20:43:04] brion: why not just have a script that takes a mediawiki url and then spits out the versions? [20:43:16] hmmmmmm that could work too [20:43:29] brion: easier to build, easier for designers, easier to maintain! [20:43:32] as long as we can just make one call to update everything [20:43:38] well [20:43:45] that puts things outside of version control....... [20:43:52] bleh [20:44:09] i want to be able to run the script a second time and get the same results reliably :) [20:44:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add COPYING file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98674 (owner: 10Yuvipanda) [20:44:42] brion: revision pinning! [20:44:51] :D [20:45:46] brion: dunno if we can get thumbs for particular revisions [20:46:11] YuviPanda: i think we can actually; have to refer by timestamp or something [20:46:14] it's slightly funky [20:46:29] but for instance in the image history you'll see thumbnails in there, so it exists :D [20:46:48] awjr|lunch, yurik - deployed [20:47:24] YuviPanda: i'm trying to think if we can make this a build step or if it'll be simpler to make it a separate script that just dumps updated files into res/drawable0* [20:47:41] man, android should just support svg directly :P [20:48:06] or we could make an SVG->Drawable resource loader that goes through a WebView ;) [20:48:23] unless you're on 2.3 [20:48:28] GRRR 2.3 SUCKS [20:49:15] brion: not a build step [20:49:23] brion: :P [20:49:42] brion: 2.3 sucks yeah [20:49:45] while we're on the subject -- YuviPanda can you check https://gerrit.wikimedia.org/r/#/c/98578/ and https://gerrit.wikimedia.org/r/#/c/98579/ ? pretty straightforward [20:51:08] (03CR) 10Yuvipanda: [C: 04-1] "transparent.png? NOOO!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98579 (owner: 10Brion VIBBER) [20:52:05] brion: testing the other patch [20:52:36] haha [20:53:09] brion: -1 on other one too, looks misaligned on my phone [20:53:48] :( [20:54:24] YuviPanda: so i assume there's a better way to ensure an ImageView is clear than feeding a transparent png in :D [20:54:27] brion: sent you screenshot [20:54:35] brion: set background to null? :D [20:54:46] there's also a 'transparent' color, IIRC [20:55:04] just making sure that'll work on cell reuse? [20:55:08] is background different from content? [20:55:31] brion: if the info changes, it'll relayout. so should be fiune [20:55:32] *fuine [20:55:34] *fine [20:56:49] will it clear itself automatically on cell reuse, even if we don't clear the image out? is that what you mean? [20:57:50] brion: yes. [20:58:04] brion: provided it is done in the getView, it should [20:58:19] lemme try that... [20:59:30] brion: and the W needs alignment. I emailed you a screenshot [20:59:46] YuviPanda: ok what i'm seeing when i do that is that some of the result rows show the wrong picture for a second, then replace it with the proper images [21:00:05] so it's not being cleared; it's taking the existing view provided as the convertView parameter and finding the image in it, then not changing it [21:00:09] so the old image still shows [21:00:33] brion: viewToUse.setImageResource(android.R.color.transparent); [21:00:34] ? [21:00:49] brion: yeah, you need to check if image is null and then set it to null or transparent? [21:00:51] that should work [21:01:08] yeah so in other words i must set it, it does not automatically get set back to empty :) [21:01:40] brion: oh no, it doesn't :) [21:01:47] I didn't realize that's what you were asking [21:01:47] sorry [21:02:06] :D [21:02:13] ok so i can just throw android.R.color.transparent in there and remove the png \o/ [21:02:15] that should work [21:02:30] brion: yup! [21:02:37] brion: null also works, but isn't documented... [21:02:45] *shudder* [21:02:50] null is evil [21:03:02] brion: heh :D [21:03:58] i so want non-nullable types [21:04:14] i guess if i want that there's always C# ;) [21:04:29] brion: heh. C# has 'nullable' types, which is sortof the Maybe monad [21:04:37] OMG I just used 'monad' nonsarcastically [21:04:45] lol [21:04:56] * brion slaps a BS in CS degree in YuviPanda [21:04:58] 's hand [21:05:15] heh [21:05:26] brion: I do like that as a concept, though [21:05:49] (03PS2) 10Brion VIBBER: Use empty placeholder while loading, CTA placeholder only for known missing images [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98579 [21:05:58] YuviPanda: better? removed the .png :D [21:06:06] lemme check that other W icon [21:06:30] brion: IMO we shouldn't be usikng the CTA at all, really [21:06:30] YuviPanda: give it some more padding on the left maybe? [21:06:48] brion: what do they get if they tap it? NOTHING! :P we're training them to not tap on CTAs [21:06:54] hah [21:07:01] brion: and a little on the top too, maybe? needs to align with the words in the hing [21:07:05] well that's the same behavior as the list on mobile web [21:07:24] well that W is larger, not sure how to vertically align it [21:07:29] with center? baseline? top? [21:07:45] tfinc: you said the glass invite expires in 7 days, and today is day 7 I think? [21:08:03] yuvipanda: hehe, i have it in my shopping cart right now [21:08:04] brion: I think the way to do it is to make the image 48dp [21:08:08] tfinc: sweet! [21:08:15] \o/ [21:08:16] yuvipanda: you around in about an hour? [21:08:21] ill finalize it then [21:08:23] tfinc: yup! [21:09:39] brion: so yeah, make the image 48dpx48dp? [21:09:53] brion: and follow the metrics guidelines on android design wrt to spacing? [21:09:55] should work [21:09:58] ok [21:10:06] yeah it was set to 32x32 lemme bump that up [21:10:06] brion: better than aligning with code IMO [21:10:30] brion: yeah. [21:10:54] brion: see http://developer.android.com/design/style/metrics-grids.html [21:14:49] oh god there's an xxxhdpi setting [21:15:03] i seriously hope that's only so you can specify a bigger icon size for xxhdpi devices [21:15:14] brion: hahahaha [21:15:15] :D [21:15:21] brion: xxxxxxxxxxxxxxxxxxhdpi [21:15:29] VECTOR ICONS PLS [21:15:52] brion: pfft, too sane :) [21:17:45] (03PS2) 10Brion VIBBER: Add 'W' icon to replace black square placeholder [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98578 [21:18:02] YuviPanda: so that bumps up to 48dp, uses a 4dp padding to the left [21:18:06] i'm not sure i like it [21:18:25] but of course we can change it all once the designers look over things with a little more functionality in there :D [21:18:43] brion: checking it [21:21:01] brion: according to http://developer.android.com/design/style/metrics-grids.html, I think they should be 32dp 'content area' on a 48dp 'image', with 8dp padding on all sizes? [21:21:10] brion: agree that current one looks more terrible than prev one :D [21:21:13] terribler!? [21:21:18] YuviPanda: well that depends on what we're going for [21:21:34] brion: hmm, that's also true [21:21:36] the 32dp content area one is next to a button [21:21:47] whereas the avatar with text is maybe more like what we're doing [21:21:53] but we'd want more padding in the image if we do that, probably [21:22:16] brion: yeah, I was okay with the size on the prev. image - just that we should have the padding in the image itself than in xml [21:22:27] also -- is that a touchable control? will it be next to a menu indicator ? [21:22:28] brion: look at the 'example' thing, for example [21:22:41] brion: yeah, would need one of those too. like how an actionbar thing would look like [21:23:51] ok lemme look up some more info on that widget [21:24:04] brion: heh, the new machine is so fast that I keep wondering if I hit 'run' or not [21:24:13] haha [21:24:19] take good care of it :D [21:24:22] and it will take good care of you [21:24:40] brion: :D [21:25:24] brion: I want to get rid of the placeholder entirely. Thoughts? [21:25:28] brion: it doesn't make sense here. [21:25:42] which placeholder? [21:25:45] brion: CTA [21:25:47] thing [21:25:50] on the search results [21:25:56] let's have it when they can tap on it and actually see something [21:25:58] well it makes sense in an overall context of click on this and do that [21:26:22] brion: yeah, except... nothing can be done now :) [21:26:23] ok navigation drawer integrates with the action bar -- do we need to switch to using an action bar here? [21:26:35] brion: I don't think so, that'll kinda mess with the app architecture [21:26:46] brion: we already have a drawer there. we just need to hook it up to that button [21:26:53] hmm [21:27:02] we have a drawer there, just... don't have anything in it :) [21:27:12] brion: there is a method on the nav drawer or something that'll let you open it [21:27:26] brion: of course, there's also a 'three lines' indicator next to the icon. check out the gmail app [21:28:00] right, is that another standard control we can use or do we have to emulate it because we're not using the action bar? [21:28:27] will this make our navigation drawer cover up the top bar? how do we get out of the menu without selecting something? [21:28:51] (https://developer.android.com/design/patterns/navigation-drawer.html) [21:28:55] jdlrobson: just saw your email about writing an RFC for template support to hopefully be discussed during the architecture summit - were you able to get anyone on board to help prepare it? [21:29:18] brion: if you look at the page activity, you see that we've put the nav drawer there to include the 'actionbar thingy' [21:29:24] brion: we can just move it around to not cover it [21:29:26] awjr: nope [21:29:35] hmm ok [21:32:06] hmm [21:35:53] (03CR) 10Jdlrobson: [C: 032] Add missing explicit GENDER parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98561 (owner: 10Siebrand) [21:35:58] (03PS2) 10Jdlrobson: Add missing explicit GENDER parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98561 (owner: 10Siebrand) [21:36:06] (03PS3) 10Jdlrobson: i18n: Add missing explicit GENDER parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98561 (owner: 10Siebrand) [21:36:19] (03CR) 10Jdlrobson: [C: 032] "Changed commit message to be consistent with others" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98561 (owner: 10Siebrand) [21:38:42] (03PS1) 10Yurik: Force HTTP redir for landing page if carrier doesn't support HTTPS [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98698 [21:39:02] (03Merged) 10jenkins-bot: i18n: Add missing explicit GENDER parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98561 (owner: 10Siebrand) [21:53:28] YuviPanda: ok i'll poke a little more at the icon & navigation drawer indicator; it seems to *really want* to hook up to an action bar but i think i can manage it manually :) will try it in a bit [21:53:35] in th meantime.... gotta make sure my rent is paid [21:53:38] brion: heh :D [21:53:42] they didn't cash my last check :P [21:53:42] brion: pfft, priorities! [21:53:54] which is why i wanted to pay it electronically but they said noo check is fine :D [21:54:12] ok i'll be back online in 60-90 mins [22:05:41]