[00:05:43] (03PS7) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 [00:05:47] (03CR) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [00:06:11] rmoen: what's the state of visual editor? [00:06:53] jdlrobson: working on getting the huge review stack merged [00:06:56] (03PS3) 10Jdlrobson: Rename Special:History to Special:MobileHistory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96963 (owner: 10Legoktm) [00:07:05] rmoen: let me know how i can help [00:07:09] would be nice to get it out before thursday [00:07:17] jdlrobson: for sure [00:07:22] jdlrobson: tell me about it [00:07:35] rmoen: did you get me any ali babas or did you forget :P [00:07:43] all last week I had Timo, and Roan review it. [00:08:06] jdlrobson: its still not merged, because of the huge stack needing to be rebased [00:08:30] jdlrobson: sry boss, no ali babas [00:08:32] ;( [00:08:38] :( boss [00:08:54] (03PS4) 10Jdlrobson: Rename Special:History to Special:MobileHistory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96963 (owner: 10Legoktm) [00:09:06] sorry man, kaldari and i bought prince suits and I got some stuff for the lady [00:09:50] (03CR) 10Jdlrobson: [C: 032] Rename Special:History to Special:MobileHistory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96963 (owner: 10Legoktm) [00:09:55] prince suits? [00:10:10] jdlrobson: just wait for the Christmas party :) [00:10:30] (03Merged) 10jenkins-bot: Rename Special:History to Special:MobileHistory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96963 (owner: 10Legoktm) [00:10:47] jdlrobson: in regards to the latest ve / mobile integration stuffs, i'm redoing our saveError handling and will be working on getting that into the veOverlay soon. Basically just generalizing all of the non desktop view logic so that it can be reused for mobile [00:10:50] (03CR) 10Jdlrobson: [C: 031] "Yuvi feel free to +2 once tested :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98006 (owner: 10MaxSem) [00:11:04] (03PS3) 10Jdlrobson: Hard refresh the main page on an edit. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98034 [00:11:06] jdlrobson: I bet you could find some ali babas in Berkeley, they have a bunch of Indian stores [00:11:27] jgonera: can you respond to https://gerrit.wikimedia.org/r/#/c/96648/2/MobileFrontend.i18n.php ? [00:11:38] jdlrobson: woo! I'll do that tomorrow :) [00:12:45] jdlrobson: damn, I thought that '+2 once tested' was for the mobile.js patch [00:16:37] yurik: you there? [00:27:43] Hi everyone on #wikimedia-mobile... I'm currently working as part-time as a contractor for the WMF, on the Education Program extension, and a little while ago I had an interview with tfinc for a position with mobile. I was wondering if there might be some mobile-related tasks I could help out with, so I can learn more about what you're working on, and also maybe so we can get to know each other a bit, if you like...! [00:28:05] jdlrobson: awjr MaxSem ^ [00:28:10] welcome, AndyRussG :) [00:28:27] Thanks YuviPanda! [00:29:27] AndyRussG: :) I don't work on the mobile site, but the others I pinged should be able to point something out [00:29:31] also kaldari and jgonera [00:29:31] welcome AndyRussG [00:29:43] are you more interested in doing work on the mobile web, or in the apps? [00:30:11] awjr: Hi :) Thanks YuviPanda [00:30:17] * YuviPanda guesses web, since he's interested in the backend role, IIRC? [00:31:09] hey AndyRussG [00:31:13] how about https://bugzilla.wikimedia.org/show_bug.cgi?id=57155 ? [00:34:16] MaxSem: hi, sounds good! awjr, YuviPanda: really anything is fine. I understood from tfinc that it's a pretty polyvalent role that requires a good understanding of backend, frontend, and how everything fits together [00:35:20] I can "take" that bug if you like... [00:35:32] feel free [00:35:34] go for it AndyRussG, there are more where that came from :p [00:35:52] yurik: yt? [00:38:45] Taken! [00:39:19] no brion [00:39:20] sigh [00:43:28] I'll try to figure stuff out on my own, and possibly bug you if I'm really stuck, or otherwise maybe just lurk [00:43:30] Thanks again! [00:45:52] awjr, sup? [00:46:35] yurik: can you still replicate https://bugzilla.wikimedia.org/57624 ? [00:47:53] 01[13WikipediaMobile01] 15yuvipanda created 06partial-zero-support (+1 new commit): 02http://git.io/ZoGMUg [00:47:53] 13WikipediaMobile/06partial-zero-support 14a9ae5f2 15Yuvi Panda: Make apps hit the mobile domain.... [00:49:19] yurik: dr0ptp4kt ^ :) [00:50:48] awjr, i saw it yesterday, will try to emulate once i get back home [00:50:56] thnx yurik [00:53:04] awjr, has there been any code changes that could affect it since yesterday? [00:53:26] not that i know of yurik, but neither jon nor i have been able to replicate [00:54:01] awjr: aren't Mobile cards tracked in Mingle? I'm not seeing the project when I'm logged in [00:54:16] chrismcmahon: you are perhaps looking at the wrong mingle instance [00:54:42] chrismcmahon: https://wikimedia.mingle.thoughtworks.com/projects/mobile/overview [00:54:43] awjr: https://mingle.corp.wikimedia.org [00:55:01] yeah, that's the old one chrismcmahon (at least for us) - we will be migrating all projects off of there over the next month or so [00:55:09] mobile just happened to make the switch already [01:03:00] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [01:07:11] (03PS1) 10JGonera: Story 1401: Language Selector Overlay UI Redesign [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 [01:08:53] (03CR) 10Siebrand: "It's a bit late now (02:00), have to go get some sleep... Let's look at it tomorrow. We don't do much magic at translatewiki.net." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98481 (owner: 10Yurik) [01:10:19] (03CR) 10Dr0ptp4kt: [C: 04-1] "I think there's a strange bug here with the destination 'to' URL." (035 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98168 (owner: 10Yurik) [01:10:33] ^yurik, okay there you go [01:13:37] awjr, seems like i can still repo it - https://en.m.wikipedia.org/wiki/New_York?debug=true -- and make sure you spoof X-CS=250-99 and User-Agent=android [01:13:55] i use chrome's debugger [01:14:36] dr0ptp4kt, will look in a sec, pls take a look at the second one now - see if i could have possibly addressed it there in some other way [01:18:34] yurik-road: how do you spoof the x-cs heder in chrome? [01:20:34] awjr - https://chrome.google.com/webstore/detail/modheader/idgpnmonknjnojddfkpgkljpfnnfcklj?hl=en [01:21:09] awjr, also highly recommend https://chrome.google.com/webstore/detail/http-headers/mhbpoeinkhpajikalhfpjjafpfgjnmgk to view headers [01:21:37] oh that's cool, i usually just the network stuff in dev tools; that looks way nicer [01:21:57] oh yeah, i found tons of amazing dev tools for chorme [01:23:13] awjr, for example - https://chrome.google.com/webstore/detail/clear-cache/cppjkneekbjaeellbfkmgnhonkkjfpdn -- delete last hour of cache (or more) and refresh page with one click or shortcut [01:23:28] ok, i can repro it now too yurik-road [01:23:33] awesome [01:23:38] it seems to be zero related though as i can only trigger it with x-cs header [01:23:43] i wonder if its our bug though :) [01:23:51] i think it might be :p [01:24:01] the uncaught error is 'module not found: ZeroOverlay' [01:24:24] lol, i saw that one a few times, but mostly i get the cleanup one [01:24:25] if i leave out the x-cs header, things work as expected [01:24:49] awjr, thing is, without x-cs the overlays are not loaded at all [01:24:54] i suspect [01:25:27] that's why would be great if jdlrobson could have a look [01:26:34] btw, awjr - with the header spoofer, you can set it up so that every time you go to the m. domain, you automatically see it as a mobile, while if you go to non-m - it will be desktop [01:26:44] just a life-hack [01:27:06] dr0ptp4kt around? [01:27:12] wait, every time you do go to the .m domain it should be mobile! same with non-m [01:27:15] yurik-road i'm here [01:27:16] even without magic headers [01:28:27] oh yeah, oops :) I guess i am soo used to spoofing x-cs and user agent for local, i didn't even realize it :) [01:28:34] hahaha [01:28:47] dr0ptp4kt, yes, regarding clicks - almost all clicks on a page are navigational events - so they will take the user out of the page [01:29:16] but i guess I could optimize regexes if that is a problem [01:30:28] dr0ptp4kt,what do you think? [01:32:00] yurik-road, if you think the clarity saved is worth it, that's fine. i'm okay with those regexes either way. i see merits both ways. [01:33:10] dr0ptp4kt, so yes, lets keep it this way until we merge it and optimize a bit after the 2nd patch? Or possibly as part of the 2nd patch - otherwise i will be in rebase hell for the rest of the day [01:33:31] let me check the other issue you raised [01:33:36] kaity: https://en.wikipedia.org/w/index.php?title=Special:Search&limit=500&offset=0&redirs=0&profile=all&search=UserProfileIntro [01:36:14] yurik, ok. i'm heading out for the evening for the concert, but i'll look at the second change further tomorrow. the code in the second change seems to work fine, just trying to ferret out edge cases and practical runtime things. [01:59:13] (03CR) 10Yurik: Added don't ask again button & cleaned up handling logic (032 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98168 (owner: 10Yurik) [02:07:28] (03PS1) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [02:07:42] (03CR) 10Kaldari: [C: 04-2] "Not ready" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [07:49:46] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Messages are fine, but appears to still contain some development artefacts." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [08:14:06] (03CR) 10Siebrand: "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 (owner: 10JGonera) [09:18:31] (03PS2) 10Shirayuki: Fix getErrorMessage() [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97703 [09:29:20] (03PS1) 10Mayankmadan: Adding a readme file in /tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 [10:20:01] (03PS1) 10Mxn: (bug 57914) Added Vietnamese translations for Zero namespaces [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98791 [12:37:29] (03CR) 10Zfilipin: [C: 031] Adding a readme file in /tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 (owner: 10Mayankmadan) [15:23:15] Hi, two users report that in the iPhone app, the "Kontaktiere uns" (presumably "Contact us" in English) link does lead to a non-existing special page. Could this be localization-related or is this otherwise a known issue? [15:23:43] (talking about dewiki) [15:26:44] thanks pajz, this is known and will be fixed with next release [15:35:28] MaxSem: Good, thanks. Also, it's reported that infoboxes are displayed incorrectly, see https://dl.dropboxusercontent.com/u/22742936/image-1.png (from https://de.wikipedia.org/wiki/Kranich_%28Sternbild%29) [15:36:30] Is that just due to faulty css or does it have some other reason? The underlying template is https://de.wikipedia.org/wiki/Vorlage:Infobox_Sternbild [15:36:47] s/just [15:37:09] YuviPanda, ^^^ [15:37:35] faulty CSS that's also old, pajz [15:38:12] oh, "max-width:67%". hmm. [15:38:22] pajz: should be fixed in next release [15:39:59] YuviPanda: meaning it would also somehow overwrite the css definition in the template and display it properly? [15:40:17] pajz: possibly. we're considering killing all inline styling and see how it goes [15:40:20] *considering* [15:41:32] Ok, thanks! [15:41:36] pajz: yw! [15:44:55] (03PS1) 10Yuvipanda: Bump min version to 11 (temperoarily) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98838 [17:02:41] MaxSem: is there a technical reason to put "?useformat=mobile" at the end of URLs for mobile web? [17:03:10] to force mobile view no matter of circumstances [17:05:02] MaxSem: OK, getting an odd result sometimes when on a ".m" URL that also uses "?useformat=mobile", I'm trying to nail it down. [17:06:25] chrismcmahon, how can I help? [17:06:39] MaxSem: cancel my meetings :-) [17:07:09] no problem, just gimme your password [17:07:19] MaxSem: I just wanted to make sure that ?useformat=mobile was still a legitimate thing to append to a URL [17:07:30] it is [17:59:09] (03CR) 10Yuvipanda: [C: 04-1] "Too java-y for my tastes" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98734 (owner: 10Yuvipanda) [18:00:25] yurik, you there? you able to do the scrum of scrums meeting in my absence? adele needs me on a call at that time. [18:02:21] * awjr waves to jdlrobson [18:02:30] hey awjr [18:02:55] jdlrobson: can you bring up the 500 error issue on betalabs during sos? [18:02:58] i've got a bug for it somewhere... [18:03:32] the 500 error? i'm not familiar with that [18:03:42] awjr: just whack it on the scrum of scrums board [18:04:07] jdlrobson: it's https://bugzilla.wikimedia.org/show_bug.cgi?id=57249 - there have been some threads about it too on the engineering list [18:04:26] it's resulting in bogus failed tests on betalabs because big articles like barack obama time out [18:04:42] i'll add it to the wall [18:11:15] (03CR) 10Yurik: [C: 032] Fix getErrorMessage() [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97703 (owner: 10Shirayuki) [18:11:19] (03Merged) 10jenkins-bot: Fix getErrorMessage() [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/97703 (owner: 10Shirayuki) [18:11:58] dr0ptp4kt, sure, will be at scrum [18:12:14] yurik, thanks [18:12:20] i'll email you status updates that i have [18:12:31] dr0ptp4kt, np. Any q for me so far? [18:12:50] yurik, no [18:13:25] yurik, i recommend fixing the bug in the first javascript patchset so that commit history is not dirty with a bug. then ensure that the second patch doesn't have a merge conflict [18:14:28] dr0ptp4kt, ok, will do [18:15:25] whoa have any of you seen explainshell? this looks pretty sweet http://lifehacker.com/explainshell-breaks-down-long-confusing-linux-commands-1475159535 [18:25:44] jdlrobson: 10.30a still happening right [18:25:55] violetto: 10.30am? [18:26:03] oh yeh [18:26:10] i'm gonna be late though as there is SoS before [18:26:22] ok [18:26:43] awjr: care to explain https://mingle.corp.wikimedia.org/projects/scrum_of_scrums/cards/41 ? [18:27:08] * awjr shrugs [18:27:11] i know nothing about it [18:27:15] maybe chrismcmahon added it? [18:27:34] yeah looks like he did [18:28:21] awjr jdlrobson I did add that one, but perhaps it is overtaken by history? [18:31:05] awjr: we have a room issue again.. [18:31:23] er wtf [18:31:45] i don't know what's happening but fabrice is in there [18:31:59] and according to the calendar the room is not assigned to us [18:32:19] so we now have 5 people outside the room with nowhere to go.. [18:33:21] awjr: no rooms with video conferencing available [18:33:49] wtf [18:36:53] kaldari: what's the status with the getting started stuff you began yesterday? [18:37:02] are you using the growth team's API? [18:37:21] It's being completely revised by Vibha [18:37:28] I should go bug her [18:37:48] I was thinking about using the API [18:37:56] I merged it yesterday [18:38:08] do you know if it supports the linking category? [18:38:52] I have it using the new overlay instead of the drawer, but Vibha wants to redo the workflow [18:42:30] violetto, kaity: mediawiki.ui includes styles for "containers". What's a container? [18:42:49] any idea? [18:43:19] kaldari: hmmm [18:43:32] kaldari: we're all in meeting, come down later [18:43:44] ok [18:56:42] superm401: you around [18:57:52] (03CR) 10Jdlrobson: [C: 04-1] "There is a section in the README in the main directory called "Selenium tests ". We should improve that if necessary.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 (owner: 10Mayankmadan) [19:00:13] Let me know when kaldari is back. [19:00:16] I can answer his questions. [19:01:35] It does support a link category with the addlinks task. [19:01:39] Oh, hey kaldari. [19:01:55] Yeah, so the three are listed in GettingStarted.php currently. They're: [19:02:07] copyedit - All_articles_needing_copy_edit [19:02:14] clarify - All_Wikipedia_articles_needing_clarification [19:02:21] addlinks - All_articles_with_too_few_wikilinks [19:03:10] kaldari, also, I think mw-ui-container is meant to be a wrapper around stuff with the MW UI styles. [19:03:46] Right now, all it controls is the special font styles for Vector. [19:04:04] hmm, no brion [19:05:16] superm401: So at the last mediawiki.UI hack day we discussed briefly spinning off a separate RL module just for the button styles, since those are sometimes needed in contexts where there is no JS access (see discussion at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Template:Clickable_button_is_broken and https://en.wikipedia.org/wiki/MediaWiki_talk:Common.js#Fixing_Template:clickable_button), so I was thinking about [19:05:16] actually doing this today. The alternative idea is to just load all of mediawiki.ui by default everywhere, but that might be overkill. Any opinion on this? [19:05:35] awjr: eeek i think there is a serious bug in master - can you look into it? http://localhost.beta/w/index.php/Special:Preferences [19:05:42] when i visit that in beta i get a flood of php warnings [19:05:55] (currently in the mediawiki ui meeting so can't look into it :)) [19:07:25] jdlrobson: i can take a quick look [19:08:12] awjr: ignore [19:08:18] turns out i was running old version of core [19:08:21] heh [19:08:22] phew [19:10:07] kaldari, I like the idea of spinning it off. [19:10:51] That would allow loading the button styles unconditionally for the benefit of wikitext content, which a few people have wanted. [19:11:27] We talked about having mediawiki.ui and mediawiki.ui.js, but there are other ways of breaking it up. [19:11:36] Just a pure CSS mediawiki.ui.button might be simplest. [19:14:46] superm401: https://gerrit.wikimedia.org/r/#/c/87296/ [19:14:55] oops [19:16:18] superm401: https://gerrit.wikimedia.org/r/#/c/98869/ [19:18:09] jdlrobson: https://gerrit.wikimedia.org/r/#/c/98869/ [19:22:55] jdlrobson: did matt say the GS API stuff is checked in, or totally merged? [19:23:17] awjr: kaldari has started working on it but yeh we should be good to go. I left it on the board to keep tabs on it [19:23:24] as we haven't made use of it yet [19:23:33] w00t [19:23:41] jdlrobson: i marked it as 'done' on the board but i'll leave it there til next week [19:23:46] since theoretically the dependency is gone [19:24:27] argh i need to get bingle updated to stop the dupes coming in [19:29:22] (03PS1) 10Yurik: Follow up to getErrorMessage() fix [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98880 [19:29:33] My computer froze after I said "Just a pure CSS...", so if someone said something to me after that, I missed it. [19:31:44] superm401: https://gerrit.wikimedia.org/r/#/c/98869 [19:31:57] Thanks, will review that after Roan's. [19:31:57] let me know if you think that implementation makes sense [19:33:38] has anyone seen tfinc yet today? [19:40:23] hmm, no brion nor tfinc [19:40:58] my hangout with tfinc is lonely since he's not actually there :( [19:41:26] heh [19:41:58] awjr: there he is! [19:44:24] mhurd: hey! [19:44:51] YuviPanda: yo! [19:45:02] mhurd: how's it going? how's history coming along? [19:45:51] * YuviPanda has it mostly working, yay [19:45:57] YuviPanda: coming along pretty well. had some tweaks to the schema that i just ironed out [19:46:03] YuviPanda: that's awesome! [19:46:23] mhurd: nice! I spent most of last week implementing the data persistance layer, so now that's done things move fast :) [19:46:47] YuviPanda: ya it's so fun actually hooking things up! [19:46:57] (to the data layer) [19:47:10] mhurd: heh, yeah [19:48:44] mhurd: any idea about brion? [19:49:24] YuviPanda: he may have apt stuff today. not sure [19:49:29] ah, right [19:52:10] chrismcmahon: any idea how hard it is to get a (new) extension deployed on betalabs? [19:53:02] YuviPanda: it's easier today than in the past, we've done it with CirrusSearch and with Flow. what's the extension? [19:53:21] chrismcmahon: MobileApp. Nothing in it yet, should have something in it in a couple of days [19:53:31] chrismcmahon: mostly just RL styles for the apps, no other code. [19:53:42] chrismcmahon: how much 'prior notice' would you need? [19:56:11] YuviPanda: hashar is the expert there, but I think it is mostly config change. You'll need to have the code for it in the master branch, and the extension listed in the config for beta labs. [19:57:46] chrismcmahon: sounds doable enough :) [19:57:52] chrismcmahon: will poke in a few days! [19:58:56] YuviPanda: do check in with hashar when you see him around so he knows it's coming up. [19:59:02] chrismcmahon: right! will do! [19:59:04] thanks! [19:59:19] chrismcmahon: I don't expect it to be deployed for another month at best, but having it in beta would be useful :) [19:59:59] YuviPanda: the more people use beta for testing before deployment, the happier I am. I am psyched that we can host undeployed extensions these days, that was kind of a big deal. [20:00:08] chrismcmahon: :D [20:08:29] chrismcmahon: is that firefox search failure still happening? [20:08:59] awjr: I think jdlrobson repro'd it just now. that was an odd one. [20:09:10] :( [20:09:18] chrismcmahon: awjr see bug report yeh [20:09:46] @_@ [20:10:19] that is truly whacky [20:10:34] chrismcmahon, jdlrobson can you reproduce on mediawiki.org or enwiki? [20:10:45] awjr: the link is on the bug report [20:11:09] awjr: no repro on enwiki, didn't try on mw.o, I'll do that now [20:11:55] jdlrobson: nothing about enwiki or mw.o on the bug report but sounds like chris is checking [20:12:41] awjr: which bug are you talking about? [20:12:52] awjr: what's the mobile URL for mw.o? I tried the likely candidates [20:12:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=57934 [20:12:59] chrismcmahon: m.mediawiki.org [20:13:08] awjr: see comment 2 [20:13:28] it's probably an issue with test2 or current master [20:13:55] jdlrobson: right yeah i saw that, i was asking about enwiki or mw.o to determine whether it's something unique to test2 [20:14:01] awjr jdlrobson definitely have the same issue at http://m.mediawiki.org [20:14:01] test2 and mw.o should be running the same code [20:14:07] enwiki is running a different branch [20:15:03] awjr jdlrobson AND have a repro at https://m.mediawiki.org with Chrome and https, not just FF and http [20:15:36] i wonder if this is an opensearch issue [20:15:50] im going to eat some lunch, i can take a look a bit later [20:16:10] awjr: I wondered that too, I'll ask Nik [20:16:16] sounds good chrismcmahon [20:16:33] i can imagine a scenario where different requests are hitting different search nodes and getting different results [20:16:56] but based on what jdlrobson posted it sounds like it's probably not MF-specific [20:26:21] awjr|lunch: yeah, unless MF is sending some unusual parameter or whatever to search, that was my first thought [20:29:48] kaity, are you sure that button in the profile can't be any of http://33cc77.com/wikipedia/ ? ;) [20:30:24] I think we can experiment here [20:30:47] also why does the text in those buttons have drop shadows? [20:31:25] (03CR) 10Yurik: [C: 04-2] "We should not localize Zero namespace because it is only used on Meta for configuration, and accesseed mostly via API. Having namespace lo" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98791 (owner: 10Mxn) [20:31:49] whoa i forgot i was spoofing my UA in my browser and started seeing the mobile version of facebook [20:32:05] sorry jgonera is that ok? we can simplify it for now if its too much work [20:32:39] kaity, not sure why it has drop shadows, a volunteer did this. do you have the latest specs somewhere? [20:32:59] it's not about the amount of work, it's more about creating something reusable [20:36:01] yea we can look at the latest spec I'll come over [20:36:32] kaity, we're in R31 [20:36:46] oh thats ok we can talk about that later [20:37:10] you can just use the blue button style [20:37:17] I mean, it's the UI hack day so it's absolutely OK if you come now ;) [20:37:36] kaity, but I want to implement the new styles today as a part of the UI hack day [20:40:08] (03PS5) 10MaxSem: WIP: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [20:40:44] ok [20:49:17] YuviPanda: heading to lunch [20:49:25] mhurd: okay! [20:49:47] back in ~ 1 hr [20:50:19] awjr|lunch, could you rename Wikipedia Zero -> Zero at https://mingle.corp.wikimedia.org/projects/scrum_of_scrums/enumeration_values/list?definition_id=2618 pls? thx! [20:50:23] mhurd: sweet [20:59:04] (03PS7) 10Yurik: Added don't ask again button & cleaned up handling logic [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98168 [21:17:44] done yurik [21:18:38] kaity, can I have that link? ;) [21:19:27] i sent an email [21:19:49] jgonera: heres a link too https://www.dropbox.com/s/ajtygqv78z9vvep/Agora%20buttons-01.png [21:20:37] awjr, mingle is buggy :((( https://mingle.corp.wikimedia.org/projects/scrum_of_scrums/cards/grid?color_by=status&filters[]=[Show+on+Wall][is][Yes]&group_by[lane]=team+dependency&group_by[row]=team&lanes=+%2CAnalytics%2CCore+Features%2CGrowth%2CLanguage%2CMobile%2CMobile+apps%2COperations%2CParsoid%2CPlatform%2CQA%2CVisual+Editor%2CWikipedia+Zero&tab=Dependency+Wall [21:20:52] with URLs like that what could possibly go wrong [21:20:57] yurik: there are two lists [21:21:01] i only updated one :p [21:21:08] YuviPanda, true that! [21:21:18] omfg i know [21:21:22] those urls are awful [21:21:42] Cool URLs are completely unreadable and break everything, says W3C [21:21:46] thanks kaity [21:22:43] ok yurik, better now? [21:23:16] awjr, not really, we are off the wall :) [21:23:24] @_@ [21:23:26] kaity, I don't get the color codes B1, B2, G1, G2... [21:23:32] were there any cards in the zero column? [21:23:39] if not, it wont show up [21:23:39] yep [21:23:42] oops [21:23:50] damn you mingle! [21:23:57] i say we should switch to X [21:24:03] TRELLO! [21:24:06] :P [21:24:07] bleh [21:24:09] oh oops [21:24:13] trello doesn't have any of these fun views [21:24:25] bugzilla! :P [21:24:34] * yurik ignores YuviPanda [21:24:53] * YuviPanda adds yurik as cc to all cards [21:24:58] :D [21:25:10] yurik: try now? [21:25:12] jgonera: https://www.dropbox.com/s/0phu7gixfk1ss83/Agora%20colors-15.png [21:27:04] jgonera: did you get that? [21:29:27] kaity, violetto1 and S say that those are the up-to-date colors: https://www.mediawiki.org/wiki/File:Guide_Color.png [21:41:17] YuviPanda, are you saying that people on 2.2 cannot apply any app updates, even if a new version was supplied to the marketplace before the reboot? [21:41:53] dr0ptp4kt: they can do that *before* the reboot goes out. After that people who *currently* have the app won't get any updates, and people who don't have the app but are on 2.2 cannot install [21:42:31] YuviPanda, i got ya, so multiple apk support is infeasible. granted, that's a rather small percentage. [21:42:45] dr0ptp4kt: yeah. [21:43:10] dr0ptp4kt: I want mhurd or brion to confirm, but I think the situation is similar in the iOS app store [21:43:36] kaldari: hey how hard is it to run another central notice campaign [21:43:38] ? [21:43:46] easy [21:44:03] dr0ptp4kt: also note that the current PR from me needs testing and merging and deploying and all that [21:44:25] jgonera: yes those are good [21:44:42] jgonera: it just doesn't include the blue button color [21:44:59] kaity, it has the blue base color, that's fine [21:45:22] jgonera: blue button color is 347bff [21:47:30] (03PS6) 10Yurik: Do not call API unless needed [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98266 [21:59:55] (03CR) 10Dr0ptp4kt: [C: 032] Added don't ask again button & cleaned up handling logic [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98168 (owner: 10Yurik) [22:05:29] dr0ptp4kt, you rock! :) [22:06:42] YuviPanda, sorry, just read your latest msg to me. yeah, i think test & build on that should be held off for the moment. if https isn't disabled opportunistically, it won't yet measurably reduce charges. we'll need to talk with carolynne today in a meeting with kenanwang about support across android legacy, ios legacy, and wap web mobile [22:07:09] dr0ptp4kt: alright. Currently the app also *always* uses https, fwiw [22:07:29] (03CR) 10JGonera: Story 1401: Language Selector Overlay UI Redesign (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 (owner: 10JGonera) [22:08:22] dr0ptp4kt: can you leave comments on the pull request? [22:10:13] (03PS1) 10Jdlrobson: Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 [22:11:22] hey brion :D [22:11:26] (03PS1) 10Yuvipanda: Prevent crash when rotating device without pages open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98980 [22:11:27] (03PS1) 10Yuvipanda: Add UI to see history [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98981 [22:11:38] brion: just in time? :) ^ [22:11:38] for some reason i can't get colloquy to unzip on my secondary laptop [22:11:41] jgonera: https://gerrit.wikimedia.org/r/#/c/98979/ [22:11:47] weird [22:12:03] brion: heh [22:12:05] YuviPanda: ok is the database stuff ready to review or should i start with the other bits? [22:12:06] brion: use LimeChat! [22:12:12] meh [22:12:13] brion: oh start with the db [22:12:18] brion: and work forwards :) [22:12:18] ok [22:13:30] (03CR) 10Yurik: [C: 04-2] "working on it" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [22:14:11] brion: had to make some modifications to the core data schema so got a bit behind. starting now on the history display layer. i think with all the backend work this front-end part should go quickly [22:15:48] (03PS2) 10Jdlrobson: Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 [22:16:48] (03Merged) 10jenkins-bot: Added don't ask again button & cleaned up handling logic [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98168 (owner: 10Yurik) [22:17:03] ok [22:19:54] brion: I'm thinking if we should show history entries for links that were opened from the history activity [22:20:00] YuviPanda, yeah, i'll add comments [22:20:00] yurik, i haven't forgotten about the second js patch [22:20:07] dr0ptp4kt: ty [22:20:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 (owner: 10Jdlrobson) [22:20:14] YuviPanda: i was wondering about that too [22:20:20] good question :) [22:20:29] mhurd: I currently add that, and it kinda... feels a bit weird [22:20:30] i think for now let's consider opening those as just revisiting the past [22:20:34] so no new entry? [22:20:41] dr0ptp4kt, cool, thx, its rebased without any changes on top of patch1. Also, I'm making a list of tiny patches that I hope we can have out tomorrow [22:20:42] YuviPanda: maybe if re-opened within half a day or so just compress to single entry? [22:20:48] but if you follow more links, they'd be linked to that previous context [22:20:50]