[00:00:17] awjr: Erik's interested in me going to a developer recruiting event tomorrow, but it overlaps with the estimation meeting. Do you need me at the estimation meeting tomorrow? [00:01:30] probably depends on if jdlrobson, jgonera, and MaxSem are going to be there [00:01:49] it would be good to have you there kaldari but it is not the end of the world. any chance you could dial in for the hangout? [00:01:54] 'dial in' heh [00:01:56] I'll be there [00:03:11] * MaxSem too [00:03:14] awjr: unfortunately no, during the meeting time (1-2pm) I would basically be doing speed interviews [00:03:22] at theevent [00:03:35] whoa [00:03:38] is it like speed dating? [00:03:43] 7 minutes for each candidate [00:03:48] kaldari: we'll miss you but i think we'll be OK [00:03:49] yep, like speed dating [00:04:08] that's crazy [00:04:09] where is it [00:04:10] ? [00:04:24] Hackbright Academy [00:04:55] cool! [00:13:32] awjr: OK, I told Erik I'll be there [00:16:37] (03PS4) 10Yurik: Added a welcome message at the top of the landing page. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 [00:16:57] (03CR) 10Yurik: Added a welcome message at the top of the landing page. (033 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [00:17:11] (03CR) 10Yurik: Added a welcome message at the top of the landing page. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [00:28:16] yurik: during the mtg earlier you mentioned you needed help with deplyoying database changes on meta - i just realized we didn't coordinate getting you help during the meeting [00:28:16] (03PS5) 10Yurik: Hide header & add a welcome message (empty) to the landing page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 [00:28:52] yurik: MaxSem or kaldari can probably help you out [00:29:33] awjr, thx, aaron has indicated what needs to get done to deploy it... hope he didn't forget anything :) [00:29:53] heh [00:29:56] ok cool [00:29:57] will attempt to deploy it tomorrow [00:30:04] iirc it is all well documented [00:30:05] dr0ptp4kt, around? [00:30:12] or at least it was last itme i did it, but that was a while ago [00:30:17] yurik, yes. [00:30:20] awjr, well... not exactly from what i saw ... a bit outdated actually :) [00:30:45] ruhroh [00:30:50] dr0ptp4kt, anything i can help with? [00:30:51] will aaron be around whle you deploy? [00:30:58] the list of patches is growing :) [00:30:58] yurik: ^ [00:31:05] yurik, hang on [00:32:15] (03CR) 10Dr0ptp4kt: [C: 032] Do not call API unless needed [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98266 (owner: 10Yurik) [00:33:39] dr0ptp4kt, awesome!!! now on to the tiny patches :) [00:35:16] (03Merged) 10jenkins-bot: Do not call API unless needed [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98266 (owner: 10Yurik) [00:36:24] (03PS4) 10Jdlrobson: Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 [00:41:35] yurik, so tomorrow, first things first: you'll merge and deploy "Apply FlaggedRevs to metawiki for W0." (https://gerrit.wikimedia.org/r/#/c/95662/). and then you'll merge "Supported flagged revisions of W0 configuraton." (https://gerrit.wikimedia.org/r/#/c/95657/) ... correct? [00:42:46] dr0ptp4kt, I could do that, but I would rather get out the stable version that doesn't depend on any external changes, and than deploy the revflags - because that one actually is affected by external systems [00:43:31] dr0ptp4kt, so how about this : lets deploy all of my patches, followed by rev flags, check that rev flags works ok on meta, and than deploy the code change? [00:46:49] awjr, MaxSem, you guys know that we are deploying the new redirector from m.wikipedia.org and zero.wikipedia.org, right? [00:46:52] yurik, okay, so that means deploy the current tip of ZRMA. then verify it works / isn't broken. then the mediawiki-config change. then verify that works / isn't broken on meta (nor in zrma-modified webpages). then, if time allows, merge and deploy the zrma flaggedrevs code. [00:47:19] i was not aware yurik - what is the new redirector? was there an email? [00:47:38] awjr, it shouldn't change any functionality [00:48:09] just internally m.wikipedia.org will be 302 to en./main page just like it is hardcoded in varnish but via a redirector [00:48:40] so this is more of a heads up in case m. or zero. (without the language) stop working [00:48:41] does it do it based on language, or always en? [00:49:00] awjr, currently its always bounces to en [00:49:25] yurik: i have a vague recollection of seeing an email about this maybe a month or so ago [00:49:39] sounds cool :) [00:49:40] now it will bounce to proper language IIF X-CS is set [00:49:45] or to EN otherwise [00:49:50] awesome [00:49:58] at some point maybe we will start analyzing lang setting s:) [00:50:02] of the device [00:50:10] we can easily do that now [00:51:24] yurik, is your thought to actually have ops merge and deploy 97122 tomorrow? or to have that deployed _afterward_ [00:51:25] ? [00:56:34] dr0ptp4kt, i just spoke with paravoid, he was looking at the patch, so most likelly he will push it out some time soon [00:56:44] this won't be on backend deployment schedule though [00:56:50] yurik, okay [00:58:34] dr0ptp4kt, so it seems like all those minor patches can go in in any order - as long as we can get them all :) [01:00:14] yurik, is there something you need me to review? [01:00:23] dr0ptp4kt ?? [01:00:31] i thought you were looking at all those patches [01:01:02] yurik, what patch #s? i don't think i received patch #s [01:01:17] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/q/owner:%22Yurik+%253Cyurik%2540wikimedia.org%253E%22+status:open+project:mediawiki/extensions/ZeroRatedMobileAccess,n,z [01:06:09] dr0ptp4kt, and i'm fighting https://bugzilla.wikimedia.org/show_bug.cgi?id=57624 [01:06:28] hopefully can fix it by tomorrow [01:11:33] (03CR) 10Dr0ptp4kt: "Per your IRC request, reviewing." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98480 (owner: 10Yurik) [01:13:13] (03CR) 10Dr0ptp4kt: [C: 04-1] Force HTTP redir for landing page if carrier doesn't support HTTPS (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98698 (owner: 10Yurik) [01:15:12] (03CR) 10Yurik: "Agree, need to discuss this further." (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98698 (owner: 10Yurik) [01:19:58] (03CR) 10Dr0ptp4kt: [C: 04-1] Removed a few strange or obsolete i18n message strings (032 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98481 (owner: 10Yurik) [01:21:16] (03CR) 10Dr0ptp4kt: [C: 032] Follow up to getErrorMessage() fix [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98880 (owner: 10Yurik) [01:21:18] dr0ptp4kt, that's ok - those messages are weirdly used by one lang (see comments in that patch) [01:21:22] (03Merged) 10jenkins-bot: Follow up to getErrorMessage() fix [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98880 (owner: 10Yurik) [01:21:47] will fix it in translatewiki [01:24:16] (03CR) 10Dr0ptp4kt: [C: 032] "yurik to make an update in translatewiki post merge." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98481 (owner: 10Yurik) [01:24:18] (03Merged) 10jenkins-bot: Removed a few strange or obsolete i18n message strings [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98481 (owner: 10Yurik) [01:36:33] (03CR) 10Dr0ptp4kt: [C: 032] Improved zero subdomain detection [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98998 (owner: 10Yurik) [01:36:35] (03Merged) 10jenkins-bot: Improved zero subdomain detection [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98998 (owner: 10Yurik) [01:48:46] (03CR) 10Dr0ptp4kt: [C: 04-1] Hide header & add a welcome message (empty) to the landing page (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [01:49:45] (03CR) 10Dr0ptp4kt: [C: 032] Zero Config cleanup [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98480 (owner: 10Yurik) [01:49:48] (03Merged) 10jenkins-bot: Zero Config cleanup [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98480 (owner: 10Yurik) [01:49:57] (03CR) 10Yurik: Hide header & add a welcome message (empty) to the landing page (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [01:55:39] yurik, in the future would you please add me to the changes needing review, and then ping me on irc and, if i don't respond there, email, with the patch numbers to review? [02:13:46] (03PS1) 10Kaldari: Don't try to save if the form is empty and the page doesn't exist. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 [02:29:14] dr0ptp4kt, will do, sorry :) [02:29:26] dr0ptp4kt, btw, i answered one of yoru concerns [02:29:41] https://gerrit.wikimedia.org/r/#/c/98464/ [02:29:43] dr0ptp4kt, ^ [03:14:05] (03PS2) 10Legoktm: Don't try to save if the form is empty and the page doesn't exist. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [03:14:23] kaldari: the bot is kinda stupid, but there can't be a newline between the change id and bug number [03:17:43] oops [03:17:44] thanks for fixing it [03:18:10] (03CR) 10Legoktm: "FWIW, you can also use the nocreate parameter to the API (https://www.mediawiki.org/wiki/API:Edit) to prevent pages from being created." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [03:47:17] is that a good idea to always have styles separated from everything else and added via ->addModuleStyles instead of ->addModules ? [04:05:52] (03PS1) 10Yurik: Bug 57624: proper js resource loading in zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99027 [04:10:51] (03CR) 10Yurik: "Re inline CSS" (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [07:28:41] (03CR) 10Mxn: "My bad, I thought it needed to be localized because [[MediaWiki:Right-zero-edit]] mentioned it, but I'll add a note in translatewiki.net t" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98791 (owner: 10Mxn) [07:29:04] (03Abandoned) 10Mxn: (bug 57914) Added Vietnamese translations for Zero namespaces [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98791 (owner: 10Mxn) [07:46:16] (03CR) 10Siebrand: [C: 031] "Looks fine to me. I added Raimond as reviewer, because a message needs to be added as ignored once merged." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [09:15:49] yurik: only if the module only contains styles, and if you need it to work without JS as well. [09:17:16] thedj[wo1k], i do need it to work with and without js, and it is listed as required in the bigger module that is being added - basically there are two operations one after another - addModuleStyles(a) and addModules(b), and b depends on a [09:19:06] if it needs to work with and without JS, then there is no dependecy between the two [09:19:41] if there is, then you are putting to much into one CSS file [09:21:40] thedj[wo1k], could you take a look pls? https://gerrit.wikimedia.org/r/#/c/99027/ [09:22:07] thedj[wo1k], the .php adds mobile.zero.styles & mobile.zero [09:22:22] (03CR) 10TheDJ: Hide header & add a welcome message (empty) to the landing page (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [09:24:29] i don't know enough about how zero pages are built to really say something about the case in specific. [09:24:35] (03CR) 10Yurik: Hide header & add a welcome message (empty) to the landing page (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [09:26:41] thedj[wo1k], it seems zero adds http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroRatedMobileAccess/0f72bd5b4bb1bccbff265aae080be14e2f331a25/modules%2Fbanner.css [09:26:42] and http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FZeroRatedMobileAccess/0f72bd5b4bb1bccbff265aae080be14e2f331a25/modules%2Fredux.less [09:27:34] yurik: as far as I can see, 'mobile.zero.styles' should conceptually not have to be a dependency for a JS module [09:27:54] those two CSS files are listed as a dependency for another module (that has no CSS), and also added explicitly [09:28:27] or rather, it shouldn't be a dependency, but it seems it is. [09:28:47] i understand, will have to wrap my brain around it and optimize it [09:28:49] then again, i'm not sure the site even WORKS without JS. [09:28:53] hey yurik [09:28:58] sdehaan, yo! [09:29:07] getting a number of errors on the wikipedia search api [09:29:08] :) [09:29:18] vumi_wikipedia.wikipedia_api.APIError: {u'servedby': u'mw1124', u'error': {u'info': u'HTTP request timed out.', u'code': u'srsearch-error'}} [09:29:19] not good :( [09:29:26] and not getting back a JSON response [09:29:32] or a "Pool is full" error [09:29:40] bummer, need to get ops [09:29:48] has the rate of errors been steady? [09:29:53] not very often but more often than otherwise [09:30:26] sdehaan,is it something that just started happening, or has it been going on/off for a while at a low rate? btw, ops are at #wikimedia-operations [09:30:46] they would be the ones best equiped to track it down [09:30:56] ok thanks [09:31:52] yurik: https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader actually does explain it quite well. [09:32:31] thedj[wo1k], thx! i was thinking of reading up on rs loader, now's good time i guess... its only 4:30am :) [09:34:12] lol [10:30:54] (03PS1) 10Yurik: Added right-zero-edit i18n string [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99063 [10:35:23] (03CR) 10Siebrand: [C: 04-1] Added right-zero-edit i18n string (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99063 (owner: 10Yurik) [10:43:46] (03PS2) 10Yurik: Added right-zero-edit and group-zeroadmin i18n strings [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99063 [10:46:29] (03CR) 10Siebrand: [C: 04-1] "Sorry, Yuri. So many things that are not obvious, obviously..." (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99063 (owner: 10Yurik) [11:55:25] (03CR) 10Siebrand: Story 1401: Language Selector Overlay UI Redesign (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 (owner: 10JGonera) [12:21:50] (03PS2) 10Zfilipin: Adding a readme file in /tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 (owner: 10Mayankmadan) [12:22:00] (03CR) 10Zfilipin: [C: 032] Adding a readme file in /tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 (owner: 10Mayankmadan) [12:23:17] (03Merged) 10jenkins-bot: Adding a readme file in /tests/browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 (owner: 10Mayankmadan) [12:33:05] (03CR) 10Zfilipin: "Apologies for merging this after -1, I was reviewing several commits and gave +2 to the wrong one. :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 (owner: 10Mayankmadan) [12:38:05] (03PS1) 10Zfilipin: Where to find information on how to run Selenium tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99074 [12:40:05] (03CR) 10Zfilipin: "Created https://gerrit.wikimedia.org/r/#/c/99074/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 (owner: 10Mayankmadan) [15:08:49] (03PS3) 10Amire80: i18n: RTL beta icon for nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 [15:10:46] (03CR) 10Amire80: [C: 04-1] "Rebased + bug number added." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 (owner: 10Amire80) [15:11:06] (03CR) 10Amire80: "This still has the not-so-great SVG. See the bug." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 (owner: 10Amire80) [15:39:41] (03PS1) 10Yuvipanda: Follow NavigationDrawer pattern properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99097 [15:40:22] (03PS2) 10Yuvipanda: Follow NavigationDrawer pattern properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99097 [15:42:59] (03PS3) 10Yuvipanda: Follow NavigationDrawer pattern properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99097 [15:44:35] (03PS1) 10Yuvipanda: Exit when back is pressed with only one page in the backstack [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99099 [16:19:14] (03CR) 10Jhall: [C: 031] Where to find information on how to run Selenium tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99074 (owner: 10Zfilipin) [17:09:52] (03Abandoned) 10Yurik: Added right-zero-edit and group-zeroadmin i18n strings [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99063 (owner: 10Yurik) [17:10:34] dr0ptp4kt, good morning [17:10:52] ready to break the site? [17:26:34] (03PS3) 10Kaldari: Don't try to save if the form is empty and the page doesn't exist. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 [17:28:49] (03CR) 10Kaldari: "Legoktm: Well, we actually want them to be able to create pages from this interface, just not empty pages :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [17:39:59] yurik, i'm here. i'm ready to see the features go in with zero problems (integer, not string) :) sorry, forgot to set my status to away. i'm here. though. give me a couple minutes to skim email [17:44:49] dr0ptp4kt, could you check the two pending patches -- https://gerrit.wikimedia.org/r/#/c/99027/ is more important [17:45:10] hope we can get it into the depl in 15 min [17:45:43] and no worries about not replying before - I figured you weren't there :) [17:46:46] yurik, looking at 99027. regarding the QOTD-style message on the Special: page, it's unclear to me that Carolynne and Dan spoke and came to a resolution about supporting the concept writ large - i think it can wait until next week while we get clarity. gimme a few minutes to look at 99027 [17:47:03] sounds good [17:53:46] yurik, still looking [17:56:42] (03PS1) 10Robmoen: Add general errorHandling to VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99172 [17:59:25] zomg ive had the worst case of hiccups for the last 30 mins [17:59:31] i think they've stopped just in time for standup [18:00:54] (03CR) 10Dr0ptp4kt: [C: 032] "Okay, but fix the RL test module shortly after this." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99027 (owner: 10Yurik) [18:00:57] (03Merged) 10jenkins-bot: Bug 57624: proper js resource loading in zero [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99027 (owner: 10Yurik) [18:01:10] awjr|hiccup [18:01:13] ^ ^^ yurikk, ACTIVATE [18:01:36] hi MaxSem [18:02:01] MaxSem: I'll try to verify and merge that mobileview patch today [18:03:57] COOL [18:04:04] eh, caps [18:04:25] dr0ptp4kt, here we goo... [18:04:29] MaxSem: CAPS! [18:04:37] YES [18:04:41] yurik, jeopardy music [18:04:48] MaxSem: so... does mobileview have a hook that lets me get pageimages as a prop? :D [18:05:01] trying to reduce the number of requests... [18:05:21] feel free to create a card for it [18:05:45] MaxSem: oo, sweet [18:05:55] MaxSem: I'll just file a bug and then poke awjr later on. [18:10:48] (03CR) 10Legoktm: "Right. I was thinking that if the user passes an empty string, you can also add on the nocreate parameter, and then handle that error grac" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [18:15:51] dr0ptp4kt, start poking at en.wiki pls [18:16:08] yurik, ok [18:19:01] brion: hai! :D [18:20:55] hmm jdlrobson - I think I know what to do with line numbers [18:23:14] MaxSem: tested it, seems to work as expected. May I +2? [18:23:25] gogogogog [18:23:35] (03PS2) 10Yuvipanda: Introduce new mobileview parameter, onlyrequestedsections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98006 (owner: 10MaxSem) [18:23:37] dr0ptp4kt, ok, its fully live, v5 too [18:23:44] might need to restart testing - [18:23:55] seems like enwiki is 5, not 4 [18:23:57] yurik, what's v5? [18:24:00] yurik, oh [18:24:01] latest [18:24:10] dr0ptp4kt, now on to create db schema :) [18:24:15] yurik, ok. i'll run the automated script now for one carrier [18:24:21] ok, thx [18:25:14] (03CR) 10Yuvipanda: [C: 032] "Tested, seems to do what it should do!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98006 (owner: 10MaxSem) [18:25:19] MaxSem: thanks a lot :) [18:25:52] (03Merged) 10jenkins-bot: Introduce new mobileview parameter, onlyrequestedsections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98006 (owner: 10MaxSem) [18:27:27] dr0ptp4kt: btw, changing from http to https is also a single switch, but figuring out *when* to do that isn't simple :) [18:27:50] YuviPanda, agreed [18:28:08] dr0ptp4kt: so from what I'm reading, the current plan is to just support them in the reboots? [18:28:19] brion: there are patches for you :D [18:29:25] YuviPanda, yeah, in terms of making optimizations - the reboots are a better place to engineer delegate / hook / event handler things that would support the ability to (a) try to get the config, then (b) modify the scheme:// and rendering options [18:29:37] dr0ptp4kt: yeah, agreed. [18:29:39] whee [18:30:33] dr0ptp4kt: think you guys can pitch in for a sprint or so to add this support? :) [18:30:35] YuviPanda and mhurd, can i just setup a meeting to talk through the configuration and anticipated hooks with you guys for w0 in the rebooted apps? [18:30:51] dr0ptp4kt: sure! [18:30:54] YuviPanda, i'm planning on it as part of my annual goals. cc mhurd [18:31:02] dr0ptp4kt: sweet! [18:31:08] dr0ptp4kt: ya, but today i may not have time [18:31:14] tfinc: am I in the right hangout? [18:31:29] YuviPanda: yup, i was just checking something for jdlrobson. one sec [18:31:30] (03CR) 10Jdlrobson: Bug 57624: proper js resource loading in zero (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99027 (owner: 10Yurik) [18:31:36] tfinc: ah, sure [18:32:09] YuviPanda and mhurd, hopefully i can do the full feature set for the first release of the reboot, but it may need to be a subsequent reboot. for the first stable release of the code i mainly hope to just have the delegate / hook / event handler stuff present so that its baked in as at least supportable [18:32:29] dell announcing 4k monitors.... ooooooh [18:32:44] now where's my apple thunderbolt 4k display with integrated everything for inflated price!? [18:33:30] (03CR) 10Jdlrobson: "Please do.. although confusingly now we have one README written in mediawiki markup and one in markdown - this is also weird." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98777 (owner: 10Mayankmadan) [18:37:00] chrismcmahon: getting a bunch of jenkins build failures that appear to be the result of a runtime error? [18:38:08] yeah awjr seems to be a perfect storm, Zelkjo merged a change to the shared code that broke everything, but I'm also getting at least one error about the WMF account itself, trying to sort that right now. [18:38:20] YuviPanda: hey [18:38:22] heh ok thanks chrismcmahon [18:38:30] hey kaity [18:38:32] meeting, brb [18:38:33] awjr: sorry for the hassle [18:38:43] YuviPanda: I'm still kinda confused about external link [18:38:45] np chrismcmahon it happens [18:38:52] yurik, you seeing anything with fatalmonitor? [18:38:56] kaity: give me 10 mins? meeting [18:39:04] dr0ptp4kt, nope [18:39:04] YuviPanda: ok! [18:39:06] why? [18:39:12] yurik, just checking [18:39:18] MaxSem: just saw your wap deprecatin email - makes me happy :D [18:39:24] dr0ptp4kt, everything ok? i'm about to push sql changes [18:39:29] :) [18:40:30] MaxSem, just to double check, this seems right? [18:40:31] mwscript sql.php metawiki extensions/FlaggedRevs/backend/schema/mysql/FlaggedRevs.sql [18:40:33] yurik, that should be safe. the test run on 250-99 didn't cause problems and manual walktrhough on 413-02 only turned up an inconsistency for the 'not supported' language that doesn't warrant a rollback. i filed a bug for that [18:40:45] yuirk, ACTIVATE [18:40:53] awjr: such a helpful message: "This node has an availability policy that will "CloudBees Swarm". Currently, this mandates that the node be offline." A different message points me to a page saying our account details are no longer offered. Anyway, sorting now... [18:40:56] yurik, Y so scared?:P [18:41:06] don't like wiping sql dbs :) [18:41:12] @_@ [18:41:13] you won't [18:41:24] yurik, "MaxSem said" [18:41:37] yurik: http://xkcd.com/327/ [18:41:49] MaxSem, there is no sql.php :))) [18:42:10] (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "android-apt-compiler: [wikipedia] /Users/brion/src/wiki/apps-android-wikipedia/wikipedia/res/layout/activity_main.xml:7: error: Error: No " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99097 (owner: 10Yuvipanda) [18:42:19] MaxSem, yurik@tin:/a/common/php-1.23wmf5$ mwscript sql.php metawiki extensions/FlaggedRevs/backend/schema/mysql/FlaggedRevs.sql [18:42:39] PHP Warning: fopen(metawiki): failed to open stream: No such file or directory in /a/common/php-1.23wmf5/maintenance/sql.php on line 74 [18:42:47] ha [18:42:59] lololol [18:43:05] *fail [18:43:13] ok, how do i get this baby up? [18:43:23] it telss you that it can't find the sql file, not sql.php [18:43:39] yes, but the file is there :) [18:43:59] should i give absolute path? [18:44:00] s/metawiki/--wiki=metawiki/ [18:44:14] stupid het deploy bug [18:44:23] brion: gah! let me fix that [18:44:33] yurik, ^ [18:44:36] yei!!! [18:44:38] thx, worked [18:44:40] :) [18:47:12] kaity: back! [18:47:18] kaity: there? [18:47:25] yes [18:47:38] kaity: so, 'external link' is an Android specific feature [18:47:47] YuviPanda: oh I see [18:47:54] kaity: imagine I email you a link to a wikipedia article. You see my email in GMail app, and click the link [18:47:55] what is the scenario? [18:48:02] kaity: it'll open up in the wikipedia app (this is configurable) [18:48:16] kaity: so the user came to the app from an external application. [18:48:29] (03PS1) 10Dr0ptp4kt: Make the shell script kicking off PhantomJS only look in same dir. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99179 [18:48:33] YuviPanda: ok cool [18:48:38] kaity: does that make sense? [18:48:49] ^^yurik, ignore for now. just a tweak to the phantom script i caught on my local host [18:48:55] doesn't impact anything [18:48:59] ok [18:49:29] yurik, i'll be changing rooms pretty soon and switching from ethernet to wifi pretty soon. just wanted to let you know in case my irc connection drops [18:50:04] YuviPanda: yes, i think we would use that in IOS too [18:50:42] kaity: from what I understand the iOS feature isn't as versatile. You can't just mail someone a https://en.wikipedia.org/wiki/Water link and have it open in the app. Might be wrong tho [18:51:26] (03PS4) 10Yuvipanda: Follow NavigationDrawer pattern properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99097 [18:51:27] brion: updated patch. [18:51:33] (03CR) 10Jdlrobson: [C: 04-1] Add general errorHandling to VisualEditorOverlay (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99172 (owner: 10Robmoen) [18:51:40] mhurd: Do you know if that's possible? (clicking on a wikipedia link in email or browser takes you to app)? [18:52:01] YuviPanda: whee [18:52:27] kaity: not sure exactly... will read up on it [18:52:33] YuviPanda: https://support.google.com/glass/answer/3297404?hl=en :D [18:52:49] tfinc: sweeet! :) [18:52:56] YuviPanda: mhurd here are the history assets so far [18:52:57] https://www.dropbox.com/sh/s7ixd3b71wdis66/0-d-RGCQa- [18:53:01] kaity, mhurd: so it's possible for us to handle special links, like 'wikipedia://en.wikipedia.org/wiki/Foo' [18:53:02] I'll send in email too [18:53:12] kaity: thanks! [18:53:15] but we can't automatically take over an email link to 'http://en.wikipedia.org/wiki/Foo' etc [18:53:21] brion: ah. makes sense [18:53:27] brion: mhurd yeah, you can handle them based on protocol, but nobody's going to send around a wikipedia protocol ;) [18:53:45] mhurd: on Android you can regex match URLs, so we're handling everything that's *.wikipedia.org/wiki/.* [18:54:30] kaity: hmm, dropbox tells me 'cannot preview', but I guess that's just dropbox not being able to handle SVGs [18:54:51] yeah that's just dropbox [18:54:52] YuviPanda: that's pretty cool! [18:54:56] if you download the file it'll work [18:54:56] YuviPanda: yea its goofy, should work when you download [18:55:00] kaity: sweet! [18:55:29] brion: Im going to skip thumbnails there for now. I want us to add thumbnailing support for action=mobileview, and then deal with it at a HTTP layer [18:55:59] YuviPanda: hmmmmmm, could do [18:56:34] brion: vastly cleaner, IMO. since then every article in history will have a cached image thumbnail. also much simpler. [18:56:50] hmm this raises another question to me [18:57:00] if we try to load a page, but it doesn't complete, should we store a history entry? [18:57:23] brion: probably not. [18:57:33] brion: but right now if we try to load a page, and it doesn't load... we just sortof crash :D [18:57:35] yeah that'll keep our lives simpler :) [18:57:38] haha [18:57:50] jgonera: i'm reviewing the languages overlay now - in the designs there is a count of languages next to the heading but this is not present - is that something you are aware of? https://www.dropbox.com/s/s0lzlo5oeyyabmf/language-overlay-01.png cc. kaity [18:57:53] well we have a card for not losing your data if that happens ;) [18:57:55] we'll get to it.. [18:58:08] jdlrobson, yes, we decided that we get rid of it with kaity [18:58:11] brion: it's already there, in this iteration even :D I'll make a small error page [18:58:20] jdlrobson, there's no way this makes sense when variants are present too [18:59:32] brion: I moved the drawer below the searchbar. should deactivate the searchbar or something when the drawer is open [18:59:39] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=57994 [18:59:43] * YuviPanda waves at awjr [18:59:48] thx [19:00:02] jdlrobson: jgonera We think the number of languages isn't very important, a user just wants to find the language that they speak quickly [19:00:24] kaity: fyi this gets confusing when reviewing - had you and juliusz not been here i would have -1ed it :) [19:00:39] jdlrobson: sorry! [19:00:46] I see, I should have update the story card [19:00:53] updated* [19:00:57] awjr: poke back when you have a couple of mins :) [19:01:00] can you simply add a comment/ update ac on the card in future when the design changes like this? That way when reviewing I know what to look for :) [19:01:03] thanks guys :) [19:01:14] yeo [19:01:16] yep [19:01:20] damn keyboard [19:01:25] (03CR) 10Brion VIBBER: "Couple notes:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99097 (owner: 10Yuvipanda) [19:01:39] be back in 30 mins [19:01:58] brion: yeah, need to handle the touch feedback. [19:03:01] remind me why we're not using an action bar? [19:03:04] brion: I'll do the tap on top-right to toggle, but want the icon to actually be there first [19:03:07] is it not customizable enough for some reason? [19:03:16] brion: custom views in Actionbar are a pain [19:03:23] do we need custom views in the actionbar? [19:03:49] brion: Android has 'searchprovider' support which hooks into a... contentprovider. [19:03:58] brion: and since our search results are over the network, it's kinda tortorous [19:04:26] brion: plus doing things like that 'spinning icon when search request is up' is kinda... not easy. [19:04:34] hmm [19:05:27] brion: it's not that hard to hook up these behaviors. [19:06:29] brion: I'll have appropriate open/close actions for that, and put them on the bus [19:07:00] YuviPanda: so there's another oddity which is that when we select text in the web view, the selection action bar overlay comes up but instead of overlaying the standard action bar (since there isn't one), it pushes down our custom search fragment [19:07:15] brion: I think that's fine? [19:07:21] meh [19:07:26] (03CR) 10Jdlrobson: [C: 04-1] "Some minor nitpicks then I'm happy to merge. Seems to work as expected and doesn't introduce any regressions." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 (owner: 10JGonera) [19:08:35] MaxSem: i'll take a look at the diff code now - so don't work on it :) [19:08:47] okay [19:08:57] brion: also, the 'quick return' thing - I'm not sure how easy it is to do with the normal actionbar [19:09:20] MaxSem: how do i get setup? I'm only seeing blank diffs.. [19:09:25] dr0ptp4kt, fini! flagrevs are live :) [19:09:38] jdlrobson, should just work [19:09:42] mm [19:09:44] brion: if we run into major issues in the future, we can always investigate moving. I think the code is compartmentalized enough for that. [19:09:56] did ya update the core? [19:10:11] yurik, that's for metawiki *only*, correct? or is it in effect for the code that retrieves configs from metawiki as well (zrma extension)? [19:10:25] 1st [19:10:30] ahh need to disable JS.. [19:10:37] YuviPanda: *nod* [19:10:49] dr0ptp4kt, lets make sure it works first -- when it takes data from the live wiki [19:11:26] brion: and re: touch behavior - I think the way to fix it is with a ListView [19:11:34] brion: I'll do that in a followup patch? [19:11:37] along with the search behavior [19:11:42] sounds good [19:11:52] brion: sweet [19:12:07] you want to patch up the W icon also or shall i pick up my previous patch on that? [19:12:31] brion: I'll amend and merge that one after these get merged [19:12:35] and then make it toggle the drawer [19:12:38] awesome [19:13:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Per IRC discussion:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99097 (owner: 10Yuvipanda) [19:18:30] mhurd: give me a shout when you have stuff ready to poke at :) [19:20:47] yurik, a low traffic config to use might be sri lanka or xl. [19:20:53] (03CR) 10Robmoen: Add general errorHandling to VisualEditorOverlay (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99172 (owner: 10Robmoen) [19:21:05] dr0ptp4kt, what do you mean? [19:21:23] yurik, to validate that the flaggedrevs stuff is working as expected [19:21:44] yurik, it certainly seemed to work on the opera config page [19:22:10] dr0ptp4kt, i meant - set your local MW to use remote api [19:22:21] instead of pulling zero config from localhost [19:22:24]