[00:00:34] YuviPanda: ok i'll check in a few, gotta run to a series of meetings now [00:00:59] (03PS2) 10Dr0ptp4kt: Support "click to view" on mdot when showImages=false but mdot is free. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99272 [00:01:08] violetto1: enjoy your meetings :) [00:06:59] violetto1: heading to bed now :) do email back responses. [00:07:08] violetto1: failed at sleeping before 5AM, let me at least try 6AM :) [00:07:12] * YuviPanda waves [00:08:20] kaity: heading to sleep, do look at the icons email I sent :) [00:08:23] * YuviPanda goes to sleep, for real [00:12:11] bah [00:13:37] ok where the hell was i [00:13:41] finishing up builds yay [00:18:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Merging this as-is per previous IRC discussion, will add a bit of commentary after builds go out." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/98991 (owner: 10Mhurd) [00:22:51] goodnight YuviPanda [00:25:40] ugh " "Invalid IPA: The keychain-access-group in the embedded.mobileprovision and your binary don't match."" again [00:25:45] * brion stab stab stab [00:25:48] @_@ [00:25:53] i seem to have destroyed our story wall [00:25:59] awjr: i think you accidentally deleted the in analysis column? [00:26:08] rest looks fine though [00:26:10] jdlrobson: i renamed it to 'needs analysis' [00:26:12] ah i have to adjust the signing on build, not just after. [00:26:19] jdlrobson: but now i dont even see the story wall anymore :p [00:26:27] something went sideways. [00:26:29] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/grid?aggregate_property%5Bcolumn%5D=story+points&aggregate_type%5Bcolumn%5D=sum&color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BInfrastructure%5D&filters%5B%5D=%5BIteration%5D%5Bis%5D%5B%28Current+iteration%29%5D&group_by%5Blane%5D=status&lanes=In+Anal [00:26:30] %2CReady+for+Estimation%2CReady+for+Development%2CIn+Development%2CAwaiting+Final+Code+Review%2CReady+for+Testing%2CIn+Testing%2CReady+for+Signoff%2CAccepted&tab=Story+Wall [00:26:33] Wikipedia has corrupted me and now I always think of "IPA" as being International Phonetic Alphabet (or Indian Pale Ale). [00:26:35] that's what i see [00:26:47] Identity, Policy, Audit [00:26:49] lol jdlrobson url got cut off, i think [00:26:51] I assume. [00:26:57] In Anal [00:26:58] tinyurl jdlrobson? [00:27:02] heh yes [00:27:27] url is too big for tiny url [00:27:32] LOLOLOLOLOL [00:27:32] wtf [00:27:48] it's ok, i'll make a new wall. [00:27:56] awjr: http://goo.gl/zd2Gl5 [00:28:13] ah thatnks jdlrobson, that gives me a headstart [00:29:16] lord have mercy the mingle urls are a nightmare [00:29:23] jdlrobson: if you refresh the interface, do you see a 'story wall' tab? [00:29:33] and if you click on it, do things like mostly as expecteD? [00:29:39] s/like/look [00:29:52] brion: welcome back [00:29:54] did you see my txt ? [00:29:57] thanks [00:30:02] yes, when i woke up :P [00:30:07] this cold is kicking my ass worse than i thought [00:30:18] brion: then get those builds in and go back to bed [00:30:24] sounds like a plan [00:30:29] both should be good to go [00:30:31] iOS build is up :D [00:30:32] and please mail out [00:30:36] uploading android now [00:30:38] once their both ready [00:30:39] thanks [00:32:21] Which part of Mingle isn't a nightmare? [00:32:51] a lot of it, actually [00:32:54] at leat imo [00:32:58] s/leat/least [00:34:47] awjr: fundraising fail.. https://www.facebook.com/photo.php?fbid=707541635924307&l=2c27550dee [00:35:10] Elsie: while the UI is kind of annoying, it's incredibly powerful and flexible. for us it provides awesome workflow management, prioritization, estimation/velocity tracking, backlog management, etc [00:35:24] it's more complicated than trello, but we need it to be [00:35:45] oops jdlrobson [00:35:59] awjr: i'm messaged megan to let her know [00:36:01] jdlrobson: mail fr-tech [00:36:02] kk [00:36:10] it's a more general issue [00:36:25] awjr: And it's non-free. But if it's helping get work done... [00:36:45] jdlrobson: does the story wall look ok now and is there a tab for it (after you refresh the interface) [00:37:01] Elsie: yeah, that is a major downside. [00:37:31] i have yet to see a free-as-in-freedom that works well :( [00:37:34] Eep, banners on mobile? [00:37:35] er [00:37:41] free-as-in-freedom tool [00:37:46] I thought those were disabled. [00:37:54] Elsie: yeah they're doing single impression banners on mobile this year [00:37:55] story wall still broken fro me awjr [00:38:03] screenshot jdlrobson? [00:38:06] We stopped supporting "text WIKI to whatever to donate $10" I think. [00:38:15] (03CR) 10Kaldari: Don't try to save if the form is empty and the page doesn't exist. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [00:38:16] Donating from a mobile device is non-trivial, isn't it? [00:38:36] last time i tried it seemed not much harder than on desktop [00:38:50] but i havent tried for real since the official campaign began since i only saw the banner once :p [00:39:18] jdlrobson: replied to your question at https://gerrit.wikimedia.org/r/#/c/99020/ [00:39:22] jdlrobson: and/or try hard refresh [00:41:06] kaldari: i fixed that mobile view link bug [00:41:19] awjr: awesome! [00:41:35] i took a peak since i wrote the original footer link generation code and it was a quickie [00:43:13] (03CR) 10Yurik: "We can't do this - in order to vary on showImages, varnish needs to be able to decide if the request is with images or without. But it has" (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99272 (owner: 10Dr0ptp4kt) [00:43:22] (03CR) 10Yurik: [C: 04-1] Support "click to view" on mdot when showImages=false but mdot is free. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99272 (owner: 10Dr0ptp4kt) [00:43:59] (03CR) 10Kaldari: Don't try to save if the form is empty and the page doesn't exist. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [00:53:55] (03CR) 10Dr0ptp4kt: [C: 04-1] "The pages are already varied on X-CS and X-Subdomain today, so doesn't this solution allow us to avoid further varying the cache until a f" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99272 (owner: 10Dr0ptp4kt) [01:01:58] brion: does your app crash when you search for https://en.m.wikipedia.org/wiki/Guy_Lalibert%C3%A9 ? [01:02:30] errr .. when you tap on it as a search result [01:02:33] mine does [01:02:37] with sprint 2 [01:02:49] thankfully it didn't wipe history [01:04:08] brion: yeah the android app doesn't seem to like apostrophes [01:05:28] awjr: still broken for me [01:20:19] (03PS4) 10Jdlrobson: Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 [01:21:16] awjr: https://gerrit.wikimedia.org/r/#/c/94620/7/includes/specials/SpecialHistory.php thoughts? [01:26:48] Jdlrobson I'll have to look tmrw, I'm away from my laptop celebrating Sarah 's successful defense of her masters thesis [01:27:08] sweet :) [01:27:12] tell her congrats from me :) [01:27:27] She says thanks :D [01:28:04] (03PS8) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 [01:28:25] kaity, vbamba1 I'm not going to finish all the styling changes to profile before tomorrow so I can either do only some updates and the rest of them later or I'll finish it all tomorrow but then it will be deployed next week [01:28:55] (03CR) 10Kaldari: "Legoktm: See inline comments." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [01:34:07] (03CR) 10Jdlrobson: Don't try to save if the form is empty and the page doesn't exist. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [01:47:19] awjr: i didn't see https://bugzilla.wikimedia.org/show_bug.cgi?id=58014 come into the app sprint board. any idea why ? [01:47:27] it was cut an hour ago [01:48:04] No idea tfinc, I can take a look tmrw [01:48:08] thanks [01:48:15] Have other bugs been coming in? [01:48:33] i'm going to have to check now as i've been looking at the sprint board [01:49:46] awjr: confirmed. there are other bugs [01:54:33] OK probably something specific with the bug, like it changed components or something. Anyway, I'll look tmrw [01:54:57] (03PS1) 10JGonera: Update styling in user profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99298 [01:55:24] kaldari, would you have time to review ^ today? [01:56:00] sure, looks simple enough [01:56:47] ok, thanks [02:00:49] http://news.cnet.com/8301-1023_3-57614591-93/google-gives-free-glass-upgrades-to-early-adopters/ [02:29:13] (03PS4) 10Kaldari: Don't create empty user descriptions for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 [02:29:50] (03CR) 10jenkins-bot: [V: 04-1] Don't create empty user descriptions for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [02:49:59] (03CR) 10Yurik: "Well, but that's the point - right now we don't rely on any X-CS varying, other than to render the banner - that was the point of all our " [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99272 (owner: 10Dr0ptp4kt) [02:54:23] (03CR) 10Kaldari: [C: 04-1] "Looks fine except that the edit button overlaps the user description." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99298 (owner: 10JGonera) [02:56:10] (03PS5) 10Kaldari: Don't create empty user descriptions for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 [03:31:49] (03PS2) 10JGonera: Update styling in user profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99298 [03:50:10] (03CR) 10Kaldari: [C: 04-1] Update styling in user profiles (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99298 (owner: 10JGonera) [03:53:36] (03PS3) 10JGonera: Update styling in user profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99298 [03:56:17] (03CR) 10JGonera: [C: 04-1] Story 1401: Language Selector Overlay UI Redesign (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 (owner: 10JGonera) [03:57:57] (03PS2) 10JGonera: Story 1401: Language Selector Overlay UI Redesign [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 [04:42:50] (03PS1) 10Kaldari: More robust permission checking for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99320 [04:48:29] (03CR) 10Kaldari: [C: 032] Update styling in user profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99298 (owner: 10JGonera) [04:49:05] (03Merged) 10jenkins-bot: Update styling in user profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99298 (owner: 10JGonera) [05:44:48] (03PS1) 10Yurik: Removed X-Images variance & legacy url params [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99326 [07:35:09] (03CR) 10Yurik: [C: 04-1] "Adam, I removed and re-added you on this issue to get rid of -2 (since the prereqs have been met). Yet, i found a security bug - see comm" (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95657 (owner: 10Dr0ptp4kt) [07:46:31] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 (owner: 10JGonera) [07:50:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [09:44:46] (03PS6) 10Yurik: Always on banner on special, add a welcome message to the landing page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 [09:46:05] (03PS7) 10Yurik: Always on banner on special, add a welcome message to the landing page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 [10:24:53] (03CR) 10Siebrand: [C: 031] Always on banner on special, add a welcome message to the landing page [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/98464 (owner: 10Yurik) [10:50:03] (03CR) 10Hashar: "ULS change merged in, will revisit this one." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [11:14:37] (03PS6) 10Hashar: QA: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 [13:47:54] (03PS1) 10Zfilipin: Moved information on how to run Selenium tests to a separate README file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99391 [13:49:09] (03Abandoned) 10Zfilipin: Where to find information on how to run Selenium tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99074 (owner: 10Zfilipin) [14:45:45] (03PS1) 10Yuvipanda: Add minimal styling to the content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99404 [17:23:39] (03CR) 10Jhall: [C: 031] Moved information on how to run Selenium tests to a separate README file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99391 (owner: 10Zfilipin) [17:35:32] (03CR) 10Dr0ptp4kt: "Faidon, would you please advise us on how to vary the cache between now and the ESI implementation to support "click here to view images" " [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99272 (owner: 10Dr0ptp4kt) [17:46:35] (03CR) 10Jdlrobson: [C: 031] "Anyone listed feel free to merge :-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99391 (owner: 10Zfilipin) [17:52:30] (03CR) 10Jdlrobson: [C: 032] Story 1401: Language Selector Overlay UI Redesign [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 (owner: 10JGonera) [17:53:13] (03Merged) 10jenkins-bot: Story 1401: Language Selector Overlay UI Redesign [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98743 (owner: 10JGonera) [17:53:17] awjr: in analysis column is on far right for me [17:53:59] jdlrobson: if you click on 'story wall' tab? [17:55:07] yup [17:55:11] it's on far right rather than far left [17:55:30] @_@ [17:55:36] ok i'll look shortly jdlrobson, on the phone right now [17:56:23] (03CR) 10Jdlrobson: [C: 04-1] Don't create empty user descriptions for User Profile (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [17:58:40] (03CR) 10Jdlrobson: [C: 032] Ensure title arg isn't set twice when creating 'mobile view' link (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99270 (owner: 10Awjrichards) [17:59:16] (03Merged) 10jenkins-bot: Ensure title arg isn't set twice when creating 'mobile view' link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99270 (owner: 10Awjrichards) [17:59:33] (03PS2) 10Cmcmahon: Moved information on how to run Selenium tests to a separate README file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99391 (owner: 10Zfilipin) [17:59:52] jdlrobson: can you send me a screenshot? [17:59:54] looks fine for me [17:59:57] (03CR) 10Cmcmahon: [C: 032] "mergin', per the +1" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99391 (owner: 10Zfilipin) [17:59:59] awjr: sure [18:00:27] awjr: http://imgur.com/TsO80SW [18:00:41] jdlrobson: click 'reset' on the story wallt ab [18:00:58] awjr: ok that seems to have worked [18:01:03] that was not clear ui at all [18:01:17] :p [18:01:58] (03Merged) 10jenkins-bot: Moved information on how to run Selenium tests to a separate README file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99391 (owner: 10Zfilipin) [18:04:58] (03CR) 10Jdlrobson: "A few suggestions but not enough to warrant a -1" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99320 (owner: 10Kaldari) [18:05:12] (03PS6) 10Jdlrobson: Hard refresh the main page on an edit. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98034 [18:05:58] (03PS6) 10Kaldari: Don't create empty user descriptions for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 [18:07:48] (03PS1) 10Yuvipanda: Add ACRA error reporting [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99433 [18:11:46] (03CR) 10Kaldari: More robust permission checking for User Profile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99320 (owner: 10Kaldari) [18:14:16] (03PS2) 10Kaldari: More robust permission checking for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99320 [18:14:39] jdlrobson: Thanks for the code reviews! [18:16:36] (03CR) 10Jdlrobson: [C: 031] More robust permission checking for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99320 (owner: 10Kaldari) [18:16:42] kaldari: ^ i'll let MaxSem +2 this one [18:16:53] looking [18:17:26] jdlrobson: Yeah, I wasn't 100% sure if quickCanUser was the right check to use here. It's not 100% foolproof, but it avoids expensive queries. [18:17:55] I suppose it depends on how critical a function we consider editing the user profile description [18:18:40] (03CR) 10MaxSem: [C: 032] More robust permission checking for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99320 (owner: 10Kaldari) [18:19:17] (03Merged) 10jenkins-bot: More robust permission checking for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99320 (owner: 10Kaldari) [18:19:29] kaldari, quickUserCan is appropriate - 100% bulletroof checks are supposed to be run only when user actually attempts to edit something [18:23:59] MaxSem: that makes sense [18:24:01] (03PS14) 10Jdlrobson: VE editing on tablets in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [18:24:13] (03CR) 10Jdlrobson: [C: 032] VE editing on tablets in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [18:25:02] jdlrobson: https://gerrit.wikimedia.org/r/#/c/99020/ fixed now [18:25:27] kaldari, I just hope that we won't explode if AbuseFilter or something prevents editing:) [18:25:46] (03Merged) 10jenkins-bot: VE editing on tablets in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/93916 (owner: 10Robmoen) [18:25:47] (03CR) 10Jdlrobson: [C: 032] Don't create empty user descriptions for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [18:26:02] I merged the UserProfile style updates from Juliasz last night, so those should be on the train today [18:26:50] MaxSem: actually, we do need to add some error handling [18:26:53] awjr: can i have priority changing rights on bugs? We have a bug in awaiting final code review which should really be right at the bottom [18:27:08] awjr it seems if no priority is set it is assumed to be the most important [18:27:49] (03Merged) 10jenkins-bot: Don't create empty user descriptions for User Profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99020 (owner: 10Kaldari) [18:29:04] You can't already change priorities, jdlrobson? [18:29:13] i didn't think so.. [18:30:08] (03CR) 10Jdlrobson: Enable editing on fishbowl wikis (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 (owner: 10Jdlrobson) [18:30:22] You have the same rights I do so you should [18:30:25] (03PS5) 10Jdlrobson: Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 [18:31:16] awjr: how do i order things in this?! [18:32:00] ahh the tiny classic rank cards checkbox in the top left corner ux trick ;-) [18:32:22] ok the world makes sense again :) [18:33:05] :-) [18:56:37] (03CR) 10Kaldari: [C: 04-1] "This doesn't work for me. See inline comments for details." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96175 (owner: 10Jdlrobson) [19:10:54] dr0ptp4kt, i was thinking about that patch, and i think what we could do is always add a redirector to the image links - and then confirm with js if we should redirect or ask [19:17:16] yurik, you talking about the "click to view" thing? [19:17:49] dr0ptp4kt, yep. Also, have you looked at that email? what seems to be the concern? [19:19:01] yurik, i get what you're saying on the "click to view" thing. we'll just need to get buyin on cache variance from faidon and mark. [19:19:28] dr0ptp4kt, we don't have to with what i'm proposing [19:20:02] and besides, while we vary on x-cs, we don't have to ask them at all [19:20:11] regardless of how we choose to go [19:20:22] yurik, regarding the email on the qotd-like stuff, i don't have any particular concern, just want to get final confirmation from carolynne and dan on what to do. my recommendation is that the verbiage be carrier specified, with approval by the business, just like banners, if it is to be a supported feature. [19:20:23] but the point is - we don't have to make different html [19:21:12] yurik, on the "click to view", are you thinking that in the case that the user says "don't warn me", the tags in the dom just get modified client side to "inject" the images? [19:21:18] i'm still failing to understand the issue with the email, but lets go one issue at a time - clicking is first :) [19:21:32] (ditto if the user says "show me images this time" or whatever) [19:21:49] okay, "click to view"... [19:22:41] dr0ptp4kt, first of all, in the rare case of allowing "m", but wanting to limit image views with a fake varning, are we ok with showing the smaller image as part of m? [19:23:21] in other words, should the regular m. be customized in any way visually? [19:23:28] before cilcking on the image [19:24:17] yurik, the "fake warning" i think would be "Display images? [ No ] [ Yes ] [ Yes, always ]" or something to this effect, correct? [19:24:48] yurik, i think the concern from the carriers is that the thumbnails in the page cause unnecessary bandwidth usage. [19:25:33] dr0ptp4kt, but if they agreed to m., they agreed to images, is it not? [19:25:41] because we can't really change the way m. looks for each carrier [19:28:15] yurik, i think for this one particular carrier they just wanted to limit the automatic display of thumbnails, in other words forcing an additional click. let me clarify with carolynne, though, whether she perceives that carrier as actually wanting to charge for images. if the use case is that images are charged, well, ho-hum, i guess we could just supply the normal charge warning. but at least the user would be getting normal pages non-charge [19:29:50] we really ought to crarify that, because i was under the impression ( dfoy ?) that anyone on m. zero rates images [19:32:06] yurik, dr0ptp4kt, the last I heard from Csrolynne was that they were still planning to charge for images (zero. only) [19:32:47] dfoy, in that case we simply should not list them as allowing m [19:33:40] we can't show banners for a page view that's only partially free [19:36:16] dfoy, thx. so i think we could modify the patch to account for that. yurik and i will need to figure out the cache variance stuff with faidon and mark, still. yurik, one notion i floated was not showing images by default, but making it easy for users to turn on images...if the carrier supports them for free, it would prompt the user about pagespeed or something. and if the user is on a carrier that charges, it could warn them about the charge [19:36:27] yurik: to my knowledge, they are not listed as supporting m.wikipedia.org [19:37:13] dr0ptp4kt, if they are not listed as free anyway, whats the issue? [19:38:42] i'm a bit confused - adam, if you are proposing a new "turn off images on mobile" button - that's a feature request for mobile team :) [19:39:34] we could write it of course, but it shouldn't only be available to a subset of m. users [19:39:52] yurik, i think we'll need to discuss this face to face so that we're all on the same page. dfoy, would it be possible to meet from 3-4 pacific today? [19:40:07] i'm thinking it would be good to go over the story wall like normal [19:41:20] dr0ptp4kt, dfoy or better yet - at 12? :) I have a meeting at 1:30 [19:41:47] yurik + dfoy, that would work for me [19:41:53] (12-1 pacific) [19:42:03] yurik, dr0ptp4kt: not going to be able to do 12 - have a lunch meeting with Kul and Adele [19:42:21] yurik, will 3-4 pacific work? dfoy? [19:42:30] 2:30 ? [19:42:47] yurik, that's /my/ status update with tomasz [19:42:58] i thout it was at 2? [19:43:09] yurik, dr0ptp4kt: tomorrow ok? [19:43:22] dfoy, sure [19:43:31] dfoy, yurik, tomorrow works for me. dfoy, you got the scheduling covered or want me to do it? [19:43:35] i could be here at 3, that's also ok [19:44:10] or tomorrow [19:44:16] yurik, dr0ptp4kt: I can schedule if pushing to tomorrow. [19:45:01] dfoy, does 3 today work for you? this is funny. [19:45:03] whichever you guys decide, yeither today or tomorrow, but pls before 3 tmrw [19:45:08] today is ok [19:45:40] dr0ptp4kt: Adam, are you available at 3 today? [19:45:57] hmm, no brion or tfinc [19:47:16] dfoy, i am. i'll schedule it and we'll be good. [19:48:09] dr0ptp4kt: ok thx [19:48:27] YuviPanda, this chanelz iz all zero now! [19:48:41] yurik: YOU HAVE TAKEN OVER! [19:48:50] dr0ptp4kt: yurik can I close that pull request now? [19:49:03] YuviPanda, wa? [19:49:25] * yurik is clueless [19:49:33] yurik: zero support for legacy app? since i think we decided they'll be useless because https...? [19:50:07] YuviPanda, are you sure we don't want to switch it to http? or is that not part of that magic string? [19:50:21] yurik: I don't want to switch *everyone* to http [19:50:25] that's trivial too, but... [19:50:30] HTTPS for everyone! [19:50:31] i hear you [19:50:43] moreover, i think that's the way it should be :( [19:50:45] bleh [19:50:47] oh well :) [19:50:58] yeah, kill it i guess :) [19:51:01] yurik: it's complicated. Would be nice to make sure it isn't so complicated in the new app :) [19:51:33] by having a good continues integration build environment? agree :) [19:51:57] (and lots of automated unit tests of course...) [19:52:09] yurik: we *already* have unit tests :) [19:52:12] yurik: no CI, though [19:52:24] yurik: everything non-UI has unit tests :) [19:52:45] nah, without CI it ain't good - requires someone to do all the manual building for a new deployment [19:52:47] no good :) [19:53:07] yurik: oh, we've that sorted out. Maven to the rescue! Build step is clone + 1 command. [19:53:19] yurik: we've reproducible builds. One step setup [19:53:35] wow! [19:54:15] yurik: yeah. it took us a week to setup the first time, BUT OMG HAS IT SAVED TIME AFTERWARDS! [19:54:34] nice! [19:55:01] but a proper build server with a one click "deploy to store".... mmmm [19:55:51] yurik: it's not too hard to do with jenkins, y'know. Everything we need to build can actually be installed on our servers. [19:55:59] nothing proprietary there. [19:56:01] just... needs someone to do it [19:56:13] yurik: we had it for the commons app, I just haven't found time to bother hashar about it [19:56:17] YuviPanda, what about store depl? [19:56:19] or more like he's always been busy so [19:56:28] yurik: that's to be done manually, because the private keys are secret [19:56:41] yurik: but you can make people test it by just downloading a file, no neeed to go to store [19:56:58] yurik: store deployment is also one command, except you need to specify path to the keyfile and put in a passphrase [19:57:09] yurik: err, store *build*. deployment, we need to drag drop things [19:57:34] hehe, sounds easy enough. thx! [19:57:41] yurik: :) [19:57:46] i wonder if brion is around? [19:57:58] yurik: i've beeen looking for him. Neither him nor monte are around. [19:57:59] i want to pester him about mobile. and wap. and some other old domains [19:58:07] * YuviPanda pokes tfinc [19:58:14] tfinc: think you can txt brion? [19:58:16] YuviPanda: yes? i'm about to step out [19:58:17] YuviPanda: sure [19:58:22] tfinc: thanks [19:58:28] tfinc: both me and yurik are looking for him :) [19:59:49] YuviPanda: sen [19:59:50] t [19:59:59] tfinc: thanks [20:01:00] dr0ptp4kt, so are we meeting today? [20:01:14] yurik, yeah, sent invitation for 3 pacific [20:02:06] ok. dr0ptp4kt any thoughts about the starting page? [20:02:39] hi mhurd [20:02:43] mhurd: feeling better? :) [20:04:38] yurik, i'm cool with whatever cs + df + kw determine. my only thought is that if the feature is implemented, that i prefer that the verbiage is carrier expressed and bizops approved (it adds more value, but prevents risk of bad messaging), although i can see the point of it being community provided, too (which doesn't add as much value, but is kind of a neat and quirky thing anyway) [20:05:26] true, but we are not a business, we are a community :) [20:06:05] hey [20:06:07] hi brion! [20:06:10] dr0ptp4kt, another thing - re blanked out zero - are you looking at it or should i? [20:06:10] brion: feeling better? [20:06:20] nope. still sick and it sucks [20:06:27] brion: :( [20:06:28] brion, get better!!! [20:06:36] brion: think you'll have energy for a couple of patches? They can wait. [20:06:37] being sick sucks :( [20:06:37] \o/ [20:06:38] if you're sick [20:07:02] sure i'll take a look [20:07:08] yurik, i don't disagree about the community aspect of things. but the community doesn't determine which languages to show on that page, either. again, i am fine with whatever the bizops team decides to do with that. [20:07:08] it's that or daytime television [20:07:25] yurik, i have not been looking at the bg/fg color problem on the warning page. go for it if you like [20:07:33] brion: heh, reading through AN/I and ArbCom discussion sounds a better prospect than TV [20:07:44] lol [20:08:23] tomasz changed my status meeting to tomorrow. i'll look at the calendar and reschedule today's meeting to earlier if everyone available. dfoy yurik [20:09:02] brion: I have a violetto fueled style change in there :) [20:09:14] wheeee [20:09:18] brion: should move it to the MobileApps extension, which... hasn't been deployed yet [20:10:26] kaity|away: around? [20:11:11] brion, faidon has deployed this patch removing wap. and mobile. domains. Could you verify? Apparently there is still some traffic and he reverted it. https://gerrit.wikimedia.org/r/#/c/99394/1/templates/varnish/mobile-frontend.inc.vcl.erb [20:11:24] (03CR) 10Brion VIBBER: [C: 04-1] "Those PNGs are really blurry looking at hdpi and xhdpi; it looks like ImageMagick is rasterizing and *then* scaling up, or something. Need" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99264 (owner: 10Yuvipanda) [20:13:03] yurik: i'm not quite sure what i'm supposed to do with that...? :) [20:13:04] brion: garhg. should we just ask the designers to render them themselves? to the biggest PNG size possible? [20:13:21] YuviPanda: did you try using inkscape or rsvg? [20:13:24] brion: there are other patches though :) also in that patch - everything other than the images look okay? [20:13:34] still looking [20:13:40] brion, do you know anything about those domain? any app or anything else that's using them? [20:13:41] brion: rsvg on osx, wasn't sure how to install. and inkskape is eughiuasdgg GUIS!!!!! [20:13:52] yurik: as far as i know nothing's used em in years [20:13:54] yurik: apps don't use wap nor mobile. [20:14:00] YuviPanda: brew install librsvg should do it [20:14:20] brion: wants me to manually install xquartz or something [20:14:30] heh [20:14:41] go home x11, nobody likes you! [20:14:53] heh [20:15:54] switches to map constants to other constants make me cry. java SOOOOO needs literal Map objects [20:16:16] yeah, and won't get it [20:16:23] "WHAT IF POOR DEVELOPERS GET CONFUSED?!?!?!:?!?!?!" [20:16:45] they'll just switch to objective-c and make more money selling shitty games in apple's walled garden [20:16:56] \o/ capitalism wins! [20:16:59] heh [20:17:11] ok lemme make sure it works aside from the icons... [20:17:21] brion: the local app dev scene is interesting. Nobody building for the indian market gives a fuck about iOS :) [20:17:25] like, at all! [20:17:27] it's all Android first [20:17:28] YuviPanda: worth updating to intellij 13? [20:17:35] brion: seems faster. [20:17:39] nice [20:17:46] brion: oh, and has gradle support, which I think we'll move to eventually [20:18:11] aha [20:18:42] brion: also if you like vim, you should try out the IdeaVim plugin :) [20:18:59] i tolerate vim ;) [20:19:53] looks nice, pretty icons yay! [20:20:22] brion: heh :P [20:20:23] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok let's fix up the icon conversion in future commit. Works fine otherwise..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99264 (owner: 10Yuvipanda) [20:20:25] VIM4LYF! [20:21:24] * brion wistfully remembers doing assembly programming using the text editor in https://en.wikipedia.org/wiki/Borland_Sidekick [20:21:32] hehe [20:22:00] brion: I'm trying to move my labs-patches-addiction to something else. Might do some Go hacking or Rust hacking :) [20:22:43] something to hold you until you get the Glass? ;) [20:23:30] brion: :D [20:23:32] yeah [20:23:39] brion: i need to get that patch in for wikidata too [20:24:22] oh man i forgot all about that in all the commotion [20:24:36] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add minimal styling to the content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99404 (owner: 10Yuvipanda) [20:24:44] brion: woo! [20:25:07] water run, brb in like 2 mins [20:25:59] yurik: concerns* :-) [20:26:38] YuviPanda: ooh i may borrow that css :) [20:26:45] mhurd: don't copy paste it yet! [20:26:54] mhurd: there's a repo called mediawiki/extensions/MobileApp [20:26:56] mhurd: which will have the CSS [20:27:00] mhurd: and we'll sever them via resourceloader [20:27:08] mhurd: and the apps will have to fetch it once a few days or so and cache it :) [20:27:08] YuviPanda: awesome! [20:27:18] mhurd: we shouldn't be shipping CSS hard coded in the apps :) [20:27:22] hey kaity [20:27:23] om nom nom i like that idea [20:27:23] around? [20:27:26] lets us update [20:27:29]