[00:03:47] who wants drinks tonight? kaity kaldari violetto vbamba jgonera ? [00:04:01] sure [00:04:30] jdlrobson: are you celebrating the repeal of prohibition? [00:04:33] jdlrobson, awjr - deployed [00:04:40] \o/ thanks MaxSem [00:04:51] testing [00:05:07] awjr: yes i am [00:05:08] you can meet my dad [00:05:33] oh probably need to wait for rl cache to expire [00:05:53] jdlrobson: yes! [00:06:48] ok, issue appears fixed on test2 [00:06:57] thanks jdlrobson and MaxSem :) [00:07:04] and chris m [00:07:51] yey [00:08:01] jdlrobson: wine bar? [00:08:14] that is up for discussion [00:19:44] jdlrobson, jgonera: The margins around the new overlay header buttons render in 3 different ways depending on if you're using Safari, Firefox, or Chrome. Everytime I manage to fix them in one browser, it makes it worse in the others. We're currently using display:table-cell with negative margins, which is a very uncommon way to do layout. Perhaps we should consider implementing it differently. [00:20:44] kaldari, I'm open to suggestions, I spent a whole day trying to make it look like kaity wanted and adjust to any amount of text in the header [00:20:45] I think this is the first time I've ever seen all 3 browsers render 1 box in different ways :P [00:23:58] Thursday viewing: http://www.youtube.com/watch?v=G8CeP15EAS8 [00:24:22] (03PS1) 10Yuvipanda: Factor crossfade function into own static method in Utils [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99577 [00:24:23] (03PS1) 10Yuvipanda: Show error message when there's no network connection [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99578 [00:25:26] (03PS1) 10Jdlrobson: Story 1402: A/B test showing edit guider after user creates an account [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99579 [00:25:27] (03PS1) 10Jdlrobson: Hygiene: Make use of M.isBetaGroupMember [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99580 [00:26:10] @jdlrobson yes! [00:27:40] (03CR) 10Yuvipanda: [C: 04-1] "Reason in Commit message" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99578 (owner: 10Yuvipanda) [00:27:50] tfinc: i think i see why bugello hasn't been picking up your bugs - you started naming your boards differently [00:27:59] it looks like it probably hasn't been working for a while [00:28:05] awjr: what's it looking for ? [00:28:14] logs are filled with 'There are no valid boards for which to add cards' [00:28:21] tfinc: Mobile App - Sprint # [00:28:38] awjr: yup we've added themese to boars ala Mobile App - Sprint 20 (Saved pages) [00:28:40] thus [00:28:46] that's probably it [00:28:52] Mobile App - Sprint %d (%s) [00:29:07] lemme see if that will work - the trello api is finicky [00:30:53] tfinc: at *quick* glance i dont think that's going to work for bugello [00:30:57] but i can take a deeper look tomorrow [00:32:49] awjr: k. let me know [00:32:59] actually i think i see what i can do now [00:37:41] k [00:39:00] tfinc: also it looks like the bugello user is not a member of the boards? [00:39:07] ahh [00:39:16] fixed [00:40:07] ok i kinda fixed it [00:40:40] er or not [00:40:51] it's adding to sprint 19 not sprint 20 [00:41:05] ergh tfinc im going to disable bugello for now and fix it properly tomorrow when i have more time [00:43:55] awjr: k [00:44:03] awjr: 19 is fine [00:44:05] 20 is the next sprint [00:44:18] kicking off next week [00:44:23] so in this case its doing the right thing [00:44:42] lol the bug is currently a feature [00:45:16] tfinc it's written to add bugs to the 'latest' board - meaning the board it finds with the biggest ## [00:45:44] awjr: what made it pick 19 this time / [00:45:46] (03PS2) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [00:45:49] bad regex tfinc [00:45:54] 9 is bigger than 0 :p [00:45:57] (03CR) 10jenkins-bot: [V: 04-1] WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:46:13] if you have a problem and you solve it with regex, you have two problems ;) [00:46:39] tfinc potential work around would be to only add the bugello user when the sprint becomes active? [00:50:46] ha ok. [00:51:03] awjr: i like having the next sprint staged so i'm going to have those boards [00:52:24] ok tfinc, then i think only adding the bingle user to board when the sprint is 'active' is probably the best bet, though that adds some overhead for you [00:52:45] awjr: lets run with it and see how it goes. i bet i'll forget but maybe i'll surprise us ;) [00:52:54] :p [00:53:35] tfinc: is it easy to move cards between boards? [00:53:41] another option may be to have a separate bug board [00:53:42] awjr: yes [00:53:46] but not in bulk [00:53:49] ah [00:53:59] but if its on another board we'll never check it [00:54:04] yeah [00:54:29] so thats a no win [00:54:34] having an "active" board is best [00:54:38] tfinc: well what im suggesting is have the bug board be a holding pen and you move the bugs over [00:55:03] id unno when you guys triage bugs, but i guess it comes down to which is easier to remember - checking the 'bug board' or adding the bugello user at the right time :p [00:55:04] awjr: i know. but thats another board to check so thats less attractive then the user [00:55:07] k [00:55:09] awjr: standup [00:55:22] when im playing with it tomorrow i'll see if i can come up with any other ideas [00:55:27] thanks [00:55:29] np [01:00:01] YuviPanda: how are you still awake ? [01:28:19] dr0ptp4kt, i plan to add a screen shot of the starting page to give users an idea of what it will look like [01:28:23] (03PS1) 10Mhurd: Updated history interface to better sync with design specs. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/99589 [01:28:30] yurik, cool [01:28:32] brion: ^ [01:29:06] brion: it's not drawing the lines between history discovery context icons, but can add that soon [01:32:06] (03PS2) 10Mhurd: Updated history interface to better sync with design specs. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/99589 [01:32:55] brion: oops had a small bug. amended ^ [01:34:22] (03CR) 10Dr0ptp4kt: [C: 04-1] Supported flagged revisions of W0 configurations. (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95657 (owner: 10Dr0ptp4kt) [01:40:47] (03PS3) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [01:40:52] (03CR) 10jenkins-bot: [V: 04-1] WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [01:43:31] (03PS1) 10Robmoen: Prefetch wikitext on summary screen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99591 [10:43:14] (03PS1) 10Aude: Fix logout link code to use Userlogout instead of alias [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99628 [12:42:42] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99579 (owner: 10Jdlrobson) [17:46:22] jdlrobson: https://commons.wikimedia.org/wiki/File:World_of_Wikipedia_by_Jon_Robson.png is so awesome [17:46:35] awjr: i'm currently annotating it before standup :) [17:47:24] :D [17:47:27] i wish i had a large format printer [17:51:01] awjr: we do in the office :) [17:51:05] $12 to print it in color :) [17:51:10] @_@ [17:51:14] i should print out a copy when im in town [17:51:25] i would love to hang it in my office [18:15:25] (03PS1) 10Cmcmahon: [WIP] new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 [18:16:19] mhurd: you about to start the office hangout ? [18:16:41] (03CR) 10Cmcmahon: "TODO: add chunky_png to gems for Mobile tests" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 (owner: 10Cmcmahon) [18:19:02] brion: did that get through? [18:19:12] brion: speedtest tells me I've 14mbps, but doesn't seem to [18:19:14] mostly :) [18:19:36] brion: heh ok :) [18:19:44] brion: you seem to have spread the plague to mhurd :) [18:19:50] :( [18:20:22] brion: what else do you think needs to be done for History on Android? I added slightly darker icons [18:20:31] brion: the lines perhaps? [18:21:03] we could consider that, easy enough to line up the stuff [18:26:52] YuviPanda: no plague :) just need more coffee [18:28:25] \o/ yay [18:28:40] brion: i'll also work on the "if i try to do something that requires connectivity it doesn't destroy my current article" acceptance criteria - turns out it needs a bit of tweaking [18:29:10] ah excellent [18:29:50] brion: I'm thinking of moving the API code into the app itself [18:30:17] ok. just easier to update that way? [18:30:52] (03PS1) 10Jdlrobson: Override language_urls template data to avoid hook abuse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 [18:31:16] brion: https://gerrit.wikimedia.org/r/99589 is ready to be poked and prodded :) still haven't refactored the data layer into cleaner abstraction, but will do so soon [18:33:12] brion: no, lets us integrate better - I needed to add a timeout, and I could either parameterize it or I could just bundle it in [18:33:19] brion: also lets me use OKHttp better [18:34:52] spiff [18:35:08] jdlrobson: do you still need a bug ticket for Wikibase/Wikidata tags appearing in Mobile view? [18:35:19] jdlrobson: I forgot to add that yesterday [18:35:25] brion: there are still a couple of changes to merge other than that, I think [18:35:27] Please chrismcmahon (if you're talking about the Barack obama article) [18:35:41] yeah i see a couple more in there :D [18:35:49] it's a a pretty bad one - so Wikidat shouldn't be deployed in current state [18:36:05] brion: I've -1'd one - the code there is fine, but I need to set a timeout on the HTTP connection before it can work / be tested. [18:36:19] ok lemme refresh my coffee and i'll start on review [18:36:56] brion: :D [18:36:58] awjr: any idea if kenan is coming in today? [18:37:06] kaldari: kenan is remote today and monday [18:37:27] hmm, guess I'll have to email him [18:37:32] he's got time open on his calendar until noon pst [18:37:45] kaldari: you can give him a call too - he should be on IRC [18:37:53] or send an sms [18:38:04] his # is on the contact page on officewiki [18:38:56] doesn't seem to be on IRC, email is fine, just had a question about KeepGoing [18:40:46] awjr: emailed the list, re https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1480 [18:40:49] awjr: thanks! [18:40:51] YuviPanda are you still killing saved pages?: https://twitter.com/PAULdrknhandsum/status/408255998516670464 [18:41:10] jdlrobson: sadly not, no matter how much I'd love to do it :) [18:41:18] YuviPanda: actually, we discussed it during standup and put it in our next iteration, starting monday :) [18:41:24] well looks like you'd upset people if you did so that's good :) [18:41:25] awjr: woo, sweet! [18:41:38] YuviPanda: when do you get your exam results? [18:41:49] jdlrobson: we'll replicate the exact same featureset the old app had, and instrument usage. If we find people use them, then happily keep it on :) [18:42:05] jdlrobson: end-Jan or beginning-Feb. No clear dates, sadly :( [18:45:53] dfoy: no need for me on the call at 11, correct? [18:46:15] dfoy: granted, i was attempting to cancel / reschedule it. sounds like you and adele will take it from here [18:47:20] dr0ptp4kt: yes but I don't know what the status of the meeting is today [18:48:19] dr0ptp4kt: do you know if the call is still expected today? [18:48:56] dfoy: i haven't heard from him. what would probably be best is if i email and say 'Dan will be placing the call unless we hear that you want to postpone the meeting.' ok? [18:49:15] dr0ptp4kt: sure that's fine. Thanks! [18:50:02] dfoy: done. ok, i'm exiting the loop on that topic for now [18:50:14] (until you notify of further need to be involved) [18:50:36] dr0ptp4kt: ok [18:50:42] dfoy: thx [18:52:32] (03CR) 10Brion VIBBER: "Search icon seems noticeably lighter than the others?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99525 (owner: 10Yuvipanda) [18:53:00] YuviPanda: looks like search icon didn't get an update for the darker color [18:53:48] brion: oh? [18:54:09] brion: I wonder if all this is because we don't have native xxhdpi assets [18:54:14] it... seemed okay on my n4 [18:54:25] YuviPanda: i'm pretty sure it's because there was no change to search.svg [18:54:29] oh [18:54:29] wat [18:54:31] I see [18:54:36] brion: I.. didn't notice that :) [18:54:43] :D [18:54:44] brion: need to poke kaity [18:55:03] pssh just edit the svg file and change the color [18:55:15] that's what semi-human-readable file formats are for :D [18:55:29] brion: noooo! :P [18:55:33] brion: gonna start that data abstraction pass now - a couple of the small history bugs would be a bit easier to wrangle if that were done [18:55:35] brion: Editing XML by hand feels weird ;) [18:55:48] spiff [18:56:37] brion: do you want to, uh, do that? :) [18:56:51] hah fine [18:58:58] (03CR) 10Brion VIBBER: "I'm not sure this succeeds at "History view 'flickering' when you go from history to elsewhere" -- I still see a new entry pop up in the l" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99558 (owner: 10Yuvipanda) [18:59:40] brion: that's what it refers to, and... that shouldn't be happening [18:59:58] brion: is your internet *that* fast? [19:00:19] awjr: what's the status of Rummana helping with post deployment validation? [19:00:32] heh [19:00:38] lemme double-check it after i merge the other one [19:00:43] brion: ok [19:00:45] jdlrobson: not sure about Rummana specifically, but the QA group in general helped out yesterday [19:00:56] jdlrobson: chrismcmahon specifically [19:01:09] brion: it theoretically shouldn't be happening, since we aren't touching the history persister at all until after the leadsectionrequest finishes loading [19:01:46] no one replied about their opinions on post-deployment testing on the email thread, so i figured best to continue asking qa to help out post-deployment until we can discuss more seriously as a team during quarterly planning [19:01:48] jdlrobson: ^ [19:01:51] YuviPanda: random is also a slightly lighter color than the link & external icons [19:01:55] should that match? [19:01:59] brion: should, yeah. [19:02:03] awjr: sounds good [19:02:07] ok *tweak tweak* :D [19:02:13] brion: I didn't check the exact colors, was just checking the size. [19:04:33] (03PS2) 10Brion VIBBER: Add newer, darker icons from the designers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99525 (owner: 10Yuvipanda) [19:05:00] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok gray values normalized in this version :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99525 (owner: 10Yuvipanda) [19:06:05] (03PS2) 10Brion VIBBER: Only add history entry after page has actually loaded [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99558 (owner: 10Yuvipanda) [19:06:49] chrismcmahon, why do tests use ?useformat=mobile instead of going to m domain on beta? [19:07:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok pretty sure I accidentally tested on the wrong build version, cause it's working great now. Yay!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99558 (owner: 10Yuvipanda) [19:07:35] (03PS2) 10Brion VIBBER: Factor crossfade function into own static method in Utils [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99577 (owner: 10Yuvipanda) [19:09:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] Factor crossfade function into own static method in Utils [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99577 (owner: 10Yuvipanda) [19:09:29] (03PS2) 10Brion VIBBER: Show error message when there's no network connection [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99578 (owner: 10Yuvipanda) [19:13:19] brion: ah, nice to know that works :) [19:14:53] hmm [19:14:57] there's not even a DNS timeout? [19:15:14] brion: doesn't seem to be. [19:15:24] that or I'm not throwing the exception :D [19:15:25] looking [19:15:27] heh [19:16:03] brion: that doesn't seem to be the problem, no [19:16:15] (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "So this doesn't actually seem to work yet..." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99578 (owner: 10Yuvipanda) [19:16:23] (03CR) 10Dr0ptp4kt: "See comment. By giving zeroadmin autoreview." (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95657 (owner: 10Dr0ptp4kt) [19:16:42] ^yurik [19:17:05] the fact that there's no reachable network should cause the http attempt to error out *really fast* shouldn't it... [19:17:15] brion: yup [19:20:18] (03CR) 10Robmoen: [C: 04-1] Prefetch wikitext on summary screen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99591 (owner: 10Robmoen) [19:21:48] (03CR) 10Brion VIBBER: [C: 04-1] "Looks good except: search icon is visibly lighter than the link icons -- needs to be darkened to #AAAAAA to match the other updated icons." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/99589 (owner: 10Mhurd) [19:26:50] (03CR) 10Brion VIBBER: Updated history interface to better sync with design specs. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/99589 (owner: 10Mhurd) [19:27:06] tfinc: so the core data schema change to support sub-sections turns out to be super simple - just need to save off toclevel field :) [19:27:19] whee [19:27:20] mhurd: thats great to here [19:27:21] brion: yay! [19:27:22] jdlrobson: Can I mark 58102 as a dupe of 57094? [19:27:28] brion: thx! [19:27:52] kaldari: they are two different bugs really :-/ [19:28:13] what's the difference? [19:28:26] oh wait [19:28:32] yeh you can they are the same [19:28:45] tfinc: sub-sections were already being saved individually - my worry had been that the query i was using was returning a section and all its subsections as one big chunk. thankfully that was not the case [19:28:46] cool [19:33:33] brb foodstuffs [19:34:42] (03PS2) 10Robmoen: Prefetch wikitext on summary screen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99591 [19:37:35] (03PS3) 10Robmoen: Prefetch wikitext on summary screen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99591 [19:39:56] kaity, changes to user profiles are on mediawiki.org, but as I said it's not perfect yet: https://m.mediawiki.org/wiki/Special:UserProfile/Juliusz_Gonera [19:40:45] cool! thanks [19:41:58] jgonera: would it be possible in the future to crop images to a 100x100 px thumbnail? [19:42:52] kaity, like in watchlist? yes [19:42:59] jgonera: and items without an image set the height to 100 so they're all the same size? [19:43:26] well, as long as they fit in 100px, so yes, we can make 100px the minimum height [19:47:28] jdlrobson, jgonera: change 99591 reflects recent changes in master to the save api. could one of you kind sirs review it please ? [19:47:47] link? ;) [19:48:00] jgonera: https://gerrit.wikimedia.org/r/#/c/99591 [19:49:01] (03CR) 10Bartosz Dziewoński: Override language_urls template data to avoid hook abuse (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [19:53:00] jgonera: oh and also https://gerrit.wikimedia.org/r/#/c/99172 plz :) [19:53:17] brion: found the bug, fixed it :) [19:53:21] brion: now to make it not be shit.. [19:53:47] rmoen, do I need some patches for core and ve for this to work or should I use the latest master? [19:56:23] jgonera: latest master of both [19:56:48] rmoen, then it says "Uncaught Error: Unknown dependency: ext.visualEditor.mobileViewTarget " [19:57:17] jgonera: hmmm, that doesn't happen for me :( [19:58:10] rmoen, I've just pulled master a minute ago, still happening [19:58:31] jgonera: i guess someone changed the name.. 1 sec [19:59:23] jgonera: hmm no the ext.visualEditor.mobileViewTarget is still correct [20:00:48] tfinc: do we still have the meeting now? I think we talked about not having it [20:01:09] brion: mhurd ^ [20:01:11] i'm going to remove it. we don't need it [20:01:20] ok [20:01:31] tfinc: ^k [20:01:37] tfinc: ok [20:02:19] especially since if we have it i'll never make it to the office. been in meetings back to back since 10 [20:02:36] rmoen, does it work for you with the newest master? [20:02:50] jgonera: yes [20:03:06] jdlrobson: but not without my patch https://gerrit.wikimedia.org/r/#/c/99591 [20:03:11] oops [20:03:44] jgonera: without the patch, there is an error on save. [20:04:02] rmoen, the editor doesn't load for me with the patch (possibly without too) [20:04:17] ok . mailed kenan about reducing scope too as were over on points for sprint 20 [20:04:54] jgonera: i remember it was doing this before as you left a comment on the first patch that has now been merged. are you sure you have ve installed? [20:07:10] rmoen, sorry, I'm stupid, I had VE disabled in config, not sure why [20:07:24] jgonera: lols [20:08:08] rmoen, there's one thing which is wrong in the workflow but that's not a problem with this patch [20:08:12] jgonera: no worries m8. also, when you are testing. I feel like something should be done about the spinner. [20:08:20] there's no way to go back to editing from the summary field [20:08:38] jgonera: yeah, i can work on that in another patch [20:09:37] and there is no text in overlay headings ;) [20:09:44] but looks good [20:11:15] jgonera: ok, i can add the heading and add in the back behavior in separate commits. [20:11:30] rmoen, one thing though, the spinner should show up in place of the submit button instead, just like in the regular editor [20:11:37] rmoen, yeah, I know, let's merge this [20:11:55] tfinc: brion: YuviPanda: grabbing lunch [20:11:58] jgonera: yeah the spinner is out of place [20:12:01] ok [20:19:05] (03CR) 10JGonera: [C: 032] Prefetch wikitext on summary screen (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99591 (owner: 10Robmoen) [20:20:07] (03Merged) 10jenkins-bot: Prefetch wikitext on summary screen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99591 (owner: 10Robmoen) [20:20:27] (03CR) 10JGonera: [C: 032] Add general errorHandling to VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99172 (owner: 10Robmoen) [20:20:34] (03CR) 10jenkins-bot: [V: 04-1] Add general errorHandling to VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99172 (owner: 10Robmoen) [20:20:37] rmoen, rebase https://gerrit.wikimedia.org/r/#/c/99172/ [20:21:24] dr0ptp4kt, dfoy - i accepted all the zero namespace pages, and fixed a number of their names (that look like there were leftovers from the old days) [20:22:33] jgonera: doing that now [20:23:46] (03PS3) 10Yuvipanda: Show error message when there's no network connection [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99578 [20:23:55] brion: that should do it! ^ [20:23:59] brion: I was looking for the wrong type of exception [20:24:40] dr0ptp4kt, VCL has been updated https://bugzilla.wikimedia.org/show_bug.cgi?id=54822 [20:25:40] (03PS1) 10Brion VIBBER: Fix SVG->PNG icon rasterization for higher resolutions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99725 [20:26:03] YuviPanda: take a peek at that, make sure rsvg installs and runs on your machine :D [20:26:40] brion: ah, yes, doing now [20:26:55] brion: I'm going to email the list asking for design for the error page, but for now I've so mething working [20:29:31] (03CR) 10Brion VIBBER: [C: 04-1] "Seems to survive a link click, but crashes hard on a search when airplane mode is on (hostname lookup fail throws an exception)." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99578 (owner: 10Yuvipanda) [20:29:45] brion: the story doesn't mention search at all ;) [20:29:51] brion: I'll do that in a separate commit. [20:30:01] brion: if you notice in this, if you hit 'back', it still works. [20:30:03] :P :) [20:30:03] after failing on a link [20:31:26] yep. just don't tap into search by mistake or you lose your place :D [20:32:03] brion: yup, that :) [20:34:30] brion: apparently I need to install xquartz [20:34:33] doing so now [20:34:51] whee [20:37:01] brion: emailed mobile-tech [20:37:16] brion: merge that patch? Search will need a separate patch [20:38:48] i'd prefer to merge them together [20:40:27] (03PS2) 10Jdlrobson: Override language_urls template data to avoid hook abuse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 [20:40:30] brion: they'\re in different parts of the code, and I think should remain separate [20:40:42] brion: don't want to make them in the same commit [20:41:09] both are required to fulfill the requirement of not fucking up your state just because you tried to do something when offline [20:41:14] so, i will merge them together. [20:41:29] brion: well, fine. I'll make a separate commit though. [20:41:34] hehe ok [20:46:21] (03CR) 10Kaldari: [C: 04-1] Override language_urls template data to avoid hook abuse (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [20:49:45] (03PS5) 10Robmoen: Add general errorHandling to VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99172 [20:53:18] jgonera: rebase hell complete [20:53:59] yurik, thx & thx. can we get rid of the extensive if-elseifs in the zero vcl? [20:54:32] (03PS4) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [20:54:37] (03CR) 10jenkins-bot: [V: 04-1] WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [20:55:07] dr0ptp4kt, it will slightly increase fragmentation for the non-whitelisted languages, so ops probably wouldn't be ok with it :( [20:55:39] yurik, fair enough. i'll add it to the list of discussion topics for thursday [20:56:02] jgonera: stepping away for lunch, brb [21:03:00] (03CR) 10Siebrand: "L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [21:09:19] (03PS1) 10Kaldari: HYGIENE: Removing FIXME that has been fixed. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99732 [21:09:47] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok let's go ahead and merge this for simplicity and we'll fix em up in another commit:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/99589 (owner: 10Mhurd) [21:10:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok since Yuvi is gonna do the search fix in another commit anyway, going ahead and merging this to clear the board. Yay!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99578 (owner: 10Yuvipanda) [21:10:18] brion: woo :) [21:10:22] :) [21:12:24] (03PS1) 10Yuvipanda: Do not crash when searching without network [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99733 [21:12:25] brion: there you go! [21:12:38] huzzah [21:12:58] brion: this actually does retry. I should implement that too in the page section [21:13:33] ooh nice improvement [21:13:55] (03CR) 10JGonera: [C: 032] Add general errorHandling to VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99172 (owner: 10Robmoen) [21:15:58] (03Merged) 10jenkins-bot: Add general errorHandling to VisualEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99172 (owner: 10Robmoen) [21:16:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I love it :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99733 (owner: 10Yuvipanda) [21:16:45] brion: :) [21:20:19] * awjr waves to AndyRussG [21:20:28] AndyRussG: any luck with that bug? [21:20:36] Hi awjr! [21:20:51] (03PS2) 10Yuvipanda: Fix SVG->PNG icon rasterization for higher resolutions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99725 (owner: 10Brion VIBBER) [21:21:12] So far it seemed to be server-side [21:21:38] actually i forget which bug it was… do you have the bug number handy AndyRussG? [21:21:39] Because the inital HTML response included the message about the file not found [21:21:49] Yes, one sec [21:22:10] (03CR) 10Yuvipanda: [C: 032 V: 032] "Sharper indeed!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99725 (owner: 10Brion VIBBER) [21:22:16] brion: anything else you think we need to add for history? [21:22:38] whee [21:22:38] awjr: 57155 [21:22:41] lemme take a peek [21:23:14] YuviPanda: thumbnails would be bitchin', but if they don't make it in until next week i won't cry much [21:23:36] brion: yeah, apparently MaxSem can tackle it next week on the server side, and then we can make 'em work [21:23:40] It seemed intermittent. On Wednesday morning I did see the error in the links mentioned in the report, but Wednesday evening no more [21:23:46] nice [21:23:53] that is bizarre [21:23:53] Couldn't reproduce locally, either [21:24:19] YuviPanda: we might also want to standardize on how we divide up the date markers [21:24:24] My next stop was going to be operations to ask if anything had been merged on production over that time [21:24:27] brion: it's per-day now. [21:24:29] currently they're slightly different between platforms [21:24:31] yeah [21:24:42] per-day on android, and 'today/last week/last month' or something on ios [21:24:56] we'll try em both and see what people like in screenshtos ;) [21:25:01] And also learn a bit more about how mobleaction=beta works [21:25:09] right [21:25:42] brion: YuviPanda: the annotated mockup had "today/last week" etc. i just copied that [21:26:09] AndyRussG: mobileaction=beta just forces the user into 'beta' mode temporarily [21:26:25] (for that particular request) [21:26:29] mhurd: yeah, and I think I should add annotative 'today', 'yesterday' text next to the dates perhaps. [21:26:42] awjr: OK [21:26:54] AndyRussG: operations probably won't have much in the way of answers for you im afraid [21:27:07] Hmmm [21:27:11] brion: mhurd I want them to be at least daily since we don't even have timestamps on them. I say let it be and see if someone complains :) [21:27:18] it's actually a little tricky to see all of the things that have changed during deployments [21:27:20] I'll probably add at least a marker for 'today' tho [21:27:29] Hmmm [21:27:33] Just tried it again and no error [21:27:38] yeah, "today" makes me warm and fuzzy [21:27:39] YuviPanda: cool [21:27:46] i forget whether it's december 5 or 6 or what ;) [21:27:54] brion: yup, me too :D [21:28:00] brion: I'll specialcase today :) [21:28:07] especially when i'm working with you, it's usually a different day there ;) [21:28:19] pfft. i've completely given up on the concept of 'day' [21:28:27] I woke up today at 5PM localtime. [21:28:29] hehe [21:28:31] this is theoretically saturday [21:28:34] AndyRussG: i recommend trying to figure out how the file pages work - that is, how they load images from commons but make them appear to be on the local wiki (eg enwiki) [21:28:38] does it all make sense? OF COURSE NOT! :) [21:29:00] brion: as the Joker says, sometimes it is easier to give into the madness :) [21:29:05] :) [21:29:28] ooh [21:29:44] there's another nice thing about the section headings on the iOS version -- this may be a tableview behavior but it's very handy [21:29:56] the sections headers "stick" at the top of the screen" as you scroll down [21:30:05] so you don't have to remember what day you're on :) [21:30:15] wonder if we can do that easily on android or if that's a pain in the ass [21:31:10] AndyRussG: i suspect there's something happening in the beta-specific code that is mangling the request for the image [21:32:05] AndyRussG: totally unrelated - i hear you live in DF? [21:32:12] awjr: Right... strange that on the same file sometimes it happens and sometimes it doesn't [21:32:18] awjr: Yes! I live in the DF [21:32:34] brion: yeah it's a pain in the ass [21:32:34] AndyRussG: it seems to happen consistently for me, i havent' been able to spot the intermittent-ness [21:32:43] but perhaps thats the result of some race condition? [21:32:58] darn. we'll leave that one on the table for 'if we figure out how to do it and can just drop in an alternate tableview ' :D [21:33:02] listview [21:33:04] gridview? [21:33:07] whatever the hell view [21:33:08] AndyRussG: that's cool, what brought you to mexico? [21:33:17] every damn UI toolkit calls it something different [21:33:49] Do you get an error on the second link right now? [21:34:04] (03CR) 10JGonera: [WIP] new test for uploading an image (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 (owner: 10Cmcmahon) [21:34:13] awjr: I came in '96 to study Anthropology [21:34:36] And stayed a while... [21:34:42] (03CR) 10JGonera: [C: 032] HYGIENE: Removing FIXME that has been fixed. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99732 (owner: 10Kaldari) [21:35:59] https://es.wikipedia.org/wiki/Escuela_Nacional_de_Antropolog%C3%ADa_e_Historia [21:36:01] AndyRussG: interestingly, in chrome i do but in firefox i do not [21:36:30] in private browsing mode in chrome, i also do not [21:36:55] i wonder if there was a bad request that got cached [21:37:32] Hmmm, I don't know much about how the cache works but that sounds like a theory [21:38:08] On Wednesday evening I tried it on a Chrome on an Android phone and at first did get the error, then didn't [21:38:20] brion: there's a third party library that does the sticky headers [21:38:22] im not sure how the file caches work either - i dunno if they vary differently or have different TTLs than the text caches [21:38:36] brion: problem is that it completely re-implements listview from scratch, and... I don't trust it enough yet :) [21:38:40] So I thought it might have been fixed inadvertently in some change that had just merged, and was just still propagating through the cluster [21:38:47] brion: our current section headers are a complete hack :) [21:38:53] in the instance where i get the error, i am logged in - which means i am bypassing the main varnish text cache [21:38:56] brion: if it gets a listview wrong, that's a lot of memory leaking [21:38:58] but i dunno if the same behavior happens for files [21:39:15] (03Merged) 10jenkins-bot: HYGIENE: Removing FIXME that has been fixed. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99732 (owner: 10Kaldari) [21:39:23] interesting [21:39:43] AndyRussG: i just logged in in the private browsing window where i was able to view the image [21:39:45] now, i get the error! [21:39:47] hey YuviPanda mhurd I updated the history page to show a button to clear history https://trello.com/b/Q1pNIFXm/mobile-app-sprint-19-saved-pages-history [21:39:55] kaity: awesome! [21:40:05] AndyRussG: same thing in firefox, actually [21:40:06] If you're getting it just now, then it's not from some recent merge in the code on production [21:40:19] no, i think there's some other weirdness going on [21:40:26] kaity: we should put that as an actionbar item in Android [21:40:35] I was thinking we can use a default dialogue for user to confirm clear history [21:40:41] AndyRussG: in a browser whre you're NOT getting the error, are you logged in? [21:40:47] YuviPanda: ok cool [21:40:49] kaity: sounds good [21:40:58] Let me check [21:41:05] kaity: do we need to have an explicit clear, if we are auto-killing everything 30 days old/ [21:41:07] ? [21:41:38] YuviPanda: Yea I was thinking we could show a confirm pop-up when a user taps the clear button [21:41:51] kaity: no, I mean, *why* would someone want to clear history? [21:41:53] (03CR) 10JGonera: "Where can you observe this notice?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99628 (owner: 10Aude) [21:41:53] actually [21:41:56] forget I said that :) [21:42:01] it just hit me as I said it [21:42:05] YuviPanda: haha [21:42:06] kaity: makes sense. Will implement :) [21:42:08] YuviPanda: probably needed as someone may have browsed something "embarrassing" and wants to clear it [21:42:14] AndyRussG: as an aside, '96 was a long time ago :p but that is awesome. my wife and i lived in guadalajara a few years back and i got to spend a tiny bit of time in mexico city - i loved it [21:42:21] mhurd: yeah, I hit enter and then it hit me :) [21:42:33] YuviPanda: :) [21:42:40] kaity: saw email about the error page? [21:42:48] YuviPanda: yes [21:42:53] awjr: Yeah, it was a while ago--time flies! What brought you to Guadalajara, and how long were you there for? [21:43:08] kaity: cool [21:43:30] jgonera: just installing mobile frontend [21:43:31] kaity: btw, I was showing http://androidniceties.tumblr.com/ to violetto1 and thought you might like it too! [21:43:55] having all development notices set to display [21:43:59] aude, I don't get any notices :O and I tried, I have PHP set to show notices [21:44:08] all of them? [21:44:09] AndyRussG: we were there for a year or so, working primarily with youth on a storytelling/digital literacy project about water contamination issues [21:44:09] YuviPanda: maybe instead of leaving the page we can show a small pop-up [21:44:12] odd [21:44:18] aude, is there anything I need to set apart from E_ALL in php.ini? [21:44:21] awjr: I don't get the error in a brrowser, and I'm not logged in [21:44:21] kaity: for 'want to clear'? definitely [21:44:28] kaity: small modal. [21:44:45] YuviPanda: I mean for network down [21:44:48] at the moment i have ini_set( 'display_errors', 1 ); [21:44:51] AndyRussG: and also putting together a documentary on the contamination of the rio lerma watershed [21:44:53] that displays all [21:44:55] AndyRussG: if you do log in, do you get the error? [21:44:55] kaity: modal dialog on error? NOOOOO! [21:44:59] those are annoying [21:45:05] I have a personal hatred for apps that do that :) [21:45:16] kaity: they can always hit back to go back to where they were [21:45:17] awjr: sounds like a cool project [21:45:24] or projects [21:45:31] also requires $wgDevelopmentWarnings = true [21:45:35] it was AndyRussG, we're still working on the documentary. or i should say my wife is [21:45:42] YuviPanda: maybe some kind of indication that they are offline so that they dont leave the page [21:45:47] since wfWarn converts stuff to a notice (or warning) with that set on [21:46:00] kaity: that's expensive to do, since we will have to *constantly* keep checking [21:46:15] we probably would have finished it if i hadn't gotten a call from the WMF :p [21:46:16] kaity: the back button pattern is well established in Android, and if they hit back the page they were on + position will be preserveed [21:46:18] *preserved [21:46:37] 'push it again to retry' and 'here's a small thing that's not in your way that you can push or dismiss' are good patterns [21:47:11] brion: yeah, should have a retry in a few mins [21:47:12] awjr: Cool! At the place where I worked until recently--a small research center--I worked with a team that made documentaries [21:47:33] very cool AndyRussG, what is it called? [21:47:35] YuviPanda: hmmm we'll keep looking into it [21:47:43] kaity: ok! [21:47:59] The institute is the Instituto Mora [21:48:02] thanks for sending that android tumblr! awesome stuff [21:48:17] kaity: yup! lovely things there. [21:48:27] The area is the Laboratorio Audiovisual de Investigación Social (Audiovisual Social Science Research Lab) [21:48:28] kaity: I *highly* reccomend you install some of the apps there and check them out [21:49:09] yea! I've been playing with circa actually, they have a nice app on android and ios [21:49:29] cool AndyRussG! [21:49:38] awjr: :) [21:49:50] AndyRussG: im able to replicate the problem with other arbitrary images [21:50:07] but only when im logged in [21:50:30] kaity: nice! [21:51:36] YuviPanda: whats some of your favorite apps? [21:52:24] awjr: Are you doing anything special to replicate it? I just logged in and can see the image in a browser [21:52:38] with ?mobileaction=beta in the url? [21:52:42] AndyRussG: ^ [21:52:51] Yeah [21:53:03] Wait, it looks like I'm not logged in for mobile [21:53:03] kaity: GMail, Hangout, Maps, Square, Foursquare, Twitter, Google Keep, Play Music, Wordpress [21:53:53] kaity: RedReader, Akido, BaconReader, HN [21:54:19] AndyRussG: yeah, if im logged in and am in beta (or am using mobileaction=beta), then it happens consistently for me for images coming from commons (images uploaded directly to enwiki do not seem to have the same problem) [21:54:20] awjr: OK, now I do get the error, properly logged in [21:54:29] very weird [21:55:51] AndyRussG: so yeah, i would dig to see how that magic that loads images from commons works and see if that gives some clues [21:55:57] Looks like I wasn't logged in on mobile then, let me try replicating locally while logged in [21:56:21] jdlrobson: do we do anything special for loading file pages/commons images in beta? [21:56:29] by special i mean different from stable? [21:56:36] kaity: should I email you a list instead of just leave it on IRC? :) [21:56:48] (03CR) 10Aude: "i simply installed mobile frontend." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99628 (owner: 10Aude) [21:56:58] YuviPanda: haha either way! [21:57:42] baconreader? is that for reading fortunes in your bacon? [21:58:17] awjr: Doesn't happen on my local install logged in yet, but I should try setting a different source for images (similar to commons) [21:58:17] hmm, my grease line intersects with my flavor line [21:58:19] is that good? [21:58:35] kaity: no, it's a Reddit reader app :D [21:58:38] AndyRussG: yeah i think there's a config variable for that… [21:58:45] Yeah there is [21:58:51] * AndyRussG has to run in a few minutes 8p [21:58:51] kaity: first app I've ever paid actual money for :D [21:59:07] AndyRussG: wgUseInstantCommons [21:59:43] np, if you do dig anything up, let us know in the bug report - otherwise one of the engineers may pick up the bug and duplicate work :) [21:59:52] awjr: yes there's a bug open [22:00:03] jdlrobson: yes i know :) [22:00:04] awjr: Ah that looks good [22:00:11] it's new page creation [22:00:17] wait wha? [22:00:22] awjr, jdlrobson: I'm currently the assignee for the bug [22:00:24] now im confused [22:00:41] sandwich time bbiab [22:00:54] jdlrobson: we aer talking about https://bugzilla.wikimedia.org/show_bug.cgi?id=57155 [22:01:04] awjr: yes [22:01:15] oh [22:01:19] what does that have to do with new page creation? [22:01:30] kaity: emailed mobile-tech [22:01:46] brion: YuviPanda mhurd : just a reminder to close out your done stories on https://trello.com/b/Q1pNIFXm/mobile-app-sprint-19-saved-pages-history so that we can finalize sprint 20 and if anything will cross over [22:02:01] awjr: 1s i'll find the line of code [22:02:17] cool cool thanks jdlrobson [22:02:21] SkinMobileBeta::handleNewPages [22:02:22] tfinc: yeah, I expect 'ema ll to be cleaned out and in 'Done' in an hour or so [22:02:25] that's the reason [22:02:27] tfinc: most of the code has already been merged [22:02:35] @_@ [22:02:40] woot [22:02:54] AndyRussG: jdlrobson says SkinMobileBeta::handleNewPages is the reason :p [22:03:02] brion: YuviPanda: i have a couple acceptance criteria i'm hoping to wrap up yet today. will keep u posted [22:03:03] jdlrobson: That's where to look for bug 57155? [22:03:14] OK, got it :D [22:03:17] :) [22:03:25] mhurd: I'm skipping the '30 day cleanup' thing for now, just adding the clear button [22:03:32] oh jeez [22:03:37] brion: that iOS card you took should be ok to drop. next sprint has saved pages stuff [22:03:49] YuviPanda: nice! [22:04:15] mhurd: I thought the iOS card brion had was explicitly not about saved pages on disk but just making sure you keep session state open:? [22:04:21] maybe I'm thinking in Android terms [22:04:45] i dont see how that would cause the problem, the logic in that method shouldn't even get run for file pages [22:05:47] awjr, jdlrobson: thanks so much for the help, I'll keep digging into it [22:06:00] : [22:06:00] :) [22:06:09] I'm off in just a sec, may be back online later, hopefully [22:06:20] take it easy AndyRussG [22:06:34] Looking forward to meeting folks soooooooon [22:06:42] oh jdlrobson is it because file pages for commons images don't actually exist? [22:06:59] Thanks, likewise! cheers, all [22:07:55] YuviPanda: it had an out of date mockup - but you're right - 2 of the criteria haven't been met yet - the scroll position saving (which i'm adding) and "record EventLogging data for offline usage" [22:08:09] mhurd: I think we should completely ignore the mockup there, yes. [22:08:13] mhurd: that's for the history [22:08:17] mhurd: is on the wrong card [22:08:27] YuviPanda: ya confirmed w katie earlier [22:08:30] ok [22:08:36] YuviPanda: did u get the logging? [22:08:46] YuviPanda: of offline usage [22:08:55] mhurd: nope. Can you email mobile-tech asking for clarification on what exactly needs logging? [22:09:06] YuviPanda: ya [22:09:21] mhurd: ok [22:10:44] (03CR) 10JGonera: [C: 04-1] "Two minor things, other than that looks good." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99579 (owner: 10Jdlrobson) [22:10:58] wow, that is indeed it $title->exists() will be false for file pages of commons images on the local wiki [22:12:11] (03CR) 10JGonera: [C: 032] Hygiene: Make use of M.isBetaGroupMember [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99580 (owner: 10Jdlrobson) [22:12:58] YuviPanda: email sent [22:13:36] mhurd: sweet [22:21:12] (03PS2) 10Cmcmahon: new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 [22:23:00] awjr jdlrobson jgonera apropos of yesterday's snafu with file upload, https://gerrit.wikimedia.org/r/#/c/99690/ [22:23:38] brion: going to use http://square.github.io/tape/ for EventLogging so that it survives crashes and can be used when offline [22:24:25] brion: 1. put things in queue, 2. Try to clear queue immediately 3. at certain points (onStart, maybe?) try to clear the queue, if it isn't already cleared [22:24:31] brion: should work fairly well [22:25:34] yay awesome chrismcmalunch :) [22:25:44] oops forgot to change my nick [22:25:51] awjr: we [22:26:10] awjr: we've had a test for UploadWizard for some time, this one should work nicely for Mobile [22:26:15] :) [22:27:01] (03CR) 10JGonera: [C: 04-1] "Inline comments + change from patchset 3 got lost (using node_modules)!" (0310 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 (owner: 10Jdlrobson) [22:27:27] (03PS3) 10Cmcmahon: new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 [22:29:03] (03PS4) 10Cmcmahon: new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 [22:29:54] (03PS5) 10Cmcmahon: new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 [22:38:07] YuviPanda that QueueFile sounds perfect for logging type stuff yeah [22:42:13] brion: yup [22:55:42] (03CR) 10Jhall: [C: 04-1] "Found a minor issue in the uploads_step.rb file - I tried adding a comment in Gerrit for the first time, so here's hoping it saves as inte" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 (owner: 10Cmcmahon) [22:57:20] (03CR) 10Yurik: Supported flagged revisions of W0 configurations. (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95657 (owner: 10Dr0ptp4kt) [22:57:33] (03PS1) 10Kaldari: HYGIENE: Deprecating @baseFontSize [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99771 [22:59:47] woohoo, online banking fail. gotta go to the bank in person to deposit a check. :P [23:04:11] (03CR) 10Cmcmahon: "Jeff, I don't think the comment saved correctly, but I did read it. In line 44 of the steps file I am explicitly checking that the href li" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 (owner: 10Cmcmahon) [23:10:05] (03PS1) 10Robmoen: Added handling for captcha support on saveError [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 [23:10:09] (03CR) 10Parent5446: [C: 04-1] "It should be pretty obvious, but this will break any extension that adds legitimate language information to language_urls via the hook." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [23:10:23] (03CR) 10Jhall: [C: 031] "Chris' comment on my comment makes sense, so all good from my end." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 (owner: 10Cmcmahon) [23:15:53] (03CR) 10Kaldari: "Parent5446: Yeah, I was wondering about that, but I didn't see any cases where that was actually happening. Is there a legitimate use case" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [23:17:35] (03PS1) 10Mhurd: Added section tocLevel to core data schema. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/99774 [23:17:42] (03CR) 10JGonera: [C: 04-1] Added handling for captcha support on saveError (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen) [23:18:18] brion-away: ^ when you return :) [23:18:43] (03CR) 10JGonera: "Sorry, I didn't read the commit message ;) Yeah, we have to abstract it. Parts of templates can be also shared by using template partials." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen) [23:22:43] (03CR) 10JGonera: [C: 032] HYGIENE: Deprecating @baseFontSize [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99771 (owner: 10Kaldari) [23:23:18] (03Merged) 10jenkins-bot: HYGIENE: Deprecating @baseFontSize [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99771 (owner: 10Kaldari) [23:23:53] (03PS1) 10Robmoen: Add editing and preview messages to header area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 [23:23:58] (03PS1) 10Jdlrobson: WIP: Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 [23:24:11] (03CR) 10Jdlrobson: [C: 04-1] "Not ready :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [23:26:53] (03PS1) 10Yuvipanda: Add retry button to network failure vie [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99778 [23:29:23] tfinc found another bugello problem - it's only been looking for commons app bugs [23:29:43] ha [23:31:00] think i fixed the issue with pulling out the correct sprint # [23:31:12] but discovered the bugzilla query is out of date when testing : [23:31:18] hopefully should have this wrapped up shortly [23:37:48] mhurd: so that adds a new field to Section? [23:39:29] (03CR) 10Brion VIBBER: [C: 04-1] "Looks good, but since we already pushed a beta including these entities without the added field we need to make sure it'll upgrade the sch" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/99774 (owner: 10Mhurd) [23:40:49] (03CR) 10Parent5446: "I have no idea. Maybe it's just theoretical. But even then I can imagine the surprise on an extension developer's face when their new lang" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [23:42:03] brion: I had a patch up too [23:42:26] looking [23:42:35] (03CR) 10Jdlrobson: "Its theoretical. We used to do this up until 2 weeks ago. See I43fc26bf334753b189e20921f142bade7658ac31" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [23:42:39] :Add retry button to network failure vie" [23:42:41] vie? :) [23:43:32] man i gotta find some light bulbs.... my office gets super dark in the late afternoon [23:43:40] (03PS2) 10Jdlrobson: Story 1402: A/B test showing edit guider after user creates an account [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99579 [23:43:44] brion: gah, missed a 'w' [23:43:55] brion: fixed [23:43:57] :D [23:43:59] (03PS2) 10Yuvipanda: Add retry button to network failure view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99778 [23:44:19] (03PS9) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 [23:44:50] hmm [23:44:55] (03PS6) 10Cmcmahon: new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 [23:45:03] retry works good but i noticed a crash, lemme get the BT [23:45:45] brion: ok [23:45:49] (03PS10) 10Jdlrobson: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 [23:46:06] brion: I've been noticing ACRA misbehaving and just eating the crash if you don't email it [23:46:17] (03CR) 10Jdlrobson: [C: 032] "Rebased manually - fixed reference to SpecialHistory to point at Special:MobileHistory" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [23:48:14] bah my google account wasn't set up on the n4 since i last ref lashed it [23:48:39] (03PS3) 10Jdlrobson: Override language_urls template data to avoid hook abuse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 [23:49:45] (03CR) 10Jdlrobson: [C: 04-1] Add editing and preview messages to header area (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 (owner: 10Robmoen) [23:49:57] (03Merged) 10jenkins-bot: Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94620 (owner: 10Jdlrobson) [23:50:11] (03CR) 10Jdlrobson: [C: 04-1] Added handling for captcha support on saveError (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen) [23:50:20] YuviPanda: ok sent [23:50:31] now where was i with the retry button... [23:50:49] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add retry button to network failure view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99778 (owner: 10Yuvipanda) [23:51:05] brion: okay. to which email? [23:51:18] YuviPanda: to whatever is the default receiver of crash reports [23:51:23] i think yuvipanda at wikimedia? [23:51:24] brion: ah, ok [23:51:26] brion: yeah [23:52:05] brion: clear history implemented! sending a patch now [23:52:31] (03CR) 10Parent5446: [C: 04-1] Override language_urls template data to avoid hook abuse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [23:52:32] ok [23:53:17] why is Parent5446 -1ing me [23:53:20] kaldari: ^ [23:53:26] it's exactly how we did it previously [23:53:42] (03PS1) 10Yuvipanda: Implement 'Clear History' feature [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99780 [23:53:44] brion: there! [23:54:05] (03CR) 10Jdlrobson: "Parent5446 I'm not sure why you are -1ing me but in reply to your earlier comment this was how we have been doing things for 2 years and n" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [23:56:20] YuviPanda: that icon looks like an old-style menu icon, not an action bar icon [23:56:24] but i assume it's a placeholder anyway [23:56:26] so no biggie :D [23:56:41] brion: it's ic_menu, so is supposed to be 'good enough', but yeah, we will have to redo them at some point anyway [23:57:46] (03CR) 10Jdlrobson: "Also FWIW I see no legitimate use for this hook. Template variables should not be changeable. I said so on the talk page: https://www.medi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99693 (owner: 10Jdlrobson) [23:58:19] brion: hmm, super interesting. if i hit reload as well, and it reloads, and then I switch, it still crashes [23:58:42] funky [23:58:59] brion: yeah [23:59:03] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Icon doesn't feel like proper action bar style, will need to be replaced at some point. But it works. :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/99780 (owner: 10Yuvipanda) [23:59:28] brion: think we can mark the two cards as done? [23:59:52] brion: only sticking point I see is EventLogging, and I think we can punt that