[00:27:19] <Krenair>	 YuviPanda, you're on the mobile apps team responsible for the iOS Wikipedia app right?
[00:28:16] <YuviPanda>	 Krenair: yup, although I do just the android bits
[00:28:37] <Krenair>	 do you know if there are any plans to support iOS 7?
[00:28:49] <YuviPanda>	 Krenair: the 'current' app is dead. No work is done on it at all.
[00:28:59] <YuviPanda>	 Krenair: new app is being built now. apps/ios/wikipedia
[00:29:03] <YuviPanda>	 Krenair: and it supports only 6 and 7 :)
[00:29:06] <Krenair>	 presumably the next one will support ios7?
[00:29:08] <YuviPanda>	 and the styling is all 7ish
[00:29:09] <Krenair>	 okay.
[00:30:52] <Krenair>	 YuviPanda, any idea when the new one should be available?
[00:31:07] <YuviPanda>	 Krenair: January end or february start, I'd believe
[00:31:23] <YuviPanda>	 Krenair: although we make beta builds every other week and email mobile-l :)
[00:31:57] <Krenair>	 YuviPanda, this is for someone else, I don't personally have any iOS device. Don't think I should be advertising beta builds to them
[00:32:05] <YuviPanda>	 oh completely agreed, Krenair
[01:35:57] <Gloria>	 Does the App Store have that issue where someone releases a buggy minor version and the reviews get flooded with negative comments?
[01:36:29] <Gloria>	 still have that *
[01:37:07] <YuviPanda>	 Gloria: yup, still does.
[01:37:11] <YuviPanda>	 Android, at least
[01:37:13] <YuviPanda>	 iOS, idk
[01:37:42] <Gloria>	 Fun.
[01:37:53] <YuviPanda>	 :)
[01:37:56] * Gloria  NP: "Defying Gravity" by Idina Menzel & Kristen Chenoweth from "Wicked (Original Broadway Cast Recording)"

[05:44:51] <grrrit-wm>	 (03PS1) 10Legoktm: Only show geonotahack beta feature if GeoData is installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100350 
[17:15:24] <grrrit-wm>	 (03PS1) 10Cmcmahon: hygiene and appearance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100397 
[17:33:28] <grrrit-wm>	 (03PS1) 10Yuvipanda: Handle out of order network responses to search query [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100404 
[17:38:38] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100397 (owner: 10Cmcmahon)
[17:41:26] <grrrit-wm>	 (03Merged) 10jenkins-bot: hygiene and appearance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100397 (owner: 10Cmcmahon)
[17:42:00] <grrrit-wm>	 (03CR) 10Robmoen: "I agree also. thanks for feedback. I'll be working on this today." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen)
[17:42:32] <grrrit-wm>	 (03CR) 10Robmoen: "I agree also. thanks for the feedback." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 (owner: 10Robmoen)
[18:13:46] <yuvipanda>	 hey brion
[18:14:01] <brion>	 hey hey
[18:15:29] <yuvipanda>	 brion: still trying to join the hangout, it just seems to sit there and wiggle disconcertingly at me
[18:15:58] <jgonera>	 jdlrobson, remind me, finally you're doing the interview, not me, right?
[18:16:48] <brion>	 "Sorry, you have been logged out [probably in another window]. Please log in again." sonofa
[18:17:09] <awjr>	 kenanwang, jdlrobson now that im reading https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1484 more closely, i think this is a wontfix
[18:17:16] <yuvipanda>	 brion: won't let me join either
[18:17:21] <brion>	 ok i think i'm on now
[18:17:23] <yuvipanda>	 keeps 'loading' forever
[18:17:24] <brion>	 but i see nobody else
[18:17:27] <kenanwang>	 I'm in but now one is here
[18:17:35] <kenanwang>	 ohh
[18:17:37] <kenanwang>	 brion
[18:17:39] <yuvipanda>	 kenanwang: I'm having issues connecting, not sure why
[18:17:41] <brion>	 ok i see you kenanwang 
[18:18:06] <yuvipanda>	 brion: it keeps crashing my chrome :|
[18:18:10] <kenanwang>	 awjr: OK That's fine
[18:18:24] <awjr>	 kenanwang, jdlrobson afaict the functionality the guy is talking about on desktop is something project-specific; probably some magical css or a gadget/extension they're using to generate that; they would probably need to make whatever tool they're using support mobile - it's not something for us to deal with
[18:18:26] <awjr>	 cool
[18:18:30] <yuvipanda>	 and... firefox just keeps showing me a 'loading'
[18:18:42] <yuvipanda>	 brion: kenanwang I'm just going to mail my status in, Hangout is being a PITA today
[18:19:02] <brion>	 ok
[18:22:26] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Max what are you thoughts on my comment about $wgMFNearby VS class_exists( 'GeoData' ) ?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100350 (owner: 10Legoktm)
[18:22:42] <jdlrobson>	 ^ MaxSem 
[18:24:52] <jgonera>	 jdlrobson, remind me, finally you're doing the interview, not me, right?
[18:27:35] <grrrit-wm>	 (03CR) 10MaxSem: "If people want to create GeoData alternatives they should pretty please avoid using the same API so avoid committing a mortal sin of eithe" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100350 (owner: 10Legoktm)
[18:28:02] <awjr>	 jgonera, jdlrobson, MaxSem, kaldari, kaity, kenanwang: note that our sprint kickoff is rescheduled for an hour earlier than usual and will be in R35 due to a scheduling conflict for kenanwang. the calendar invite should be updated, and i'll mail out an announcement as well
[18:28:22] <yurik>	 dr0ptp4kt, hi, any thoughts on my patch?
[18:28:28] <grrrit-wm>	 (03PS7) 10Cmcmahon: new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 
[18:28:32] <kenanwang>	 Thanks awjr and all!
[18:28:34] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 (owner: 10Cmcmahon)
[18:29:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: new test for uploading an image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99690 (owner: 10Cmcmahon)
[18:29:51] <kaldari>	 awjr: is 1pm the earlier time or the usual time?
[18:30:01] <awjr>	 kaldari: 1pm is the earlier time, usually it's at 2
[18:30:05] <yuvipanda>	 brion: anything from the standup I should knmow about?
[18:30:08] <yuvipanda>	 mhurd: kenanwang ^
[18:30:12] <kaldari>	 awjr: thanks, I couldn't remember :)
[18:30:15] <awjr>	 :D
[18:30:38] <brion>	 moment
[18:33:33] <brion>	 yuvipanda: ok we're going to try closing out a few more little bits of the last sprint today
[18:33:44] <yuvipanda>	 brion: okay. which bits?
[18:33:55] <brion>	 yuvipanda: think we can do a stop-gap implementation of the history thumbnails doing a fetch on demand like we do in search?
[18:34:12] <yuvipanda>	 brion: nope. repeated work and will actually take more time.
[18:34:16] <brion>	 and having it expire records older than 30 days should pretty much do it
[18:34:19] <yuvipanda>	 brion: MaxSem is on the mobileview implementation.
[18:34:35] <MaxSem>	 ?
[18:34:37] <yuvipanda>	 brion: hmm, I'll think of a nice way to do that, yeah.
[18:34:41] <brion>	 ok
[18:34:59] <yuvipanda>	 MaxSem: pageimages in mobileview? awjr said it has been picked up this sprint :)
[18:35:28] <MaxSem>	 kickoff is in 2.5 hours
[18:35:30] <awjr>	 yuvipanda: sprint starts later today, but it's there: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards?favorite_id=10341&view=Next+iteration+story+wall
[18:35:32] <yuvipanda>	 brion: we can have a 'scheduled runner' thingy, and have it check in onCreate for certain circumstances and run
[18:35:39] <MaxSem>	 also, what's that card priority?:P
[18:35:46] <yuvipanda>	 awjr: sweet! 
[18:36:11] <yuvipanda>	 MaxSem: idk how web team does it, but we've at least 2 featuresets blocked on it :) <- awjr
[18:36:54] <brion>	 we can work around it but it offends yuvipanda's sense of good programming to do it the workaround way :)
[18:37:09] <yuvipanda>	 very much so :P
[18:37:19] <brion>	 and it will be nice to do it the proper way, saves us a request which is good on mobile networks
[18:37:35] <yuvipanda>	 it makes the code a bit ugly, and involves multiple requests, and also some synchronizing since history is an infinite scroller
[18:37:38] <brion>	 poor yuvi gets to do all the "bad network testing" for us ;)
[18:37:44] <yuvipanda>	 hehe :P
[18:37:57] <yuvipanda>	 brion: I've a 'bad networking' related patch in gerrit, btw
[18:38:07] <brion>	 whee
[18:38:34] <brion>	 bah, with the new UI style in Firefox nightly i'm having trouble telling Firefox and Chrome windows apart
[18:38:39] <brion>	 the tabs look more similar
[18:38:42] <yuvipanda>	 brion: haha, same for me :D
[18:38:52] <yuvipanda>	 brion: I keep gmail and stuff open in chrome and firefox for everything else
[18:38:52] <brion>	 and they have the same damn hamburger menu icon
[18:39:14] <brion>	 i basically use chrome for Hangouts only :P
[18:39:20] <yuvipanda>	 :P
[18:39:22] <brion>	 cause hangouts still gets confused by multiple accounts
[18:39:47] <brion>	 you'd think this would be like a core google apps feature they'd want to sell you on
[18:40:37] <MaxSem>	 kaldari, I shot you down:P
[18:41:06] <yuvipanda>	 brion: heh
[18:41:16] <yuvipanda>	 brion: so I found out that if I open hangouts from *google calendar*, it does not get confused
[18:41:19] <yuvipanda>	 brion: if i open from gmail, it does
[18:41:23] <brion>	 madness
[18:41:41] <kaldari>	 MaxSem: :*(
[18:42:20] <MaxSem>	 *(
[18:42:32] <yuvipanda>	 (
[18:44:01] <kaldari>	 MaxSem: Ah, looks like Tim has an idea in Bug 53945
[18:44:27] <brion>	 😱
[18:45:38] <yuvipanda>	 brion: mm, smileys!
[18:45:59] <yuvipanda>	 brion: https://en.wikipedia.org/wiki/Adam_tablet - I've one of these now
[18:46:14] <yuvipanda>	 brion: a friend was going to throw them away, so I rescued 'em and put CM9 on it.
[18:46:37] <brion>	 nice
[18:46:59] <kaldari>	 MaxSem: Change abandoned. Poor little change, it never even had a chance.
[18:47:10] <yuvipanda>	 brion: and I spend weekend working on github.com/yuvipanda/AndroLua - lets you type lua code on a desktop webbrowser, and *instantly* syncs it to your tablet so you can execute it
[18:47:13] <MaxSem>	 :*(
[18:47:19] <yuvipanda>	 brion: much easier to try random coding in than typing on the tablet or  using adb
[18:47:44] <yuvipanda>	 brion: after building it out, I realized I can make it run on Glass too :D So type code on laptop, have it run on Glass. :D
[18:47:45] <brion>	 niiice
[18:47:48] <brion>	 haha
[18:47:50] <brion>	 awesome
[18:48:02] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle out of order network responses to search query [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100404 (owner: 10Yuvipanda)
[18:48:24] <yuvipanda>	 brion: it is using ShareJS to do the syncing, so tons of people can type in the code at the same time :)
[18:48:28] <yuvipanda>	 s/the//
[18:49:39] <brion>	 all right let's try updating to intellij 13...
[18:49:54] <brion>	 "what's the worst that could happen?"
[18:50:24] <yuvipanda>	 brion: "we could be writing Java. oh wait..."
[18:52:16] <brion>	 woo it still builds and runs
[18:53:04] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Quick fix for last schema update. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/99804 (owner: 10Mhurd)
[18:54:44] <kaldari>	 MaxSem: I salvaged the convenience function though, since it will be useful for fixing some other disambiguation-related bugs: https://gerrit.wikimedia.org/r/#/c/100413/
[18:55:48] <MaxSem>	 kaldari, profiling?:)
[18:55:56] <kaldari>	 oh yeah!
[18:56:01] <kaldari>	 one sec...
[18:58:41] <kaldari>	 see if that's better
[19:06:41] <grrrit-wm>	 (03PS2) 10Robmoen: Added handling for captcha support on saveError [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 
[19:07:05] <kaldari>	 awjr: Ack, my meeting with Emily and Stephen is also a 1pm
[19:08:31] <kaldari>	 What is kenan's scheduling conflict?
[19:16:21] <tfinc>	 yuvipanda: please mail out your status
[19:17:08] <jdlrobson>	 kaldari: can you help me get error logging up and running?
[19:17:22] <jdlrobson>	 i swear it's not working for me properly
[19:18:44] <yuvipanda>	 tfinc: done
[19:18:59] <kaldari>	 jdlrobson: stick these above your php_info call and see what happens...
[19:19:01] <kaldari>	 error_reporting(E_ALL);
[19:19:01] <kaldari>	 ini_set("display_errors", 1);
[19:21:00] <kaldari>	 $wgShowExceptionDetails = true;
[19:21:01] <kaldari>	 $wgShowSQLErrors = true;
[19:21:02] <kaldari>	 $wgDebugDumpSql  = true;
[19:21:54] <kaldari>	 jdlrobson: $wgDebugLogFile = "/tmp/mediawiki.log";
[19:26:06] <jdlrobson>	 MaxSem: kaldari https://gerrit.wikimedia.org/r/#/c/99628/1 any ideas how to replicate this issue?
[19:26:12] <jdlrobson>	 i can't get any notices
[19:26:18] <ragesoss>	 brion: do you have your Nexus 10 handy?
[19:27:46] <MaxSem>	 jdlrobson, $wgDevelopmentWarnings = true;
[19:30:11] <jdlrobson>	 ahh MaxSem thanks :)
[19:31:03] <grrrit-wm>	 (03PS2) 10Jdlrobson: Fix logout link code to use Userlogout instead of alias [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99628 (owner: 10Aude)
[19:31:09] <ragesoss>	 brion: if/when you do, could you do me a favor and take a screenshot in landscape mode, fullscreen to the extent possible, of [[Encyclopedia]] in a private browsing tab while logged out? I'm trying to get a good high resolution screenshot for a print brochure.
[19:31:29] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Fix logout link code to use Userlogout instead of alias [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99628 (owner: 10Aude)
[19:31:44] <yuvipanda>	 ragesoss: wouldn't a retina screen thing also be as good? brion has one of those too :)
[19:31:54] <kaldari>	 awjr: ^
[19:32:10] <awjr>	 in a mtg kaldari
[19:32:10] <ragesoss>	 yes, a retina would work too.
[19:32:21] <kaldari>	 kenan: ping
[19:32:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix logout link code to use Userlogout instead of alias [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99628 (owner: 10Aude)
[19:32:38] <kaldari>	 where's kenan?
[19:33:09] <yuvipanda>	 kaldari: terribly hard to catch him on IRC, sadly.
[19:33:28] <kaldari>	 so it seems
[19:34:00] <yuvipanda>	 kaldari: btw, your keyboard - is it cherry brown switches or cherry blue?
[19:34:28] <kaldari>	 ?
[19:34:43] <kaldari>	 what the heck is cherry blue? :)
[19:35:06] <kaldari>	 cherries are red
[19:35:09] <kaldari>	 :)
[19:35:18] <yuvipanda>	 kaldari: http://www.daskeyboard.com/blog/mechanical-keyboard-guide/#keyswitches
[19:35:41] <kaldari>	 wow
[19:36:52] <yuvipanda>	 kaldari: blues are loud, browns aren't as loud while having a similar feel
[19:37:20] <kaldari>	 must be blue
[19:37:46] <yuvipanda>	 kaldari: you should try browns at some time. I used a blue one for a long time before I switched to browns, feels better.
[19:57:11] <jdlrobson>	 lolz http://imgs.xkcd.com/store_news/store_gd_g1_QG5Z.png
[19:57:13] <grrrit-wm>	 (03PS1) 10Jdlrobson: Kill some php notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100423 
[19:58:49] <grrrit-wm>	 (03PS2) 10Robmoen: Add editing and preview messages to header area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 
[20:00:49] <rmoen>	 jdlrobson: lolz
[20:01:30] <grrrit-wm>	 (03PS1) 10Yuvipanda: Implement deleteAll as a variant of delete [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100424 
[20:08:09] <awjr>	 kaldari: sorry about the scheduling conflict - i responded to your email
[20:29:55] <yurik>	 dr0ptp4kt, any updates? I need to take off earlier today and will be back later at night
[20:30:16] <dr0ptp4kt>	 yurik, no update yet, sorry. email, for the most part. about to dive in.
[20:30:32] <yurik>	 oki
[20:43:41] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add a recurring task execution mechanism [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100429 
[20:58:54] <tfinc>	 yuvipanda: mhurd any blockers to finishing up sprint 19 ?
[20:59:20] <yuvipanda>	 tfinc: mhurd sent an email to mobile-tech about Eventlogging.
[20:59:47] <tfinc>	 Logging offline activity acceptance criteria...  ?
[20:59:49] <yuvipanda>	 tfinc: other than that just waiting for a feature from the mobile web team (it is in their current iteration - link in my standup status email)
[21:00:15] <yuvipanda>	 tfinc: yeah, that.
[21:00:29] <mhurd>	 tfinc: on track - just taking a bit longer. another hour i think
[21:00:45] <tfinc>	 yuvipanda: at the standup we agreed that blocking on the web team for the feature would delay us longer then necessary and that we should just use the the two request approach to move forward
[21:00:58] <tfinc>	 yuvipanda: also, kenan decided that event logging could wait till later
[21:01:17] <yuvipanda>	 tfinc: it's a day's work, and will have to be scrapped in two weeks time. I would rather just keep it at where it is at right now (black squares) until we get mobile web feature done
[21:01:29] <yuvipanda>	 tfinc: well, in that case there's one patch from me waiting for review from brion, and that should be it.
[21:02:18] <tfinc>	 yuvipanda: do you know when the feature will be deployed by the mobile web team ?
[21:02:54] <yuvipanda>	 tfinc: it's on this iteration for mobile web, so I expect at worst it should be available for us in our next iteration. 
[21:03:14] <yuvipanda>	 tfinc: MaxSem should be able to give a more accurate estimate if necessary.
[21:05:24] <tfinc>	 yuvipanda: looking at their story wall https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards?favorite_id=10341&view=Next+iteration+story+wall i'm seeing it second to last in priorities 
[21:06:15] <yuvipanda>	 tfinc: the hack is error prone, slow, and will need to be duplicated wherever we want to display thumbnails. I'd rather just bump it until MF has that feature done.
[21:06:40] <yuvipanda>	 implementing it after MF has that done is 1/10th the effort of doing it with the hack, and I'm not sure what doing the hack right now gives us.
[21:06:51] <tfinc>	 thats a call for kenan to make then. waiting for him to join post sprint kick off 
[21:07:07] <tfinc>	 plus were already using it on ioS
[21:07:59] <yuvipanda>	 tfinc: I should be able to convince kenan, I think.
[21:08:32] <yuvipanda>	 tfinc: *shrug*. iOS is also architected differently, so perhaps it wasn't as error prone as Android's hack would be.
[21:19:18] <kaity>	 https://www.dropbox.com/s/qm8z6ijdarzzae5/header-02.png
[21:20:32] <mhurd>	 YuviPanda: hey yuvi! quick question - how is the request for search result thumbs either a hack or error prone? 
[21:20:50] <yuvipanda>	 mhurd: search results don't scroll infinitely
[21:20:53] <yuvipanda>	 mhurd: history page does
[21:21:09] <yuvipanda>	 mhurd: so i'll have to wait for a scroll, request another batch, and also handle flings properly
[21:21:26] <tfinc>	 rmoen: you about ?
[21:21:42] <awjr|lunch>	 http://etherpad.wikimedia.org/p/MobileWeb-IterationName
[21:21:49] <yuvipanda>	 mhurd: and I'd also need to handle cancellations when you've scrolled completely past something that had already had a pageimages request fired off for
[21:22:05] <mhurd>	 YuviPanda: but if you cache thumbs in the first place they'll be there for history
[21:22:38] <yuvipanda>	 mhurd: fire off a request at save time?
[21:23:40] <yuvipanda>	 mhurd: I'll also have to handle updating the thumb when the image is changed, and also that means an extra request for every page saved - not *that* bad.
[21:24:44] <yuvipanda>	 mhurd: but true, it's not as terrible as doing the request when you view it.
[21:25:36] <mhurd>	 YuviPanda: we'll have the image changed issue regardless i think. can solve that later?
[21:27:31] <yuvipanda>	 mhurd: hmm, it's certainly a lot more elegant than the one I had in mind.
[21:29:09] <yuvipanda>	 mhurd: okay, I think I can do it in a way that'll make minimal updates necessary later on. Thanks a lot for pointing out this way to me :) I was so focused on the other way that I had not thought of it :)
[21:29:35] <mhurd>	 YuviPanda: you're welcome! :)
[21:29:40] <yuvipanda>	 mhurd: :)
[21:39:47] <tfinc>	 yuvipanda: mhurd : nice job sorting it out :)
[21:39:56] <yuvipanda>	 tfinc: :) I'm working on it now.
[21:44:41] <tfinc>	 jdlrobson: you missing anything else for the interview tomorrow ?
[21:46:33] <grrrit-wm>	 (03CR) 10Legoktm: "> Also, IMO, we should explicitly set $wgAllowUserJs and $wgAllowUserCss to false in MobileFrontend.php in the config variables section (s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96175 (owner: 10Jdlrobson)
[21:50:58] <yuvipanda>	 kaldari: I think we sent everyone a notification for your birthday, except you :)
[21:51:39] <kaldari>	 YuviPanda: Ah, that makes sense ;)
[21:51:48] <yuvipanda>	 :D
[22:10:21] <grrrit-wm>	 (03PS5) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 
[22:11:16] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari)
[22:11:54] <grrrit-wm>	 (03PS6) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 
[22:12:12] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "Yep, that's much better ;) Unfortunately doesn't seem to work. I enabled captcha and when trying to save I've got:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen)
[22:12:34] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari)
[22:14:00] <jgonera>	 jdlrobson, why do we have mobile.editor.styles? why can't those styles be in mobile.editor.common?
[22:14:46] <jdlrobson>	 jgonera: not sure off top of my head - check git blame
[22:15:44] <jgonera>	 jdlrobson, commit message doesn't mention anything, it's from "VE editing on tablets in alpha"
[22:16:12] <jdlrobson>	 mmm might be to do with alpha/beta stuff? not really sure
[22:16:59] <grrrit-wm>	 (03PS7) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 
[22:21:20] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Add editing and preview messages to header area (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 (owner: 10Robmoen)
[22:22:27] <jgonera>	 jdlrobson, how do you get notices from https://gerrit.wikimedia.org/r/#/c/100423/1 to show up?
[22:22:30] <grrrit-wm>	 (03CR) 10Jdlrobson: "Little confused.." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen)
[22:22:54] <grrrit-wm>	 (03PS2) 10Jdlrobson: Kill some php notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100423 
[22:23:00] <jdlrobson>	 updated commit message jgonera  :)
[22:23:06] <jdlrobson>	 i was having that issue this morning :)
[22:23:20] <jgonera>	 thanks!
[22:25:45] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Kill some php notices when $wgDevelopmentWarnings = true; [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100423 (owner: 10Jdlrobson)
[22:26:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Kill some php notices when $wgDevelopmentWarnings = true; [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100423 (owner: 10Jdlrobson)
[22:27:06] <jgonera>	 jdlrobson, this also seems to give a notice: includes/specials/SpecialMobileHistory.php:10:	protected $specialPageName = 'History';
[22:29:03] <jdlrobson>	 jgonera: on what url?
[22:29:09] <jdlrobson>	 are you on latest core?
[22:29:13] <jgonera>	 jdlrobson, every article page
[22:29:15] <jgonera>	 let me check
[22:29:16] <jdlrobson>	 mm
[22:29:44] <jgonera>	 yep, newest core
[22:30:34] <jgonera>	 or perhaps it's includes/MobileContext.php:292:			$redirectUrl = SpecialPage::getTitleFor( 'History', $this->getTitle() )->
[22:33:44] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Hygiene: Introduce isAlphaGroupMember (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99800 (owner: 10Jdlrobson)
[22:45:11] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "Some inline comments. It would be good to replace all the requests for edit tokens. I guess we get them for free now as I see this in page" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99799 (owner: 10Jdlrobson)
[22:49:09] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "Is adding all this special casing really worth it just for preserving the position of the last edited bar? Not that many people are allowe" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98034 (owner: 10Jdlrobson)
[22:57:48] <tfinc>	 awjr: where are you guys at with the discussion on showcases ?
[22:58:04] <awjr>	 tfinc holding pattern until quarterly planning
[22:58:07] <tfinc>	 k
[22:59:33] <awjr>	 tfinc: showcases and a handful of other process-related things have had some discussion on the list, in irc, in person, etc but no concrete decisions made. i figured best to let folks focus on the work at hand and discuss it all when we're all focussed on big picture stuff next week
[23:07:42] <rmoen>	 jgonera: for captcha are you using confirmEdit ? 
[23:08:27] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 04-1] "Just one thing left to do." (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100204 (owner: 10Yurik)
[23:17:27] <jgonera>	 rmoen, to enable it for editing you need $wgCaptchaTriggers['edit'] = true;
[23:17:43] <rmoen>	 jgonera:  ahh thanks ;)
[23:22:33] <MaxSem>	 mmm yuvipanda, do you need a page image on main page?
[23:22:51] <yuvipanda>	 MaxSem: would be nice to have
[23:23:05] <yuvipanda>	 but not absolutely required :)
[23:23:39] <MaxSem>	 yuvipanda, I was thinking that MP is different and a PI might _not_ represent it adequately
[23:24:00] <yuvipanda>	 MaxSem: it'll probably throw up the featured image?
[23:24:00] <MaxSem>	 there's no technical problem with adding it:)
[23:24:15] <MaxSem>	 (other than stale image:P)
[23:24:35] <grrrit-wm>	 (03CR) 10Robmoen: "Ouch, yeah this surfaces some problems with the mw base target class." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen)
[23:24:42] <yuvipanda>	 MaxSem: ah, that
[23:24:49] <yuvipanda>	 MaxSem: how cached are pageimages?
[23:25:07] <MaxSem>	 PI might not work very well on pages glued together from a bunch of templates because it depends on LinksUpdate
[23:25:23] <yuvipanda>	 ah
[23:25:38] <MaxSem>	 and links don't get updated when a page simply gets re-rendered
[23:25:51] <yuvipanda>	 MaxSem: meh, keep it on, for consistency's sake? We can conditionally turn it off later
[23:26:05] <MaxSem>	 yuvipanda, what about other users?
[23:26:19] <yuvipanda>	 MaxSem: what other users? :P
[23:26:23] <yuvipanda>	 *kidding, kidding*
[23:26:40] <MaxSem>	 those mystical ppl who 7use it but will never admit it:P
[23:26:41] <yuvipanda>	 MaxSem: we can fix it in the future to have specific behavior for main page
[23:26:50] <yuvipanda>	 :P
[23:27:28] <yuvipanda>	 MaxSem: or just hide it client-side.
[23:27:55] <yuvipanda>	 MaxSem: we only make a promise of a 'representative image', don't we? if we make it more representative in the future, nothin wrong with it!
[23:28:29] * MaxSem  imagines an xmas pic on new year

[23:29:00] <yuvipanda>	 MaxSem: mf-page-image?
[23:29:02] <yuvipanda>	 :D
[23:29:13] * MaxSem  bites yuvipanda

[23:30:18] * yuvipanda  applies band aid liberally

[23:30:32] <Mediawiki>	 look at me, I'm just a bunch of band aids on top of other band aids!
[23:30:40] <awjr>	 lolololol
[23:31:20] <YuviPanda>	 awjr:  :D
[23:31:27] <YuviPanda>	 MaxSem: what else do you propose?
[23:31:58] <YuviPanda>	 awjr: I'm being chastised in other channels for not capitalizing the 'W'
[23:31:59] <YuviPanda>	 heh
[23:32:05] <awjr>	 hahaha
[23:32:26] <MaxSem>	 YuviPanda, I'm seriously considering not returning the image for MP
[23:32:40] <MaxSem>	 when we fix it to be actually useful, we could add it
[23:32:50] <YuviPanda>	 MaxSem: that's cool too, MaxSem.
[23:34:19] <MaxSem>	 YuviPanda, also - what about PI do you need?
[23:34:33] <MaxSem>	 a thumb with some width?
[23:34:52] <YuviPanda>	 MaxSem: ideally, just the image name. So it can be re-used in different contexts.
[23:35:02] <YuviPanda>	 I've code that calculates thumb URLs from names locally
[23:36:06] <MaxSem>	 omg herecy. what if we change the schema as part of thumbnails overhaul?
[23:36:31] <YuviPanda>	 MaxSem: I bet  there'll be redirects :P)
[23:36:45] <YuviPanda>	 MaxSem: I don't want to make 2 HTTP requests every time I want to display an image.
[23:37:08] <MaxSem>	 lazy panda
[23:37:21] <MaxSem>	 okay
[23:37:26] <YuviPanda>	 MaxSem: mobile networks! latency! <buzzwords>!
[23:37:34] <MaxSem>	 we can add another property later
[23:37:42] <YuviPanda>	 MaxSem: two weeks ago in a bus my latency was about 15s for search :P
[23:38:03] <YuviPanda>	 MaxSem: yeah. also is it always going to be on Commons?
[23:38:34] <MaxSem>	 no
[23:38:41] <MaxSem>	 images can be local
[23:38:57] <YuviPanda>	 right
[23:39:16] <MaxSem>	 you know it only when resolving to a file URL
[23:40:19] <YuviPanda>	 MaxSem: so, I'm going to suggest something :D
[23:40:27] <YuviPanda>	 MaxSem: return the full URL?
[23:40:30] <YuviPanda>	 I can munge it to get thumbs
[23:40:32] <YuviPanda>	 err
[23:40:41] * YuviPanda  pukes a little into a bucket

[23:40:46] <YuviPanda>	 okay, let's not do that.
[23:41:01] * MaxSem  feels pain from that self-inflicted facepalm

[23:41:23] <YuviPanda>	 yeah, that was terrible even by Mediawiki standards
[23:41:31] <MaxSem>	 okay, how 'bout 2 props: name and thumb with a given size?
[23:41:54] <YuviPanda>	 MaxSem: hmm, name, thumb with size & isLocal?
[23:42:13] <MaxSem>	 why isLocal?
[23:42:23] <YuviPanda>	 then I'll construct URL to $wiki or commons
[23:42:57] <MaxSem>	 I'll just give you the thumb
[23:43:00] <MaxSem>	 URL
[23:43:16] <YuviPanda>	 MaxSem: but I'm going to be storing these clientside for future use, at different sizes
[23:43:40] <MaxSem>	 s/one size/another/?:P
[23:44:04] <YuviPanda>	 what if the title had '240px' in it? :P
[23:44:13] <MaxSem>	 still, better than fully construct them in the app...
[23:44:26] <YuviPanda>	 it's almost the same as the one I puked for 
[23:44:27] <MaxSem>	 replace  one last occurence or something...
[23:44:51] <YuviPanda>	 MaxSem: well, replace first occurance in last part of URL
[23:44:57] <YuviPanda>	 that's actually mostly accurate
[23:46:19] <YuviPanda>	 MaxSem: I could do that, but still a bit pukey don't you think?
[23:46:56] <YuviPanda>	 MaxSem: why not 'oroginSite' or something of that sort?
[23:48:20] <MaxSem>	 ask Brion what he thinks?:)
[23:48:40] <YuviPanda>	 MaxSem: he won't be around for a few hours
[23:48:47] <MaxSem>	 meh
[23:48:51] <YuviPanda>	 MaxSem: how hard is it? other than the API design stuff
[23:49:27] <MaxSem>	 not hard at all. other than by doing this we increase the amount of evil in the world
[23:49:42] <YuviPanda>	 MaxSem: well, that's a given simply because it'll require nonzero lines of PHP code
[23:50:57] <YuviPanda>	 MaxSem: think we can do this in time for thursday cutoff?
[23:51:05] <MaxSem>	 we can
[23:51:19] <MaxSem>	 so I'd rather wait for Brion's thoughts
[23:51:19] <YuviPanda>	 sweet to hear.
[23:51:25] <YuviPanda>	 MaxSem: concur.
[23:51:32] <MaxSem>	 sehr gut
[23:51:49] <YuviPanda>	 MaxSem: also, how much of a perf hit will this be?
[23:52:01] <MaxSem>	 unnoticeable
[23:52:07] <YuviPanda>	 MaxSem: ah, nice :)
[23:52:30] <YuviPanda>	 MaxSem: the onlyrequestedsections patch will hit enwiki this thursday, right?
[23:52:39] <YuviPanda>	 or have I missed a week?
[23:52:46] <MaxSem>	 prolly
[23:52:57] <MaxSem>	 it will if it's already on mw.org
[23:53:06] <MaxSem>	 ...which it should
[23:53:16] <YuviPanda>	 right. Just wanted to make sure that we didn't merge it two weeks ago.
[23:57:18] <kaity>	 hey MaxSem
[23:58:33] <MaxSem>	 yo kaity
[23:58:33] <kaity>	 is it possible to see a screenshot of your diff work?
[23:58:33] <grrrit-wm>	 (03PS1) 10MaxSem: Add PageImages to action=mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 
[23:58:50] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-2] "Waiting for finalized requirements." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 (owner: 10MaxSem)
[23:59:18] <YuviPanda>	 MaxSem: sweet! Thanks :)
[23:59:23] <YuviPanda>	 MaxSem: added a bunch of people as reviewers :)