[00:02:39] kaity, http://staging.wmflabs.org/wiki/Special:MobileDiff/12116...12146?useformat=mobile [00:02:50] just updated it to the latest version [00:10:59] thanks MaxSem! [00:13:39] MaxSem, looks good, jdlrobson is pointing out that we should only run it in beta for now though, so http://staging.wmflabs.org/wiki/Special:MobileDiff/12116...12146?useformat=mobile&mobileaction=beta [00:14:12] head's up im updating the mingle wall - things may be weird for a minute [00:14:24] the difference is currently only in CSS - guess I'll need to return the old HTML in stable for now [00:35:57] (03PS1) 10JGonera: Increase the gap between username and roles in diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100510 [00:36:32] kaity, vbamba: quick question… In the new KeepGoing workflow, when a user has already gone through the workflow once (successfully added links to an article), and chooses to fix another article, should we display the linking instructions again? [00:37:27] kaldari: hmm I'm thinking no, what do you think vbamba [00:43:13] tfinc: do you still have my copy of the agile retrospectives book? [00:43:26] awjr: yes [00:43:40] tfinc: can i have it back when i come to town next week? [00:43:44] sure [00:45:00] :D [00:46:09] kaity: I'll go with 'no' then :) [00:49:24] (03CR) 10Jdlrobson: [C: 032] Increase the gap between username and roles in diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100510 (owner: 10JGonera) [00:49:43] kaldari: cool! [00:49:58] (03Merged) 10jenkins-bot: Increase the gap between username and roles in diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100510 (owner: 10JGonera) [00:51:14] (03PS1) 10Jdlrobson: Add alias for Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100513 [00:52:08] (03PS2) 10Jdlrobson: Add alias for Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100513 [00:55:07] (03Abandoned) 10Jdlrobson: Alpha: Allow users to add their own mobile.js and mobile.css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96175 (owner: 10Jdlrobson) [00:56:56] (03CR) 10Jdlrobson: "Max - I'd rather we were consistent in this code base and in future moved all Nearby specific code to the GeoData extension instead of dep" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100350 (owner: 10Legoktm) [01:17:36] yuvipanda: are you all done with https://trello.com/b/Q1pNIFXm/mobile-app-sprint-19-saved-pages-history minus code review ? [01:22:15] (03PS2) 10Jdlrobson: Hygiene: Make use of mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99799 [01:22:46] (03PS1) 10JGonera: [WIP] Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 [01:32:41] (03PS2) 10Jdlrobson: WIP: Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 [01:33:07] (03PS3) 10Jdlrobson: WIP: Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 [01:33:25] (03CR) 10Jdlrobson: [C: 04-1] "See TODO notes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [01:55:33] (03CR) 10Robmoen: "So in VE I have a patch in which addresses this. I'm not sure what our strategy is for tracking events so for now i've moved the problema" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen) [02:02:59] (03CR) 10Yurik: Zero warning page fixes (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100204 (owner: 10Yurik) [02:03:12] dr0ptp4kt, still here? [02:03:16] ^^ [02:07:02] yurik_, yeah, i'm heading out. if you could add a little extra protection there it would be appreciated [02:07:25] dr0ptp4kt, have a good eve [02:07:31] will see what i can do :) [02:08:47] yurik_, you too. thx. i think this one is more on the user psychology side of things. the user may be more predisposed to click the link given the verbiage, i think. obviously, it's hard to know with absolute certainty, to be fair. okay, ttyl [02:08:55] (03CR) 10Dr0ptp4kt: Zero warning page fixes (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100204 (owner: 10Yurik) [03:37:29] (03PS8) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [03:43:38] (03PS9) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [06:11:26] yurik_: thanks for the email [07:35:05] (03PS1) 10Mhurd: Partial model code refactor w/ fix for dupes in history. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/100545 [07:36:14] sdehaan, no prob, hope it helps :) [07:36:28] have you found any extra info? [07:39:51] yurik_: nope, mostly waiting on the MNO to get back to us with /any/ kind of feedback on their side of things. [07:40:28] sdehaan, i heard from dan that mno reported all is ok on their side [07:40:36] (03PS2) 10Mhurd: Partial model code refactor w/ fix for dupes in history. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/100545 [07:40:43] yurik_: of course it is :) [07:40:57] hehe :) [12:00:40] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [14:00:49] hey MaxSem [14:00:50] around? [14:01:04] yep [14:01:39] MaxSem: so I requested a thumbnail for 96px, and got back https://upload.wikimedia.org/wikipedia/commons/thumb/4/49/Gujaratispeakers.png/84px-Gujaratispeakers.png [14:02:09] teh request? [14:02:17] ah [14:02:35] so you're requesting a maximum dimension [14:02:53] that pic is 96px high [14:03:11] wat, I thought we always requested just width?! [14:03:23] no [14:03:26] is that how our thumbnails work, or is it just for pageimages? [14:03:36] I guess it actually makes sense [14:03:52] so we don't get a 1000px tall 2px wide 'thumb' [14:04:33] the latter [14:08:21] (03PS2) 10MaxSem: Only show geonotahack beta feature if nearby is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100350 (owner: 10Legoktm) [14:08:34] MaxSem: sorry, bad bouncer. [14:08:39] MaxSem: did i miss something? [14:08:44] i last said 'hmm' [14:08:47] and 'MaxSem: so I suppose if I want to reuse this, I'll have to rip out the last part of the URL and reconstruct it myself? ' [14:08:48] [18:04:33] the latter [14:09:31] if needed, other thumbnail size modes can be added [14:12:35] MaxSem: hmm, alright. Right now this is fine, I think [14:13:08] https://gerrit.wikimedia.org/r/100567 [14:13:49] sweet [14:14:00] MaxSem: merged [16:10:10] (03PS7) 10Hashar: QA: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 [16:10:50] (03CR) 10Hashar: "Ignoring a few more tests using @needs-custom-setup tag. Will have to fill bug for each of them though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [16:10:53] (03PS8) 10Hashar: QA: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 [16:17:57] (03PS9) 10Hashar: QA: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 [16:19:00] (03CR) 10Hashar: "The feature tests are now passing using:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [16:20:09] (03CR) 10Cmcmahon: "Should be spelled "Barack"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [16:22:23] * MaxSem waves to JeffHall [16:22:39] Hi MaxSem! [16:22:40] welcome! [16:23:02] MaxSem: Thanks - glad to be here! [17:45:02] brion: hey! [17:45:10] hey hey [17:45:42] brion: will fix that bug i emailed about - hopefully only a minute or 2. think i know what it is [17:45:48] awesome [17:45:57] i'm gonna make a quick whole foods run, be back in a few mins [17:46:16] brion: nice. oh we have standup in 30 min [17:46:26] gonna be 3 days in a row :) [17:46:48] aah madness :) [17:46:51] ok i'll be back before then [17:51:34] hey brion [17:51:55] brion: the thumbnail stuff is a bit hacky, but almost done. expect a commit in a bit [17:57:17] oh well, guess I wasn't late after all [17:57:42] I need to walk slower [18:06:55] (03PS3) 10Mhurd: Partial model code refactor w/ fix for dupes in history. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/100545 [18:08:44] (03PS4) 10Mhurd: Partial model code refactor w/ fix for dupes in history. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/100545 [18:09:39] yuvipanda: awesome thanks :D [18:09:42] i'll look over shortly [18:10:15] brion: fixed the bug [18:10:22] \o/ [18:10:26] YuviPanda: hey! [18:10:33] hey mhurd [18:10:41] brion: the thumbnail patch is... kinda large :) [18:10:48] oh my [18:12:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] Implement deleteAll as a variant of delete [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100424 (owner: 10Yuvipanda) [18:13:44] brion: laptop trouble again, trying my backup laptop [18:14:07] :( [18:14:48] (03CR) 10Jdlrobson: [C: 032] Only show geonotahack beta feature if nearby is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100350 (owner: 10Legoktm) [18:15:33] (03Merged) 10jenkins-bot: Only show geonotahack beta feature if nearby is enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100350 (owner: 10Legoktm) [18:15:42] (03CR) 10Brion VIBBER: Add a recurring task execution mechanism (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100429 (owner: 10Yuvipanda) [18:21:26] (03PS3) 10Jdlrobson: Add alias for Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100513 [18:23:19] (03CR) 10Jdlrobson: Hygiene: Introduce isAlphaGroupMember (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99800 (owner: 10Jdlrobson) [18:27:42] brion: how is that 60? [18:27:56] brion: it'll run at worst on the startup that's at least 30 days since last run [18:28:23] and then it'll accumulate another 30 days of data [18:28:27] making 60 days total [18:28:32] and the end of which, it'll trim out the first 30 days [18:28:58] brion: no it clears it out whewn it runs doesn't it? [18:29:19] but it won't run until 30 days past the last successful run, if i'm reading correctly [18:29:34] brion: day 0, it runs, clears up and nothing happens. [18:29:56] brion: then it runs again after 30 days, clears out everything older than 30 days, which is also nothing [18:30:06] brion: and then after 60 days, it'll run again, clear out 0-30 [18:30:08] isn't that what we want? [18:30:37] yuvipanda: except for during days 30-59.9 we see more than 30 days of info in our database [18:30:43] isn't that not what we want? [18:30:55] we could just trim to 30 days once a day and be done with it [18:31:06] ah [18:31:06] no unexpected 1-4 extra weeks of data [18:31:07] hmm [18:31:27] I see what you mean [18:31:31] math is hard. [18:31:34] :D [18:31:42] brion: I can tweak the last run time to a day, yeah [18:31:47] awesome [18:31:55] brion: it won't be exactly a day, but is close enough :) [18:32:02] yeah close enough is fine :D [18:32:12] brion: we can also use the same mechanism to cache style files :D [18:32:31] \o/ [18:32:34] brion: anyway, other CR + testing on that would be nice :) You can test it by changing the time period to something suitably small, like 1 min or something [18:32:47] we really should have a push clear for styles too though, just to plan for it [18:33:08] brion: why? [18:33:25] so we don't have broken styles in the wild for days/weeks every time we push an update? [18:34:14] brb [18:35:04] brion: heh, solution to that is to not push broken styles! :P [18:35:05] * yuvipanda runs [18:39:15] jdlrobson: scrum of scrums? [18:39:25] shit completely forgot awjr [18:39:26] heading over [18:39:32] ty :) [18:40:01] awjr: just curious - does wikidata participate in SoS? [18:40:10] it is today yuvipanda [18:40:16] awjr: does it usually? [18:41:01] today is the first time but they have been expressing interest since the beginning [18:49:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Per IRC discussion, the timing will be changed in an upcoming commit to more aggressively prune so we only have 30-31 days of data max ins" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100429 (owner: 10Yuvipanda) [18:51:05] i don't know where to properly report the minor weirdness i reported at https://www.mediawiki.org/wiki/Talk:Wikimedia_Mobile_engineering#Watchlist_issues_on_mobile_website so i will just paste that link here :) [18:51:42] (03PS1) 10Yuvipanda: Add thumbnail storage support [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100608 [18:51:49] britta: jdlrobson is probably the person to poke about it :) [18:52:14] brion: added the largeish thumbnail commit. Will probably need a bit of cleanup, but wanted to get it out there. Do take a look, It works, just needs minor cleanup [18:52:28] ok [18:53:01] britta: 2nd point sounds like https://bugzilla.wikimedia.org/show_bug.cgi?id=58050 [18:53:01] (03PS1) 10Yuvipanda: Run the history clearere every day [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100609 [18:53:08] brion: and simpler commit for the clearer [18:53:34] i'm not sure why your preference is not remembered though as that seems to be working as expected (at least for me) [18:54:04] jdlrobson: oh interesting, should i add my reversed-list experience to that bug? [18:54:17] britta: feel free :-) [18:54:21] ok [18:55:00] i can try clearing cookies in mobile safari and see if the preference still doesn't get remembered [18:55:18] brion: interesting article about nsurlconnection's caching policy: http://blackpixel.com/blog/2012/05/caching-and-nsurlconnection.html [18:59:28] brion: it's big enough, so do review/test it. The 'upsert' code has a crashingg bug when I do an insert with a stupid error message, so investigating it now [18:59:45] brion: we missed you at scrum of scrums! [19:00:24] heh ok [19:00:31] awjr: ah crap forgot about that [19:00:37] we had an extra standup today which overlapped [19:00:42] E/ACRA (23916): android.database.sqlite.SQLiteException: near ",": syntax error (code 1): , while compiling: UPDATE pageimages SET site=?,title=?,imageName=? WHERE site = ?, title = ? [19:00:46] and then i went about my code review :) [19:00:52] brion: it tells me ^, which is rather... useless [19:00:54] awjr: anything interesting? [19:01:08] yuvipanda: where site= ? AND title = ? ? [19:01:14] brion: i'll be mailing notes out this afternoon - nothing super exciting specific to mobile apps [19:01:16] brion: they're substituted [19:01:25] yuvipanda: no i mean use AND instead of "," ? [19:01:28] but folks were curious what's going on with apps [19:01:29] oh [19:01:32] fuck [19:01:35] brion: would you mind mailingout updates? [19:01:41] awjr: sure [19:01:45] :D [19:02:03] brion: I was looking everywhere [19:02:14] jdlrobson: cleared cookies in settings -> safari, went to wikipedia and logged in, went to http://en.wikipedia.org/wiki/Special:Watchlist (which redirected to https://en.m.wikipedia.org/wiki/Special:Watchlist), tapped "modified". then went to my bookmark of https://en.wikipedia.org/wiki/Special:Watchlist and "list" is the active view instead of "modified" [19:02:56] jdlrobson: i suppose it is a little weird that my bookmark is to the desktop style url instead of the mobile style url [19:03:37] * MaxSem pokes yuvipanda and brion [19:03:46] tfinc: planning for planning? [19:03:47] tfinc: hey you around? [19:04:09] we need to decide about PageImages in mobileview [19:04:10] ? [19:04:55] brion, so Yuvi filed https://bugzilla.wikimedia.org/57994 but it's not clear what exactly needs to be returned [19:05:40] he wants filename and whether the wiki is shared to construct the URLs by hand [19:06:08] I'd rather prefer to return a fully built thumb URL [19:06:42] the problem is that yuvipanda wants to have several sizes of the same image [19:06:55] hmmm [19:06:58] well that is a tricky question [19:07:05] constructing urls by hand is awful and we should never do it [19:07:16] but doing multiple requests to get multiple urls would suck [19:07:57] and doing s/$1px/$2px/ would also suck [19:08:11] and could fail in some cases with funny-sized pics [19:08:20] MaxSem: what's the feasibility of being able to request a series of sizes? [19:08:39] pageimagesize=48|72|96 [19:08:48] doable [19:09:11] yuvipanda, is ^^ ok with you? [19:11:41] we'll assume yuvipanda shows back up in a few minutes :) [19:15:58] MaxSem: brion: on ios i've been grabbing thumbs @ width of 110 [19:16:09] sorry6 was away [19:16:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Some inline comments, but seems to pretty much work for now. :D" (034 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/100545 (owner: 10Mhurd) [19:16:41] brion: thx! will review comments [19:16:42] brion: MaxSem well, no :P that still constraints us [19:17:04] mhurd: reccomend not doing that, since they won't be pre-cached *server* side. Using one of the more common sizes means it'll already be generated and can be faster. [19:17:12] do you want an infinite number of thumbs? [19:17:25] not exactly *infinite* [19:17:50] MaxSem: for example, the width of a thumbnail can be anywhere from 36x36 to 128x128 depending on device's screen density [19:18:27] will the user have an option to chenge their screen resolution?:P [19:18:28] MaxSem: plus I'll have to store those separately in the local database, which is ugh. [19:18:29] YuviPanda: fair enough. would be nice to have a medium-ish size as well - like the 128 you mention [19:18:50] YuviPanda: i'll tweak the sizes i grab later [19:19:29] mhurd: okay! [19:19:49] MaxSem: I don't mind just getting a thumb and doing manipulation to get others. [19:19:56] seems 'cleaner' by mediawiki standards :P [19:21:25] brion: that 'AND' in sqlite was embarassingly stupid. ugh. [19:21:35] :D [19:21:45] yuvipanda, mhurd, actually the standard size is 120px;) [19:22:05] MaxSem: nice [19:22:19] 'wgThumbLimits' => array( [19:22:19] 'default' => array( 120, 150, 180, 200, 220, 250, 300 ), [19:22:30] hmm [19:22:34] what size does mobile web pull? [19:22:42] MaxSem: those are some weird standards :P [19:22:43] but ok [19:22:57] the default one, unless wikitext sets it explicitly [19:23:32] 'wmgThumbsizeIndex' => array( [19:23:32] 'default' => 4, [19:23:32] 'svwiki' => 2, // bug 16739 [19:23:48] mobile search appears to fetch 80px [19:24:10] nearby fetches 180px [19:24:11] whaaa [19:25:18] and mobile watch list uses 150 [19:25:19] huh, you tried to find some sense in it?:P [19:25:27] ok let's just make up random sizes \o/ :D [19:25:37] lol [19:25:54] mhurd: brion we could at least have consistent sizes in the apps :) [19:26:00] across the apps, that is [19:26:12] although I guess Android will have more variety than iOS because screen densiites vary more [19:26:15] let's not worry too much about it just yet and sync up with design at some point probably :) [19:26:27] yeah but we'll target the same size in device-indenpendent pixels [19:26:40] just be server-side fragmentation for the densities [19:26:55] yeah :) [19:26:59] (03PS2) 10Yuvipanda: Add thumbnail storage support [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100608 [19:27:00] brion: sounds good [19:27:06] brion: okay, the SQl bug fixed :) [19:27:20] yay [19:27:47] brion: remember to uninstall and reinstall the app to test :) I don't want to increment the db number for this. [19:30:09] (03PS10) 10Kaldari: WIP: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [19:35:36] (03PS11) 10Kaldari: New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [19:35:51] (03CR) 10Kaldari: [C: 031] New KeepGoing workflow [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [19:36:34] (03PS12) 10Kaldari: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [19:36:37] okay, filing a bug against MF [19:37:08] meanwhile, we still need to figure out what to do, brion and yuvipanda [19:37:25] MaxSem: I'm happy with passing it a single param and getting a response with just that [19:37:55] MaxSem: i can work with what yuvi wants, if you think that makes sense [19:38:39] yuvipanda, so 1 thumb of a given size? [19:38:56] MaxSem: hmm, yeah. how expensive is it to get original size as well? [19:39:07] since I'll need to limit my local requests to make sure they don't go over that (which 404s) [19:40:39] well once you do the lookup getting the size is probably free [19:40:44] (03PS13) 10Kaldari: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [19:40:49] but there's enough internal rules i hate ever trying to replicate it on the client side [19:41:18] much safer to let the server processing do its work and give you back a url for your parameters [19:41:40] jdlrobson, jgonera, MaxSem: The new KeepGoing workflow is ready for review: https://gerrit.wikimedia.org/r/#/c/98745 [19:41:53] kaldari, in an interview now [19:43:45] brion: we will get a URL back, but just change the size ove.r [19:43:46] yuvipanda: odd, i notice sometimes the web view shows blank and i see an error in log: D/WikipediaWeb﹕ file:///android_asset/bridge.js:9 - Uncaught ReferenceError: marshaller is not defined [19:43:57] brion: hmm, I don't see it :| [19:44:17] brion sounds like a race condition you are hitting because of n5. I'll investigate carefully when this stuff is merged [19:44:20] happens on about 1/2 of links for me, nexus 4 running 4.3 [19:44:27] oh [19:44:28] weird [19:44:31] doesn't happen for me :| [19:44:51] aaaand.... none of my history items saved [19:44:53] hrmf [19:45:11] brion: waaaath [19:46:25] steps: 1) launch app 2) search for "art" 3) click on "arthropod" 4) click "W" 5) click "history" 6) see that "Arthropod" appears in history 7) click back a couple times until app closes 8) reopen app 9) hit W 10) his history 11) marvel at big empty list [19:46:54] brion: progress on inspecting the images being downloaded by uiwebview - have the urls so far :) [19:48:28] (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "History items don't survive app exit / reopen. :(" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100608 (owner: 10Yuvipanda) [19:48:34] brion: YuviPanda: running to lunch - back in hour [19:48:43] ok [19:50:54] brion: ok [19:50:59] brion: that's weird :| [19:51:53] if you can't repro it i'll re-scrub the phone and double-check :D [19:53:00] brion: your machine :) i love it [19:53:05] a cr machine [19:55:28] brion: alright [19:55:57] woo [20:12:39] yuvipanda: ok it looks like i have a page images but not a history entry [20:20:20] brion: yeah, i think the clearer might be a bit too agressive [20:20:35] brion: debugging now, gimme a bit. [20:22:35] brion: yup, looks like it is the HistoryCleaerer being aggressive [20:22:45] hmm [20:22:57] i notice that 30 * 24 * 60 * 60 * 1000 will overflow a 32-bit signed integer [20:23:23] result is stored in a long, but none of the bits are so it might be doing 32-bit logic in the compiler [20:23:52] brion: Java can't be that dumb, can it [20:24:36] ok, CLEAR_INTERVAL_MILLI is -1702967296 [20:24:39] so.... yes it can ;) [20:25:12] brion: woah [20:25:16] also 'wat' [20:25:29] (03CR) 10Brion VIBBER: "Ok this also turns out to be just plain broken because CLEAR_INTERVAL_MILLI overflows :D SHould be fixed by later commit that reduces the " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100429 (owner: 10Yuvipanda) [20:25:42] brion: don't merge yet, am making that commit now [20:25:46] ok :D [20:26:23] in a sane world, integer overflows would throw exceptions [20:26:25] or... SOMETHING [20:26:33] brion: great catch, I wouldn't have thought of that :) [20:26:52] yeah i checked the date it was using in the delete query and it was in the future [20:26:56] and i was like "this can't be right" [20:30:48] brion: updated [20:30:54] (03PS2) 10Yuvipanda: Run the history clearer every day [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100609 [20:30:55] (03PS1) 10Yuvipanda: Prevent integer overflow in Java's constant computation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100629 [20:33:57] whee [20:34:22] brion: :) [20:34:24] yuvipanda: i beg you, use L not l [20:34:29] cause 600l looks like 6001 :D [20:35:25] Or 600I [20:35:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok the history clear is due to an overflow in the previous commit, will be fixed shortly." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100608 (owner: 10Yuvipanda) [20:35:58] That's an upper i byw [20:36:01] Btw [20:36:11] :) [20:36:42] 600l 600I 6001 600| [20:36:53] All different... [20:36:56] brion: aha, let me redo that [20:36:59] (03CR) 10Brion VIBBER: [C: 032 V: 032] "The clear count has an integer overflow leftover from previous commit, next commit fixes it." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100609 (owner: 10Yuvipanda) [20:37:07] :p [20:37:35] brion: done [20:37:37] (03PS2) 10Yuvipanda: Prevent integer overflow in Java's constant computation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100629 [20:37:39] \o/ [20:37:41] thanks :D [20:39:48] hey all, I'm ping you (mobile-team) regarding this gerrit change from antoine: [20:39:49] (03CR) 10Brion VIBBER: [C: 032 V: 032] Prevent integer overflow in Java's constant computation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100629 (owner: 10Yuvipanda) [20:39:51] https://gerrit.wikimedia.org/r/#/c/97497/ [20:39:59] pinging specifically awjr|lunch :) ^^^ [20:58:17] brion: there are no unit tests for any of these. makes me nervous [21:02:19] cool thanks for the head's up greg-g :) [21:02:40] looks like chrismcmahon is already on it - i suspect he probably the best one to review :D [21:03:28] :) [21:03:28] brion: also can you confirm that the join there is what it should be? [21:03:46] it *looks* right but i'll do a closer pass [21:03:58] tests would be nice its true... :) [21:04:48] brion: MaxSem did we decide on something for pageimages in mobileview? [21:05:05] Most sane(hehe?) thing to me seems to just ask for a thumbsize and just return that. [21:05:08] yep, I'll show you my code in a bit [21:05:12] ok [21:05:15] awjr greg-g yeah, this is us putting smoke tests into WMF Jenkins. we're taking existing tests for repos that will pass on a wiki with no data or users, running them in PhantomJS for a smoke test in the build [21:05:49] MaxSem: having original width / height in the output would be cool too :) Not a requirement, and we shouldn't do it if it isn't a trivial operation, but if it is... [21:06:25] will do [21:06:48] MaxSem: woo, thanks [21:09:23] brion: when we get the pageimage with mobileview, we can do the topmost 'header image' thing as on https://www.dropbox.com/s/sof9c7bqpvktxgw/Screenshot%202013-12-03%2013.19.52.png [21:10:14] mmmmmmmmm yum :D [21:12:36] brion: I'm going to try sleeping early today. 3:30 AM or so [21:12:53] brb enforced break [21:17:40] mhurd: around? [21:17:56] YuviPanda: ya! [21:18:12] mhurd: any thoughts on how you're planning on handling the images that need to be saved? [21:20:39] YuviPanda: presently playing with listening in to the webview's img requests. that seems to be working so far. was thinking could either record local url at which the default cache stores resource, or perhaps do complete intercept and re-route image data to core-data stores... not sure which will be easier/less troublesome yet... [21:20:57] mhurd: hmm, okay [21:21:12] I can't intercept requests in 2.3, so I am guessing I'll have to rewrite the HTML [21:21:12] YuviPanda: will probably take path of least resistance :) [21:21:22] :) [21:21:23] ok [21:21:38] 2.3! aarrggh! [21:22:09] * tfinc closes sprint board 19 [21:22:34] ha ... 111.54% done for sprint 20 [21:22:37] * tfinc is amused [21:23:17] tfinc: :) [21:23:22] whee [21:23:34] we gave it 110%. and then some [21:26:10] brion_: I'm thinking I'll 1. store the Page object in the sqlite database as a JSON blob, and 2. rewrite all image URLs directly in a deterministic way (Hash'em, probably) and 3. rewrite image URLs on display (not on save) [21:26:13] how does that sound? [21:26:29] yuvipanda: sounds good to me [21:26:33] brion_: sweet. [21:26:47] brion_: we'll download all the images a second time, but I think that's okay [21:27:21] hmm, you thinking of putting in the original html, then rewriting it and then loading in the image? [21:27:58] brion_: sorry, brb in 5 mins. forced break. Am forcing myself to respect these (CTS grr) [21:28:08] ok [21:29:16] MaxSem, jgonera I am trying to put together the agenda for quarterly planning next week. how late are you willing to meet on weds/thurs (PST)? [21:29:39] till 5, preferrably 4 [21:30:51] thanks MaxSem [21:39:10] (03PS2) 10MaxSem: Add PageImages to action=mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 [21:39:25] yuvipanda & brion, ^ [21:40:39] (03CR) 10jenkins-bot: [V: 04-1] Add PageImages to action=mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 (owner: 10MaxSem) [21:41:16] brion_: back [21:42:24] MaxSem: thumb should also return imageHeight and imageWidth rather than the thumb's width and height [21:42:32] original dimensions [21:42:52] there's image for that;_ [21:42:54] ;) [21:45:16] (03PS3) 10MaxSem: Add PageImages to action=mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 [21:46:05] MaxSem: not sure if we should even be adding image, tbh :) [21:46:43] YuviPanda: will the thumb w and h be available otherwise? [21:46:56]