[00:00:23] (03CR) 10JGonera: [C: 04-2] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 (owner: 10JGonera) [00:34:30] (03CR) 10Dr0ptp4kt: [C: 032] Zero warning page fixes [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100204 (owner: 10Yurik) [00:37:59] (03Merged) 10jenkins-bot: Zero warning page fixes [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100204 (owner: 10Yurik) [00:41:15] (03CR) 10Dr0ptp4kt: [C: 032] Removed X-Images variance & legacy url params [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99326 (owner: 10Yurik) [00:41:17] (03Merged) 10jenkins-bot: Removed X-Images variance & legacy url params [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/99326 (owner: 10Yurik) [00:43:00] tfinc: brion: much progress on investigation of how UIWebView's images get cached [00:43:12] mhurd: good news ? [00:43:18] tfinc: yes! [00:44:08] tfinc: was even able to experimentally override the images served up by the cache. weighing options presently [00:46:32] tfinc: i think i want to chat with brion and yuvi tomorrow about options. i presently see 3 approaches for iOS. [00:46:47] mhurd: mail out the the list [00:46:51] to* [00:47:06] that way yuvi can pick it up when he wakes up [00:47:18] tfinc: will do [00:58:19] (03PS3) 10Dr0ptp4kt: When proxied, don't show banners unless proxy is known to be zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95050 [01:00:14] ^^yurik, just changed it to use isSaving. non-mergeable otherwise. we'll have to ask the guys on thursday whether the related vcl thing is a simple thing or not (esi top priority, though). [01:05:38] * MaxSem bashes diffs with his head [01:05:52] WTF, C++ works, PHP doesn't:P [01:14:55] (03CR) 10Yurik: [C: 032] When proxied, don't show banners unless proxy is known to be zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95050 (owner: 10Dr0ptp4kt) [01:14:57] (03Merged) 10jenkins-bot: When proxied, don't show banners unless proxy is known to be zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/95050 (owner: 10Dr0ptp4kt) [01:17:59] (03PS9) 10MaxSem: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [01:18:03] (03CR) 10jenkins-bot: [V: 04-1] Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 (owner: 10MaxSem) [01:20:36] (03PS10) 10MaxSem: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [01:21:14] (03CR) 10jenkins-bot: [V: 04-1] Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 (owner: 10MaxSem) [01:24:36] MaxSem: how are you still awake ? [01:24:52] am I?:P [01:26:54] dr0ptp4kt [01:27:06] yurik-road [01:27:13] i think i accidently merged the wrong patch - the one that you don't want yet [01:27:22] proxies one [01:27:45] do you want to revert it? [01:28:42] yurik-road, shouldn't matter too much unless legit xfbs being sent, right? if legit xfbs are being sent, those also probably shouldn't have banners on them i should think. [01:29:08] dr0ptp4kt, one thing - i think you forgot to add a localized message to that proxy [01:30:13] dr0ptp4kt, add "zeroconfig-proxies" to "en" & "qqq" [01:30:57] yurik-road, strange, i thought i had that there at one time. ok, will look into it [01:33:54] (03PS1) 10Dr0ptp4kt: Don't echo Wikipedia Zero banners when HTTPS isn't zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100729 [01:43:22] (03CR) 10Yurik: [C: 04-1] Don't echo Wikipedia Zero banners when HTTPS isn't zero-rated. (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100729 (owner: 10Dr0ptp4kt) [01:44:41] (03PS1) 10Dr0ptp4kt: Add messages for zeroconfig-proxies Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100731 [01:48:24] (03CR) 10Yurik: [C: 031] "Up to siebrand to approve it i guess" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100731 (owner: 10Dr0ptp4kt) [01:50:12] (03PS2) 10Dr0ptp4kt: Don't echo Wikipedia Zero banners when HTTPS isn't zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100729 [01:51:17] ^yurik, thx [01:52:28] yurik yurik-road, heading out. have a call later tonight. peace out [05:25:05] (03PS1) 10AndyRussG: Don't handle new pages for images or categories [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 [05:25:52] (03CR) 10jenkins-bot: [V: 04-1] Don't handle new pages for images or categories [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 (owner: 10AndyRussG) [05:33:29] (03PS2) 10AndyRussG: Don't handle new pages for images or categories [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 [05:34:13] (03CR) 10jenkins-bot: [V: 04-1] Don't handle new pages for images or categories [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 (owner: 10AndyRussG) [06:00:13] (03CR) 10Yurik: [C: 032] Don't echo Wikipedia Zero banners when HTTPS isn't zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100729 (owner: 10Dr0ptp4kt) [06:00:16] (03Merged) 10jenkins-bot: Don't echo Wikipedia Zero banners when HTTPS isn't zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100729 (owner: 10Dr0ptp4kt) [07:32:28] (03CR) 10Siebrand: [C: 032] Add messages for zeroconfig-proxies Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100731 (owner: 10Dr0ptp4kt) [07:32:30] (03Merged) 10jenkins-bot: Add messages for zeroconfig-proxies Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/100731 (owner: 10Dr0ptp4kt) [09:26:55] (03CR) 10Zfilipin: [C: 031] QA: profile for default settings (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [10:48:31] (03PS3) 10AndyRussG: Don't handle new pages for images or categories [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 [10:54:30] (03CR) 10AndyRussG: "As is shown by the fact that Patch Set 3 passes qunit tests but Patch Set 2 does not, this method of checking the type of page may be frag" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 (owner: 10AndyRussG) [15:55:39] Tpt__: Not sure which OSor browsers this bug has affected, but the little pencil button that allows mobile users to edit a section has disappeared on some devices. Article should reflect bugs and other problems.[[User:I.am.a.qwerty|I.am.a.qwerty]] ([[User talk:I.am.a.qwerty|talk]]) 14:23, 11 December 2013 (UTC) [15:57:48] --tpt__ [15:58:15] thedj: "little pencil button that allows mobile users to edit a section" you are talking about which kind of pages, normal articles or Page: pages ? [15:59:21] Tpt__: sorry, i just auto completed wrong. didn't mean to put you into this [15:59:39] thedj: No problem :-) [16:00:08] yeah someone on english wikipedia saying that this mobile edit button has disappeared. [16:00:17] but i gtg. so bye folks ! [17:06:22] morning all [17:08:27] yo [17:52:42] (03PS1) 10Jdlrobson: Make sure Echo notifications appear in correct order [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100810 [17:52:48] (03PS1) 10Jdlrobson: Prefix notifications with '/' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100811 [18:16:13] mhurd: you getting the office rig signed in ? [18:16:22] tfinc: omw [18:16:43] we're just about to :D [18:16:52] kenanwang: http://en.m.wikipedia.beta.wmflabs.org/wiki/This_page_has_issues [18:17:12] (although that's a bad example due to the bug ;-)) [18:17:29] blargh i am having irc issues [18:17:49] thanks taking a look [18:18:45] jdlrobson: ah, I see you actually did a full review on KeepGoing (but just forgot to publish it), sorry I said it was only "cursory" :) [18:19:09] kaldari: no worries :) [18:19:15] kenanwang: i'm finding you a better less broken example [18:19:16] jdlrobson: did we decide not to replace the icons? [18:21:06] kenanwang: http://en.m.wikipedia.beta.wmflabs.org/wiki/Duel_Masters#issues [18:21:10] we have a single icon [18:21:32] mediawiki.org is logging this: Validation error against schema EchoInteraction: Value "mobile-overlay" for property: context not in enum ["flyout","archive"] [18:23:14] kaldari: > https://bugzilla.wikimedia.org/show_bug.cgi?id=57378 [18:23:25] kenanwang: Keep in mind the Issues interface is very different in Beta than stable [18:24:37] thanks jdlrobson [18:24:50] thanks kaldari [18:25:02] what about the language template? [18:25:07] language selector [18:25:35] how did you find that page by the way? did you create it a previously for the purposes of testing? [18:26:30] kenanwang: i created it previously yes [18:26:35] kenanwang: San Francisco should have languages [18:27:24] http://en.m.wikipedia.beta.wmflabs.org/wiki/Definition_of_music < kenanwang [18:27:39] kenanwang: better example http://en.m.wikipedia.beta.wmflabs.org/wiki/Geocaching [18:27:51] add it to your watch list :) [18:28:03] cool [18:28:26] word [18:29:57] visual editor does it take a long time to load jdlrobson? [18:33:18] I don't seem to see it on beta labs it just keeps loading [18:44:47] dr0ptp4kt, deploying, starting testing :) [18:47:04] can someone review https://gerrit.wikimedia.org/r/#/c/100723/ please? it's quite trivial:) [18:48:20] MaxSem: if someone doesn't get to it first i can take a look in a little bit [18:48:29] thanks [18:50:18] MaxSem: i added a quick comment [18:50:25] sounds fine functionally but i hate the constructor params ;) [18:50:25] yurik, don't break anything. [18:51:15] brion, currently there are two use cases: no parameters and two nulls. very concise and elegant:P [18:52:42] two nulls are never consice and elegant. they're mysterious and confusing [18:53:43] bah [18:54:08] dr0ptp4kt, seems like the landing page is a bit borked :( [18:54:23] yurik, why you break that? [18:54:31] (or why i break it?) [18:54:41] i feel i am not being noticed enough :( [18:55:02] yurik, so you're saying you need to be in more articles [19:05:26] yurik, switching to wifi [19:15:09] awjr: Hey I can't find the bug backlog favorite filter/view in mingle anymore [19:16:57] brion: can anything within an article be considered to be within a section? [19:17:45] dr0ptp4kt: //bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=startup&only=scripts&skin=mobile&target=mobile&* [19:18:02] dr0ptp4kt: //bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=mobile.pagelist.styles%7Cmobile.styles%7Cmobile.styles.beta%2Cpage&only=styles&skin=mobile&target=mobile&* [19:19:04] jdlrobson: How do I see visual editor? [19:19:22] On tablets? [19:19:22] kenanwang: go to alpha and click edit on any page in your desktop browser [19:19:41] It just sits there loading for me [19:21:14] mhurd: yeah anything in an article will be in one of the sections; if at top it's section 0 [19:21:32] brion: awesome! [19:23:49] Actually now when I go I just get the wiki text editor jdlrobson [19:24:02] kenanwang: check with rmoen maybe it's not enabled on beta labs [19:24:14] * jdlrobson going silent to hack with dr0ptp4kt [19:25:57] kenanwang: Yeah not sure, last time I checked there was an error with a WikimediaEvents dependency. [19:26:35] Ok I'll email mobile tech about it [19:42:36] hey brion [19:42:40] hey mhurd [19:42:45] hey hey [19:42:48] brion: mhurd got the message from my friend? [19:42:49] YuviPanda: hey! [19:42:53] ya [19:42:59] am on 3G right now, is slower than usual and has 1.5s ping times [19:43:00] grrr [19:43:08] ouch [19:43:25] brion: anything happened at standup that I should know about? [19:43:37] GMail keeps getting timed out :| [19:43:48] I wonder if all these providers use the same backbone and somehow that is fucked [19:45:18] YuviPanda: not too much , just want to make sure i know what you're working on so i don't dupe anything [19:45:31] brion: hmm, okay [19:45:50] brion: mhurd I've been thinking about 'saved pages' - and I think the idea is that you can always read it even if you are offline, right? [19:46:20] brion: mhurd so I'm thinking that when you are *not* offline, it gets the latest version of the article (and saves it too). If you are offline it picks it up from local storage. How does that sound? [19:47:21] that sounds ideal :D [19:48:03] !logs [19:48:06] brion: mhurd grr, sorry, terrible network [19:48:08] repasting what I said [19:48:13] brion: mhurd I've been thinking about 'saved pages' - and I think the idea is that you can always read it even if you are offline, right? [19:48:24] brion: mhurd so I'm thinking that when you are *not* offline, it gets the latest version of the article (and saves it too). If you are offline it picks it up from local storage. How does that sound? [19:49:24] this sucks, I don't even know if my messages are going through [19:49:25] grr [19:49:33] still here :D [19:49:52] :D alright [19:49:57] brion: mhurd thoughts on that idea? [19:50:23] YuviPanda: yeah i think that's good [19:50:34] gives us always refreshed data when possible [19:50:42] and gives us a good load path when offline [19:50:43] brion: mhurd okay, so that sortof treats saved pages as 'favorites' with the option of an offline fallback [19:50:50] mmm, yeah basically :D [19:51:02] nice :) [19:51:06] mhurd: sounds good to you? [19:51:20] YuviPanda: thinking... [19:51:22] also dammit, I ate some jalapenos for fun and now my foodpipe hurts [19:51:43] well you know not to do that again :D [19:51:57] brion: I did it last week, and then I did it again... [19:52:01] I love spicy things too much :( [19:52:14] although I should probably stop eating them raw [19:52:15] YuviPanda: eat ice cream for fun now. food pipe fixed [19:52:19] s/raw/raw pickled/ [19:52:20] ++ [19:52:25] mhurd: we are out of ice cream [19:52:33] mhurd: and this city has a 11pm curfew for shosp [19:52:35] *shops [19:52:40] YuviPanda: :( [19:53:10] you gotta plan ahead YuviPanda [19:53:16] no jalapeños without ice cream or milk! [19:53:29] YuviPanda: brion: would that same behavior (refreshing if online) be desirable for history items? [19:54:14] mhurd, YuviPanda: possibly yes if we click on them in history list, probably no if we click forward/back [19:54:20] for fwd/back navigation we wanna be super-fast [19:54:29] brion: i like it [19:54:31] but if it's an older item, yeah refresh it is probably good [19:54:33] YuviPanda: what say you [19:56:36] goddamnit [19:56:38] am I here again? [19:56:43] I think I just got a disconnect [19:56:49] mhurd: thoughts on the saved pages idea? [19:56:58] the last message I got was YuviPanda: :( [19:57:23] YuviPanda: "YuviPanda: brion: would that same behavior (refreshing if online) be desirable for history items?" [19:57:45] awjr, am I needed for story prio? [19:57:48] YuviPanda: brion said "mhurd, YuviPanda: possibly yes if we click on them in history list, probably no if we click forward/back" [19:57:55] MaxSem: you are optional [19:58:04] cool [19:58:05] i mean, it is optional for you :) [19:58:31] awjr, I'll be 10 minutes late [19:58:43] np jgonera thanks for the head's up [20:03:39] story prioritization, jdlrobson[dark]? [20:05:11] awjr: ken an is setting up [20:05:19] thanks jdlrobson[dark] [20:08:55] Hello [20:09:03] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards?favorite_id=10043&view=Iteration+Planning [20:11:51] food time [20:13:20] awjr: https://bugzilla.wikimedia.org/buglist.cgi?cmdtype=runnamed&namedcmd=MFE&list_id=258350 [20:18:22] Link 1: http://bit.ly/1bEB5bO [20:18:56] Link 2 [20:18:59] (beta) http://bit.ly/1dqHbuR [20:29:40] YuviPanda: i'm going to grab some lunch and head back to the home office, will try to ping you later if you're more or less online again :D [20:33:38] !logs [20:33:40] goddamn internet [20:39:14] mhurd: I'm giving up for the night, and going to sleep. [20:39:17] mhurd: around? [20:39:26] are my packets coming through? [20:39:26] (03PS11) 10MaxSem: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [20:39:47] YuviPanda, YES! [20:39:56] MaxSem: thank god for that [20:40:08] I think intermittently working internet is way way worse than nonworking internet [20:40:11] * YuviPanda grrrs [20:50:28] (03CR) 10MaxSem: [C: 04-1] "This solution is fragile: core can change, extensions can override core behavior." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 (owner: 10AndyRussG) [20:51:12] Hi MaxSem [20:51:29] hey [20:53:19] Do you know what's the correct way to check what kind of wiki page we're on (i.e., anything that's essentially similar to an article, including say, talk pages)? Should I just check the namespace? [20:53:40] I thought that might be fragile too [20:53:47] heh [20:53:50] It you don't know offhand I can hunt around [20:55:13] hmm, there might even be a legitimate case for creating a category [20:56:02] True... The message sounded more geared to articles [20:56:24] yep, message could use some tweaking too:) [20:57:36] I'd be for making the message adaptable when possible... As in, for standardish wikiish stuff, "This page doesn't exist. Why not be bold and create it?" I think is cool [20:57:59] But for usability, if it's a category, it would be nicer to say "This category..." [20:58:18] Just as for a file that doesn't exist, it should go to the upload page, I think [20:59:49] wikis can customize it with their usual conditionals [21:00:06] also, technically, categories are also pages:) [21:00:17] YuviPanda: welcome back [21:00:27] YuviPanda: can you mail your standup status ? [21:00:58] tfinc: still terrible internet - gmail doesn't load yet (on EDGE/3G). I'll do that when GMail loads. [21:01:13] tfinc: I'll go get the ISP to fix this tomorrow, if not will relocate to somewhere else with proper internet until this gets fixed. [21:01:20] * YuviPanda hits refresh on gmail again [21:01:25] YuviPanda: just message it here and i'll mail it to mobie-tech [21:01:30] Here's a vaguely related bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=58311 [21:01:42] Related to customizing the interface based on what kind of page it is [21:02:53] tfinc: okay! "Started on the underlying SQLite content models for Saved pages. Talked to Monte and Brion about opportunisticly saving pages to make sure the latest version is always available. Investigating ways to make sure that image get saved offline. Spent some time yesterday with Max and brion to get the Thumbnail 'proper' API sorted, should be merged today or tomorrow. No blockers" [21:02:57] tfinc: thanks! [21:03:05] MaxSem: did you find someone to review / merge that patch? [21:03:16] * YuviPanda eyes awjr|lunch [21:03:18] nope YuviPanda [21:03:29] oh crap [21:03:34] i totally forgot to test that yesterday YuviPanda [21:03:51] awjr|lunch: would be nice to get it merged today or so so it can ride the train tomorrow [21:03:54] YuviPanda: if you resend the code review link i'll take a look as soon as im done with lunch [21:04:00] awjr|lunch: [21:04:01] awjr|lunch: https://gerrit.wikimedia.org/r/#/c/100507/ [21:04:04] :) [21:04:32] awjr|lunch: thanke! [21:04:40] np sorry i forgot about it :p [21:04:45] ok now im to lunch for realz [21:05:20] awjr|lunch: I'll probably not be around when you come back though [21:06:22] MaxSem: in any case, I would agree that making custom messages is lower priority than the bug, so if you like for now I can just make it check for files [21:06:36] yep [21:07:24] OK [21:12:30] awjr|lunch, after that, https://gerrit.wikimedia.org/r/97871 would be a good candidate for review:) [21:15:36] AndyRussG: does Terry have you well setup on the other side of 3 ? [21:17:03] (03CR) 10MaxSem: Add PageImages to action=mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 (owner: 10MaxSem) [21:17:04] tfinc: yeah! desk, comfy chair [21:17:25] AndyRussG: great. let me know if you need anything else. i'm at the same place that you saw yesterday [21:19:25] awjr|lunch: did you figure out your leave for the holidays ? [21:19:33] tfinc: cool, thanks so much, likewise... [21:20:53] The grapevine told me there's going to be a... Nerf Skirmish??? So maybe I'll need some shelter then [21:21:42] AndyRussG: always hide behind marktraceur [21:21:52] AndyRussG: and avoid Ironholds. [21:21:55] and you should be good [21:22:06] YuviPanda: How do I identify them? [21:22:40] We'll be the idiots with too much kit [21:22:41] AndyRussG: shout 'free software is the only thing we must use, except for XBox and YouTube' and the first person to shout 'yay!' will be marktraceur :) [21:23:24] I know who'll be getting head-shotted when next he visits... [21:24:08] AndyRussG: We have armaments for you, and you can join in the fun [21:24:21] Or at least, I think we have armaments for you [21:24:27] Do they have proprietary plugins? [21:25:32] We aren't free to paint the tips anything but orange, but that's a bug in government and not the manufacturer's fault. [21:25:57] Also I don't know if Ironholds is aware of that peculiarity. [21:27:30] (03PS4) 10MaxSem: Return 404s on MobileHistory without a title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100699 [21:27:38] jdlrobson[dark], ^^ [21:28:22] MaxSem: no qqq code! [21:28:33] ah [21:28:49] I hate when ppl actually look at changes:P [21:29:05] :P [21:29:29] (03CR) 10Jdlrobson: [C: 04-1] Return 404s on MobileHistory without a title (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100699 (owner: 10MaxSem) [21:30:08] jgonera_nothere awjr|lunch kenan_nothere dr0ptp4kt yurik - we need to make sure the new overlays work for zero before pushing to stable [21:30:10] jdlrobson[dark], actually it's still there;) [21:30:17] MaxSem: it is?! [21:30:26] yup, wasn't removed [21:30:33] MaxSem: just testing now [21:31:02] jdlrobson[dark], ok, is it in master or a patch? [21:31:04] MaxSem: I don't see it.. [21:31:11] yurik: it's in beta on master [21:31:18] (HEAD) x ~/Sites/w/extensions/MobileFrontend $ grep 'mobile-frontend-history-404-title' MobileFrontend.i18n.php [21:31:19] 'mobile-frontend-history-404-title' => 'No such page', [21:32:30] yurik: i made a placeholder for next iteration https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1501 [21:32:39] jdlrobson[dark], race condition: a i18n update has just removed it:P [21:32:45] MaxSem: lolz [21:33:53] MaxSem, do you know how often i18n is refreshed? [21:33:56] jdlrobson[dark]: why are you dark? [21:33:59] daily [21:34:06] YuviPanda: i want to code leave me alone! [21:34:11] * jdlrobson[dark] retreats to his dark room [21:34:13] jdlrobson[dark]: NOOOO! [21:34:20] * YuviPanda sends cats after jdlrobson[dark] [21:34:34] * MaxSem pokes jdlrobson[dark] to make him remeber us [21:37:37] anyway jdlrobson[dark] - the message is still there in TWN and will be caught up when the master rev is back [21:37:50] MaxSem: but it's not in master.. [21:38:00] it seems weird to merge it :) [21:38:09] just like the other traanslations - but they will reappear [21:38:14] MaxSem: do you promise me? [21:38:17] yes [21:38:19] I'll never trust you again if it breaks [21:38:37] wow, you trusted me before?:P [21:38:38] (03CR) 10Jdlrobson: [C: 032] "MaxSem: anyway jdlrobson[dark] - the message is still there in TWN and will be caught up when the master rev is back" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100699 (owner: 10MaxSem) [21:38:44] tfinc: hey boss [21:38:51] rmoen: there you are [21:38:59] been tough trying to get a hold of you [21:39:07] (03CR) 10Kaldari: New KeepGoing workflow for adding links (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [21:39:10] I don't think I'll get anything done with this internet. I'll go off to sleep and get stuff done tomorrow. [21:39:14] (03Merged) 10jenkins-bot: Return 404s on MobileHistory without a title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100699 (owner: 10MaxSem) [21:39:20] tfinc: sorry about that was away for lunch [21:39:24] awjr|lunch: don't forget to get that patch merged in time for the deploy tomorrow :) [21:39:27] tfinc: how can i help ? [21:39:38] jdlrobson[dark]: I added a bunch of replies to your comments at https://gerrit.wikimedia.org/r/#/c/98745/13 [21:39:47] sure let me pm you [21:45:01] rmoen: how goes testing with the iPad Air ? [21:46:40] tfinc: Its going. It just came in the mail this week. ( finally ) and I have a proxy setup on my dev environment so I can test locally. [21:48:25] tfinc: I considered canceling the order because delivery was so pushed back, but they refused as engraving had already been done [21:49:56] (03PS1) 10Kaldari: Quick fix for styling issue with Issues overlay in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100910 [21:57:31] (03CR) 10Kaldari: "Check out Title::getNamespace() and https://www.mediawiki.org/wiki/Manual:Namespace" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 (owner: 10AndyRussG) [21:57:46] tfinc: to answer your question about figuring out my leave, still working on it; it keeps getting lowered in priority on my todo… hopefully resolved today [21:57:58] k [21:58:14] kaldari: Thx, yeah I was looking at that [21:58:17] andrew otto agreed (sort of) to cover for sos though, which is groovy [21:58:45] AndyRussG: Also note there are constants defined for all the namespaces so we usually don't use the namespace numbers directly [21:59:15] kaldari: K [22:00:11] awjr: what is sos? [22:00:24] Are you talking about nerf? [22:00:36] AndyRussG: sos = 'scrum of scrums' - basically a dependency management mtg for all of engineering [22:00:37] heh [22:00:38] no [22:00:39] :p [22:00:56] i nerf alone here in az :( [22:01:29] * chrismcmahon nerfs awjr from across town [22:01:32] AndyRussG: Here's the list: https://www.mediawiki.org/wiki/Manual:Namespace_constants [22:01:33] !!! [22:01:45] nice sneak attack chrismcmahon :p [22:02:18] awjr: a drive-by nerfing, I'd barely looked at IRC all day. timing is everything. [22:02:26] :D [22:03:14] kaldari: There are also more defined by extensions [22:03:24] Including the Education Program extension [22:03:42] true [22:03:45] YuviPanda: you still about? [22:03:56] im going to -1 your patchset in a sec [22:04:04] https://www.mediawiki.org/wiki/Extension:TimedMediaHandler [22:04:07] also [22:04:45] I don't know whether to do it whitelist or blacklist style [22:08:20] AndyRussG: I would go with a blacklist since the general idea of a wiki is that everything is supposed to be editable and anything that isn't is an exception rather than the rule. [22:08:38] tfinc: know if yuvi is gone for the day? [22:08:39] K cool [22:08:58] (03CR) 10Awjrichards: [C: 04-1] Add PageImages to action=mobileview (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 (owner: 10MaxSem) [22:09:00] awjr: if he can get his internet back then he'll return. mail him [22:09:18] k thnx [22:11:18] AndyRussG: You know there might even be a function specifically for this issue buried somewhere in Title or WikiPage, but I can't remember off the top of my head [22:11:49] (03PS1) 10Jdlrobson: Experiment: Add Special:App to alpha to explore usage in Firefox OS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 [22:11:55] ^ dr0ptp4kt [22:12:28] AndyRussG: I wonder if Title::isContentPage() would work [22:12:44] I don't remember what that actually checks for though [22:13:10] Ah I did see that, thought that wasn't it, let me check again [22:13:59] AndyRussG: There might not be, just thought it would be worth double-checking :) [22:14:24] Yea... I think there *should* be [22:14:34] There's so much stuff in the Title object I have a hard time remembering what all is in there [22:15:46] It goes to this line in Namespace.php: $index == NS_MAIN || in_array( $index, $wgContentNamespaces ) [22:16:12] http://www.mediawiki.org/wiki/Manual:$wgContentNamespaces [22:18:11] AndyRussG: Yeah, that's definitely not the solution for this bug then [22:18:26] close, but no not quite :) [22:18:49] Too bad we don't have $wgEditableNamespaces [22:20:29] Although in the cases of File and Category pages they are technically editable, we just don't want to ask people on mobile to edit them (for now). [22:21:14] as both of those types of pages can display useful content without actually existing as a WikiPage [22:22:30] File via InstantCommons, and Category as the autogenerated list of included pages. Special pages, however, are never editable as WikiPages. [22:22:48] (03PS2) 10Jdlrobson: Experiment: Add Special:App to alpha to explore usage in Firefox OS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 [22:30:00] (03PS3) 10Jdlrobson: Experiment: Add Special:App to alpha to explore usage in Firefox OS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 [22:30:47] kaldari: Yeah. Title::isWikitextPage() is not it either. It returns true in the case of a file (as it should, since there's wikitext there). [22:31:20] Maybe I should just do a NS blacklist for now [22:31:28] AndyRussG: Yeah, I think you're right [22:31:44] K [22:33:32] (03PS4) 10MaxSem: Add PageImages to action=mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 [22:33:47] awjr, ^^ [22:35:31] MaxSem: cool just got finished testing, seems to work as advertised :) [22:37:52] cool MaxSem lgtm [22:37:59] (03CR) 10Awjrichards: [C: 032] Add PageImages to action=mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 (owner: 10MaxSem) [22:38:07] whee, thanks [22:38:10] :D [22:38:35] (03Merged) 10jenkins-bot: Add PageImages to action=mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100507 (owner: 10MaxSem) [22:38:46] (03PS17) 10Kaldari: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [22:39:55] (03CR) 10MaxSem: [C: 04-1] Experiment: Add Special:App to alpha to explore usage in Firefox OS (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson) [22:40:31] "$title->getNamespace() != NS_FILE" is a pretty common check. "grep -R getNamespace ." from mw core directory [22:47:40] Bug report about mobile editing: https://en.wikipedia.org/w/index.php?title=Help_talk:Mobile_access&curid=880229&diff=585595537&oldid=582770201 [22:47:50] kaldari, jgonera ^ [22:48:50] StevenW, would be cool if a device where this happens was specified [22:48:50] YuviPanda: did you get an icon for network failures? [22:48:54] YuviPanda: i could do with that now [22:49:26] (03PS4) 10AndyRussG: Don't handle new pages for files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100753 [22:49:31] jdlrobson[dark], what's that [dark], do you belong to some sort of clan now? [22:50:12] jgonera: LEAVE ME ALONE I JUST WANT TO CODE IN THE DARK JEEEZZ MUM! :P [22:50:26] jgonera: i'm just wanting to code in a dark room :) [22:50:38] jgonera: I think he's just dimmed to save power [22:51:49] i think it's ironic that so many people have asked jon what that [dark] means when he's trying to hide away to code :p [22:54:24] MaxSem: got a sec? i have a q about the diff patchset but it's more curiosity than something worth leaving in reveiw [22:54:39]