[00:00:48] awjr, ^^ [00:01:11] (03PS18) 10Jdlrobson: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:03:26] (03PS19) 10Jdlrobson: Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:04:57] (03PS3) 10Jdlrobson: Hygiene: Make use of mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99799 [00:07:23] (03CR) 10Jdlrobson: Story 1448: New KeepGoing workflow for adding links (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:08:59] (03CR) 10Jdlrobson: [C: 04-1] "Please rebase of mw.user (or +2 the mw.user patchset) and use that library instead of wgUserEditCount" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:10:03] MaxSem: diffs in stable look wrong (collapsed on oneline) [00:11:06] this is with the new wikidiff2 and wgMFEnableBetaDiff == true [00:11:13] looks great in beta tho [00:13:54] (03PS18) 10MaxSem: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [00:14:28] awjr, done - wrapped in divs. don't want to return display: block to CSS [00:15:11] MaxSem: that seems to not be right either, now part of the diff is not even appearing [00:16:02] (03PS4) 10Jdlrobson: Hygiene: Make use of mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99799 [00:16:14] MaxSem: updated screenshots: http://imgur.com/oDsBvo9,ISOdNDZ [00:16:28] i gotta go do a mingle migration but i can look back at this in a little while [00:20:26] (03PS20) 10Jdlrobson: Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:20:55] awjr, overheated - will look tomorrow [00:21:02] np MaxSem :) [00:21:14] it's super close! [00:21:20] (03PS3) 10JGonera: Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 [00:25:00] (03PS4) 10JGonera: Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 [00:34:00] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove button.cancel in overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101121 (owner: 10JGonera) [00:34:33] (03Merged) 10jenkins-bot: Hygiene: Remove button.cancel in overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101121 (owner: 10JGonera) [00:35:26] (03CR) 10Jdlrobson: "As stated in person if you use a class instead of inline styles (suggested class name for the gray one is mediumGray) and rebase off of mw" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:35:32] (03CR) 10Jdlrobson: [C: 04-1] Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:40:21] (03CR) 10Jdlrobson: [C: 04-1] "Still shows the icons as 48px in overlay rather than 24px - let me take a look" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100910 (owner: 10Kaldari) [00:40:37] (03CR) 10Kaldari: [C: 04-1] Hygiene: Make use of mw.user (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99799 (owner: 10Jdlrobson) [00:41:43] (03CR) 10JGonera: [C: 032] Hygiene: Add alias for Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100513 (owner: 10Jdlrobson) [00:42:19] (03Merged) 10jenkins-bot: Hygiene: Add alias for Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100513 (owner: 10Jdlrobson) [00:42:24] (03CR) 10JGonera: [C: 04-1] Hygiene: Introduce isAlphaGroupMember (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99800 (owner: 10Jdlrobson) [00:43:06] (03PS5) 10Jdlrobson: Hygiene: Make use of mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99799 [00:45:33] (03CR) 10Jdlrobson: [C: 031] "haven't tested yet but code looks good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 (owner: 10Robmoen) [00:46:46] (03CR) 10Jdlrobson: [C: 031] "Code looks good but need to test still. I'll fix the minor moan in the process to keep the diff cleaner." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen) [00:47:07] (03PS2) 10Jdlrobson: Make sure Echo notifications appear in correct order [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100810 [00:50:58] (03Abandoned) 10Jdlrobson: Quick fix for styling issue with Issues overlay in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100910 (owner: 10Kaldari) [00:53:12] (03CR) 10Kaldari: [C: 032] Hygiene: Make use of mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99799 (owner: 10Jdlrobson) [00:53:52] (03Merged) 10jenkins-bot: Hygiene: Make use of mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99799 (owner: 10Jdlrobson) [00:56:32] (03CR) 10JGonera: [C: 04-1] "Rob, this still doesn't work for me. Is https://gerrit.wikimedia.org/r/#/c/100520 a dependency? If yes, let's add it as a dependency to th" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen) [00:58:20] (03PS21) 10Kaldari: Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [00:58:21] (03PS1) 10Kaldari: Merge "Hygiene: Make use of mw.user" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101159 [00:58:59] (03CR) 10jenkins-bot: [V: 04-1] Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [00:59:36] (03CR) 10JGonera: "Just a heads up about changes in https://gerrit.wikimedia.org/r/#/c/100515/ to support ellipsis in the middle of the header. See "Truncati" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 (owner: 10Robmoen) [01:00:01] (03CR) 10jenkins-bot: [V: 04-1] Merge "Hygiene: Make use of mw.user" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101159 (owner: 10Kaldari) [01:00:31] (03CR) 10JGonera: [C: 032] Prefix notifications with '/' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100811 (owner: 10Jdlrobson) [01:02:43] (03PS1) 10Jdlrobson: Regression: Ensure jQuery selector doesn't happen on hashes containing / symbol [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101161 [01:03:40] https://bugzilla.wikimedia.org/show_bug.cgi?id=58425 <-- WONTFIX? [01:04:06] MaxSem: yeah, that is intended behavior [01:04:42] (03PS22) 10Kaldari: Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [01:05:20] (03CR) 10jenkins-bot: [V: 04-1] Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [01:06:37] (03Abandoned) 10Kaldari: Merge "Hygiene: Make use of mw.user" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101159 (owner: 10Kaldari) [01:06:53] (03CR) 10Jdlrobson: [C: 032] Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 (owner: 10JGonera) [01:06:57] (03CR) 10jenkins-bot: [V: 04-1] Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 (owner: 10JGonera) [01:07:24] (03CR) 10JGonera: [C: 032] Regression: Ensure jQuery selector doesn't happen on hashes containing / symbol [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101161 (owner: 10Jdlrobson) [01:08:00] (03Merged) 10jenkins-bot: Regression: Ensure jQuery selector doesn't happen on hashes containing / symbol [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101161 (owner: 10Jdlrobson) [01:08:28] awjr, I don't seem to be able to move cards out of in analysis [01:08:54] are you logged in MaxSem? [01:09:02] yep [01:09:11] is the column called 'in analysis' or 'needs analysis'? [01:09:26] Needs Analysis [01:09:39] hmm [01:09:43] where are you trying to move the card to MaxSem? [01:09:51] yep [01:10:00] the buttons are also absent [01:10:01] which column are you trying to move it to? [01:10:05] next one [01:10:11] that is weird [01:10:14] can you send me as creenshot? [01:10:20] (03PS5) 10JGonera: Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 [01:11:45] (03CR) 10JGonera: [C: 04-2] "After thinking about it again, let's wait to see what people say on the design mailing list in "Truncating a message, enforcing word order" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 (owner: 10JGonera) [01:12:19] awjr, http://i41.tinypic.com/33wpf0z.png [01:12:43] weird [01:12:47] (03CR) 10JGonera: [C: 032] Allow right clicking on images to avoid previews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101124 (owner: 10Jdlrobson) [01:12:47] for the reference, other moves are possible: http://i44.tinypic.com/i5x5hz.png [01:12:57] did someone kill a transition? [01:13:02] i may have [01:13:10] when i changed the statuses [01:13:20] i can move it, but i have administrator privileges [01:13:21] lemme look [01:13:55] yeah looks like the transition is missing :( [01:14:00] (03Merged) 10jenkins-bot: Allow right clicking on images to avoid previews [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101124 (owner: 10Jdlrobson) [01:14:39] MaxSem: i just added the transition back - can you try again? [01:15:07] although, you still should have seen the dropdown menu for status in the card itself [01:15:59] awjr, works, thanks [01:16:09] jorm, have you accepted that message I sent to design? [01:16:23] np MaxSem thanks for bringing it up :) [01:19:26] (03Abandoned) 10Jdlrobson: Enable editing on fishbowl wikis [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96899 (owner: 10Jdlrobson) [01:21:54] (03Abandoned) 10Jdlrobson: Allow filtering of revisions by namespace [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96172 (owner: 10Jdlrobson) [01:24:10] (03PS2) 10Jdlrobson: Prefix notifications with '/' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100811 [01:24:20] (03CR) 10Jdlrobson: [C: 032] Prefix notifications with '/' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100811 (owner: 10Jdlrobson) [01:25:19] jgonera jdlrobson kaldari tfinc i assume you're going to the holiday party - have a blast, wish i could be there [01:25:33] (03Merged) 10jenkins-bot: Prefix notifications with '/' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100811 (owner: 10Jdlrobson) [01:25:44] thanks awjr [01:25:58] awjr: maybe next time we can add a mustache to a roving robot [01:26:05] !!! [01:26:18] that's what i would like for christmas :) [01:26:41] and my two front teeth [01:31:55] (03PS23) 10Kaldari: Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [01:33:26] kaldari: https://gerrit.wikimedia.org/r/100810 [01:38:41] (03PS24) 10Kaldari: Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 [01:48:06] (03CR) 10Jdlrobson: [C: 032] Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [01:48:43] (03Merged) 10jenkins-bot: Story 1448: New KeepGoing workflow for adding links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98745 (owner: 10Kaldari) [14:02:30] (03PS2) 10Yuvipanda: Draw drawer indicator icon next to the 'W' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101114 [14:02:31] (03PS2) 10Yuvipanda: Request only the sections we really want [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101116 [14:10:06] (03PS3) 10Yuvipanda: Draw drawer indicator icon next to the 'W' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101114 [14:10:07] (03PS3) 10Yuvipanda: Request only the sections we really want [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101116 [15:02:56] yurik (and others), are you still interested in faking http headers? https://bugzilla.wikimedia.org/show_bug.cgi?id=48218 [15:23:37] hi yurik [17:57:36] hey mhurd [17:57:42] heard anything from brion yet? [18:00:18] YuviPanda: no - i left a bit early yesterday too. forgot to email summary to mobile list :( [18:00:25] 'tis ok :) [18:00:31] do email out today :) [18:00:36] k [18:01:38] YuviPanda: may was going to revise some mockups - probably be cool if i incorporate these into summary [18:02:31] mhurd: ok! [18:02:45] YuviPanda: always nicer w pictures [18:04:08] YuviPanda: i told here about android issues w alpha compositing and that we'll play around with adjusting the TOC to be a bit inset so on android you can still see that the web view beneath is scrolling [18:04:21] here ... *her* [18:04:49] I personally don't think seeing it matters that much, but oh well [18:05:37] YuviPanda: that's one of the things i like about this - it kinda works regardless even w/o transparency [18:05:47] right [18:12:07] YuviPanda: brion's here [18:15:23] jgonera: http://mobile-ux.appspot.com/#47 [18:15:36] mhurd: sweet [18:15:48] arg wrong link 1s [18:15:58] https://twitter.com/Paul_Kinlan/status/411499443083808768 < jgonera [18:16:37] mhurd: am I in the wrong hangout? [18:16:43] (03CR) 10Robmoen: "Correct, this still shouldn't work. As of yesterday, I completely changed the way we handle events inside target modules. I'll be adding" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99773 (owner: 10Robmoen) [18:17:31] jdlrobson, yeah, that's why I want to move it to beta ;) [18:17:46] jgonera: super ironically that presentation doesn't seem to work in a desktop browser (binds to touch events maybe) o_O [18:17:53] jgonera: are you on twitter? [18:18:23] jdlrobson, it does, use keyboard arrows [18:18:33] I am, but don't use it frequently [18:18:58] ahhh [18:20:00] I hope other browsers will follow and in future there won't be any need for such hacks [18:21:12] yeh that would be sweet [18:22:55] dr0ptp4kt: around? [18:23:12] YuviPanda, yeah, i'm fighting with intellij [18:23:19] dr0ptp4kt: ah, I see :) [18:23:25] dr0ptp4kt: what's happening with it? [18:23:34] dr0ptp4kt: the app has no setup docs yet, sadly, so sorry about that [18:24:05] YuviPanda: did the glass unit get to you? [18:24:07] YuviPanda, i'm just having dependency problems. so after getting close to building the project, i ended up scrapping all the directories and starting over. do you think we could just screen share for a few minutes and get me setup properly? [18:24:20] tfinc: no, my friend reaches bangalore on Monday. [18:24:29] dr0ptp4kt: sure! [18:24:42] YuviPanda, okay, should we do the Google Hangout now, then? [18:24:48] dr0ptp4kt: yes [18:25:05] dr0ptp4kt: i invited you [18:28:39] hey brion [18:28:41] yo yo [18:28:44] (03PS19) 10MaxSem: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [18:28:47] brion: code review! :) [18:28:51] \o/ [18:28:51] awjr, ^ [18:29:01] cool MaxSem will looks hortly [18:31:15] brion: also I'm going to move the API into the app itself, and integrate OKHttp directly. Thoughts? [18:31:31] brion: means we can cache easily, and our codebase would be cleaner. [18:31:33] YuviPanda: sounds like a good plan [18:31:36] brion: okay! [18:31:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] Ensure that History+PageImages always has a valid projection [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/100688 (owner: 10Yuvipanda) [18:34:00] (03CR) 10Brion VIBBER: "Quick note - I get a crash if I push 'save' when there's no page open yet." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101035 (owner: 10Yuvipanda) [18:34:01] (03PS1) 10MaxSem: Allow to force stable with useformat=stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101242 [18:34:20] (03PS1) 10Jdlrobson: Enable status bar for standalone apps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101243 [18:35:08] (03CR) 10Brion VIBBER: "Crashes if I select "Saved pages" from the menu" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101035 (owner: 10Yuvipanda) [18:35:22] (03PS2) 10Jdlrobson: Enable status bar for standalone apps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101243 [18:35:50] YuviPanda: mailed you the crash reports for those two [18:36:01] also crashes if i save a page that is open [18:36:05] brion: so for that I need to make them conditionally dependent on if a page is open or not. I'd want to fix those in a separate commit, since that'll get frameworky [18:36:06] oh [18:36:08] teh second is bad [18:36:42] (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "And crashes if I save a page that's open, eg search "Arthropod" then hit menu/Save page." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101035 (owner: 10Yuvipanda) [18:38:40] brion: uninstall and reinstall [18:38:45] for STACK_TRACE=java.lang.RuntimeException: android.database.sqlite.SQLiteException: no such table: savedpage (code 1): , while compiling: UPDATE savedpage SET site=?,timestamp=?,title=? WHERE site = ? AND title = ? [18:38:52] (03CR) 10Brion VIBBER: Add Save Page action (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101035 (owner: 10Yuvipanda) [18:39:07] YuviPanda: it looks like you added a table without incrementing the database version or having any provision for adding it [18:39:25] so it's not getting created [18:39:31] so there's no table, hence a crash [18:39:42] can you fix to increment the version and add the table please? [18:39:52] brion: that's fine, I think. until we do the release I think expecting people to uninstall and reinstall is acceptable [18:40:03] i think that's a really shitty habit to get into [18:40:06] i think we should not do that [18:40:27] we need to be not destroying peoples' data as we update [18:40:38] because real people won't be uninstalling and reinstalling all the time [18:40:40] brion: we shouldn't unnecessarily complicate the code for making test updates easier [18:40:41] they're going to upgrade in-place [18:40:55] brion: once more than 3 people start using it, I completely agree [18:41:02] it's pretty necessary, and it's not very complex. you've already got infrastructure to do it yet? [18:41:04] *yes? [18:41:11] for updates? no. just for create. [18:41:22] brion: I'd rather do it when it is necessary, rather than just when 3 of us are using it [18:42:42] i strongly disagree [18:42:46] brion: the moment I have to ask someone who is not you or tomasz to uninstall, I'll do it [18:42:49] this is the time to bake it in [18:43:26] brion: this *will* lead to version inflation. does this mean that every time I tweak a column next weak I'll have to increment the version? [18:43:32] I strongly disagree on doing that. [18:43:34] ... [18:43:40] version inflation? [18:43:44] i don't see how that's a problem [18:44:26] and yes, i'd recommend that every time you change a column you increment the version [18:44:50] brion: updating is complex and error prone, and I'd rather not do it unless necessary. [18:45:39] brion: if you want me to do it, I'll do it after the 'cards' for this iteration are done. [18:46:08] fine i'll let this one slide for now but we need to be prepared to do real updates [18:46:21] brion: I completely agree. [18:48:02] dr0ptp4kt, around? [18:48:15] yurik, yeah, on google hangout with YuviPanda right now [18:48:36] dr0ptp4kt, oh, ok, just wanted to know who is doing the VLC stuff [18:49:50] yurik, i can do that later today if you like. [18:50:00] ok lemme delete/reinstall and then stress test this thing :D [18:50:04] dr0ptp4kt, sure [18:50:40] yurik, cool, will do later [18:51:00] (03CR) 10Yuvipanda: "As discussed on IRC, this needs an uninstall and reinstall to get rid of the crashes. We'll have seamless updating in the near future." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101035 (owner: 10Yuvipanda) [18:51:20] brion: it doesn't actually *save* pages yet, btw :P They work like boomkarks now [18:52:10] (03CR) 10Brion VIBBER: "Ok we're going to punt on the update for now, reviewing on a fresh install." (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101035 (owner: 10Yuvipanda) [18:52:21] YuviPanda: *nod* [18:52:47] YuviPanda: if a page doesn't load completely, it ends up with no thumbnail in history or saved pages [18:53:01] that's probably ok for now [18:53:10] hmm [18:53:12] yeah, since by thursday we'll get thumbs with mobileview [18:53:17] ah excellent [18:53:23] ok good that'll solve itself later ;) [18:53:37] then just upsert the new thumbnail when we reload the page, should resolve it nicely [18:53:46] yeah, that's why I implemented upsert :) [18:53:50] :D [18:54:02] we're missing history icons for search and history selections, they use the external icon. do we need to ask for assets? [18:54:35] brion: I already did ask for hisory, I'll bump that thread up again [18:54:48] awesome [18:55:50] (03CR) 10Awjrichards: [C: 04-1] "Latest patchset seems to cut off multi-line diffs in stable (tested with new wikidiff2). See screenshots of both desktop and mobile diffs:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 (owner: 10MaxSem) [18:56:07] YuviPanda: probably not related to this latest commit but i see some problems sometimes loading pages: [18:56:09] "file:///android_asset/bridge.js:9 - Uncaught ReferenceError: marshaller is not defined" [18:56:25] brion: yeah, you mentioned to me y'day. I'll investigate later today [18:56:30] ah great [18:58:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok things above are mostly workable later:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101035 (owner: 10Yuvipanda) [18:59:11] brion: so this is the core data concurrency pattern i think looks good: http://floriankugler.com/blog/2013/4/2/the-concurrent-core-data-stack [19:00:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] Ensure keyboard is always hidden when opening page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101066 (owner: 10Yuvipanda) [19:01:15] YuviPanda: oh that keyboard one reminds me [19:01:34] if we put focus into the search box while the menu drawer is open, we should probably close the menu drawer [19:01:40] otherwise it seems to stay open over the article we load [19:01:53] brion: yup. I'll do that. [19:01:57] thanks :D [19:04:31] (03CR) 10Brion VIBBER: [C: 032 V: 032] Request only the sections we really want [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101116 (owner: 10Yuvipanda) [19:07:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] "pretty :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101114 (owner: 10Yuvipanda) [19:29:10] (03PS1) 10Mhurd: Schema refactor and other fixes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/101254 [19:32:52] brion: http://stackoverflow.com/a/9632644/135557 [19:32:59] niiiice [19:33:20] brion: sorry, was doing a code walkthrough with Adam [19:33:25] brion: whee, all merged :) [19:33:34] :D [19:33:52] brion: so I was thinking of ways to intercept Images and cache them locally [19:34:02] brion: and realized we could do it on Android with some JS trickery [19:34:19] oh my [19:34:31] brion: rewrite all img src tags to local filesystem on load, then pass off messages to Java to actually load them, and pass back message when they are loaded [19:34:45] that could work yeah [19:35:00] do we have to force a reload when the file becomes present? [19:35:22] or we could use temp placeholder images and then just update the src [19:35:29] brion: no, we'll just rename src to data-waiting-src, and when the message comes back, we rename it :D [19:35:33] perfect [19:35:38] brion: or we can even rename the tag to be something else [19:35:48] brion: or yes, we can do placeholders too. [19:35:53] eeh, let's leave em as :) [19:36:04] brion: heh, yeah. but we can do placeholders. [19:36:08] I think we know the size beforehand [19:36:27] yes, size in dp / css pixels is given in width/height on each element [19:36:32] very handy :D [19:36:54] also -- srcset attribute includes 1.5x and 2.0x density URLs pre made for us [19:37:08] so we can either use those or roll the density ourselves, whatever is easiest [19:37:30] brion: oh, right. I forgot about that. [19:37:45] brion: yeah, we'll know which density to use, so we can strip out the others [19:38:06] nom nom nom [19:38:31] brion: but yeah, first I'll just use the regular stuff [19:38:46] yeah start simple [19:38:56] iterative development ftw [19:39:54] brion: 1. on load, find all img tags 2. rewrite them, 3. send off messages asking for response 4. java grabs actual images, saves them in fs 5. responds with path 6. replace img src with path [19:41:21] YuviPanda: doing the find all img tags in JS or Java? [19:41:30] if in JS, the web view might have already started fetching [19:41:45] brion: hmm, even if we have a DOM element that's unattached? [19:42:46] foo = new Image(); foo.src = 'https://upload.wikimedia.org/wikipedia/commons/thumb/f/f8/Western_Derby_Eland_%28Taurotragus_derbianus_derbianus%29_3_crop.jpg/100px-Western_Derby_Eland_%28Taurotragus_derbianus_derbianus%29_3_crop.jpg'; foo.onload = function(){console.log('this happens')}; [19:42:55] you don't even need to be in a document fragment [19:43:10] it's pretty aggressive as i recall :) [19:43:13] gah [19:43:34] brion: we could do this rather easily with 3.0+ [19:43:49] we could just say 'images don't save on 2.3' ............. [19:43:58] but we'd need to put that question to kenanwang :) [19:46:19] brion: personally, I don't care if Saved Pages die (*just use Pocket, dammit!*), but this feature will be useful for any other media stuff we do too [19:46:43] brion: I'm also wondering if I could just say 'fuck it' and re-download it again. Most of the reuses won't be the same size anyway [19:47:00] reuses? [19:47:05] like for showing a zoom you mean/ [19:47:06] ? [19:47:13] brion: yeah [19:47:24] brion: or 'full screen view' when tapped. [19:47:26] or thumbnail [19:47:36] my recommendation is to use the existing lower-res size at first, then replace it with a full-res beautiful version when it's done loading [19:47:48] that gives you immediate visual feedback but still uses the display properly [19:48:02] so it can be handy to keep em around... [19:48:37] brion: right, but that'll require us to 1. build a fast XML rewriting infrastructure that does not keep everything in memory [19:48:55] heh [19:49:22] YuviPanda: well the other possibility is to transfer the images from JS to Java over the bridge, but that just sounds like horribleness [19:49:52] brion: yes. our bridge performance isn't that great already, and transferring base64 encoded possibly-multi-megabyte things on JS side and then decoding them on Java sounds euahgafsga [19:50:05] haha yeah let's not do that then [19:50:12] brion: :) [19:50:14] but i would like to save images offline one way or another [19:50:30] YuviPanda: we could.... save them to local storage only if you actually hit 'save' perhaps? [19:50:43] then you're possibly double-downloading them, but it's when you're online anyway [19:50:52] brion: yeah, that's what I was proposing. [19:50:58] excellent [19:51:02] brion: when you hit 'save', then download 'em again and save 'em [19:51:29] brion: that's settled then :) [19:51:35] \o/ [19:51:37] brion: also how did you like the animation on drag? [19:51:45] YuviPanda: it's awesome :D [19:51:53] brion: :D [19:51:55] works whether you tap or drag, and is very smooth [19:51:59] yup! [19:52:14] brion: tapping also has a 'selected' style now when you tap on it [19:52:56] brion: are you taking vacation time around christmas? [19:53:23] mhurd: ^ [19:53:52] YuviPanda: i'm not sure if i'll take any additional days [19:54:06] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Note this version requires a delete/reinstall due to the schema change, soon we will start doing proper versioning. :)" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/101254 (owner: 10Mhurd) [19:54:23] YuviPanda: i'll take a couple days around christmas to visit my family down south [19:54:28] not sure exactly what days yet [19:54:31] right [19:54:33] need to check flight vs drive costs [19:54:45] I'm considering taking a week off to stay away from a computer. [19:54:46] spent all my money on the doomed house so it's tight this season [19:54:51] heh :) [19:55:23] ooh wordpress 3.8 is out, i have to upgrade my blog again [19:55:58] brion: yeah, just upgraded a while ago. Looks nicer [19:57:25] (03PS20) 10MaxSem: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 [19:58:01] awjr, https://gerrit.wikimedia.org/r/#/c/97871/19..20/includes/specials/SpecialMobileDiff.php :P:P:P:P [19:58:17] omfg [19:58:21] brion: I'm going to store the page contents separately from the savedpages table, btw. [19:58:23] ha nice one MaxSem [19:58:25] lemme check it out [19:58:35] YuviPanda: good, that lets us use it for cache as well right? [19:59:10] brion: so i was thinking - 1. sqlite table (no contentprovider) for page JSON, 2. FS for images [19:59:21] (2) needs to be FS because then you can just address them directly (file:///0 [19:59:22] ) [19:59:26] MaxSem: that looks better :D [19:59:41] advantage to sqlite over FS for storing json blobs that won't be joined etc? [20:00:07] brion: nothing much, so I'm open to moving that to the FS too. [20:00:30] ok, whichever is easier sounds fine [20:00:39] brion: okay! [20:00:40] just make sure you don't use article titles raw as filenames [20:00:45] cause they can have / and . and shit ;D [20:00:49] brion: heh, yeah. hashing sounds appropriate here [20:00:52] yeah [20:01:02] brion: has site . title and use that, perhaps [20:01:21] *nod* that sounds just fine [20:01:22] brion: hmm, storing them in sqlite gives us upgrades. [20:02:25] what's to upgrade in a key<->blob table? :D [20:02:55] brion: format changes? Parsoid does this, for example :P [20:02:56] (03PS21) 10Awjrichards: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 (owner: 10MaxSem) [20:03:10] ah [20:03:11] * brion hmms [20:03:12] brion: if we switch to parsoid output, for example. [20:03:29] well would we like add a second column for data version or something? [20:03:33] brion: and it can be a different db file than everything else - so won't slow down query perf on this one [20:03:37] yeah [20:03:41] (03CR) 10Awjrichards: [C: 032] Story 1348: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 (owner: 10MaxSem) [20:03:47] brion: DB versions are inherently managed by Android [20:03:50] we can just use those [20:04:44] (03Merged) 10jenkins-bot: Story 1348: Inline diffs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97871 (owner: 10MaxSem) [20:05:01] thank you so much awjr! [20:05:05] :D [20:05:10] np MaxSem, nice work :) [20:05:47] brion: any opposition to storing them in SQLite? [20:06:21] YuviPanda: as long as there's no perf prob with the blob size that's fine [20:06:27] brion: yeah, alright [20:06:40] it's also easy to start with sqlite and break the blobs out :D [20:06:47] hmm, yeah [20:06:55] I'm thinking if storing them in the FS will give us any advantages [20:07:13] brion: since we could just as well store the filepath in the sqlite db and handle upgrades that way [20:07:25] in theory we could fetch the json blobs directly from the JS side using XHR [20:07:32] would that be useful? [20:07:38] brion: I just want to be really careful, since Saved Pages were a *constant* PITA with the old app [20:07:42] heh yeah [20:07:47] brion: nope, not particularly [20:07:48] keep the schema simple and easy to update [20:07:50] ok [20:07:59] then let's just use sqlite for now [20:08:05] brion: ok [20:08:47] anything else before i grab some lunch? [20:09:33] brion: I'll probably go to sleep early today. sleeping at 10AM and waking up at 6PM can't be healthy in the long run, and I feel it is catching up to me [20:09:43] heh [20:09:46] ok [20:10:19] since i missed some time during the week i'm gonna do some catchup on the weekend, so feel free to ping me by mail if i'm not visibly online later [20:10:45] brion: sweet [20:10:52] (03CR) 10JGonera: [C: 032] Make sure Echo notifications appear in correct order [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100810 (owner: 10Jdlrobson) [20:10:55] gonna play with Glass app too ;) [20:11:14] see if i can make it pull wikidata info or something [20:11:39] ok burrito time! [20:12:13] brion: cya! [20:15:27] (03PS1) 10Jdlrobson: Story 1508: Update talk, page previews and geonotahack to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101428 [20:18:33] (03Merged) 10jenkins-bot: Make sure Echo notifications appear in correct order [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100810 (owner: 10Jdlrobson) [20:32:14] brion: mhurd alright, heading to sleep now. hopefully will stay that way. night! [20:32:34] YuviPanda: have a good night! (brion ran to lunch i think) [20:32:40] yeah [21:15:56] (03PS3) 10Jhall: New browser test for "Nearby" page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101129 [21:18:10] brion: wanna review this managed object context madness? :) [21:18:18] \o/ [21:18:21] sure [21:24:23] (03PS1) 10Mhurd: Core data concurrency refactor. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/101436 [21:31:59] jdlrobson: ready when you are in r33 [21:47:46] (03PS4) 10Cmcmahon: New browser test for "Nearby" page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101129 (owner: 10Jhall) [22:01:30] dr0ptp4kt: https://github.com/montehurd/apps-ios-wikipedia [22:16:33] dr0ptp4kt: https://gist.github.com/montehurd/7663582 [22:16:43] (03PS5) 10Jdlrobson: New browser test for "Nearby" page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101129 (owner: 10Jhall) [22:17:38] (03PS6) 10JGonera: [WIP] Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson) [22:18:11] (03CR) 10Jdlrobson: [C: 04-1] "I'm soo soo happy to see progress on this!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101129 (owner: 10Jhall) [22:59:08] YuviPanda: did brion manage to get in all the code review for you ? [23:12:30] (03PS6) 10JGonera: Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 [23:13:24] (03CR) 10JGonera: Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 (owner: 10JGonera) [23:14:04] (03PS7) 10JGonera: Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 [23:34:02] https://www.mediawiki.org/wiki/Extension_talk:MobileFrontend#search_is_no_longer_working_after_updating_36554 [23:34:10] hmm, sounds a bit weird [23:34:22] (03PS2) 10Jdlrobson: Hygiene: Introduce isAlphaGroupMember [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99800 [23:35:20] (03PS3) 10Jdlrobson: Hygiene: Introduce isAlphaGroupMember [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99800