[00:52:04] (03PS6) 10Jdlrobson: Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 [00:52:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 (owner: 10Jdlrobson) [00:53:59] (03PS7) 10Jdlrobson: Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 [00:56:18] ^ jgonera !! [00:56:55] jdlrobson, will check when I finish one thing [01:06:27] thanks jgonera ! :D [01:12:02] (03PS1) 10Dr0ptp4kt: Added some instructions for prospective developers on Macs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101463 [01:22:17] (03PS1) 10Jdlrobson: Story 1464: Push the A/B test to stable for left nav signups [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101465 [01:25:23] tfinc: he did [01:46:52] (03PS1) 10JGonera: [WIP] Fix various annoyances in new search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101466 [01:47:12] (03CR) 10JGonera: [C: 04-2] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101466 (owner: 10JGonera) [01:52:14] (03CR) 10JGonera: [C: 032] Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 (owner: 10Jdlrobson) [01:52:50] (03Merged) 10jenkins-bot: Hygiene: Document less files with kss, generate style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98979 (owner: 10Jdlrobson) [01:56:19] (03PS1) 10Yuvipanda: Handle page state change events to keep page action state in sync [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101467 [08:31:15] hi yurik [08:31:35] hi mayankmadan [08:31:53] yurik, im currently doing this task http://www.google-melange.com/gci/task/view/google/gci2013/5854732451053568 [08:32:27] nice! i replied about it on the bug report btw, have you seen it? [08:34:16] i did [08:46:46] yurik, what tests do i need to write? [08:47:40] mayankmadan, the question is if we can use full blown testing framework for unit tests [08:48:08] currently we have a custom-written script that simply checks that server's replies contain all the expected elements [08:48:30] and i don't think its a good idea to do a custom testing this way [11:03:38] yurik, what tests do i need to write for this task? [12:29:47] yurik, online? [15:33:27] (03PS1) 10Yuvipanda: Hide the drawer when the searchbar is clicked [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101491 [15:40:08] yurik, online? [15:45:09] yuvipanda: yo yo yo yo. [15:45:15] hey aharoni :) [15:45:26] That RTL screenshot is in, um, English. [15:45:35] aharoni: yes. It's a new feature of Android devtools [15:45:38] Can I contribute some translations to make it actually look RTL? [15:45:40] aharoni: forces RTL but keeps language the same [15:46:09] aharoni: ah, yes you can definitely help! We don't have it setup on Translatewiki at all yet :( [15:46:37] Yes, I know, but I'm willing to make a one-time exception. [15:47:01] aharoni: aaha! Directly submit patches for apps/android/wikipedia then? [15:47:06] aharoni: although there is no qqq yet :( [15:47:38] There's another TLA in addition to QQQ that can help me - IRC. [15:47:47] Is it Git or Gerrit? [15:48:07] aharoni: gerrit [15:48:17] aharoni: ah, yes. IRC is definitely available :) [15:48:27] (I meant GitHub of course, not Git.) [15:48:29] OK, cloning. [15:48:35] aharoni: :D [15:49:13] aharoni: there aren't too many strings yet though. [15:49:32] I'm calling it a "one-time exception" because I hate translating in text files with a passion. [15:49:58] aharoni: yes, I know! The actual solution is to get this on twn [15:50:16] aharoni: I don't mind if you want to help with that either :D Is a better idea longer term, I'd think [15:50:23] I can add qq right now if that is what is blocking it [15:50:44] aharoni: you really don't like seeing English in RTL, do you? :) [15:50:45] What's currently blocking it is that I don't know in which file the English is. [15:51:02] aharoni: ah! wikipedia/res/values/strings.xml [15:51:10] Indeed, I really don't like seeing English in RTL. It is often worse than seeing Hebrew in LTR. [15:51:39] ehh... and how do I add a language? [15:51:47] aharoni: it's just a developer feature you can turn on in the 'Developer Options' [15:51:53] "Wikipedia crashed :(". [15:51:56] aharoni: create file called strings-he.xml [15:51:58] "Send Yuvi a crash report" [15:52:14] Got it. [15:52:28] aharoni: those are present only in the debug builds, for reporting crashes. Won't be present in the final builds. [15:57:07] (03PS1) 10Amire80: Add Hebrew strings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101492 [15:57:16] aharoni: sweeet! [16:02:55] yuvipanda: glad you like it. can you make a screenshot? ;) [16:03:36] aharoni: emailed you them [16:03:41] aharoni: look a *lot* better than the English versions :) [16:04:26] aharoni: feel free to tweet them :) [16:05:07] aharoni: I modified the commit slightly. It doesn't like -he, likes -iw. Also I misremembered the filenamne format. [16:05:15] (03PS2) 10Yuvipanda: Add Hebrew strings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101492 (owner: 10Amire80) [16:05:49] (03CR) 10Yuvipanda: [C: 032 V: 032] "Merging for now, will have to be moved to TranslateWiki eventually." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101492 (owner: 10Amire80) [16:05:52] aharoni: merged! [16:06:35] aharoni: did I email them to the right location? [16:06:40] Yes. [16:06:47] Google are steadfast in using deprecated language codes. [16:07:37] aharoni: heh, yeah. [16:07:46] aharoni: I see that the 'W' is being clipped a bit. [16:07:53] Yes. [16:08:02] aharoni: anything else? [16:08:09] Looks quite good@! [16:08:25] aharoni: yup! for the page contents we'll be using RL, so I guess RTL there should take care of it [16:08:41] Sounds good. [16:08:48] aharoni: sweet :) [16:08:52] thanks for the patch! [16:08:57] NP. [16:09:03] You still use the floppy disk for saving :) [16:09:19] aharoni: mostly because haven't gotten around to pestering the deisgn folks for new icons :) [16:09:36] Is it a native Android thing? [16:09:46] aharoni: right now all icons are native android things, yes [16:09:58] except the 'W' [16:15:07] So it's Android that still uses the floppy. Amusing somewhat. [16:15:30] aharoni: heh :D [16:15:37] aharoni: alright, I'm going to go have some dinner :D [16:15:44] cya around! and thanks for the patch! [16:16:02] aharoni: hopefully the RTL situation with this app won't be 'whack-a-mole' unlike the previous one [16:17:17] :) [21:52:27] (03CR) 10MZMcBride: "Follow-up: ." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/90062 (owner: 10Jdlrobson) [21:52:53] * Gloria NP: "Upside Down" by Paloma Faith from "Do You Want The Truth Or Something Beautiful?"