[01:02:54] <grrrit-wm>	 (03PS2) 10Yuvipanda: Hide the drawer when the searchbar is clicked [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101491 
[01:02:55] <grrrit-wm>	 (03PS2) 10Yuvipanda: Handle page state change events to keep page action state in sync [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101467 
[01:12:37] <grrrit-wm>	 (03PS1) 10Yuvipanda: Setup appropriate strings for clearing Saved Pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101606 
[01:33:54] <grrrit-wm>	 (03PS1) 10Yuvipanda: Reduce gap between search spinner & overflow menu button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101607 
[03:05:40] <grrrit-wm>	 (03PS1) 10Yuvipanda: Minor RTL fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101611 
[03:13:20] <grrrit-wm>	 (03PS1) 10Yuvipanda: Minor stylistic fixes for the Page Contents [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101612 
[05:31:58] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add minimal styling for tables and thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101616 
[08:31:49] <mayankmadan>	 yurik, online?
[08:32:05] <yurik>	 mayankmadan, nope, i should be sleeping.... 3:30 ;0
[08:32:07] <yurik>	 am
[08:32:13] <yurik>	 :)
[08:32:25] <mayankmadan>	 good night :)
[08:33:54] <yurik>	 mayankmadan, nah
[08:34:01] <yurik>	 will probably stay up for a bit longer
[08:34:13] <yurik>	 what' sup ;)
[08:34:13] <mayankmadan>	 yurik, busy?
[08:34:22] <mayankmadan>	 are you busy?
[08:34:40] <mayankmadan>	 or can i ask you for a favor?
[08:34:41] <yurik>	 coding away - https://www.mediawiki.org/wiki/Requests_for_comment/Json_Config_pages_in_wiki
[08:34:52] <yurik>	 you could ask :)
[08:34:58] <mayankmadan>	 great
[08:35:17] <mayankmadan>	 yurik, can you have a look at this? https://gerrit.wikimedia.org/r/#/c/101485/
[08:35:31] <yurik>	 its scarry!
[08:36:04] <yurik>	 not sure exactly what i'm looking at :)
[08:36:50] <mayankmadan>	 yurik, zeljko asked me to write a test which supply custom header and checks if the content returned from the server is correct
[08:37:08] <yurik>	 ok, so just to be sure we are on the same page:
[08:38:23] <mayankmadan>	 what?
[08:38:40] <yurik>	 the request should go to http://en.m.wikipedia.org/wiki/Main_Page   and the custom header should be set to X-CS=-TEST-ALL
[08:38:56] <yurik>	 and you should see this page; http://en.m.wikipedia.org/wiki/Main_Page?X-CS=-TEST-ALL
[08:39:33] <yurik>	 than, another test should go to the same page, but with the header 250-99 -- and you would see http://en.m.wikipedia.org/wiki/Main_Page?X-CS=250-99
[08:39:39] <mayankmadan>	 okay
[08:39:51] <mayankmadan>	 yurik, so i write a test for that and im done with this task?
[08:40:12] <yurik>	 well, if the header content is controllable from within the test, yeah, should be good :)
[08:40:23] <mayankmadan>	 controllable?
[08:40:53] <yurik>	 as in - within the test you say "go to the URL ..., with the X-CS custom header == ..."
[08:41:08] <yurik>	 than you do another test just like that but the header is set to something else
[08:41:23] <yurik>	 i haven't looked closelly at the testing framework, hence can't say it in the proper terms
[08:41:42] <mayankmadan>	 okay
[08:42:15] <yurik>	 so if you don't have to set up an independent proxy, with some magic constant header, it should be perfect :)
[08:42:49] <yurik>	 our tests would than list all the needed configs and ping them one at a time, verifying that the header is there when it needs to be there
[08:49:20] <mayankmadan>	 yurik, when i set the header to -TEST-ALL the content that should be there is there(The yellow strip at the top) but the url is just  http://en.m.wikipedia.org/wiki/Main_Page
[08:49:25] <mayankmadan>	 is that a problem
[08:49:50] <yurik>	 mayankmadan, not sure i understood
[08:50:04] <yurik>	 the URL with the ?X-CS=...  is a hack
[08:50:12] <yurik>	 it should not be used in a test
[08:50:29] <yurik>	 i use it only to show what it will look like
[08:50:38] <mayankmadan>	 that means the custom header doesnt appear in the url parametres
[08:50:50] <mayankmadan>	 yurik, ^
[08:50:52] <yurik>	 ??
[08:51:03] <yurik>	 custom header is a header, not a URL param, right
[08:51:08] <yurik>	 they just have the same name
[08:51:17] <yurik>	 URL param is for manual testing
[08:51:32] <mayankmadan>	 i know that
[08:51:42] <mayankmadan>	 let me show you a screenshot
[08:52:07] <yurik>	 in the code i have this logic:   if (  url-param is defined ) use url param, else if ( header is defined ) use the header
[08:52:27] <yurik>	 both are "X-CS"
[08:53:12] <mayankmadan>	 yurik, this is the webpage im getting http://imgur.com/4zqQOSH
[08:53:22] <mayankmadan>	 this is the screenshot of the web page
[08:53:28] <yurik>	 right
[08:53:32] <yurik>	 this is good
[08:53:40] <mayankmadan>	 ok
[08:53:42] <yurik>	 but what url are you using for that?
[08:53:56] <mayankmadan>	 http://en.m.wikipedia.org/wiki/Main_Page
[08:54:02] <yurik>	 ok, good, exactly what i need :)
[08:54:07] <mayankmadan>	 great
[08:54:14] <mayankmadan>	 let me save the test and upload to gerrit
[08:54:51] <yurik>	 just to make it clearer - could you add two tests - one with X-CS = 250-99, and another - with X-CS = -TEST-ALL
[08:54:54] <yurik>	 mayankmadan, ^
[08:55:04] <mayankmadan>	 ok no problem
[08:55:09] <yurik>	 thx :)
[08:55:38] <mayankmadan>	 yurik, is there a trick to get these working in the url params?
[08:55:47] <yurik>	 ?
[08:55:59] <yurik>	 they shouldn't be in the URL params - that's just for manual testing
[08:56:06] <mayankmadan>	 when i run http://en.m.wikipedia.org/wiki/Main_Page?X-CS=-TEST-ALL in chrome
[08:56:11] <mayankmadan>	 i dont get any thing different
[08:56:20] <yurik>	 you don't get a banner?
[08:56:32] <yurik>	 make sure you run from privacy mode
[08:56:47] <mayankmadan>	 when i open these sites in chrome manually i dont get anything different
[08:56:55] <yurik>	 different from what?
[08:56:57] <mayankmadan>	 yurik, why do i need privacy mode?
[08:57:06] <yurik>	 because you have some headers set
[08:57:13] <mayankmadan>	 so?
[08:57:14] <mayankmadan>	 :)
[08:57:20] <yurik>	 when you use wiki, it sets all sorts of cookies
[08:57:40] <yurik>	 just use it, makes my life easier :)
[08:57:56] <yurik>	 either that, or delete all cookies related to wikipedia
[08:58:11] <mayankmadan>	 privacy mode is better :)
[08:58:20] <yurik>	 exactly
[09:20:56] <mayankmadan>	 yurik, done
[09:21:02] <mayankmadan>	 uploaded the patch
[09:21:23] <mayankmadan>	 but changing the tests wont work if someone changes the order of given and then
[09:21:38] <mayankmadan>	 in custom_headers_steps.rb
[09:22:01] <yurik>	 has it uploaded to gerrit?
[09:22:14] <yurik>	 there it is
[09:22:16] <yurik>	 sec
[09:24:15] <yurik>	 mayankmadan, sorry for being thick, i'm new to selenium - how do i verify that passing "X-CS=-TEST-ALL" actually shows a banner?
[09:25:42] <yurik>	 also, i'm not exactly sure - why does the header value is repeated on every line of the test?
[09:27:38] <yurik>	 lastly, this doesn't look very convinient - seems like I would have to repeat X-CS value in 6 different spots in two files
[09:27:48] <yurik>	 wouldn't it be better to have it just at one place?
[09:41:37] <mayankmadan>	 yurik, i saw your comments
[09:41:50] <mayankmadan>	 i dont think it should matter
[09:42:30] <mayankmadan>	 the interpreter doesnt care what language we have used but if you say, i will change it the way you wish to
[09:42:31] <mayankmadan>	 yurik, ^
[09:43:14] <yurik>	 mayankmadan, the language is actually important, because when i wrote "main page from english wikipedia", those are actually three parameters
[09:43:22] <yurik>	 main page is the title of the requset
[09:43:41] <yurik>	 english (could be "en" instead to make things easier) - is the language of the siet
[09:43:43] <yurik>	 site
[09:43:46] <yurik>	 and so is the wikipedia
[09:44:01] <yurik>	 this way we can reuse the same test to check all the other projects and languages
[09:44:08] <yurik>	 mayankmadan, ^
[09:44:24] <yurik>	 and the same with the X-CS -  its a parameter
[09:44:31] <yurik>	 not part of the request string
[09:44:36] <mayankmadan>	 yurik, so you want only 1 or 2 scenario?
[09:44:37] <yurik>	 i mean - not part of the test name
[09:44:42] <mayankmadan>	 for all the tests?
[09:44:58] <yurik>	 i want one scenario but 2 tests that use it
[09:45:08] <yurik>	 unless i don't understand something about selenium
[09:45:34] <yurik>	 otherwise what it looks like is that you are hardcoding X-CS for each scenario in each test
[09:45:44] <mayankmadan>	 yurik, yes
[09:45:49] <mayankmadan>	 isnt that what is required?
[09:47:00] <mayankmadan>	 yurik, ^
[09:47:07] <yurik>	 mayankmadan, sorry, need to clarify vocabulary:  the step_definiton file should have just one "given -> then"  thing
[09:47:21] <yurik>	 with the X-CS being a parameter for it
[09:47:31] <yurik>	 as well as the main page, en, and wikipedia
[09:47:38] <yurik>	 so total of 4 params that i can think of
[09:47:47] <mayankmadan>	 yurik, ok
[09:48:04] <mayankmadan>	 yurik, so you want these to be supplied at the time you run the test
[09:48:35] <yurik>	 the individual tests ("scenarios" in selenium) should call that test
[09:48:50] <yurik>	 with different values for those 4 parameters
[09:49:29] <mayankmadan>	 yurik, i get it now
[09:49:53] <yurik>	 so the scenario file would have two entries (many more later):    test Main Page for en wikipedia with X-CS = ... - expect header "blah"
[09:50:38] <mayankmadan>	 i think the website's url can be hard coded
[09:50:48] <mayankmadan>	 its going to remain the same for all the tests
[09:51:14] <yurik>	 mayankmadan, it would be better not to - because "wikipedia" could also be "wikivoyage" or "wikiquotes"
[09:51:23] <yurik>	 and en could also be another language
[09:51:29] <mayankmadan>	 okay
[09:51:39] <yurik>	 and "main page" could also be some other page like a special one we have
[09:51:56] <mayankmadan>	 ok
[09:51:59] <yurik>	 that's why the URL should be created on the fly by the 'feature'
[09:53:21] <mayankmadan>	 it will be better if i define a function in the custom_headers_step.rb with all the parameters for creating a browser instance and with appropriate headers and then call it within the other tests
[09:53:32] <mayankmadan>	 yurik, ^ i think it will be enough
[09:53:41] <yurik>	 sure
[10:23:55] <mayankmadan>	 yurik, it will have to be a class instead of a function
[10:55:19] <mayankmadan>	 yurik, it will have to be a class instead of a function
[10:55:22] <mayankmadan>	 sorry
[13:32:56] <grrrit-wm>	 (03PS1) 10Shirayuki: i18n: add colon before page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101648 
[14:14:50] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] i18n: add colon before page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101648 (owner: 10Shirayuki)
[14:15:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: add colon before page title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101648 (owner: 10Shirayuki)
[15:12:15] <grrrit-wm>	 (03PS1) 10IAlex: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101657 
[15:34:56] <grrrit-wm>	 (03PS1) 10Shirayuki: i18n: replace single quote by double [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101659 
[16:14:31] <grrrit-wm>	 (03PS4) 10Amire80: i18n: RTL beta icon for nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 
[16:14:54] <grrrit-wm>	 (03CR) 10Amire80: [C: 04-1] "Rebased, the SVG is still not great." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 (owner: 10Amire80)
[16:40:56] <grrrit-wm>	 (03PS5) 10Amire80: i18n: RTL beta icon for nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 
[16:42:07] <grrrit-wm>	 (03CR) 10Amire80: "Saved the new file as "Plain SVG" in Inkscape and the size is smaller now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 (owner: 10Amire80)
[17:29:57] <multichill>	 yuvipanda: Ping! Did you see the json ticket?
[18:45:57] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] i18n: replace single quote by double [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101659 (owner: 10Shirayuki)
[18:46:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: replace single quote by double [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101659 (owner: 10Shirayuki)