[02:21:16] (03PS2) 10Yuvipanda: Increase line height for the page title [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101612 [02:21:17] (03PS2) 10Yuvipanda: Add minimal styling for tables and thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101616 [02:21:18] (03PS1) 10Yuvipanda: Perform display related DOM transforms in JS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101802 [02:46:55] (03PS2) 10Yuvipanda: Perform display related DOM transforms in JS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101802 [02:46:56] (03PS3) 10Yuvipanda: Add minimal styling for tables and thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101616 [04:21:55] (03PS1) 10Yurik: Minor formatting fixes [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101804 [04:23:50] (03PS1) 10Yurik: Minor spacing fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101805 [08:02:35] (03PS1) 10Yurik: Format proxy names, remove examples that result in HTTP 500 error [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101819 [08:22:53] hi yurik [08:23:02] hi mayankmadan [08:24:42] i dont understand your comment on gerrit [08:26:58] yurik, do you want to extract information from the given statement? [08:27:11] mayankmadan, sorry, context? [08:27:19] link pls :) [08:27:34] oh, the headers stuff? [08:27:41] sorry, too many contexts at the same time [08:27:43] yurik, https://gerrit.wikimedia.org/r/#/c/101485/ [08:28:01] mayankmadan, do you know regex ? [08:29:31] to answer your question -- correct - i would like to extract needed parameters directly from the statement, instead of hardcoding each case in two places - one for each file [08:33:07] mayankmadan, still there? [08:34:38] yep [08:49:48] mayankmadan,i'm about to head to bed, i think you pretty much figured out how to do it via headers, i guess i am just trying to make it into a nice test that others can copy/paste [08:50:12] i don't want it to be unfinished, because than bad coding practices start propogating [13:14:05] (03CR) 10Dr0ptp4kt: [C: 032] Minor formatting fixes [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101804 (owner: 10Yurik) [13:14:08] (03Merged) 10jenkins-bot: Minor formatting fixes [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101804 (owner: 10Yurik) [14:56:08] (03PS1) 10Ebrahim: i18n: Using localized message on overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101862 [15:22:40] hey brion [15:22:44] up early! [16:17:19] (03CR) 10Siebrand: [C: 031] "i18n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101862 (owner: 10Ebrahim) [16:51:06] (03CR) 10MaxSem: [C: 032] Minor spacing fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101805 (owner: 10Yurik) [16:51:55] (03Merged) 10jenkins-bot: Minor spacing fixes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101805 (owner: 10Yurik) [16:53:07] yurik, online? [17:00:01] (03CR) 10MaxSem: [C: 04-1] Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101657 (owner: 10IAlex) [17:12:00] (03CR) 10Dr0ptp4kt: [C: 032] Format proxy names, remove examples that result in HTTP 500 error [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101819 (owner: 10Yurik) [17:12:05] (03Merged) 10jenkins-bot: Format proxy names, remove examples that result in HTTP 500 error [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/101819 (owner: 10Yurik) [17:13:02] dr0ptp4kt, thx [17:13:11] yurik, sure thing [17:13:21] dr0ptp4kt, btw, i'm not very sure - why did you check in PS15?? [17:13:21] yurik, thanks for attending to it [17:13:52] yurik, i didn't see your patchset. i even did an owner:yurik to look for it. too early in the morning...or a cached page [17:15:30] yurik, you got anything in code review you want me to look at this morning? in about 45 minutes i'll be unavailable for about 30-45 minutes. i'll be wrapping up at 4 pm pacific time today and probably until the 31st of december. [17:15:32] ok. btw, seems like the easiest way to revert a patchset is to check it out using the checkout URL gerrit suggests, and change comment message [17:16:48] dr0ptp4kt, not at this point [17:16:50] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/101485/ [17:16:53] take a look at it [17:16:58] no need to +2 :) [17:17:15] we will switch to this framework fairly soon for testing [17:17:46] qa intern (after a lot of pushing from me and others) did this :) [17:17:56] dr0ptp4kt, ^ [17:19:27] yurik, good, glad to see the phantomjs webdriver is working smoothly. will take a spin through that in time [17:20:38] also, dr0ptp4kt, q question on email re 470 [17:20:51] yurik, you gonna help the intern with translation of the features in the monolithic phantomjs script plus https://www.mediawiki.org/wiki/Wikipedia_Zero/Test_cases ? lemme know if you need me on a hangout or anything for that. [17:21:44] dr0ptp4kt, awesome, i didn't know we had that [17:22:24] yurik, re 470, it seems they launched their campaign with zerodot via om only. i don't think we need to madly rush to make the change as they're zerodot only, hence the question to mr. bergsma and mr. liambiotis [17:22:46] their press release says that it requires opera mini [17:22:55] dr0ptp4kt, right, but that patch is incorrectly setting it up [17:23:06] yours? [17:23:11] yes [17:23:13] take a look [17:23:22] isn't that the fallthrough case? i'll look again. hang on. [17:26:24] brion: hey? [17:27:57] yurik, oh i see, it's a an "||" or. i agree it's inaccurate given my understanding that they marketed with om only. i'll reply to the email with my understanding. [17:29:26] yurik, want me to remove the first OR condition for that carrier, or you got it? [17:29:38] heading into the offivce [17:29:49] brion: ok! [17:29:53] officevce! :D [17:33:34] hi dr0ptp4kt [17:33:48] hi there mayankmadan! [17:33:57] hey awjr [17:34:25] dr0ptp4kt, are you a mentor in GCI ? [17:34:31] hiya MaxSem [17:34:32] mayankmadan, yurik just pointed out your phantomjs webdriver poc. looking forward to your work on this stuff. sweet! [17:34:43] stuck in the airport? [17:34:46] how's it going? [17:34:46] yeah [17:34:47] dr0ptp4kt, great :) [17:34:54] although not for long - boarding soon! [17:34:56] mayankmadan, i'm not operating in mentorship mode, but i'm here to support yurik and you when you need me [17:35:06] thats great [17:36:46] i hope my bingle test finishes before i have to get on the plane :-/ [17:36:49] mayankmadan, feel free to cooprate with yurik in case you need me to explain the monolithic monster of a "testing script" i dropped into the ZeroRatedMobileAccess script. i really should have used casperjs or just tried to wire up that phantomjs webdriver like you did ;D [17:37:38] dr0ptp4kt, just so i understand, the zero_automated_tests.js you have in the phantom dir - does that implement all the testing we need, does it cover all test cases in the https://www.mediawiki.org/wiki/Wikipedia_Zero/Test_cases ? [17:38:05] or it manually implements that? [17:38:11] mayankmadan, ^ [17:38:22] yurik (cc mayankmadan), it covers a lot of them, but i don't know if it covers all. plus the business logic has changed a little bit over time [17:38:56] awjr: enjoy the ride [17:39:04] :D [17:39:07] thanks yuvipanda [17:39:17] hopefully this time the plane will actually pressurize :p [17:39:20] * dr0ptp4kt shudders at downloading and installing binaries at the command line (rvm sez "just trust me"!) [17:39:36] * dr0ptp4kt presses red button [17:39:50] mayankmadan, i think i have access to GSOC system, not sure if that's the same, but i never played around at creating issues there.... Who usually create them for you? [17:40:34] yurik, zeljko, Jeff Hall, Andre Klapper is admin [17:41:34] mayankmadan, i think it would be better if they add some issues around zero testing [17:42:29] mayankmadan, have a look at the zero repository under maintenance/phantomjs dir - there is a huge script and some readme stuff... its scary :) [17:42:32] yurik, qgil and I are happy to create GCI tasks in there for you, but somebody needs to be a mentor :) [17:43:02] andre__, its hard not to be a mentor when your own repo is being changed :) [17:43:15] add me as one :) [17:43:44] btw, andre__ , one other task that we badly need is cleaning up all the docs for "how to become a hacker" [17:44:07] someone needs to go through all the tutorials and consolidate them on using vagrant [17:46:01] yurik, i am missing something. i seem to be a bit lost :) [17:46:37] mayankmadan, welcome to my world. Which part are you lost about? [17:46:58] yurik, everything :) [17:47:22] can you explain me from the beginning if you are not busy? [17:47:57] andre__, i added some links to https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker about vagrant, but someone with access to both mac & windows should go through all the stuff we have scattered around and consolidate it... this is mostly a tech writing task i guess [17:49:52] (03CR) 10IAlex: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101657 (owner: 10IAlex) [17:50:11] mayankmadan, might be a bit hard right now - have to run somewhere, but possibly in a few hours. Basically zero project needs to have good test coverage and reporting. dr0ptp4kt has implemented an awesome phantomjs-based testing, but he is doing everything by hand. We should use proper testing frameworks just like it was described in https://www.mediawiki.org/wiki/Wikipedia_Zero/Test_cases [17:50:43] yruik, mayankmadan: gherkin syntax rulez :) [17:51:08] dr0ptp4kt, where can i start? [17:51:42] mayankmadan, to see his code, get the zero repository https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/ZeroRatedMobileAccess [17:51:46] yurik: so if you have an actionable task, see https://www.mediawiki.org/wiki/Google_Code-in#Mentors.27_corner [17:52:42] yurik, andre__ thx for piping in on this. mayankmadan, best if those guys help guide this along and pull me in as needed. i'm going to be knee deep in app-oriented stuff and chasing after yurik's mad awesome patchsets for code review. [17:53:49] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/98767/ [17:53:53] go for it [17:54:01] just don't +2 it yet :) [17:54:06] we will base zero on it [17:54:08] yurik: dr0ptp4kt the QA mail list would be a great place to talk about what you're doing with PhantomJS: https://lists.wikimedia.org/mailman/listinfo/qa [17:55:21] yurik: dr0ptp4kt we're making some PhantomJS tests for ULS and other projects also [17:57:47] chrismcmahon, sounds good. may be a good way of saying, "here's why you use phantomjs, and here's why you then use cucumber with the phantomjs webdriver" :) [17:58:49] chrismcmahon, i gotta run but will add that email-to-send to my task list [17:59:31] (03CR) 10Jdlrobson: [C: 032] i18n: Using localized message on overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101862 (owner: 10Ebrahim) [18:00:22] (03Merged) 10jenkins-bot: i18n: Using localized message on overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101862 (owner: 10Ebrahim) [18:01:46] yurik, how about implementing those tests in python? [18:02:00] or do you want them in ruby? [18:02:15] mayankmadan, i don't care about the backend side of things - could be javascript too [18:02:25] if you want to reuse some of the existing code [18:02:39] i am more concerned with flexibility [18:02:45] ability to clearly state what you are testing [18:02:54] just like cucumber has [18:05:19] yurik, so ill try to implement cucumber with python, is that ok with you? [18:06:16] mayankmadan, sure, but do you think it wouldn't it be easier to do it in javascript? But up to you, python is fine [18:06:38] i guess clicking buttons and checking result screen is the same in all lang [18:06:56] check what adam wrote in our repository (did you git clone it?) [18:07:27] yurik, it would be easier in javascript [18:07:39] yes i did clone it [18:08:05] mayankmadan: two key principales: KISS & DRY [18:08:55] where did he wrote what? [18:09:16] and what is KISS & DRY [18:12:46] rmoen: glass is here boss :) [18:17:17] how is it yuvipanda? [18:18:52] awjr: pretty great! [18:19:02] awjr: gave me a major headache if I used it without my glasses [18:19:10] awjr: and also was completely unusable anyway - couldn't read the text! [18:19:57] heh, tfinc just saikd 'commuter or trafficker' instead of 'traveller' [18:20:59] ha [18:22:05] jdlrobson, im here [18:22:14] mayankmadan: have you installed MobileFrontend? [18:22:24] i have cloned the repository [18:22:30] jdlrobson, ^ [18:24:30] mayankmadan: can you access the mobile site on your local machine? [18:24:56] jdlrobson, on local mediawiki server? [18:25:39] mhurd: around? [18:25:47] mayankmadan basically can you view a page that looks like a version of https://en.m.wikipedia.org/wiki/Main_Page [18:25:47] YuviPanda: ya! [18:26:11] mhurd: so, re: the cars for next iteration. In my head, they seem to be crystallizing as: 1. Visual ToC 2. Gallery view [18:26:14] mhurd: is that accurate? [18:26:17] jdlrobson, on local mediawiki server or wikipedia.org? [18:26:24] your own server mayankmadan [18:26:30] ok [18:26:31] you need to be able to make changes to the code [18:26:40] mayankmadan: you'll find the JavaScript in javascripts/modules/editor/editor.js [18:26:43] specifically the line // FIXME: Disable on IE < 10 for time being [18:26:58] jdlrobson, how can i apply an extension in wikimedia? [18:27:02] *mediawiki [18:27:17] YuviPanda: iirc that sounds right [18:27:21] mhurd: sweet. [18:27:25] mayankmadan: you might want to read this first https://www.mediawiki.org/wiki/Extension:MobileFrontend [18:29:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] "sweet docs!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101463 (owner: 10Dr0ptp4kt) [18:29:26] (03CR) 10Jdlrobson: [C: 032] "Thanks a lot Amir! You're a star :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 (owner: 10Amire80) [18:29:36] enjoying life as a cyborg so far YuviPanda ? [18:29:53] brion: yes :D [18:29:57] brion: haven't whipped out the NDK yet [18:30:01] heh [18:30:15] (03CR) 10Jdlrobson: [C: 032] Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 (owner: 10JGonera) [18:30:23] it's pretty straightforward, extra package installs from the android sdk manager [18:30:30] the stub app i made builds in intellij [18:30:36] (03Merged) 10jenkins-bot: i18n: RTL beta icon for nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98159 (owner: 10Amire80) [18:31:16] brion: mmmmm! [18:31:36] kaity: can you make sure a design gets attached to this card please? thanks! https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1512 [18:31:36] doesn't do much yet, i haven't gotten around to making it do awesome things yet ;) [18:31:39] (03Merged) 10jenkins-bot: Story 1483: Make overlay headers fixed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100515 (owner: 10JGonera) [18:31:42] brion: :D [18:31:45] brion: does webkit run on it? [18:31:53] yep! but the web browser SUCKS [18:32:19] it's just a weird interface if you have to do anything complicated like [18:32:24] click something [18:32:28] brion: hehe :D [18:32:36] brion: yeah, I'm thinking more of wikidata than of wikipedia [18:32:44] oh definitely [18:33:04] though i am tempted to have a 'hitchhikers guide to the galaxy' mode that reads out a wikipedia article with text-to-speech [18:33:12] while animating the images and drawing the text in a green font [18:33:18] brion: haha! :D [18:33:29] jdlrobson, how do i enable mobile view? [18:33:39] brion: Voice Recognizer is werid. I tried 'Sucheta' and it gave me 'Sveta' [18:33:59] brion: also, lotsa patches :P [18:34:00] (03CR) 10Jdlrobson: [C: 04-1] Allow to force stable with useformat=stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101242 (owner: 10MaxSem) [18:34:03] heh [18:34:36] mayankmadan: you can either spoof the user agent to be a mobile browser or append useformat=mobile on the URL [18:35:23] jdlrobson, ok that works [18:36:26] brion: all minor tho [18:37:07] mhurd: brion yuvipanda : also we have pass #2 at prioritization if kenanwang is ready to go [18:37:13] brion: yup! [18:37:16] whee [18:37:21] tfinc: in about 20mins afaik [18:37:34] tfinc: ya [18:37:48] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle page state change events to keep page action state in sync [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101467 (owner: 10Yuvipanda) [18:37:58] mhurd: get the designers in too, ok? :) [18:38:24] kaity: ^ [18:39:13] (03CR) 10Brion VIBBER: [C: 032 V: 032] Hide the drawer when the searchbar is clicked [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101491 (owner: 10Yuvipanda) [18:39:52] (03CR) 10Brion VIBBER: [C: 04-1] "Wrong message string, says 'history'?" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101606 (owner: 10Yuvipanda) [18:40:20] brion: grr. fixing [18:40:28] brion: go on to the next ones tho :) [18:40:42] \o/ [18:41:24] brion: updated [18:41:31] (03PS2) 10Yuvipanda: Setup appropriate strings for clearing Saved Pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101606 [18:42:18] jdlrobson: yes sir [18:42:19] brion: did all rebases [18:42:38] (03PS2) 10Yuvipanda: Reduce gap between search spinner & overflow menu button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101607 [18:42:39] (03PS2) 10Yuvipanda: Minor RTL fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101611 [18:42:40] (03PS3) 10Yuvipanda: Increase line height for the page title [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101612 [18:42:41] (03PS4) 10Yuvipanda: Add minimal styling for tables and thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101616 [18:42:42] (03PS3) 10Yuvipanda: Perform display related DOM transforms in JS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101802 [18:42:44] (03CR) 10Brion VIBBER: [C: 032 V: 032] Setup appropriate strings for clearing Saved Pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101606 (owner: 10Yuvipanda) [18:42:55] odd [18:42:59] it won't let me merge https://gerrit.wikimedia.org/r/#/c/101606/ [18:43:17] jdlrobson, changing useragent in chrome is not working\ [18:43:30] (03PS3) 10Yuvipanda: Setup appropriate strings for clearing Saved Pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101606 [18:43:41] (03CR) 10Brion VIBBER: [C: 032 V: 032] Reduce gap between search spinner & overflow menu button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101607 (owner: 10Yuvipanda) [18:43:45] (03CR) 10Yuvipanda: [C: 032 V: 032] "Brion already did it!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101606 (owner: 10Yuvipanda) [18:43:52] mayankmadan: what exactly is not working? [18:43:55] (03PS3) 10Yuvipanda: Reduce gap between search spinner & overflow menu button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101607 [18:43:59] brion: need to hit rebase [18:44:00] on 'em lal [18:44:06] ah funky [18:44:08] (03CR) 10Yuvipanda: [C: 032 V: 032] Reduce gap between search spinner & overflow menu button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101607 (owner: 10Yuvipanda) [18:44:22] brion: gerrit being funky? I'm so surprised :P [18:44:26] jdlrobson, i change the user agent to ie9 but it doesnt redraw the page in mobile version [18:44:27] heh [18:45:14] mayankmadan try user agent: Mozilla/5.0 (compatible; MSIE 9.0; Windows Phone OS 7.5 [18:45:56] (03PS3) 10Brion VIBBER: Minor RTL fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101611 (owner: 10Yuvipanda) [18:45:58] mayankmadan: append useformat=mobile to URL if you find you are still getting desktop [18:48:28] jdlrobson, i can edit page when i append useformat=mobile in my browser [18:49:53] mayankmadan: are you sure you are spoofing the user agent? if you can edit then something is going wrong there [18:50:01] brion: I'm going to keep the DOM transforms in JS, so we can put them in mobileapp later and share them across apps [18:50:01] (03CR) 10Brion VIBBER: [C: 032 V: 032] Minor RTL fixes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101611 (owner: 10Yuvipanda) [18:50:12] ok [18:50:30] jdlrobson, yeah, i cant edit when i spoof the user agent [18:50:39] (03PS4) 10Brion VIBBER: Increase line height for the page title [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101612 (owner: 10Yuvipanda) [18:50:51] mayankmadan: did you change the JavaScript? [18:50:55] jdlrobson, i have claimed this task http://www.google-melange.com/gci/task/view/google/gci2013/5770916835360768 [18:50:57] not yet [18:51:22] When I click edit mayankmadan I get the message "Mobile editing is not currently available on your browser. Please try a different browser." [18:51:29] so something is going wrong with the way you are spoofing the user agent [18:51:33] (03CR) 10Brion VIBBER: [C: 032 V: 032] Increase line height for the page title [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101612 (owner: 10Yuvipanda) [18:51:38] Are you sure you hit enable and selected other from the dropdown? [18:51:43] (03PS5) 10Brion VIBBER: Add minimal styling for tables and thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101616 (owner: 10Yuvipanda) [18:51:51] jdlrobson, me too right now [18:52:30] mayankmadan: the other thing you will need to do is append mobileaction=beta to the query string [18:52:37] this will force 'beta mode' and expose the new style editor [18:52:44] which is the one we want to make work in ie9 [18:53:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add minimal styling for tables and thumbnails [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101616 (owner: 10Yuvipanda) [18:53:18] (03PS4) 10Brion VIBBER: Perform display related DOM transforms in JS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/101802 (owner: 10Yuvipanda) [18:54:14] querySelector \o/ [18:54:17] modern JS yummmmm [18:55:12] if info box were like, a separate tab or something that might be neat [18:55:26] have to go over those crazy ux ideas some more :D [18:56:21] jdlrobson, if i just comment out or delete the blacklisted variable, editing would be enabled in ie [18:56:46] cause its checking if it is blacklisted in isEditingSupported variable [18:56:50] and it worked too [18:57:01] is there anything else that needs to be done? [18:57:04] jdlrobson, ^ [18:57:15] brion: mhurd ugh, the water in the overhead tank just overflowed. I'll be a couple of minutes late to the meeting. Should be there soonn [18:57:26] YuviPanda: doh! [18:57:29] oy [18:57:34] mayankmadan: yes you need to test in in Internet Explorer 9 [18:57:41] it was blacklisted for a reason - i forget why but it's broken :) [18:58:07] jdlrobson, so what should i do? should it remain blacklisted or what? [18:58:18] which ie does a windows phone 8 have? [18:58:31] cause i have a windows phone 8 on which i can test it on [18:58:32] mayankmadan: it's blacklisted as the editor is broken on this browser. You need to test it in Internet Explorer 9 [18:58:59] which ie does a windows phone 8 have? [18:58:59] cause i have a windows phone 8 on which i can test it on [18:59:15] mayankmadan: you should check the user agent - if it is IE9 based then that Windows Phone 8 should be fine but I fear Windows Phone 8 uses IE10 [18:59:15] jdlrobson, ^ [18:59:18] which hew do support [18:59:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] Core data concurrency refactor. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/101436 (owner: 10Mhurd) [18:59:52] jdlrobson, hew? [19:01:45] which _we_ do support [19:08:59] jdlrobson, how do i test it in ie9? [19:11:50] mayankmadan: if you haven't got the phone this is probably going to be a difficult task for you and not the best one to work on - are you mostly a PHP developer or JavaScript? [19:12:27] jdlrobson, will a windows phone 8 help? [19:12:35] mayankmadan: nope - need 7 [19:13:28] Just curious: is there an SDK to develop/test Windows Phone 7 / IE9 on mobile? [19:14:30] qgil: there may be somewhere but it might be limited to Windows machines - we have a real device in the office for this purpose [19:19:30] (03PS7) 10Jdlrobson: Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 [19:20:24] anyway mayankmadan, you see the problem: if you are going to work on a task based on mobile editing in IE9, you will need a reliable environment to develop and test. [19:20:49] yeah. will unclaim the task now [19:21:18] mayankmadan, makes sense. We hope you find other Wikimedia tasks to work on. Thank you for your interest in contributing to Wikimedia. [19:23:41] mayankmadan: :/ sorry that didn't work out [19:23:51] (03CR) 10MaxSem: [C: 04-1] Story 1405: Update messages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [19:23:52] no problem [19:23:58] MaxSem: :( [19:24:15] Don't worry jdlrobson, you're almost there:) [19:25:33] jdlrobson: updated with design https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1512 [19:25:33] MaxSem: could you fix up the regex problem i'm currently looking into the state of visual editor? In terms of wgMFIsUserBlocked vs wgMFUserIsBlocked' I tend to prefer prefixing with 'is' to show it's a question and hint it's a boolean.. [19:25:39] thanks kaity ! [19:25:57] dr0ptp4kt: are you free to chat at some point today about the state of manifests? [19:26:17] jdlrobson, yeah, i'll set something up for the later afternoon. [19:26:21] wgBoolMWIsUserBlocked:P [19:27:29] MaxSem: http://martinfowler.com/bliki/TwoHardThings.html [19:28:03] did jgonera say when he was working today? [19:43:19] dr0ptp4kt, deployed some stuff, pls rerun [19:44:32] yurik, kicked off [19:47:20] yurik, made small change to the vcl. https://gerrit.wikimedia.org/r/#/c/88261/17..18/templates/varnish/zero.inc.vcl.erb .......... cool? [19:48:58] dr0ptp4kt, yep, missed it, thx [19:49:10] yurik, sure thing. [19:49:37] dr0ptp4kt, although those regexes are really bad imho - we could have used the "?" [19:49:56] makes it much cleaner [19:50:07] only might be a bit slower to run... not sure [19:50:17] don't remember how backtracking works in regex [19:50:44] violetto: around? [19:54:37] yurik, beware greedy matches and backtracking ;) i think what you did in there - ^([a-zA-Z0-9-]+\.)?zero\. - should be quick. as it's a zero-or-one match i think that should still be pretty quick because it by definition shouldn't seek to the end of the string. [20:15:51] jdlrobson: i saw in the backscroll you were wondering about when juliusz was working today [20:15:51] i don't think he is - he said his flight to poland was this morning [20:16:11] "My flight is on December 16th in the morning and I'm coming back on January 9th in the afternoon. I will be working remotely during that time and on a plane during both flights." [20:16:26] i appreciate that he clarified that he'd be on a plane during both flights :p [20:26:33] mhurd: do you know who is the new person? the one who was talking about recaptcha? [20:45:14] yuvipanda: he's new designer [20:45:18] ah [20:45:44] mhurd: also, you *do* drop straight from the top level 'this is what we are doing' down to 'this is the class name' very quickly :P sometimes disorienting [20:51:05] yuvipanda: fair enough :) [20:59:35] MaxSem: we'll probably have site specific styles there, so I don't think i18n issues should be *too* much of a problem [20:59:54] ALSO, YELLING [21:01:40] i18n issues are never a problem, yuvipanda. [21:01:59] MaxSem: I AGREE [21:02:19] MaxSem: I AM NOT SURE IF SMALLER TEXT WITH SUBDUED GAYS IS YELLING [21:02:20] err [21:02:22] GREYS [21:02:27] aharoni: heh :) [21:03:14] aharoni: I should set it up on twn at some point [21:03:29] From today, we call you Yuvaraj "Smaller Text With Subdued Gays" Pandian. [21:04:32] aharoni: heh :D [21:06:39] kaldari: hey? [21:07:42] kaldari: hey? [21:07:49] howdy [21:08:14] stepping out for lunch [21:08:17] YuviPanda: I put some of the research on infoboxes here: https://www.mediawiki.org/wiki/Mobile_web_projects/Infoboxes [21:08:30] kaldari: ah, nice! [21:08:48] although that's more about collapsing them by default or not [21:09:35] kaldari: right. I personally also think we shouldn't collapse, but moving it below the lead seems okay to me. Since on the desktop you usually read the first sentence or so and then read the infobox [21:09:48] YuviPanda: I know Jon has done more research on them as well [21:10:01] YuviPanda: true [21:10:35] kaldari: and re: restyling. I can get away with some JS manipulation too, I think - rather than just CSS. And I can also be selective about it - even if all I do is mimic MF for all wikis but have restyling for most of enwiki's infoboxes, I think that's a net positive [21:12:17] Yeah, like I said on that page, there are some styles that are worth changing and others that are problematic to mess with. What I would really love to see is some mobile-friendly clean-up of the actual infobox module on-wiki, especially since it is shared by lots of wikis now. [21:13:03] The less we have to override, the less fragile our hacks will be (and the more cross-wiki friendly) [21:13:11] kaldari: yup! I was thinking of that too [21:13:30] kaldari: for example, in some cases the subheading has inline styling set on the tr and in some cases the same styling but on the th. [21:13:34] those can be fixed by template magic [21:14:50] kaldari: think you can mail this (+ whatever jdlrobson has) to mobile-tech? [21:14:58] sure [21:18:22] kaldari: sweet [21:21:02] jdlrobson: Do you have any research on infoboxes that you would like to add to my email to mobile-tech? [21:29:40] (03PS2) 10JGonera: Fix various annoyances in new search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101466 [21:30:03] MaxSem, why abandoned? :) [21:30:16] yurik, not worth the mess:) [21:30:22] hehe [21:31:58] MaxSem, https://gerrit.wikimedia.org/r/#/c/98767/ [21:32:29] the ultimate in wiki configuration :) [21:32:38] rmoen: VisualEditor now depends on universal language selector.. that's not good [21:33:34] will take a look [21:35:02] jdlrobson, they should all depend on https://gerrit.wikimedia.org/r/#/c/98767/ ;) [21:35:12] * yurik is shamelessly selfpromoting [21:36:11] wasn't there some conversation a while ago to start using some nice dependency framework for wiki...? [21:39:42] (03CR) 10JGonera: Fix various annoyances in new search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101466 (owner: 10JGonera) [21:49:49] (03PS1) 10Hoo man: Enable keyboard section toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 [21:51:01] jdlrobson: ^ [21:51:34] jdlrobson: I've talked to various people and we agreed that this is the basic keyboard navigation that is needed [21:54:05] (03CR) 10jenkins-bot: [V: 04-1] Enable keyboard section toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [21:55:45] (03PS2) 10Hoo man: Enable keyboard section toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 [21:56:05] brion: heading to sleep now. [21:56:09] ok [21:56:26] dream of Glass apps ;) [21:56:35] brion, forgot to seek your comments :) https://gerrit.wikimedia.org/r/#/c/98767/ [21:56:41] brion: heh, will do! [21:56:48] brion: I can wear it over my prescription glasses. not bad [21:56:57] hehe nice [21:57:03] they barely fit over mine but it's a bit awkward [21:57:06] yurik: moment [21:57:18] whee [21:57:21] oh that sounds fun :D [21:59:26] fwiw, we're going to re-index search on beta labs, suggestions don't seem to be working correctly for either desktop or mobile, and it's causing a browser test failure [22:00:05] brion: also played for Google Music unlimited access :D [22:00:12] hah nice [22:00:14] brion: one of the very few services that'll let me use them without a goddamn VPN [22:00:31] ! [22:00:34] is it actually worldwide? [22:00:39] or did they forget to limit it ;) [22:00:50] brion: it isn't. they limit it to 'US accounts', rather than IP based limiting [22:00:58] brion: aaandd one of my accounts is somehow 'US based' [22:00:58] heh [22:01:01]