[00:00:42] you're skipping it in the most intrusive way [00:00:46] MaxSem: so are you saying this is a caching issue? [00:00:57] and caching too;) [00:01:06] MaxSem: forgive me it's a very very long function so if you could summarise [00:01:12] it's a horrible function [00:01:27] special pages aren't cached, so you're going to fry the cluster instantly [00:01:35] ok so that's more constructive. [00:01:59] I thought it's for FF app when you asked, otherwise I would've slapped you sooner: [00:02:05] :P [00:02:07] MaxSem: so what stops special pages from caching? [00:02:20] that they're not intended to be cached [00:02:23] our main page code is becoming extremely unmanageable [00:02:29] so it would be good to abstract it some how [00:02:43] we have special casing in our JavaScript, skin and formatter code [00:02:45] as well as api code [00:03:07] and none of them is going away this way;) [00:03:35] API still needs to serve you special-cased main page HTML [00:03:45] a lot of our JavaScript doesn't run on special pages so this is why i went down the special page route [00:07:39] MaxSem: so if I created SkinMobileMain would you object less? [00:08:00] srsly, what are you trying to fix? [00:08:18] MaxSem: grep isMainPage :P [00:08:23] brb [00:08:33] if ( $this->getTitle()->isMainPage() ) { $this->slapCallToActions(); } [00:08:34] ? [01:23:35] (03CR) 10Kaldari: "I support the idea, but I'm not sure a mobile-specific Special Page is really the right solution to the problem. The design team has throw" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 (owner: 10Jdlrobson) [01:25:00] jdlrobson, MaxSem: added my thoughts to the Main Page Special Page, although I'm not sure how useful they are :P [02:12:06] (03PS2) 10Jdlrobson: WIP Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 [02:13:09] (03CR) 10jenkins-bot: [V: 04-1] WIP Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 (owner: 10Jdlrobson) [02:15:39] (03PS3) 10Jdlrobson: WIP Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 [02:16:24] (03CR) 10jenkins-bot: [V: 04-1] WIP Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 (owner: 10Jdlrobson) [02:24:28] (03PS4) 10Jdlrobson: WIP Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 [02:25:40] MaxSem, why are you still awake? :) [02:25:59] why a reason is needed? [02:28:41] (03CR) 10Kaldari: Story 1405: Update messages (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [02:28:47] (03CR) 10Kaldari: [C: 04-1] Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [02:31:03] (03PS5) 10Jdlrobson: WIP Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 [02:33:57] (03PS9) 10Jdlrobson: Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 [02:34:01] (03CR) 10jenkins-bot: [V: 04-1] Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [02:34:49] (03PS10) 10Jdlrobson: Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 [02:35:52] (03CR) 10Kaldari: [C: 031] Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [03:52:40] (03PS1) 10Yurik: Startup message fix per MaxSem [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/102066 [03:52:49] (03PS1) 10Yurik: Startup message fix per MaxSem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102067 [06:55:51] (03CR) 10JGonera: [C: 032] Hygiene: Introduce isAlphaGroupMember [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99800 (owner: 10Jdlrobson) [06:56:31] (03Merged) 10jenkins-bot: Hygiene: Introduce isAlphaGroupMember [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99800 (owner: 10Jdlrobson) [06:59:09] (03CR) 10JGonera: [C: 032] Enable status bar for standalone apps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101243 (owner: 10Jdlrobson) [06:59:45] (03Merged) 10jenkins-bot: Enable status bar for standalone apps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101243 (owner: 10Jdlrobson) [09:15:06] 01[13WikipediaMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/6tvtpg [09:15:06] 13WikipediaMobile/06master 142f4873c 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [11:42:12] (03PS1) 10Yuvipanda: Kill some noisy Log messages that are no longer useful [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102113 [15:54:03] (03PS1) 10Yuvipanda: Enable webview debugging on Kitkat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102160 [16:32:30] (03CR) 10MaxSem: [C: 032] Startup message fix per MaxSem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102067 (owner: 10Yurik) [16:32:56] (03CR) 10MaxSem: [C: 032] Startup message fix per MaxSem [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/102066 (owner: 10Yurik) [16:39:06] yurik, heh - those messages were written in Preillynglish, far from standard:) [16:49:10] (03PS2) 10MaxSem: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101657 (owner: 10IAlex) [16:51:17] (03CR) 10MaxSem: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101657 (owner: 10IAlex) [16:51:34] (03CR) 10MaxSem: [C: 032] Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101657 (owner: 10IAlex) [16:53:32] (03CR) 10jenkins-bot: [V: 04-1] Startup message fix per MaxSem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102067 (owner: 10Yurik) [16:54:04] (03CR) 10jenkins-bot: [V: 04-1] Startup message fix per MaxSem [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/102066 (owner: 10Yurik) [16:58:56] (03CR) 10MaxSem: [C: 032] Startup message fix per MaxSem [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/102066 (owner: 10Yurik) [16:59:19] (03CR) 10MaxSem: [C: 032] Startup message fix per MaxSem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102067 (owner: 10Yurik) [17:08:35] (03Merged) 10jenkins-bot: Remove useless $out parameter from SkinTemplate::prepareQuickTemplate() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101657 (owner: 10IAlex) [17:11:53] (03Merged) 10jenkins-bot: Startup message fix per MaxSem [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/102066 (owner: 10Yurik) [17:13:29] (03Merged) 10jenkins-bot: Startup message fix per MaxSem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102067 (owner: 10Yurik) [17:43:40] hey yuvipanda! [17:43:46] hey mhurd [17:44:35] hey do you have logging hooked up for saved pages accept criteria? was wondering what keys / schema to use... [17:45:00] mhurd: nope, not yet. Kenan said he'll setup a meeting at some point to figure out what to log [17:45:09] yuvipanda: ah. k [17:45:34] mhurd: also, I just found out yesterday that you are caching *everything*. [17:45:59] that makes me a little uncomfortable, since "there are two hard problems in computer science: Cache invalidation and naming things" :) [17:48:20] yuvipanda: it's no different from what the embedded web view's default cache was already doing (once i set a max capacity and prune old entries in excess of that capacity). degrades gracefully and re-requests if cached image not found. fairly common approach. [17:49:01] awjr_away: my account does not seem to have gone over to the new Mingle instance [17:49:20] yuvipanda: are there other gotcha's you can think of? [17:49:21] mhurd: does it respect ETag, If-Modified-Since, s-maxage and other HTTP caching paramters that we use? [17:49:46] mhurd: Caching is super simple. Cache *invalidation* is the problem. [17:50:20] yuvipanda: i was going to ask you about etag. how easy is it to get etag for a mw image? [17:50:30] I don't know :P [17:50:45] yuvipanda: but u know all the things! [17:50:48] I'm just going to let the webview do its thing, and only save locally to disk 'saved pages' [17:51:01] mhurd: caching is hard :) [17:51:20] mhurd: if you are caching images, for example - what will you do if the images change on the server? [17:51:25] yuvipanda: INVALIDATE ALL THE DATA! [17:51:38] mhurd: and even for normal pages - the main page changes every day [17:51:50] mhurd: not saying it's not possible, simply that it is a *lot* of work to get right. [17:51:59] and I'm going to completely stay away from it on Android :P [17:52:19] the underlying network library actually implements a disk based HTTP cache properly, and I'm just going to let it do its work [17:52:49] Saved Pages I'll do myself, but I personally think it is a useless feature - if you want to do a lot of offline stuff, you will have pocket installed. If you don't do a lot of offline stuff, saved pages is uesles [17:52:51] *useles [17:52:51] s [17:53:20] mhurd: anyway, just pointing out that cache invalidation is an issue you will have to figure out at some point :) [17:53:36] jdlrobson: sorry was out yesterday.. VE is only dependent on jquery.uls in experimental mode. [17:53:43] rmoen: no problemos [17:53:43] yuvipanda: there are *so* many other amazing things we'll be able to do if we have the data in a local, fairly normalized store though! :) [17:53:51] rmoen: but yeh i'd like us to sandbox the mobile code better.. [17:53:56] not sure what the solution is though [17:53:58] yuvipanda: true and good points [17:54:03] mhurd: there's also the problem of vandalism - if someone replaces the "Justin Bieber" article with "GAY GAY GAY GAY!", and that gets cached... [17:54:09] chrismcmahon: you likely need to reset your password [17:54:11] have you tried that yet? [17:54:12] maybe a test that forces mobile mode and checks it initialises? [17:54:13] jdlrobson: just don't turn on experimental mode? [17:54:16] mhurd: we can do *all* those things just as well by writing serverside PHP code :) [17:54:17] yuvipanda: lol [17:54:34] mhurd: plus it'll actually perform a lot better, since caching can be done agressively (with invalidation!) when you do things on the server [17:54:36] rmoen: experimental mode in mobile is the only place visual editor works.. [17:54:37] not so much on the client [17:54:52] jdlrobson: yeah but i'm talking about VE experimental mode [17:55:05] why does that effect mobile? :-) [17:55:13] mhurd: I bet we can do a *lot* more things in the server than we can in the client :D [17:55:22] if it's a boolean rmoen we should force it to false [17:55:25] mhurd: we just have a lot more resources, and raw data available in the server than we ever will on the client. [17:55:33] yuvipanda: except make it work w offline mode ;) [17:55:41] mhurd: indeed, hence 'saved pages' [17:56:06] rmoen: i also get Error: Unknown dependency: ext.wikimediaEvents.ve Error on mediawiki.org :( [17:56:09] is that experimental mode? [17:56:15] jdlrobson: It's a global $wgVisualEditorEnableExperimentalCode = false; [17:56:34] jdlrobson: I have fix, that has been merged for that [17:56:36] rmoen: so why is that enabled on to beta labs o_O [17:57:17] jdlrobson: WikimediaEvents was never targeted for mobile [17:58:06] yuvipanda, have you seen LoboWiki? [17:58:15] MaxSem: no? [17:58:28] yuvipanda: not sure it's such an "either-or" issue [17:58:30] MaxSem: ah, nice. checking it out now [17:58:52] I've seen a lot of comments from ppl who want to see our app like it [17:58:55] mhurd: simply saying you will run into cache invalidation issues. Just a headsup :) And that the android behavior will be different. [17:59:51] yuvipanda: fair enough. i had some positive feedback after presenting yesterday about how it [17:59:54] ... [17:59:56] oops [18:00:08] ... how it "just worked" [18:00:22] when airplane mode was on [18:00:35] mhurd: when was the last time your phone had Airplane mode on? [18:00:36] awjr: I'm getting msg "There is no registered user ", so no way to reset password [18:00:52] rmoen: sorry i'm getting confused.. so question one :is $wgVisualEditorEnableExperimentalCode = true on beta labs? [18:01:06] yuvipanda: every i travel - tmobile data is horrible outside sf :) [18:01:19] *shrug*. I just wanted to warn you, mhurd :) [18:01:21] jdlrobson: not sure, you'll need to check the betlabs config [18:01:23] that is all. [18:01:44] jdlrobson: I can check after my meeting [18:01:46] o_O [18:01:47] MaxSem: ah, yes. the reading queue. [18:01:48] chrismcmahon: ok one sec [18:01:55] i think mark is having similar problems [18:01:57] rmoen: but it sounds like that is the case if that code is trying to be loaded on beta labs? [18:02:03] MaxSem: it's actually rather useful, and I wanted us to implement *that* instead of Saved Pages. but that went nowhere. sigh. [18:02:09] yuvipanda: it's really good feedback. thank you [18:02:18] :) [18:02:21] jdlrobson: jquery.uls ? [18:02:28] rmoen: yes [18:02:35] mhurd: yw :) I'm also *not* caching everything outside of regular HTTP caching on Android :) [18:03:07] jdlrobson: That makes sense i guess. I guess we want to test Experimental features on betalabs [18:03:19] rmoen: i can't seem to find it in the config file :( [18:03:50] jdlrobson: :( [18:04:17] yuvipanda: i'm just intercepting at the point the data retrieved from the http transfer would be stuffled off to disk. whatever else it does with caching still happens [18:05:01] dr0ptp4kt: hi there - problems with google? [18:05:19] chrismcmahon: ah, you don't have an email address set on your mingle account [18:05:22] i'll add it [18:05:33] yurik: is google calendar working for you? [18:05:43] rmoen: this might fix the problem on beta labs: https://gerrit.wikimedia.org/r/102188 [18:05:49] although i can't' work out why it would be true [18:05:49] chrismcmahon: i just added your email address to your mingle account - try using the password reset link again [18:06:20] jdlrobson: just to be clear, we have been talking about two separate issues on betalabs [18:06:29] we are rmoen ? [18:06:31] jdlrobson: uls being enabled on one [18:06:40] jdlrobson: and the WikimediaEvents error on the other [18:06:50] yeh the uls one is the one that i want to get resolved [18:06:54] since you say you've fixed the latter [18:07:03] and the uls one is stopping Kenan from testing VisualEditor [18:07:15] jdlrobson: exactly what i mean by two sep issues [18:07:20] awjr: that did it, thanks [18:07:26] awesome chrismcmahon [18:07:27] mhurd: okay! Just make sure that HTTP caching primitives are respected, and there shouldn't be too many problems [18:07:31] dfoy, yep [18:07:38] rmoen: i still don't follow. rmoen: jdlrobson: uls being enabled on one < how do we fix this? [18:07:38] chrismcmahon: do config changes for betalabs get auto-deployed there after merge? [18:07:48] dfoy, we're on [18:07:49] awjr: they should [18:07:54] jdlrobson: ^ [18:07:59] dfoy, try clearing cache and cookies [18:08:23] yuvipanda: oh ya, sorry if i was unclear about how it works - not touching any of that craziness :) [18:08:33] ok :) [18:08:35] yurik, dr0ptp4kt: my hangout says waiting for people to join - I can't get to calendar for the link [18:09:38] jdlrobson: I'm sorry you don't follow. I'm sure your patch will work nicely for disabling uls. [18:09:46] kaldari / MaxSem can you test and merge https://gerrit.wikimedia.org/r/#/c/99777/ before i get another rebasing problem [18:16:23] jdlrobson: will do [18:16:41] (03CR) 10Jdlrobson: "Anyway we can separate this from the dependency? I'm keen to get this merged today in some form..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 (owner: 10Robmoen) [18:17:47] brion: hey! [18:17:54] yo [18:19:12] brion: saved pages patch still not in - redoing it again. But a couple of unrelated patches are in [18:19:24] spiff [18:20:30] software update, brb [18:20:33] brion: ok [18:27:49] (03CR) 10Jdlrobson: [C: 032] Fix various annoyances in new search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101466 (owner: 10JGonera) [18:28:39] (03Merged) 10jenkins-bot: Fix various annoyances in new search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101466 (owner: 10JGonera) [18:29:41] awjr: fwiw that issue with Search on beta is also affecting Transclusion in VisualEditor as well as regular ol [18:29:52] tfinc: i'm in the hangout, and all I can hear are loud sirens. [18:30:06] awjr: regular ol' Search. [18:30:55] (03CR) 10MaxSem: [C: 032] "Works for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [18:32:20] (03Merged) 10jenkins-bot: Story 1405: Update messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [18:35:05] (03CR) 10Jdlrobson: [C: 04-1] "We have a meeting today to decide whether we want to enable this in current form." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101465 (owner: 10Jdlrobson) [18:37:29] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add 'Share page' functionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102014 (owner: 10Yuvipanda) [18:37:50] (03CR) 10Jdlrobson: "There is no need to remove" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/98034 (owner: 10Jdlrobson) [18:38:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] Kill some noisy Log messages that are no longer useful [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102113 (owner: 10Yuvipanda) [18:38:57] yuvipanda: looks like you dropped [18:39:11] tfinc: yeah, Hangout just logged me out [18:42:10] hey kenanwang [18:42:20] hey [18:42:37] kenanwang: i was told you were looking for a nice IRC client for iOS [18:42:55] kenanwang: have you checked out IRCCloud? Bouncer+Client, pretty awesome. [18:43:32] hmm [18:43:33] no [18:43:55] I'd love if I could get IRC to work well on my iphone [18:44:22] kenanwang: so IRCCloud uses a bouncer with its own protocol in the middle, so it works on the phone fine [18:44:35] the weird thing is that I don't have big issues getting it to work with my iPad mini but my iPhone colloquy doesn't let me connect over 3g [18:44:40] kenanwang: without the 'battery drain' and 'frequent disconnect' problems that traditional IRC clients have on mobile devices. [18:45:01] hmm, let me check if it uses a bouncer or not [18:45:06] yeah a bouncer would be great [18:45:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] "yay remote debugging!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102160 (owner: 10Yuvipanda) [18:45:13] colloquy has a bouncer but I haven't enabled it [18:45:24] I can't even get the client to connect is my problem there [18:45:38] but I'll definitely try IRC cloud Thanks! [18:46:01] kenanwang: I think Colloquoy still uses the IRC protocol, which would definitely have trouble with 3G [18:46:04] kenanwang: try out IRCCloud :) [18:46:14] ahhh ok [18:46:16] cool [18:46:49] kenanwang: :) [18:47:32] brion: I also made this gist (https://gist.github.com/yuvipanda/8007006) to try out the CSS mods on a desktop :) [18:47:39] brion: it's super crude, just has an article, but is good enough. [18:48:18] (03PS1) 10Zfilipin: Replacing single quotes with double quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102207 [18:51:03] mhurd: any updates for today? no worries if they come in the afternoon, i expect these things ;) [18:51:33] brion: actually should be done in a few minutes :) [18:51:39] \o/ awesome :D [18:53:55] brion: so i undertook a fairly seat-of-the-pants refactor yesterday. things were acruing too much in the web view controller. oh and the buttons you'll see for the saved pages toggle is only temporary - it's occupying the space of the search box's little round "x" icon - so once we get further designs on overall menu the little "x" will come back [18:54:10] ooooh :D [18:57:00] chrismcmalunch: that makes sense - thanks - i presume the search folks are working on it? [19:00:04] jdlrobson: Eventually we'll want the KSS-generated doc on https://doc.wikimedia.org [19:02:40] jdlrobson, are we having the a/b discussion now? [19:04:15] jgonera: hey you around? [19:04:22] kenanwang, yes [19:04:22] able to join the ab testing review meeting? [19:07:03] https://trello.com/c/5lcUPxGn/46-instrumentation-changes-for-mobile-tests [19:11:39] dr0ptp4kt: just wanted to clarify on #53 - should that be marked as in progress [19:11:41] ? [19:13:15] and #20 done? [19:15:58] #53 in progress, #20 done [19:16:00] awjr^ [19:16:05] thanks dr0ptp4kt_ [19:43:01] (03PS1) 10Kaldari: Avoid using router for Issues overlay when we are in Editing overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102286 [19:43:57] (03Abandoned) 10Jdlrobson: Story 1464: Push the A/B test to stable for left nav signups [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101465 (owner: 10Jdlrobson) [19:45:13] jdlrobson: I implemented https://gerrit.wikimedia.org/r/102286 as a quick fix until the Overlay Manager is implemented. Once that is merged, it should be easy to fix the 2 related bugs as well. [19:45:29] regarding the Issues overlay [19:49:48] (03PS1) 10Yuvipanda: Save page contents to internal storage when 'Save page' is hit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102289 [19:50:01] brion: ^ saves it. the encoding seems to be safe. [19:50:06] brion: now to figure out how to load it cleanly... [19:53:19] brion: you can use scripts/pullfiles to get the data out of the device [19:53:24] jdlrobson, I'll try to stick around for the multimedia meeting but I'm barely able to concentrate at this point [19:59:28] (03PS1) 10Mhurd: Added swipe to delete to saved pages items. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/102291 [20:02:43] brion: how are we looking for our release today? [20:02:51] can you work with kenan to find out why he's not getting builds? [20:03:04] tfinc: just waiting on the last-minute bits to come through for final review :D [20:04:04] brion: mhurd just sent you a bunch of stuffs [20:04:10] yep [20:06:27] (03PS1) 10Yuvipanda: Make documentation slightly more accurate [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102293 [20:07:54] mhurd: who is there beyond fabrice? [20:07:59] mhurd: I saw a knee and a hand... [20:08:06] marktraceur: ^ [20:08:24] yuvipanda: aarcos, Aaron Arcos, volunteering with us [20:08:30] marktraceur: aaha! right [20:13:24] (03CR) 10Siebrand: Story 1405: Update messages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99777 (owner: 10Jdlrobson) [20:14:12] marktraceur: mhurd tfinc brion google signed me out again. be back on in a moment. [20:14:15] (03CR) 10Brion VIBBER: Save page contents to internal storage when 'Save page' is hit (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102289 (owner: 10Yuvipanda) [20:14:21] ok [20:14:22] yuvipanda: k [20:15:27] yuvipanda, did you fall off the chair? [20:15:38] jdlrobson: not yet, no. [20:15:40] gah [20:15:43] jgonera: not yet, no [20:25:37] (03PS2) 10Yuvipanda: Make documentation slightly more accurate [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102293 [20:25:38] (03PS2) 10Yuvipanda: Save page contents to internal storage when 'Save page' is hit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102289 [20:25:39] brion: updated! [20:25:51] whee [20:29:02] brion: if it helps for review the un-squashed commits can be seen here: https://github.com/montehurd/apps-ios-wikipedia/commits/imageIntercept [20:29:23] ok [20:31:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] "seems to save json files intact :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102289 (owner: 10Yuvipanda) [20:32:12] marktraceur, what is the web site of the media viewer extension? [20:32:27] Uhhh [20:32:35] s/web site/wiki page/ [20:32:39] !e MultimediaViewer [20:32:42] ...of course not [20:32:43] can be, or git repo [20:32:53] well, not indexed in Google [20:33:14] I've had good success with Seeks in searching for MultimediaViewer [20:33:28] * yuvipanda gives marktraceur a Free Lunch [20:33:49] jgonera: https://www.mediawiki.org/wiki/Extension:MultimediaViewer [20:33:55] Aw, but I already have lunch. [20:34:01] thanks yuvipanda , got it [20:34:02] yuvipanda: I hilighted him in -dev with it [20:34:03] marktraceur: it's Free, not free [20:34:07] marktraceur: ah, right. [20:34:13] marktraceur: I wouldn't know now, would I? :P [20:34:19] Truuue [20:40:35] marktraceur: kaldari 'Images related to the article' in the Apps context refers to commonscat [20:40:59] ah [20:41:11] Common Scat I'M THE SCAT MAN. [20:41:37] yuvipanda: Seriously though this is affecting three teams, we need to make it general-er [20:41:45] marktraceur: any idea where visual editor gets it's related images? [20:41:50] marktraceur: commonscat is already available from the API [20:42:00] kaldari: Nooope. Let me shine the James_F signal. [20:42:33] it may just be search-based [20:42:40] I think it's just search based [20:42:50] I wouldn't be surprised [20:43:12] ah, the laugh that drowns out the joke [20:46:14] marktraceur: WRITE iOS CODE! [20:46:26] marktraceur: WRITE iOS CODE! [20:46:27] marktraceur: WRITE iOS CODE! [20:46:27] marktraceur: WRITE iOS CODE! [20:46:28] :P [20:46:43] * marktraceur resists saying !ops [20:46:55] marktraceur: you aren't resisting well :P [20:47:00] marktraceur: it was fabrice's idea! [20:48:27] I mean, it would need to be the first thing in the message [20:51:19] marktraceur: what's the URL for that RfC? [20:51:20] https://www.mediawiki.org/wiki/Requests_for_comment/Standardized_thumbnails_sizes kaldari [20:51:27] ESP. [20:51:59] kaldari: And a patch even https://gerrit.wikimedia.org/r/95282 [20:52:13] nom nom [20:52:36] We're working on EventLogging for performance before moving on it though [20:54:22] brion: are you in the hangout using glass?! [20:54:36] awjr: just checking my email on it ;) [20:54:38] waiting for a package ;) [20:54:45] lol [20:54:46] sweet [20:55:36] brion: awjr I feel like putting it on in a show of solidarity [20:55:46] :) [20:55:53] :D [20:56:23] jdlrobson: I <3 mobile's Makefile and scripts/pre-commit . Are you putting your KSS-generated HTML anywhere? [20:57:20] brion: done! [20:57:36] B) [20:57:40] brion: needs IRC [20:58:00] oh god veinheheheh that'd need hella good filtering though [20:58:03] jgonera: I should talk to you about what you think about it [20:58:19] brion: just PMs and highlights [20:58:28] yeah [20:58:31] yeah, marktraceur let's sync up later, I need to get some sleep now ;) [20:58:39] brion: heh, I dont' think I said a single word the entire meeting [20:59:08] the ideal meeting is the one where nothing needs be said [20:59:13] as all minds are in sync [20:59:16] with Google Brain [20:59:27] brion: :D [20:59:43] brion: we did that for a minute or two at the start, where we were just looking at each other without saying anything :) [21:00:01] jgonera: Sleep is for the weak and the dead [21:00:08] * brion muses on steganography in the video chat? [21:00:43] ooooh software update for Glass [21:00:47] brion: oh!? [21:00:56] it just started updating for me [21:00:59] like without a prompt or anything [21:01:07] lucky i wasn't doing anything eh [21:01:31] brion: yuvipanda: running to lunch [21:01:34] ok let's see if i can get Xcode to build [21:01:42] ok i'll have some feedback for you in a bit mhurd :D [21:02:56] brion: sounds good. this commit is not exactly where i want it to be on a few fronts - the dust from yesterday's big refactor is going to settle for a couple days here... [21:03:10] yeah that's ok [21:03:21] we'll tidy it up soon enough :D [21:03:29] brion: yes :) [21:04:04] brion: i'm really happy about the web view controller slimming down :) [21:04:16] yay :D [21:04:27] ok... food :) [21:04:44] back around 2 [21:04:56] brion: I have started using the app as my primary way to read wiki :D [21:05:27] yay dogfooding [21:07:44] brion: yeah, has been usable since the CSS fixes :) [21:11:56] (03CR) 10Brion VIBBER: "We'll definitely need to tweak the UI a bit. :) Let's chat a little with designers about menu planning when we get a chance!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/102291 (owner: 10Mhurd) [21:14:20] yuvipanda: "wink to take picture" mode [21:14:22] creeeeepy [21:14:29] brion: yeah, at least you need root for it [21:14:42] no now it's a settings option O_O [21:14:51] brion: wait what. [21:14:53] woah [21:14:57] https://support.google.com/glass/answer/4353446?hl=en [21:16:00] brion: woah [21:16:04] brion: the update rolled out today i guess [21:16:35] brion: they're not helping the 'glasshole' thing, are they? [21:16:39] haha srsly [21:16:46] brion: I really hope they put out a version that doesn't have the camera [21:17:25] or at least has a shutter and a light [21:17:41] brion: well, I think that ship has sailed [21:18:14] yuvipanda: oh they added the google play music feature now too \o/ [21:18:36] brion: :D [21:18:59] shit i don't have my music on google play do i, no i have it on iTunes match and amazon [21:19:00] brion: youtube works? [21:19:02] effing cloud services [21:19:06] brion: heh! [21:20:11] ah i have to turn youtube uploading on in glassware [21:20:27] brion: oh, *upload*? not view? [21:23:03] * marktraceur points dramaticall at James_F [21:23:05] yuvipanda: https://www.youtube.com/watch?v=uHhkrzgXCUU \o/ [21:23:18] Heya. [21:23:22] now i just need an upload to commons ;) [21:23:27] brion: hah! :D [21:23:39] brion: heh, makes dick pictures so much easier, eh? [21:23:44] lol [21:23:54] *look down* *wink* [21:24:33] awjr or kaldari, can you review https://gerrit.wikimedia.org/r/102305 please? [21:24:44] The magic "images like this page" is not so magic when I peel back the curtain: it's just a search for the page's title. [21:24:59] Which means it's great in English and less good in non-English languages. :-( [21:25:06] The plan is to hook into Wikidata, but for now… [21:25:38] heh [21:27:31] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok merging for now -- let's get the UI tweaked up soonish :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/102291 (owner: 10Mhurd) [21:28:22] James_F: you could hook into commonscat. It's already available from the API, and I think non-english languages also can have it [21:28:28] (we are planning on using it on the app) [21:29:30] yuvipanda: Yeah, there's a suggestion to do that. [21:29:41] yuvipanda: Problem is for pages which don't have a Wikidata link yet. [21:29:56] James_F: yeah, but better than searching for page title no? [21:30:00] or at least in combination with that [21:30:08] yuvipanda: E.g. I'm just creating one, or it doesn't exist in other languages… there's nothing we'd have to suggest. [21:30:20] i gotta start using rechargeable batteries in my wireless keyboard/trackpad [21:30:29] James_F: right. true! [21:30:30] i'm sure i've poisoned a landfill or two with these throwawayys [21:30:42] James_F: still, a combination of article title + commonscat perhaps [21:30:49] brion: Tsk, Earth-hater! :-) [21:30:52] yuvipanda: Yeah. [21:31:18] not to mention the landfill full of coffee stirrers with my name on it [21:32:44] ok gonna eat some form of lunch, bbiab [21:33:09] jdlrobson: BTW, where should I put a bug about Special:Nearby on desktop? [21:34:37] James_F: another one :( < JeffHall this is why i want tests - glad we're getting closer :-( [21:34:44] James_F: stick it under MobileFrontend [21:35:17] jdlrobson: It's actually a bug for May, not you (the BetaFeature icon is unlike all the other ones, and probably should be fixed to be in sync). :-) [21:35:21] jdlrobson: But thanks. [21:35:32] James_F: wait.. [21:35:39] you mean nearby pages or Special:Nearby ? [21:36:08] James_F: amir just submitted a patch to add a RTL icon for nearby as well [21:36:26] James_F: I really think a BetaFeatures Feature product would be useful on bugzilla [21:36:29] jdlrobson: The nearby pages, sorry. [21:36:35] it gets super confusing otherwise [21:36:47] jdlrobson: There is one - but this isn't an issue with BF itself, really. [21:40:47] jdlrobson: hallo. [21:41:06] about "Mobile-frontend-editor-disabled" => "This page is protected to prevent vandalism." [21:41:19] up to you, but it looks a bit too dry to me. [21:41:58] I would think about a way to say clearly that it's only this particular page, and that there was a reason to protect... and maybe invite the user to contribute to some other page. [21:42:22] Maybe you already thought about that... but I ran into it while translating and it didn't seem completely right. [21:42:48] aharoni: it only shows on protected pages and it shows as feedback when you click the edit icon [21:42:53] it's not supposed to be actionable in any way [21:43:06] there is a lock icon on the edit icon so the purpose of the message is just to say why [21:43:53] inviting a user to contribute to another page would require showing something other than a notification message [21:44:03] i'm not sure what that would look like [21:54:07] brion: just 'read contents of a file into an string' has 10000 possible solutions, all of which are different. [21:54:09] goddamn java [22:08:05] (03PS1) 10Kaldari: Reset the issues array before we populate it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102317 [22:09:09] hi, i am a little unsure if wikimedia-dev, or wikimedia-mobile is the right channel. i am trying to extend the kiwix help so it is easy to download books. [22:10:00] rutu: try #kiwix? [22:10:04] but, i have multiple issues. (1) there is no "book" link in the mobile skin ... [22:11:32] (2) http://en.wikipedia.org/wiki/Special:Book has the wrong default order and format for kiwix/zim [22:12:49] jdlrobson: That's exactly how I guessed that that message is displayed. It's just that it reminded of Mako's talk at last year's all-staff - about how the most popular pages on Wikipedia are also the most likely to be protected, and how it works against attracting new editors. [22:13:42] yuvipanda: how can i get a book link into the mobile skin, which allows to add the page to the book? [22:14:01] rutu: it's stripped out by the Mobile skin, I think. ask jdlrobson perhaps [22:14:05] So maybe you could consider making it less dry. For example, a lot of people could easily think that they are suspected of being vandals, even though they didn't even start editing yet. [22:16:47] yuvipanda: thanks! and how could one edit the special page? how could one set defaults to drop downs etc? [22:17:06] rutu: I have no idea, sorry! jdlrobson works on the Mobile skin and might know [22:17:12] rutu: you could also perhaps email the mobile-l list [22:20:36] YuviPanda: Can you give me admin and gwtoolset rights on http://commons.wikimedia.beta.wmflabs.org? [22:20:50] kaldari: nope, I think I had mine taken away a month or so back [22:21:12] still says you're a crat on this list: http://commons.wikimedia.beta.wmflabs.org/wiki/Special:ListUsers/sysop [22:21:30] ah! [22:21:31] yes [22:21:33] moment [22:21:41] kaldari: i was taken off as project admin on wikitech, not here [22:21:42] moment [22:23:01] kaldari: username is Kaldari? [22:23:06] yep [22:23:30] kaldari: crat and admin done! [22:23:40] thank you sir! [22:23:43] kaldari: yw! :) [22:30:47] (03PS1) 10Yuvipanda: Add methods + tests to bring back value objects from JSON [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102327 [22:30:48] (03PS1) 10Yuvipanda: Load the saved pages when pointed to from the Saved Pages activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102328 [22:30:49] brion: that works [22:30:53] brion: sans images, ofcourse. [22:32:02] hey dr0ptp4kt [22:32:11] hi jdlrobson [22:32:14] brion: thx brion! [22:32:19] you got a hangout? [22:32:29] yup, see meeting details [22:33:31] (03PS2) 10Yuvipanda: Load the saved pages when pointed to from the Saved Pages activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102328 [22:33:38] brion: I'm going to head to sleep now. [22:37:22] brion: mhurd just realized I joined the WMF 2 years ago today! :D [22:38:44] yuvipanda: that's awesome! happy anniversary :) [22:38:51] mhurd: :) [22:40:01] mhurd: do poke brion to review the android patches. [22:40:03] i'm off now [22:40:13] yuvipanda: goodnight! [22:40:20] will do [22:40:22] t [22:40:23] y [22:40:30] hehe [22:49:34] yvipanda: thanks for the hints, asked without result on wikimedia-tech, and mailed to mobile-l. [22:49:55] yuvipanda: and i should learn typing [22:57:33] (03PS6) 10Jhall: QA: New browser test for "Nearby" page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101129 [23:22:35] jdlrobson: You OK for there to be a VectorBeta component in Bugzilla with you as default CC? [23:23:33] jdlrobson, using the tip of MobileFrontend:master and core:master, if i start from a completely fresh browsing session, the datetime stamp on the startup module is different between successive loads. in production, varnish would be caching the invoking javascript (/w/load.php?debug=false&lang=en&modules=startup&only=scripts), hence the timestamp contained within being the same for up to 300 seconds, depending on when the ua hits the [23:23:34] site. [23:25:07] so i think the trick is probably to emulate the behavior and ensure that the appcache manifest has the correct cache-control (and maybe expires) headers to follow suit. [23:32:58] brion: how did we do for our release ? [23:33:12] * tfinc is eager to see the release email [23:50:05] MaxSem: yt? [23:50:13] yup [23:50:19] hi :) [23:50:24] im taking a spin through the extractformatter stuff [23:50:49] quick q [23:50:53] https://gerrit.wikimedia.org/r/#/c/102305/2/ExtractFormatter.php L39 [23:51:11] yes? [23:51:20] i noticed in the MobileFrontend version, there is a distinction between RemovableClasses['base'] and ['extracts'] [23:51:38] is that going to be problematic here? [23:51:48] or… why is that not necessary here? [23:53:25] because it doesn't have to depend on MF and thus doesn't need to have its structure with various formatters inheriting certain removals [23:53:54] MaxSem: so you feed it a flat array which contains everything you care about [23:54:10] yep [23:56:14] ah ok, i just looked at the comments in MobileFrontend.php for $wgMFRemovableClasses - that makes more sense to me now [23:57:33] MaxSem: i just +2'd [23:57:35] thanks awjr and kaldari [23:57:37] :) [23:57:39] np [23:57:42] :D [23:57:49] awjr: you beat me to it [23:57:52] :p [23:57:57] fastest draw in the west [23:58:47] MaxSem: Now it's time to create https://www.mediawiki.org/wiki/Extension:TextExtracts :) [23:59:07] wee