[00:04:47] (03PS2) 10Kaldari: Reset the issues array before we populate it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102317 [00:10:40] (03PS1) 10Jdlrobson: Hygiene: Correct the hook parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102852 [00:14:24] (03PS1) 10Jdlrobson: Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 [00:48:12] (03PS2) 10Mhurd: Moved history, saved pages and page save buttons to "W" menu. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/102832 [01:21:22] (03PS2) 10Jdlrobson: Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 [01:21:23] (03PS1) 10Jdlrobson: Hygiene: Separate toggling code into own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102864 [01:21:24] (03PS1) 10Jdlrobson: Hygiene: Remove dependency between mobile.newusers and mobile.toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102865 [01:21:25] (03PS1) 10Jdlrobson: Offer the blue pill or the red pill [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 [01:37:46] (03PS2) 10Jdlrobson: Offer the blue pill or the red pill [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 [16:09:39] (03CR) 10JGonera: [C: 032] Reset the issues array before we populate it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102317 (owner: 10Kaldari) [16:10:21] (03Merged) 10jenkins-bot: Reset the issues array before we populate it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102317 (owner: 10Kaldari) [16:59:17] brion: hey! [17:00:33] brion: around? [17:20:28] (03PS7) 10Jdlrobson: Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 [17:21:50] (03CR) 10Jdlrobson: [C: 031] "MaxSem feel free to merge" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102463 (owner: 10MaxSem) [17:44:10] (03PS1) 10JGonera: [WIP] Introduce OverlayManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102966 [17:46:42] (03PS2) 10JGonera: [WIP] Introduce OverlayManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102966 [17:52:05] hey jdlrobson - props for doing what you did to SkinMobile:) [17:52:18] thanks MaxSem - it was getting way too confusing [17:52:19] (03PS3) 10Jdlrobson: Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 [17:52:25] i also think we could upstream the isMobileMode to skins [17:52:27] what think you? [17:52:41] that way other skins could run in a mobile adapted mode if they wanted to [17:53:00] we would need to upstream DeviceDetection, for that, no? [17:53:19] yup [17:53:28] $this->isMobileMode = $this->mobileContext->shouldDisplayMobileView(); < basically that [17:53:35] (in some form) [17:54:18] kill WAP first [17:54:35] (it's in the next iteration) [17:54:36] MaxSem: +1 :) [17:54:48] but yeh if you can merge my refactorings of skin that would be awesome [17:54:57] i imagine we'll hit merge conflicts soon otherwise [17:55:37] (03CR) 10Jdlrobson: [C: 04-1] "Need to find a way of styling Special:Preferences on mobile before this can be merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [17:58:32] (03PS5) 10MaxSem: Fix fatal for non-existent users on SpecialMobileContributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102463 [17:58:49] (03CR) 10MaxSem: [C: 032] Fix fatal for non-existent users on SpecialMobileContributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102463 (owner: 10MaxSem) [17:59:36] (03Merged) 10jenkins-bot: Fix fatal for non-existent users on SpecialMobileContributions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102463 (owner: 10MaxSem) [18:02:58] that's super weird, I can hear and see you totally OK [18:05:52] (03PS1) 10MaxSem: Rv accidental graffiti [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102968 [18:06:07] (03CR) 10MaxSem: [C: 032] Rv accidental graffiti [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102968 (owner: 10MaxSem) [18:06:45] brion: hey! [18:06:57] (03Merged) 10jenkins-bot: Rv accidental graffiti [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102968 (owner: 10MaxSem) [18:09:35] COFFEE OBTAINED [18:09:46] brion: ACHIEVEMENT UNLOCKED! [18:09:49] now to find glasses so i can read what I'm typing [18:10:15] brion: OVERRATED! :P [18:13:23] ah, a nice set of things to review [18:14:58] (03CR) 10Brion VIBBER: [C: 032 V: 032] Clear bridge listeners when they are no longer used [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102818 (owner: 10Yuvipanda) [18:17:38] app team is full of glassholes YuviPanda ;-) [18:19:42] (03CR) 10JGonera: [C: 04-2] [WIP] Introduce OverlayManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102966 (owner: 10JGonera) [18:22:09] jdlrobson: only two! :P [18:22:16] jdlrobson: and mine is off because it ran out of charge [18:23:37] lol [18:23:51] yeah the battery life is awful [18:24:19] brion: yeah. I think unless you are writing code for it, a glass right now is uesless [18:25:05] it's like cigarettes [18:25:08] it just makes you look cooler [18:25:12] and/or like an asshole [18:25:21] brion: heh! [18:25:29] brion: I seem to have quit tobacco. [18:25:43] probably for the best :) [18:25:55] brion: yeah, and hopefully this time for real [18:26:02] hehe [18:26:54] hmmmm i saw a 'saving page...' toast but didn't see the 'page saved' [18:26:59] lemme see if it worked [18:28:57] bah i'm getting those mar sheller fails again. lemme test on 4.4 for now, see if that works around that until i get it figured out [18:29:06] brion: ok [18:31:25] oh i'm betting i had a bogus sqlite db. lemme refresh [18:32:27] oh i bet that next commit helps [18:33:16] yessss [18:33:20] brion: :D [18:33:48] (03CR) 10Brion VIBBER: [C: 032 V: 032] "this fixes previous commit :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102826 (owner: 10Yuvipanda) [18:34:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] "This fixes earlier commit, but also needs next commit to actually work on some real pages :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102823 (owner: 10Yuvipanda) [18:35:45] (03CR) 10Brion VIBBER: [C: 032 V: 032] Use md5 for generating image save URLs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102827 (owner: 10Yuvipanda) [18:43:24] (03PS1) 10Jdlrobson: Make Special:Preferences work on Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102976 [18:44:21] (03CR) 10Brion VIBBER: When loading images fails, fall back to loading them from storage (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102847 (owner: 10Yuvipanda) [18:47:06] (03CR) 10Yuvipanda: When loading images fails, fall back to loading them from storage (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102847 (owner: 10Yuvipanda) [18:47:36] (03PS2) 10Jdlrobson: Make Special:Preferences work on Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102976 [18:49:55] hmm stuff keeps being cached. lemme force it to always replace and make sure it works [18:51:11] brion: yeah, you can do a webview.clearCache(true); in CommunicationsBridge to force that [18:52:04] ah nice [18:52:49] brion: remember to not commit that tho :P [18:53:07] heh [18:53:44] we'll have to deal with density on images at some point [18:53:49] but we can worry about that later i think [18:54:18] (03PS3) 10Jdlrobson: Make Special:Preferences work on Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102976 [18:54:46] brion: yeah [18:55:57] bah i wish that remote inspector worked on 4.3 [18:56:02] it's very handy on 4.4 :D [18:56:08] brion: yeah [18:56:50] woot ok works on both, good [18:56:55] (the saving/loading) [18:57:06] brion: :D [18:57:22] kaldari, I added an example of use at https://www.mediawiki.org/wiki/Requests_for_comment/HTML_templating_library#Example_of_use [18:57:30] not sure what else should be added [18:57:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok confirmed working with the 4.3 and 4.4 webviews :D" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102847 (owner: 10Yuvipanda) [18:58:01] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I don't like sync stuff but this is fine for now :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102846 (owner: 10Yuvipanda) [18:58:27] (03CR) 10Brion VIBBER: [C: 032 V: 032] Do not download duplicates or file:// URL images [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/102928 (owner: 10Yuvipanda) [18:59:51] ok now lemme poke ios [19:01:52] jdlrobson, kaldari I'll be leaving soon for today. I'll start with code review and finishing overlay manager [19:02:14] one thing I'm wondering about: should we first use overlay manager only in beta or test it thoroughly and use it everywhere? [19:02:35] I can imagine that it's going to be a hassle having this working differently in stable [19:03:56] mhurd: ok that effect with the saved page text jumping down to the saved pages menu item? that's just awesome :D [19:05:22] brion: :) yay! it was fun to implement too [19:08:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ahhh, pretty menu is much nicer than the funky icon before. :D And the animation ROCKS." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/102832 (owner: 10Mhurd) [19:08:51] mhurd: my one complaint is that the 'save for offline reading' button doesn't change state after, and we can fix that later [19:08:57] in the meantime i have fun just pushing it over and over ;) [19:09:25] brb [19:10:26] brion: ah! good point! [19:37:16] brion: can haz favor? i need a pair of mobile screenshots from a Nexus 5 or other small 1080p device. [19:38:47] [[Penny Cyclopedia]] logged in with one Notification, with and without the menu open. [19:40:41] * MaxSem bites upstart hard [19:43:18] jdlrobson: can I get your opinion on something visual? [19:56:23] (03PS1) 10Kaldari: Fixing default table styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102983 [20:05:23] (03PS5) 10Robmoen: Add editing and preview messages to header area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 [20:07:15] (03PS6) 10Robmoen: Add editing and preview messages to header area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 [20:10:26] (03PS7) 10Robmoen: Add editing and preview messages to header area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 [20:14:08] kaldari: sure i'll be over in a sec [20:17:08] (03CR) 10Kaldari: "Shouldn't we name the file SpecialMobilePreferences to stick with our existing naming convention?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102976 (owner: 10Jdlrobson) [20:18:39] brion: yuvipanda mhurd http://brionv.com:5000/30939 [20:23:54] yuvipanda: raed my google hangout message [20:24:07] violetto: ok [20:24:29] violetto: will do when brion is done talking [20:26:05] violetto: oh, I didn't know search team was on that [20:26:10] yeah! [20:26:11] :) [20:26:19] just not the interface they dont have a frontend [20:26:22] yuvipanda: [20:26:31] violetto: yeah, true [20:26:40] violetto: right now searching across languages is a PITA in the backend [20:26:46] violetto: if they fix that we can easily add it :) [20:26:51] yuvipanda: pita bread? [20:26:56] yeah :) [20:27:02] violetto: i keep hearing about that bread, haven't actually seen it [20:27:24] violetto: let me go poke them [20:27:30] yuvipanda: There's this free encyclopedia thing on the internet... [20:27:40] Reedy: that's where I keep hearing about it [20:27:41] yuvipanda: https://en.wikipedia.org/wiki/Pita_bread [20:27:47] Reedy: i know right [20:27:49] haha [20:27:59] Here's a pita [20:28:02] There's a pita [20:28:06] And another little pita [20:28:13] Funny pita [20:28:15] Fuzzy pita [20:30:40] Reedy: you sound very passionate about pita [20:31:19] yuvipanda: chad is the person if you don't know yet [20:31:21] search team [20:31:28] violetto: been talking to him for the last 3 minutes [20:31:36] yuvipanda: nice! [20:31:50] violetto: estimate on: 'yuvipanda: Between now and the heat death of the universe ;-) ' [20:39:05] violetto: talked to chad, a more realistic estimate is 6 months or so [20:40:39] yuvipanda: even if just language? [20:40:44] violetto: yeah. [20:40:48] i see [20:41:03] violetto: although if we switch to wikidata search it's trivial to do [20:41:22] violetto: but that patch hasn't been merged [20:41:26] yuvipanda: i see [20:41:35] oh well, it's already designed just waiting for it to happen [20:41:39] whenever you guys need it :) [20:41:39] violetto: yeah [20:48:41] violetto: enjoy the time off! [20:48:45] violetto: don't check email! [20:53:33] (03PS1) 10Yuvipanda: Actually use the saved pages layouts in the saved pages activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103036 [20:53:38] brion: ^ trivial fix that had me head banging for about 2 hours :| [20:53:49] heh [20:54:02] brion: this is why copy paste sucks [20:54:07] those lists are almost the same ;) [20:54:25] brion: heh, yeah [20:54:32] brion: also, we forgot to add 'setup on translatewiki' there [20:54:37] brion: but I guess that'll come in a later sprint [20:54:49] yeah [20:54:58] gotta get that in the backlog so we do it soon enough :D [20:55:06] brion: yeah [20:55:29] brion: it'll be easy enough for Android, since we did most of the tough work with the commons app [20:55:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] Actually use the saved pages layouts in the saved pages activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103036 (owner: 10Yuvipanda) [20:55:44] yeah [20:55:50] i'll have to do some fiddling with ios [20:55:58] brion: what format does it use [20:56:08] we weren't entirely happy with the custom localization library we used on commons [20:56:15] yeah [20:56:17] so we might switch to the native iOS strings list format [20:56:24] which i think is an xml plist or something [20:56:39] so either have to a dd translatewiki support or add a script to convert the formats [20:57:40] (03CR) 10TheDJ: [C: 04-1] "if you want no border, you probably should set explicit border:none; to counter any border=1 attribute on a table for instance." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102983 (owner: 10Kaldari) [21:07:43] brion: the reason I gave it a 2 was because... https://code.google.com/p/romannurik-code/source/browse/misc/scrolltricks/src/com/example/android/scrolltricks/QuickReturnFragment.java [21:11:37] +1 existing code \o/ [21:13:28] brion: it doesn't work with webviews directly, since they don't have a native scroll event, but fixable [21:13:43] yeah [21:13:51] worst case bridge the js onscroll [21:14:16] yeah [21:14:17] worst case [21:31:53] (03CR) 10MaxSem: [C: 04-1] "I don't think that adding another special page override just to add a module is a maintainable thing to do. Using OutputPageBeforeHTML hoo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102976 (owner: 10Jdlrobson) [21:41:17] (03CR) 10MaxSem: [C: 032] "Works for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102864 (owner: 10Jdlrobson) [21:41:55] (03Merged) 10jenkins-bot: Hygiene: Separate toggling code into own module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102864 (owner: 10Jdlrobson) [21:52:11] (03PS2) 10Theopolisme: Add intermediate Special:MobileEditor to catch users without JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102923 [21:53:21] (03CR) 10Theopolisme: Add intermediate Special:MobileEditor to catch users without JavaScript (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102923 (owner: 10Theopolisme) [21:56:13] (03CR) 10Dr0ptp4kt: [C: 032] Reduce api caching, hide api warnings [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/102850 (owner: 10Yurik) [21:56:17] (03Merged) 10jenkins-bot: Reduce api caching, hide api warnings [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/102850 (owner: 10Yurik) [21:57:25] (03PS2) 10Jdlrobson: Fixing default table styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102983 (owner: 10Kaldari) [21:57:35] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fixing default table styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102983 (owner: 10Kaldari) [21:58:28] (03Merged) 10jenkins-bot: Hygiene: Fixing default table styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102983 (owner: 10Kaldari) [22:00:39] kaldari: https://gerrit.wikimedia.org/r/#/c/99523/ https://gerrit.wikimedia.org/r/#/c/99524/ [22:01:47] (03Abandoned) 10Jdlrobson: Alpha: Experiment to collapse sections in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94245 (owner: 10Jdlrobson) [22:02:09] MaxSem: any thoughts around https://gerrit.wikimedia.org/r/#/c/101242/1/includes/MobileContext.php [22:02:12] would be nice to merge :) [22:02:28] argh [22:02:46] (03CR) 10MaxSem: [C: 032] Hygiene: Remove dependency between mobile.newusers and mobile.toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102865 (owner: 10Jdlrobson) [22:03:23] (03Merged) 10jenkins-bot: Hygiene: Remove dependency between mobile.newusers and mobile.toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102865 (owner: 10Jdlrobson) [22:07:06] (03CR) 10MaxSem: Allow to force stable with useformat=stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101242 (owner: 10MaxSem) [22:08:15] (03CR) 10Jdlrobson: [C: 032] Add editing and preview messages to header area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 (owner: 10Robmoen) [22:08:50] (03Merged) 10jenkins-bot: Add editing and preview messages to header area [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/99776 (owner: 10Robmoen) [22:08:56] (03CR) 10Jdlrobson: [C: 032] "Fair point. Resolve later :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101242 (owner: 10MaxSem) [22:09:32] (03Merged) 10jenkins-bot: Allow to force stable with useformat=stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101242 (owner: 10MaxSem) [22:11:20] mmm jdlrobson, refactoring gurus would say that https://gerrit.wikimedia.org/r/#/c/102853/3/includes/skins/SkinMinerva.php is an example of what inheritance is for:) [22:14:28] MaxSem: mm? [22:15:19] I like the general idea of getting rid of SkinMobile, but the current implementation has a lot of if ( $isMobile ) conditionals [22:16:13] it impairs readability no less [22:27:14] (03PS1) 10MaxSem: Remove unused hook parameter, will be removed from MF too [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103052 [22:28:23] dr0ptp4kt, yurik - ^^^:) [22:29:11] tfinc: awjr|lunch: video link? [22:30:33] MaxSem, do i even need to test that? :) [22:30:52] that an unused parameter is unused?:) [22:32:00] (03CR) 10Yurik: [C: 04-1] Remove unused hook parameter, will be removed from MF too (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103052 (owner: 10MaxSem) [22:32:09] :) [22:32:14] MaxSem: so... how hard is it to add page protection status to mobileview? [22:32:29] not hard [22:32:54] MaxSem: mmm, okay! [22:32:57] * MaxSem wonders when an average mobileview request will hit our URL length limit:P [22:33:06] MaxSem: sooooooooon :D [22:33:20] MaxSem: so we'll at some point of time deploy Extension:MobileApp [22:33:27] MaxSem, you were looking for the wrong thing ... we have two of them [22:33:29] chrismcmahon: robla just added it to the calendar invite [22:33:30] MaxSem: perhaps at that time I can move mobileview to there, and just call mobileview internally [22:33:40] MaxSem: so I can add things there without complicating mobileview too much [22:34:46] (03PS2) 10MaxSem: Remove unused hook parameter, will be removed from MF too [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103052 [22:38:46] (03CR) 10Yurik: [C: 032] Remove unused hook parameter, will be removed from MF too [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103052 (owner: 10MaxSem) [22:38:48] (03Merged) 10jenkins-bot: Remove unused hook parameter, will be removed from MF too [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103052 (owner: 10MaxSem) [22:38:55] thanks:) [22:39:42] MaxSem, do you know why a wfDebugLog result might be empty? [22:40:05] (ops) [22:44:39] hmmm, let's look.... [22:46:56] yurik, was it ever synched? I don't see it in SAL [22:47:49] MaxSem, sal? [22:48:00] server admin log [22:48:03] Reedy has deployed it yesterday i think [22:49:23] MaxSem, 19:52 logmsgbot: reedy synchronized php-1.23wmf7/includes/Message.php [22:49:32] ah, not you:) [22:49:41] it was his window :) [22:50:09] oh, MaxSem could you +2 https://gerrit.wikimedia.org/r/#/c/102604/ [22:50:23] its already in production :) [22:50:52] doned [22:50:57] thx [23:06:13] (03CR) 10Jdlrobson: [C: 032] Add intermediate Special:MobileEditor to catch users without JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102923 (owner: 10Theopolisme) [23:06:41] (03PS1) 10MaxSem: Remove hookOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103059 [23:06:58] (03Merged) 10jenkins-bot: Add intermediate Special:MobileEditor to catch users without JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102923 (owner: 10Theopolisme) [23:10:04] (03CR) 10Jdlrobson: [C: 032] Remove hookOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103059 (owner: 10MaxSem) [23:10:09] (03PS2) 10Jdlrobson: Remove hookOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103059 (owner: 10MaxSem) [23:10:14] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove hookOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103059 (owner: 10MaxSem) [23:10:34] (03PS3) 10Jdlrobson: Story 1508: Update talk, page previews and geonotahack to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101428 [23:11:03] MaxSem: MaxSem: https://gerrit.wikimedia.org/r/#/c/102852/ [23:11:19] (03Merged) 10jenkins-bot: Hygiene: Remove hookOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103059 (owner: 10MaxSem) [23:11:20] (03PS8) 10Jdlrobson: Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 [23:12:23] (03CR) 10MaxSem: Hygiene: Correct the hook parameter (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102852 (owner: 10Jdlrobson) [23:15:37] (03PS2) 10Jdlrobson: Hygiene: Correct the hook parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102852 [23:16:40] (03CR) 10MaxSem: [C: 032] Hygiene: Correct the hook parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102852 (owner: 10Jdlrobson) [23:17:18] (03Merged) 10jenkins-bot: Hygiene: Correct the hook parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102852 (owner: 10Jdlrobson) [23:18:39] kaldari and jdlrobson Ori just told me that he merged a change for the event logging schema change [23:19:39] does that mean we need to change things on our end? [23:22:41] (03PS4) 10Jdlrobson: Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 [23:22:42] (03PS1) 10Jdlrobson: Hygiene: kill applyCustomisations and template variable tweaking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103061 [23:26:55] I dunno. Can someone look to see what he merged? if it's doing what we expect then we need to update our limn graphs [23:28:08] (03PS4) 10Jdlrobson: Make Special:Preferences work on Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102976 [23:28:42] (03CR) 10jenkins-bot: [V: 04-1] Make Special:Preferences work on Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102976 (owner: 10Jdlrobson) [23:29:46] (03PS5) 10Jdlrobson: Make Special:Preferences work on Minerva [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102976 [23:31:42] MaxSem: https://gerrit.wikimedia.org/r/#/c/103061/ you'll like this one [23:32:20] jdlrobson, how do we fight with Echo now, then?:) [23:32:49] MaxSem: javascript takes care of it :) [23:33:00] yurik, poked around on tin - everything looks like it should work [23:33:06] yet it doesn't:P [23:33:37] (03PS5) 10Jdlrobson: Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 [23:34:10] MaxSem: hm? [23:34:25] that wasn't for you [23:34:36] (03CR) 10MaxSem: [C: 032] Hygiene: kill applyCustomisations and template variable tweaking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103061 (owner: 10Jdlrobson) [23:34:37] MaxSem, exactly! so very confused :( [23:34:41] (03PS3) 10Jdlrobson: Docs: Document overlays with KSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102547 [23:34:49] (03CR) 10Jdlrobson: "Jgonera could do with some feedback ^^" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102547 (owner: 10Jdlrobson) [23:35:09] MaxSem, but thank you! although strangelly enough, jenkins also doesn't let me +2 it :( [23:35:11] (03Merged) 10jenkins-bot: Hygiene: kill applyCustomisations and template variable tweaking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103061 (owner: 10Jdlrobson) [23:45:40] (03PS1) 10Jdlrobson: Hygiene: Cleanup cookie usage in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103065 [23:46:01] (03PS2) 10Jdlrobson: Hygiene: Cleanup cookie usage in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103065 [23:52:35] yurik: dr0ptp4kt when I run ZeroRatedMobileAccess why does it always redirect me to enwiki? [23:52:54] jdlrobson, it doesn't like you [23:53:02] what do you mean you run zRMA? [23:53:03] jdlrobson, it depends on the X-CS value. [23:53:11] yurik!!! [23:53:18] I've adding the extension to my local wiki and it always redirects me to en.wiki [23:53:34] I have RequestHeader set X-CS "250-99" [23:53:37] jdlrobson, it should not redirect unless you navigate to special:ZRMA [23:53:38] is that not valid? [23:53:47] Sorry, en.zero.wikipedia.org is only supported by select mobile carriers and is not available from your mobile carrier. [23:53:47] If you are contacting your mobile carrier, mention that your IP address 127.0.0.1 is not supported. [23:53:48] Continue to http://en.m.wikipedia.org/wiki/Main_Page (standard data charges may apply) [23:54:05] it's valid, are you going to /wiki/Main_Page ... okay, set your X-Subdomain header to ZERO [23:54:25] dr0ptp4kt: i have [23:54:29] dr0ptp4kt, hold on, 250-99 has both [23:54:30] RequestHeader set X-SUBDOMAIN "ZERO" [23:54:31] RequestHeader set X-CS "250-99" [23:54:33] moizsyed, kaity: Is jared around? [23:54:49] dr0ptp4kt, yes, but have you configured where it gets its configs? [23:54:55] sec, let me get you the string [23:55:05] README is not up to date btw ;-) [23:55:26] jdlrobson, $wgZeroRatedMobileAccessApiUri = 'http://meta.wikimedia.org/w/api.php'; [23:55:32] kaldari: I think he's in meetings all day [23:55:39] :( [23:55:40] * yurik blames dr :) [23:55:53] yurik: that did it! [23:55:54] thanks :) [23:56:01] * yurik knows he should have done it... [23:56:11] fixed the doc [23:56:58] dr0ptp4kt, i propose we delete all text in README, and just leave a link to the extension page [23:57:07] we shouldn't have two spots for docs - its not DRY [23:57:34] jdlrobson, btw, i suggest you set X-CS = TEST [23:57:39] dr0ptp4kt, ^ [23:58:01] TEST is a better one - you can have funky things with it - like i can easily give you the right to change it [23:59:21] yurik, i'm fine with that. people will just need to be running the latest version and read the wiki. hypothetically, you'd want the readme to match the current version if there's version-dependent stuff... [23:59:44] nah, it would suck to keep them in sync [23:59:48] not DRY :)