[00:05:37] (03PS2) 10Yuvipanda: Make saved pages selectable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103325 [00:45:48] (03PS1) 10Yuvipanda: Add functionality to delete selected pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103328 [01:44:18] (03PS1) 10Theopolisme: View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 [02:05:05] (03PS2) 10Theopolisme: View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 [02:05:58] (03CR) 10Theopolisme: View source of old revisions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [03:41:31] (03CR) 10Theopolisme: View source of old revisions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [05:05:11] (03PS1) 10Yuvipanda: Bump minVersion to ICS, not HoneyComb [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103337 [07:49:10] (03PS1) 10Yuvipanda: Implement a continuous version of 'Quick Return' [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103344 [14:55:23] hello, can anybody here help me with modifying mobilefrontend? [15:00:44] http://www.google-melange.com/gci/task/view/google/gci2013/5837265490149376 [15:01:04] hey GEOFBOT [15:01:50] thanks for taking the bug I originally reported:) [15:02:43] so the question is what do you know and what do you need help with, GEOFBOT [15:04:13] i don't know a lot of web stuff [15:04:19] so after i clone hte repository [15:04:23] where should i start out? [15:05:15] do you already have MediaWiki up and running? [15:05:21] no [15:05:24] shoul di set that up? [15:06:02] https://www.mediawiki.org/wiki/Download_from_Git [15:06:43] install MW from Git, then install MobileFrontend you cloned [15:07:13] MaxSem: a raspberry pi should be able to handle runing mediawiki, right ? ;) [15:07:24] heh [15:07:32] its become my developer platform [15:07:39] just in case i dont fry it ;) [15:07:45] I guess if it has PHP 5.3 andsome DB [15:17:31] hey jgonera [15:17:37] hey MaxSem [15:18:04] how's Poland? [15:18:15] pretty good, no snow though :( [15:19:00] are you missing the snow? [15:19:55] a little bit, winter is gray and sad without it [15:20:42] FFS, Jon just broke fixed headers in overlays again... [15:21:04] we had no browser tests for this? [15:21:15] how would we browser test CSS? [15:21:20] here in the southeast us there is no snow whatsoever :'( [15:21:53] -- a displaced yankee [15:21:55] any success GEOFBOT? [15:22:11] still installing [15:22:21] all the other packages [15:23:08] how's winter around Moscow MaxSem? [15:23:53] also, does the editor work for you in beta on the most recent master? [15:24:08] rain falling on snow, when temperature falls it's going to be one fucking skating range [15:25:05] haha [15:26:24] jgonera, Error: Module not found: modules/editorNew/EditorOverlay [15:26:32] yep, same here, great [15:33:16] MaxSem: where should mediawiki go? [15:33:24] like the directory [15:33:39] to /var/www? :P [15:35:20] clone directly to /var/www ? [15:36:53] yep, or to a subdirectory of it [15:41:46] mediawiki is rather large to clone [15:56:26] MaxSem: ive moved mediawiki into /var/www/wiki/ [15:56:35] is there any otehr config i need to do? [15:56:49] because when i open 192.168.1.7/wiki it pulls a 403 [15:58:29] what about /wiki/mw-config/index.php? [15:59:45] You don't have permission to access /wiki/mw-config/config.php on this server. [15:59:53] i think the permissions for the wiki dir are wrong [16:00:16] drw-r--r-- 15 root root 4096 Dec 23 15:51 wiki [16:00:23] lol [16:06:41] MaxSem: oh, i think i didn't set it up in the 000-default [16:07:20] MW doesn't require webserver config changes [16:07:53] hmmmm [16:08:47] if you have PHP set up you should be fine [16:18:00] MaxSem: ok, its woring now [16:18:33] working as in "installed"? [16:18:37] yes [16:18:43] my permissions were wrong [16:19:08] ok, move your clone of MobileFrontend into extensions/ [16:19:32] add require_once( "$IP/extensions/MobileFrontend/MobileFrontend.php" ); to LocalSettings.php [16:27:36] MaxSem: done [16:27:46] i should try opening it on mobile now? [16:28:02] you should see mobile view links at the bottom now [16:29:09] ah, i see [16:30:42] now we need to set up interwikis [16:30:47] INSERT INTO `my_wiki`.`interwiki` (`iw_prefix`, `iw_url`, `iw_wikiid`, `iw_local`) VALUES (0x6672, 0x2F2F66722E77696B6970656469612E6F72672F77696B692F, 0x6672, 1); [16:31:37] INSERT INTO `my_wiki`.`interwiki` (`iw_prefix`, `iw_url`, `iw_local`) VALUES (0x7371, 0x2F2F66722E77696B6970656469612E6F72672F77696B692F2431, 1); [16:31:45] (assuming you're on mysql) [16:32:40] Hey everyone. Can I become a betatester of the new iOS-app? [16:32:56] MaxSem: ok, i entered those two lkines into mysql [16:33:27] now edit some page, add [[fr:foo]] [[sq:bar]] [16:33:36] you should see interwiki links [16:34:13] note that they're in page HTML in mobile view - your task is to get rid of them:) [16:34:28] (while maintaining the functionality, of course) [16:34:40] ah, i see [16:34:58] mobile view is rather slow on my server [16:35:45] i see a "Read in another language" button [16:35:48] that linsk to a list [16:37:21] apt-get install memcached php-apc [16:38:16] $wgMainCacheType = [16:38:16] $wgParserCacheType = [16:38:16] $wgMessageCacheType = CACHE_ACCEL; [16:39:04] ;;;;;;; [16:39:43] NO;NO;NO; [16:40:50] much faster :D [16:41:27] so i should get to work with the code [16:41:29] ? [16:41:32] yep [16:42:27] just wondering, which php file has the code for the actual mobile page? [16:43:33] grep it?;) [16:47:40] all i managed to find were 83 translations of "Read in another language" [16:47:42] :P [16:47:45] ill keep looking haha [16:48:31] hmm, the all have a message name, right... [16:49:16] I found Resources.php, seems like this is it [16:54:25] MaxSem: BINGO [16:54:35] through some messing aorund [16:54:39] i found the place for the language list [16:54:46] in minervatempalte.php [17:02:24] MaxSem: what is the goal of this task? [17:02:36] disable the language list unless a flag is set? [17:03:20] display them on a separate page or dynamically on demand if JS is present [17:03:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=40678 [17:04:40] MaxSem: ah, so don't load the language list unless the button is pressed to list them [17:04:47] yep [17:08:03] crap, now i have to set up the printer to print my boarding passes [17:09:39] ....or i can have them scan my mobile phone [17:09:50] TECHNOLOGY [17:24:15] brion: Hello, can I become a betatester of the new iOS-app? [17:26:08] sjoerddebruin: that's a hard question right now. :) [17:26:25] our ad-hoc distribution slots all got used up in last year's various betas and they're not cleared out yet, so we can't add new people [17:26:56] we're trying to set up enterprise distribution for additional testing, but we have to double-check if we can have people who aren't internal staff on that [17:27:00] but.... i hope so :D [17:27:08] :( [17:27:18] yeah, thank apple's distribution policies [17:27:37] (on the other hand if you happen to be a registered, paid-up iOS developer you can compile and install it yourself....) [17:27:46] Okay, if you have more information later, ping me. :D [17:27:55] No. [17:28:17] Ehm, registered, but I’m not paying. :P [17:28:34] welcome to iOS hell :) [17:28:49] will definitely give a shout out if we can do more open betas... [17:29:15] Is it not possible to test it in the iOS-simulator? [17:29:25] ah it should be actually! [17:29:32] you got Xcode and everything set up? [17:29:54] Yes. [17:30:09] sjoerddebruin: git clone https://gerrit.wikimedia.org/r/apps/ios/wikipedia apps-ios-wikipedia [17:30:19] shouldn't be any external dependencies i think, it should build as-is [17:30:20] In the terminal? [17:30:23] yeah [17:30:30] then fire it up in xcode [17:31:37] MaxSem: Milestone 1: I managed to change the text of the button to YO MAMA! [17:31:40] just as a test [17:31:43] hahha [17:31:49] Working. :D [17:31:53] sehr gut [17:32:01] Thank you brion. :D [17:32:05] yay :D [17:32:31] It’s really basic. :P [17:32:51] yes, so far :) [17:32:55] that's why it isn't released yet :D [17:33:11] Full-native btw? [17:33:18] yep [17:33:22] well the text is in a web view there :) [17:33:27] Much better. [17:33:29] but the surrounding UI and logic is all native [17:39:31] yuvipanda: you about? i'm gonna do review on your last changes in a bit [17:39:50] will be out most of the rest of the week for holidays but i'll check in for quick review [17:39:56] brion: hey [17:40:03] brion: ok. [17:40:12] brion: should we self merge during the holidays or just let it be? [17:41:31] nah i'll do review, just pile up a few commits and ping me by email if you want anything poked in a hurry :) [17:42:46] brion: ok [17:42:55] brion: I'll be out for almost all of it too, btw :) [17:43:06] ok [17:43:39] i'll pick up some of the android work while you're out, will you be able to do occasional review on those? or should i just let them pile up until you're back [17:43:50] * brion waves [17:44:12] brion: I should be able to pop in now and then [17:44:15] brion: do not self merge :P [17:44:23] brion: add me as reviewer th ough [17:44:34] yuvipanda: brion should instead ask me to blindly +2? ;-) [17:44:44] hehe [17:44:45] yuvipanda: ok [17:44:52] James_F: heh, that's for mediawiki-config only :P [17:45:35] yuvipanda: Pah. I've never blindly +2'ed anything in -config. [17:45:48] yuvipanda: … mostly because I'm not a deployer, so don't have +2 rights there. ;-) [17:45:48] James_F: yet! [17:45:56] James_F: ah! :P [17:46:01] * brion adds `rm -rf /` to some commits for James_F [17:46:14] :-P [17:46:36] brion: you know that doesn't actually work with new rm's, right? [17:46:59] yuvipanda: i'll write my own 'rm' in perl [17:47:06] brion: hah! :D [17:47:18] brion: write it in php, replace with index.php [17:47:36] wfDeleteAllFiles() [17:48:11] brion: according to php convention it should be called echo_r() and take a parameter called 'force' that defaults to 'true' and deletes everything [17:48:24] lol [17:48:50] MaxSem: I've found the cde that renders that button, but where is the code that turns it into a [17:50:08] GEOFBOT, JS [17:54:09] ahhh [17:55:24] MaxSem: i see the comment about the bug [17:55:41] brion: so, when we do 2.3 compat, I'm just going to take out all the a nimations for anything preICS [17:55:45] I think that's good enough [17:58:51] yuvipanda: that's probably fair [17:58:58] brion: good :) [17:59:08] if we end up doing awesome transparency effects on something we'd probably ditch that for 2.3 too [17:59:11] brion: and we will classify Honeycomb as 'pre-ICS', since that makes things simpler. [17:59:16] the software compositing is slow as shit on old nexus one [17:59:18] brion: yup. 'graceful degradation' and all that [17:59:24] yeah [17:59:29] honeycomb: the version we wish didn't exist [17:59:34] and almost doesn't [17:59:54] brion: compositing for transparency, I don't think we ought to do it even in ICS+ [17:59:54] :P [18:00:00] mostly because that's a very iOS thing [18:00:10] eyyyyeee cannnnddyyyyyyy :) [18:00:13] brion: anyway, the saved pages stuff needs review first, I guess [18:00:15] we'll see if it ever seems relevant :) [18:00:16] brion: BLINK! [18:04:35] [18:04:46] brion: class="sparkle' [18:04:47] " [18:05:09] ? [18:15:56] mhurd: you starting up the office rig ? [18:16:04] yuvipanda: waiting on you to join [18:16:19] tfinc: beh, forgot. on it now [18:25:54] brion: I ended up writing my own for quick return instead of reusing the link I showed you the other day, since that was for the header view to be *inside* the scroller as well [18:26:05] aha [18:28:14] brion: wasn't too hard, although I'll have to much around with the hierarchy of layouts a bit more [18:31:36] (03CR) 10Siebrand: "i18n/L10n reviewed." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [18:32:00] (03CR) 10JGonera: "See my response in less/common/OverlayNew.less, patchset 2." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102547 (owner: 10Jdlrobson) [18:32:01] (03PS1) 10JGonera: Regression: bring back fixed headers in overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 [18:32:13] (03PS1) 10JGonera: Regression: make editor work in beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103371 [18:32:16] (03Abandoned) 10Yuvipanda: Have the shadow be under the search bar when showing results. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/96427 (owner: 10Yuvipanda) [18:32:19] (03CR) 10JGonera: [C: 04-1] Hygiene: Cleanup cookie usage in MobileFrontend (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103065 (owner: 10Jdlrobson) [18:32:25] oh wow that was slow [18:32:39] lolz [18:32:48] that was confusing [18:32:48] (03CR) 10Jdlrobson: Hygiene: Cleanup cookie usage in MobileFrontend (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103065 (owner: 10Jdlrobson) [18:32:52] (03CR) 10Jdlrobson: Regression: bring back fixed headers in overlays (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 (owner: 10JGonera) [18:32:54] (03CR) 10Jdlrobson: Regression: bring back fixed headers in overlays (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 (owner: 10JGonera) [18:32:57] haha [18:33:15] (03PS3) 10Theopolisme: View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 [18:33:16] (03CR) 10Theopolisme: View source of old revisions (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [18:33:39] (03CR) 10Jdlrobson: [C: 032] "Nice catch. My bad for merging the code (I think my local instance is having some cache oddities since I enabled $wgResourceLoaderStorageE" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103371 (owner: 10JGonera) [18:33:41] (03Merged) 10jenkins-bot: Regression: make editor work in beta and alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103371 (owner: 10JGonera) [18:33:46] (03CR) 10JGonera: Regression: bring back fixed headers in overlays (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 (owner: 10JGonera) [18:33:47] (03CR) 10JGonera: Hygiene: Cleanup cookie usage in MobileFrontend (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103065 (owner: 10Jdlrobson) [18:33:50] (03PS1) 10Dr0ptp4kt: Updates to documentation. We'll probably move this to MediaWiki.org. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103385 [18:33:55] (03PS5) 10Jdlrobson: Docs: Document overlays with KSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102547 [18:33:56] (03CR) 10Dr0ptp4kt: [C: 032] Updates to documentation. We'll probably move this to MediaWiki.org. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103385 (owner: 10Dr0ptp4kt) [18:33:57] (03Merged) 10jenkins-bot: Updates to documentation. We'll probably move this to MediaWiki.org. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103385 (owner: 10Dr0ptp4kt) [18:34:00] (03CR) 10Jdlrobson: [C: 04-1] "Will merge once the position-fixed class stuff is cleaned up." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 (owner: 10JGonera) [18:34:01] (03CR) 10Jdlrobson: Regression: bring back fixed headers in overlays (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 (owner: 10JGonera) [18:34:24] (03CR) 10Jdlrobson: [C: 04-1] "Looking great @Theopolisme! :D" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [18:34:26] (03PS3) 10Jdlrobson: Hygiene: Cleanup cookie usage in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103065 [18:34:27] (03PS4) 10Jdlrobson: Hygiene: Cleanup cookie usage in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103065 [18:34:58] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make saved pages selectable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103325 (owner: 10Yuvipanda) [18:38:49] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add functionality to delete selected pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103328 (owner: 10Yuvipanda) [18:39:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] Bump minVersion to ICS, not HoneyComb [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103337 (owner: 10Yuvipanda) [18:39:35] (03PS1) 10Cmcmahon: Styling makes file input invisible for when_present clause [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103393 [18:41:01] (03PS2) 10Cmcmahon: use send_keys instead of = to avoid corrupting file path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103393 [18:41:15] (03PS3) 10Cmcmahon: use send_keys instead of = to avoid corrupting file path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103393 [18:41:32] MaxSem: about to interview Aaron, can you send me the URL for his coding task again? [18:43:17] (03CR) 10Brion VIBBER: "I'm getting a crash on rotate. Emailed crash report to yuvi..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103344 (owner: 10Yuvipanda) [18:45:08] (03CR) 10Jhall: [C: 032] use send_keys instead of = to avoid corrupting file path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103393 (owner: 10Cmcmahon) [18:45:09] brion: i don't have no crash report yet.. [18:45:25] slow email is slow [18:45:37] brion: should've skyped it :D [18:45:39] or fb chat [18:45:51] (03Merged) 10jenkins-bot: use send_keys instead of = to avoid corrupting file path [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103393 (owner: 10Cmcmahon) [18:46:52] brion: hmm, other emails from other folks have showed up in the meantime :| [18:47:37] brion: i think section image association is working! [18:48:01] brion: got it [18:48:16] ah [18:48:27] just sent ya a hangout message too ;) [18:48:30] mhurd: woohoo [18:49:05] brion: how many times did you rotate? [18:49:12] brion: weirdly sometimes the webview just... is null :| [18:49:19] just once [18:49:22] brb [18:49:24] open article, rotate sidewise [18:50:55] jdlrobson: hey! to move it to skinmobilebeta do I just copy the entire function? [18:51:10] theopolisme: looking :) [18:51:54] theopolisme: best thing to do is prepareWarnings( BaseTemplate $tpl ) { parent::prepareWarnings( $tpl ); // your changes} [18:52:03] use inheritance [18:53:06] hmm, so how will that work? My changes essentially rewrite the function (well, not as much rewrite but add something smack-dab in the middle of it) [18:54:24] jdlrobson: ^ [18:54:57] theopolisme: you can still override it [18:55:02] it's just safer in case that function ever changes [18:55:08] Yeah, I see what you're saying [18:55:10] theopolisme: just copy the bit in $tpl->set( '_old_revision_warning', [18:57:32] (03PS3) 10Jdlrobson: Enable keyboard section toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [18:59:00] (03CR) 10Jdlrobson: [C: 031] "Hooman let me know if you're happy with these changes I have made to limit the code to beta." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [18:59:39] brb must make quesadilla [18:59:47] the cheese & tortilla gods demand it [19:00:19] SantaClaus: hello am i on the good list or bad list this year? Just wanted clarification.. [19:01:02] MaxSem: kaldari if you could look at https://gerrit.wikimedia.org/r/#/c/102043/ today that would be realll useful :) [19:01:34] jdlrobson: Don't I have to copy the entire code of the function, actually? Because otherwise it will unconditionally add the View source link? [19:06:47] Why is it that when I browse to en.wikipedia.org on my phone I get redirected to en.m.wikipedia.org, but the reverse is not true? [19:07:30] theopolisme: feel free to copy just make sure you run parent::prepareWarnings [19:08:59] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=58425 [19:09:33] tfinc: last sprint board can be closed now [19:09:34] oh FFS, it's a wontfix [19:10:03] yuvipanda: thanks [19:10:58] MaxSem: they unassigned my task b/c it was a little too challenging :P [19:11:11] GEOFBOT, bleh [19:11:23] do you feel you would've done this? [19:11:29] Krenair: I am working on a patch that makes mobile a registered skin. If this gets merged in theory it should be possible to run the vector skin on the mobile url once logged in [19:11:38] not sure, was confused and boggled by the JS [19:11:39] :P [19:11:42] e.g. no need for a redirect [19:12:05] kenanwang: you still need to trim https://trello.com/b/GPl5drAS/mobile-app-sprint-21-navigation-language [19:12:09] were @ 35 [19:12:36] ahh yes [19:12:40] GEOFBOT: are you more interested in PHP / JavaScript? Maybe we could descope the task into multiple easier tasks (MaxSem)? [19:12:57] hmmm [19:13:16] tfinc: one of the stories that I was going to trim is already in code review [19:13:23] jdlrobson: I'm more of a Python person than a web person [19:13:57] i really should learn more about js and php :P [19:14:00] kenanwang: you could trim it on iOS and bring it down to 30 :) [19:14:47] kenanwang: iOS already has more stories than Android (the spike for nav, backwards/forwards) [19:14:57] cool [19:14:59] done [19:16:59] jdlrobson, at that point why not just dump the mobile domains and set useskin=mobile based on user agent? [19:17:23] Krenair: caching… anon users still need the mobile site [19:17:37] Krenair: anyway in case you want to follow progress there - https://gerrit.wikimedia.org/r/102866 [19:17:44] and https://bugzilla.wikimedia.org/36636 [19:17:52] (03PS4) 10Theopolisme: View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 [19:29:22] (03CR) 10MaxSem: [C: 04-1] "Mostly minor problems." (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 (owner: 10Jdlrobson) [19:30:01] jgonera: hi there, how's the snow? Did you get anywhere with a new version of mediawiki.ui ? jdlrobson's patch is merged [19:30:11] GEOFBOT, if you would like to learn, we could find an easier task for you [19:30:57] spagewmf, I'll be working on it today [19:31:14] spagewmf, after I get something to eat [19:32:03] (03CR) 10MaxSem: Story 1465: Add a call to action on main pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 (owner: 10Jdlrobson) [19:39:46] MaxSem: sure [19:40:00] for now ill do some other tasks [19:43:40] (03PS9) 10Jdlrobson: Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 [19:48:07] ^ MaxSem [19:48:13] aha [19:51:56] (03CR) 10Jdlrobson: [C: 032] View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [19:52:43] (03CR) 10jenkins-bot: [V: 04-1] View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [19:56:40] (03CR) 10Jdlrobson: [C: 04-1] "Looks like this breaks QUnit tests. Please fix! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [19:56:57] jdlrobson: noticed that the test failed because we are passing an empty rvstartid [19:57:11] will fix [19:57:14] theopolisme: yup - should be easy to fix :) [20:00:04] (03PS5) 10Theopolisme: View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 [20:01:06] jdlrobson: that should fix it [20:01:34] looking [20:02:36] yuvipanda: figured out that crash? [20:02:54] brion: no, distracted with some Jared related emails. [20:02:56] (03PS6) 10Jdlrobson: View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [20:02:57] brion: will get to it in a minute [20:03:07] (03CR) 10Jdlrobson: [C: 032] View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [20:03:23] ok [20:03:25] no worries [20:03:35] brion: how does the code look otherwise?} [20:04:02] looks straightforward enough and it feels slick [20:04:04] i like :D [20:04:06] yay, looks like it worked :) [20:04:17] brion: :D [20:04:21] brion: the only thing that I need to add [20:04:24] brion: is that if you *stop* scrolling [20:04:31] brion: then it either neards to snap all the way back out, or back in [20:04:34] brion: depending on where it is [20:04:38] (03Merged) 10jenkins-bot: View source of old revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103334 (owner: 10Theopolisme) [20:04:45] brion: that's why there are the down and up/cancel event handlers :) [20:05:04] (03CR) 10MaxSem: [C: 04-1] "Throws exceptions, will fix myself." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 (owner: 10Jdlrobson) [20:05:14] aha [20:05:22] brion: that's what chrome's does [20:05:30] brion: it's impossible to be left in a 'half visible' state [20:05:39] thanks MaxSem [20:06:00] sensible [20:07:48] brion: also, the other card - attribution [20:07:55] brion: i'm wondering if I should do it natively or in HTML [20:08:07] brion: I don't see any reason doing it natively would give me an advantage [20:08:32] yuvipanda: yeah i'd think a link at the end of the document is probably reasonable [20:08:47] only reason to go native on there is to put it into one of our other menus [20:08:57] brion: yeah, and i don't think we are doing that [20:09:04] brion: we could also animate it, but that feels.. eh [20:09:04] (03PS1) 10Jdlrobson: Future proof ZeroOverlay [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103404 [20:09:17] watch the history expand, line by line! [20:09:23] brion: although there will have to be some communication, to deal with i18n [20:09:50] sure, inject the string and link target i guess [20:10:22] yeah [20:11:17] brion: have you read http://research.microsoft.com/en-us/people/mickens/thenightwatch.pdf [20:12:17] O_O [20:13:15] haha [20:14:33] brion: particularly like the comments about 'HCI people' and 'PHP programmers' [20:18:17] i have got to subscribe to this guy :) [20:18:44] brion: he has a bunch more [20:18:55] dr0ptp4kt, could you take a look at the few patches pls [20:18:59] brion: same guy, as hilarious https://www.usenix.org/system/files/1309_14-17_mickens.pdf [20:19:02] (03PS10) 10Jdlrobson: QA: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [20:19:30] (03CR) 10Jdlrobson: "Can this be merged yet with or without the typo in 'Ba(r)rack Obama'?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [20:19:36] yurik, which #s? [20:20:30] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/ZeroRatedMobileAccess,n,z [20:22:05] (03CR) 10Dr0ptp4kt: [C: 032] Removed bottom banner border color from CSS [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103188 (owner: 10Yurik) [20:22:10] (03Merged) 10jenkins-bot: Removed bottom banner border color from CSS [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103188 (owner: 10Yurik) [20:23:43] (03CR) 10Dr0ptp4kt: [C: 04-2] "This would create a mixed content weakness." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103320 (owner: 10Yurik) [20:27:15] (03PS4) 10Jdlrobson: Story 1508: Update talk, page previews and geonotahack to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101428 [20:41:46] jdlrobson, is that overlay stuff ready for review, or got some more tweaks on that (cc yurik). btw, i think i found the source of the datetime stamp thing for manifests. i submitted https://gerrit.wikimedia.org/r/#/c/103407/1/includes/resourceloader/ResourceLoaderModule.php and rebased the Special:Manifests stuff on top of it. [20:41:47] 01[13WikipediaMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/xgVYdA [20:41:47] 13WikipediaMobile/06master 1477271ce 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [20:42:11] dr0ptp4kt: btw, we set end of february as target date for our market release [20:42:17] jdlrobson, saw your other comments. agree we need to get the stuff to point at bits. [20:42:19] yuvipanda, thx [20:42:28] dr0ptp4kt: :) [20:46:25]