[00:00:28] (03CR) 10Brion VIBBER: "Note that it crashes a little more often on an older Galaxy Nexus, so we'll definitely need this fixed proper before we roll out on older " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103344 (owner: 10Yuvipanda) [00:00:33] brion: I'll think of something else, I guess. [00:00:37] bah [00:00:44] brion: how's the quickreturn smoothness? [00:01:05] yuvipanda: silky smooth [00:01:13] brion: woohoo! :D [00:01:15] way cooler than anything in the old app already :D [00:01:15] brion: even with flings? [00:01:19] brion: and super long apps? [00:01:25] brion: well, old app's beta also had this :P [00:01:31] brion: but it faded out [00:01:39] and was, of course, buggy on certain devices [00:01:41] hehe [00:03:09] yuvipanda: yeah i haven't found a scenario that looks choppy yet :D [00:03:26] (03PS2) 10Jdlrobson: KeepGoing tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103508 [00:03:30] brion: woo! [00:03:36] ok lemme try that next commit with the state forcing [00:03:38] brion: poor 2.3 users :D [00:03:44] hehe [00:04:07] (03PS3) 10Jdlrobson: Regression: bring back fixed headers in overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 (owner: 10JGonera) [00:05:25] (03CR) 10Jdlrobson: [C: 032] Regression: bring back fixed headers in overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 (owner: 10JGonera) [00:05:42] nice [00:05:43] mhurd: brion the prop=thumb API patch is available on enwiki now, btw. So you can get the thumb info with the initial request itself :) [00:05:59] (03Merged) 10jenkins-bot: Regression: bring back fixed headers in overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103368 (owner: 10JGonera) [00:06:00] yuvipanda: feels very natural, i like the updated quick return with state enforcement :D [00:06:03] ah awesommeeeee [00:06:06] :D [00:06:13] yuvipanda: no way!!! [00:06:16] brion: yeah, and also waits for a while before it disappears [00:06:23] (03CR) 10Brion VIBBER: [C: 032 V: 032] "works very nicely :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103509 (owner: 10Yuvipanda) [00:06:33] brion: I don't notice it unless I'm looking for it, because by then my eyes are halfway down the page [00:06:34] mhurd: :D [00:06:38] heh [00:06:39] mhurd: one less request! [00:06:44] yuvipanda: YES!!!! [00:06:52] mhurd: there's prop=image and prop=thumb, check it out [00:07:01] yuvipanda: k [00:07:03] sweeeeeet [00:07:05] mhurd: this means we can do the 'header image' thing may had in her mockups [00:07:21] oooooooh that's gonna be awesome [00:07:27] i'm looking forward to pretty pictures [00:07:27] brion: I'm also going to move the infobox to right after the *first paragraph*, rather than entire lead section [00:07:47] brion: wait till the ImageFilter controversy rises back from the dead... [00:07:48] :D [00:07:51] lol [00:07:56] (03CR) 10JGonera: [C: 04-1] "* Not enough margin between "This article needs your help!" and the button." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 (owner: 10Jdlrobson) [00:08:00] brion: I also wonder if Apple will bring that up again :D [00:08:04] until then, just ..... don't demo certain terms *cough* [00:08:18] yuvipanda: sweet! i need to update that and point to the css stuff u did [00:08:19] brion: well, it's probably not 'too soon!' for Adolf Hitler [00:08:21] so that's fine [00:08:24] lol [00:08:25] mhurd: yeah [00:08:43] mhurd: remember the CSS stuff there is only temp. eventually you'll get a blob from a server that will need periodic refreshing [00:08:44] yuvipanda: both in android repo now? [00:08:46] but for now, yeah, it works :) [00:08:51] yuvipanda: k [00:08:53] mhurd: the CSS stuff? [00:08:59] mhurd: CSS stuff is in the android repo, yeah [00:09:04] mhurd: JS and CSS bits. [00:09:14] mhurd: wikipedia/assets/* [00:09:22] yuvipanda: awesome thanks! [00:09:26] yeah feel free to just copy the files for now :D [00:09:27] mhurd: yw! [00:09:30] yup [00:09:39] yuvipanda: brion k [00:09:49] brion: mhurd I don't think JS will be *completely* reusable [00:09:52] although we can reuse bits [00:09:59] CSS should be fully reusable [00:10:04] yeah [00:10:09] the JS bits have been slightly different [00:10:12] but CSS is easy drop-in [00:10:18] woohoo! [00:10:22] brion: so the idea is to build the CSS out of LESS bits via RL [00:10:24] (03CR) 10Kaldari: [C: 032] KeepGoing tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103508 (owner: 10Jdlrobson) [00:10:30] +1 [00:10:33] jdlrobson, kaldari I'm going to bed now. tomorrow I'll mostly work EU hours but will pop in for a moment later to see if you need something, reply on gerrit if needed, etc. [00:10:38] brion: so we can easily set variables for things different between iOS and Android (fonts come to mind) [00:10:58] (03Merged) 10jenkins-bot: KeepGoing tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103508 (owner: 10Jdlrobson) [00:11:23] jgonera: so you got the main page stuff working? [00:11:31] jdlrobson, kaldari what time are you working tomorrow? leaving a bit early I suppose? [00:11:31] if so feel free to +1 :-) then have a good sleep :D [00:11:38] jgonera: affirmative [00:11:42] i'll probably leave around 4pm [00:11:44] jdlrobson, yes, it works, but I -1 :( [00:11:59] jgonera: ok i'll look at your -1 and fix what i can and hopefully kaldari can then merge it :) [00:12:05] ok [00:15:24] jgonera: the design was not the most helpful so this makes this a little trickier [00:15:34] why? [00:15:56] I mean, the font sizes are clearly the same as article font size, margin above the button is bigger [00:16:17] and the black line definitely should not be visible on every page below the header [00:16:46] https://www.dropbox.com/s/dszucdtul548a2k/Mobile-landingpage-06.png < jgonera [00:16:54] i was told i should just use the page list design pattern [00:16:55] brion: mhurd how's RTL support on iOS? [00:17:29] yuvipanda: so as i recall there is at least some basic support, but i don't think it does layout mirroring unless they just added it recently [00:17:35] so we may have to manually flip some things [00:17:43] the black line was already there - i just standardized on the color which in turn has made it a little darker [00:17:51] brion: for the CSS, RL will flip things for us [00:17:51] sure, jdlrobson, only that fonts are rendered bigger in the watchlist, different CSS context I suppose [00:18:06] jgonera: yeh i'll have a poke around [00:18:12] yuvipanda: really good. will have to spend some time to make sure things are done to leverage built-in RTL functionality [00:18:23] brion: mhurd sweet :) [00:19:45] yeah looks like the text all renders nice but i see mostly left-to-riught layouts with islands of right-to-left text in them (trying switching to arabic) [00:19:59] if we want to keep amir happy we'll have to flip a few things :D [00:20:07] but that's totally doable [00:21:24] jdl [00:21:25] jdlrobson: hmm [00:21:33] hmm? [00:21:41] brion: did you check out on Android 4.4 now you can force RTL layout with english? [00:21:50] sweet [00:22:00] kenanwang: hhm?? [00:22:01] easier than learning hebrew or arabic ;) [00:22:11] brion: I did that to test RTL on Android, put out a screenshot, and amir was so sad he submitted a patch to add hebrew translations :P [00:22:11] crap, how do i put my iPhone back to english now ;) [00:22:17] brion: apparently english RTL is terrible [00:22:19] haha [00:22:26] so one thing with the new cta text we removed the error messages on the signup pages if they type an incorrect password etc.? [00:23:00] well, i guess i just have to learn arabic now [00:23:47] brion: no time like the present :D [00:24:11] ahhhhh i found the right menu item [00:24:34] brion: mhurd hmm, so mobile web doesn't have a history link outright - but clicking the 'last modified' link takes them to historyu [00:24:40] brion: I guess we can do the same for the apps [00:24:51] *nod* [00:25:16] brion: we also have a 'last modified by' info, but I guess we don't need to expose that right now [00:25:39] brion: I also wonder if we could put it not at the bottom, but near the top [00:25:55] humanize that last-modified info eh [00:25:59] brion: like, under the title or something [00:26:06] "India, last modified 5 days ago" [00:26:08] or somesuch [00:26:35] brion: I'm thinking I'll just do it and see if a designer screams at me :P [00:26:42] yeah go for it :) [00:27:29] brion: it'll also help reinforce the 'hey people edit this thing!' bits [00:29:51] ya [00:30:45] jdlrobson: I'm just unable to create an account on beta labs right now... [00:43:28] ok i gotta buy cat food, see ya guys in a bit [00:44:28] (03PS18) 10Dr0ptp4kt: WIP: Experiment: Special:MobileWebApp and manifests for offline FF & Chrome, FFOS + CWS. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson) [00:45:09] (03CR) 10jenkins-bot: [V: 04-1] WIP: Experiment: Special:MobileWebApp and manifests for offline FF & Chrome, FFOS + CWS. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson) [00:45:10] (03CR) 10Dr0ptp4kt: WIP: Experiment: Special:MobileWebApp and manifests for offline FF & Chrome, FFOS + CWS. (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson) [00:49:32] (03PS1) 10Jhall: [QA] WIP Spoof physical geolocation for browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103512 [00:59:01] (03PS13) 10Jdlrobson: Story 1465: Add a call to action on main pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 [01:19:03] (03PS1) 10Yuvipanda: Perform QuickReturn at the same rate as scrolling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103515 [01:27:20] (03PS1) 10Yuvipanda: Prevent weirdasscrashes when rotating phone [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103516 [01:33:14] (03CR) 10Jdlrobson: [C: 032] "Works as advertised." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103506 (owner: 10MaxSem) [01:34:54] (03Merged) 10jenkins-bot: Don't display mobile view links on blacklisted pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103506 (owner: 10MaxSem) [01:40:35] (03PS6) 10Jdlrobson: Docs: Document overlays with KSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102547 [01:40:42] ^ kaldari [02:23:22] (03CR) 10Kaldari: [C: 04-1] Docs: Document overlays with KSS (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102547 (owner: 10Jdlrobson) [02:58:03] (03PS1) 10Yuvipanda: Make search bar visible when navigating to a new page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103520 [02:58:04] (03PS1) 10Yuvipanda: Move infobox to just below first paragraph, rather than lead [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103521 [07:29:10] (03PS3) 10Yuvipanda: Use empty placeholder while loading, CTA placeholder only for known missing images [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98579 (owner: 10Brion VIBBER) [07:37:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson) [07:48:36] hi jdlrobson [08:27:13] (03PS6) 10Jdlrobson: Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 [08:27:14] (03PS3) 10Jdlrobson: Offer the blue pill or the red pill [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 [09:40:02] YuviPanda: sent you an email! [10:20:10] !ask [10:20:15] !logs [11:04:29] Hi, I'm a GCI student, and I have a question about https://bugzilla.wikimedia.org/show_bug.cgi?id=58356. In the bug report, it indicated that the headings are still printed in English. However, I can't find the headers they are referring to. What are the headers in the mobile editor?