[05:24:58] marktraceur, YuviPanda: hmm, we just have it setup on the same subdomain...never really figured that part out. [05:25:12] Hah. [05:25:44] heh [05:25:55] i bet you can dig through some ops repo or the other and figure it out [05:26:05] but I don't think that'll help the person [05:26:15] marktraceur: are you not vacationing? [05:26:41] I am! [05:26:43] Well [05:26:45] I'm weekending [05:26:50] I finished Vacationing on Thursday [05:27:24] Oh, he's here. [05:27:49] Urgent: Can you try to explain what you're trying to do? [05:28:21] My issue is not auto detection. [05:30:04] from beginning, I wanted the desktop and mobile version on two different domains [05:30:42] I pointed m.xserve.org to the wiki directorary [05:31:24] Now, when i visit from mobile . It displays desktop version [05:31:35] Its autodetection problem [05:31:55] marktraceur: oh. I've a week left [05:32:12] but after visit, if i use mobile version from footer then it should display the mobile version [05:32:50] In this case, it still displays desktop version [05:33:11] So, its not autodetection [05:34:57] I want proper configuration of apache and guide [05:37:16] I am not using any rewrite rule [05:43:42] legoktm: Thoughts? [05:44:16] I thought it was done by detecting User-Agents, but I'm not really sure how to do that [05:44:40] https://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_browser_auto-detection [05:45:13] Urgent: did you try $wgMFAutodetectMobileView = true;? [05:46:09] :/ [05:49:51] Urgent: Did you see legoktm's reply? [05:50:00] 2013-12-29 - 21:44:16 I thought it was done by detecting User-Agents, but I'm not really sure how to do that [05:50:03] 2013-12-29 - 21:44:40 https://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_browser_auto-detection [05:50:06] 2013-12-29 - 21:45:13 Urgent: did you try $wgMFAutodetectMobileView = true;? [05:50:34] yep [05:50:47] did that not work? [05:50:52] I want apache configuration for this [05:50:57] no [05:51:15] do you have the apache mobile filter installed? [05:51:22] no [05:52:10] well that seems like the easiest way to do so [05:52:19] I'm not sure if its possible to do via mod_rewrite [05:52:29] I want that rewrite rule http://m.xserve.org/index.php?title=Main_Page to m.xserve.org [05:52:58] i also want m.xserve.org to have query string useformat=mobile [05:53:06] always [05:54:03] what i have done here is m.xserve.org and xserve..org are clone of each other [05:54:15] pointing to same directorary [05:54:41] Thats why they are showing desktop version on both [05:55:07] I want rewrite rule support [05:58:06] Can you install the Apache mobile filter? [05:58:19] http://www.apachemobilefilter.org/ [05:58:26] seems like that would be the easiest to get working [05:58:34] NO, its not vps(virtual private server) [05:58:50] I know [05:58:58] ok, well I'm not sure how to do it with a rewrite rule. [05:59:13] Wait. [06:00:11] http://forum.modrewrite.com/viewtopic.php?f=4&t=6555#p98879 [06:00:28] not so much similar [06:02:16] I want to paste a paragarh [06:02:23] may i here [06:02:31] !pastebin [06:02:36] Use a pastebin, dpaste.de [06:02:41] AGH fucking useless wm-bot2 [06:03:08] !pastebin is To avoid overflowing the channel with inane amounts of text, use https://dpaste.org/ or other awesome pastebin sites to share code, errors, and other large texts. [06:03:08] You are not authorized to perform this, sorry [06:03:22] Rabble rabble rabble [06:04:46] http://pastebin.com/J8qtC5Gk [06:06:19] if you could solve the desktop problem in the rewrite rule [06:06:25] i can use that [06:09:40] What? [10:22:34] (03CR) 10Siebrand: [C: 032] i18n: consistency tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104321 (owner: 10Shirayuki) [10:23:31] (03Merged) 10jenkins-bot: i18n: consistency tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104321 (owner: 10Shirayuki) [16:08:43] MaxSem, do you know why I keep getting "A database query error has occurred. This may indicate a bug in the software." on all non-special pages after updating core? [16:09:44] MaxSem, OK, nevermind, maintenance/update.php fixed it [16:54:35] (03CR) 10MaxSem: [C: 04-1] Warn user when attempting to switch to desktop without cookies (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme) [16:59:38] (03CR) 10MaxSem: Add "You're already logged in" information to Special:UserLogin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104378 (owner: 10M4tx) [17:21:20] (03PS1) 10Jdlrobson: i18n: Add message output format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104526 [17:21:30] (03CR) 10Jdlrobson: "Follow up in https://gerrit.wikimedia.org/r/104526" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102043 (owner: 10Jdlrobson) [17:26:30] (03CR) 10Siebrand: [C: 032] i18n: Add message output format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104526 (owner: 10Jdlrobson) [17:27:20] (03Merged) 10jenkins-bot: i18n: Add message output format [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104526 (owner: 10Jdlrobson) [17:45:08] (03CR) 10Jdlrobson: [C: 04-1] "Seems to cause a regression in stable - when I click edit on a page in stable and make changes, when the page reloads and I click the lang" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104168 (owner: 10Theopolisme) [17:52:03] (03CR) 10Kaldari: [C: 031] Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 (owner: 10Jdlrobson) [17:52:24] (03CR) 10Jdlrobson: [C: 04-1] "This code doesn't look like it has been tested at all - the page explodes dramatically." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104378 (owner: 10M4tx) [17:57:07] (03CR) 10Jdlrobson: [C: 031] "Leaving a +2 to MaxSem. You may want to address my points or not." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104382 (owner: 10Theopolisme) [17:58:45] jdlrobson: your imgur URL isn't working for me: http://imgur.com/dtqExbo,BCUdl4I,7m6Qahx [18:00:29] (03PS2) 10M4tx: Add "You're already logged in" information to Special:UserLogin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104378 [18:01:23] (03CR) 10M4tx: "Oh. It looks like I added that "->text()" by a mistake, after testing the changes. Already fixed; sorry then." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104378 (owner: 10M4tx) [18:02:53] (03CR) 10MaxSem: "I would also like to see the core message reused." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104382 (owner: 10Theopolisme) [18:11:31] kaity, do you or Moiz have the new hamburger icon handy? [18:11:41] yes [18:12:11] jgonera: https://www.dropbox.com/s/vuajohh2kvc83uv/menu-icon.svg [18:12:32] kaity, thanks! [18:12:32] thank you juju! [18:12:45] ! [18:20:02] kaldari: shouldn't we just rename notifications.js to toast.js or notify.js now ? [18:22:01] sounds reasonable to me. is 'toast.js' ok with everyone? jgonera MaxSem [18:22:19] kaldari, jdlrobson I was going to do the same thing in this patch ;) yes, toast.js sounds good [18:22:22] kaldari, if you can, please change the name in M.define() too [18:22:39] will do [18:22:39] thanks! [18:22:50] (03CR) 10Jdlrobson: [C: 04-1] "As discussed in IRC lets rename to toast.js instead." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104174 (owner: 10Kaldari) [18:24:00] MaxSem: hey max! quick question - tomasz said you'd probably know what api queries i could use to get back list of all languages & list of languages a given article is available in. can you give me examples? [18:24:20] heh, web team discussed it on Friday:) [18:24:40] 1 sec [18:33:40] mhurd, https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=languages&prop=langlinks&titles=Barack%20Obama [18:33:47] jdlrobson: Also, I'm a bit confused about our file naming conventions. Half the files in js/common/ begin with a capital letter and half of them don't, but I haven't figured out any rhyme or reason to it. [18:34:07] should it be Toast.js or toast.js? [18:34:12] thanks MaxSem! [18:36:27] kaldari: toast.js fine i think [18:36:37] actually let me chekc [18:36:47] my bad Toast.js [18:36:53] basically replicate what happens in the file [18:37:09] The capital letter is used for 'classes' that can be reused [18:37:30] starting with a lowercase means run some stuff [18:37:53] I thought that might be the case, but it was inconsistant [18:38:11] (03CR) 10Jdlrobson: [C: 04-1] On "File does not exist" disable edit, enable upload (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [18:38:40] kaldari: if not documented on coding conventions it should be :) [18:52:54] jdlrobson: hmm, the mobile coding conventions actually suggests that JS modules/classes should be camel-case rather than capitalized :P [18:53:20] i.e. "moduleName' [18:53:23] (03PS1) 10JGonera: Story 1512: Update the chrome header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104539 [18:53:23] (03PS1) 10JGonera: Hygiene: Update LESS variable names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104540 [18:53:53] and the file name should match [18:53:53] (03CR) 10JGonera: [C: 04-1] "Still some issues with border margins. Alternative at https://gerrit.wikimedia.org/r/#/c/104539/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103618 (owner: 10Jdlrobson) [18:54:42] jgonera: can we get https://gerrit.wikimedia.org/r/103570 merged :) [18:54:50] kaldari: i'm looking now at the guidelines [18:55:03] https://www.mediawiki.org/wiki/MobileFrontend/Coding_conventions#Modules [18:55:30] kaldari: yeh that could be made clearer - let me edit [18:55:50] Do we want to change that to be "M.define( 'ModuleName' )" instead? [18:56:23] jdlrobson, I guess, if nothing got broken since patchset 8 when I last reviewed ;) [18:56:47] MaxSem: https://gerrit.wikimedia.org/r/#/c/104210/3/includes/skins/SkinMobileBeta.php "mobileaction gets stripped before Varnish kicks you back to mobile site" are you sure? It seemed to work when I was testing this... [18:57:24] (03CR) 10JGonera: [C: 032] Hygiene: LESS file reorg (killing enwp.less) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103570 (owner: 10Jdlrobson) [18:57:46] (03Merged) 10jenkins-bot: Hygiene: LESS file reorg (killing enwp.less) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103570 (owner: 10Jdlrobson) [18:58:05] theopolisme, do you have a varnish with WMF VCL set up?;) [18:58:21] Heh okay I see what you're saying :P [18:59:05] (03CR) 10Brion VIBBER: [C: 032 V: 032] "merge; new additions coming soon!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/103858 (owner: 10Mhurd) [18:59:26] How do you propose I test that then? instructions anywhere? [19:00:47] kaldari, "Start constructor functions with capital letters." I should specify that a module can be capitalized if the only thing it defines is a class/constructor [19:01:31] kaldari, but yeah, in this case it's toast.js because it doesn't expose the class itself [19:02:18] MaxSem: ^ [19:02:45] OK [19:03:09] kaldari: updated [19:04:30] jdlrobson: did you see jgonera's comments above? [19:05:22] jdlrobson, I updated your update ;) https://www.mediawiki.org/w/index.php?title=MobileFrontend/Coding_conventions&action=history [19:05:38] (03PS4) 10Theopolisme: Show "already logged-in" notice at Special:UserLogin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104382 [19:05:50] see if this is clearer [19:05:50] (03CR) 10Theopolisme: Show "already logged-in" notice at Special:UserLogin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104382 (owner: 10Theopolisme) [19:06:48] aren't wikis great.. ;-) [19:07:22] yeah, I almost got an edit conflict, if I only had been a minute faster [19:08:12] can someone take my word for it and +2 https://gerrit.wikimedia.org/r/#/c/104122/ [19:09:33] (i promise i'll move it out to a new repo soon) [19:12:17] (03CR) 10JGonera: [C: 032] Hygiene: Gerrit tool [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104122 (owner: 10Jdlrobson) [19:12:55] (03Merged) 10jenkins-bot: Hygiene: Gerrit tool [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104122 (owner: 10Jdlrobson) [19:16:02] theopolisme, I don't think it's easily testable as it relies on WMF infrastructure, however I can make an educated guess when I see the code:) [19:16:17] (03CR) 10JGonera: [C: 032] Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 (owner: 10Jdlrobson) [19:16:38] Okay. I guess what will need to happen is that will just need a different approach [19:16:58] grr why won't everyone just enable JavaScript, that would make life so much easier ;) MaxSem [19:16:58] I'll work on that in a little while [19:17:07] (03CR) 10Jdlrobson: "Since this patch is pretty much the same as https://gerrit.wikimedia.org/r/#/c/104378/2 I am going to flip a coin to choose which to merge" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104382 (owner: 10Theopolisme) [19:17:21] (03CR) 10Jdlrobson: "Since this patch is pretty much the same as https://gerrit.wikimedia.org/r/#/c/104382/ I am going to flip a coin to choose which to merge." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104378 (owner: 10M4tx) [19:17:22] even if they do, they might have their JS not loaded due to mobile conditions [19:17:59] time for dinner, will be back [19:18:03] MaxSem: yeah, I was joking [19:18:08] (03CR) 10Jdlrobson: [C: 032] "Merged after coin toss." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104382 (owner: 10Theopolisme) [19:18:49] (03Abandoned) 10Jdlrobson: Add "You're already logged in" information to Special:UserLogin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104378 (owner: 10M4tx) [19:19:21] (03Merged) 10jenkins-bot: Show "already logged-in" notice at Special:UserLogin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104382 (owner: 10Theopolisme) [19:20:22] jdlrobson: good thing you did that regression check on the language overlay... i just realized that the whole thing dies dramatically if the language doesn't have any variants! Easy fix, but *kinda* important [19:24:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok confirmed once I 'mvn install'ed from the right repo. :P :) Merging this for now, will clean up any remaining issues in future commits." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103626 (owner: 10Yuvipanda) [19:28:31] (03CR) 10Brion VIBBER: [C: 032 V: 032] Refactor transition animation code to avoid duplicates [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103628 (owner: 10Yuvipanda) [19:29:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] Increase number of threads for Searching [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103733 (owner: 10Yuvipanda) [19:31:29] (03CR) 10Brion VIBBER: [C: 032 V: 032] Show network error only if it is actually a network error [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/103735 (owner: 10Yuvipanda) [19:36:53] (03CR) 10Hoo man: "In general it would be nice if we could disable section toggling altogether." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [19:39:46] (03PS10) 10Jdlrobson: Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 [19:39:57] (03CR) 10Jdlrobson: [C: 032] Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 (owner: 10Jdlrobson) [19:41:17] (03Merged) 10jenkins-bot: Hygiene: Kill SkinMobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102853 (owner: 10Jdlrobson) [19:42:18] eek.. jgonera on stable now if i click edit and cancel i see two prompts asking me if i want to abandon my edit :-S [19:42:58] fine in beta [19:43:58] (03PS10) 10Jdlrobson: Update page previews and geonotahack to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101428 [19:46:20] jdlrobson: do I need to update the tests for getPageLanguages? [19:46:45] theopolisme: tests will need to pass so i guess so :) [19:47:01] if you can avoid changing them even better [19:47:20] Well, the problem is the tests that check the raw result of the api [19:48:41] (03Abandoned) 10Kaldari: HYGIENE: Making sure people don't confuse the two notification systems. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104174 (owner: 10Kaldari) [19:49:23] Do I need to literally paste in that long horrendous API result? Because I will if I need to, I suppose... jdlrobson [19:50:21] theopolisme, just trim it to a minimum example [19:51:00] theopolisme: well if the API result has changed then you should be able to just change the mock in the test [19:51:08] but not actually edit the actual test [19:52:12] Well I'm looking at `sinon.stub( PageApi.prototype, 'get' ).returns( $.Deferred().resolve( {` in `QUnit.test( '#getPageLanguages'` [19:54:17] mhurd: ok so undo https://gerrit.wikimedia.org/r/#/c/103858/ and you'll merge on top? [19:54:46] brion: ya! [19:55:06] (03PS1) 10Brion VIBBER: Revert "Added sectionImage associations to core data store." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/104552 [19:55:06] ok let's see if that helps [19:55:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] Revert "Added sectionImage associations to core data store." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/104552 (owner: 10Brion VIBBER) [19:55:47] (03CR) 10Jdlrobson: [C: 04-1] Add short-curcuit in api.getTokens for tokens availble in user.tokens (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104160 (owner: 10Kaldari) [19:56:04] theopolisme: looking [19:56:27] Thanks. qunit is new to me (as is sinon), so I guess I'm just a bit confused :) [19:56:33] theopolisme: updating the stub should be fine yes [19:56:50] simon simply intercepts the normal function call and allows you to make it do other things [19:58:29] Another thing, jdlrobson... It looks like these tests are in english only, would it make sense to test the variants somehow? (sounds like a FIXME to me) [19:58:41] theopolisme: yeh if you can add a test for variants that would be great [19:58:49] simply stub the result to return variants in it [19:59:09] Okay [19:59:09] Will do [20:00:57] (03PS1) 10Mhurd: Added sectionImage associations to core data store + TOC menu! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/104615 [20:01:09] brion: ^ [20:01:16] brion: hope this works!!! [20:01:24] whee [20:01:55] brion: i have to run. i'll be back thursday :) [20:02:07] ok i'll comment & tweak if necessary :D [20:02:10] have fun! [20:02:32] MaxSem: can you reply to this bug? https://bugzilla.wikimedia.org/show_bug.cgi?id=58321 i don't know enough about the subject matter [20:03:09] thanks brion! later! [20:07:18] gotta charge, ping me if needed before I'm back [20:08:19] jgonera: are you looking at upload behavior? I'm going to head for lunch soon (maybe 30 mins) [20:08:56] (03PS2) 10Jdlrobson: Hygiene: Give feedback when topic added to talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103871 [20:08:56] (03PS1) 10Kaldari: Making sure people don't confuse the two notification systems. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104653 [20:10:58] dr0ptp4kt: any problems with me rebasing the app stuff? [20:11:38] jdlrobson: go for it. and good luck [20:15:21] (03PS5) 10Kaldari: Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104160 [20:15:56] PhantomJS is really cool! [20:17:41] (03CR) 10Kaldari: Add short-curcuit in api.getTokens for tokens availble in user.tokens (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104160 (owner: 10Kaldari) [20:25:19] jdlrobson, are you a code in mentor? [20:25:34] MaxSem: yup what's up [20:26:02] (03PS29) 10Jdlrobson: Experiment: Special:MobileWebApp and manifests for offline FF & Chrome, FFOS + CWS. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 [20:26:13] (03PS1) 10Jdlrobson: Hygiene: Break out ajax pages RL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104659 [20:26:13] dr0ptp4kt: rebase complete [20:26:21] jdlrobson, I see that two people are working on same tasks, Theo and M4tx [20:27:23] MaxSem: which task - i've seen this a bit too - they are not mention to work on a task unless they have it assigned to themselves [20:27:23] *they are not meant to work.. [20:28:10] The problem is GCI only lets us assign ourselves to one task at a time [20:28:45] When I'm inspired I tend to do multiple tasks before code review is completed :p [20:29:11] jdlrobson, https://gerrit.wikimedia.org/r/104378 vs https://gerrit.wikimedia.org/r/104382 [20:30:12] (03PS2) 10Jdlrobson: Making sure people don't confuse the two notification systems. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104653 (owner: 10Kaldari) [20:30:12] MaxSem: i merged one of them by coin toss [20:30:32] theopolisme: should make sure you only work on one problem at a time and ensure that everyone following the bug report can see you are working on it [20:30:39] i think with this bug it was implied you were working on it but not 100% clear [20:31:54] jdlrobson, other than the skin parent class name change and the user of location.hash, did anything else "significant" change in the rebase of 100919? [20:32:30] yeah, understood completely. GCI will be over in a week or so, then this should become less of a problem (I still would really enjoy working on MobileFrontend, if that's okay with you...) [20:32:31] (03CR) 10Jdlrobson: [C: 032] Hygiene: Making sure people don't confuse the two notification systems. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104653 (owner: 10Kaldari) [20:32:54] theopolisme: we would love you to continue working on MobileFrontend :) [20:33:19] we just don't want to get into the situation where one of us is fixing a bug and you are as well - we all need to communicate better :) [20:34:50] kaldari, what;s your card supplementary to https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1583 ? [20:35:00] (03CR) 10Jdlrobson: [C: 04-1] "My test comment was neglected.. was this on purpose?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104160 (owner: 10Kaldari) [20:35:47] dr0ptp4kt: i broke out a smaller patch so that can be merged quicker [20:35:56] i didn't touch your code though [20:36:03] just made sure it rebased okay [20:36:18] jdlrobson: absolutely, i'll make sure to comment on bug reports before doing anything [20:36:36] sweet :) [20:37:37] jdlrobson: do you know how i can get qunit to be more verbose? I'm getting a Failed assertion: return augmented language links, expected: [object Object],[object Object],[object Object], but was: [object Object],[object Object],[object Object] ...which isn't very helpful... [20:38:17] do a console.log [20:38:17] JSON.stringify( jsonObj ) < [20:43:21] I'm leaving for lunch and be back online in about 40 mins - anyone need anything? [20:44:22] also jgonera kaldari bug i suspect we'll need to fix before next deploy https://bugzilla.wikimedia.org/show_bug.cgi?id=59140 [20:45:08] (03PS2) 10Jdlrobson: Hygiene: Break out ajax pages RL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104659 [20:48:25] (03PS3) 10Jdlrobson: Hygiene: Making sure people don't confuse the two notification systems. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104653 (owner: 10Kaldari) [20:48:25] (03CR) 10Jdlrobson: [C: 032] "wake up jenkins!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104653 (owner: 10Kaldari) [20:49:46] (03PS7) 10Jdlrobson: Register mobile skin, offer users the ability to change it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 [20:50:26] (03CR) 10Jdlrobson: [C: 04-2] "Will send mail to wikitech to see if this is acceptable." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [20:52:39] (03PS4) 10Theopolisme: Add support for language variants in LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104168 [20:53:49] jdlrobson: ^ when you get back :) [21:06:59] (03PS2) 10MaxSem: Add variable to disable WAP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103658 [21:08:09] (03CR) 10MaxSem: Add variable to disable WAP (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103658 (owner: 10MaxSem) [21:13:04] (03PS6) 10Kaldari: Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104160 [21:15:25] (03CR) 10Dr0ptp4kt: [C: 031] Add variable to disable WAP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103658 (owner: 10MaxSem) [21:24:49] (03CR) 10jenkins-bot: [V: 04-1] Experiment: Special:MobileWebApp and manifests for offline FF & Chrome, FFOS + CWS. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson) [21:29:14] (03PS1) 10JGonera: Remove unnecessary confirm dialogs in stable editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104670 [21:30:15] (03Merged) 10jenkins-bot: Hygiene: Making sure people don't confuse the two notification systems. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104653 (owner: 10Kaldari) [21:42:04] kaldari, what's your card supplementary to https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1583 ? [21:42:23] oh yeah, let me find it... [21:42:39] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1586 [21:43:21] MaxSem: just moved it to the currentl iteration and into Ready for Dev [21:43:55] hmm, actually it won't allow me to move it to that column. I guess kenan or awjr have to do that [21:45:29] thanks [21:46:48] (03CR) 10Jdlrobson: [C: 032] Add support for language variants in LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104168 (owner: 10Theopolisme) [21:46:49] kaldari, jdlrobson & jgonera, any thoughts on how ^^ should be implemented, config variable wgCoordinates = [41,-138] ? [21:47:13] MaxSem: json would probably be better wgCoordinates { latitude: longitude, [21:47:28] allows future extending with things like altitude etc [21:47:52] (03Merged) 10jenkins-bot: Add support for language variants in LanguageOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104168 (owner: 10Theopolisme) [21:48:33] MaxSem, jdlrobson what is it about? I mean, I know which bug, but what would that config var do? [21:48:49] jgonera: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1586 [21:49:09] jdlrobson MaxSem does this from CentralNotice mean anything to you? It just started showing up, and I don't see any likely culprits in recent merge history: https://bugzilla.wikimedia.org/show_bug.cgi?id=59143 [21:49:26] oh, ok, so this would be something that we could pull from mw.config? [21:49:51] yep jgonera [21:50:11] then I guess what jdlrobson said sounds OK [21:50:28] I mean, not JSON as a string, just a regular JS object would be nice (if mw.config supports that) [21:51:31] it does [21:53:46] chrismcmahon, result of recent refactoring, fixing [21:54:14] thanks MaxSem, looked like a typo [21:56:55] MaxSem: does GeoData currently store any other data besides lat and long? [21:57:15] (03PS1) 10MaxSem: Ensure that EnableMobileModules hook always gets an OutputPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104672 [21:57:15] thanks chrismcmahon for flagging! [21:57:35] MaxSem: is that ever the case? [21:57:40] (obviously the bug is happening but i'm sure someone told me that parameter is deprecated) [21:57:56] chrismcmahon, ^^ [21:57:56] jdlrobson, see the bug;) [21:58:16] kaldari, https://www.mediawiki.org/wiki/Extension:GeoData#Parser_function [21:58:16] MaxSem: I saw the bug [21:58:16] i just don't get it [21:58:56] jdlrobson, https://gerrit.wikimedia.org/r/#/c/104670/ [21:58:56] jgonera: yeh i saw [21:58:59] mmm, if that parameter is deprecated it's not geting passed a variable?:P [21:59:19] gerrit is my bitch [21:59:19] ;) [21:59:38] MaxSem: so that's wrong.. [21:59:51] wfRunHooks( 'EnableMobileModules', array( $out, $this->getMode() ) ); should be wfRunHooks( 'EnableMobileModules', array( $this->getOutput(), $this->getMode() ) ); [22:00:22] (03CR) 10Jdlrobson: [C: 04-1] "wfRunHooks( 'EnableMobileModules', array( $out, $this->getMode() ) );" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104672 (owner: 10MaxSem) [22:00:44] jdlrobson, you've killed the code similar to what I've reintroduced in my refactoring [22:01:04] kaldari, I'm not sure that we really should pollute page HTML with all kinds of additional stuff [22:01:38] kaldari: MaxSem is it clear what is being lightning deployed today? [22:01:59] https://gerrit.wikimedia.org/r/#/c/103581/ [22:02:19] also config change https://gerrit.wikimedia.org/r/#/c/103611/ [22:02:42] ok [22:03:40] jdlrobson, core skins do the same [22:04:20] meh, just use context overrides from SkinTemplate [22:06:03] (03PS2) 10MaxSem: Ensure that EnableMobileModules hook always gets an OutputPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104672 [22:06:39] (03CR) 10jenkins-bot: [V: 04-1] Ensure that EnableMobileModules hook always gets an OutputPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104672 (owner: 10MaxSem) [22:08:23] kaity: jgonera i replied about the special page headers - i really think we should defer this for next iteration - the existing headers are already proving complicated [22:08:23] would appreciate your thoughts [22:08:53] jdlrobson, I agree, I would just style them like we style overlays for now [22:09:44] MaxSem: I'm fine with just lat and long [22:10:25] i just want to do the minimum work for special page headers and then switch to the new ones next iteration (which may delay overlay push but hey i think it's warranted here..) [22:12:26] hey folks. i was exploring Experimental yesterday... really exciting bunch of features! [22:12:58] jdlrobson - ok replying to email [22:13:17] ragesoss: which ones in particular? [22:13:27] I agree that we shouldnt rush search to special pages, lets worry about that much later [22:13:43] one thing i noticed: on the user profile page at the bottom, the Talk link goes to the non-editable version instead of the one where you can reply and post new topics. [22:14:02] yurik: dr0ptp4kt MaxSem still looking for one of you to get this +2'ed please https://gerrit.wikimedia.org/r/103658 [22:14:47] ragesoss: yeh we need to wrap up the profile work, but it should open the same talk overlay as elsewhere [22:15:04] although talk work as been put on hold for a bit while i try and convince maryana and co that they want flow on mobile :) [22:15:04] jdlrobson: the last-edited thing at the top of articles... user profiles in 255 characters... talk pages that are usable! [22:15:04] jdlrobson: Do you have rights to move cards into Ready for Dev in Mingle? [22:15:21] can't seem to find kenan or awjr [22:15:48] ragesoss: the 255 characters part of the page got a bit of hate :( [22:15:53] jdlrobson: gave my +1 a little earlier. yurik, you mind looking at MaxSem's patch 103658 to make sure it makes sense? it will be shortening the cache lifetime of the WML pages, and then once the messaging goes out about deprecation of wml, i gather the switch will be flipped [22:16:09] someone was concerned we were reinventing user pages - which i guess we are but it was painted in a negative light) [22:16:17] kaldari: yup which one needs moving? [22:16:28] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1586 [22:16:28] for Max [22:16:43] kaldari: done :) [22:16:50] although I think we need to estimate it :) [22:16:59] 3 [22:17:04] I give it a 5 [22:17:04] . [22:17:04] any other bids? [22:17:28] (03CR) 10Yurik: [C: 031] Add variable to disable WAP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103658 (owner: 10MaxSem) [22:17:42] OK, I guess 3 works :) [22:17:48] http://jitsu.instance-proxy.wmflabs.org/94717 :P [22:18:01] another nit... equal width images aren't ideal for recent uploads in the profile. I'd much prefer a justified layout with fixed height and multiple images per row. [22:18:11] that page gives me an error :( [22:18:36] ragesoss, at least not panoramas that give you a horizontal line:) [22:18:46] jgonera: kaldari pleeeeassseeee https://gerrit.wikimedia.org/r/101428 [22:18:57] (and friends) [22:19:08] the less i see of the old overlay design the happier i am [22:19:14] jdlrobson, I'm going through the back button in uploads now [22:19:27] jgonera: ok that's more important i'm happy with that :) [22:20:26] i tried a superwide, then supertall upload on test.wiki, and realized then that the uploads part is Commons-only [22:20:29] OK, let me test [22:21:01] (which is fine, unless you're me trying to test) [22:21:20] (03CR) 10JGonera: [C: 04-1] "Cool! Seems to be working as expected, but I have a few doubts. I'd be grateful if you could explain some of the decisions so that we can " (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson) [22:21:31] (03CR) 10Jdlrobson: [C: 032] Remove unnecessary confirm dialogs in stable editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104670 (owner: 10JGonera) [22:21:32] jdlrobson: sorry I missed your test comment in https://gerrit.wikimedia.org/r/#/c/104160/, should be better now [22:22:07] (03Merged) 10jenkins-bot: Remove unnecessary confirm dialogs in stable editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104670 (owner: 10JGonera) [22:23:16] (03CR) 10Jdlrobson: [C: 04-2] "You are now running outputPage twice.. (outputMobilePage runs outputPage)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104672 (owner: 10MaxSem) [22:24:53] (03CR) 10JGonera: [C: 032] Update page previews and geonotahack to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101428 (owner: 10Jdlrobson) [22:25:03] (03PS3) 10MaxSem: Ensure that EnableMobileModules hook always gets an OutputPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104672 [22:25:25] (03PS5) 10JGonera: Update Talk overlay to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103854 (owner: 10Jdlrobson) [22:25:28] MaxSem: there is a reason outputPage runs at the end... [22:25:30] (03CR) 10jenkins-bot: [V: 04-1] Update Talk overlay to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103854 (owner: 10Jdlrobson) [22:25:32] (03Merged) 10jenkins-bot: Update page previews and geonotahack to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101428 (owner: 10Jdlrobson) [22:25:51] jdlrobson: what do you think about updating the title specs on special pages? [22:26:09] which is... [22:26:10] ? [22:26:20] jdlrobson, https://gerrit.wikimedia.org/r/#/c/103854/ needs rebase [22:26:30] jgonera: gerrit is my bitch on it ;-) [22:26:44] (03CR) 10Jdlrobson: [C: 032] Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104160 (owner: 10Kaldari) [22:27:19] (03Merged) 10jenkins-bot: Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104160 (owner: 10Kaldari) [22:30:44] jdlrobson: https://gerrit.wikimedia.org/r/#/c/101428/ looks good. Already got +2ed by Juliasz though :) [22:31:58] (03PS1) 10JGonera: Truncate title if too long in page preview overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104678 [22:34:43] kaldari, don't start spelling my name like Emily does [22:35:23] oops :) [22:36:06] I still mispell Tomasz's name as Thomasz on occassion [22:36:45] damn Polish spellings ;) [22:37:19] MaxSem: actually now i look at it outputMobilePage is kinda pointless... [22:37:24] I can understand that, but the English spelling of my name doesn't have any "a", nor is A close to U on keyboard [22:37:32] MaxSem: but basically the purpose of making it run first was to set targets [22:37:37] but targets is set to mobile unconditionally now [22:37:43] still, she manages to consistently misspell my name in this exact way [22:37:44] lemme do a fix up.. [22:38:46] i'd like to move stuff around so it's easier to follow [22:40:07] your right, apparently Julias doesn't exist. Good think I never had to write any letters to Ceasar [22:40:20] kaldari, https://gerrit.wikimedia.org/r/104679 :) [22:42:48] MaxSem: Why not use the MakeGlobalVariablesScript hook? [22:42:54] kaldari, because I need ParserOutput [22:43:09] (03PS4) 10Jdlrobson: Ensure that EnableMobileModules hook always gets an OutputPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104672 (owner: 10MaxSem) [22:43:09] MaxSem: unless i'm missing something ^ [22:44:17] MaxSem: is anyone using EnableMobileModules? [22:44:35] otherwise I'd suggest killing it and adding a hook BeforePageDisplayMobileBeta if necessary [22:45:53] (03CR) 10Jdlrobson: [C: 04-1] "No point in reviewing until dependency merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101123 (owner: 10Jdlrobson) [22:46:14] jdlrobson, http://code.ohloh.net/search?s=%22EnableMobileModules%22&browser=Default&fp=395433&projSelected=true&mp=1&ml=1&me=1&md=1&filterChecked=true [22:46:52] CentralNotice can easily be updated to use it [22:47:07] i think they do it in stable anyway [22:47:25] MaxSem: alpha/beta can also be derived from OutputPage via getSkin [22:50:04] (03CR) 10Jdlrobson: [C: 031] Ensure that EnableMobileModules hook always gets an OutputPage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104672 (owner: 10MaxSem) [22:51:23] (03CR) 10Jdlrobson: [C: 032] Truncate title if too long in page preview overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104678 (owner: 10JGonera) [22:51:57] (03Merged) 10jenkins-bot: Truncate title if too long in page preview overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104678 (owner: 10JGonera) [22:53:16] kaldari: i'm moving the bug about the edit token back to the backlog - i mean we've kinda done it but the bug isn't resolved and can't be resolved yet [22:53:16] does that make sense? [22:53:36] yeah [22:53:36] or do we want to open a more specific bug? [22:53:56] this would also make sense to me [22:54:06] You could open a more specific bug about making mw.user.tokens support all token types [22:54:15] yeh i think that makes sense [22:54:21] is a bug for that open? [22:54:29] not that I know of [22:55:04] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson) [22:55:58] (03PS1) 10MaxSem: Restore error messages on account creation page [extensions/MobileFrontend] (wmf8) - 10https://gerrit.wikimedia.org/r/104682 [22:56:36] (03CR) 10jenkins-bot: [V: 04-1] Restore error messages on account creation page [extensions/MobileFrontend] (wmf8) - 10https://gerrit.wikimedia.org/r/104682 (owner: 10MaxSem) [22:57:59] (03CR) 10MaxSem: [C: 032 V: 032] Restore error messages on account creation page [extensions/MobileFrontend] (wmf8) - 10https://gerrit.wikimedia.org/r/104682 (owner: 10MaxSem) [22:58:20] grrrit-wm, pwn3d! [22:58:35] Is Kenan not working today? I haven't seen him since stand-up. [22:58:46] kaldari: done [22:58:57] kaldari: yeh me neither - he seems to be on email [23:00:14] kaity: any sign of the design for this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=51482 ? [23:01:58] jdlrobson: oops, I'll get to you by end of day [23:02:17] Kaity: Do you know anything about what the CTA for https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1516 is supposed to look like, or should I email Kenan? [23:03:22] kaity: ^ (in case capitalization matters in IRC) [23:03:56] kaldari: umm email kenan, not sure [23:04:00] will do [23:22:22] (03PS6) 10JGonera: Update Talk overlay to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103854 (owner: 10Jdlrobson) [23:24:02] jdlrobson, I'll merge the new talk overlay, change in styling looks mostly ok, I guess we have to work on it more anyway if we want to push it to stable [23:24:25] (03CR) 10JGonera: [C: 032] Update Talk overlay to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103854 (owner: 10Jdlrobson) [23:25:06] (03Merged) 10jenkins-bot: Update Talk overlay to use new overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103854 (owner: 10Jdlrobson) [23:28:15] (03CR) 10Jdlrobson: [C: 032] "We can fix the nearby icon later (I have a followup patch for that)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104539 (owner: 10JGonera) [23:28:48] jdlrobson, what icon? [23:28:52] (03Merged) 10jenkins-bot: Story 1512: Update the chrome header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104539 (owner: 10JGonera) [23:28:55] oh [23:28:59] nearby? [23:29:54] (03CR) 10Jdlrobson: [C: 032] Hygiene: Update LESS variable names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104540 (owner: 10JGonera) [23:29:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Update LESS variable names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104540 (owner: 10JGonera) [23:30:21] jgonera: yeh nearby refresh icon [23:30:26] looks like button tag has some weird default styling [23:30:33] easiest thing to do is switch to an A tag [23:30:40] (03PS1) 10MaxSem: Don't rely (solely) on templates for geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104687 [23:31:26] (03PS1) 10Jdlrobson: Fix refresh icon on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104688 [23:31:29] i need to jump on a bus back to SF. bus has wifi but i'll be offline for a few minutes [23:31:34] ^ jgonera refresh icon fix [23:31:59] jgonera: feel free to spend a little longer working out what styling is causing the problem - i didn't have time to do that just now - just thought it was important to get it looking nice again [23:32:32] jdlrobson, I'll have a look at it now but probably won't do much, I'm going to bed in 5 mins [23:32:40] makes sense :) [23:32:46] kaldari can always merge it [23:32:58] and you can do a follow up if you didn't like it and feel the need tomorrow [23:33:06] sure [23:41:41] (03PS2) 10JGonera: Hygiene: Update LESS variable names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104540 [23:42:13] (03CR) 10JGonera: [C: 032] Hygiene: Update LESS variable names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104540 (owner: 10JGonera) [23:42:53] (03Merged) 10jenkins-bot: Hygiene: Update LESS variable names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104540 (owner: 10JGonera) [23:51:22] (03PS2) 10JGonera: Fix refresh icon on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104688 (owner: 10Jdlrobson) [23:55:57] (03PS1) 10JGonera: Make title in new header bold and centered [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104691