[00:01:42] jdlrobson, jgonera, kaldari - I'm deploying [00:01:50] ok MaxSem [00:02:26] jdlrobson, I pushed a new patchset to https://gerrit.wikimedia.org/r/104688 [00:03:16] jgonera: what did you change? [00:03:52] just replaced some CSS rules, it's still small [00:03:54] (03CR) 10Jdlrobson: [C: 04-1] "This is great but I really really would like the settings to be created purely in JavaScript. It feels very wrong building any of this on " (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [00:04:01] i'll take a look [00:04:41] ok, good night! [00:05:02] oh, btw, I'll work EU hours tomorrow [00:05:39] jgonera: i suspected ;-) [00:08:02] deployed the login fix [00:10:12] (03CR) 10Jdlrobson: [C: 04-1] "This is looking interesting. Can you rebase this and cherry pick this to master (doesn't seem to require the previous patchset?) so this i" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 (owner: 10Pcc) [00:11:00] looks good max [00:11:06] did you also deploy the config change? [00:11:50] MaxSem: doesn't seem like it - poke me when config change is live [00:12:11] jdlrobson, just did:) [00:12:26] works MaxSem :) [00:12:29] good work! [00:12:32] ohh wait [00:12:33] wee [00:12:35] not working on enwiki [00:12:42] i spoke too soon :) [00:12:59] guess 5 minute cache [00:13:30] mmm, it's still on wmf7 which didn't cherry-pick - I thought it's because only wmf8 is affected [00:13:46] both are effected by the Validation error against schema EchoInteraction: Value "mobile-overlay" for property: context not in enum ["flyout","archive"] bug [00:14:09] ah, the logging stuff [00:15:02] yeh the errors are fine [00:15:08] (login errors) [00:15:09] it's just the schema update now [00:15:37] (03PS3) 10Jdlrobson: Hygiene: Give feedback when topic added to talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103871 [00:16:18] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Give feedback when topic added to talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103871 (owner: 10Jdlrobson) [00:17:31] (03CR) 10Jdlrobson: [C: 032] Fix refresh icon on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104688 (owner: 10Jdlrobson) [00:17:44] MaxSem: you on it? [00:18:06] (03Merged) 10jenkins-bot: Fix refresh icon on nearby [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104688 (owner: 10Jdlrobson) [00:18:12] 5 minutes has just passed jdlrobson [00:18:42] ^ kaldari i'm still seeing this issue [00:18:43] any ideas? [00:18:47] https://en.m.wikipedia.org/w/index.php?title=Main_Page&welcome=yes#notifications [00:18:51] Validation error against schema EchoInteraction: Value "mobile-overlay" for property: context not in enum ["flyout","archive"] [00:19:11] its logging to schema 5539940 [00:20:18] MaxSem: not sure whether it's caching or something else [00:20:33] i don't know enough about Echo extension [00:20:55] MaxSem: it seems to be working now [00:20:56] neither do I [00:20:58] \o/ [00:21:08] i think we're good [00:21:12] give yourself a pat on the back :) [00:30:43] jdlrobson: Sorry. 5539940 was still the old schema # [00:30:55] must have taken a while to update [00:32:17] it's been an hour and a half and still haven't heard anything back from kenan :( [00:32:55] where is he hiding [00:58:31] (03CR) 10Jdlrobson: Story 882: Upload overlay back behaviour (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson) [01:13:29] okay, Tim merged my wikidiff2 change, tomorrow I'll start pestering the ops about updating the package [01:25:08] (03PS9) 10Jdlrobson: Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 [01:25:13] (03CR) 10jenkins-bot: [V: 04-1] Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson) [01:27:57] (03PS10) 10Jdlrobson: Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 [01:28:34] (03CR) 10jenkins-bot: [V: 04-1] Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson) [01:28:45] kaldari: :( about kenan's absence [01:29:17] kaldari: what are you blocked on? [01:31:11] (03Abandoned) 10Jdlrobson: Story 1512: Apply new chrome in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103618 (owner: 10Jdlrobson) [01:33:58] (03CR) 10Jdlrobson: [C: 04-1] "Could you point the commit to the dependency that brings in this functionality? It's hard to see the whole picture." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104687 (owner: 10MaxSem) [01:44:24] jdlrobson: The A/B test story has no design, but I'm working on the other parts in the meantime. [01:46:12] jdlrobson: I understand there are a couple of old designs sitting around somewhere. Do you happen to know anything about those? Do you know who implemented them? [01:46:26] kaldari: :-( i'd poke kaity|away for any design needs [01:46:30] she may be more responsive [01:46:32] I already did [01:46:39] she said I should ask Kenan [06:27:52] (03CR) 10Theopolisme: "Talked to Max on IRC, just noting that I've not abandoned this, just going to have to look into a different approach for the non-JS fallba" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme) [09:56:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103871 (owner: 10Jdlrobson) [16:00:40] (03PS11) 10JGonera: Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson) [16:02:10] (03CR) 10JGonera: [C: 04-1] "I fixed the rebase and added a few more comments, but unfortunately discovered that inserting lead photo doesn't work at all. If you uploa" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson)