[08:51:30] <grrrit-wm>	 (03PS3) 10M4tx: Add an ability to change the copyright warning in editor and uploader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 
[08:54:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add an ability to change the copyright warning in editor and uploader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx)
[09:06:09] <grrrit-wm>	 (03CR) 10Siebrand: "i18n/L10 reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx)
[11:45:56] <twkozlowski>	 https://gerrit.wikimedia.org/r/#/c/92036/
[11:46:20] <twkozlowski>	 do I understand correctly that this will make tablet devices get mobile view of the sites inside their browsers?
[11:46:31] <twkozlowski>	 ie. without the need to resort to the mobile app?
[12:28:15] <thedj>	 twkozlowski: looks like it. although i don't think the configuration has been deployed yet.
[12:49:23] <twkozlowski>	 thedj: Thanks, I'll add it to Tech News #2 then
[12:52:57] <thedj>	 twkozlowski: like i said, no idea when that would go live, might be weeks away, might be tomorrow
[12:53:23] <grrrit-wm>	 (03CR) 10Odder: "I'd like to mention this change in the upcoming issue of the Tech News newsletter. Can someone have a look at https://meta.wikimedia.org/w" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92036 (owner: 10MaxSem)
[12:53:47] <twkozlowski>	 thedj: oh. Well, I guess my comment won't hurt anyone :)
[16:22:51] <grrrit-wm>	 (03CR) 10Jdlrobson: "@Odder this is not correct. We havent enabled this we have only put the possibility to do this in place!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92036 (owner: 10MaxSem)
[16:24:55] <grrrit-wm>	 (03CR) 10Odder: "@Jdlrobson: Thanks! Is there any documentation that I can read to fix or reword this? Are there any plans to actually enable this at some " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/92036 (owner: 10MaxSem)
[16:42:19] <grrrit-wm>	 (03CR) 10Theopolisme: "Looked at this a bit, is checking" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme)
[17:13:16] <grrrit-wm>	 (03PS4) 10Theopolisme: Warn user when attempting to switch modes without cookies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 
[17:14:08] <grrrit-wm>	 (03CR) 10Theopolisme: "Here's a somewhat rough approach. Am I on the right track?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme)
[17:39:46] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Allow switching from edit preview to editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104755 (owner: 10Jdlrobson)
[17:56:19] <grrrit-wm>	 (03CR) 10MaxSem: Don't rely (solely) on templates for geonotahack (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104687 (owner: 10MaxSem)
[17:56:21] <jgonera>	 jdlrobson, can you do git pull?
[17:56:31] <jgonera>	 nvm, just worked as I typed this...
[17:57:46] <grrrit-wm>	 (03PS2) 10MaxSem: Don't rely (solely) on templates for geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104687 
[17:58:39] <MaxSem>	 heyyyy guys, your review will be appreciated at https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/ApiSandbox,n,z
[17:59:58] <jdlrobson>	 jgonera: have you had a chance to look at https://gerrit.wikimedia.org/r/#/c/96922/ yet?
[18:00:03] <jdlrobson>	 MaxSem: yeh i
[18:00:13] <jdlrobson>	 MaxSem: yeh it's on my radar I just haven't had time yet sorry
[18:00:32] <jgonera>	 jdlrobson, I've seen your comments, but haven't checked it yet, I'm about to
[18:00:50] <jdlrobson>	 i wanted to write some qa tests but the qa stuff was broken - chrismcmahon was gonna take a look
[18:00:55] <jdlrobson>	 hey theopolisme happy new year :)
[18:01:18] <chrismcmahon>	 jdlrobson:  tests for what? 
[18:01:33] <jdlrobson>	 chrismcmahon: the MobileFrontend acceptance tests being broken remember :)
[18:01:42] <jdlrobson>	 ie. i can't run them locally
[18:02:24] <chrismcmahon>	 jdlrobson: you can start writing the test Scenarios without needing to run the test.  that is often the hardest part.  what is it you want to test? 
[18:02:25] <jgonera>	 MaxSem, jshint fails in the first patch. are those patches just refactorings?
[18:02:44] <MaxSem>	 the first one is, others are bugfixes
[18:03:32] <theopolisme>	 you too, jdlrobson! :) i've gone from 300 ft above sea level to over 7,000 ft, so it's an *interesting* new year at least
[18:03:51] <theopolisme>	 MaxSem, https://gerrit.wikimedia.org/r/#/c/104210/ whenever you have time :)
[18:04:04] <MaxSem>	 looking
[18:07:59] <chrismcmahon>	 jdlrobson: got a story for that QA test?
[18:09:23] <jdlrobson>	 chrismcmahon: i thought you opened a bug let me check
[18:10:07] <chrismcmahon>	 jdlrobson: no, I mean, what feature needs a QA test? 
[18:10:10] <jdlrobson>	 chrismcmahon: but basically on tuesday i told you i was trying to run bundle exec cucumber and it was freezing
[18:10:22] <jgonera>	 jdlrobson, just checked again, lead photo upload doesn't work with https://gerrit.wikimedia.org/r/#/c/96922/
[18:10:28] <jdlrobson>	 so i can't write any test
[18:10:30] <jgonera>	 go to a page without a photo and try to add one
[18:10:38] <jgonera>	 it won't show up, it won't be added to page's wikitext
[18:11:06] <jgonera>	 jdlrobson, can you reproduce?
[18:11:41] <chrismcmahon>	 jdlrobson: sure you can.  The first thing you need is a foo.feature file saying "Given <some initial condition>/When <I take some action>/Then <I should see some result>"  That's what I'm asking about. 
[18:12:24] <chrismcmahon>	 jdlrobson:  check in one of those and we can take it from there. 
[18:13:16] <jdlrobson>	 hang out jgonera 
[18:13:39] <jdlrobson>	 chrismcmahon: i'm sooo confused now. I can't run the tests! let me pull up the conversation from tuesday
[18:14:42] <jdlrobson>	 chrismcmahon: jdlrobson:  one moment, let me check out the most recent
[18:14:43] <jdlrobson>	 [3:02pm] chrismcmahon: jdlrobson: the command /MobileFrontend/tests/browser$ bundle exec cucumber features/footer.feature  does not launch Firefox at all?
[18:14:44] <jdlrobson>	 [3:03pm] chrismcmahon: jdlrobson: after the test I am getting a funny message from Firefox saying "Your Firefox profile cannot be loaded. It may be missing or inaccessible" that I don't think I've seen before
[18:14:59] <jdlrobson>	 chrismcmahon: jdlrobson:  I'm trying to figure out what might have gone wrong here.  I think the new stuff for "Nearby" is messing with us.
[18:15:17] <jdlrobson>	 chrismcmahon: jdlrobson:  this might have gotten +2 a little too quickly:  https://gerrit.wikimedia.org/r/#/c/101129/6.  I am seeing that the BROWSER_LABEL env var is not being honored.  I set it to 'chrome' and all the tests launch Firefox.
[18:15:17] <jdlrobson>	 chrismcmahon: jdlrobson:  I suspect the issue lies in what Jeff did in the Nearby stuff and how it works with local settings, but I'm probably not going to figure it out today.  We can revert if you want, or I can work on it more first thing on Thursday.
[18:15:21] <jdlrobson>	 ^ chrismcmahon familiar?
[18:16:02] <jdlrobson>	 chrismcmahon: i usually run the tests to remind myself how to write them - as it's helpful and tells me what is missing
[18:16:11] <chrismcmahon>	 jdlrobson:  yes, I understand.  I'm talking about something different.  Here is an example of a test that I have begun writing.  I want to have it reviewed first, then I want to pair-program to implement the test.  https://gerrit.wikimedia.org/r/#/c/103761/
[18:16:20] <jdlrobson>	 jgonera: i can't reproduce that no - it works fine for me. are you trying that in stable/beta/alpha?
[18:17:20] <jdlrobson>	 chrismcmahon: sure. i've written tests like this before.
[18:17:27] <jdlrobson>	 I just find it easier writing tests when i can run them
[18:24:18] <chrismcmahon>	 jdlrobson: I know why https://gerrit.wikimedia.org/r/#/c/101129 fails in Linux, but I don't have a Mac to work on.  I think I'll be speaking to Jeff tomorrow and he'll certainly be back next week.  I think we should revert that Nearby commit https://gerrit.wikimedia.org/r/#/c/101129
[18:24:55] <chrismcmahon>	 jdlrobson: and I still wonder what feature you want to write tests for
[18:25:17] <jdlrobson>	 chrismcmahon: it's just to test back behavior on the new upload overlay
[18:25:29] <jdlrobson>	 there are so many scenarios
[18:25:38] <jdlrobson>	 proving difficult to write and test
[18:26:36] <jgonera>	 jdlrobson, beta
[18:26:37] <grrrit-wm>	 (03PS1) 10Cmcmahon: Revert "QA: New browser test for "Nearby" page". This is causing several issues for Bug 59174 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104997 
[18:27:14] <jgonera>	 jdlrobson, so the wikitext gets updated for you and the newly uploaded lead photo appears on the page?
[18:27:21] <chrismcmahon>	 jdlrobson:  want to +2 reverting the Nearby stuff?  https://gerrit.wikimedia.org/r/#/c/104997/
[18:27:21] <jdlrobson>	 jgonera: correct
[18:27:26] <jgonera>	 magic...
[18:27:34] <jdlrobson>	 jgonera: what happens if you refresh the page?
[18:27:37] <jdlrobson>	 is it there?
[18:27:44] <jgonera>	 it's not there
[18:27:46] <jdlrobson>	 what is happening in the network tab?
[18:27:56] <jgonera>	 no errors
[18:28:07] <jgonera>	 ok, I'll investigate...
[18:29:38] <jgonera>	 ok, jdlrobson, it must be your weird browser cache thing again
[18:29:42] <jgonera>	 it just can't work
[18:29:45] <jgonera>	 I'm looking at the code
[18:29:51] <jgonera>	 				on( 'success', function( data ) {
[18:30:07] <jgonera>	 you removed the "success" event from PhotoUploaderButton
[18:30:10] <jgonera>	 so this can't work
[18:30:12] <jdlrobson>	 jgonera: one second i'll pull it down again
[18:30:29] <grrrit-wm>	 (03CR) 10Mattflaschen: "The main issue is that KSS is using a different CSS-generation pathway than ResourceLoader. It uses the node.js LESS package, https://npm" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102547 (owner: 10Jdlrobson)
[18:31:40] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Break out ajax pages RL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104659 
[18:31:41] <grrrit-wm>	 (03PS30) 10Jdlrobson: Experiment: Special:MobileWebApp and manifests for offline FF & Chrome, FFOS + CWS. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 
[18:32:02] <grrrit-wm>	 (03CR) 10Mattflaschen: "Note, the ResourceLoader CSS output uses full HTTP paths, hence the note about a running MW instance (or at least a server mimicking MW pa" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102547 (owner: 10Jdlrobson)
[18:33:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Experiment: Special:MobileWebApp and manifests for offline FF & Chrome, FFOS + CWS. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson)
[18:33:26] <jdlrobson>	 so jgonera just pulled it down and it does work for me.. look at uploadsNew/PhotoUploaderOverlay.js
[18:33:27] <jdlrobson>	 api.save
[18:33:35] <jdlrobson>	 inside the _submit function
[18:33:46] <jgonera>	 jdlrobson, LeadPhotoUploaderButton.js, L27
[18:33:46] <jdlrobson>	 are you sure you are looking at the same code as me?
[18:33:52] <jgonera>	 there are two issues here
[18:34:04] <jgonera>	 1) not showing the photo after upload 2) not updating wikitext
[18:34:11] <jdlrobson>	 that only runs in stable jgonera 
[18:34:11] <jgonera>	 I'm talking about 1) now, will check 2)
[18:35:09] <jdlrobson>	 jgonera: i know the uploads code is super confusing :)
[18:35:10] <jgonera>	 jdlrobson, why? what do we use in beta?
[18:35:10] <jdlrobson>	 / FIXME: Kill use of these events when new upload workflow goes to stable
[18:35:18] <jdlrobson>	 PhotoUploaderOverlay.js jgonera 
[18:35:40] <jdlrobson>	 jgonera: i would really like to get some qa tests written and make this a lot clearer
[18:35:51] <jdlrobson>	 it's a huge head f**k :)
[18:35:56] <jgonera>	 uh, we reload the whole page then...
[18:36:00] <jdlrobson>	 jgonera: yeh correct
[18:36:27] <jgonera>	 ok, then I still don't know why it doesn't work... let me investigate further
[18:36:42] <jdlrobson>	 jgonera: are you running Ori's localStorage resource loader experiment?
[18:36:47] <jdlrobson>	 is there any code in local storage?
[18:36:53] <jgonera>	 jdlrobson, nope
[18:36:55] <jdlrobson>	 mm
[18:36:58] <jdlrobson>	 super odd
[18:37:24] <jgonera>	 haha! I know@
[18:37:34] <jgonera>	 I have captcha enabled so the edit fails...
[18:37:40] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson)
[18:37:49] <jgonera>	 which resurfaces the bug we have about no captcha/abusefilter support in uploads
[18:37:59] <jdlrobson>	 ahhh
[18:38:01] <jdlrobson>	 lolz
[18:38:26] <jdlrobson>	 chrismcmahon: ok so now with reverting that patch I have a weird problem
[18:38:34] <jdlrobson>	 it gets to Scenario: Create Article                            # features/create_article.feature:4 and then freezes
[18:38:38] <jgonera>	 not so lolz, we have to fix that ;)
[18:38:43] <jdlrobson>	 must be something screwed up with my firefox web driver?
[18:38:52] <chrismcmahon>	 jdlrobson: do you have a browser at all? 
[18:39:02] <jdlrobson>	 chrismcmahon: i'm a frontend developer of course ;-)
[18:39:19] <chrismcmahon>	 jdlrobson:  I mean, does the test launch a browser for you? 
[18:39:37] <jdlrobson>	 nope chrismcmahon 
[18:39:43] <jdlrobson>	 unable to bind to locking port 7054 within 45 seconds (Selenium::WebDriver::Error::WebDriverError)
[18:42:07] <chrismcmahon>	 jdlrobson:  does 'lsof -i TCP:7054' tell you anything? 
[18:42:22] <jdlrobson>	 ruby    8936 jrobson    7u  IPv4 0xffffff801022a160      0t0  TCP localhost:7054 (LISTEN) < chrismcmahon 
[18:43:24] <chrismcmahon>	 jdlrobson: kill that process and go again. 
[18:44:48] <jgonera>	 jdlrobson, do you want me to merge this patch or you want to add browser tests first?
[18:45:00] <jdlrobson>	 jgonera: i think browser tests would be a good addition
[18:45:05] <jdlrobson>	 chrismcmahon: seems to open firefox now :)
[18:45:20] <jdlrobson>	 chrismcmahon: and it seems to work again!
[18:45:29] <jdlrobson>	  no need to revert the nearby patch! :)
[18:45:38] <jdlrobson>	 not sure what happened there..
[18:45:51] <jgonera>	 firefox froze in the background
[18:45:57] <jdlrobson>	 jgonera: it did for you?
[18:46:14] <jgonera>	 I'm guessing, it did a few times, not in Selenium tests though
[18:46:15] <chrismcmahon>	 jdlrobson:  we still need to revert the Nearby patch (at least for now)
[18:48:02] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "This doesn't seem to fix the problem when the screen is 320px." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104775 (owner: 10M4tx)
[18:48:15] <grrrit-wm>	 (03CR) 10Jdlrobson: Fix main menu animation glitches (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104775 (owner: 10M4tx)
[18:48:32] <jdlrobson>	 jgonera: have you tried out 'make gerrit' ?
[18:49:00] <jgonera>	 nope, jdlrobson, only the python script
[18:49:08] <jdlrobson>	 same thing :)
[18:50:20] <jgonera>	 oh, then I did ;) I'll have to play with it more
[18:52:03] <grrrit-wm>	 (03PS2) 10Cmcmahon: Revert "QA: New browser test for "Nearby" page". This is causing several issues for Bug 59174 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104997 
[18:54:48] <chrismcmahon>	 jdlrobson:  we should revert 104997 because a) it only works for tests with one Scenario and b) it prevents launching Chrome.
[19:00:26] <jdlrobson>	 chrismcmahon: ok sure writing a test right now but i'll +2 in a bit if no one else beats me to it :)
[19:01:08] <pcc1>	 what actually happens when you call $ with a function as an argument?
[19:01:34] <jdlrobson>	 $( function() {} ) is the same as jQuery.ready( function(){})
[19:01:38] <jdlrobson>	 if that's what you mean
[19:02:09] <pcc1>	 jdlrobson: yeah, that's what I mean
[19:03:55] <pcc1>	 I have no idea why anyone thinks jquery is a well designed library. "let's overload everything into one function and make things impossible to look up"
[19:10:58] <jdlrobson>	 chrismcmahon: page.upload_button_element.span_element - what's the equivalent function to span_element for anchor tags?
[19:12:05] <jgonera>	 jdlrobson, does https://gerrit.wikimedia.org/r/#/c/104777/ fix both bugs in media viewer?
[19:12:32] <jdlrobson>	 jgonera: it seems to. feel free to test more vigorously though :)
[19:12:53] <jgonera>	 I'll add the second bug number ot the commit then
[19:13:35] <chrismcmahon>	 jdlrobson:  not sure I understand the question.  want to check in what you have so far? 
[19:14:33] <jdlrobson>	 chrismcmahon: i worked it out - link_element :)
[19:17:20] <chrismcmahon>	 jdlrobson:  I think you have a misunderstanding of some sort. 
[19:18:25] <grrrit-wm>	 (03PS2) 10JGonera: Fix image preview for tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104777 (owner: 10Jdlrobson)
[19:18:41] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Fix image preview for tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104777 (owner: 10Jdlrobson)
[19:19:04] <jdlrobson>	 chrismcmahon hmm? don't think so i got myself a working test so far :)
[19:19:40] <chrismcmahon>	 jdlrobson:  let me know when you check it in... 
[19:19:47] <jdlrobson>	 chrismcmahon: will do
[19:25:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix image preview for tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104777 (owner: 10Jdlrobson)
[19:29:59] <grrrit-wm>	 (03PS1) 10JGonera: Remove spinner in media viewer only after the image is fully loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105007 
[19:38:51] <grrrit-wm>	 (03PS1) 10JGonera: Remove the header in LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105011 
[19:48:44] <grrrit-wm>	 (03PS1) 10JGonera: Add browser back support to new languages overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105013 
[19:52:45] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Regression: Fix add discussion button in talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104771 (owner: 10Jdlrobson)
[19:53:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Regression: Fix add discussion button in talk overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104771 (owner: 10Jdlrobson)
[19:55:35] <grrrit-wm>	 (03CR) 10JGonera: [C: 031] Don't rely (solely) on templates for geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104687 (owner: 10MaxSem)
[19:55:50] <pcc1>	 jdlrobson: I'm trying to add my option to javascript and having a bit of trouble adding the template.  http://www.pcc.me.uk/~peter/tmp/a.patch is my current diff against my existing patch series, but this doesn't work. I get this: "Uncaught Error: Template not found: specials/mobileoptions/checkbox".  anything else required for templates to work?
[19:57:11] <jdlrobson>	 pcc1: switch from $wgMFMobileSpecialPageResourceBoilerplate to $wgMFMobileResourceBoilerplate
[19:57:19] <jdlrobson>	 it's a special RL module type which has template support
[19:57:23] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Hygiene: Break out ajax pages RL (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104659 (owner: 10Jdlrobson)
[19:57:26] <grrrit-wm>	 (03PS3) 10Kaldari: New A/B test for Sign-up Edit Guider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 
[19:57:55] <grrrit-wm>	 (03CR) 10Kaldari: New A/B test for Sign-up Edit Guider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 (owner: 10Kaldari)
[19:58:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] New A/B test for Sign-up Edit Guider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 (owner: 10Kaldari)
[19:58:55] <grrrit-wm>	 (03CR) 10Jdlrobson: Hygiene: Break out ajax pages RL (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104659 (owner: 10Jdlrobson)
[20:00:09] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Script: Add make mygerrit command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104770 (owner: 10Jdlrobson)
[20:00:55] <pcc1>	 jdlrobson: thanks, that gets me a little closer (no javascript errors). think I'll need to play around some more to get something to appear on the page
[20:01:07] <jdlrobson>	 sweet. thanks for looking into this pcc1  :)
[20:01:17] <jdlrobson>	 i'm looking forward to seeing the end result!
[20:02:45] <grrrit-wm>	 (03Merged) 10jenkins-bot: Script: Add make mygerrit command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104770 (owner: 10Jdlrobson)
[20:03:36] <kaldari>	 jdlrobson, jgonera, MaxSem: for some reason I can't get https://gerrit.wikimedia.org/r/#/c/104790/ to not make the RL quint tests explode. Anyone have time to take a look?
[20:03:52] <MaxSem>	 looking
[20:04:08] <kaldari>	 The test itself is in [core]/tests/qunit/data/testrunner.js
[20:04:16] <kaldari>	 around line 354
[20:07:41] <kaldari>	 it's complaining that all of the mobile RL modules are in an error state when the test runs
[20:08:03] <kaldari>	 but if I test their state from the console, they seem fine
[20:09:20] <MaxSem>	 hmm, I'm not really experienced with qunit
[20:10:32] <kaldari>	 I can't imagine how anything in that changeset would cause such a cataclysmic failure in RL
[20:11:22] <jgonera>	 kaldari, I'll have a look in a moment
[20:11:49] <kaldari>	 thanks
[20:14:15] <jgonera>	 kaldari_lunch, where's mobileLeftNavbarEditCTA.js?
[20:15:18] <kaldari_lunch>	 jgonera: Ah! Shit, I forgot to add it in my commit :P
[20:15:28] <kaldari_lunch>	 that explains it :)
[20:15:33] <jgonera>	 ;)
[20:16:02] <grrrit-wm>	 (03PS4) 10Kaldari: New A/B test for Sign-up Edit Guider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 
[20:16:03] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] Warn user when attempting to switch modes without cookies (0310 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme)
[20:46:03] <abailiss>	 is there a good task for a beginner with the mediawiki codebase that needs working on now?
[20:46:21] <MaxSem>	 hey abailiss
[20:46:32] <abailiss>	 hey :)
[20:49:47] <jdlrobson>	 any one seen kenan wang today?
[20:49:54] <jdlrobson>	 otherwise might have to create whereiskenan.com
[20:54:34] <mhurd>	 jdlrobson: he's in ny. was in hangout w/him about an hour ago
[21:02:42] <tfinc>	 jdlrobson: i just had him on hangout 30min ago
[21:02:52] <jdlrobson>	 tfinc: we're just waiting on him for story estimation
[21:02:56] <jdlrobson>	 i can't get hold of him
[21:07:43] <tfinc>	 abailiss: between MaxSem and jdlrobson we can find something for you to take on :)
[21:09:41] <abailiss>	 thanks tfinc, I've been given https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=keyword%3Aeasy
[21:18:19] <MaxSem>	 http://jitsu.instance-proxy.wmflabs.org/
[21:18:22] <jdlrobson>	 sorry abailiss we're just in a meeting - i'll take a look in about 40 mins :)
[21:18:56] <abailiss>	 no problem at all, may be gone by then - have to get a bouncer setup
[21:19:12] <abailiss>	 taking a look through the buglist with keyword easy
[21:24:59] <kaldari>	 https://en.wikipedia.org/wiki/List_of_women_in_the_Heritage_Floor
[21:38:25] <jdlrobson>	 https://en.m.wikipedia.org/wiki/Dutch_East_Indies < 
[21:52:45] <grrrit-wm>	 (03CR) 10Theopolisme: Warn user when attempting to switch modes without cookies (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme)
[21:53:05] <grrrit-wm>	 (03PS5) 10Theopolisme: Warn user when attempting to switch modes without cookies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 
[22:00:38] <jdlrobson>	 kaity: any captcha refresh designs yet?
[22:01:46] <kaity>	 jdlrobson: yes! 1 sec
[22:01:53] <theopolisme>	 MaxSem, replies @ https://gerrit.wikimedia.org/r/#/c/104210/
[22:03:44] <theopolisme>	 jdlrobson, if you have a sec, did I misinterpret the bug report at https://gerrit.wikimedia.org/r/#/c/104210/4/includes/MobileContext.php (search for From Jon's comment )
[22:04:56] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Remove spinner in media viewer only after the image is fully loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105007 (owner: 10JGonera)
[22:05:52] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Sad days :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104997 (owner: 10Cmcmahon)
[22:06:31] <grrrit-wm>	 (03CR) 10Cmcmahon: "It's cool, we'll bring this back real soon." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104997 (owner: 10Cmcmahon)
[22:11:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove spinner in media viewer only after the image is fully loaded [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105007 (owner: 10JGonera)
[22:13:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "QA: New browser test for "Nearby" page". This is causing several issues for Bug 59174 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104997 (owner: 10Cmcmahon)
[22:18:13] <kaity>	 jdlrobson: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1012
[22:18:27] <kaity>	 added a design and asset for refresh icon
[22:21:45] <jdlrobson>	 thanks kaity 
[22:22:54] <jdlrobson>	 abailiss: this is pretty straightforward bug you could work on - it would make you familiar to MobileFrontend's code structure: https://bugzilla.wikimedia.org/show_bug.cgi?id=51482
[22:23:08] <jdlrobson>	 not the most exciting though :)
[22:23:19] <jdlrobson>	 it would make you familiar with MobileFrontends
[22:28:33] <kaity>	 thank you jdlrobson!
[22:28:45] <jdlrobson>	 jgonera: almost have some cucumber tests for uploads
[22:29:00] <jdlrobson>	 not sure how to test back behavior though.
[22:29:11] <jdlrobson>	 the tests are not proving related so feel free to merge if you feel happy with it
[22:29:20] <jdlrobson>	 oh wait there was one thing that did get surfaced
[22:29:27] <jdlrobson>	 so scrap everything i just said
[22:29:39] <jgonera>	 ;)
[22:30:01] <jgonera>	 so should I wait for cucumber tests or not?
[22:33:19] <jdlrobson>	 yup they are almost done
[22:41:39] <grrrit-wm>	 (03PS13) 10Jdlrobson: story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 
[22:41:46] <jdlrobson>	 ^ jgonera okay. So this just tests the button initiates as it is supposed to
[22:41:50] <jdlrobson>	 ^ cc chrismcmalunch 
[22:43:21] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Warn user when attempting to switch modes without cookies (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme)
[22:44:46] <jgonera>	 jdlrobson, my thought here is to split this into two separate patches because it was not done using TDD anyway
[22:44:56] <jdlrobson>	 jgonera: that's fine i'll put a QA test first :)
[22:45:06] <jdlrobson>	 gimme a secon
[22:47:54] <grrrit-wm>	 (03PS14) 10Jdlrobson: Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 
[22:47:55] <grrrit-wm>	 (03PS1) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 
[22:47:55] <jdlrobson>	 ^ jgonera 
[22:48:26] <grrrit-wm>	 (03CR) 10Theopolisme: Warn user when attempting to switch modes without cookies (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme)
[22:48:39] <grrrit-wm>	 (03PS6) 10Theopolisme: Warn user when attempting to switch modes without cookies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 
[22:48:41] <theopolisme>	 jgonera: ^
[22:51:26] <grrrit-wm>	 (03PS15) 10Jdlrobson: Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 
[22:51:27] <grrrit-wm>	 (03PS2) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 
[22:51:31] <grrrit-wm>	 (03CR) 10JGonera: Warn user when attempting to switch modes without cookies (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme)
[22:53:04] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=59009 < i'm a bit concerned about this bug MaxSem jgonera 
[22:53:50] <MaxSem>	 oh shi
[22:53:58] <MaxSem>	 will look after a mtg
[22:58:55] <jdlrobson>	 MaxSem: is there a way we can revert a commit to see if that makes the problem go away
[22:59:09] <jdlrobson>	 MaxSem: I suspect it was v
[22:59:09] <jdlrobson>	 I3e927ec9b9d171cc227da25be43643e6ce21a308
[23:00:07] <grrrit-wm>	 (03PS1) 10MaxSem: Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105108 
[23:00:28] <MaxSem>	 now I go to labs and checkout this
[23:00:54] <jdlrobson>	 MaxSem: thanks :)
[23:04:14] <MaxSem>	 jdlrobson, checked out
[23:05:16] <jdlrobson>	 MaxSem: it works again
[23:05:28] <jdlrobson>	 we need to revert that commit and make sure it doesn't end up on any production servers :(
[23:07:29] <kaldari>	 hmm, I don't get how that code could have affected a centralauth token request :P
[23:07:36] <grrrit-wm>	 (03PS2) 10MaxSem: Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105108 
[23:07:54] <MaxSem>	 jdlrobson, no wanna fix?:)
[23:08:50] <grrrit-wm>	 (03PS3) 10Jdlrobson: Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105108 (owner: 10MaxSem)
[23:09:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105108 (owner: 10MaxSem)
[23:09:08] <jgonera>	 chrismcmahon, where does "include URL" come from, what gem is URL from?
[23:10:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105108 (owner: 10MaxSem)
[23:10:35] <grrrit-wm>	 (03CR) 10JGonera: "Comments in patchset 1." (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson)
[23:10:40] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson)
[23:11:02] <chrismcmahon>	 jgonera: https://git.wikimedia.org/summary/mediawiki%2Fselenium
[23:11:26] <jgonera>	 jdlrobson, anything changed in https://gerrit.wikimedia.org/r/#/c/96922/ since the last time I checked it out without tests?
[23:13:55] <MaxSem>	 jdlrobson, wmf9 is affected by that bug, we need a LD
[23:14:01] <jdlrobson>	 oh dears
[23:14:06] <jdlrobson>	 MaxSem: time for one today?
[23:14:19] <jdlrobson>	 jgonera: nope
[23:15:20] <MaxSem>	 hey greg-g, is there a LD today?
[23:15:26] <greg-g>	 yeah
[23:15:50] <MaxSem>	 we need to deploy a fix for uploads
[23:16:03] <jgonera>	 chrismcmahon, I can't find the URL module defined there, is it from one of the external gems?
[23:16:28] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson)
[23:17:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Story 882: Upload overlay back behaviour [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/96922 (owner: 10Jdlrobson)
[23:18:18] <chrismcmahon>	 jgonera:  my mistake, we haven't made that shared code yet, find it in features/support/modules/url_module.rb
[23:18:59] <jgonera>	 ah, OK, thanks chrismcmahon 
[23:23:59] <grrrit-wm>	 (03CR) 10JGonera: QA: Add tests for lead photo and uploads workflows (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson)
[23:29:47] <grrrit-wm>	 (03PS3) 10Jcf2000: On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 
[23:29:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000)
[23:35:59] <grrrit-wm>	 (03PS1) 10MaxSem: Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] (wmf9) - 10https://gerrit.wikimedia.org/r/105112 
[23:36:14] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032 V: 032] Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] (wmf9) - 10https://gerrit.wikimedia.org/r/105112 (owner: 10MaxSem)
[23:46:19] <jgonera>	 jdlrobson, kaldari, MaxSem I'm finishing for today. would you mind if I worked EU hours tomorrow? I'll be at the standup
[23:46:32] <jdlrobson>	 np from me jgonera 
[23:46:36] <kaldari>	 fine by me
[23:46:39] <MaxSem>	 np either
[23:48:08] <jgonera>	 all right then, good night!
[23:59:41] <grrrit-wm>	 (03PS3) 10M4tx: Fix main menu animation glitches [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104775