[00:00:08] (03PS1) 10Kaldari: Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105116 [00:00:51] (03CR) 10Kaldari: [C: 04-1] "Apparently, this breaks retrieving centralauth tokens, but I have no idea why." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105116 (owner: 10Kaldari) [00:02:44] (03CR) 10jenkins-bot: [V: 04-1] Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105116 (owner: 10Kaldari) [00:02:59] jdlrobson, kaldari - fix deployed [00:03:30] (03PS2) 10Kaldari: Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105116 [00:03:53] (03CR) 10Kaldari: [C: 04-2] "Apparently, this breaks retrieving centralauth tokens, but I have no idea why." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105116 (owner: 10Kaldari) [00:04:18] MaxSem: thanks [00:10:36] (03PS4) 10Jcf2000: On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 [00:10:42] (03CR) 10jenkins-bot: [V: 04-1] On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [00:15:25] (03PS5) 10Jcf2000: On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 [00:15:30] (03CR) 10jenkins-bot: [V: 04-1] On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [00:21:44] (03CR) 10Kaldari: [C: 032] Don't rely (solely) on templates for geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104687 (owner: 10MaxSem) [00:23:40] (03Merged) 10jenkins-bot: Don't rely (solely) on templates for geonotahack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104687 (owner: 10MaxSem) [00:42:30] (03PS2) 10Jdlrobson: WIP: Generate JSDoc from Common folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104788 [00:43:17] (03CR) 10jenkins-bot: [V: 04-1] WIP: Generate JSDoc from Common folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104788 (owner: 10Jdlrobson) [02:09:19] (03PS1) 10Dr0ptp4kt: Use reflection for enabling debugging, update README. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105134 [02:40:11] (03PS6) 10Jcf2000: On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 [02:40:45] (03CR) 10jenkins-bot: [V: 04-1] On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [02:43:45] (03PS7) 10Jcf2000: On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 [02:43:56] (03CR) 10jenkins-bot: [V: 04-1] On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [05:37:12] (03PS8) 10Jcf2000: On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 [05:37:25] (03CR) 10jenkins-bot: [V: 04-1] On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [05:40:07] (03PS9) 10Jcf2000: On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 [08:06:32] (03PS3) 10Jdlrobson: Generate JSDoc from Common folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104788 [08:07:11] (03CR) 10jenkins-bot: [V: 04-1] Generate JSDoc from Common folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104788 (owner: 10Jdlrobson) [08:08:37] (03PS4) 10Jdlrobson: Generate JSDoc from Common folder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104788 [11:15:56] (03PS1) 10Dzahn: fix build error by malformed translation string [apps/android/commons] - 10https://gerrit.wikimedia.org/r/105165 [11:20:00] YuviPanda: https://gerrit.wikimedia.org/r/#/c/105165/1 [11:23:47] hey mutante_, are you in Europe? [11:24:37] MaxSem: hello, yes, i am [11:24:43] in January [11:25:26] just tried to build and change the commons app with some friends last night :) [11:25:33] and that is the fix we came up with [11:25:41] that was actually no-work for fun:) [11:26:03] want to use commons app as a generic app to upload images to non-wmf wikis too [12:09:55] (03CR) 10Mschon: [C: 031] fix build error by malformed translation string [apps/android/commons] - 10https://gerrit.wikimedia.org/r/105165 (owner: 10Dzahn) [12:54:16] mutante_: thanks! [12:54:35] mutante_: i think that'll have to be fixed in translatewiki.net though, otherwise it'll be overritten on next import [13:18:19] Are you guys still on schedule to release the new android app? Thanks [13:21:12] (03CR) 10JanZerebecki: [C: 031] fix build error by malformed translation string [apps/android/commons] - 10https://gerrit.wikimedia.org/r/105165 (owner: 10Dzahn) [13:23:30] YuviPanda: a, gotcha, well, i already added Siebrand as reviewer suspecting that might happen [13:23:47] Eeeeeee: yeah, should be out by end of feb [13:23:54] mutante_: thanks :) [13:23:56] as you saw above,just tried to build it with friends last night and that one we needed to get it done [13:24:20] sure, it was fun [13:24:33] never built .apk before [13:24:56] YuviPanda Awesome thanks. Will it be open source like the last? Also is it native? [13:25:05] Eeeeeee: yes,, completely native :) [13:25:21] Eeeeeee: yes, open source too: http://github.com/wikimedia/apps-android-wikipedia [13:25:23] mutante_: :D [13:25:30] mutante_: did you use an IDE? [13:25:35] YuviPanda: when it started getting stuff from yuvi.in ... :) [13:25:42] mutante_: haha :D [13:25:58] YuviPanda :D [13:26:00] mutante_: I need to get that running on labs, but lazy [13:26:00] YuviPanda: we tried eclipse, and to import it [13:26:03] This is the new one? [13:26:07] but didnt really use it to build [13:26:07] mutante_: eclipse sucks :D [13:26:10] just mvn install [13:26:11] Whoops mistook it for the old [13:26:12] and vi [13:26:14] Eeeeeee: yeah, it is the new one [13:26:16] mutante_: nice [13:26:33] and apt-get install maven [13:26:36] NOT maven2 :p [13:26:45] had to realize maven is newer than maven2 [13:26:48] mutante_: :D [13:27:06] mutante_: shouldn't there be a maven3 and maven just a virtual package or somesuch referring to that? [13:27:58] YuviPanda: on Debian wheezy laptop.. no maven3, but maven and maven2 [13:28:09] mutante_: heh [13:28:13] maven Breaks: maven2 (<< 2.2.1-11) [13:28:21] Replaces: maven2 (<< 2.2.1-11) [13:28:57] YuviPanda: do you think OpenJDK vs. Oracle JDK matters for this one? [13:29:10] mutante_: shouldn't. [13:29:13] k [13:29:25] i only used openjdk and that worked fine [13:29:35] more android dev talk going on in here than #android-dev :D [13:29:40] Eeeeeee: haha :D [13:29:44] cool, wanted to confirm that, yea, jzerebecki [13:29:54] so we should have skipped that [13:30:02] Eeeeeee: I'm happy, since usually it's just *me* talking Android here. [13:30:05] jzerebecki: i still have a different error than you now :p [13:30:10] hahaha [13:30:37] using oracle java? [13:31:19] jzerebecki: Sun :p [13:31:33] 2 /usr/lib/jvm/java-6-openjdk-i386/jre/bin/java 1061 manual mode [13:31:36] * 3 /usr/lib/jvm/java-6-sun/jre/bin/java 63 manual mode [13:31:43] switches that [13:32:43] it will reinstall java6 when installing 7 through software manager [13:33:13] used update-alternatives --config java [13:34:41] jzerebecki: ok, i'm back to the error i meant orignally: [13:34:57] ERROR: Unable to open class file [13:35:06] /commons/commons/target/generated-sources/r/org/wikimedia/commons/R.java: No such file or directory [13:36:05] did export ANDROID_HOME, or it doesn't even get to this one [13:36:23] do you have R.java ? [13:36:26] mutante_: how are you compiling? [13:36:30] mvn install [13:36:31] mvn package? [13:36:33] hmm [13:36:38] mvn install should run mvn package [13:36:46] it works for the others [13:36:50] hmm [13:36:53] on their laptops, and we kinda did the same [13:36:56] and all Debian [13:36:59] hmmm [13:37:03] stupidest idea ever, but try mvn clean and then mvn install? :D [13:37:14] is there an apk of this uploaded anywhere? [13:37:17] clean sounds good after so many attempts [13:37:52] ah, i have some permission issues, "clean" cant delete things as non-root.. my bad [13:37:55] cleans up [13:38:02] Eeeeeee: http://dumps.wikimedia.org/android/apps-android-wikipedia-dev-sprint3.apk exists but is a few weeks old [13:38:50] that's fine thank you. Don't use maven normally [13:39:31] YuviPanda: thanks:) [INFO] BUILD SUCCESS [13:39:39] now we're talking [13:39:39] mutante_: woo, nice :D [13:40:03] Eeeeeee: we announce new builds to the mobile-l mailing list [13:45:37] Honestly new to wikipedia, at least the contributing side of it heh, but saw there was an app in the works and I'm in the process of learning so I figured it couldn't hurt to come see how I could help [13:45:59] after looking at the structure looks like there was a lot added [13:46:07] I'm guessing all the editing functions [13:46:29] Eeeeeee: fyi, the one i was talking about was the Wikimedia Commons app, there is also Wikipedia and WikiLovesMonuments, so several apps out here [13:47:13] commons and wlm both uploading images you take with your phone camera [13:47:35] Gotcha [13:48:22] you can git clone them all to take a look :) [13:49:17] wonder if wikitionary is getting an update :o [13:49:38] probably not :) [13:49:45] hehe [13:50:16] so I could update it if I wanted to [13:51:01] supports wiktionary:) [13:51:05] maybe. I'm unsure. [13:51:12] it's based off the old codebase, and that one is getting no updates [13:51:27] there is an unoffical wiktionary app [13:51:29] that shows ads [13:51:45] always bugged me [13:51:53] should be a WMF app that makes it irrelevant [13:52:08] If anything you should add the dictionary function within the main app [13:52:12] mutante_: heh, yeah. idk when that'll happen though. [13:52:16] agreed with Eeeeeee [13:52:18] should be one app [13:53:16] YuviPanda: i made twn fix it just now:) [13:53:23] mutante_: whee! thanks! :) [13:53:37] 05:58 < Raymond_> mutante_: I have changed it on twn: https://translatewiki.net/w/i.php?title=Wikimedia:Commons-android-strings-contribution_state_in_progress/fa&diff=5247261&oldid=5069343 [13:53:44] sweet! [13:53:46] Maybe have both I'm sure some user would rather download a wikitionary app than some random dictionary [13:53:57] and now they're are like "it can't handle %" and so on ,hehe [13:54:05] yea, but it was a different % :) [13:54:19] but it definitely looks close to the old wikitionary app in sdk support :D [13:55:04] mutante_: yeah, android support on twn is patchy, and there isn't anyone there actively working on it [13:55:07] * YuviPanda mumbles [13:55:26] mutante_: doesn't support plurals, for example [14:01:57] (03CR) 10Nikerabbit: [C: 04-1] "The proper fix is to remove the preceding % instead." [apps/android/commons] - 10https://gerrit.wikimedia.org/r/105165 (owner: 10Dzahn) [14:03:55] looks good [14:04:00] but it could use some work [14:05:10] the tables are what's killing it [14:08:57] Eeeeeee: yeah [14:09:01] Eeeeeee: we haven't worked on those yet [14:09:38] Eeeeeee: we're working on it [14:09:43] if the row of page titles were small enough to ship with the app, you could really speed up it's perceived performance [14:09:50] ya I know [14:10:02] just thought I would mention it [14:10:58] (03Abandoned) 10Dzahn: fix build error by malformed translation string [apps/android/commons] - 10https://gerrit.wikimedia.org/r/105165 (owner: 10Dzahn) [14:14:32] YuviPanda: abandoned because Nikerabbit said 2-way syncs take time and it should be fixed on next twn export/import to the app [14:14:45] How do people go about getting involved? Just submit pull requests? heh [14:14:45] but it served it's purpose anyways [14:14:52] mutante_: true [14:15:04] Eeeeeee: it's a few hundred megs, so don't think we can do that :) [14:15:07] because it made them change on twn side [14:15:19] Eeeeeee: we use gerrit, but that's okay - you can send pull requests too [14:15:52] wow [14:16:01] i downloaded quotes and it was 80 [14:18:29] Eeeeeee: they are in dumps.wikimedia.org [14:20:43] nice. back to coding for now. Thanks for all the info YuviPanda, mutante_ [14:21:24] Eeeeeee: :) [14:21:28] Eeeeeee: good luck! [14:21:30] * YuviPanda goes off to dinner [14:21:31] Eeeeeee: :) http://www.mediawiki.org/wiki/Gerrit/git-review [14:21:37] same here, good luck and afk for now [14:21:42] thank you [16:16:31] (03PS9) 10Pcc: Add an "always expand all sections" option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 [16:16:32] (03PS6) 10Pcc: In alpha mode, save and restore the set of open sections in the history [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 [16:24:20] (03PS10) 10Pcc: Add an "always expand all sections" option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 [16:24:21] (03PS7) 10Pcc: In alpha mode, save and restore the set of open sections in the history [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 [16:26:54] (03CR) 10jenkins-bot: [V: 04-1] Add an "always expand all sections" option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [16:34:19] (03CR) 10Pcc: "Done." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [16:40:24] (03CR) 10Pcc: "This needs to be on top of my other change because it, like the other change, alters the initial behavior of the toggler." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 (owner: 10Pcc) [16:41:35] why does jenkins not run the qunit/phpunit tests (or does it?) [17:22:19] pcc1: which project exactly? for some it should, for others it was not yet configured. [17:28:56] kaity, vbamba is May still on vacation? [17:40:29] (03CR) 10Brion VIBBER: [C: 04-2] "I'd prefer to avoid reflection when we can use the calla directly and know they won't explode because were following standard practice of " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105134 (owner: 10Dr0ptp4kt) [17:50:04] (03PS4) 10Jdlrobson: Hygiene: Break out ajax pages RL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104659 [17:53:22] jgonera: I thought I'd point this one out: https://bugzilla.wikimedia.org/show_bug.cgi?id=59602 Contribute button missing on beta labs right now. [17:54:12] thanks chrismcmahon, we have a standup in a few minutes, I'll be sure to point that out [17:55:03] chrismcmahon: thanks [17:55:35] chrismcmahon: do the qa builds work now? would be great if they could flag this kind of stuff [17:55:51] I always see "Build step 'Execute shell' marked build as failure" but I'm not sure what failed [17:56:27] jdlrobson: that's exactly what they do: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ [17:56:44] chrismcmahon: i guess what i want is the content of this in the email: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/264/testReport/(root)/Upload%20image/Upload_image_file/z [17:56:57] jdlrobson: we have an improved email template about to be deployed, I'll send you an example. [17:57:03] chrismcmahon: sweet! i'd love to se :) [18:12:26] MaxSem: can you update the status of https://bugzilla.wikimedia.org/show_bug.cgi?id=58960 ? [18:12:42] brion: yo [18:13:24] tfinc: yo. me & monte are in the office [18:13:29] brion: you've been a hard man to track down [18:13:33] brion: glad to see you on [18:13:45] i underestimated the amount of time i should have taken off :P [18:13:53] will catch up through the weekend [18:14:23] tfinc: shall we set up the standup? [18:14:28] brion: yes please [18:14:32] i'm already on the hangout [18:14:36] ok brthere [18:17:45] closed [18:21:18] @jgonera ya she's back on monday [18:22:39] vbamba, thanks. that's what I thought so I just asked on design list instead [18:25:11] (03CR) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson) [18:27:20] (03PS3) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 [18:31:10] (03CR) 10jenkins-bot: [V: 04-1] QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson) [18:34:42] jdlrobson, you're our representative at SoS, right? [18:34:43] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson) [18:34:49] MaxSem: correct [18:34:54] MaxSem: what's up? [18:35:19] jdlrobson, can you add a card for https://rt.wikimedia.org/Ticket/Display.html?id=4028 - it's currently blocking the new diff [18:35:56] Sure can you give me details of it to save me looking up my rt credentials? [18:36:16] Rebuild and deploy wikidiff2 [18:37:01] we need help from platform with that? [18:38:00] chrismcmahon: I'd like to try to track down what specifically caused bug 59009 on beta labs today (re centralauth tokens). Since it's rather difficult to reproduce locally, I would like to try troubleshooting it directly on beta labs. Is that kosher and is there a time to do that that's better than other times? (I might break a couple tests in the process). [18:38:05] (03CR) 10Jdlrobson: [C: 032] Remove the header in LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105011 (owner: 10JGonera) [18:38:08] jdlrobson, from ops [18:38:16] MaxSem: ok all recorded. will be sure to bring it up [18:38:25] thanks [18:38:40] it's quite easy but requires a poke [18:39:25] kaldari: I'm fine with you doing that any time. I don't mind a few failing tests if they're expected. [18:39:34] Kaldari you there? Can you talk? [18:39:52] cool, I'll probably work on it in the next couple hours then [18:39:55] kenanwang: here [18:39:59] (03PS2) 10Jdlrobson: Make title in new header bold and centered [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104691 (owner: 10JGonera) [18:40:03] (03CR) 10Jdlrobson: [C: 032] Make title in new header bold and centered [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104691 (owner: 10JGonera) [18:40:22] Want to get on hang out? Kaldari? [18:40:51] sure, go ahead and set up a hang-out and I'll join in a couple minutes [18:40:54] (03CR) 10JGonera: [C: 032] Hygiene: Break out ajax pages RL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104659 (owner: 10Jdlrobson) [18:41:38] (03CR) 10jenkins-bot: [V: 04-1] Remove the header in LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105011 (owner: 10JGonera) [18:41:53] wtf? [18:41:57] lost lost lost skipped? [18:42:17] (03CR) 10JGonera: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105011 (owner: 10JGonera) [18:44:25] (03Merged) 10jenkins-bot: Make title in new header bold and centered [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104691 (owner: 10JGonera) [18:45:26] (03Merged) 10jenkins-bot: Hygiene: Break out ajax pages RL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104659 (owner: 10Jdlrobson) [18:46:28] (03CR) 10Jdlrobson: [C: 04-1] "This works in the stable mode of the site but not in beta mode (here it always uploads with the filename undefined.png)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [18:46:48] (03CR) 10Jdlrobson: "(looking very promising though!)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [18:47:27] (03CR) 10Jdlrobson: [C: 031] Remove the header in LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105011 (owner: 10JGonera) [18:47:32] (03CR) 10Jdlrobson: [C: 032] Remove the header in LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105011 (owner: 10JGonera) [18:48:08] (03Merged) 10jenkins-bot: Remove the header in LoadingOverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105011 (owner: 10JGonera) [18:49:21] kaldari: I went ahead and aborted the MobileFrontend test builds in today's queue, fire at will. [18:50:01] thanks [18:50:15] kenanwang: ready to meet now [18:50:52] k I sent you an invite [18:51:45] (03CR) 10Jdlrobson: [C: 032] "Jgonera - one afterthought" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105013 (owner: 10JGonera) [18:52:23] (03Merged) 10jenkins-bot: Add browser back support to new languages overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105013 (owner: 10JGonera) [19:03:04] (03CR) 10Jdlrobson: [C: 04-1] "This is looking great functionality wise!" (0310 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [19:07:02] [C: -1] "This is looking great functionality wise!" [19:07:03] Yay! [19:08:18] (03CR) 10Jdlrobson: [C: 04-1] "Still not quite there - now it creates a big gap between the menu and article (see screenshot)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104775 (owner: 10M4tx) [19:09:06] brion: maybe to keep things simpler for you i'll squash the new one down so you don't have to make 2 review passes [19:09:15] nah leave it [19:09:25] MaxSem: anyway we could make beta/alpha a user preference in addition to a cookie setting? [19:09:32] would be good to port modes across devices [19:10:11] jdlrobson, any way we could keep users logged in without cookies?:P [19:10:29] MaxSem: hmm? [19:10:42] MaxSem: i'm just fed up of going into different browsers and finding i'm no longer in beta [19:11:02] (03CR) 10Brion VIBBER: "So doing a little poking..." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105134 (owner: 10Dr0ptp4kt) [19:11:03] ah - I was referring to desktop redirect cookies [19:11:30] so... while it's possible, some people might actually want per-device settings [19:11:34] jdlrobson: you can just have it set a user option via API if they are logged in [19:11:43] kaldari: i'd like that [19:12:22] hey MaxSem jdlrobson anna koval and Philippe from the Community liason team recently reported an issue with mobile logins on NYE [19:12:35] kenanwang: what was the issue? [19:12:37] yes? [19:12:58] they got an “Error: no global login available” [19:13:08] jdlrobson: https://www.mediawiki.org/wiki/API:Options [19:13:08] I'm told there was a central auth issue on NYE [19:13:36] is this something that we want to look into more or should we just chalk it up to the central auth issue [19:13:49] (03PS2) 10Dr0ptp4kt: Update README for build requirement. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105134 [19:14:09] what is NYE? [19:14:15] NYE = new year eve? [19:14:18] ah :) [19:15:39] yes new years eve sorry [19:15:45] kenanwang: The centralauth bug that we ran into this week was apparently due to a change that wasn't merged until Dec 30th, so it never went live. [19:16:30] also, it couldn't have broken logins [19:16:34] how to repro? [19:17:13] (03CR) 10Jdlrobson: "Personally I think just testing on JavaScript enabled pages should be enough." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme) [19:18:04] unfortunately she wasn't able to reproduce but two people saw the same issue... [19:18:10] jgonera: I think May is still on vacation, she said til the 3rd [19:18:27] do you want me to add you to the email thread MaxSem? or have them file a bug? [19:18:35] (03PS3) 10Dr0ptp4kt: Update README for build requirement. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105134 [19:18:55] kenanwang: might be worth pinging chrismcmahon, but it's probably not something any of us would be able to track down at this point [19:18:57] yes please, whatever the way we need as much details as possible [19:19:13] i still don't get what the issue was kenanwang [19:19:36] no global login available sounds like a CentralAuth issue not mobile specific [19:19:49] kaldari kenanwang I'm about to take off right now, but do please add me to email discussion if it's appropriate [19:20:01] brion, sorry ps2 for ^^^^^ was an empty amended commit. ps3 provides an updated readme for the gui-based build. unsure about if it would make maven nice. [19:20:19] yeah i'll wait until yuvi's back to figure out that one i think :) [19:20:32] MaxSem: so my suggestion with the cookie desktop switch stuff is to split it into two patches [19:20:36] he knows maven better than i do [19:20:50] the JavaScript code looks good and can probably be merged pretty quickly. Thoughts? [19:20:57] jdlrobson, so far it looks like a lot of cruft for one limited use case [19:21:04] me too [19:21:05] MaxSem: agreed - but the JS isn't so much [19:21:13] okay [19:21:27] ok I'll add chrismcmahon [19:21:54] jdlrobson, on the condition that it nukes the test cookie immediately, not relying on it to expire with session [19:22:49] (03CR) 10Jdlrobson: [C: 04-1] "Please break into two patchsets as suggested above." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme) [19:30:55] (03CR) 10Jdlrobson: "Works great and meets the acceptance criteria but I'm getting validation issues on MobileWebEditing (Instead of using value CTA I'd sugges" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 (owner: 10Kaldari) [19:31:00] (03CR) 10Jdlrobson: [C: 04-1] New A/B test for Sign-up Edit Guider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 (owner: 10Kaldari) [19:31:22] kaity: hey you around want to go over those sign offs? [19:32:55] (03PS4) 10M4tx: Fix main menu animation glitches [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104775 [19:33:33] (03CR) 10M4tx: "Sorry for not testing that properly in the first place. Fixed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104775 (owner: 10M4tx) [19:36:38] brion: getting the lockup bug on big pages? i still need to make more concurrency updates... [19:36:51] yeah [19:37:01] app's still running but i can't touch anything [19:37:06] EVER AGAIN until i delete the app [19:37:15] brion: the obama page locks it up every time... THANKS OBAMA!!! [19:37:37] we'll have to work that out :D [19:38:11] brion: i'll play with it this weekend. there's also a problem with the way i'm pushing views onto the stack. gonna refactor that too [19:38:41] ok [19:39:37] (03CR) 10Jdlrobson: [C: 032] Fix main menu animation glitches [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104775 (owner: 10M4tx) [19:41:10] (03Merged) 10jenkins-bot: Fix main menu animation glitches [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104775 (owner: 10M4tx) [19:47:06] (03CR) 10Brion VIBBER: "A few additional notes before moving on to the next rev:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/104615 (owner: 10Mhurd) [19:47:24] brion: will review notes now [19:47:38] ok [19:50:26] brion: have sec [19:50:53] brion: oops - when u have a sec [20:00:23] jdlrobson: will do [20:00:28] i agree it is a ton of code :p [20:00:52] for such a random thing. it would be cool if there was just a function in core that would let you know if the user had cookies enabled... [20:03:07] kenanwang: can I in about an hour> [20:03:15] it's been a useful exercise - we've looked into it - but really the code it requires does not seem worth it. [20:03:26] kenanwang: or can you send a screenshot of what you're reviewing? [20:03:28] but I think the JavaScript alert is a good useful compromise. [20:03:33] Im about to go to the airport [20:03:40] theopolisme: for bonus points use a toast notification [20:03:48] instead of an alert [20:04:02] kenanwang: I'll be available by email [20:04:31] jdlrobson: how do i do that? :) [20:04:33] var toast = M.require( 'toast' ); toast.show( 'no cookkieeess!', 'toast error' ) [20:04:41] (instead of an alert) [20:04:47] and feel free to push that straight to stable :) [20:05:06] gotcha, neat [20:05:07] obviously don't use the message "no coookieess!" lol ;-) [20:05:10] i'll do that in a bit [20:05:16] heh, i'm not that out of it :D [20:06:45] (03PS3) 10Kaldari: Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105116 [20:07:00] (03CR) 10Kaldari: [C: 031] Add short-curcuit in api.getTokens for tokens availble in user.tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105116 (owner: 10Kaldari) [20:08:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Provisional merge, will review details more along with the next rev!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/104615 (owner: 10Mhurd) [20:08:44] kaity|away: I'll see what I can do [20:08:52] gotta restart, weird trackpad issues [20:08:52] (03PS1) 10Mhurd: On appearance table of contents now scrolls to reflect onscreen section. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/105248 [20:08:54] yayyyyy [20:09:01] jdlrobson, jgonera, MaxSem: I fixed the centralauth token issue with the api.php patch: https://gerrit.wikimedia.org/r/#/c/105116/. The fix is in the 3rd patchset as compared with the 2nd. [20:10:00] apparently with centralauth you have to use a token to retrieve a token [20:12:55] kaldari: Token galore! [20:17:58] (03PS1) 10Jdlrobson: Restore the upload button to Special:Upload in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105251 [20:17:59] (03PS1) 10Jdlrobson: Hide empty message after first upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105252 [20:24:49] (03PS1) 10Cmcmahon: Revert "Revert "QA: New browser test for "Nearby" page". This is causing several issues for Bug 59174" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105253 [20:28:16] (03CR) 10Brion VIBBER: "This fixes several of the issues from the previous commit and generally is improving. Will add some more notes after lunch & looking at th" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/105248 (owner: 10Mhurd) [20:32:47] jzerebecki: I was referring to MobileFrontend [20:44:39] jdlrobson, question [20:44:39] (03PS1) 10MaxSem: Add protection information to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105357 [20:44:58] right now the notifications module isn't loaded in mobile.startuo [20:45:02] YuviPanda, ^^ [20:47:25] it's instead loaded in mobile.stable.common...is it okay to move the stop redirect script to mobile.stable.common, perhaps? [20:49:56] (03CR) 10Pcc: Add an "always expand all sections" option (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [20:54:50] (03PS7) 10Theopolisme: Warn user when attempting to switch modes without cookies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 [20:55:40] jdlrobson: ^ :/ [21:07:12] chrismcmahon: revert a revert? [21:09:13] (03CR) 10Jdlrobson: [C: 032] Warn user when attempting to switch modes without cookies [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme) [21:38:25] hey jdlrobson, we're hacking on Nearby [21:38:39] JeffHall and I are pairing at a co-working space in Tucson AZ [21:38:43] ah ok :) [21:38:56] jdlrobson: we just needed the files :-) [21:43:39] pcc1: MobileFrontend has qunit enabled but not phpunit, see the comments e.g. on https://gerrit.wikimedia.org/r/#/c/105318/ by jenkins-bot [21:45:21] jzerebecki: interesting. I then wonder why the qunit tests weren't triggered for https://gerrit.wikimedia.org/r/#/c/74922/ (which itself adds a qunit test) [21:48:56] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme) [21:49:17] (03CR) 10Jdlrobson: [C: 04-1] "Needs rebasing Theo!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme) [21:49:37] (03PS1) 10Jhall: [QA] WIP New version of Nearby test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105389 [21:50:08] (03PS9) 10Jdlrobson: WIP Alpha: Use the same chrome on special pages as article pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 [21:50:16] (03Abandoned) 10Cmcmahon: Revert "Revert "QA: New browser test for "Nearby" page". This is causing several issues for Bug 59174" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105253 (owner: 10Cmcmahon) [21:50:31] (03PS10) 10Jdlrobson: Story 1589: Use the same chrome on special pages as article pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 [21:51:08] pcc1: somebody with the permissions needs to +1 your patch, then the qunit tests get run [21:53:00] tfinc: sorry was talk with jon [21:53:14] kaldari: k. let me know if you need anything [21:53:15] tfinc: I think we can skip the 1:1 this week anyway [21:53:19] k [21:53:41] (03CR) 10Jdlrobson: Add an "always expand all sections" option (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [21:54:09] tfinc: hope you feel better! [21:56:19] (03CR) 10Pcc: Add an "always expand all sections" option (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [21:57:21] (03CR) 10Jdlrobson: [C: 032] Add protection information to mobileview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105357 (owner: 10MaxSem) [21:59:08] pcc1: ack MobileOptions is nasty in that sense [22:05:06] jdlrobson: I guess I could change that template to use two DIVs instead of two LIs... [22:05:36] pcc1: i'm just about to submit a patch that cleans up the settings page [22:07:04] (03PS1) 10Jdlrobson: Hygiene: Cleanup Special:MobileOptions markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105391 [22:07:06] ^ pcc1 feel free to rebase off that patch [22:07:27] hopefully kaldari or MaxSem can review and merge it [22:09:14] jdlrobson: thanks [22:10:14] (03CR) 10MaxSem: [C: 032] Hygiene: Cleanup Special:MobileOptions markup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105391 (owner: 10Jdlrobson) [22:14:34]