[10:22:30] <grrrit-wm>	 (03PS1) 10Yuvipanda: Implement type-ahead filtering for language links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105926 
[10:22:31] <grrrit-wm>	 (03PS1) 10Yuvipanda: Move preferred language to top of languagelinks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105927 
[10:44:26] <grrrit-wm>	 (03PS1) 10Yuvipanda: Move Page & Search related things into a package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105932 
[16:11:10] <grrrit-wm>	 (03PS11) 10Pcc: Add an "always expand all sections" option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 
[16:11:11] <grrrit-wm>	 (03PS8) 10Pcc: In alpha mode, save and restore the set of open sections in the history [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 
[16:11:14] <grrrit-wm>	 (03CR) 10Pcc: Add an "always expand all sections" option (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc)
[16:12:30] <grrrit-wm>	 (03CR) 10Pcc: "Fixed tests (and added one)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 (owner: 10Pcc)
[16:13:12] <grrrit-wm>	 (03CR) 10Pcc: In alpha mode, save and restore the set of open sections in the history (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 (owner: 10Pcc)
[16:24:08] <grrrit-wm>	 (03CR) 10Theopolisme: Warn user when attempting to switch modes without cookies (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104210 (owner: 10Theopolisme)
[17:33:56] <yuvipanda>	 brion: hey!
[17:33:57] <brion>	 i see.... code review in my future
[17:33:59] <yuvipanda>	 hehe
[17:34:00] <yuvipanda>	 :D
[17:34:06] <brion>	 better brew another cup of coffee :D brb
[17:34:10] <yuvipanda>	 brion: they are mostly smallish
[17:34:18] <brion>	 nice
[17:40:34] <theopolisme>	 jdlrobson: hey
[17:41:28] <jdlrobson>	 hey theopolisme :)
[17:41:30] <jdlrobson>	 how's the snow?
[17:41:53] <theopolisme>	 well, i'm back in memphis now. and there's no snow, it's just freezing cold outside :p
[17:42:30] <theopolisme>	 but anyways, what can I do that would be the most helpful right now?
[17:43:44] <theopolisme>	 Also re https://bugzilla.wikimedia.org/show_bug.cgi?id=59624, that seems trivial enough, but I wonder if we need to account for language variants as well
[17:44:28] <jdlrobson>	 so i'm pretty sure if a language supports variants there will always be variants
[17:44:38] <theopolisme>	 Yeah
[17:44:38] <jdlrobson>	 so langlinks should be enough
[17:44:46] <jdlrobson>	 let me check)
[17:44:59] <theopolisme>	 Well, so I guess what if there are no interwiki but there are variants
[17:45:07] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=51482 < also captcha support should be super easy and really useful
[17:45:16] <jdlrobson>	 it's just a design tweak and pushing that functionality to stable
[17:46:31] <theopolisme>	 cool, i'll work on that now
[17:47:06] <jdlrobson>	 so i think theopolisme you can ignore variants for the time being. I'm not sure what the correct test is but if you find a way to surface those in the api even better
[17:52:05] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks basically good, a few quick notes for later:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105914 (owner: 10Yuvipanda)
[17:52:30] <yuvipanda>	 brion: language list dialog doesn't have back/home button on the actionbar!
[17:52:34] <yuvipanda>	 brion: also fixed in a later commit :P
[17:52:40] <brion>	 yay
[17:52:57] <brion>	 ah renaming the namespace hierarchy
[17:53:03] <brion>	 i love how java makes you move all your damn files
[17:53:23] <yuvipanda>	 brion: :D
[17:53:25] <yuvipanda>	 brion: yeah
[17:53:46] <yuvipanda>	 brion: I also got the stupid 'INSTALL_FAILED_UID_CHANGED' error when trying to deploy, and the only other solution to fixing that is to reset your goddamn phone
[17:53:50] <yuvipanda>	 so did this instead
[17:53:53] <yuvipanda>	 needed doing anyway
[17:54:10] <brion>	 heh
[17:55:10] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Note to testers: uninstall the old version before installing this to avoid confusion. "Shoot us both, Spock!"" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105915 (owner: 10Yuvipanda)
[17:55:56] <brion>	 throw new RuntimeException("WAT");
[17:55:58] <brion>	 lol
[17:57:14] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Enable 'Up' arrow in LangLinks Activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105916 (owner: 10Yuvipanda)
[17:57:22] <yuvipanda>	 brion: :D
[17:57:38] <yuvipanda>	 brion: next time I'll probably be "such unreachable, much exception, wow!"
[17:58:30] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Setup labels for the Settings & LangLinks activities [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105917 (owner: 10Yuvipanda)
[18:02:30] <brion>	 yuvipanda: so the intermittent crashes i'm seeing following links look like they might be due to getting a bad API response. failure seems to be in LeadSectionFetchTask.processResult, one of those optJSON* calls returns a null perhaps
[18:02:43] <yuvipanda>	 hmm
[18:03:00] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Tapping language link now opens appropriate article [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105919 (owner: 10Yuvipanda)
[18:04:40] <grrrit-wm>	 (03CR) 10Brion VIBBER: Implement type-ahead filtering for language links (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105926 (owner: 10Yuvipanda)
[18:05:35] <yuvipanda>	 brion: good catch
[18:06:09] <brion>	 i was wondering why 'art' didn't turn up results in 'Artist' :)
[18:09:54] <theopolisme>	 jdlrobson, do I need to install  ConfirmEdit to test the captcha stuff?
[18:10:00] <jdlrobson>	 theopolisme: yup
[18:10:14] <theopolisme>	 and then do all the wordlist configuring and setup -.-
[18:10:16] <jdlrobson>	 theopolisme: let me know if you hit any problems - the docs on mediawiki.org are pretty helpful for installation
[18:10:23] <theopolisme>	 Okay, gotcha
[18:10:43] <yuvipanda>	 brion: :D
[18:10:58] <yuvipanda>	 brion: I moved that card to done.
[18:12:22] <jdlrobson>	 nuria: hey. i've got scrum of scrums very soon but should be free to look at the limn graphs afterwards - around 11am my time - do you want to setup a hangout and room?
[18:12:33] <yuvipanda>	 brion: pushed
[18:12:40] <grrrit-wm>	 (03PS2) 10Yuvipanda: Move Page & Search related things into a package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105932 
[18:12:40] <grrrit-wm>	 (03PS2) 10Yuvipanda: Move preferred language to top of languagelinks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105927 
[18:12:42] <grrrit-wm>	 (03PS2) 10Yuvipanda: Implement type-ahead filtering for language links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105926 
[18:12:46] <brion>	 whee
[18:12:49] <brion>	 rebase time
[18:12:49] <nuria>	 Is your time PST?
[18:13:05] <yuvipanda>	 brion: rebased 'em all! :D
[18:13:12] <nuria>	 ya it must be, i have a meeting at that very time
[18:13:20] <dr0ptp4kt>	 jdlrobson: is the new overlay going to be a production, non-beta / non-alpha feature as of next week? or is it beta / alpha?
[18:13:20] <yuvipanda>	 brion: should write about my git workflow sometime. It mostly doesn't need the rebase buttonpushing
[18:13:30] <brion>	 nom
[18:13:40] <jdlrobson>	 dr0ptp4kt: we can talk about it in scrum of scrums
[18:13:51] <dr0ptp4kt>	 jdlrobson: cool
[18:13:54] <jgonera>	 umpfryh91
[18:14:08] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Implement type-ahead filtering for language links [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105926 (owner: 10Yuvipanda)
[18:14:29] <jgonera>	 hah
[18:14:48] <jgonera>	 good I don't reuse password too often ;)
[18:15:09] <yuvipanda>	 brion: standup?
[18:15:16] <nuria>	 jdrobson Since I am in Europe  and i have meeting at 11 am PST already can we book anytime tomorrow?
[18:15:30] <jdlrobson>	 nuria: sure. i dont
[18:15:33] <nuria>	 jdlrobson, sorry 
[18:15:50] <jdlrobson>	 nuria: sure i don't think there is too much to do - i used the new schema but the problem is there is no data before 20th december
[18:15:56] <nuria>	 right
[18:16:01] <jdlrobson>	 so I can't check if it looks right
[18:16:06] <nuria>	 as we implemented the change then
[18:16:27] <jdlrobson>	 nuria: i'll add you to that patchset
[18:16:51] <jdlrobson>	 done
[18:16:55] <nuria>	 But you get the data right?
[18:17:03] <nuria>	 only than you only have 3 weeks of it.
[18:21:18] <chrismcmahon>	 awjr:  hangout link for SoS? 
[18:21:43] <awjr>	 chrismcmahon: rachel just added one to the calendar invite
[18:22:15] <awjr>	 it was neglected when the event got recreated after terry deleted it and i just noticed as well, but it should be there now :)
[18:22:33] <chrismcmahon>	 awjr: got it
[18:24:01] <jdlrobson>	 nuria: yup i think i've understood it correctly
[18:25:11] <nuria>	 jdlrobson: ok, I have time now ( like 40 mins) or otherwise we can talk tomorrow, you are busy now if i understood it right, correct?
[18:25:14] <yuvipanda>	 brion: two patches left! :D
[18:25:41] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Move preferred language to top of languagelinks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105927 (owner: 10Yuvipanda)
[18:25:53] <yuvipanda>	 brion: hah :D
[18:25:58] <jdlrobson>	 i've got to go to a meeting now nuria so will have to be tomorrow :(
[18:26:08] <jdlrobson>	 if i finish early i'll let you know
[18:26:09] <nuria>	 very well
[18:32:03] <mhurd>	 yuvipanda: brion: tfinc: should it be ok to do these videos w/o sound and let kenan narrate? i think it would be simpler that way...
[18:32:12] <yuvipanda>	 mhurd: agrered
[18:32:23] <tfinc>	 mhurd: yes
[18:32:28] <mhurd>	 :)
[18:32:35] <brion>	 yeah totally
[18:34:14] <mhurd>	 yuvipanda: brion: what's being done on android if a user is, say, on english page, switches lang to greek, goes back to page and tries a link. presently on ios the english page is still onscreen and link-no-work-bad-sadness
[18:35:03] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "Can't build; PageQueryTask doesn't seem to have been moved into the page subnamespace so I get a compile error in, eg, PageImagesTask." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105932 (owner: 10Yuvipanda)
[18:35:04] <jdlrobson>	 theopolisme: should i assign one of those bugs to you to ensure no one else works on it?
[18:36:01] <theopolisme>	 jdlrobson, sure, the language/api one :) 
[18:36:07] <jdlrobson>	 ok will do theopolisme 
[18:36:44] <jdlrobson>	 theopolisme: there you go assigned - https://bugzilla.wikimedia.org/show_bug.cgi?id=59624
[18:36:51] <theopolisme>	 gracias
[18:44:33] <theopolisme>	 jdlrobson: would adding prop=hasvariants be acceptable?
[18:44:53] <theopolisme>	 or should i return the number of language variants as well? i see no need
[18:50:29] <theopolisme>	 jdlrobson: would adding prop=hasvariants be acceptable?
[18:50:30] <theopolisme>	 or should i return the number of language variants as well? i see no need
[18:50:45] <jdlrobson>	 theopolisme: sorry in meeting
[18:50:48] <theopolisme>	 ah ok
[18:50:49] <jdlrobson>	 theopolisme: i guess it is a question of consistency. i don't have any objections to it
[18:51:00] <theopolisme>	 okay
[18:51:00] <jdlrobson>	 Just submit the patch and be prepared for a rename :)
[18:51:05] <theopolisme>	 Heh
[18:51:18] <jdlrobson>	 MaxSem might have the most opinion but he's not here
[18:51:30] <jdlrobson>	 do what makes sense to you - i trust your opinion :)
[19:01:10] <jdlrobson>	 http://www.youtube.com/watch?v=OQ1a9LhkIoQ < mr. narwhal
[19:02:53] <jdlrobson>	 kaity: https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FMobileFrontend.git
[19:16:53] <awjr>	 tfinc, kenanwang_: i just noticed on the calendar that our quarterly review with erik and sue is next week
[19:17:07] <awjr>	 1/15
[19:19:22] <grrrit-wm>	 (03PS1) 10Theopolisme: Hide languages link if no languages available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 
[19:21:01] <theopolisme>	 jdlrobson: ^
[19:21:12] <jdlrobson>	 sweet theopolisme :)
[19:21:41] <jdlrobson>	 ^ kaldari could you take a look as well?
[19:21:52] <jdlrobson>	 theopolisme: seen a console.log ;-)
[19:21:56] <theopolisme>	 oops
[19:21:57] <theopolisme>	 :p
[19:22:31] <grrrit-wm>	 (03PS3) 10Yuvipanda: Move Page & Search related things into a package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105932 
[19:22:33] <yuvipanda>	 brion: fixed!
[19:22:44] <brion>	 \o/
[19:22:46] <grrrit-wm>	 (03PS2) 10Theopolisme: Hide languages link if no languages available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 
[19:24:46] <grrrit-wm>	 (03CR) 10Jdlrobson: "Some thoughts..." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 (owner: 10Theopolisme)
[19:25:11] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Move Page & Search related things into a package [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/105932 (owner: 10Yuvipanda)
[19:25:29] <yuvipanda>	 brion: sweet
[19:25:43] <brion>	 ok that's all outstanding merges
[19:25:56] <brion>	 mhurd: ping me when you're ready next :D
[19:26:02] <brion>	 yuvipanda: anything else before i grab a bite to eat?
[19:26:14] <yuvipanda>	 brion: nothing for today. I'll go to sleep in about 5 minutes :)
[19:26:21] <brion>	 hehe ok
[19:26:21] <yuvipanda>	 brion: should have ToC done when you wake up
[19:26:27] <brion>	 awesome, i'll be ready to review it
[19:26:32] <brion>	 gnight
[19:26:55] <mhurd>	 brion: will do! have a good sleep yuvi!
[19:27:01] <brion>	 STOP. Sandwich time
[19:27:07] <mhurd>	 hehe
[19:30:53] <theopolisme>	 jdlrobson: sure, we can do that.
[19:31:20] <yuvipanda>	 mhurd: btw, I'm using the same underlying logic in the android app too
[19:31:30] <yuvipanda>	 mhurd: only the list of languages returned by wiki are allowed
[19:31:42] <yuvipanda>	 mhurd: also we should just bundle that list in, since that hardly changes
[19:32:02] <yuvipanda>	 mhurd: I've a python script in the android repo that gets you that list, and also orders them in 'good articles count' order :D
[19:32:23] <mhurd>	 yuvipanda: sounds good. oh, what do you do if user switches lang - on english, switch to greek, back to page (still english), taps link...
[19:32:32] <yuvipanda>	 mhurd: hmm? that just works...
[19:32:33] <mhurd>	 yuvipanda: on ios link broken :(
[19:32:53] <yuvipanda>	 mhurd: if I tap a link on a page I am looking at, then I use the language of that page to lookup things
[19:33:11] <yuvipanda>	 mhurd: on Android each PageTitle object contains a Site reference, which references which language it points to
[19:33:27] <yuvipanda>	 so code has always taken that into account from the start, and mostly 'just works'
[19:33:48] <DarTar>	 jdlrobson, jgonera: can you guys check if my message on UAs for EventLogging went through on mobile-tech?
[19:33:49] <yuvipanda>	 mhurd: so everywhere you are dealing with titles and the API, you must always pass the site info around
[19:33:56] <yuvipanda>	 mhurd: no way to centrally storre that
[19:34:26] <mhurd>	 yuvipanda: doing something similar, but need to adjust a bit
[19:34:31] <yuvipanda>	 right
[19:34:53] <yuvipanda>	 mhurd: also call it 'site' and not 'language' - so in the future if we decide to support wiktionary or whatever, should work too
[19:36:00] <mhurd>	 yuvipanda: i did same, site for url and domain for "en" or "de" etc (just copied api naming)
[19:36:08] <yuvipanda>	 mhurd: nice.
[19:37:51] <grrrit-wm>	 (03PS3) 10Theopolisme: Hide languages link if no languages available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 
[19:39:28] <theopolisme>	 alright jdlrobson, i've modified it. Also, random question, why does jenkinsbot +1 verify some patchsets and +2 verify others?
[19:40:47] <jdlrobson>	 it depends on the project theopolisme i think
[19:40:57] <jdlrobson>	 it tends to +2 verify when a patch is submitted
[19:42:59] <theopolisme>	 jdlrobson: https://gerrit.wikimedia.org/r/#/c/101123/ vs https://gerrit.wikimedia.org/r/#/c/105988/ :/ it's not a big deal or anything I was just curious :)
[19:45:44] <jdlrobson>	 mm theopolisme i guess it might be some weird config - the first patch runs less tests than the last
[19:45:57] <jgonera>	 DarTar, it did
[19:46:02] <jdlrobson>	 asking someone in #wikimedia-dev might bring more light to this - maybe hasher :)
[19:46:11] <jdlrobson>	 *hashar
[19:46:13] <DarTar>	 jgonera: thanks
[19:46:40] <jgonera>	 DarTar, where can I read more about sanitized UAs?
[19:47:27] <DarTar>	 there's a long thread started on analytics-internal, we should have started this on the public list instead :(
[19:47:39] <DarTar>	 and/or wikitech-l
[19:47:53] <jgonera>	 DarTar, but in one sentence? ;)
[19:48:23] <DarTar>	 let me send you the original mail, it takes more than one sentence 
[19:48:33] <jgonera>	 DarTar, thanks
[19:48:57] <DarTar>	 nuria and ori are busy with the deployment but will share the details when it's done
[19:50:39] <DarTar>	 jgonera: some basic info is already available here: https://www.mediawiki.org/wiki/EventLogging/UserAgentAnonymization
[19:50:59] <DarTar>	 what's missing is the technical discussion on the actual implementation
[19:52:21] <theopolisme>	 jdlrobson: i think it depends on whether or not someone has +2
[19:52:36] <tfinc>	 awjr|lunch: ORLY. i'm going to push it forward
[20:03:08] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 1581: Design tweaks to user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105994 
[20:03:09] <grrrit-wm>	 (03PS1) 10Jdlrobson: Remove page from last thanked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105995 
[20:03:16] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 1581: Remove user intent from profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105996 
[20:53:34] <grrrit-wm>	 (03CR) 10Legoktm: Remove page from last thanked (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105995 (owner: 10Jdlrobson)
[21:03:17] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Awesome! thanks Theo! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 (owner: 10Theopolisme)
[21:03:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hide languages link if no languages available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 (owner: 10Theopolisme)
[21:04:30] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "oops QUnit tests need updating!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 (owner: 10Theopolisme)
[21:08:17] <mhurd>	 tfinc: do u have a sec?
[21:08:23] <tfinc>	 mhurd: hmm ?
[21:08:55] <mhurd>	 tfinc: wanted to show u something may and i are experimenting with
[21:09:11] <tfinc>	 sure. i'm on the couches by the whiteboard. come by whenever 
[21:14:08] <jdlrobson>	 theo|away: a few qunit tests need to be fixed before i can merge :(
[21:36:32] <grrrit-wm>	 (03PS14) 10Jdlrobson: New A/B test for Sign-up Edit Guider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 (owner: 10Kaldari)
[21:44:07] <grrrit-wm>	 (03PS4) 10Theopolisme: Hide languages link if no languages available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 
[21:44:09] <Guest28138>	 jdlrobson: there we go ^
[21:44:23] <Guest28138>	 I wish qunit would run on the patchsets...
[21:50:16] <brion>	 mhurd: gonna run some errands, be back in a while. ping me when ready for the next awesome commit :D
[21:50:35] <mhurd>	 brion: will do! sry taking so long
[21:54:02] <brion>	 take the time you need, you're tweaking visuals it takes trial and error :D
[21:55:55] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Story 1516: New A/B test for Sign-up Edit Guider (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 (owner: 10Kaldari)
[21:56:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Story 1516: New A/B test for Sign-up Edit Guider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104790 (owner: 10Kaldari)
[21:59:29] <theopolisme>	 jdlrobson, trying to work on the captcha thing, but apparently i fist have to install the latest version of xcode command line tools, yadda yadda yadda
[22:00:19] <jdlrobson>	 theopolisme you do?
[22:00:25] <jdlrobson>	 which step are you on?
[22:00:37] <theopolisme>	 installing pil. Apparently it disappeared when I upgraded to 10.9
[22:00:41] <jdlrobson>	 theopolisme: in terms of qunit are you familiar with make qunit in MobileFrontend ?
[22:00:43] <theopolisme>	 (re)installing that is
[22:00:54] <jdlrobson>	 you can also install the git hook which automatically runs it on all your commits
[22:01:02] <jdlrobson>	 (run make installhooks to install that)
[22:01:07] <theopolisme>	 oh cool!
[22:01:37] <theopolisme>	 yeah I tend to use Special:JavaScriptTest/qunit if there are problems since it pretty prints diffs and such
[22:03:36] <awjr>	 kaldari jdlrobson: i just saw the email thread about lightning deploys - did you get something scheduled already?
[22:05:24] <kaldari>	 yes
[22:05:26] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Reshuffle content / page action overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106128 
[22:05:27] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Prevent random campaign interfering with A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106129 
[22:05:51] <jdlrobson>	 kaldari: can you prioritize https://gerrit.wikimedia.org/r/#/c/106129/ please?
[22:06:02] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Prevent random campaign interfering with A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106129 
[22:09:30] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Hygiene: Prevent random campaign interfering with A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106129 (owner: 10Jdlrobson)
[22:10:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Prevent random campaign interfering with A/B test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106129 (owner: 10Jdlrobson)
[22:16:17] <theopolisme>	 jdlrobson, so does the captcha styling stuff need to be done in the confirmedit extension?
[22:16:30] <theopolisme>	 ext.confirmEdit.fancyCaptcha.styles?
[22:22:48] <jdlrobson>	 theopolisme: yes that would be best
[22:23:21] <jdlrobson>	 sorry for the late reply!
[22:24:14] <jdlrobson>	 theopolisme: although you'll want to be careful not to break the desktop styling
[22:25:13] <theopolisme>	 yeah
[22:42:23] <theopolisme>	 okay, restarting, hopefully pil will now work
[22:49:11] <tfinc>	 awjr: see praveens response :)
[22:49:26] <tfinc>	 awjr: my gut instinct was right
[22:49:37] <awjr>	 tfinc: oh, you didn't want to go for this friday? :p
[22:49:59] <theopolisme>	 groan... jdlrobson, pil still isn't working :/
[22:51:03] <tfinc>	 awjr: nothing like working on one on the ferry to Tiburon :)
[22:53:43] <theopolisme>	 yay it finally worked!
[22:58:55] <awjr>	 brion: during sos this morning you mentioned there was a patchset that needed review from platform/security - can you give me a link to the patch?
[22:59:15] <brion>	 awjr: not done yet, will send it out when ready
[22:59:22] <awjr>	 cool thanks!
[22:59:32] <brion>	 just wanted to make sure i had the usual suspects on notice :)
[22:59:39] <awjr>	 :D
[23:04:30] <jdlrobson>	 theopolisme: yey :)
[23:04:47] <theopolisme>	 spoke too soon, explosions
[23:05:02] <jdlrobson>	 haha typical :)
[23:05:07] <theopolisme>	 bascially now i'm just trying everything on stackoverflow ever. :D
[23:11:22] <jdlrobson>	 chrismcmahon: is there any reason why upload_image.feature is not part of uploads.feature
[23:11:25] <jdlrobson>	 i find this very confusing..
[23:11:42] <grrrit-wm>	 (03PS4) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 
[23:12:20] <grrrit-wm>	 (03CR) 10Jdlrobson: "Fixed issues with deprecation notices and tests. Added FIXMES" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson)
[23:13:50] <chrismcmahon>	 jdlrobson:  I'd suggest "uploads.feature" is misnamed.  It seems to be about a tutorial screen for a new user.  "upload_image.feature" is about uploading an image. 
[23:15:41] <theopolisme>	 jdlrobson: https://gerrit.wikimedia.org/r/#/c/105988/ is ready for merge btw :)
[23:15:47] <theopolisme>	 then we can get it to stable
[23:15:57] <jdlrobson>	 sweet thanks theopolisme will take a look in a sec
[23:16:08] <jdlrobson>	 chrismcmahon: depends how you organize features
[23:16:13] <jdlrobson>	 uploads.feature is all about Special:Uploads
[23:16:46] <jdlrobson>	 i'm trying to introduce lead_photo_uploads.feature for uploading a lead image
[23:17:13] <jdlrobson>	 upload_image is very ambiguous
[23:17:27] <jdlrobson>	 uploads_page.feature would make sense imo
[23:18:26] <chrismcmahon>	 jdlrobson:  the way I read it, uploads.feature is about a new user navigating to Special:Uploads and seeing a tutorial.   
[23:18:42] <jdlrobson>	 at the moment yes but i plan to add more tests to it
[23:18:57] <jdlrobson>	 the behavior on that page differs depending on the type of user you are
[23:19:08] <jdlrobson>	 if you have no uploads you see a tutorial, if you do you see an upload overlay
[23:19:32] <jdlrobson>	 so actually upload_image.feature complements those tests
[23:19:42] <jdlrobson>	 i was about to write a test which did exactly the same before realizing it already existed
[23:21:30] <chrismcmahon>	 jdlrobson:  I still think "uploads.feature" is poorly named, and should be "new_user_sees_upload_tutorial.feature" or some such.   Maybe it should be "uploads_new_user.feature" if more stuff should happen.  
[23:22:13] <jdlrobson>	 chrismcmahon: well this is what i'm asking - what is the definition of a feature
[23:22:18] <jdlrobson>	 is a page a feature?
[23:22:52] <jdlrobson>	 as upload_image is also too ambiguous
[23:22:58] <jdlrobson>	 uploads_page_upload_image would make more sense there
[23:23:29] <chrismcmahon>	 jdlrobson:  is there a place other than the uploads page to upload an image? 
[23:23:35] <jdlrobson>	 chrismcmahon: yes the page itself
[23:23:37] <jdlrobson>	 as a lead photo
[23:23:43] <jdlrobson>	 (on an article page)
[23:23:53] <jdlrobson>	 (my patch adds tests for that)
[23:24:11] <chrismcmahon>	 aha, cool.  feel free to rename upload_image.feature if you want
[23:24:37] <chrismcmahon>	 upload_image_on_upload_page or some such
[23:31:06] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 031] Future proof ZeroOverlay [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103404 (owner: 10Jdlrobson)
[23:31:25] <dr0ptp4kt>	 ^yurik this works for me. your turn.
[23:38:47] <jdlrobson>	 kaldari: ngrok
[23:41:12] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 04-1] "Why not re-use the "When I upload Mobile file image.png" step from upload_image.feature? That seems much more DRY and also more robust th" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson)
[23:43:51] <theopolisme>	 jdlrobson: it worked! for real!
[23:43:58] <theopolisme>	 yay my afternoon has not been in vain
[23:49:21] <grrrit-wm>	 (03PS8) 10Jdlrobson: Beta Feature: Register mobile skin, offer users the ability to change it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 
[23:50:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Beta Feature: Register mobile skin, offer users the ability to change it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson)
[23:50:09] <grrrit-wm>	 (03CR) 10Jdlrobson: "After talking to Jared, have suggested it as a BetaFeature to start off with. Feedback will be useful." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson)
[23:52:03] <grrrit-wm>	 (03PS10) 10Jdlrobson: Beta Feature: Register mobile skin, offer users the ability to change it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 
[23:53:03] <grrrit-wm>	 (03CR) 10Jdlrobson: "@Chris This is a totally different workflow.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson)
[23:53:48] <grrrit-wm>	 (03CR) 10Jdlrobson: "Now maybe you see the confusion I was talking about in IRC with our current feature names.. :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson)
[23:56:13] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hide languages link if no languages available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 (owner: 10Theopolisme)
[23:56:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hide languages link if no languages available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 (owner: 10Theopolisme)