[00:00:24] (03CR) 10Cmcmahon: "The only difference between the existing step and your step is that your new step has a hard-coded file name while the existing step takes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson) [00:34:16] (03PS5) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 [00:34:20] (03CR) 10jenkins-bot: [V: 04-1] QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson) [00:38:05] (03PS6) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 [01:07:32] (03PS1) 10Kaldari: Fix header buttons with new header style [beta] [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106175 [01:09:39] (03CR) 10Kaldari: [C: 032] Fix header buttons with new header style [beta] [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106175 (owner: 10Kaldari) [01:25:20] jdlrobson: shouldn't those bugs be made blockers of the tracking bugs and not dupes? [01:25:46] legoktm: i handle bug triaging for MobileFrontend and this way they will get more attention [01:25:56] otherwise they will end up in the blackhole of bugzilla [01:26:05] alright.... [01:27:27] ok, well I moved the Thanks bug into the MF component then [01:49:15] (03PS1) 10Kaldari: Story 1563: [WIP] Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [03:13:13] (03PS1) 10Mhurd: Languages interface downloads and presents list of wiki languages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106183 [03:14:19] brion: ^ there are issues with it - especially when switching languages and going back to the page and tapping links. will need further work [03:17:46] brion: (i think i know what's happening with the links - just didn't want to hold things up further) [06:13:15] mhurd: if it is displaying list of *all* wikis, you should just package it statically into the app. That hardly changes, and the API query takes some time [06:14:29] zz_yuvipanda: ya i did. i also update the list in the background, but the updated file doesn't actually get used until the *next* time the list is called up [06:15:14] that way it's nice and snappy and the ui never gets a flicker for forcing refresh [06:15:33] and it's pretty up to date :) [06:16:43] mhurd: hmm, right. I just ship it statically and have a python script that updates it :) [06:16:54] mhurd: that way I can also order them more meaningfully than by random unicode order [06:17:18] mhurd: just saying that it doesn't *need* to be up to date - I think we last added a new language more than 2 years ago :P [06:17:35] zz_yuvipanda: i'm gonna add your sort later [06:17:38] oh, true [06:17:53] mhurd: yeah, so updating it in app is just extra code, and that API call takes a *long* time to return as well [06:18:27] mhurd: and if you start using the same ordering I am using ('good' articles count, or even articles count), then that will hit a labs endpoint and you are theoretically not supposed to use those in production apps [06:20:20] mhurd: so I do recommend just statically putting it in and not updating it as such :) [06:21:36] zz_yuvipanda: i don't understand the labs implications, but if it's an issue i can comment out the line that does the query [06:21:55] mhurd: just saying it's not worth the hassle, but oh well [06:23:12] ah you're saying if i used the query to get the traffic info for purpose of sorting that would be slow! [06:23:39] i think i see how that could be, but i hadn't planned on doing that :) [06:24:18] mhurd: no, I'm saying that doing it at *runtime* even to update is rather useless, since it hardly updates [06:24:58] https://wikistats.wmflabs.org/api.php?action=dump&table=wikipedias&format=csv&s=good is the one that actually gives me the list sorted by number of 'good' articles [06:25:11] that makes sense too [06:26:01] mhurd: so was just going to suggest you rip out the runtime updates :P less code is better, especially if said code is making slow / large network calls :) [06:28:52] i'm using this: "action=query&meta=siteinfo&siprop=languages&prop=langlinks&format=json" [06:31:59] mhurd: yup, that's not quick. [06:32:36] YuviPanda: fair enough. will yank it. [06:32:41] mhurd: :) [06:33:10] mhurd: I think just updating it every time we make a release will be good enough. At *best* we add a new language once every two years or so now, so... [06:33:39] YuviPanda: can u point me to the file with the ordered set on android? [06:33:59] mhurd: moment [06:34:10] mhurd: I have it in XML, however. if you want I can make a JSON version for you :) [06:34:27] oooh ya! [06:34:33] json! [06:34:37] mhurd: https://github.com/wikimedia/apps-android-wikipedia/blob/master/wikipedia/res/values/languages_list.xml is the android one [06:34:46] mhurd: give me five minutes, let me hook up a JSON version [06:34:56] YuviPanda: thank u! [06:35:33] mhurd: do you want just the language code, or language code and name? [06:35:45] name too! was just going to ask :) [06:36:06] mhurd: heh, ok! [06:42:04] YuviPanda: i added language to saved pages and history: http://imgur.com/tfWziWh http://imgur.com/MfANxD3 http://imgur.com/dObjUJs [06:44:33] mhurd: https://dpaste.de/oeUj [06:45:22] (03PS1) 10Yuvipanda: Modify language generation script to make JSON for iOS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106190 [06:45:26] YuviPanda: thanks! that's perfect and awesome! [06:45:40] mhurd: and that patchset updates the script to generate the json and XML files for next time :) ^ [06:45:48] woohoo! [06:45:51] mhurd: ah, nice. I should also add language to saved pages and history I think [06:47:09] YuviPanda: updating w/json file... [06:47:10] mhurd: yeah, this will let you get rid of the language code itself, I think [06:47:21] if you want, that is. bad UX and all [06:48:09] was only showing the code on the lang selection page... i think [06:48:58] mhurd: right, but I guess you can show the 'canonical name' instead. Most people have no idea about language codes... [06:49:52] i think the first image i sent shows both the name (not canonical) and the code [06:50:38] mhurd: yeah, am talking about getting rid of the code, and showing the name in the language itself and also the canonical name, instead of name an language code [06:50:39] *and [06:50:41] hi violetto [06:50:51] ahhh got it [06:50:55] good idea [06:51:03] sry tired :) [06:51:13] mhurd: haha :D [06:51:18] mhurd: pfft, you should be asleep! [06:51:26] YuviPanda: sup [06:51:28] mhurd: I also emailed you a screenshot of how language selection looks on Android [06:52:05] violetto: working on ToC in the next few hours, then editing :) [06:52:07] violetto: basing it off http://invis.io/A2LIOY67 [06:52:12] YuviPanda: ah cool. i'll do that [06:52:35] mhurd: the android version also has search, so you can type to filter the list of languages :) [06:52:39] super useful, I think [06:52:51] YuviPanda: yes. will def add that later! [06:52:58] ya :) [06:55:01] YuviPanda: spoke with mhurd today about the ToC, we messed around abit and thought the side by side view seemed like a better option kinda like the original mock up ever: https://www.dropbox.com/s/m1dn8h5bsc1s7cr/Screenshot%202014-01-07%2022.57.29.png without the short summary [06:55:17] im going to try to work on it tonight and talk to jared tomorrow and see what he thinks [06:55:22] violetto: not enough space to do anything there, no? [06:55:26] violetto: especially on landscape [06:55:45] violetto: err [06:55:47] i mean portrait [06:56:00] we tried it on the phone today it looked very clear [06:56:09] violetto: anyway, I'll push starting work on it for a day to see what you guys come up with?} [06:56:34] yeah that'd be really nice [06:56:58] violetto: okay, will do that. [06:57:07] YuviPanda: i was actually thinking about landscape having more problems with the side by side [06:57:13] violetto: oh? [06:57:14] YuviPanda: i'll send u screenshots as soon as i can hook it back up again - (w/o summary text) [06:57:20] cus of the narrow horizontal space [06:57:25] hmm, true [06:57:31] YuviPanda: okay koo [06:58:03] violetto: on Android, low end devices have tiny screens - sometimes as low as 240px wide. so with that you only get 120px each if you split those halfway [06:58:15] so will have to keep that in mind [06:58:20] ofcourse, you also get hugeass devices [06:58:44] YuviPanda: yeah we might have to do a combination of both side by side and overlay [06:58:51] right [06:58:52] overlay for smaller phones and landscape view [06:58:57] YuviPanda: could have simpler fallback for low res? [06:58:57] i need to think about this more [06:59:02] yeah exactly [06:59:05] yeah [06:59:19] but i wonder do those devices have the capability to download apps? [06:59:20] but yeah, i don't want to do two versions of it, one for low res and one for high :P [06:59:24] violetto: they do! [07:00:05] i'll make it so it's an easy transition at least from side by side to overlay [07:00:12] not like a completely different design [07:00:14] YuviPanda: that's my preference too. but let the fancy devices have nice things :) [07:00:20] violetto: although not very common. 320 is a more common width though [07:00:36] but a design that works on overlay and side by side [07:00:38] violetto: true. but also if you are showing the article content side by side, won't images, etc get squished? [07:00:40] if that made sense [07:00:46] yeah, it does [07:00:49] 'graceful degradation' [07:01:10] the point of the birds eye view is so you get exactly that with very little details [07:01:17] violetto: anyway, I'll let you work on it in peace for now than pester you with questions :D [07:01:36] images will squish but there is help on the left side of the screen [07:01:44] violetto: I'll go have breakfast now, brb in about 15m [07:01:51] YuviPanda: okay [07:01:55] good! [07:41:30] (03PS2) 10Mhurd: Languages interface presents list of wiki languages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106183 [07:41:49] YuviPanda: ^ all your fault ;) [07:41:57] haha :D [07:45:48] YuviPanda: sleepytime! thanks again for the help!! [07:45:57] mhurd: :D have a good night! [07:46:11] YuviPanda: seeya! [11:26:22] (03CR) 10Siebrand: [C: 031] "I18n/l10n reviewed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105996 (owner: 10Jdlrobson) [12:55:33] (03CR) 10Siebrand: [C: 04-1] "I-8n/l10n reviewed" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105995 (owner: 10Jdlrobson) [13:06:40] (03CR) 10Siebrand: [C: 031] "I18n/l10n reviewed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105994 (owner: 10Jdlrobson) [13:21:42] hey MaxSem [13:21:46] yo [13:22:23] MaxSem: I'm going to use action=parse to get wikitext of individual sections. [13:22:28] MaxSem: is that a bad idea? [13:22:31] should I use something else? [13:22:36] it is [13:22:49] it'll break at least citations [13:22:55] probably, much more [13:23:14] MaxSem: hmm? why citations? [13:23:24] okay, I think I can use prop=revisions instead [13:23:25] also, section parses aren't cached so you will be eaten alive [13:23:28] right [13:23:33] but prop=revisions? [13:23:37] action=query [13:23:50] ah, wikitext [13:23:53] what for? [13:23:54] MaxSem: this is for per-section editing, so I don't think caching will have much of an issue [13:24:58] yeah, use prop=revisions [13:25:25] sweet :) [13:25:45] MaxSem: I can pass the section number from mobileview into rvsection, right? [13:25:50] I guess they're compatible? [13:26:13] yep [13:26:27] sweet! [13:26:37] MaxSem: we're doing anonymous editing in the app. should be fun :P [13:27:05] omg flood is coming [13:27:09] hehe [13:32:08] MaxSem: also started committing to Extension:MobileApp. Talked to hashar and it should be in betalabs in a few days. hopefully can go into prod in a few weeks time [13:32:12] MaxSem: just RL modules [13:33:39] did i miss anything? [13:42:55] :) [14:14:24] (03PS1) 10Yuvipanda: Add a task to fetch a section's wikitext (+ test) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106248 [16:05:09] brion: hey! [16:36:33] hmm, the wikipedia app on Android is about 9k LoC now [16:41:46] YuviPanda, I assume that's not good? ;) I mean, it's Java, it's probably normal [16:55:54] violetto, have you fixed your laptop? I know you'll probably have lots of things to catch up with now, so if you want we can delay the button fixes until I'm back (Friday) [16:59:06] jgonera: i got it fixed late yesterday, it'll be better on Friday when you're back, also will be better to just show you what ive been mentioning on emails [17:08:43] violetto, ok [17:11:38] jgonera: heh, yeah, seems normal [17:11:52] jgonera: I bet it'll cross 50k within the year :P [17:12:13] jgonera: MobileFrontend is 40k :P [17:12:39] YuviPanda, that's not a reason to be proud, it should probably be half of that ;) [17:12:53] jgonera: definitely. [17:13:02] jgonera: mediawiki in general should be 1/3 or less of what it is now [17:13:10] yeah... [17:14:01] YuviPanda, after uninstalling any wikipedia android instances from my physical device, and then building from the tip of master, then deploying to the device, on search entry tap i get a network error. any tips? it seems searchResultsList.setOnItemClickListener()'s invocation of displayResults(null) isn't yielding a page download? [17:14:18] dr0ptp4kt: is this recent master? [17:14:23] (that is search results entry tap, e.g., 'Canada' or 'California') [17:14:33] YuviPanda: yeah, the latest [17:14:37] hmm, weird [17:14:41] dr0ptp4kt: no exception? [17:15:07] dr0ptp4kt: it should print an exception to adb lolcat [17:15:13] yesterday i saw some sort of exception, but i think that was elsewhere. one moment [17:15:46] YuviPanda, want to get on a hangout? i can show you what i'm doing on the phone, then we can jump into the debuggert [17:16:19] dr0ptp4kt: ah, sure [17:16:21] dr0ptp4kt: give me a moment [17:16:35] dr0ptp4kt: call me? [17:17:53] hangout calling [17:18:08] ypandian@wikimedia.org [17:18:13] ^YuviPanda [17:44:47] YuviPanda, same behavior in the 4.4.2 vm. i'll find a device [17:44:51] (physical) [17:47:06] dr0ptp4kt: hmm, *very* weird [17:47:52] brion: around? [17:50:41] YuviPanda, bleep, no 4.4 device around. but a 2.3 and 4.1. let's ee if 4.1 gets mad [17:50:54] dr0ptp4kt: gah, ok. [17:51:00] dr0ptp4kt: don't even bother on 2.3 though :P won't even install [17:53:09] YuviPanda: same on the 4.1 samsung s3 [17:53:31] dr0ptp4kt: hmm, is that on both the wifi and 3G? [17:53:55] YuviPanda, lemme toggle to airplane mode and turn on wifi [17:54:00] ok [17:54:38] oh yea, true, they need to change what airplane mode is now [17:55:00] mutante: heh! :) [17:55:14] since IATA allowed .. you heard [17:55:21] yeah [17:56:08] YuviPanda: do you still need a key for stat1 or anything? [17:56:09] howdy [17:56:20] mutante: ah, let me look. sorry, was on 'vacation' [17:56:22] brion: heya :) [17:56:42] YuviPanda: no worries, same here. it was just still an open ticket [17:57:02] YuviPanda: because you asked for stat1, then it became stat1001 [17:57:14] mutante: stat1 still exists, and serves a different role than stat1001 [17:57:34] mutante: stat1001 is public facing, but stat1 is still used for running actual analyses (queries and stuff) [17:57:45] YuviPanda: "He had one on stat1 and was moved to stat1001; see rt #4687 " [17:58:00] " stat1 that is. Yuvi, fine with stat1001, remember being moved?" [17:58:06] * YuviPanda looks [17:58:12] mutante: I don't remember being moved :P [17:58:14] https://rt.wikimedia.org/Ticket/Display.html?id=6531 [17:58:36] oh [17:58:37] mutante: wow [17:58:52] mutante: I... completely forgot I did that [17:58:58] mutante: even now seems to be a complete memory hole :| [17:59:06] but I remember being told by someone to do this, so must've done it [17:59:21] heh:) ok [17:59:57] mutante: yeah, you can close it now :) [18:00:06] mutante: sorry about the delay [18:00:09] hey brion! [18:00:15] YuviPanda: within airplane mode with wifi turned on, same symptom. search results returned. on tap of search result item, "Could not reach the network :(" argh [18:00:29] dr0ptp4kt: I tried in a couple of modes now, can't repro at all :| [18:00:31] YuviPanda: no problem, glad to resolve:) [18:00:36] mutante: thanks :) [18:00:43] dr0ptp4kt: is brion in the office? [18:00:59] YuviPanda: i don't see him just yet [18:02:21] (03CR) 10Brion VIBBER: "I get a slightly different languages_list.xml output from what's currently checked in when I run the updated script. Mostly a couple items" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106190 (owner: 10Yuvipanda) [18:02:31] i'm at home office atm [18:04:03] brion: dr0ptp4kt has a super weird error popping up on his devices (an IOException) that I can't repro at all... [18:04:39] dr0ptp4kt: always or intermittent? [18:04:57] (03PS2) 10Yuvipanda: Modify language generation script to make JSON for iOS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106190 [18:04:58] (03PS2) 10Yuvipanda: Add a task to fetch a section's wikitext (+ test) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106248 [18:05:12] brion: updated. and some things would change position, at least at the bottom of the list. can be ignored, I guess. we'll update script before every market pus [18:05:12] h [18:05:21] ok [18:06:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok now just the minor order changes which is ok \o/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106190 (owner: 10Yuvipanda) [18:06:20] YuviPanda: okay, i think i found a good tablet, just will need to upgrade it. brion: always [18:07:18] funky [18:10:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] "compiles and tests pass \o/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106248 (owner: 10Yuvipanda) [18:11:22] dr0ptp4kt: so no sign of a fail on 4.3 for me; i think i've got a 4.2 or 4.1 around i'll try those after standup [18:12:01] awjr, jdlrobson I forgot: I'll finish after the story prioritization today because I have to wake up at 5:30am tomorrow ;) [18:12:15] brion, thx. i'll upgrade the asus nexus to 4.3 and try it [18:12:18] sounds good jgonera, thanks for the head's up [18:13:58] jdlrobson, I noticed the less files are now in VectorBeta, which is great, but since VectorBeta will contain more than one beta feature, it would be good to have a different directory structure [18:14:16] jdlrobson, in https://gerrit.wikimedia.org/r/#/c/99586/ I mimicked what I saw in core, so a resources directory with subdirectories [18:14:50] brion: standup? [18:22:27] jdlrobson? [18:22:45] ok i've got a 4.2.2 and i can emu 4.1 if necessary ;) [18:22:53] jay dee yell robson! [18:22:54] 1s jgonera [18:23:41] brion: show language selection, quick return and article load speeds too on Android! [18:23:49] brion: remember language selection has filter :) [18:24:57] brion: note there's a bug with the patch from last night where u switch language and go back to article and links don't work. [18:25:20] hmmi managed to get an SSLException about a timeout during a page load [18:25:40] mhurd: ok, do you have a handle on that one? istr some talk on irc about it [18:25:42] ok jgonera can talk now [18:26:04] there's probably a network error i'm not doing anything with [18:26:12] so the directory structure can change somewhat but we have to be careful about image asset paths [18:26:29] i'm taking a look at your patch set now [18:26:36] brion: i need to make a pass through all of them and ensure i'm presenting the error message [18:26:38] (03CR) 10JGonera: [C: 04-1] ""# Stable: +1 edit user scenarios" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson) [18:26:42] kenanwang_: dr0ptp4kt is curious when/whether or not we'll be working on the multimedia viewer [18:26:49] mhurd: ok if you need me to help on tracking that give me a ping [18:26:59] brion: will do thx! [18:27:01] ok [18:27:09] jdlrobson, I can go with a different directory structure as long as it shows which files belong to which feature [18:27:14] brion: gonna do the video stuff first thing this morning [18:27:20] awesome [18:27:28] just don't show the thing that breaks in the demo ;) [18:27:39] BREAK ALL THE THINGS! [18:27:41] jgonera: it should be fine. [18:27:43] heheh [18:27:50] jgonera: on the tests - i think this is a case of your environment being setup differently [18:27:57] dr0ptp4kt: ok i'm not seeing consistent errors on 4.2.2. lemme try an emulator [18:28:03] brion: hehe yeah! [18:28:03] jdlrobson, hm, are you also testing with Firefox? [18:28:08] jgonera: yeh [18:28:11] that's where my tests run [18:28:13] jdlrobson, but the one that has missing steps is not env [18:28:32] I'll have a look why this might be happening [18:28:38] (I mean the failing ones) [18:29:04] in the one that has missing steps, I guess you didn't rename the step in that one following chrismcmahon's suggestions [18:29:29] mm maybe something didn't get checked in [18:29:31] i'll take a look [18:29:53] jdlrobson, also, I'm not sure if steps should start with capital letters (unless it's I) [18:30:04] chrismcmahon, do we have any guidelines for that? ^ [18:30:17] brion, thx [18:30:21] brion: have u ever tried inverting the colors on ios7? settings>general>accessibility [18:30:33] mhurd: ! i have not.... something to try :D [18:30:37] jgonera: When(/^I upload Mobile file (.+) on (.+)$/) do |file_name, page| [18:30:40] that's defined for me.. [18:30:53] brion: nice for reading late at night & for proofing ui elements [18:30:55] yes, but you're not using it in the scenario I pointed out [18:30:57] jdlrobson, ^ [18:31:12] what are you running jgonera [18:31:17] jgonera: steps may start with either lowercase or capital, I think we have some of both [18:31:20] you're using the old one, the one you defined [18:31:36] (which now didn't exist) [18:31:48] jgonera: what are you running on your command line [18:31:58] I see chrismcmahon, it just looks odd to have Given That instead of Given that [18:32:05] jdlrobson, that's irrelevant in this case... [18:32:08] brion: ok if i submit that nav update separate from last night's lang patch? [18:32:15] mhurd: sure [18:32:17] jdlrobson, cucumber -f pretty features/*upload* [18:32:25] brion: cool [18:33:05] ahh ok i see what you mean yeh - i don't seem to have committed that change [18:33:11] Awjr probably will not end up working on it this quarter [18:33:37] jgonera: there is no upload feature [18:33:48] kenanwang_: thanks :) [18:33:56] i see an issue on lead_photo_uploads.feature [18:34:01] which i've now fixed [18:34:11] jdlrobson, I'm not sure I'm following, there are certainly files in the features/ directory that have the word "upload" in their name... [18:34:39] jgonera: to be clear i specifically want to know the exact command you are running e.g. bundle exec cucumber -f pretty features/upload_page_upload_image.feature passes for me [18:34:45] as does bundle exec cucumber -f pretty features/lead_photo_uploads.feature [18:34:51] I gave you the exact command [18:35:07] which also did run some irrelevant tests too [18:35:25] ok i understand now you are running with the wildcard i thought you were emphasizing that [18:35:31] no ;) [18:36:15] ok so i made one slight change to redefine and undefined step and now they are passing. I'm not seeing any timeouts that you reported [18:37:10] Note that command also runs required_uploads_steps which I have not changed [18:37:35] (03PS7) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 [18:37:37] (and seems to be specific to wikipedia) [18:38:25] * brion hmms [18:38:34] jdlrobson, yeah, I know [18:38:35] 4.1.2 emu seems ok [18:38:47] jdlrobson, I'll check why it might be failing for me in a moment [18:40:00] jgonera: i noticed one of the users needs to have made an edit [18:40:03] for these tests to pass [18:40:17] another annoyance with the current problem of tests not having their own environment [18:40:31] if it's timing out on an upload that's probably why [18:43:08] jdlrobson, which one? Selenium_user? [18:43:17] jdlrobson: I see it as a benefit of a shared test environment. But you [18:43:34] jdlrobson: but you're right, we are working on env-agnostic test tools. [18:44:00] jgonera: yeh Selenium user must have an edit count of > 0 [18:44:09] jdlrobson, I'll check that [18:50:12] dr0ptp4kt: well no luck reproducing err on 4.1.2, 4.0.3, or 4.0 emu for me :( [18:58:56] jdlrobson: fixed those links https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1522 [19:02:21] (03PS1) 10Yuvipanda: Add utility method to find a section with a given id (+tests) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106310 [19:06:45] (03CR) 10Brion VIBBER: "'Show languages' / 'Hide languages' doesn't seem to have any effect other than toggling which label is on that item. Is there something mi" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106183 (owner: 10Mhurd) [19:07:37] brion: hmmm... [19:07:42] brion: will check [19:08:47] brion: do u see the complete lang list when u tap "show languages"? [19:08:57] mhurd: no i see "hide languages" [19:09:04] brion, you're going to make me cry. i think you have a supercomputer for a machine, though :) you gonna be around? i was thinking we should compare notes on our setups and see if it has something to do with my ide and compilation [19:09:36] brion: weird... even after delete app and re-install? [19:09:53] mhurd: I notice there is Languages/languages.json in the source [19:10:01] but you're loading "languages/languages.json" [19:10:05] iOS has a case-sensitive filesystem [19:10:08] did you test on device? [19:10:14] brion: oh god [19:10:17] :D [19:10:19] one sec [19:10:39] dr0ptp4kt: heh. i'll try and compile it on another machine from scratch and see what happens :D [19:10:48] i'l be around home office all day [19:11:08] brion: sure enough. no worky on device [19:11:12] heh [19:11:19] it's those little gotchas with the simulator :) [19:11:21] brion: *facepalm* [19:11:22] gotta test on device :D [19:11:33] brion: true [19:11:59] dr0ptp4kt: you're on osx or linux, i forget? [19:14:27] brion: os x. i just upgraded the asus nexus 7 device to 4.3, and am trying it from there. fresh install after removing old wikipedia. good news: it doesn't error out right away on search result tap. bad news: it does eventually error out [19:14:41] ah hah [19:14:41] brion: you using intellij? [19:14:45] yeah [19:15:02] dr0ptp4kt: does visiting wikipedia from chrome work? [19:15:09] dr0ptp4kt: is there an error backtrace in log or offered as a report in dialog? [19:15:24] dr0ptp4kt: m. that is? [19:15:35] (03PS3) 10Mhurd: Languages interface presents list of wiki languages. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106183 [19:15:41] brion: ^ [19:16:01] mhurd: thx [19:16:06] jgonera: I guess context is important. I wouldn't use "Given " I would use "Given I am logged in" or "Given Page x exists". Most of our scenarios start with "Given I" so it's moot. [19:16:09] brion: good catch [19:17:29] brion: that "Languages" folder is also where the i18n folder & files will go. will add in later patch... [19:17:38] YuviPanda, yeah, en.m.wikipedia.org and en.wikipedia.org work, https or cleartext. [19:17:43] grrrr [19:18:54] brion, no app crash-talk-to-yuvi dialog. we looked at the onCatch and it's not too helpful. i'm going to set some more breakpoints and see if i can get lucky (stack examination a little hard with some of the asynch stuff, although stepping through provides more clairty) [19:19:25] ok good luck :) [19:19:28] i'll keep poking as well [19:19:37] brion, YuviPanda, the wifi here is kind of slow so i wonder what would happen if i tethered to my idevice :) [19:19:41] let us see [19:19:47] hah [19:20:40] dr0ptp4kt: ok now i see the languages list, but searches never return results [19:20:54] er [19:20:57] mhurd: ^ rather [19:21:08] aha wait it returned, but took a long time. odd [19:21:30] maybe our servers are just shit today? ....... nah looks ok on the graph [19:21:45] brion: hmmm [19:22:07] brion: I see some SSL chatter on -ops [19:22:09] maybe that [19:22:55] YuviPanda: hmm, but https://en.m.wikipedia.org seems very responsive on my desktop [19:23:01]