[00:18:43] team, new diff is now live on testwiki: https://test.m.wikipedia.org/wiki/Special:MobileDiff/190005?mobileaction=beta :) [00:22:01] :D [00:34:31] (03PS1) 10Jdlrobson: WIP: Story 1522: Table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106469 [00:35:16] Sweet Max. I saw it was broken in beta on enwiki! [00:36:12] it requires a config setting to work even in beta [00:36:19] actually wait.. all diffs are broken on mboile [00:37:45] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=59848 [00:38:04] anyway i gotta run [00:38:07] cya tomorrow [00:51:39] kaldari: hey [00:51:46] hey [00:51:52] do you still have the tablet stuff up? [00:51:58] sure [00:52:00] can we take a screenshot? [00:52:09] yeah [00:52:21] thanks kaldari [00:52:22] should I just mail it to you? [00:52:29] yes please [00:52:35] got any stamps? [00:52:38] jk [00:56:41] (03PS1) 10Theopolisme: Add styling for fancycaptcha refresh link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106473 [00:58:35] kaldari: ha maybe we can ask hr? [01:00:57] kaity: email sent! [01:01:10] thanks! [01:50:20] Mhurd were you able to get a video made? [01:58:57] kenanwang_: doing last minute tweaks to TOC with may - will cut video right after done [01:59:05] kenanwang_: sry taking so long! [02:00:02] Ok cool [02:04:10] Brion could I get the source file for that video so I can put on commons? [02:29:09] (03PS2) 10Kaldari: Story 1563: [WIP] Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [03:23:18] mhurd: any luck? [03:24:00] kenanwang_: sooo close! we're getting pretty happy with what we've conjured up [03:25:35] cool [03:55:29] ke [03:55:37] kenanwang_: i have 2 videos! [04:03:40] kenanwang_: you should get a google drive link in your email [04:06:17] great! [04:06:49] kenanwang_: gonna grab food. if u need more let me know! [04:07:25] Awesome looking good so far! [04:07:34] yay! [04:08:48] how's the table of contents get activated now? [04:09:28] nevermind [04:42:08] (03CR) 10Legoktm: "The workflow of having to go to BetaFeatures to enable the skin, and then having to go to another section of your preferences to actually " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [08:50:36] YuviPanda: hey! how goes it? [08:50:41] hey mhurd [08:50:44] mhurd: why aren't you asleep!? [08:51:11] just turning in now :) another late night haha [08:52:26] thought i'd check in and see how editing's going? [08:53:10] YuviPanda: i'll probably ping u tomorrow for outline on the process [08:53:13] mhurd: :D [08:53:22] mhurd: editing's going good, I should have the first card done shortly [08:53:27] mhurd: saving, haven't started on that yet :D [08:53:29] mhurd: sure! [08:53:42] YuviPanda: so exciting! [08:55:08] YuviPanda: alright. off to bed. see ya in a few! [08:56:32] mhurd: see ya [09:10:46] (03PS1) 10Yuvipanda: Handle errors & show progress for Edit Sections [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106495 [15:51:03] hey brion [15:51:08] hey hey [15:51:42] brion: addressing your comments one by one now :) [15:51:46] already have a patch up for the big one [15:51:46] yay [15:52:01] brion: I think maybe 2-3 more patches and this should be done. [15:52:05] and then actually saving this can start :) [15:52:07] sweet [15:54:48] aaaaah effing firefox nightly [15:54:59] on latest version the window close/min/max buttons aren't showing [15:56:10] https://bugzilla.mozilla.org/show_bug.cgi?id=958025 already in bugzilla \o/ [15:57:39] brion: heh :D [16:22:06] (03PS1) 10Yuvipanda: Remove section name from title of edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106527 [17:49:11] (03PS1) 10Yuvipanda: Resize Edit Activity when keyboard is shown [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106543 [17:49:21] brion: hey? [17:50:42] yo [17:51:57] ok lemme refresh my coffee and get ready for a code review binge \o/ [17:51:59] brion: I think I've addressed all your comments in new patches [17:52:01] ok :) [17:52:04] yay [17:53:28] brion: I'll head to sleep earlier today, probably [17:53:47] not staying up for the metrics meeting? :D [17:54:32] brion: most probably not [18:10:09] violetto: around? [18:14:43] brion: specifically, test the 'small sections get to center of activity' bit? I think I've a fix but couldn't find a suitably small seciton :D [18:15:09] heh [18:15:10] ok [18:15:24] * brion waves [18:15:24] hi mhurd [18:16:04] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok we got the missing-file problem fixed up yesterday; merging since there's additional work pending on this commit." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106183 (owner: 10Mhurd) [18:16:18] mhurd: you may commit when ready :) [18:16:29] brion: woohoo! thanks! [18:16:46] mhurd: also note you can queue up multiple commits, it just gets scary if we have to update the earlier ones :) [18:17:01] then it's all rebase time woo [18:17:10] brion: good point! [18:17:18] brion: i do forget that... [18:17:27] (03PS1) 10Mhurd: Split screen table of contents. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106547 [18:17:32] brion: ^ :) [18:17:43] ooooh i'm excited to try that mode [18:18:06] brion: it needs to have a tap on the scaled web view dismiss the TOC, but i can add that soon [18:19:17] dude that looks super awesome [18:19:22] brion: was able to use xpath to finally strip html out of TOC section titles too [18:19:24] brion: yay! [18:19:35] mhurd: i don't suppose we can make both sides scroll at once :D [18:19:56] brion: can experiment w that later for sure :) [18:20:39] brion: may stayed with me until around 8 last night refining the layout. still needs work but i'm super happy with her feedback [18:20:57] this is one of the many things that sucks about living halfway across the world [18:21:08] YuviPanda: soon! [18:22:55] mhurd: did you show YuviPanda the video cap you did? [18:23:20] (03PS1) 10Jhall: WIP Proof-of-concept for browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [18:23:20] brion: emailed google drive link - did u watch yuvi? [18:23:33] no, not yet, mhurd [18:23:38] will do in a bit :) [18:23:55] brion: YuviPanda by the way if u want a good page for testing gnarly TOC look at "the beach boys" article - huge section titles w *lots* of html (the current patch strips the html, but needs work on padding for super long titles) [18:24:05] mhurd: ah, will do! [18:24:14] mhurd: I don't plan on working on it this week, at least. Editing! :) [18:25:01] YuviPanda: oh, anything u can tell me about what you've learned so far working on the editing card? queries and such? [18:25:23] mhurd: sure. NEVER use action=parse or MaxSem and the Ops team will hit you on the head with decomissioned servers. [18:25:29] lol [18:25:51] mhurd: use action=query, prop=revisions [18:26:17] mhurd: and the rvsection parameter to that is the same 'id' that action=mobileview returns [18:26:25] mhurd: so you can keep the id info and get back the wikitext for that section [18:26:27] easily [18:27:40] mhurd: that's about it, really :) [18:27:49] mhurd: I'm going to work on save next - that's the next card. [18:27:52] YuviPanda: yay! so cool. thanks!!!! [18:28:19] mhurd: and that's the hard part. You will have to handle, at the least, 1. User blocks, 2. Autoblocks, 3. Page Protection, 4. Abusefilter blocks, 5. Captchas [18:28:23] mhurd: and probably more that I do not know of [18:28:36] (03CR) 10Jdlrobson: [C: 032] "Looks great!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106473 (owner: 10Theopolisme) [18:29:11] (03Merged) 10jenkins-bot: Add styling for fancycaptcha refresh link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106473 (owner: 10Theopolisme) [18:29:14] YuviPanda: whoa [18:39:13] YuviPanda: for short sections, References is usually good [18:39:22] since it tends to just have a header and a tag [18:39:45] brion: ah, hehe right. will do [18:46:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle errors & show progress for Edit Sections [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106495 (owner: 10Yuvipanda) [18:48:04] yurik, around? [18:49:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] Remove section name from title of edit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106527 (owner: 10Yuvipanda) [18:49:17] (03CR) 10Jdlrobson: "Is there any way we can test this on labs without merging to master? I can't test CORS token requests locally... Maybe Juliusz can?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105116 (owner: 10Kaldari) [19:03:05] PHP Fatal error: Call to a member function getName() on a non-object in /usr/local/apache/common-local/php-1.23wmf8/extensions/MobileFrontend/includes/specials/SpecialMobileContributions.php on line 16 [19:03:07] MaxSem: ^ [19:03:29] Noting wmf8 dies in about a minute [19:03:38] meh [19:04:31] let's see if it manifests itself on newer branches [19:04:48] lol [19:04:49] MaxSem: [19:04:51] PHP Fatal error: Call to a member function getFullURL() on a non-object in /usr/local/apache/common-local/php-1.23wmf9/extensions/MobileFrontend/includes/specials/SpecialMobileEditor.php on line 24 [19:04:54] :D [19:05:05] * MaxSem bites Reedy [19:14:01] jdlrobson: around? [19:14:23] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Woohoo! Definitely an improvement on long sections, much smoother experience." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106543 (owner: 10Yuvipanda) [19:14:42] brion: so only thing left is to have an edit icon? [19:15:05] brion: when we have that we can also not have it on the title, so can't have 'null' coming up; [19:15:29] brion: although we need to handle lead section editing somehow... [19:15:41] hey zz_yuvipanda [19:15:56] jdlrobson: quick question - which RL module in MF loads Mobile.css and Common.css? [19:16:05] or is that magically added by target=mobile? [19:16:16] let me look [19:16:39] mobile.site zz_yuvipanda [19:16:46] great name huh? ;-) [19:16:49] zz_yuvipanda: and make it save for real ;) [19:16:59] brion: next card :P [19:17:01] jdlrobson: looking [19:17:11] hehe [19:17:12] Reedy: can you raise some bugs for those issues? The MobileEditor was recently added via Google Code in. It only gets loaded when you follow an action=edit link [19:17:35] jdlrobson: so the class => MobileSiteModule does the magic? [19:17:41] yup [19:18:33] jdlrobson: ah, sweet. thanks :) [19:36:38] hi violetto [19:38:02] zz_yuvipanda: zombiemode [19:38:39] violetto: hehe, almost :D [19:40:14] violetto: I'll go sleep soon. Just putting final touches on the edit icon [19:40:18] violetto: stole it from MF [19:44:57] YuviPanda: MF? [19:45:17] violetto: MobileFrontend, aka Mobile Web [19:45:23] the pencil icon [19:46:22] YuviPanda: does it look like that: https://www.dropbox.com/s/svqcfiidzwwecyk/pencil_dark.svg [19:46:44] violetto: yeah, the same [19:47:14] YuviPanda: ok then that's the right one! [19:47:19] sweet [19:49:36] (03PS3) 10Kaldari: Story 1563: [WIP] Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [19:59:42] (03PS1) 10Kaldari: Making lazy-loaded page DOM match the server rendered page DOM. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106563 [20:04:59] violetto: https://www.dropbox.com/sc/x4w2jx6covfth4f/wgHJXAWuKy [20:05:02] is how it looks like now [20:05:54] i wonder if we could animate that button when we click it [20:06:05] have it fly around and scribble the title at the top of the screen? :D [20:06:12] (03PS1) 10Yuvipanda: Add pencil edit icon tapping which opens edit section [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106566 [20:06:14] brion: well, this is in JS [20:06:17] * brion had too much coffee this morning [20:06:19] brion: so.... NO :P [20:06:24] well, we *could* [20:06:25] hehe [20:06:26] brion: lol! [20:06:42] brion: put a nyan cat on it [20:06:46] haha [20:07:00] but we *could* also hang upside down from chandaliers while writing code on our Android 2.3 devices.... [20:07:09] oh android 2.3 [20:07:11] why won't you die [20:07:23] I like how the most ridiculous thing about that sentence is Android 2.3 [20:07:35] brion: anyway, have a look? I'll go sleep right after [20:07:39] ok [20:07:44] violetto: saw the image? [20:08:13] YuviPanda: i did [20:08:15] looks good [20:08:23] violetto: ok [20:09:54] YuviPanda: i think it could use some visual action on tap [20:10:10] but we can add that later [20:10:11] brion: hmm, like? [20:10:13] yeah [20:10:30] well if you tap an action item on the action bar it flashes the background color with a selection color [20:10:45] brion: and the tap also takes a while to register, but that's just the 300ms tap delay on webkit. we could perhaps get rid of it eventually [20:10:56] yeah we can kill that delay using touchstart/touchend [20:10:58] brion: true, should be easy enough to do here too, I suppose. We might need another image though. [20:11:06] brion: yeah, but that's orthogonal, I think [20:11:17] yeah [20:11:20] i'll put in a note for later [20:11:24] we'll tune all these things up :) [20:12:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks good! We'll want to have some visual feedback during tap on the icon, and probably use touchstart/touchend to kill the 300ms click d" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106566 (owner: 10Yuvipanda) [20:12:47] brion:we need to file bugs or open a new trello board for these things [20:12:50] brion: file bugs perhaps? [20:13:00] brion: also do you see a slight stutter when the rest of the article loads? [20:13:35] YuviPanda: i'd just stick cards in the backlog [20:13:46] they're not really *bugs* per se in the fashion of "it's horribly broken" [20:13:50] true [20:13:53] well, fine. [20:14:05] although putting a 1 on it sounds wrong, considering how all of language selection was a 3 [20:14:09] OH GOD WHAT AM I SAYING [20:14:11] nevermind that :) [20:14:13] YuviPanda: re stutter -- slight stutter sometimes on large pages, this is probably unavoidable when adding a large amount of html syncnrnously [20:14:27] brion: yeah, so what I need to do is split that up. [20:14:33] yeah that could help [20:14:53] i also have crazy ideas about reserving space in the document for the later sections but only adding them as we scroll near them [20:14:56] but that might be too crazy :D [20:15:35] brion: yeah :) [20:15:51] brion: so instead of the Java pushing that to JS, Java should just push a message saying 'hey, I am ready!' [20:15:56] brion: and then the JS should request sections one by one [20:16:07] ooh that's probably good [20:16:29] brion: but yeah, can you put that in the backlog or something? [20:16:31] easier to keep track of [20:16:37] ya [20:16:45] brion: so what we should also do is, on adding each section, wait for the Image in that section to load and only then get the next one [20:16:48] minimizes stutter [20:17:00] might be stupid, of course :) [20:18:20] brion: how's useraccount coming along? [20:18:50] hope to finish that up today so i can run it through review tomorrow [20:22:14] brion: sweet [20:23:10] kenanwang_: i emailed a link to the ios video to wmfall [20:23:48] videos will be easier to deal with if we get that mp4 stuff going :) [20:24:26] * brion lunch...... [20:24:36] brion: this snafu was my fault - i had shared the video w kenan via his email - forgot to make it public [20:25:06] mhurd: no worries, google drive has ... mysterious ways :D [20:25:22] brion: haha yeah... [20:25:37] brion: we'll present at next metrics [20:31:31] brion: I'm off for real now :) Have moved the first card to done. [20:31:36] will work on actually saving stuff tomorrow [20:31:37] night! [20:31:45] YuviPanda: see ya! [20:33:04] mhurd: night [21:25:18] (03CR) 10MaxSem: [C: 032] Making lazy-loaded page DOM match the server rendered page DOM. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106563 (owner: 10Kaldari) [21:25:55] (03Merged) 10jenkins-bot: Making lazy-loaded page DOM match the server rendered page DOM. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106563 (owner: 10Kaldari) [21:30:54] (03CR) 10MaxSem: "This test doesn't seem to check anything mobile-specific." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [21:40:36] (03CR) 10Brion VIBBER: "Pretty awesome. :D Coupla notes:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106547 (owner: 10Mhurd) [21:40:53] mhurd: a few suggestions in there, most important thing is to make sure we fix on iOS 6 [21:41:01] a few visual oddities which i hope are easy fixes :D [21:41:06] brion: cool! the tap-to-dismiss is almost done [21:41:10] awesome [21:55:11] brion: only the ios 6 fixes remain - other comments fixed. jumping on ios 6 stuff real quick [21:56:40] brion: oh god those buttons are hideous on ios 6! [22:01:48] hehe [22:22:25] hey jdlrobson :) [22:33:32] thanks for sending that out mhurd [22:45:55] hey theopolisme ! [23:06:20] on experimental, i have out-of-order notifications. is that a feature or a known bug? [23:09:18] actually, out of order notifications on all settings. [23:09:51] I'm all "what? i was reverted again?" [23:10:52] but it's the same one from 6 days ago still at the top of my list. [23:20:56] jdlrobson: Do less files automatically has access to MW global variables? I don't see @wgMFDeviceWidthTablet defined anywhere besides MobileFrontend.php. [23:22:33] kaldari, also SkinMinerva [23:23:40] ah, I see $wgResourceLoaderLESSVars now