[00:19:09] MaxSem: awjr diffs are broken on stable.. [00:19:20] can we just deploy this everywhere [00:19:26] jdlrobson: yeah i saw the bugs you filed [00:19:27] let's just promote beta! [00:19:48] MaxSem: any idea what happened to stable? [00:20:15] I might've broken it with refactoring while adding new diff [00:28:49] so what can we do about it.. [00:28:52] kind of serious no? [00:31:36] jdlrobson: sorry im in a meeting but will be done shortly [00:49:17] jdlrobson: done [00:49:21] jdlrobson: have you had the chance to dig around at all with the diff stuff? [00:49:28] awjr: no i have no idea what's happened [00:49:30] it's just hugely broken [00:49:31] i have a hunch [00:49:48] i think that only one line of diff is actually getting displayed [00:49:53] it works fine locally [00:49:55] i think a concatenation was missed [00:50:26] every diff im looking at in mobilefrontend stable is only showing one line [00:50:31] oh wait no it doesn't seem to work locally either [00:50:46] but i guess we've missed a lightning deploy window now so we have to deal with it until Monday? [00:51:03] I thought I fixed something similar during CR cycle...:P [00:51:09] MaxSem: you did :) [00:51:13] i remember because i -1'd you for it :p [00:51:48] jdlrobson: there is always a way if it's urgent enough [00:51:49] errr wtf $diff = '' . htmlspecialchars( $this->rev->getText() ) . ''; [00:52:11] jdlrobson: does kenanwang_ know about this yet? [00:52:17] awjr: i can't find him [00:53:03] i can confirm Id7adcf34601b918a2c0a601a1a1690e602a5989b broke it [00:53:40] jdlrobson: IMO it is ok to wait to monday's LD to get a fix out though kenanwang_ may feel different. [00:53:48] afaik he should be around [00:53:53] have yous een him in the office at all today? [00:54:22] StevenW: you seen kenan around by any chance? [00:54:41] No he isnt at his desk [00:55:04] awjr: i haven't seen him since 3ish- is he at the zero offsite or something? [00:55:25] jdlrobson: that's funny i think that change is the one that i saw this problem with originally but was fixed before i merged it [00:55:29] i can take a closer look [00:55:31] jdlrobson: im nos ture [00:55:33] not that i know of [00:57:02] Hey [00:57:02] I think i've found the problem [00:57:34] man gerrit is hella slow for me [00:57:36] kenanwang_: hi [00:57:40] I'm reading through [00:57:42] :) [00:59:39] It's on media wiki? [00:59:41] jdlrobson: wtf [00:59:43] i see the problem [00:59:52] i have a fix awjr [01:00:00] kenanwang_: enwiki [01:00:14] Ugh [01:00:33] jdlrobson: it is the *same* concatenation error i noticed, which max fixed, but then disappeared apparently after i updated the commit message via gerrit [01:00:39] look at line 208 of SpecialMobileDiff.php [01:00:48] That's pretty bad [01:00:50] compare versions 19 and 20, and then 19 and 21 [01:01:02] MaxSem: ^ [01:01:37] greg-g: you still around? [01:01:44] epic crappppp [01:01:59] Can we request a window tomorrow? [01:02:11] awjr: gerrit is ridicuously slow [01:02:13] kenanwang_: better to try and do it today, i think it's an easy fix [01:02:16] jdlrobson: same here :( [01:02:21] awjr: so i have a fix that works but it's taking ages to send [01:02:24] (1 minute so far) [01:02:25] kenanwang_: no deploys on friday :) [01:02:30] wtf [01:02:35] it might not be the best fix as i can't compare versions 19/20 and 19/21) [01:02:38] Ahh ok let's try today then [01:02:42] gerrit is down? [01:02:51] jdlrobson: it is up for me just mega slow [01:03:14] jdlrobson: can you pastebin me your patch so i can see it? [01:03:23] jdlrobson, replace = with .= [01:03:23] ssh: connect to host gerrit.wikimedia.org port 29418: Connection refused [01:03:24] fatal: The remote end hung up unexpectedly [01:03:30] https://gist.github.com/jdlrobson/8345145 < awjr [01:03:34] gerrit is being restarted [01:03:34] MaxSem: jdlrobson yeah should be on line 208 [01:03:36] this seems to work for both beta and alpha for me [01:03:44] (and stable) [01:04:00] I don't' know why the new diff needs just the last tag? [01:04:47] jdlrobson, you don't have $wgMFEnableBetaDiff = true; ? [01:04:57] ah maybe i haven't checked [01:05:08] i can't access gerrit right now [01:05:18] not even sure i have the new diff engine setup [01:05:23] so if someone can test that would be good [01:05:40] that piece of code affects only old diff [01:06:11] gerrit now works, you can try resubmitting [01:06:26] https://gerrit.wikimedia.org/r/#/c/97871/19..20/includes/specials/SpecialMobileDiff.php [01:06:38] jdlrobson: patchset 20 in that comparisson is what it *should* be [01:07:03] so, we discovered a gerrit bug!:P [01:07:25] old diff is deployed to the majority of our users ;-) [01:07:30] awjr: yeh i can see now [01:07:36] frisking weird [01:07:37] it never occurred to me to test again after updating the commit msg via gerrit [01:07:40] sigh. [01:07:44] is someone fixing? [01:07:44] no sign of greg-g [01:08:10] jdlrobson: i've got all the wikidiff set up [01:08:13] let me try it locally [01:13:33] (03PS1) 10Awjrichards: Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106639 [01:13:38] jdlrobson MaxSem ^ [01:14:25] (03CR) 10MaxSem: [C: 032] Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106639 (owner: 10Awjrichards) [01:14:54] since kenanwang_ expressed that this is urgent, i think it should be OK to deploy this fix now even though we're outside of lightning deploy [01:14:59] (03Merged) 10jenkins-bot: Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106639 (owner: 10Awjrichards) [01:15:07] kaldari MaxSem are one of you willing/able to deploy that fix ^? [01:15:19] it should be ported to both WMF branches in production [01:15:28] yep, as soon as greg-g PERMITS [01:15:39] i think greg-g may have gone home [01:15:49] or if he was working from home, may be done [01:15:51] for the day [01:16:10] is robla around? [01:16:32] MaxSem: in #wikimedia-dev he said he left for dinner ~45 mins ago [01:18:31] MaxSem: he is, i asked in -dev [01:19:08] ji've asked robla to join here [01:19:13] he's just in the middle of something [01:19:32] ^ awjr [01:20:31] ^ or kaldari MaxSem anyone ? :) [01:20:51] jdlrobson: yeah, i already dropped the question to him in #wikimedia-dev, he mentioned he was just wrapping something up [01:21:42] sometimes i miss the good ol days of cowboy deploys [01:22:52] violetto: do u have a second? [01:23:27] but then i remember times when people would scap while i was staging changes and cause all kinds of breakage as a result, and then i am thankful for the current status quo [01:23:41] MaxSem jdlrobson robla jsut gave the go-ahead in #wikimedia-def [01:23:43] er [01:23:44] dev [01:23:48] cool [01:24:00] let's roll! [01:27:30] (03PS1) 10MaxSem: Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106641 [01:28:03] (03CR) 10MaxSem: [C: 032 V: 032] Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106641 (owner: 10MaxSem) [01:28:22] (03PS1) 10MaxSem: Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106642 [01:28:36] (03CR) 10MaxSem: [C: 032 V: 032] Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/106642 (owner: 10MaxSem) [01:32:21] MaxSem: looks fixed? [01:32:34] although seems to be an issue with the new diff - compare https://en.m.wikipedia.org/wiki/Special:MobileDiff/536972232 with https://en.m.wikipedia.org/wiki/Special:MobileDiff/537236750 [01:32:41] wat? I ain't deployed yet:) [01:33:08] i guess not then :) [01:33:13] something fishy going on [01:33:30] oh wait i'm looking at a local diff LOLZ [01:34:07] jdlrobson, so what don't you like about those difs? [01:34:27] MaxSem: ignore what i said before i was being stupid [01:34:35] my brain is going offline [01:35:17] (03PS2) 10MaxSem: Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106641 [01:35:50] (03CR) 10MaxSem: [C: 032 V: 032] Fixed broken concatenation causing diff breakage in mobile [extensions/MobileFrontend] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/106641 (owner: 10MaxSem) [01:40:49] i need to rush off awjr MaxSem [01:41:01] https://en.m.wikipedia.org/wiki/Special:MobileDiff/537236750?mobileaction=stable seems to be working now.. [01:46:01] deployed [01:47:12] testing [01:48:07] appears to be working as expected again MaxSem - thanks :) [01:48:51] kenanwang_: diffs are fixed now [01:54:03] (03PS4) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [02:15:08] Awesome! Thanks awjr jdlrobson maxsem! [02:38:55] (03PS2) 10Jdlrobson: WIP: Story 1522: Table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106469 [02:38:56] (03PS1) 10Jdlrobson: Load the current page on startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106651 [02:38:57] (03PS1) 10Jdlrobson: Make sections aware of their subsections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106652 [05:26:56] (03PS1) 10JGonera: [WIP] Story 1462: Move new overlay code and new editor to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106658 [05:26:57] (03PS1) 10JGonera: [WIP] Story 1462: Move new uploads overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106659 [06:15:44] (03PS2) 10Mhurd: Split screen table of contents. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106547 [09:31:25] nearby is pulling in tablet.styles which breaks collapsible navboxes [09:36:55] https://www.mediawiki.org/wiki/Talk:Beta_Features/Nearby_Pages#Latest_update_breaks_navboxes [11:24:56] (03PS1) 10Yuvipanda: Make it possible for ApiTask subclasses to override the HTTP method [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106677 [11:24:58] (03PS1) 10Yuvipanda: Minor formating fix [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106678 [11:25:00] (03PS1) 10Yuvipanda: Add task to edit sections anonymously (+ tests) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106679 [15:07:55] (03PS1) 10Yuvipanda: Implement actually saving a section. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106706 [15:08:00] booom! [15:10:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106659 (owner: 10JGonera) [15:11:58] yurik, around? [15:12:10] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106658 (owner: 10JGonera) [15:31:25] (03PS1) 10Mayankmadan: Adding Cucumber tests First cucumber test for checking the banners on Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/106709 [15:43:24] (03PS2) 10Cmcmahon: [QA] WIP New version of Nearby test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105389 (owner: 10Jhall) [16:02:54] (03PS1) 10Yuvipanda: Refresh page when an edit successfully completes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106716 [16:14:00] hey brion [16:14:08] wazzap [16:14:34] brion: editing! THAT IS WHAT IS UP! :) [16:14:41] \o/ [16:14:56] (03PS2) 10Yuvipanda: Refresh page when an edit successfully completes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106716 [16:14:56] what isnt? PDF [16:15:08] haha! [16:15:20] heh [16:16:25] brion: I have also started using https://twitter.com/chris__martin/status/420992421673988096 in my bash_profile [16:16:38] hah [16:16:43] I wonder how long before I get emabarassed about typing 'such commit -p' and 'much push gerrit HEAD:refs/for/master' [16:16:57] not today, however :D [16:18:18] (03PS1) 10Yuvipanda: Show feedback when edit is saved [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106725 [16:20:45] brion: review time? :) [16:24:37] breakfast time :D review in a bit [16:25:14] heh [17:12:50] MaxSem: around? [17:12:58] yup [17:13:13] MaxSem: where does the mobile tag get added to revisions? [17:13:19] and is it just based on useformat=mobile? [17:13:55] it is based on MobileContext::shouldDisplayMobileView() [17:14:03] ah [17:14:04] I see [17:14:07] hmm [17:14:11] I need to add mobileapp tags [17:14:20] should perhaps do it in the MobileApp extension [17:21:06] (03CR) 10Nikerabbit: Remove section name from title of edit (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106527 (owner: 10Yuvipanda) [17:21:45] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make it possible for ApiTask subclasses to override the HTTP method [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106677 (owner: 10Yuvipanda) [17:25:58] (03CR) 10Brion VIBBER: [C: 032 V: 032] Minor formating fix [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106678 (owner: 10Yuvipanda) [17:54:01] (03CR) 10Jdlrobson: "I know this is a WIP but is there anyway we can separate out the tests into a separate patch to make review easier?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106659 (owner: 10JGonera) [17:57:11] (03PS2) 10Jdlrobson: Story 1581: Design tweaks to user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105994 [17:57:13] (03PS2) 10Jdlrobson: Remove page from last thanked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105995 [18:03:20] Guten Tag [18:04:10] bonan tagon [18:05:52] (03CR) 10Brion VIBBER: [C: 032 V: 032] "sweeeeeeet" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/106547 (owner: 10Mhurd) [18:05:56] :D [18:10:28] hi brion [18:10:54] hey hey [18:11:01] will finish review on yours as soon as i test em [18:12:27] brion: sweet [18:16:38] it is time .... standup! [18:17:52] brion: ah, damn [18:17:53] be there [18:17:56] ok [18:24:21] whee [18:25:53] chrismcmahon: still on for today? [18:26:27] awjr: yep, is GangPlank the best choice? [18:27:11] chrismcmahon: sure, works for me - i've never actually worked there before. did you try it out with jeff? [18:27:53] awjr: yes, it was nice. parking was convenient and cheap, no cost to use the place, people were nice [18:28:01] perfect :) let's do it [18:28:21] it's conveneinly close to me too chrismcmahon [18:28:48] awjr: it's about a 30 minute drive for me, but I like to go downtown. [18:28:56] :) [18:31:03] zz_yuvipanda: were there any changes to the api module or anything? [18:31:10] brion: hmm, no? [18:31:35] weird, i got a consistent mysterious 'could not reach network' one one page i tried to edit section on [18:31:58] aaaaaah [18:32:01] it was a redirect page [18:32:24] brion: aha! [18:32:34] brion: I need to change the title object for pages where I get a redirect back [18:32:35] hmm [18:32:37] example: look up "Area code 714" [18:32:38] try to edit section [18:32:46] it fails because the page is really "Area codes 657 and 714" [18:32:58] so there's no section 1 on the page we tried to edit [18:33:00] brion: right [18:33:06] brion: it just has the wrong page title [18:33:11] ok lemme try on a non-redirected page and confirm all else is ok :D [18:34:40] https://en.wikipedia.org/w/index.php?title=Area_codes_657_and_714&diff=590109270&oldid=588408998 woooo [18:34:46] oh wow ipv6 is working in the office [18:35:56] brion: pffft, you should use testwiki :P [18:36:08] i edit 4 REAL [18:36:18] hmm [18:36:32] zz_yuvipanda: if i click a link on the redisplayed page after editing, it crashes [18:36:36] sent you the crash report [18:36:42] looks like bridge not fully reinitialized properly? [18:37:49] brion: oh [18:37:50] hmm [18:37:51] looking [18:37:52] aaha [18:38:38] (03CR) 10Brion VIBBER: [C: 04-1] "Clicking a link on the page after it's refreshed crashes. Crash report sent to Yuvi." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106716 (owner: 10Yuvipanda) [18:38:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add task to edit sections anonymously (+ tests) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106679 (owner: 10Yuvipanda) [18:39:05] (03CR) 10Brion VIBBER: [C: 032 V: 032] Implement actually saving a section. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106706 (owner: 10Yuvipanda) [18:39:58] brion: looking into it now [18:40:15] thx [18:45:44] brion: now I also need to talk to greg-g about deploying MobileApp [18:45:49] * zz_yuvipanda attempts to catch a greg-g [18:45:51] whee [18:45:59] yeah you didn't seem very zz_ [18:46:04] heh [18:46:47] * greg-g hides [18:48:40] * YuviPanda attempts to catch greg-g [18:48:53] hi, what's up? [18:48:55] greg-g: so... what do we do to get an extension deployed? :) [18:49:03] greg-g: it's incredibly small (just RL modules for the app) [18:49:09] famous last words [18:49:16] especially re RL [18:49:19] one sec, in meeting [18:49:24] gimme 6 [18:49:29] heh [18:49:30] greg-g: ok! [18:51:54] hi mhurd [18:52:06] YuviPanda: hey! [18:52:19] mhurd: brion already made edits to enwiki! :) [18:52:36] YuviPanda: so awesome! :) [18:53:49] mhurd: indeed :) [18:54:01] so, YuviPanda a extension deploy needs some pretty high touch things done [18:54:10] have you done one? [18:54:41] mhurd: 'high touch' things? [18:54:46] err [18:54:47] greg-g: ? [18:54:54] YuviPanda: oh, any edit-saving tips for me? [18:55:24] greg-g: I talked to hashar about getting it to betalabs, and letting it mature there for a week or so [18:55:30] YuviPanda: things that require much interaction/attention [18:55:34] greg-g: should be on betalabs early next week. [18:55:42] good [18:55:48] greg-g: ah, no I haven't done a deployment. I don't even have deployment access. [18:55:58] greg-g: I think I can convince MaxSem to do it instead :) [18:55:59] well, who's going to do it? :) [18:56:01] ok [18:56:07] so, he's done those before [18:56:17] yeah, I think so [18:56:29] so, the general rule for new extensions is to wait a week after it gets onto betalabs [18:56:39] yeah, sounds sane [18:57:03] greg-g: the patch to get it on betalabs has been in gerrit for about 3 days now. Waiting on someone to unbreak the mediawiki/extensions.git repository [18:57:11] greg-g: any other rules? [18:57:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105995 (owner: 10Jdlrobson) [18:57:49] "don't break production" [18:57:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105994 (owner: 10Jdlrobson) [18:57:56] "be awesome to each other" [18:58:03] "don't walk away mad" [18:58:11] "do not have McDonalds for Lunch and Dinner, even if it is rather not too bad in India" [18:58:13] "don't tug on superman's cape" [18:58:32] "Don't climb the Reichstag dressed as greg-g" [18:59:07] huh [18:59:11] yeah, that's a good one, too [18:59:25] (reference to http://en.wikipedia.org/wiki/Wikipedia:No_climbing_the_Reichstag_dressed_as_Spider-Man, for the uninitiated) [18:59:41] greg-g: alright, so I guess I'll just poke you once it has been on betalabs for about a week? [19:00:39] well, lemme get it on the schedule now [19:00:57] spidey noooooo [19:01:08] so, betacluster week of 13th, week of 20th is toast (MLK day plus arch summit), so week of 27th is earliest to production [19:01:55] greg-g: sounds good! [19:02:04] what's the extension? [19:02:07] gimme linkies! [19:02:18] greg-g: http://en.wikipedia.org/wiki/Wikipedia:No_climbing_the_Reichstag_dressed_as_Spider-Man [19:02:19] err [19:02:20] damn [19:02:38] greg-g: https://github.com/wikimedia/mediawiki-extensions-MobileApp [19:02:55] greg-g: that's pretty much all the PHP it'll have. We'll add more CSS next week [19:02:56] hehe [19:02:58] well, LESS [19:03:05] gimme real repo plz ;) [19:03:12] (I can find it) [19:03:13] MOAR LESS [19:03:17] greg-g: https://github.com/wikimedia/mediawiki-extensions-MobileApp.git? :P [19:03:21] fine, fine :P [19:03:55] oh damn, soooo slow [19:04:37] greg-g: still hunting [19:04:50] greg-g: https://git.wikimedia.org/summary/?r=mediawiki/extensions/MobileApp.git [19:04:59] I should add a README perhaps. [19:05:07] https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MobileApp [19:05:15] yessir ;) [19:05:31] 2 commits! [19:05:38] this OBVIOUSLY isn't ready [19:05:48] :P [19:06:05] also, plz create mw.org/Extension: page [19:06:10] ah, yes. [19:06:12] I'll do that now [19:06:14] coolio [19:06:17] thanks! [19:06:20] greg-g: yw! [19:06:24] err [19:06:25] hmm [19:06:46] greg-g: thanks! :) [19:06:58] heh [19:15:22] (03CR) 10Cmcmahon: [C: 032] "needed for further development" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105389 (owner: 10Jhall) [19:16:35] (03Merged) 10jenkins-bot: [QA] WIP New version of Nearby test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105389 (owner: 10Jhall) [19:19:53] YuviPanda: $wgResourceModules = array_merge( $wgResourceModules, array( [19:19:57] Why array_merge? [19:20:05] And you should probably add a localised description [19:21:25] Reedy: hmm, should just replace it with [] [19:21:30] ja [19:21:32] Reedy: localized description of the extension? [19:21:48] 'descriptionmsg' => 'mobile-frontend-desc', [19:21:53] type of thing [19:21:54] hah [19:22:11] No doubt someone will complain when it's deployed.. [19:22:13] Reedy: then I'll have to setup i18n... [19:22:16] and things [19:22:17] but fine. [19:22:32] It only take a minute or 2 [19:22:43] Reedy: hmm, actually - if I have array_merge there then I don't have to type $wgResourceModules[] = for every module [19:22:46] fine, there's only one now... [19:22:49] oh fuck it [19:22:56] You've only got one module [19:23:56] yeah :) [19:24:45] $localBasePath = dirname( __DIR__ ); [19:24:45] $remoteExtPath = 'MobileApp'; [19:24:55] (copied that from MF) [19:24:57] $IP/extensions/MobileApp/.. [19:25:47] Meh [19:25:57] YuviPanda: Yeah, it's wrong [19:26:19] Resource.php in MF are MobileFrontend/includes [19:26:39] yeah [19:27:35] Reedy: heh, the only other extension I've locally cloned is Wikibase... [19:27:56] I've got 665.. [19:32:20] (03PS4) 10Cmcmahon: Merging but test will not run; need Nearby fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103761 [19:32:32] (03PS5) 10Cmcmahon: Merging but test will not run; need Nearby fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103761 [19:32:46] (03CR) 10Cmcmahon: [C: 032] "Need to merge to pick up Nearby fix" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103761 (owner: 10Cmcmahon) [19:35:22] Reedy: I'll commit a patch with fixes after fixing a bug in the app. [19:35:26] thanks for pointing it out! [19:50:12] (03PS1) 10Kaldari: Hi-res external link icons!!! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 [19:51:35] (03CR) 10Brion VIBBER: "Woohoo! The SVGs are a little noisy though, with extraneous bits like:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 (owner: 10Kaldari) [20:02:03] (03CR) 10Jdlrobson: [C: 04-1] Hi-res external link icons!!! (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 (owner: 10Kaldari) [20:04:50] (03CR) 10Jdlrobson: [C: 04-1] "Something seems to have gone in the rebase as now this doesn't work :(" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [20:05:12] (03CR) 10Jdlrobson: Add an "always expand all sections" option (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [20:08:44] (03PS2) 10Kaldari: Hi-res external link icons!!! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 [20:16:13] jdlrobson: what invokes Special:MobileEditor? [20:17:06] (03PS2) 10Yuvipanda: Show feedback when edit is saved [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106725 [20:17:08] (03PS3) 10Yuvipanda: Refresh page when an edit successfully completes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106716 [20:17:11] brion: that should fix the crashes. think you can take out 10mins from hacking to review? :) [20:17:19] sure [20:18:03] brion: sweet [20:18:31] brion: it should also sortof hold position when after it saves [20:19:00] "sortof" inspires confidence ;) [20:19:12] brion: :P [20:19:18] brion: 'scrolling' inspires confidence! [20:19:20] :) [20:19:29] brion: it doesn't handle any form of edit failure yet [20:19:38] YuviPanda: hey! when u have a second can i borrow api details for how you're saving edited wikitext? [20:19:46] brion: ah, it doesn't actually handle scroll saves yet. [20:19:48] mhurd: ah! sure! [20:20:10] mhurd: so http://mediawiki.org/wiki/API:Edit is what I go by [20:20:23] mhurd: so the two primary things are 1. getting an edit token, 2. doing the actual edit [20:20:48] mhurd: edit token you can get via action=tokens, and it is constant per login - so if you already have a token for the current login, you can just reuse it [20:20:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] "whee!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/106716 (owner: 10Yuvipanda) [20:21:03]