[00:00:03] lol awjr [00:00:08] scum of scrums [00:00:41] hehehe [00:01:00] it's that film that forms at the top of the scrum [00:01:07] there are so many bad things you can do with that name [00:01:16] lol [00:01:17] yes. [00:01:18] some of which I cannot say in a public channel [00:01:27] (03CR) 10Kaldari: "Agreed. I'll do the content.css in a separate commit." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 (owner: 10Kaldari) [00:01:53] jdlrobson: Do you want me to get rid the content centering or is it OK? [00:02:11] kaldari: it's fine according to kaity lolz [00:02:40] lolz! [00:02:44] it just seems a slight diversion from what's happening on VectorBeta which max widths it but aligns it to the left [00:03:04] I'd actually like to see us show the left menu by default on tablets [00:03:15] e.g. not hide it but that can happen in another iteration maybe? [00:03:20] jdlrobson: Didn't mean to make changes to stable, those were accidently left over from when I was live-hacking it during the meeting. I'll move those to beta. [00:04:36] no worries kaldari but yeh if you split them up i should be able to review them pretty fast [00:08:27] jdlrobson, any idea how I should write a browser test for the language overlay? I need a page with languages... [00:11:34] jgonera: mmm.. [00:11:36] tricky [00:11:54] can we run arbitrary JS to create one? [00:14:00] jdlrobson, that's not how tests are supposed to work ;) [00:15:52] oh wait, there seems to be a test for languages... I bet it fails on wikis other than enwiki, let me check [00:22:02] (03PS1) 10Jdlrobson: Remove wgMFAnonymousEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 [00:26:01] mhurd: how are you doing with Yuvi sending all of these juicy editing screenshots ? [00:26:42] (03PS2) 10Jdlrobson: Remove wgMFAnonymousEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 [00:26:54] jdlrobson, jgonera: going up to HR meeting on 6 if you need me [00:27:08] k [00:27:51] tfinc: hehe jealous :) yuvi gave me a pretty good roadmap earlier today of the getting-wikitext-for-a-section process and also the save changes process so i should be able to catch up :) [00:30:03] (03PS1) 10Jdlrobson: Close overlay when invalid image selected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106853 [00:31:36] (03PS3) 10Jdlrobson: Correctly identify lead section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106434 [00:41:26] (03PS1) 10JGonera: [WIP] Story 1462: Move new languages overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106854 [01:10:26] jgonera: now? [01:10:28] sorry! [01:10:35] violetto, ok [01:12:47] violetto, I come or you come? ;) [01:13:09] s wants to be in it too [01:13:11] come! [03:53:01] (03PS3) 10MZMcBride: Allow anonymous editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [05:17:41] (03CR) 10Legoktm: Allow anonymous editing (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [05:17:46] Gloria: ^ [05:20:42] legoktm: I'm not sure I understand how it should look. [05:21:33] I think the current behavior was already broken, but it still needs fixing [05:21:52] * legoktm waits for his IDE to load [05:22:51] it makes the assumption if the page isn't editable, that the user just needs to create an account [05:24:08] ignore the intendation but https://dpaste.de/N31W/raw [05:24:19] I think you can get rid of the enture user.isAnon() block [05:24:20] not sure [05:33:43] (03PS4) 10MZMcBride: Allow anonymous editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [05:33:57] (03CR) 10jenkins-bot: [V: 04-1] Allow anonymous editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [05:34:06] Oh, bother. [05:34:08] What'd I do? [05:38:06] 05:33:55 javascripts/modules/editor/editor.js: line 125, col 21, 'initCta' is defined but never used. [06:39:41] (03PS1) 10Legoktm: Add mobile version of "anoneditwarning" message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106865 [08:36:10] (03CR) 10Jdlrobson: [C: 04-2] "you've changed this patch. I was trying to be constructive but you have taken it in a different direction. let's talk about this on Monday" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [08:41:25] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106865 (owner: 10Legoktm) [08:42:01] (03CR) 10Siebrand: [C: 031] Add mobile version of "anoneditwarning" message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106865 (owner: 10Legoktm) [08:44:58] (03CR) 10Jdlrobson: [C: 04-1] "There are various issues with this patch one of Which being we are about to kill this editor code. I dont want to go into detail about thi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106865 (owner: 10Legoktm) [11:26:17] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106659 (owner: 10JGonera) [11:26:37] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106658 (owner: 10JGonera) [11:29:52] (03CR) 10Siebrand: [C: 031] "i18n/l10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106854 (owner: 10JGonera) [16:34:53] (03CR) 10MZMcBride: "I think updating patches on a changeset is the crux of Gerrit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [16:38:56] (03PS5) 10MZMcBride: Allow anonymous editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [16:39:11] (03CR) 10jenkins-bot: [V: 04-1] Allow anonymous editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [16:40:33] (03PS6) 10MZMcBride: Allow anonymous editing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [16:41:00] There we go. [16:42:04] (03CR) 10MZMcBride: "PS5 was just early-morning stupidity (missed a semicolon). I should probably set up JSLint locally rather than relying on jenkins-bot to c" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106851 (owner: 10Jdlrobson) [16:42:41] (03CR) 10MZMcBride: "Related: https://gerrit.wikimedia.org/r/106851" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106865 (owner: 10Legoktm) [17:16:44] 01[13WikipediaMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/8FTyHQ [17:16:44] 13WikipediaMobile/06master 140c074f4 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [17:57:37] yurik, around? [19:24:22] (03CR) 10Jcf2000: "Hello again!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000)