[03:38:46] (03CR) 10Legoktm: [C: 031] Remove page from last thanked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105995 (owner: 10Jdlrobson) [19:34:30] YuviPanda: hey! [19:38:35] mhurd: heya! [19:38:38] mhurd: nice weekend? [19:39:05] YuviPanda: ya! took a break and went climbing yesterday :) going today too! how's yours? [19:39:26] mhurd: not bad. bought more clothes, went for a drink and read a book [19:39:26] YuviPanda: oh! good news too! [19:39:32] nice! [19:39:46] i think i fixed the long-standing concurrency lockup :) [19:40:18] app can now "run the gauntlet of presidents" from obama to washington without locking up - before even just obama locked it up [19:40:30] mhurd: ah [19:40:33] mhurd: what was the cause? [19:41:31] core data's contexts are not thread-safe - nor are core data objects themselves. i had the objects pretty much doing what they should have been, but the *contexts* were not set up quite right [19:41:41] ah I see [19:41:46] nice! :) [19:41:52] learned a log :) [19:41:57] lol. "lot" [19:42:30] mhurd: :D [19:42:38] YuviPanda: i was getting scared a bit... that i woundn't figure it out in time [19:42:42] so relieved [19:42:45] :D [19:42:55] seems fine in Android so far [19:43:05] YuviPanda: that's 'cause you're awesome [19:43:16] heh [19:43:31] gotta catch up w editing now:) [19:43:34] mhurd: I spend a couple of years doing Desktop apps, so some lessons from there :) [19:43:36] mhurd: nice! [19:45:34] YuviPanda: hopefully we'll get the apple dev acct enterprise switch completed soon so i can test w new ipads... so frustrating not being able to push to new device... grrrr [19:48:18] YuviPanda: btw - the enlish "architecture" article has some beautiful images if you want a good article for demos/videos [19:48:37] mhurd: heh :) [19:48:40] mhurd: ah, sure [19:49:02] mhurd: I'm going to spend *faaar* less time on ToC, though. talked to may, we are just going to do the initial thing here and see how it goes later on [19:49:30] mhurd: I also have to do some performance fixes - not with threading, but with webkit being a bit stuttery when you add 700kb of DOM elements via JS at the same time :) [19:49:59] mhurd: also for editing - you should test things on the testwiki rather than on enwiki [19:50:06] YuviPanda: sounds good! [19:50:21] YuviPanda: haha yeah testwiki [19:50:22] for sure [19:50:31] mhurd: don't get the office IP banned again! :) [19:50:35] lol [19:52:12] mhurd: :) [19:52:33] mhurd: the number of possible error conditions are rather... large. [19:52:39] i'll probably spend most of next week on that [19:53:15] YuviPanda: oh god... should be fun :) [19:53:16] mhurd: and most of them you have to hunt around a bit [19:53:31] mhurd: of the ones listed in http://www.mediawiki.org/wiki/API:Edit#Possible_errors, we will at best run into just one or maybe two of those [19:53:42] the other ways it can fail ther are... just not listed in one place [19:54:03] Extension:ConfirmEdit, Extension:TitleBlacklist, Extension:AbuseFilter... [19:54:09] all can abort edits in different ways [19:54:14] mhurd: and then there are edit conflicts [19:54:18] zomg edit fucking conflicts [19:54:34] legoktm: has anyone tried resolving edit conflicts with something like git's 3 way merge? [19:54:38] YuviPanda, mhurd, also errors from AbuseFIlter are possible, maybe other extensions [19:54:48] MaxSem: yeah, i just mentioned it [19:54:56] ah [19:55:09] MaxSem: ConfirmEdit, TitleBlacklist, AbuseFilter, Edit Conflicts, page protection, what else? [19:55:12] YuviPanda: MaxSem: sounds like a sprint just wrangling these errors haha [19:55:35] just accept /^.*$/ [19:55:46] haha [19:56:03] cause AF allows to introduce custom errors codes [19:56:09] ah, that [19:56:09] yeah [19:57:05] MaxSem: edit conflicts I'll handle by pretending they don't exist (for now, at least). ConfirmEdit is Captcha, so need to handle that. [19:57:22] MaxSem: page protection, don't let them save. simple enough once your patch gets deployed [19:57:38] MaxSem: AbuseFilter, TitleBlacklist - I'm just going to pop up the error (hopefully with an explanation message) [19:57:40] and let it be [19:58:18] MaxSem: is there an API that shows me editnotices? [19:58:19] YuviPanda: no clue! [19:58:24] mhurd: we will also need to handle editnotices and anonnotices [19:58:31] hmm [19:58:36] doubt that [19:58:44] MaxSem: MF doesn't show people editnotice does it? [19:58:56] it doesn't [19:59:12] well, we should [20:00:13] as with login notices, mobile might not want to display enwiki's ridiculously long cryptic warnings [20:00:19] that's true [20:00:30] but still... [20:00:31] something [20:00:48] we will definitely need the equivalent of anonwarning [20:00:50] (http://en.wikipedia.org/w/index.php?title=Puppy_pregnancy_syndrome&action=edit) [20:01:41] either way, plenty of work ahead, mhurd :) [20:01:53] mhurd: we'll also need to build in a kill switch so we can turn some things off without requiring an app update [20:01:55] :) [20:02:09] nice article title! [20:02:12] * MaxSem reads [20:02:28] YuviPanda: true... *takes deep breath* [20:02:56] MaxSem: think you can help deploy Extension:MobileApp by end of month? :) I talked to greg -g and he was fine with it (he gave me the date). It should be on betalabs this week (I've a patch awaiting mediawiki/extensions.git getting fixed) [20:03:31] mhurd: so we can bundle that in the extension too, as an RL module that sends JSON (I think we might have one of those). I'll investigate that [20:03:36] has it been peer-reviewed? [20:03:38] mhurd: we have about 6 weeks to release :) [20:03:49] MaxSem: well, it's just LESS files for now [20:03:51] * MaxSem hates deadlines [20:03:59] YuviPanda: insanity! :) [20:04:03] MaxSem: and there are no self-merges :) [20:04:18] MaxSem: I actually like them provided I was part of the process setting them :) [20:04:22] still whole-extension review would be a good thing [20:04:49] MaxSem: true. Reedy gave me some comments that I'll fix tomorrow [20:04:53] and I'll shop it around a bit too [20:05:04] FIXME [20:05:12] I don't want to poke you with it now because I'll have to sleep in a bit, and also you'll probably tell me all the things Reedy told me first :D [20:05:29] Lots of code is hard to review [20:06:04] consequence --> kill all code [20:06:35] indeed [20:06:56] * YuviPanda kills all the code [20:07:12] MaxSem: I just checked a few days ago, MF is about 50k LOC [20:07:14] :O [20:07:30] could use 1/2 decimation [20:07:38] at least, yeah :) [20:07:48] alright, time for me to sleep [20:07:51] good night, MaxSem and mhurd [20:07:53] just merge it into core [20:07:59] thatll fix it [20:08:01] YuviPanda: goodnight! [20:08:08] * YuviPanda merges Reedy into core [20:08:18] Reedy, core CR is crazy [20:08:25] and thus was born a bit of british skynet [20:09:08] ok off for real now [20:23:06] Reedy, is there a place I can see your comments? [20:23:31] irc backscroll [20:23:38] his paths were wrong [20:23:55] no need to use array_merge [20:24:08] should have minimal i18n [21:32:04] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7338859 [21:41:47] Krenair, I don't have OTRS access anymore, what's in that ticket? [21:55:32] MaxSem, someone wants to modify Wikipedia Android to only open pages in a specific language [21:56:14] that's for yuvipanda or mhurd [21:57:16] MaxSem: ya yuvi will have to tackle that one :) [22:22:45] (03PS1) 10Mhurd: -Fix for most (all?) concurrency lockups! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/107104