[04:24:05] (03PS12) 10Pcc: Add an "always expand all sections" option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 [04:24:07] (03PS9) 10Pcc: In alpha mode, save and restore the set of open sections in the history [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 [07:23:50] (03PS1) 10Yuvipanda: Send POST requests form encoded by default [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/107118 [07:24:35] (03PS1) 10Yuvipanda: Add an & in edit test to test for appropriate encoding [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107119 [08:01:43] (03PS1) 10Yuvipanda: Expose ability to set an HTTP Connection Factory [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/107120 [08:02:53] (03PS1) 10Yuvipanda: Use OkHttp for HTTP requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107121 [11:15:29] YuviPanda: remember when i recently submitted that gerrit change to fix commons build error, but then it turned out to be fix in translatewiki and abandoned? [11:15:56] there is a new one, now, because.. on traslatewiki people added a comment _about_ the issue with the percent character [11:16:05] and that itself breaks building again . hahah [12:43:31] (03CR) 10Hoo man: "Is the mobile team still interested in working on this?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [17:36:52] (03CR) 10Jdlrobson: "Yep sorry. Let me rebase this and get this merged asap." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [17:52:53] hey mhurd [17:53:04] YuviPanda: heya! [17:53:19] morning :) [18:14:51] (03PS4) 10Jdlrobson: Enable keyboard section toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [18:15:13] (03CR) 10Jdlrobson: [C: 031] Enable keyboard section toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [18:15:25] brion: hey [18:15:29] brion: standup! [18:15:39] yo [18:15:55] jgonera: https://gerrit.wikimedia.org/r/102004 [18:16:13] brion: standup? [18:16:41] cat attacking computer :P [18:19:15] wget http://www.bitboost.com/pawsense/ | convert -to --free-software [18:20:00] jdlrobson: do you have a few minutes today to talk about the errors you guys had when implementing editing? or should I poke someone else? [18:20:09] YuviPanda: errors? [18:20:20] jdlrobson: abusefilter, captcha, things like that? [18:20:34] what specifically about them? [18:20:46] how many people were effected or how to handle those errors? [18:20:59] jdlrobson: Just wanted a list of things you had to deal with, and how you handled them? [18:21:04] A more than B, if you have less time [18:27:43] (03CR) 10Jdlrobson: "So the main problem with this is the code doesn't actually work - when I set $wgMFAnonymousEditing to true I get no warning message." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106865 (owner: 10Legoktm) [18:28:32] brion: http://www.bitboost.com/pawsense/pawsense-faq.html [18:29:27] heh [18:35:42] (03PS6) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [18:37:24] (03PS7) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [18:38:37] (03PS8) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [18:40:16] (03PS3) 10Jhall: Proof-of-concept for browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [18:40:21] (03CR) 10jenkins-bot: [V: 04-1] Proof-of-concept for browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [18:40:35] milimetric: you there? [18:40:48] yes [18:40:49] hi [18:41:04] so I saw this little dip in some of the graphs on the third tab [18:41:09] so the drop in http://mobile-reportcard.wmflabs.org/#uploads_daily-graphs-tab actually might be related to a bug [18:41:10] little -> large [18:41:18] that we are lightning deploying today [18:41:22] ah, ok [18:41:29] good then :) [18:41:41] milimetric: https://bugzilla.wikimedia.org/show_bug.cgi?id=59836 [18:41:46] i'm checking the sql though to be sure [18:42:27] also errors are going up which is concerning [18:43:02] i saw that too [18:43:05] milimetric: reason i think that is because apps are not effected [18:43:49] it just seemed strange because the 10th is when I merged that patch [18:44:03] but i suppose errors were going up already on the 9th [18:44:18] hey brion [18:44:21] yo [18:44:25] brion: code revie? [18:44:50] lookin [18:45:30] ok jdlrobson, let me know when you're done with all that and I will try to rebase your second patch to generate.py and get that ready to merge [18:45:40] it got all messed up because of the changes I suggested to the first patch [18:47:14] milimetric: errors look about right since 7th January there was 850 invalid token errors, 526 on enwiki alone [18:47:58] yeah, and eventually everyone who got errors stopped uploading so the uploaders dipped a couple days later [18:47:59] makes sense [18:48:20] and we can easily see if it improves after your lightning today [18:48:45] milimetric: yep looks broken [18:50:33] milimetric: yep photo uploads broken [18:51:09] (03PS3) 10JGonera: [WIP] Story 1462: Move new overlay code and new editor to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106658 [18:51:11] (03PS3) 10JGonera: [WIP] Story 1462: Move new uploads overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106659 [18:51:13] (03PS2) 10JGonera: [WIP] Story 1462: Move new languages overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106854 [18:51:15] (03PS1) 10JGonera: [WIP] Story 1462: Move new search overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107192 [18:51:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] "test fails as expected -- library fail!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107119 (owner: 10Yuvipanda) [18:51:59] (03PS9) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [18:52:08] brion: if you do mvn install after that update to the library, it should pass [18:52:20] i guess ideally we'd have some automatic monitoring of these graphs [18:52:20] milimetric: thanks for flagging [18:52:27] milimetric: that would be awesome [18:52:31] i was thinking the same [18:52:33] YuviPanda: uhhh? [18:52:37] where i find update to that library [18:52:42] or do you mean the next commit [18:52:48] brion: https://gerrit.wikimedia.org/r/#/c/107118/ [18:53:00] ah in java-mwapi [18:53:01] brion: i linked it in the commit message [18:53:03] yeah [18:53:06] bah i didn't read then [18:53:06] i know christian made something like that for the geowiki dashboards, maybe that's a good place to start [18:53:08] morning [18:53:09] bleah [18:53:15] I'll make a note and talk to him tomorrow [18:53:15] brion: there are a couple of java-mwapi fixes as well [18:53:29] (03PS10) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [18:53:57] moment [18:55:45] (03CR) 10Brion VIBBER: "and works as expected with the other patch in \o/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107119 (owner: 10Yuvipanda) [18:55:52] (03CR) 10Brion VIBBER: [C: 032 V: 032] Send POST requests form encoded by default [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/107118 (owner: 10Yuvipanda) [18:56:26] (03PS11) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [18:58:35] YuviPanda: Can you send a mail to mobile-l ? I'll respond there... [18:58:43] jdlrobson: yeah, will do that! [18:58:45] jdlrobson: thanks! [18:59:02] (03CR) 10Kaldari: Story 1563: Typography updates for Tablet (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 (owner: 10Kaldari) [18:59:04] brion: no rush on review of https://gerrit.wikimedia.org/r/#/c/107104/ - but super curious if it behaves itself better on 3gs :) [18:59:27] jdlrobson: Typography update is ready for re-review: https://gerrit.wikimedia.org/r/#/c/106181/ [18:59:39] sweet [19:01:10] tfinc: am I in the wrong hangout? [19:02:07] YuviPanda: i'm in one with just kenan [19:02:08] hmm [19:03:09] brion: nevermind [19:03:24] brion: i was in the wrong one [19:03:33] heh [19:04:12] (03PS13) 10Jdlrobson: Add an "always expand all sections" option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [19:05:53] (03CR) 10Jdlrobson: [C: 032] Add an "always expand all sections" option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [19:05:59] awjr, jdlrobson: So it looks like the token reversion got cherrypicked, but never deployed. I can make sure it's deployed during the lightning deploy today. [19:06:03] (03PS10) 10Jdlrobson: In alpha mode, save and restore the set of open sections in the history [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 (owner: 10Pcc) [19:06:29] (03Merged) 10jenkins-bot: Add an "always expand all sections" option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/74922 (owner: 10Pcc) [19:06:41] kaldari: which revision is that? [19:07:43] awjr: the one you emailed: https://gerrit.wikimedia.org/r/#/c/105112/ [19:08:02] (03PS4) 10Jhall: Proof-of-concept for browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [19:08:13] kaldari: that is already in the wmf9 branch [19:08:53] has the submodule been updated in core though? [19:09:40] kaldari: i checked the git logs in /a/common/php-1.23wmf9/extensions/MobileFrontend on tin and that revision shows up [19:09:57] kaldari: can you merge this hygiene patch - https://gerrit.wikimedia.org/r/#/c/106128/1 [19:10:12] It was one of the conditions of my +2 for you :P [19:10:22] awjr: hmm [19:10:54] https://gerrit.wikimedia.org/r/#/c/104790/14/includes/Resources.php < kaldari context :) [19:11:48] jdlrobson: sure, let me test... [19:15:03] kaldari: however, looking at the actual files on tin - javascripts/common/api.js does not contain the changes from that patchset [19:15:12] something may have overwritten the change [19:16:00] maybe so, especially since we did like a half dozen lightning deploys recently [19:16:07] :| [19:20:25] hmm something wonky must've happened with the cherrypick [19:20:38] i was trying to git bisect to find the problem but it results in 'The merge base 204353e9d51f51fbb3ce29f397fdc33fc7c530c1 is bad.' [19:20:49] (03CR) 10Kaldari: [C: 04-1] Hygiene: Reshuffle content / page action overlays (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106128 (owner: 10Jdlrobson) [19:20:52] (03PS1) 10JGonera: [WIP] Story 1462: Move new issues overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107195 [19:20:54] kaldari: ^^ [19:24:10] kaldari: i guess i can imagine a scenario where a rebase made things go sideways after the cherrypick, or that another cherrypick overwrote the one we wanted [19:24:51] awjr: I'll just deploy it then [19:24:58] er redeploy it i mean [19:25:02] aye [19:33:37] (03CR) 10Jdlrobson: [C: 04-1] Story 1563: Typography updates for Tablet (0314 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 (owner: 10Kaldari) [19:34:39] (03PS5) 10Jdlrobson: Proof-of-concept for browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [19:43:38] jdlrobson: For @blockquotePaddingRight and @blockquotePaddingLeft, the only reason I made then variables was so that I could add 10px to them in tablet view. Would you prefer I just hard-code them? [19:44:24] (03CR) 10Jdlrobson: [C: 04-1] "Running the test doesn't seem to work.." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106833 (owner: 10Cmcmahon) [19:44:52] brion: quick, code review before we head into another meeting! :D [19:44:57] hehe [19:45:34] brion: can you do the editing show off? [19:45:45] brion: sf to sf video is probably going to fare better than halfway around the world [19:45:52] and you can just use ASM and screencast that windoe [19:46:38] brion: also see PM? [19:48:26] YuviPanda: can you you join the next hangout early. i want to see if the echo is still there [19:48:27] ? [19:48:48] tfinc: sure [19:48:52] thanks [19:48:56] tfinc: do you want me to join now? [19:52:19] YuviPanda: yeah i'll try it [19:52:25] brion: sweet [19:56:37] bah. emulator rebooted spontaneously [19:57:48] brion: use ASM for demo, not emulator. emulator SUCKS! [19:58:04] it's a lot better than it used to be since they added host gpu [19:58:08] but it's still a bit sluggish [19:58:21] brion: ah, true [19:58:22] brion: yeah [19:58:34] (03PS1) 10JGonera: [WIP] Story 1462: Move new notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107198 [19:58:37] of course if you emu 2.3 i'm not sure if that has any effect ;) [19:58:46] probably not [19:58:53] 4.3 it is then :D [20:00:12] ok i've got emu and real device queued up just in case [20:00:26] and i should load that video as another back up ;) [20:01:46] brion: heh [20:12:09] (03PS12) 10Jdlrobson: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 (owner: 10Kaldari) [20:12:31] YuviPanda: you just talked too fast [20:12:38] tfinc: hah ok [20:12:59] goddamnit, everyone is having food [20:13:16] YuviPanda: yup, lunch time [20:13:18] yeah now i want a sandwich [20:13:24] yeah, me too [20:13:31] * brion downloads one [20:13:34] except I've to wait for about 8 hours now [20:13:39] heh [20:13:42] brion: YOU WOULDN'T DOWNLOAD A SANDWICH! [20:13:47] lolll [20:16:00] (03PS6) 10Jhall: [WIP] Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [20:27:00] (03PS7) 10Jhall: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [20:31:06] (03PS1) 10JGonera: Regression: allow text wrapping outside .overlay-header-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107208 [20:31:54] (03PS8) 10Jhall: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [20:33:00] (03CR) 10Jdlrobson: [C: 04-1] "(Tweaked commit message rather than rely on your comments inside the files)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 (owner: 10Kaldari) [20:35:15] brion: we lost audio.. [20:35:26] it sounded like you were playing pong [20:35:54] brion you are breaking up now [20:37:38] we lost audio again YuviPanda [20:37:46] jdlrobson: max muted you [20:37:53] meh [20:38:23] we lost you again YuviPanda [20:38:27] nevermind [20:38:30] :/ [20:38:35] "we are going to put in a kill switch" [20:38:43] "so we can turn off editing or anon editing if necessary without an app update" [20:39:04] all right a/v is failing. were going to end it [20:39:10] meh [20:39:35] YuviPanda: yeah the audio went very wonky [20:39:46] i'm not sure whose end it was on but i don't think they heard ne either [20:39:48] *me [20:39:52] brion: yeah, probably [20:40:01] brion: well, it's okay, since nobody cares about android anyway [20:40:05] awww [20:40:27] (03PS9) 10Jdlrobson: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [20:40:28] I'm just going to go sleep now. Night. [20:40:36] gnight [20:40:36] brion: should have a couple of patches up tomorrow. [20:40:38] ok [20:40:48] And I'm never doing these showcases again [20:40:57] well, remotely that is [20:41:00] they go wrong easily :) [20:41:06] super frustrating [20:41:08] yeah [20:41:13] in fact any hangout meeting with more than 4 people [20:41:23] next time i'll make sure i'm not surprised by the schedule [20:41:27] heh [20:41:29] alright [20:41:31] i thought these were next week :D [20:41:32] I'm off now [20:41:34] heh [20:41:35] ok see ya [20:42:08] (03CR) 10Jdlrobson: [C: 04-1] "Like Max I am a bit confused about this patch and why it lives in mobile.." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [20:42:50] whee internet [20:43:19] kaldari: can you let greg-g know about the other patch you'll deploy so it gets marked on the calendar? [20:43:26] (03CR) 10Jdlrobson: [C: 032] Regression: allow text wrapping outside .overlay-header-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107208 (owner: 10JGonera) [20:43:42] awjr: I'll add it to the calendar [20:43:47] ty [20:44:00] (03Merged) 10jenkins-bot: Regression: allow text wrapping outside .overlay-header-container [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107208 (owner: 10JGonera) [20:44:10] ok lunchtime then back to CR etc [20:44:14] (03CR) 10Kaldari: [C: 032] Correctly identify lead section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106434 (owner: 10Jdlrobson) [20:45:14] (03Merged) 10jenkins-bot: Correctly identify lead section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106434 (owner: 10Jdlrobson) [20:45:26] (03PS1) 10JGonera: Fix notifications overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107210 [20:46:04] (03CR) 10Cmcmahon: "on beta labs the message is "Whoops.Incorrect or missing CAPTCHA."" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106833 (owner: 10Cmcmahon) [20:48:17] (03PS2) 10Jdlrobson: Fix notifications overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107210 (owner: 10JGonera) [20:48:25] (03CR) 10Jdlrobson: [C: 032] Regression: Fix notifications overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107210 (owner: 10JGonera) [20:50:14] (03Merged) 10jenkins-bot: Regression: Fix notifications overlay header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107210 (owner: 10JGonera) [20:50:16] brion: can you rejoin the hangout for the showcase. chip and i want to test something [20:50:36] awjr: and/or you too [20:55:25] thanks kaldari [20:56:42] (03PS1) 10Yuvipanda: Make Sections be backed by JSON all the time [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107212 [21:00:08] jgonera: did you and jdlrobson figure out a way forward with the browser tests? [21:12:29] (03CR) 10Cmcmahon: "See the message at http://lists.wikimedia.org/pipermail/qa/2014-January/000881.html, Cc'd to mobile-tech" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [21:14:05] awjr: can I help with this "way forward"? [21:20:48] (03PS3) 10Cmcmahon: QA make tests for Create user error to run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106833 [21:22:38] (03CR) 10Cmcmahon: "This is also in answer to Bug 56057" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [21:27:38] awjr, yep [21:27:54] cool jgonera - what did you guys settle on? [21:28:03] chrismcmahon: sounds like they figured it out :) [21:28:24] since the mechanism for opening and closing all overlays is the same, we'll skip the tests for opening and closing this particular one for now [21:29:03] chrismcmahon, but we do want to figure out a way of somehow including specific pages in all instances, e.g. having a page with issues or specific templates [21:29:20] I think I'll get to that after the TDD workshop [21:29:51] jgonera: thus https://gerrit.wikimedia.org/r/#/c/106548/ [21:29:55] jgonera: chrismcmahon sent an email a little while ago called 'creating test data for browser tests at run time' which sounds like it might be a step in that direction [21:30:42] jdlrobson: are you still blocked on code review for the tablet toc? [21:30:43] jgonera: we want to use the Mediawiki API to create pages with particular data at run time. that solves a number of issues, not only for Mobile. JeffHall has been looking into it and making it go. [21:31:06] chrismcmahon, that sounds great, I'll be sure to talk to him [21:31:25] jgonera: and we can create particular users as well, but that will only be useful in local dev envs, places without CAPTCHA in place (at least for now) [21:31:50] chrismcmahon, I can imagine there's going to be some problems, e.g. importing various templates that pages use. also, we don't want to be creating new pages in production, where tests also run [21:31:58] awjr: yes none of my patches for stories in the awaiting final code review column have been code reviewed today [21:32:59] jgonera: we're going to have to distinguish between tests for local env, test for shared env e.g. beta labs and test2wiki, and tests for prod. that's always been true. [21:33:36] jgonera: let us solve one problem at a time [21:35:47] chrismcmahon, sure, sounds good [21:36:45] (03PS1) 10Dr0ptp4kt: Make spinner background opaque. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/107250 [21:37:38] (03PS2) 10Dr0ptp4kt: Make spinner background opaque. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/107250 [21:39:05] jdlrobson: ok - which patchset(s) in particular are blocking you from the tablet toc work? [21:39:08] chrismcmahon, I was also wondering why we have so many different PageObjects. it seems to me, that we should have only a handful for the pages that actually differ, e.g. HomePage, ArticlePage, UploadsPage, etc. [21:39:26] chrismcmahon, I see no point in having, e.g. LanguagePage, because languages can appear on any article page [21:39:50] furthermore, we could use inheritance and have something like BasePage with common elements from which other pages would inherit [21:40:06] they're not really blocking me awjr I just want to make sure the approach i am taking is a good one before continuing. I have a lot of open patches. Also help with https://gerrit.wikimedia.org/r/105994 and friends would be appreciated [21:40:22] the big one I would like review from is https://gerrit.wikimedia.org/r/#/c/106652/ in regards to table of contents [21:41:13] ok - thanks jdlrobson [21:43:44] jgonera: would you send a message to the QA mail list about your ideas for managing pages? I don't think we have any kind of consensus about that right now. [21:44:06] chrismcmahon, sure, I'll do that when I finish what I'm working on right now [21:46:47] jdlrobson: any idea why the capcha mismatch text on your dev env does not match beta or test2wiki? [21:47:31] (03PS2) 10Awjrichards: Load the current page on startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106651 (owner: 10Jdlrobson) [21:48:00] mhurd brion: are we already doing this on iOS and Android https://trello.com/c/MjrP8wlh/120-dynamically-load-sections-as-they-come-near ? [21:48:04] i'm pruning some old stories [21:48:09] (03PS8) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 [21:48:38] tfinc: no we're doing a 2-step load right now [21:48:41] k [21:48:43] this would be a more aggressive optimization [21:48:48] tfinc: not sure what "come near" meant... [21:48:51] but it's not super high-priority so feel free to kick it to the back [21:49:27] brion: its way deep in the backlog. i wanted to see if i could prune it out [21:49:32] chrismcmahon: I suspect this is a local wiki config - since messages can be overriden [21:49:34] i'll take a look [21:49:57] tfinc: yeah I wouldn't cry if it went away :) [21:50:15] chrismcmahon: this is the problem with testing exact message strings.. [21:50:37] http://en.m.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Captcha-createaccount-fail < chrismcmahon [21:50:41] so this overrides the default [21:52:29] chrismcmahon: oh wait.. that string got changed in core [21:52:35] that is the core message [21:52:54] even so it seems dangerous to check exact message strings for this very reason.. [21:57:35] brion: did you end up picking up the spike and/or toc from https://trello.com/b/ErAleyXy/mobile-app-sprint-22-editing ? [21:59:18] (03CR) 10Jdlrobson: [C: 032] "Apologies, I updated the ConfirmEdit extension and it seems like this message was recently changed so now the test passes." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106833 (owner: 10Cmcmahon) [21:59:52] (03Merged) 10jenkins-bot: QA make tests for Create user error to run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106833 (owner: 10Cmcmahon) [22:00:06] brion: mhurd : captcha refresh https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1609 [22:03:22] tfinc: i believe the api-side component of that is already in, yeah [22:08:13] jdlrobson: im testing https://gerrit.wikimedia.org/r/#/c/106651/2 and it appears that this causes sections to be uncollapsed by default? [22:11:08] awjr: why would it? Are you testing in beta which opens sections by default if you have a wide screen? [22:11:44] ah yeah that's it, jdlrobson [22:11:50] (wide screen) [22:14:24] (03PS4) 10JGonera: Story 1462: Move new overlay code and new editor to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106658 [22:14:26] (03PS4) 10JGonera: Story 1462: Move new uploads overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106659 [22:14:28] (03PS3) 10JGonera: Story 1462: Move new languages overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106854 [22:14:30] (03PS2) 10JGonera: Story 1462: Move new notifications overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107198 [22:14:32] (03PS2) 10JGonera: Story 1462: Move new search overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107192 [22:14:34] (03PS2) 10JGonera: Story 1462: Move new issues overlay to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107195 [22:14:36] (03PS1) 10JGonera: Story 1462: Move new page header to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107253 [22:16:14] chrismcmahon: could you take another look at https://gerrit.wikimedia.org/r/105106 ? [22:17:25] (03CR) 10Awjrichards: [C: 032] Load the current page on startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106651 (owner: 10Jdlrobson) [22:17:26] awjr, jdlrobson, kaldari, I mostly finished the story about moving the new overlays and header to stable: https://gerrit.wikimedia.org/r/#/c/106658/ there are 7 patches in total so I would appreciate if this could get reviewed asap to avoid a rebase hell. I promise I'll do some code review of your patches too ;) There is still some cleanup needed after those patches get merged but I prefer to do it after this gets merged ( [22:17:26] and it should still be deployable without the cleanup) [22:17:47] jgonera: awesome! [22:17:58] jgonera: i know jdlrobson would appreciate some review, he's got a ton of outstanding patchsets [22:18:11] will do! [22:18:20] (03PS2) 10Awjrichards: Make sections aware of their subsections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106652 (owner: 10Jdlrobson) [22:18:33] (03Merged) 10jenkins-bot: Load the current page on startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106651 (owner: 10Jdlrobson) [22:21:16] jdlrobson: I was looking for the story about the create-account failure msgs but didn't find it. part of the test was to check that the new "Whoops" msgs. made it out to prod, but it was also to walk awjr through the process of writing the tests. Sometimes checking for message strings is the right thing to do; sometimes it is the right thing to do only for a while. [22:25:28] (03PS1) 10JGonera: Regression: fix notifications header in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107254 [22:26:28] (03CR) 10Awjrichards: [C: 032] Make sections aware of their subsections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106652 (owner: 10Jdlrobson) [22:26:38] (03CR) 10JGonera: [C: 032] Close overlay when invalid image selected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106853 (owner: 10Jdlrobson) [22:26:48] jdlrobson: can you please resolve the path conflict in https://gerrit.wikimedia.org/r/#/c/106469/ [22:27:03] (03Merged) 10jenkins-bot: Make sections aware of their subsections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106652 (owner: 10Jdlrobson) [22:27:32] (03Merged) 10jenkins-bot: Close overlay when invalid image selected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106853 (owner: 10Jdlrobson) [22:32:20] (03PS9) 10Cmcmahon: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson) [22:35:41] (03PS3) 10Jdlrobson: Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 [22:37:10] (03PS13) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [22:41:11] (03PS14) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [22:42:35] (03PS3) 10Jdlrobson: Hygiene: Style the styleguide to look like more like mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106316 [22:42:37] (03PS1) 10Jdlrobson: Hygiene: Use RL generated CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107255 [22:42:39] (03PS15) 10Kaldari: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 [22:49:56] (03CR) 10Cmcmahon: [C: 04-1] "* much more DRY" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson) [22:50:53] jgonera: In order for this negative margin scheme to be compatible with what the designers want for the footer (max-width with auto margins + 65px side padding), we'll have to either (1) create a footer-container div like the content-container div, or (2) take the footer out of mw-mf-page-center. Maybe a better solution than applying the padding to mw-mf-page-center and then having negative margins on content_wrapper would be to just create a [22:50:54] header-container and apply the padding there. That way it doesn't unintentionally affect the content and footer. [22:51:38] Or we could push back and ask for the weird padding to be removed altogether, which apparently is what Moiz wants. [22:54:27] jgonera: oh yeah, there is one other possible solution. If we change the header padding from ems to pixels, I could substract it from the footer padding. [22:54:50] that way everything would still line up correctly [22:57:55] (03PS2) 10Awjrichards: Story 1581: Remove user intent from profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105996 (owner: 10Jdlrobson) [23:05:19] (03CR) 10Kaldari: [C: 031] Hygiene: Use RL generated CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107255 (owner: 10Jdlrobson) [23:09:43] (03CR) 10Awjrichards: [C: 032] Story 1581: Design tweaks to user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105994 (owner: 10Jdlrobson) [23:10:41] (03Merged) 10jenkins-bot: Story 1581: Design tweaks to user profile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105994 (owner: 10Jdlrobson) [23:11:27] (03CR) 10JGonera: [C: 032] Enable keyboard section toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [23:12:36] (03Merged) 10jenkins-bot: Enable keyboard section toggling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102004 (owner: 10Hoo man) [23:12:58] (03CR) 10Awjrichards: [C: 032] Remove page from last thanked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105995 (owner: 10Jdlrobson) [23:13:36] (03Merged) 10jenkins-bot: Remove page from last thanked [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105995 (owner: 10Jdlrobson) [23:14:57] (03CR) 10Awjrichards: [C: 032] Story 1581: Remove user intent from profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105996 (owner: 10Jdlrobson) [23:15:52] (03Merged) 10jenkins-bot: Story 1581: Remove user intent from profiles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105996 (owner: 10Jdlrobson) [23:20:27] (03CR) 10Jdlrobson: [C: 04-1] "cherry pick to https://gerrit.wikimedia.org/r/107255 and I'll +2 :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 (owner: 10Kaldari) [23:24:55] (03PS1) 10Kaldari: Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107264 [23:29:01] awjr: I think what happened with the api.token revert has to do with the fact that MaxSem cherry picked the revert to a deployment branch named wmf9 (similar to what we used before riding the train), but normally deployment branches are named like wmf/1.23/wmf9, so we ended up having 2 different deployment branches for the same version. [23:29:19] >_< [23:29:28] oops, I mean wmf/1.23wmf9 not wmf/1.23/wmf9 [23:29:36] that is confusing :( [23:30:06] awjr, maxsem: I would suggest we adopt the wmf/1.23wmf9 standard as this is what core and the other extensions are using [23:30:16] just to avoid confusion [23:30:44] kaldari, branch names mean nothing, you can call them bhsretnjhrthnjerstnFTDGN and it will work if you did everyhting righh [23:30:48] *right [23:31:11] exactly, but it's easier to push to the wrong branch if we aren't consistant [23:31:16] and I deployed in on the 2nd: https://gerrit.wikimedia.org/r/#/c/105113/ [23:31:33] now the problem is fixed with automatic branches [23:31:34] kaldari, kenanwang_ : chat still on? Hang out? [23:32:13] yeah, but then I did another lightning deployment and we ended up with two branches since I didn't know you used the non-standard wmf9 name [23:33:30] kaldari you joining? [23:33:33] anyway, I'm happy to accept the blame for the mistake, but it would be good to keep things consistant with MW practices [23:33:35] (03PS3) 10JGonera: Hygiene: Document defaults, template and templatePartials in View.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106314 (owner: 10Jdlrobson) [23:34:19] (03CR) 10JGonera: [C: 031] "Jon, I modified it a bit. Feel free to +2." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106314 (owner: 10Jdlrobson) [23:35:07] (03CR) 10Jdlrobson: [C: 032] Hygiene: Document defaults, template and templatePartials in View.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106314 (owner: 10Jdlrobson) [23:35:41] (03Merged) 10jenkins-bot: Hygiene: Document defaults, template and templatePartials in View.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106314 (owner: 10Jdlrobson) [23:36:30] (03CR) 10JGonera: [C: 04-1] Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 (owner: 10Jdlrobson) [23:38:50] (03CR) 10Jdlrobson: [C: 032] Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 (owner: 10Kaldari) [23:39:25] (03Merged) 10jenkins-bot: Story 1563: Typography updates for Tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106181 (owner: 10Kaldari) [23:39:41] (03CR) 10JGonera: [C: 04-1] "This breaks the styleguide making it completely unstyled for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106316 (owner: 10Jdlrobson) [23:39:49] awjr: if i log a beta bug does it go straight to mingle or no? [23:39:54] jgonera: how? [23:40:02] kenanwang_: you mean for MobileFrontend bea? [23:40:04] *beta [23:40:07] i logged a bug that i didnt see this morning [23:40:07] jdlrobson, ? [23:40:11] yes [23:40:18] it should [23:40:19] jgonera: did you look at https://gerrit.wikimedia.org/r/#/c/107255/1 and set the config variable ? [23:40:22] kenanwang_: what's the bug? [23:40:30] i'm guessing not based on your -1 to v [23:40:31] https://gerrit.wikimedia.org/r/#/c/106316/ [23:40:57] jdlrobson, oh, sorry, I didn't [23:41:10] nevermind awjr i found [23:41:14] :) [23:41:14] phew that makes more sense then! [23:41:26] jdlrobson, still, I don't know what variable I should set [23:41:41] https://gerrit.wikimedia.org/r/#/c/107255/1/Makefile < jgonera [23:41:47] should explain all [23:43:10] can we add this to the commit message? [23:43:57] if that helps you - i figured since I mentioned the Makefile was changed and that was the main purpose of the commit it would be obvious :-) [23:44:06] jdlrobson, ^ also, possibly change localhost to 127.0.0.1 as we do everywhere else [23:44:09] (03PS1) 10Jdlrobson: Hygiene: Remove console.log statement from tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107265 [23:44:12] sure thing [23:48:17] (03CR) 10JGonera: "Now I see how it works, but frankly I think that's a risky patchset for two reasons:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106316 (owner: 10Jdlrobson) [23:48:51] (03CR) 10JGonera: [C: 032] Hygiene: Use RL generated CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107255 (owner: 10Jdlrobson) [23:49:39] (03Merged) 10jenkins-bot: Hygiene: Use RL generated CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107255 (owner: 10Jdlrobson) [23:57:08] jdlrobson, does anyone from the product managers know about https://gerrit.wikimedia.org/r/#/c/102866/ ? marktraceur told me we should notify them about any new beta feature [23:59:09] Thanks jgonera. [23:59:17] James_F|Away: ^^