[00:00:11] <James_F|Away>	 jgonera: Aha. No.
[00:02:17] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032 V: 032] Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens" [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107264 (owner: 10Kaldari)
[00:03:09] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Ideally the image should be in keeping with all the other Beta Features – have you asked Design?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson)
[00:03:38] <grrrit-wm>	 (03PS1) 10Kaldari: Correctly identify lead section [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107269 
[00:04:15] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032 V: 032] Correctly identify lead section [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107269 (owner: 10Kaldari)
[00:04:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Correctly identify lead section [extensions/MobileFrontend] (wmf/1.23wmf9) - 10https://gerrit.wikimedia.org/r/107269 (owner: 10Kaldari)
[00:41:42] <grrrit-wm>	 (03PS5) 10Kaldari: Hi-res external link icons!!! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 
[00:43:39] <grrrit-wm>	 (03CR) 10Kaldari: "@Mattflaschen: The SVGs are the same except they are optimized for mobile, i.e. all unneeded SVG code has been striped out. We might want " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 (owner: 10Kaldari)
[00:47:45] <grrrit-wm>	 (03PS2) 10Kaldari: Hygiene: Reshuffle content / page action overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106128 (owner: 10Jdlrobson)
[00:47:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Reshuffle content / page action overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106128 (owner: 10Jdlrobson)
[00:48:39] <grrrit-wm>	 (03PS3) 10Kaldari: Hygiene: Reshuffle content / page action overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106128 (owner: 10Jdlrobson)
[00:50:03] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Hygiene: Reshuffle content / page action overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106128 (owner: 10Jdlrobson)
[00:50:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Reshuffle content / page action overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106128 (owner: 10Jdlrobson)
[00:53:12] <kaldari>	 kaity, jgonera: does anyone have an SVG for the hamburger?
[00:53:32] <jgonera>	 kaldari, I think I do, why?
[00:53:38] <jgonera>	 oh, the SVG patch
[00:53:49] <kaldari>	 I was gonna stick it in the less file
[00:54:04] <kaity>	 it should be on the mingle
[00:54:29] <jgonera>	 kaldari, e-mailed it to you
[00:54:31] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=48946 < violetto 
[00:54:32] <kaity>	 oops its not
[00:54:49] <kaldari>	 jdlrobson: BTW, your patch for the lead section should be deployed on en.wiki now.
[00:55:14] <kaldari>	 jgonera: thanks
[00:56:46] <jdlrobson>	 kaldari: checking
[00:56:59] <jdlrobson>	 kaldari: is the token fix also there?
[00:57:05] <kaldari>	 yes
[00:57:25] <jdlrobson>	 looks good kalamaridari
[00:57:30] <jdlrobson>	 seems to be working
[01:05:29] <awjr>	 kalamaridari
[01:05:30] <awjr>	 hahaha
[01:05:42] <awjr>	 this pleases me.
[01:13:26] <grrrit-wm>	 (03PS1) 10Kaldari: Correctly identify lead section [extensions/MobileFrontend] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107289 
[01:13:51] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Correctly identify lead section [extensions/MobileFrontend] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107289 (owner: 10Kaldari)
[01:15:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Correctly identify lead section [extensions/MobileFrontend] (wmf/1.23wmf10) - 10https://gerrit.wikimedia.org/r/107289 (owner: 10Kaldari)
[01:32:10] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Don't load View.js twice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107292 
[01:32:13] <jdlrobson>	 ^ jgonera kaldari eek
[01:32:47] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Hygiene: Don't load View.js twice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107292 (owner: 10Jdlrobson)
[01:33:07] <jdlrobson>	 thanks jgonera 
[01:33:08] <jdlrobson>	 also https://gerrit.wikimedia.org/r/107265
[01:33:09] <jdlrobson>	 :)
[01:33:17] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hi-res external link icons!!! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 (owner: 10Kaldari)
[01:35:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Don't load View.js twice [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107292 (owner: 10Jdlrobson)
[01:38:24] <grrrit-wm>	 (03PS1) 10Kaldari: A couple follow-up changes for the typography update. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107299 
[01:39:26] <grrrit-wm>	 (03PS3) 10Jdlrobson: Story 1522: Table of contents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106469 
[01:39:28] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Deprecate view (lowercase) module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107300 
[01:43:09] <grrrit-wm>	 (03PS7) 10Jdlrobson: Hi-res external link icons!!! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 (owner: 10Kaldari)
[01:45:53] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hi-res external link icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 (owner: 10Kaldari)
[01:47:44] <kaldari>	 jdlrobson, jgonera: any chance I could get a quick review of https://gerrit.wikimedia.org/r/#/c/107299/ (since the main change has already been merged)
[01:48:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hi-res external link icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106765 (owner: 10Kaldari)
[02:09:25] <grrrit-wm>	 (03PS1) 10Awjrichards: Show 404 when accessing Special:MobileEditor directly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107305 
[02:13:48] <grrrit-wm>	 (03PS1) 10Kaldari: Adding SVG support for humburger icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107308 
[02:43:24] <mhurd>	 tfinc: i emailed list and texted brion
[02:43:28] <tfinc>	 mhurd: thanks
[07:55:49] <grrrit-wm>	 (03PS1) 10Yuvipanda: Load sections asynchronously in the webview [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107338 
[09:31:59] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add loading animation to bottom of page when fetching sections [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107344 
[09:36:02] <yuvipanda>	 violetto1: http://dabblet.com/gist/8415677
[09:38:56] <grrrit-wm>	 (03PS2) 10Yuvipanda: Add loading animation to bottom of page when fetching sections [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107344 
[11:15:34] <grrrit-wm>	 (03PS1) 10Yuvipanda: Prevent race condition causing marshaller to not be registered [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107353 
[16:09:23] <grrrit-wm>	 (03PS10) 10Jhall: QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 
[17:04:47] <grrrit-wm>	 (03PS2) 10Awjrichards: Show 404 when accessing Special:MobileEditor directly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107305 
[18:01:52] <yuvipanda>	 hey brion
[18:01:57] <brion>	 morning
[18:02:02] <brion>	 or whatever time it is :D
[18:03:55] <yuvipanda>	 brion: heh
[18:03:59] <yuvipanda>	 brion: see patches?
[18:04:42] <brion>	 moment
[18:05:58] <mhurd>	 yuvipanda: brion heys!
[18:06:36] <yuvipanda>	 mhurd: heya!
[18:07:51] <mhurd>	 yuvipanda: i got the card for clicking on section edit icon working yesterday! today is "save the wikitext" day. to *testwiki*... gotta remember that part :)
[18:08:05] <yuvipanda>	 mhurd: nice!
[18:08:08] <yuvipanda>	 mhurd: yeah, that
[18:08:12] <mhurd>	 hehe
[18:09:00] <superm401>	 MaxSem, could you take another look at the GettingStarted API change?
[18:09:06] <superm401>	 https://gerrit.wikimedia.org/r/#/c/103737
[18:10:20] <tfinc>	 brion: yo
[18:10:25] <brion>	 yo
[18:10:31] <tfinc>	 brion: did you see montes mail about "Had a conversation with May about app design." ?
[18:10:36] <brion>	 yeah
[18:10:39] <brion>	 we good :)
[18:13:14] <MaxSem>	 superm401, me? at JS?:P
[18:13:49] <superm401>	 MaxSem, ah, didn't know you weren't a JS guy.
[18:14:02] <superm401>	 JGonera is not around, so I'll wait unles someone else wants to take a stab at it.
[18:14:19] <MaxSem>	 well, I can write it a bit, but you'd better not rely on me for reviews:)
[18:17:25] <grrrit-wm>	 (03PS2) 10Jdlrobson: Regression: fix notifications header in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107254 (owner: 10JGonera)
[18:17:31] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Regression: fix notifications header in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107254 (owner: 10JGonera)
[18:18:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Regression: fix notifications header in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107254 (owner: 10JGonera)
[18:19:50] <grrrit-wm>	 (03CR) 10MaxSem: [C: 04-1] (Bug 59873) Show 404 when accessing Special:MobileEditor directly (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107305 (owner: 10Awjrichards)
[18:20:02] <mhurd>	 hey brion! any chance to poke https://gerrit.wikimedia.org/r/#/c/107104/ 
[18:20:22] <brion>	 moment
[18:24:11] <yuvipanda>	 brion: I'll be off in about 30mins, think you can look at my patches before then? :D
[18:24:34] <brion>	 reading and responding to email. will be with y'all in a moment
[18:24:45] <mhurd>	 brion: no rush on mine!
[18:25:04] <yuvipanda>	 brion: ok :)
[18:25:44] <brion>	 ok where was i
[18:25:50] <brion>	 yuvipanda: CR time !
[18:26:44] <yuvipanda>	 brion: woo!
[18:27:16] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Doesn't explode, passes tests, installs!" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/107120 (owner: 10Yuvipanda)
[18:27:54] <brion>	 yuvipanda: hey did you want me to update https://gerrit.wikimedia.org/r/#/c/93097/ or should i abandon it to get it out of the way?
[18:28:10] <yuvipanda>	 brion: I'll pick it up end of the week
[18:28:12] <brion>	 ok
[18:28:20] <grrrit-wm>	 (03CR) 10Jdlrobson: Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 (owner: 10Jdlrobson)
[18:28:29] <brion>	 doesn't seem to be hurting us much not to have it but it'll make for some slightly cleaner test cases in future
[18:29:54] <yuvipanda>	 brion: yeah, true
[18:30:05] <awjr>	 brion scrum of scrums?
[18:30:33] <brion>	 whee
[18:30:43] <brion>	 so that's what gcal was chiming for :D
[18:31:11] <brion>	 awjr: ok i'm listening in
[18:31:34] <awjr>	 :D
[18:32:00] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Use OkHttp for HTTP requests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107121 (owner: 10Yuvipanda)
[18:35:35] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 
[18:35:37] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 
[18:35:39] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 
[18:35:41] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 (owner: 10Jdlrobson)
[18:35:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 (owner: 10Jdlrobson)
[18:35:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 (owner: 10Jdlrobson)
[18:36:47] <brion>	     junit.framework.AssertionFailedError: expected:<16> but was:<1>
[18:38:20] <grrrit-wm>	 (03CR) 10Brion VIBBER: "This test fails for me:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107212 (owner: 10Yuvipanda)
[18:38:52] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 
[18:38:54] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 
[18:38:56] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 
[18:42:12] <brion>	 yuvipanda: ^
[18:42:18] <yuvipanda>	 brion: looking
[18:43:39] <jdlrobson>	 milimetric: in summary.. limn graphs done, need help from VE folks for Firefox OS work, mostly UX fixes and need to coordinate with Zero so we don't break it
[18:44:33] <kaldari>	 jdlrobson: I currently get an "obj undefined" error when I try editing on beta labs. Is that the error that's caused by the section zero bug you fixed yesterday?
[18:44:48] <kaldari>	 might just need to update beta labs
[18:47:05] <kaldari>	 wow gerrit just crashed firefox
[18:48:32] <awjr>	 just heard that VE is hosed on betalabs at the moment
[18:48:39] <awjr>	 dunno if that's what you're facing kaldari
[18:48:46] <milimetric>	 thx jdlrobson
[18:49:01] <kaldari>	 awjr: I was testing in stable mode
[18:49:05] <awjr>	 ah
[18:49:50] <grrrit-wm>	 (03CR) 10Brion VIBBER: Make Sections be backed by JSON all the time (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107212 (owner: 10Yuvipanda)
[18:50:10] <kaldari>	 looks like beta has jdlrobson 's fix in place
[18:51:12] <kaldari>	 awjr: I imagine the VE breakage could be related though
[18:51:40] <awjr>	 kaldari: indeed 
[18:51:53] <awjr>	 kaldari: during scrum of scrums just now, greg-g mentioned that beta cluster extensions are not updating properly
[18:52:04] <awjr>	 which i htik was the reason for VE breakage, and presumably for other weirdness
[18:52:22] <greg-g>	 yeah :/
[18:52:33] <kaldari>	 awjr: and of course the error is happening in jQuery, so no obvious cause :P
[18:52:44] <awjr>	 fun!
[18:53:02] <Reedy>	 We can force update VisualEditor to get it to master...
[18:53:08] <Reedy>	 Obviously won't stay up to date...
[18:53:15] <Reedy>	 But bridges the current gap
[18:53:28] <James_F>	 Reedy: That'd help.
[18:53:37] <awjr>	 aye
[18:54:35] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 
[18:54:37] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 
[18:54:39] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 
[18:54:55] <Reedy>	 	-Subproject commit 3e925e634398ab80711819ee4c10a29b89854588
[18:54:55] <Reedy>	 +Subproject commit 278bcd9a20e485230034a9db1f942255ec131027
[18:56:34] <grrrit-wm>	 (03PS1) 10Jdlrobson: Regression: Don't load button and mainmenu styles twice in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107401 
[18:56:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Regression: Don't load button and mainmenu styles twice in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107401 (owner: 10Jdlrobson)
[18:58:22] <Reedy>	 Should be done...
[19:02:02] <tfinc>	 yuvipanda: brion: were on the hangout
[19:02:34] <yuvipanda>	 tfinc: yeah, on it
[19:02:47] <brion>	 agh moment
[19:02:57] <tfinc>	 yuvipanda: not seeing you
[19:05:17] <tfinc>	 brion: https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AlEIL4N8KjNndHp1LTlmbkFqRkV0amNIRUhxaHdmV1E&usp=drive_web
[19:05:40] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "We can actually improve this a bit more now. Maybe Adam and I should pair on it?" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103404 (owner: 10Jdlrobson)
[19:13:35] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] "needs a rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107198 (owner: 10JGonera)
[19:22:57] <grrrit-wm>	 (03PS2) 10Yuvipanda: Prevent race condition causing marshaller to not be registered [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107353 
[19:22:59] <grrrit-wm>	 (03PS2) 10Yuvipanda: Load sections asynchronously in the webview [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107338 
[19:23:01] <grrrit-wm>	 (03PS3) 10Yuvipanda: Add loading animation to bottom of page when fetching sections [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107344 
[19:23:03] <grrrit-wm>	 (03PS2) 10Yuvipanda: Make Sections be backed by JSON all the time [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107212 
[19:23:05] <grrrit-wm>	 (03CR) 10Yuvipanda: "Fixed" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107212 (owner: 10Yuvipanda)
[19:23:20] <awjr>	 kenanwang_: are you in/working today?
[19:23:25] <awjr>	 or still sick?
[19:23:34] <yuvipanda>	 awjr: he's in mobile app meeting
[19:23:42] <awjr>	 ty yuvipanda
[19:23:46] <yuvipanda>	 yw
[19:26:09] <yuvipanda>	 brion: updated to fix the issues
[19:26:15] <brion>	 tx :D
[19:29:42] <kenanwang_>	 Yep in a couple meetings right now what's up? Awjr
[19:29:59] <awjr>	 nothing specific kenanwang_, just curious if you were still out sick :)
[19:32:10] <brion>	 yuvipanda: ok lemme finish up this CR then i gotta run some errands and grab lunch :D
[19:32:16] <yuvipanda>	 brion: okay!
[19:32:56] <brion>	 \o/ 11:32:48 AM Tests passed
[19:33:40] <yuvipanda>	 brion: :)
[19:33:46] <yuvipanda>	 brion: glad we caught that :)
[19:34:39] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "pass ze test" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107212 (owner: 10Yuvipanda)
[19:35:48] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Load sections asynchronously in the webview [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107338 (owner: 10Yuvipanda)
[19:35:52] <yuvipanda>	 brion: this has stopped the stutering I have had
[19:36:17] <yuvipanda>	 I've one more trick too, if I want to make it stutter even less
[19:37:27] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Add loading animation to bottom of page when fetching sections [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107344 (owner: 10Yuvipanda)
[19:37:56] <brion>	 aha you found that race condition :D
[19:38:00] <yuvipanda>	 brion: yeah! :)
[19:38:03] <brion>	 d'oh yeah that makes sense
[19:38:42] <yuvipanda>	 brion: one of my roommates also has a HTC One X, which ocnsistently had this problem
[19:38:43] <yuvipanda>	 so
[19:38:45] <yuvipanda>	 easier to debug
[19:38:54] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "woot!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107353 (owner: 10Yuvipanda)
[19:38:55] <yuvipanda>	 brion: I went about 20 pages without encountering that issue
[19:39:08] <yuvipanda>	 brion: okay, I'm off to sleep now :)
[19:39:09] <brion>	 heh
[19:39:12] <brion>	 ok gnight :D
[19:39:12] <kaldari>	 kaity, vbamba: I'm about to start working on infoboxes for tablet. If you have suggestions / want to collaborate, let me know.
[19:39:18] <yuvipanda>	 brion: you should poke people for code review
[19:39:24] <brion>	 i shall
[19:39:38] <kaity>	 kaldari: yes!
[19:39:44] <kaity>	 whats your plan now?
[19:40:05] <jdlrobson>	 awjr: we need to reschedule next weeks sprint kick off
[19:40:12] <awjr>	 holiday!
[19:40:13] <awjr>	 you're right
[19:40:23] <awjr>	 thanks for reminding me jdlrobson
[19:40:39] <brion>	 mhurd: ok i'll check out the concurrency fix shortly, brb 
[19:40:47] <mhurd>	 brion: cool!
[19:41:01] <awjr>	 jdlrobson: looks like we can do same times on tuesday but in r37, i think
[19:41:22] <kaldari>	 kaity: I'm not completely sure. I was thinking we would remove a lot of the mobile-specific customization, and just make sure the text flows around it correctly and the width is sensible.
[19:42:32] <kaity>	 kaldari: that makes sense, I'll come by soon
[19:42:35] <kaldari>	 kaity: maybe tweaking some of the typography as well
[19:42:36] <awjr>	 jdlrobson: done, thanks gain
[19:42:37] <awjr>	 *again
[19:55:16] <kaldari>	 awjr, jdlrobson: just got the "obj undefined" error when editing locally. I think this is some kind of race condition that is worse on beta labs.
[20:21:45] <milimetric>	 hey nice, I'm sure you know this jdlrobson but your graphs rebounded and the errors dropped
[20:21:50] <milimetric>	 so whatever you did must've fixed uploads
[20:56:18] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "so far feels more stable :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/107104 (owner: 10Mhurd)
[21:12:00] <tfinc>	 brion: how are we looking for tomorrows build ?
[21:20:20] <brion>	 tfinc: should be a pretty stable build for iOS; things shaping up nicely on android
[21:20:35] <brion>	 now we gotta implement the bits that aren't done on the other platform and we'll have some parity :D
[21:27:14] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Coupla times I've gotten an error like this while scrolling quickly through the ToC:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/107104 (owner: 10Mhurd)
[21:27:21] <MaxSem>	 awjr, did you bisect MF in production?
[21:27:43] <awjr>	 MaxSem: on tin
[21:27:53] <MaxSem>	 yep, and forgot to clean up;)
[21:27:55] <awjr>	 OH SHIT
[21:27:59] <awjr>	 whoops
[21:28:05] <awjr>	 MaxSem: still busted?
[21:28:33] <MaxSem>	 awjr, in what state did you leave it, is it safe to scap?
[21:28:43] <awjr>	 probably not :(
[21:28:51] <awjr>	 MaxSem: the bisect just needs to be terminated
[21:28:55] <mhurd>	 brion: yay! oh yeah i've seen that bug too. it's autolayout constraint update relate i believe
[21:29:05] <brion>	 aha
[21:29:07] <MaxSem>	 unfortunately, I nuked .git/BISECT_* already:(
[21:29:15] <brion>	 must be getting a bad coord from something
[21:29:28] <awjr>	 huh what does that do, MaxSem?
[21:29:31] <mhurd>	 brion: ya
[21:29:38] <MaxSem>	 tracks your bisect
[21:29:42] <awjr>	 hmm
[21:29:48] <awjr>	 MaxSem: what does git bisect reset do?
[21:29:55] <awjr>	 i mean, if you run it now without .git/BISECT_*
[21:30:08] <MaxSem>	 commit 0c8faa313bcc975526ffa5426b60ece5da5f4f15
[21:30:08] <MaxSem>	 Author: jrobson <jrobson@wikimedia.org>
[21:30:08] <MaxSem>	 Date:   Wed Jan 8 13:48:18 2014 -0800
[21:30:08] <MaxSem>	  
[21:30:08] <MaxSem>	     Correctly identify lead section
[21:31:46] <awjr>	 MaxSem: ok and maybe follow up with a git reset —hard HEAD to be safe?
[21:31:52] <MaxSem>	 awjr, phew - was OK, I'm resuming scap
[21:31:56] <awjr>	 phew
[21:32:01] <awjr>	 sorry MaxSem, that was foolish  on my part :(
[21:34:48] <dfoy>	 yurik: ping
[21:49:40] <brion>	 tfinc: ok apple says they're going to call you for verification next and we think it's clear sailing from there :D
[21:51:16] <MaxSem>	 awjr, https://wikimedia.mingle.thoughtworks.com/projects/scrum_of_scrums/cards/63 can be closed
[21:51:36] <awjr>	 yeah MaxSem, i marked it as done this morning :)
[22:01:09] <tfinc>	 brion: great
[22:06:50] <Virox>	 wow, you guys dont use any frameworks
[22:07:10] <tfinc>	 yurik: https://www.mediawiki.org/wiki/Search
[22:07:39] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "I'll sync up with you, Jon. We should also discuss the beta langlinks functionality." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103404 (owner: 10Jdlrobson)
[22:09:01] <jgonera>	 Virox, you mean in PHP or JS?
[22:09:13] <Virox>	 Ive just been looking through the iOS app source code
[22:10:04] <jgonera>	 oh, in the app, which one? we have an old one that is no longer developed that uses PhoneGap, but there are new ones being developed
[22:10:15] <Virox>	 Its the new reader app
[22:10:29] <jgonera>	 mhurd ^
[22:10:48] <Virox>	 https://github.com/wikimedia/apps-ios-wikipedia
[22:11:25] <jgonera>	 Virox, what would you suggest to use for it?
[22:11:35] <Virox>	 Its cool that it's all native. I've never liked phonegap
[22:11:46] <Virox>	 jgonera: What do you mean, use it for?
[22:11:57] <Virox>	 I was just surprised you guys aren't using ANY third party frameworks
[22:12:04] <jgonera>	 Virox, oh, I thought you were saying that we should
[22:12:10] <Virox>	 Nah
[22:12:45] <Virox>	 just some stuff is made easier with frameworks. I tend to use AFNetworking for example instead of writing my own network stuff (it's not hard just consumes more time)
[22:12:49] <jgonera>	 I can't say much about it, but from what I heard PhoneGap was a pain to debug
[22:13:03] <Virox>	 yeah ive worked with phonegap in the past and it is a nightmare for debuggin
[22:13:29] <jgonera>	 mhurd, have you heard about AFNetworking?
[22:13:41] <mhurd>	 jgonera: ya
[22:14:26] <mhurd>	 jgonera: it's fine. i prefer finer-grain control is all :)
[22:22:24] <Virox>	 yeah :)
[22:25:10] <tfinc>	 yurik: http://mobile-reportcard.wmflabs.org/graphs/edits-monthly-5plus-editors
[22:29:25] <superm401>	 jgonera, could you review the API patch we were talking about? https://gerrit.wikimedia.org/r/#/c/103737/
[22:29:30] <superm401>	 I made the change you requested.
[22:29:45] <jgonera>	 superm401, sure, I'll do it today!
[22:30:13] <superm401>	 jgonera, much obliged.
[22:49:27] <grrrit-wm>	 (03PS1) 10Kaldari: Fixing CSS resets in reset.css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 
[22:50:13] <grrrit-wm>	 (03PS2) 10Kaldari: Fixing CSS resets in reset.css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 
[22:51:38] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] A couple follow-up changes for the typography update. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107299 (owner: 10Kaldari)
[22:52:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: A couple follow-up changes for the typography update. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107299 (owner: 10Kaldari)
[22:53:06] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/107265/1 < jgonera kaldari 
[22:53:31] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Hygiene: Remove console.log statement from tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107265 (owner: 10Jdlrobson)
[22:54:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Remove console.log statement from tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107265 (owner: 10Jdlrobson)
[22:55:15] <grrrit-wm>	 (03PS1) 10MaxSem: Remove text extracts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107496 
[22:58:22] <jdlrobson>	 chrismcmahonafk: is there any way we can get this merged in some form - https://gerrit.wikimedia.org/r/105106 - the problem here is that there is no way to accurately define a user who has previously editing - this is again due to this longstanding issue of environmental differences (fwiw if Selenium User makes a single edit on beta labs then this test will pass)
[23:01:03] <jdlrobson>	 also chrismcmahonafk how on earth do i test on beta labs without the credentials?
[23:02:20] <JeffHall>	 jdlrobson: I can send you the Selenium_user password for betalabs - hang on a sec...
[23:02:35] <jdlrobson>	 thanks JeffHall i'm really keen to wrap up https://gerrit.wikimedia.org/r/#/c/105106/
[23:03:23] <grrrit-wm>	 (03CR) 10Jdlrobson: "What does "much more DRY" mean?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 (owner: 10Jdlrobson)
[23:18:44] <grrrit-wm>	 (03PS10) 10Jdlrobson: QA: Add tests for lead photo and uploads workflows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105106 
[23:20:50] <grrrit-wm>	 (03CR) 10Jdlrobson: "Thanks adding the bug number gives context to this patch now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall)
[23:21:43] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Not 100% clear what this is fixing and why it is a fix. Can you raise a bug to make this clearer or elaborate on the commit message?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 (owner: 10Kaldari)
[23:22:31] <jdlrobson>	 jgonera: kaldari can we get this merged - https://gerrit.wikimedia.org/r/107401 - yucky css in current state
[23:24:51] <grrrit-wm>	 (03PS2) 10JGonera: Future proof ZeroOverlay [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103404 (owner: 10Jdlrobson)
[23:25:02] <kaldari>	 jdlrobson: I just need these resets fixed before I mess with the infobox styling, since these incorrect resets affect how infoboxes are rendered. (otherwise I can just fix it in the infobox styling, but it's strange to override something that shouldn't be incorrect in the first place.
[23:25:24] <kaldari>	 I'll elaborate in the commit message
[23:26:46] <kaldari>	 jdlrobson: importantly, I'm not making a design change, I'm just fixing 2 errors in the resets.
[23:28:56] <grrrit-wm>	 (03PS3) 10Kaldari: Fixing CSS resets for tables in reset.css and hacks.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 
[23:29:13] <grrrit-wm>	 (03PS4) 10Kaldari: Fixing CSS resets for tables in reset.css and hacks.less [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 
[23:29:21] <grrrit-wm>	 (03PS2) 10Jdlrobson: Adding SVG support for humburger icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107308 (owner: 10Kaldari)
[23:29:27] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Adding SVG support for hamburger icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107308 (owner: 10Kaldari)
[23:29:56] <jgonera>	 jdlrobson, dr0ptp4kt https://gerrit.wikimedia.org/r/#/c/103404/ that should be enough for now
[23:30:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Adding SVG support for hamburger icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107308 (owner: 10Kaldari)
[23:32:35] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 
[23:32:37] <grrrit-wm>	 (03CR) 10Kaldari: Fixing CSS resets for tables in reset.css and hacks.less (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 (owner: 10Kaldari)
[23:32:45] <dr0ptp4kt>	 jdlrobson, testing
[23:35:17] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-2] "Do not merge until all the needed by patches have been merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106658 (owner: 10JGonera)
[23:37:38] <mhurd>	 brion: have some time to review see-wikitext story?
[23:37:52] <grrrit-wm>	 (03CR) 10JGonera: "You mean +2ed?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106658 (owner: 10JGonera)
[23:37:52] <brion>	 mhurd: sure!
[23:37:58] <grrrit-wm>	 (03PS1) 10Mhurd: Retrieves wiki text for section when edit icon tapped. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/107508 
[23:38:21] <mhurd>	 brion: ^ (it's just the tap the edit icon story - doesn't save yet or show error msgs)
[23:38:32] <brion>	 whee
[23:39:33] <brion>	 hmmm
[23:39:35] <brion>	 *** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSCFSet: 0x10967bbf0> was mutated while being enumerated.'
[23:39:36] <brion>	 dang
[23:39:54] <brion>	 ok that was an odd error
[23:40:01] <brion>	 second run ok though
[23:40:03] <grrrit-wm>	 (03PS3) 10Awjrichards: (Bug 59873) Show 404 when accessing Special:MobileEditor directly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107305 
[23:40:10] <brion>	 we'll have to see if that ever happens for real :D
[23:40:29] <mhurd>	 brion: ya that was the one i mentioned at last standup - at least it doesn't just lock w/o msg :)
[23:40:36] <brion>	 yeah :D
[23:40:46] <grrrit-wm>	 (03PS3) 10JGonera: Future proof ZeroOverlay [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103404 (owner: 10Jdlrobson)
[23:41:28] <brion>	 scrolling in the text field seems a bit odd in simulator... lemme grab device
[23:41:30] <jdlrobson>	 jgonera: hmm? merge = +2ed no? :)
[23:41:42] <jdlrobson>	 oh i see what you mean
[23:41:49] <jdlrobson>	 semantics ;-)
[23:43:10] <jgonera>	 yeah, merge means to me that it's already in master ;)
[23:43:14] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032] Future proof ZeroOverlay [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103404 (owner: 10Jdlrobson)
[23:43:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Future proof ZeroOverlay [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/103404 (owner: 10Jdlrobson)
[23:44:21] <dr0ptp4kt>	 ^yurik: jgonera and jdlrobson reasoned that they can silently replace the old overlay with the new overlay. regarding the langlinks stuff, that is *not* going to stable soon.
[23:44:46] <yurik>	 dr0ptp4kt, cool. I will review the patch in a bit
[23:44:55] <dr0ptp4kt>	 i +2'd it, don't smack me yurik
[23:45:59] <grrrit-wm>	 (03CR) 10Brion VIBBER: "There's a couple oddities in the text field:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/107508 (owner: 10Mhurd)
[23:46:25] <yurik>	 dr0ptp4kt, its ok, i'll fix it later if i find something in it :)
[23:46:26] <brion>	 mhurd: i think it's scrolling inside the text field? seems slightly funky compared to say compose in the email app
[23:46:44] <dr0ptp4kt>	 LOL. i know you will yurik :) it shouldn't have a side effect because it will continue using the old overlay...until the new overlay is renamed from NewOverlay to Overlay
[23:47:37] <mhurd>	 brion: oh i think i see. i have the margin around the text field and perhaps it would look better if it was padding inside?
[23:47:47] <brion>	 hmm maybe
[23:47:53] <violetto>	 kenanwang_: where art thou
[23:48:20] <mhurd>	 brion: ok to tweak that later?
[23:48:24] <brion>	 mhurd: poking at the system email app compose dialog, it looks like there's a big ol' scroll view, and the text field itself doesn't scroll inside
[23:48:28] <brion>	 yeah we can figure that out
[23:48:31] <brion>	 basics seem to work :D
[23:48:38] <mhurd>	 yay!
[23:48:44] <brion>	 mhurd: also i see if it takes a while to load i can actually click into the "loading' message ;)
[23:48:54] <brion>	 might want to replace that with a spinner or somehting
[23:49:01] <mhurd>	 brion: haha yeah
[23:49:53] <mhurd>	 brion: i have to tweak the way messages are shown so i can show errors and such when saving. if it's alright i'll address that then as well
[23:50:01] <brion>	 ok
[23:52:45] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Also needs some error detection, though the failure mode is safe (you can cancel out). These can all be followup fixes." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/107508 (owner: 10Mhurd)