[00:00:05] <greg-g>	 yes yes, I just, for some reason, felt typing out "brandon (black)" was easier than non-tab-completing his irc nick...
[00:00:08] <greg-g>	 go with it
[00:03:25] <jdlrobson>	 kaldari: http://meyerweb.com/eric/tools/css/reset/
[00:05:01] <awjr>	 jdlrobson: kaity you two coming to the VE discussion?
[00:05:04] <kenanwang_>	 jdlrobson: hey you available for the meeting now?
[00:06:54] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "On a tablet if I flick from portrait to landscape, when I go back to portrait the viewport is broken. I haven't quite worked out why.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107519 (owner: 10Kaldari)
[00:14:53] <awjr>	 rmoen: did you just lose video from the office?
[00:15:23] <awjr>	 jdlrobson: head's up i, maybe we, lost video from the office
[00:15:29] <awjr>	 i think rmoen may be frozen
[00:16:14] <awjr>	 all better! and now in hd :)
[00:16:16] <brion>	 mhurd: tfinc: want to try installing the iOS app enterprise-signed build via test flight?
[00:16:25] <mhurd>	 brion: ya!
[00:16:43] <brion>	 mhurd: ok https://www.testflightapp.com/install/ee820b2d209d83848bd39225161885dc-ODg1MTI2MQ/ <- should only let you if i've enabled ya and you're logged in
[00:17:23] <grrrit-wm>	 (03CR) 10Kaldari: Fixing CSS resets for tables in reset.css and hacks.less (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 (owner: 10Kaldari)
[00:17:36] <brion>	 in theory this should let us just sign people up through testflightapp and not have to deal with the device whitelist anymore (as long as it's in-house people)
[00:18:01] <brion>	 i'm just hoping i pushed all the right knobs and buttons :D
[00:19:46] <mhurd>	 brion: WOOHOO!!!! it worked :)
[00:20:01] <brion>	 huzzahhhhhhhh
[00:20:03] <mhurd>	 brion: just ran it on new retina ipad mini
[00:20:53] <brion>	 sweet
[00:21:10] <mhurd>	 brion: thanks! 
[00:21:27] <brion>	 ok i'll push it to a few folks like the designers and we'll set up a new invite group probably later
[00:21:39] <brion>	 this one's kinda labeled under 'wikimedia commons' still which i notice is probably wrong ;)
[00:21:48] <mhurd>	 hehe
[00:29:39] <brion>	 mhurd: ok next build we'll maybe put a proper icon on it and try to get more internal testers :D
[00:30:11] <mhurd>	 brion: ya!
[00:31:09] <brion>	 ok i've got a pile of devices to charge, bbiab
[00:32:44] <grrrit-wm>	 (03PS5) 10Kaldari: Fixing CSS reset for border-spacing. Making table headers bold. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 
[00:37:45] <kaldari>	 jdlrobson: Let me know if this is better: https://gerrit.wikimedia.org/r/#/c/107494/
[00:40:23] <ScrimpyCat>	 Hi I just came across https://github.com/wikimedia/apps-ios-wikipedia and looks pretty good so far (issues I had with the old/original one seem to fixed). I wouldn't mind making some contributions. I saw in the readme it mentioned about pull requests through GH, is the bot active? or is it better for me to register and use Gerrit?
[01:00:04] <Reedy>	 ScrimpyCat: If you can use gerrit, it's probably better
[01:00:54] <ScrimpyCat>	 ok
[01:02:11] <Reedy>	 I can't remember if code review comments are pushed back onto the pull request on github
[01:08:16] <grrrit-wm>	 (03PS1) 10Kaldari: Adding revisions to BeforeSpecialMobileDiffDisplay hook params [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107754 
[01:15:59] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Remove deprecated mozmarket.js call. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/107755 
[01:34:32] <grrrit-wm>	 (03PS1) 10Jdlrobson: Fix broken messages on account creation / login for watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107756 
[01:38:48] <kaldari>	 legoktm: Good idea on the Thanks. I rewrote it with half as much code :) https://gerrit.wikimedia.org/r/#/c/107633
[01:48:40] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Regression: fix hamburger and left menu icon alignment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107625 (owner: 10JGonera)
[01:49:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Regression: fix hamburger and left menu icon alignment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107625 (owner: 10JGonera)
[02:09:27] <grrrit-wm>	 (03PS1) 10Reedy: Add COPYING [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107767 
[02:09:48] <grrrit-wm>	 (03PS1) 10Reedy: Add COPYING [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/107768 
[04:55:46] <zz_YuviPanda>	 hey vbamba
[04:55:52] <zz_YuviPanda>	 around?
[07:16:33] <pcc1>	 jdlrobson: hey, when can i expect to see my stuff deployed on en.wikipedia.org?
[07:17:44] <jdlrobson>	 hey pcc1 can't talk for long but let me summarize quickly now :) so a branch gets cut every thursday so as of tomorrow MediaWiki.org should have sections open by default in settings on alpha
[07:17:53] <jdlrobson>	 then next monday that will be on wikipedia.org
[07:18:24] <jdlrobson>	 i forget when things filter out to other projects exactly but they will do so between those dates
[07:19:21] <jdlrobson>	 hope that helps - will be around tomorrow if you want to get more details. Next step beta! :-)
[07:19:26] <pcc1>	 jdlrobson: cool, thanks
[07:19:49] <jdlrobson>	 goodnight! (or morning depending on where you are!)
[07:22:43] <grrrit-wm>	 (03PS1) 10Yuvipanda: Simplify sections to be not nested [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107808 
[07:39:31] <YuviPanda>	 vbamba: around?
[13:54:27] <grrrit-wm>	 (03CR) 10Theopolisme: "Maybe this would be better displayed on the preview page? (Perhaps above the license text...)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106865 (owner: 10Legoktm)
[17:09:41] <YuviPanda>	 brion: hey!
[17:21:23] <grrrit-wm>	 (03CR) 10Yurik: Add COPYING (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/107768 (owner: 10Reedy)
[17:45:13] <brion>	 mornin
[17:47:30] <YuviPanda>	 ihello brion
[18:03:08] <YuviPanda>	 brion: code review?
[18:09:02] <grrrit-wm>	 (03CR) 10Kaldari: Fixing CSS reset for border-spacing. Making table headers bold. (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 (owner: 10Kaldari)
[18:14:39] <brion>	 moment, been caught up in mp4-land ;)
[18:14:42] <YuviPanda>	 ah
[18:14:47] <YuviPanda>	 hello vbamba
[18:19:03] <grrrit-wm>	 (03PS6) 10Kaldari: Removing CSS reset for border-spacing. Making table headers bold. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107494 
[18:43:34] <grrrit-wm>	 (03PS1) 10Kaldari: Story 1565: Tweak infobox styling for tablet [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107882 
[18:44:30] <grrrit-wm>	 (03Abandoned) 10Kaldari: Story 1565: Improve Infobox styling for tablet on beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107519 (owner: 10Kaldari)
[18:50:08] * YuviPanda  pounces on mhurd

[18:50:14] <mhurd>	 brion: YuviPanda: heya! sry didn't realize irc hadn;'t connected
[18:50:15] <YuviPanda>	 just as a general principle :)
[18:50:20] <mhurd>	 hehe
[18:50:25] <YuviPanda>	 mhurd: hah! 
[18:50:28] <YuviPanda>	 mhurd: what client are you using?
[18:50:38] <mhurd>	 colloquy
[18:51:15] <YuviPanda>	 mhurd: ah, hmm. 
[18:51:20] <YuviPanda>	 mhurd: tried Textual or LimeChat?
[18:51:42] <dr0ptp4kt>	 dfoy, yurik: faidon said he can't make it (too late), and mark is away. brandon accepted. faidon's going to be here next week. i think we should still talk with brandon to get on the same page, and then next week have another discusssion.
[18:51:53] <mhurd>	 YuviPanda: no but i think i'll give them a peek later :)
[18:52:00] <YuviPanda>	 mhurd: please do :)
[18:52:15] <yurik>	 dr0ptp4kt, sounds good
[18:52:44] <mhurd>	 YuviPanda: i got distracted refactoring
[18:53:02] <YuviPanda>	 mhurd: best kinda distracted
[18:53:05] <YuviPanda>	 I spent yesterday doing that too
[18:53:21] <krakjoe>	 evening :)
[18:53:51] <YuviPanda>	 hello krakjoe
[18:53:58] <mhurd>	 YuviPanda: for sure! some was a bit overdue in the ios code base
[18:54:07] <YuviPanda>	 mhurd: oh, I saw a couple of pull requests to the iOS app on github
[18:54:19] <mhurd>	 YuviPanda: commons?
[18:54:27] <YuviPanda>	 mhurd: no, https://github.com/wikimedia/apps-ios-wikipedia/pulls
[18:54:34] <YuviPanda>	 mhurd: do comment there, and let me know if it is ok to merge.
[18:54:38] <YuviPanda>	 I'll migrate them to gerrit and merge
[18:54:52] <YuviPanda>	 if you tell him 'hey now learn this other thing that sucks, unlike gerrit' he'll probably go away :)
[18:55:08] <YuviPanda>	 err
[18:55:11] <YuviPanda>	 unlike github I mean
[18:56:53] <mhurd>	 YuviPanda: whoa! so cool. they look pretty good, but i'll have to test 'em a bit later today :)
[18:57:09] <dr0ptp4kt>	 yurik, what day and time you get here, approx?
[18:57:22] <YuviPanda>	 mhurd: yeah, but can you leave a comment on those saying 'hey, cool! I will test them later today'? :)
[18:57:32] <grrrit-wm>	 (03CR) 10Brion VIBBER: "There seems to be some sort of problem with internal links with non-ASCII chars in them -- they consistently cause crashes for me when I c" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107626 (owner: 10Yuvipanda)
[18:57:32] <mhurd>	 YuviPanda: ya!
[18:58:10] <brion>	 YuviPanda: so we really need better error handling in LeadSectionFetchTask
[18:58:14] <grrrit-wm>	 (03CR) 10Yuvipanda: "Really? They were causing problems for me, and then this patch fixed them. Are you sure this patch is applied? Can you send me a crash rep" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107626 (owner: 10Yuvipanda)
[18:58:21] <brion>	 it seems to crash on me like A LOT
[18:58:39] <brion>	             pageProperties = new PageProperties(Utils.parseMWDate(result.asObject().optJSONObject("mobileview").optString("lastmodified")));
[18:58:41] <brion>	 as always
[18:58:42] <YuviPanda>	 brion: it crashed on me on non ascii internal links, but that patch seems to fix it
[18:58:46] <YuviPanda>	 brion: exactly that line
[18:59:07] <YuviPanda>	 brion: I prefer it crashing on us now so we can isolate those easier and handle it graciously before we release.
[18:59:15] <brion>	 so that line crashing basically means "something somewhere returned a bad response of some kind"
[18:59:24] <brion>	 with no way to actually see what was wrong
[18:59:43] <brion>	 if i could see the returned API result that might help
[18:59:52] <brion>	 lemme try adding a log line
[19:00:43] <YuviPanda>	 brion: there's already a log line in PageViewFragment, line 250
[19:00:49] <YuviPanda>	 i might've added it in a later patch
[19:01:13] <brion>	 yeah thats in the next patch 
[19:01:16] <YuviPanda>	 right
[19:01:21] <YuviPanda>	 should've added it to this one
[19:01:26] <YuviPanda>	 since that is what I used to test
[19:01:34] <yurik>	 dr0ptp4kt, 21-29
[19:01:41] <YuviPanda>	 it told me invalid title because we were sending it without decoding the URL
[19:01:46] <dr0ptp4kt>	 yurik thx
[19:04:20] <brion>	 agh now it's being super flaky... maybe it's just my bad wifi :P
[19:04:33] <YuviPanda>	 brion: heh, office liefi
[19:05:06] <brion>	 well now this is interesting
[19:05:27] <brion>	 YuviPanda: it's crashing inside URLDecoder.decode with a null pointer sexception
[19:05:33] <YuviPanda>	  wat
[19:05:41] <YuviPanda>	 brion: goddamit
[19:05:45] <YuviPanda>	 I know what's wrong there
[19:05:46] <YuviPanda>	 let me fix
[19:05:49] <brion>	 :D
[19:06:07] <dfoy>	 dr0ptp4kt: ok thx
[19:08:04] <awjr>	 anybody know if juliusz's tdd workshop is streaming?
[19:08:12] <awjr>	 i can't join the hangout because it's full
[19:08:22] <grrrit-wm>	 (03PS2) 10Yuvipanda: Simplify sections to be not nested [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107808 
[19:08:22] <YuviPanda>	 brion: there! should be fixed now.
[19:08:24] <grrrit-wm>	 (03PS2) 10Yuvipanda: Handle URLEncoded internal page links properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107626 
[19:08:27] <brion>	 whee
[19:09:47] <awjr>	 tfinc: ^^^
[19:10:03] <tfinc>	 awjr: their working on it
[19:10:07] <awjr>	 thanks tfinc
[19:13:07] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok this fixes when there's no namespace. ;)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107626 (owner: 10Yuvipanda)
[19:16:39] <awjr>	 tfinc: i see the stream, but there is no audio
[19:16:58] <tfinc>	 awjr: message chip and let him know
[19:17:28] <awjr>	 tfinc: i have but he hasn't been responding to me
[19:17:42] <tfinc>	 awjr: i just let him know
[19:17:46] <awjr>	 thnx
[19:19:07] <awjr>	 got it tfinc, thanks for your help