[18:02:33] awjr, I might not make it on time for standup today. If that's the case I'll send notes [18:02:48] ok jgonera, no one else is making it on time either [18:02:51] brion: small aptch? https://gerrit.wikimedia.org/r/108069 [18:03:01] *patch [18:03:02] brion: just qqq [18:03:06] oh... [18:03:21] jgonera: actually they just showed up :) [18:03:54] OK, start without me [18:30:10] kenanwang_: I moved the final translate card back to the next sprint. Looks like the translatewiki codebase has changed a fair bit since I last saw it, so I'll just have to wait for the langeng team [18:42:42] jgonera, where's the mobile edit dashboard? the one on mobile-reportcard.wmflabs.org seems to be stuck in aug 2012 [18:43:02] hello violetto. catch your breath! [18:43:58] dr0ptp4kt, it is http://mobile-reportcard.wmflabs.org/ [18:44:24] dr0ptp4kt, not sure why it doesn't work, Dan was migrating something recently [18:44:27] jgonera_ should i ping him or should someone else? [18:44:59] milimetric, is it possible that the recent changes to limn graphs (OAuth) messed up our graphs? [18:45:37] I wouldn't bet my life that they didn't [18:45:38] but very unlikely [18:45:52] I'm seeing some very weird things going on with wikimetrics though, related to OAuth [18:46:01] so I'm suspecting there's some outages or gremlins somewhere [18:46:14] doesn't help that the latest ubuntu upgrade seems to have hosed my local system too [18:46:25] jgonera_: what issues are you seeing though? [18:46:26] :/ [18:46:58] milimetric, all the graphs are empty for me at http://mobile-reportcard.wmflabs.org/ even though CSVs contain data [18:48:37] looking [18:49:35] yeah, jgonera_, it's a network issue [18:49:44] those csvs are fed through limn as a proxy [18:49:50] dr0ptp4kt, ^ [18:49:54] and right now that's throwing a 502 gateway error [18:50:03] I see [18:50:20] milimetric and jgonera, so just check later, right? [18:50:25] (for my purposes) [18:52:16] yes, let me see hm... [18:52:34] jgonera_: i'll look at this as soon as I figure out why labsdb is not accessible from wikimetrics [18:52:50] thanks milimetric [18:53:45] ok jgonera: drdee to the rescue as usual [18:53:47] there's a tampa outage [18:53:57] people are aware of it, I think it's causing all these problems [18:54:24] dr0ptp4kt, do you need any of the data urgently? [18:55:01] jgonera, nah, just wanted to know if it will be back up eventually. which it sounds like it will. thx! (cc milimetric) [18:56:25] if this is needed before tampa problems are resolved [18:56:25] the easiest way is just to download the CSVs and change the datafile urls in the datasources [18:56:25] (not easy, but easiest) [18:56:25] so download the ones you need to ./datafiles/ [18:56:48] milimetric, I think we can wait, but thanks ;) [18:57:05] k [18:57:21] (and i can do that for you if it's days and days with no solution) [19:00:21] train delayed by medical emergency at civic center [19:04:27] moving again [19:28:05] violetto, you around? [19:34:39] dr0ptp4kt: yeah brb [19:36:50] violetto: alright, hit me up when back [19:48:35] violetto: that was useful! :) [19:55:36] YuviPanda: it really was [19:55:45] dr0ptp4kt: gimme 10 mins! [19:55:50] violetto: yeah. Already fixed one thing (search result). will probably fix 4-5 tonight [19:56:55] YuviPanda: cross things off da list! [19:58:03] violetto: yeah, doing [19:58:10] violetto: okay, I quite like this interaction :) [19:58:26] :)! [19:58:38] violetto: :) [19:59:14] violetto: the trying-to-scroll-hides-keyboard feels very choppy, sadly :( [19:59:54] violetto: I sent you a build [19:59:55] how can we unchoppy it? [20:00:21] violetto: I'm unsure if we can. [20:00:35] violetto: when you get rid of the keyboard, it no longer can scroll, since all elements are visible on screen [20:00:41] so it just resets to start, and that is jarring [20:00:46] hmm [20:00:50] maybe we need some padding [20:00:57] or just return more results ;) [20:01:05] brion: you can't scroll something that isn't there, no? [20:01:14] brion: yeah, I just doubled it. [20:01:25] brion: we were discussing how many results we should show and decided on 12 [20:01:31] before this it was hardly possible to scroll, since we only showed 5 or 7 [20:01:32] err [20:01:33] 6 [20:01:36] yeah [20:01:47] 12 also gives you some headroom on a larger screen device [20:01:53] or if using an external keyboard [20:03:32] brion: yep. YuviPanda brought up the idea of first detecting the device height to decide on the # of results shown but im not sure if that's necessary [20:03:50] brion: can you take a look at https://gerrit.wikimedia.org/r/#/c/65270/? [20:03:56] but then again, some device can be long and probably scrolling won't do anything for them [20:04:03] violetto: yeah. [20:04:32] YuviPanda: and if they can't scroll how do those people get to the bottom of the list or know that thereis additional results if they can't scroll [20:04:41] brion: they *can* scroll? [20:04:43] err [20:04:47] violetto: they can scroll [20:04:56] okay\ [20:04:57] violetto: just that with the keyboard hidden, the entire list of results fits on screen [20:05:03] violetto: so they can't scroll because there's nowhere to scroll to [20:05:28] violetto: check out the build when you have the time :) [20:05:59] YuviPanda: haha yeah, it's like a fake scroll [20:06:05] im playing with it now [20:06:07] ok [20:06:44] yeah it's choppy. could we make the list scroll even though there's nothing more underneath? [20:07:06] even though a large part of the screen will be blank when they scroll [20:07:30] YuviPanda: looks vaguely sensical, i'll set up a local Translate install this weekend, test that, and try to get the iOS strings.plist format also set up [20:07:41] brion: yeah. he also has unit tests [20:07:42] i added myself to reviewers so i won't totally lose it :) [20:07:44] ok [20:07:44] nice [20:08:09] in the meantime, back to API and getting a sane error return value out of the captcha [20:08:18] which seems to be the only holdup remaining \o/ [20:08:32] the actual 'send the captcha info' part doesn't seem to scare them which pleases me [20:08:53] brion: :) [20:09:16] brion, should i create a separate branch to switch all api access to mdot in the android reboot? [20:10:01] YuviPanda: oh what do you think on that issue? dr0ptp4kt 's zero-detection patch adds a thingy to use m. for some stuff, i think it's easier if we just say 'use m. for everything API' [20:10:15] dr0ptp4kt: I agree, why not just use m. for everything? [20:10:16] and use the non-m. URLs for outward-facing links [20:10:18] we don't lose anything [20:10:19] yeah [20:10:21] \o/ [20:10:22] ok [20:10:41] brion: only outward facing thing we have is the share, so we can do things there [20:10:44] yeah [20:10:52] that's easy to regex in the worst case [20:11:04] brion: dr0ptp4kt we can keep the site to have the canonical non m. thing, and have 'getMobileDomain' or something? [20:11:12] or just use [20:11:14] getURLDomain() [20:11:20] and use that when constrocting an API for the site [20:11:37] getCanonical*() ? [20:12:52] brion: sure, either way [20:13:01] brion: we can have the site object produce them for us as is [20:13:11] dr0ptp4kt: I haven't looked at your patch yet, sorry! will do tomorrow [20:36:12] brion + YuviPanda: is https://gerrit.wikimedia.org/r/#/c/108087/ what you had in mind? [20:36:13] dr0ptp4kt: looks about right :D [20:36:13] dr0ptp4kt: yeah! [20:36:13] dr0ptp4kt: I'm wondering if we should just have the site constructor take in en. [20:36:13] dr0ptp4kt: en.wikipedia.org [20:36:13] dr0ptp4kt: and have it internally add the m. [20:36:13] dr0ptp4kt: brion ^ [20:36:13] will make it easier to change in the future [20:36:13] either rway [20:36:13] dr0ptp4kt: can you do that instead? constructor takes 'canonical' domain, but then just mangles it to add m. for everything else? [20:36:14] YuviPanda, yeah, couple minutes [20:36:14] sweet [20:46:38] brion: when u have a sec... no rush [20:46:56] moment [20:47:09] hey mhurd! did you see http://etherpad.wikimedia.org/p/design-thingies-jan-android? [20:48:43] YuviPanda: looks good! [20:48:49] mhurd: :) [21:00:35] brion: think you'll have time to get to about 6 minor patches? [21:01:38] we can hope:D [21:01:52] brion: :D [21:01:59] brion: but yeah, account creation over this [21:36:20] YuviPanda, well, I managed to completely break something pertaining to Parcelable stuff. git reset --hard, here i go again [21:41:26] parcel able scares me, it's all order-dependent [22:03:17] brion, okay, here: https://gerrit.wikimedia.org/r/#/c/108087/2 [22:04:39] violetto, around? [22:04:49] dr0ptp4kt: am! [22:05:04] violetto: where you at? [22:05:52] the other side of 3 [22:07:09] k, here i come [22:07:48] jgonera: ready when you are [22:07:54] jdlrobson: kenanwang_: is https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1522 supposed to be in stable? [22:08:12] awjr: no hence why i posted a patch earlier today [22:08:12] awjr, sorry, forgot to sync the calendar on my phone, argh [22:08:27] awjr, let me just find a place where I won't disturb anyone [22:08:35] jdlrobson: k haven't seen the patch, i just noticed the toc in stable which is why i asked :) [22:08:47] jgonera: i reserved r32 for you :) [22:08:49] https://gerrit.wikimedia.org/r/108074 [22:08:59] just updated it [22:09:19] cool jdlrobson thanks [22:09:53] Awjr it should be in beta why? [22:10:12] kenanwang_: because it's not, at least not in master - but jdlrobson submitted a fix already [22:11:17] It's not in stable? [22:11:22] Is it in beta? [22:20:24] kenanwang_: in master, TOC is showing up in stable [22:20:48] kenanwang_: but jon submitted a patch making it happen in beta [22:27:16] (03PS2) 10Kaldari: More typography updates from Moiz and Kaity (beta only) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107981 [22:27:34] awjr: all of labs got hosed because Tampa went down with a fiber cut [22:27:45] chrismcmahon: that's funny, i was JUST reading that email :p [22:28:19] (03PS3) 10Kaldari: More typography updates from Moiz and Kaity (beta only) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107981 [22:28:33] awjr: also, Zeljko and I are putting together a complaint because of connectivity problems between Cloudbees and Sauce Labs. it's a big world. [22:29:03] (03PS4) 10Kaldari: More typography updates from Moiz and Kaity (beta only) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107981 [22:29:31] awjr: I had 5 MobileFrontend builds in a row fail because of hosting connection issues. I am unhappy. [22:29:39] >_< [22:30:28] awjr: zackly :-) we'll migrate to a WMF Jenkins instance at some point, but that is not short-term, more medium- or possible long-term. In the meantime, support tickets. [22:30:44] :) [22:34:53] (03PS1) 10Jdlrobson: Make sure table of contents re-initialises [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108157 [22:40:04] yurik: ping [22:52:29] (03PS2) 10Jdlrobson: Make sure table of contents re-initialises [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108157 [22:52:47] dr0ptp4kt: Hey Adam [22:53:13] kenanwang_: can you please clarify the problem with the user profile [22:53:22] it's not very clear what you mean by "There is a bug with the borders of the boxes" [22:53:27] dr0ptp4kt: scratch that - no need for immediate response, I'll send email [22:53:44] dfoy, thanks! [22:56:22] (03PS3) 10Dr0ptp4kt: Add basic Wikipedia Zero detection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107992 [23:04:29] Yeah the boxes that go around the contributions. Sometimes there is a weird border between the box and the image inside [23:04:36] Where they should be flush [23:04:52] Thanks awjr [23:09:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks good in general, let's merrrrrrrge" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/108150 (owner: 10Mhurd) [23:13:14] dfoy, what's up? [23:18:30] yurik: on a call - will chat soon [23:18:46] dfoy, okay [23:23:39] kenanwang_: 'flush' ? [23:23:45] kenanwang_: a screenshot would help [23:26:21] K Kaity did you have a screenshot? [23:26:32] If not I'll get one [23:27:16] jdlrobson: its on the mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1581 [23:27:35] https://www.dropbox.com/s/a2lwif43yg5pnkf/Screen%20Shot%202014-01-16%20at%202.10.19%20PM.png [23:27:52] so you mean the image doesn't reach the bottom of the box? yeh that will happen on certain images if they are certain resolutions [23:34:44] kenanwang_: according to the ac of https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1522, toc should default to open, but it appears to default to collapsed - is that expected [23:34:45] ? [23:34:50] (03PS2) 10Jdlrobson: Regression: Don't load button and mainmenu styles twice in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107401 [23:35:22] (03CR) 10Jdlrobson: [C: 032] "Rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107401 (owner: 10Jdlrobson) [23:35:38] (03PS2) 10Jdlrobson: Hygiene: Deprecate view (lowercase) module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107300 [23:35:52] oh nevermind, it apperas open by default in beta after the patch [23:35:55] (03PS2) 10Jdlrobson: Hygiene: Move Section to its own file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107526 [23:36:02] (03Merged) 10jenkins-bot: Regression: Don't load button and mainmenu styles twice in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107401 (owner: 10Jdlrobson) [23:36:10] (03PS4) 10Jdlrobson: Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 [23:36:16] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 (owner: 10Jdlrobson) [23:36:53] (03PS5) 10Jdlrobson: Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 [23:36:55] (03PS6) 10Jdlrobson: Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 [23:36:57] (03CR) 10Awjrichards: [C: 032] Limit Table of Contents to beta/alpha and not on main page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108074 (owner: 10Jdlrobson) [23:36:59] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 (owner: 10Jdlrobson) [23:37:03] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 (owner: 10Jdlrobson) [23:37:40] (03Merged) 10jenkins-bot: Limit Table of Contents to beta/alpha and not on main page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108074 (owner: 10Jdlrobson) [23:39:16] (03PS6) 10Jdlrobson: Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 [23:39:18] (03PS7) 10Jdlrobson: Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 [23:39:46] Awjr I would expect it to be expanded it seems this behavior is inconsistent on mediawiki vs Betalabs [23:50:27] jdlrobson sent you an email with screenshot [23:50:27] See the first box that's says last edited xyz page [23:52:46] (03CR) 10Awjrichards: [C: 032] Make sure table of contents re-initialises [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108157 (owner: 10Jdlrobson) [23:53:23] (03Merged) 10jenkins-bot: Make sure table of contents re-initialises [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108157 (owner: 10Jdlrobson) [23:53:46] (03PS7) 10Awjrichards: Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 (owner: 10Jdlrobson) [23:56:35] jdlrobson: https://gerrit.wikimedia.org/r/#/c/106315/7 looks innocuous, but why the markdown? where are these files expected to be read from? [23:57:36] jgonera: EEEK https://m.mediawiki.org/wiki/Special:MobileMenu [23:58:05] looks related to tablet styling [23:59:36] chrismcmahon: is there any semantic meaning to indentation in feature files for tests, or is it purely for style? eg when you indent the 'And' line after a 'Then' statement?