[08:18:38] (03PS1) 10Theopolisme: Show localized/aliased namespace in edit header [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108489 [08:26:25] I would like to contribute by developing wikimedi Commons app for firefox Marketplace.. i have knowledge about HTML5, CSS, JS how can i start [08:36:56] yuvipanda, hi. [08:37:27] yuvipanda, what /framework/ is there, to avoid me manually using the API? I looked up the things you mentioned, but didn't find their source code. [08:37:53] Or anyone else awake. [08:41:58] gry: the android app http://github.com/wikimedia/apps-android-wikipedia [08:42:06] gry: https://github.com/wikimedia/apps-android-commons the commons app [08:42:17] gry: they are both in Java [08:42:53] yuvipanda: My mobile platform only supports JS. [08:43:26] gry: you could maybe steal code from MobileFrontend https://github.com/wikimedia/mediawiki-extensions-MobileFrontend [08:43:35] it has editing and photo upload and a bunch of other things [08:48:08] gry: is this ffos? [08:48:37] yuvipanda, It is. I would like to present the user a textbox and a list of his recent commons uploads, suggesting that he ticks some of the photos and writes article content. Then this has to be processed into an article. [08:49:00] gry: I see [08:49:14] I think you can steal some code from MobileFrontend, but I don't work on it, sadly [08:49:16] I think some of this can be done using Lua; however, the 'show list of checkboxes and do something when he clicks submit' appears to only be doable using JS. [08:49:36] (03CR) 10Liangent: "Do you want to try to resolve bug 60251 together :p" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108489 (owner: 10Theopolisme) [08:49:44] I don't appear to be spectacularly good with JS. The mobile thing you linked is too large. [08:50:15] it is. [08:50:20] about 50k lines of code in total, I think [08:50:41] It should be possible to script something instead of forking an extension. [08:51:17] should be [08:51:26] gry: in that case I suppose you'll just have to write it from scratch [12:05:31] (03PS1) 10Yuvipanda: Start using browserify for the JavaScript [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108499 [12:42:13] (03PS1) 10Yuvipanda: Add jshint support & fix jshint errors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108500 [12:56:25] (03PS2) 10Yuvipanda: Add jshint support & fix jshint errors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108500 [12:56:27] (03PS1) 10Yuvipanda: Move handleMessage out of bridge into global namespace [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108501 [13:57:57] (03PS1) 10Yuvipanda: Moved link related actions to a separate file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108509 [13:57:59] (03PS1) 10Yuvipanda: Move js files to separate directory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108510 [14:12:52] (03PS1) 10Yuvipanda: Add a 'watch' command to grunt to simplify development [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108511 [14:33:45] (03PS1) 10Yuvipanda: Organize files into js and css directories [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108515 [14:38:23] (03PS2) 10Yuvipanda: Organize files into js and css directories [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108515 [14:38:56] hey jaseemabid :) [14:39:23] yuvipanda: I'm tempted to write a watch task for that gruntfile you just pushed [14:39:34] jaseemabid: https://gerrit.wikimedia.org/r/#/c/108515/ I just did the watch. [14:39:48] jaseemabid: https://gerrit.wikimedia.org/r/#/c/108511/1 is the watch patch [14:40:38] jaseemabid: let me push it to github to make it easier for you to view [14:40:42] gerrit is a poS [14:40:53] gerrit is good enough [14:41:15] jaseemabid: ah, ok! [14:41:18] jaseemabid: you've used it before? [14:41:45] How big is the repo? cloning might be easiest job. [14:41:51] jaseemabid: oh, not too big at all [14:41:53] How big is the repo? cloning might be *the easiest job. [14:41:53] jaseemabid: go for it [14:42:08] * jaseemabid is happy with #magit [14:42:32] jaseemabid: ah, right :) [14:42:42] jaseemabid: clone it? [14:43:14] remote url? [14:43:37] https://git.wikimedia.org/git/apps/android/wikipedia.git [14:43:39] jaseemabid: [14:43:41] https://gerrit.wikimedia.org/r/apps/android/wikipedia [14:43:42] heh [14:43:47] jaseemabid: either works [14:44:14] Done [14:44:47] jaseemabid: https://gerrit.wikimedia.org/r/#/c/108515/ is my latest patch series, so you can check that out [14:44:50] to get all of them [14:45:07] jaseemabid: look for the 'download' thing under 'Patch Set 2'? [14:46:12] Its not on a simple topic branch? [14:46:44] jaseemabid: why do you think I said gerrit is a piece of shit? :) [14:46:48] jaseemabid: no, it's not. [14:47:03] *Amen8 [14:47:05] *Amen* [14:47:24] jaseemabid: :) [14:47:57] jaseemabid: https://www.mediawiki.org/wiki/Gerrit/git-review makes it slightly easier [14:48:38] jaseemabid: comments / CR on the JS also welcome :) [14:48:54] * jaseemabid goes to read the code [14:49:14] jaseemabid: the JS could be a lot better, fwiw :) [14:49:20] I'm splitting it up into modules now [14:49:28] main.js needs to die [14:49:53] require/browserify? Which one did you decide upon? [14:50:29] both are good in its own ways if you ask me. Tempted towards require because its a *pure browser* way [14:50:42] jaseemabid: browserify [14:50:57] jaseemabid: the old app used require. [14:51:02] idk, it felt a bit 'off' for some reason [14:51:08] the explicit wrapping threw me off [14:51:15] I like the implicit wrapping browserify provides me [14:51:31] although it does make it look like I'm peppering the place with globals :D [14:52:48] 1. the wrapping gives me a nice closure. [14:53:28] (03PS1) 10Yuvipanda: Moved section display JS code to its own file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108518 [14:53:31] 2. JSLint will cry if I use any global variable, which is not a required module [14:53:31] jaseemabid: browserify also gives you a nice closure. [14:53:42] jaseemabid: it just isn't explicitl [14:53:53] jaseemabid: this code is also now jshint-passing :) [14:53:54] They do the same thing for 90% cases [14:54:08] jaseemabid: indeed, and I prefer the cleanliness and one-less-indent of browserify [14:54:23] YUI doc is slick, I use that along too when I need docs [14:54:28] oh? [14:54:35] I've never looked at YUI in about... 3 years? [14:54:48] jaseemabid: this code has no jQuery or any external dependency :D [14:55:00] that's also a thing to note, since I didn't know if I really wanted to have require.js or somesuch there [14:55:03] doing it dynamically [14:55:11] https://github.com/jaseemabid/prototype/blob/master/app/scripts/views/_base/tab.js [14:55:54] YUI is an overkill for small projects, and the jQ community grew larger. [14:55:58] jaseemabid: and here too, JS is a very very small part of the app. Most of the UI is in Java, so I don't really need anything [14:56:01] jaseemabid: yeah, pretty much [14:56:01] YUI doc is sweet [14:56:41] jaseemabid: https://doc.wikimedia.org/mediawiki-core/master/js/ is ours [14:56:49] just autogenerated, of course [14:57:04] jaseemabid: there's a bug about it too :) https://bugzilla.wikimedia.org/show_bug.cgi?id=1 [14:57:27] id === 1 ? [14:57:40] jaseemabid: yeah :) [14:58:05] lol [14:58:14] jaseemabid: :D [14:58:24] * jaseemabid 's emacs compilation is taking ages :( [14:58:35] jaseemabid: are you compiling emacs? [14:59:46] I'm with my brother for 2 days and dnt have my machine with me. The mint package is way too old [14:59:49] 23 [15:00:09] jaseemabid: ah! [15:00:26] jaseemabid: I've been trying LightTable for JS for the last couple of days [15:00:32] the Vim plugin needs some tweaking [15:01:15] LT can wait for some more time.. [15:02:06] hehe [15:09:03] grunt file not using vars like allScriptFiles? [15:09:22] in browserify.dist.files [15:09:41] jaseemabid: hmm? [15:10:01] jaseemabid: this is also my first foray into grunt, so I might be doing things suboptimally :) [15:10:09] Define a scripts array and use it everywhere? [15:10:31] jaseemabid: I am doing that [15:10:40] jaseemabid: from commit f11297ac7e2c8504759a6d3d3032cf83db59b9e7 [15:10:56] could probably re-use some more, though [15:12:03] What is the policy on external libraries? [15:12:38] jaseemabid: don't use them unless absolutely required [15:12:44] I don't even have _ included, for example [15:12:51] jaseemabid: this also only targets webkit [15:13:15] Maybe a jquery like zepto. Underscore can clean up a lot of code! [15:13:40] like I almost always use _.each [15:13:42] jaseemabid: why so? I can rely on querySelector* if I want [15:13:48] jaseemabid: you can use .forEach, you know that? [15:13:52] jaseemabid: this is webkit :P [15:14:06] _.each use [].forEach if available [15:14:20] jaseemabid: yeah, but I *know* that [].forEach is available [15:14:23] so why use _.each? [15:14:49] * jaseemabid goes to caniuse.com for querySelectorAll [15:15:14] chrome supported it forever :) [15:15:17] jaseemabid: remember this targets webkit Android 2.3+ only :) [15:15:30] so yeah, I can use querySelectorAll, querySelector [15:15:34] and [].forEach [15:15:38] so why should I use Zepto? [15:15:45] * jaseemabid is having a bliss moment [15:15:50] jaseemabid: :D [15:16:23] jaseemabid: I also don't need to worry about e vs event for event handling, since this is webkit only :D [15:17:25] Need to test this thing. How do i see it in action? README? [15:17:51] jaseemabid: there's a README, but.... [15:17:53] read it? [15:17:55] it's a bit of a pain [15:17:56] to set up [15:18:01] the android bits, that is [15:18:20] jaseemabid: this is why I wanted to build that clojurescript thing, so that people who just want to hack on the JS thing can [15:18:31] then I realized I should re-use a lot of my current JS code [15:18:43] and then I realized the JS is currently disorganized, so organized it :) [15:18:45] So this needs the entire anroid dev env? :( [15:19:01] jaseemabid: sadly, yes. [15:19:10] jaseemabid: well, the JS parts will compile by themselves [15:19:14] but to test, right now, you do need it [15:19:23] bridge.js:6 says caniuse.com for querySelectorAll [15:19:33] jaseemabid: hmm? [15:19:36] I mean // This is called directly from Java [15:19:40] jaseemabid: yup, it is [15:19:46] Realized i need java [15:19:47] :( [15:19:54] Let me get that. [15:20:03] jaseemabid: bridge.js is a 'bridge' between those things [15:20:05] Android and JS [15:20:31] I guess the Bridge is just a message broker? [15:20:51] jaseemabid: pretty much [15:20:55] And uses stuff like window.prompt [15:20:58] yup [15:21:13] send message from Java -> JS ? [15:21:17] jaseemabid: yup [15:21:19] jaseemabid: and vice versa too [15:21:28] so the networking code is all in Java [15:22:01] jaseemabid: 4.5k lines of Java, 200 lines of JS :) [15:23:10] Stuff like `module.exports.sendMessage( "DOMLoaded", {} );` looks like another level of indirection from nowhere to nowhere [15:23:41] Yeah, the JS is readable, can be cleaned up, but i need the entire dev env now. Let me go fix that [15:23:56] jaseemabid: it just lets the Java code do things that need to be done after the DOM is loaded [15:24:10] jaseemabid: messages from java to js get lost if sent before the DOM is loaded, so need to wait [15:24:17] jaseemabid: I definitely need to document it [15:26:48] I wonder how much can browserify browserify. Stuff like EventEmitter (http://nodejs.org/api/events.html) can replace Broker [15:26:56] No code is the best code right? :_ [15:26:58] No code is the best code right? :) [15:31:27] jaseemabid: hehe true [15:31:41] jaseemabid: yeah, but I didn't find anything in EventEmitter that I wanted that wasn't in bridge [15:31:50] less code is better code :P [15:32:01] I'm giving a talk on the same topic at next bangaloreJS [15:32:07] 25th, Marathahalli [15:32:12] ah nice [15:32:15] I won't be in BLR [15:32:16] sadly [15:32:17] grr [15:32:53] Need to make a nice slide and stuff. The thing you mentioned about keeping a good online presence to be a freelancer [15:32:54] :P [15:34:35] jaseemabid: true :D [15:34:37] also blog about it [15:34:40] jaseemabid: brb food [15:35:37] Cool [15:35:52] What is the lightest droid env I can get? [15:35:59] I mean i dont need an ide and stuff [15:36:11] just java and build files so that I can get the app on a droid [16:46:00] (03CR) 10Theopolisme: "@Liangent, replied at Bugzilla. Not sure if that should be done." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108489 (owner: 10Theopolisme) [17:15:10] jaseemabid: sorry, was away for food [17:15:12] still there? [17:17:25] yuvipanda: Just had dinner [17:17:31] jaseemabid: ah [17:17:47] jaseemabid: so theoretically it should work with maven but our build system is broken right now :( [17:18:29] so you sortof need IntelliJ [17:21:23] Ohk [17:21:32] Slow internet, gimme sometime [17:22:09] Miss the 'bangalorean internet' [17:22:31] jaseemabid: heh [17:26:56] Android studio edition of intellij works i suppose? [17:27:49] 480MB :( Wont complete here [17:27:59] jaseemabid: sigh :( [17:28:02] jaseemabid: no, don't use Android Studio [17:28:08] such a piece of shit [17:28:12] jaseemabid: when are you coming back to BLR? [17:28:59] Wednesday. I'd be happy to sit with you a while on this. [17:29:36] without running into drinks in the middle :/ [17:30:52] jaseemabid: hehe :P [17:30:58] jaseemabid: we could do that this time [17:31:17] With pleasure.. I'll learn some cljs by then :) [17:32:14] jaseemabid: :D [17:32:15] jaseemabid: ok [18:59:52] (03PS1) 10Yuvipanda: Start using LESS instead of CSS directly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108536 [19:18:24] (03PS1) 10Theopolisme: Use DISPLAYTITLE when rendering pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108539 [19:19:46] violetto1: hey! [19:28:40] violetto: hey! [19:42:44] (03PS1) 10Yuvipanda: Make CommunicationBridge fully asynchronous [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108541 [19:54:28] yuvipanda: hey! [19:54:46] violetto: good morning! Had a nice weekend? :) [19:55:08] yuvipanda: was nice. :) got back very late last night [19:55:12] how was yours [19:55:24] violetto: more interesting than usual, to say the least :) [19:55:26] not bad [19:55:41] yuvipanda: oh yea? waht happened [19:55:52] violetto: see PM [19:57:15] violetto: did you get the PM?: [20:03:20] yuvipanda: yep [20:11:47] hey violetto [20:12:07] violetto: open sans does have good character coverage [20:12:17] violetto: latin,cyrillic-ext,greek-ext,greek,vietnamese,latin-ext,cyrillic [20:12:47] that's my worry with a lot of fonts [20:13:03] what about ubuntu [20:13:04] violetto: that's a pretty good set of characters, no? [20:13:38] violetto: latin,cyrillic,latin-ext,greek-ext,cyrillic-ext [20:13:46] and greek too [20:13:54] violetto: it's just missing vietnamese [20:14:08] i misread, i thought you said doesn't [20:14:23] can i see how both of them look? [20:14:51] violetto: oh sure [20:15:00] violetto: http://www.google.com/fonts [20:15:09] violetto: type 'Open Sans' in the search field to the left [20:15:13] same with Ubuntu [20:15:30] violetto: then you can preview the fonts at various weights and various texts [20:16:45] i meant in our app [20:17:12] or i can just download the fonts and use them on my mocks up [20:17:15] *mock ups [20:17:59] violetto: I am making a preview of them in the app [20:18:36] yuvipanda: okay [20:18:41] violetto: and yeah, you can download them too if you want. [20:19:07] violetto: you can 'add to collection' in that website, and eventually just 'download collection' [20:19:09] gives you TTF files [20:19:41] mmhm [20:25:04] violetto: https://www.dropbox.com/s/jneob98uv24t9zj/Screenshot_2014-01-21-01-53-32.png [20:25:06] violetto: opensans [20:27:52] violetto: should I try Ubuntu? [20:28:39] yuvipanda: open sans looks the best [20:28:39] and closest to helv neue [20:28:50] violetto: hmm, ok [20:28:52] yuvipanda: i tried ubuntu, not very nice [20:29:22] violetto: should I commit with OpenSans now? [20:29:41] violetto: also, I'm using 'True' bolds and italics - they are separate font faces (OpenSans-Bold, OpenSans-Italic, etc) [20:31:20] violetto: also, see http://www.google.com/fonts/specimen/Open+Sans#pairings [20:31:20] as in, not very fitting with the rest of what we have. can have more line height though, maybe +1/3 of what we have [20:31:20] yeah [20:31:21] that's the way it should be! [20:31:22] the lines where there are subscript and superscript letters are messing up with the line height [20:31:23] can we fix that so it still has the same line height regardless of super/subscripts? [20:31:53] violetto: yeah, but we'll need to figure out what to do with them. [20:31:55] that's a ridiculous advise, PT and Open [20:31:58] violetto: you said you wanted a grey outline, don't you? [20:32:01] barely any difference [20:32:09] grey outline to what [20:32:11] violetto: heh, yeah, even I couldn't spot any [20:32:19] violetto: to the superscripts? [20:32:29] not outline but a grey box [20:32:32] let me show hang on [20:32:33] violetto: we can't really 'fix' them if they are still superscripts, no? They need some space to be at [20:32:44] violetto: if they are above the baseline, they will mess up line height... [20:32:51] violetto: okay, should I commit OpenSans then? [20:34:32] yes to open sans [20:34:55] violetto: alright [20:34:56] but the thing is, there is more than enough height space for the superscripts [20:36:22] violetto: hmm, I think there's a way around it [20:36:22] oh yea remember to increase the line height to more than what it is now to a 1/3 more [20:36:55] violetto: for the body? [20:37:07] [20:37:07] violetto: right now line-height is 24px, font-siz3e is 16px [20:37:14] should I just make it 1.6 of font-size? [20:39:20] yuvipanda: https://www.dropbox.com/s/67ydwew5pzap6ow/Screenshot%202014-01-20%2012.40.22.png [20:39:20] yeah 1.6 [20:39:51] violetto: yeah, we can do that [20:40:07] violetto: https://www.dropbox.com/s/4ikch4kum6i77ga/2014-01-20%2020.39.43.png [20:40:11] 1.6 line height [20:43:09] violetto: and superscripts fixed! https://www.dropbox.com/s/949pm06syv28aqi/2014-01-20%2020.42.42.png [20:45:00] (03PS1) 10Yuvipanda: Use OpenSans WebFont for primary content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108626 [20:45:02] (03PS1) 10Yuvipanda: Fix ^{tags breaking line-flow [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108627
[20:45:06] violetto: there ^ :)
[20:45:19] violetto: so that blue box design - should that happen to just references, or all ^{things?
[20:45:21] hmm
[20:45:30] I think we can make it happen to all ^{things with a opening and closing paren
[20:45:42] violetto: can you tell me what color the blue is?
[20:46:17] * yuvipanda pokes violetto
[20:46:30] yuvipanda: just for references
[20:46:41] violetto: why not for things like [citation needed] too?
[20:47:46] cus they are links and should be the same blue with the normal links in article
[20:47:46] hmmmmmm
[20:47:46] let me try hang on
[20:48:53] violetto: they are also ^{[20:48:54] we can use for citation needed too but im afraid it could get busy. we could certainly try
[20:48:54] ok
[20:49:04] violetto: let me just do for refs now
[20:49:14] citation needed is more like a call for action
[20:49:49] would you try a red dashed line for citation needed
[20:49:58] or any other text CTAs within article
[20:50:29] violetto: hmm, ok.
[20:50:34] violetto: let's do this first. am on it
[20:50:48] violetto: in the meantime, http://etherpad.wikimedia.org/p/design-thingies-jan-android has other design things! :)
[20:53:58] let me take a look at them
[20:54:22] violetto: whee
[20:54:59] yuvipanda: go to bed!
[20:55:03] so late omg
[20:55:06] violetto: I've another 30mins
[20:59:15] violetto: what is the blue color there?
[20:59:18] violetto: and font size?
[20:59:23] violetto: of the reference boxes?
[20:59:36] violetto: and is that a rounded corner?
[20:59:46] 1px rounded corner
[21:00:07] the blue is same as the links which is 0D78EE
[21:00:21] font size is 2px smaller than body copy
[21:00:28] 10px
[21:00:38] violetto: body copy is 16px
[21:00:41] not 12
[21:00:41] px
[21:01:55] right, i didn't bother to update my mock up. so in that case 14px
[21:02:55] violetto: yeah, ok
[21:02:59] violetto: moment
[21:08:21] violetto: hmm, feels distracting https://www.dropbox.com/s/vll654n1wtspoyg/2014-01-20%2021.08.01.png
[21:09:24] violetto: i had a 2px padding on left and right side
[21:09:27] this is 14px
[21:09:35] hang on
[21:09:47] * yuvipanda hangs on
[21:10:22] yuvipanda: can the box not reach all the way to the baseline?
[21:10:34] violetto: oh, yes, it can
[21:10:34] moment
[21:10:43] violetto: you want it to not be superset at all?
[21:10:54] so it'll be 2px all around
[21:11:22] the box?
[21:11:34] violetto: yeah?
[21:11:35] it can be superset if it must
[21:11:45] there's no must, we can have it be whatever we ant
[21:12:25] try box color: CCCCCC
[21:12:29] violetto: https://www.dropbox.com/s/27dykqgdl4hrbr1/2014-01-20%2021.12.07.png
[21:12:31] and the text blue
[21:12:46] violetto: ok
[21:13:34] violetto:
[21:13:35] gah
[21:13:36] violetto: https://www.dropbox.com/s/gpld2wl9ezxjszf/2014-01-20%2021.13.15.png
[21:15:39] oh no i meant the number stays supersetted but the box doesn't touch the baseline
[21:16:03] violetto: oh wait, so the number says supersetted, but the box doesn't touch the baseline *of the number*?
[21:16:03] https://www.dropbox.com/s/7texgrztg1wtblu/Screenshot%202014-01-20%2013.17.25.png
[21:16:06] not of the rpeceeding text
[21:16:07] just like in the screenshot i sent you
[21:16:15] hmm
[21:16:17] * yuvipanda considers
[21:18:06] violetto: is the box square?
[21:18:06] yeah what you have is the box being the same height as the body copy
[21:18:08] always?
[21:18:54] violetto: https://www.dropbox.com/s/lxjxfuz7pjnfy7s/2014-01-20%2021.18.30.png
[21:18:55] see?
[21:18:55] https://www.dropbox.com/s/bn47mo7taoxt6du/Screenshot%202014-01-20%2013.21.39.png
[21:18:55] yuvipanda: it wouldn't be square if the box has more than one letter
[21:18:56] it can become oblong sideways
[21:19:11] so this is taller than wide
[21:19:22] violetto: yeah, this one has proper baseline
[21:19:55] violetto: how does the latest screenshot look?
[21:20:05] it still feels a little off to me from your design
[21:20:06] https://www.dropbox.com/s/xypjjt1v44pcpb1/Screenshot%202014-01-20%2013.23.18.png
[21:20:17] yeah look at the screenshot
[21:20:27] * yuvipanda considers
[21:20:28] maybe that helps with what im trying to say
[21:20:39] yeah
[21:20:40] i do
[21:20:42] it does
[21:22:59] violetto: https://www.dropbox.com/s/85c6clmwhg0fj9e/2014-01-20%2021.22.37.png
[21:23:23] it's close! what's the padding around it now?
[21:23:35] violetto: zoomed in view https://www.dropbox.com/s/dkmer3k1kz1uk7k/2014-01-20%2021.23.14.png
[21:23:40] violetto: 4px on left and 4px on right
[21:24:21] violetto: also, see the reference 13 here https://www.dropbox.com/s/gcz5ull5te774d6/2014-01-20%2021.23.55.png
[21:24:27] looks super weird if we don't apply styles to the other ones
[21:25:36] try only 2px of padding all around
[21:26:17] violetto: that was what I first had :P
[21:26:20] but let me try again
[21:28:10] i haven't looked at this in lengths but this is along the lines of what im thinking https://www.dropbox.com/s/s6jrlts3ismee5d/Screenshot%202014-01-20%2013.30.40.png
[21:28:14] violetto: https://www.dropbox.com/s/6dgmxuxss2iw9ry/2014-01-20%2021.27.51.png
[21:28:30] violetto: yeah, that looks good
[21:28:41] violetto: I'll get to that once we finish with this
[21:28:54] looking so much better!
[21:29:00] the bottom is also 2px? it looks larger
[21:29:23] violetto: hmm, so top and bottom there's no padding specified
[21:29:25] so should be zero
[21:29:30] I think that's just residual line-height effects
[21:29:32] let me verify
[21:29:37] violetto: do you want it to be 2px?
[21:29:46] gn yuvipanda
[21:29:59] when there are multiple numbers, can the box become longer sideways rather than creating one box for every number?
[21:30:03] yuvipanda: it'll look super polish if we could
[21:30:17] violetto: 'longer sideways' as in?
[21:36:16] violetto: making the top and bottom padding exactly 2px seems beyond me atm. I'll wait for our CSS wizards to come to work tomorrow
[21:36:19] I'll note it down, howevertt
[21:39:30] hey violetto!
[21:39:33] (03PS2) 10Yuvipanda: Make reference tags prettier [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108627
[21:39:33] did you get my messages here?
[21:39:46] yuvipanda: i just realized i got dc
[21:39:52] violetto: heh
[21:40:01] 03:00 violetto: yuvipanda: it'll look super polish if we could
[21:40:02] 03:00 yuvipanda: violetto: 'longer sideways' as in?
[21:40:02] 03:06 yuvipanda: violetto: making the top and bottom padding exactly 2px seems beyond me atm. I'll wait for our CSS wizards to come to work tomorrow
[21:40:03] last message here is my dropbox link
[21:40:03] 03:06 yuvipanda: I'll note it down, howevertt
[21:40:06] violetto: ^
[21:40:13] that's the last one that I got
[21:40:26] https://www.dropbox.com/s/az9g2ipxvqcnhtn/Screenshot%202014-01-20%2013.35.50.png
[21:40:31] i sent you this
[21:40:43] ah, hmm
[21:40:45] looking
[21:40:49] take this not that
[21:40:50] https://www.dropbox.com/s/llfk0tz7b24d6ma/Screenshot%202014-01-20%2013.37.14.png
[21:41:03] right, right
[21:41:54] violetto: hmm, yeah, should be doable
[21:42:01] ok go to bed
[21:42:04] violetto: https://www.dropbox.com/s/s4dlkhj0800afxp/2014-01-20%2021.38.26.png is what I have now
[21:42:07] I pushed it out
[21:42:08] i need to run some errands too
[21:42:12] violetto: I'm going to email you a build
[21:42:14] and then go to bed
[21:42:15] ok?
[21:42:18] ok!
[21:42:32] thank you!
[21:45:07] violetto: sent
[21:45:09] violetto: I'm off now
[21:45:12] you too!
[21:45:26] okay i'll check it out when i get back
[21:45:29] nite nite
[23:11:33] damn that's a lot of yuvi patches
[23:43:32] (03CR) 10Brion VIBBER: [C: 032 V: 032] Increase default search count to 12 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108077 (owner: 10Yuvipanda)
[23:56:52] (03CR) 10Brion VIBBER: [C: 032 V: 032] Switch section headers to sans-serif. Also specify sizes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108080 (owner: 10Yuvipanda)
[23:57:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] Minor modification to body background [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/108081 (owner: 10Yuvipanda)}}}}