[00:04:20] Dartar I filled in for web and apps [00:04:37] kenanwang_: awesome, taking a look [00:06:03] kenanwang_: is tfinc in a best position to fill in the section? [00:06:12] the *zero* section, that is [00:49:44] kaldari, Emily is asking about your coding task [00:50:08] ? [00:50:12] kaldari, she says you reverted your changes to the task [00:50:32] yes, per her comments about it taking too long [00:50:35] and she's not sure if she should say that the candidate should pay special attention to security or not [00:50:49] so we basically have the same task as before? [00:51:30] yes, same as before [00:51:38] so should she say something? [00:51:43] that's her question [00:51:51] she should not tell the candidate to pay special attention to security [00:52:02] ok [00:52:13] that's up to the candidate's judgement [00:53:08] Is she on IRC? [01:06:08] DarTar, https://gerrit.wikimedia.org/r/#/admin/projects/analytics/limn-mobile-data <- scripts that generate mobile limn data [01:06:27] danke! [01:07:23] cloned [01:20:19] violetto, around? [01:24:37] dr0ptp4kt: yea! [01:25:08] violetto: wanna drop by for the color toggle thing? [01:30:31] dr0ptp4kt: be right over [01:30:41] violetto: k [01:45:25] (03PS1) 10JGonera: Hygiene: Add proper error reporting in lead image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109264 [06:57:16] tfinc: http://www.tokyotimes.com/2014/kitkat-opens-first-store-promotes-unique-flavors/?utm_source=rss&utm_medium=rss&utm_campaign=kitkat-opens-first-store-promotes-unique-flavors [06:57:52] Reedy: i plan to visit it when i'm in Japan in March [06:58:32] :D [11:13:44] (03PS1) 10Yuvipanda: Remove superfluous files in assets dir [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109290 [12:43:44] (03PS1) 10Yuvipanda: Start using an object hierarchy to deal with Edit Results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109292 [13:01:12] (03PS1) 10Yuvipanda: Add a CaptchaEditResult with data about the Captcha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109293 [13:36:47] (03CR) 10Theopolisme: [WIP] Allow users to adjust the font size (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 (owner: 10Theopolisme) [15:41:34] (03PS11) 10Jhall: QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [15:48:42] (03PS12) 10Jhall: QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [16:44:24] dr0ptp4kt: around? [16:47:22] yuvipanda, si. [16:47:30] dr0ptp4kt: morning! [16:47:40] dr0ptp4kt: is the root cron on puppet? [16:47:56] dr0ptp4kt: also why cron? You can just make puppet update it with the apt module [16:48:02] yuvipanda: morning back at you! the root cron job is /not/ on puppet. i had just edited it manually previously, sudo crontab -e [16:48:03] and puppet runs once every 30min anyway [16:48:13] dr0ptp4kt: right. Put it on puppet? [16:48:16] dr0ptp4kt: let me find examples... [16:48:33] yuvipanda: thx [16:49:07] dr0ptp4kt: manifests/gerrit.pp has some nice cron definitions to look at [16:49:17] dr0ptp4kt: so just create a role for your labs machines and have these? [16:49:47] dr0ptp4kt: plus, I'm not sure you really need to have that cron at all :P [16:49:55] yuvipanda: btw, i'm planning to use SharedPreferences for wifi state changes. i realized i can't make otto's bus post data survive such that onresume will pick up the event. i still plan to use bus post because when the app is active it's nice to be notified that way. but i gotta make onresume work consistently to update the chrome. [16:50:18] yuvipanda: "Yuvi said I don't need security!" ;) [16:50:35] dr0ptp4kt: you should always assume that only one activity is active. So can't use bus for anything that crosses activity boundaries [16:50:42] so that applies to services too [16:50:46] and broadcast receivers [16:51:00] dr0ptp4kt: there's a setting in developer options that enforces this. Using that catches a lot of bugs :D [16:51:13] dr0ptp4kt: what exactly do you mean by 'use SharedPreferences for wifi state changes'? [16:51:37] yuvipanda: yeah, i forgot about that :) you got a few minutes to talk on hangout video? [16:52:06] dr0ptp4kt: sure! let me find my headphones, give me a moment [16:53:29] dr0ptp4kt: calling you [16:54:55] dr0ptp4kt: I can hear you [17:02:22] dr0ptp4kt: http://developer.android.com/guide/topics/resources/style-resource.html [17:02:50] dr0ptp4kt: http://developer.android.com/guide/topics/ui/themes.html [18:01:14] (03PS9) 10Jdlrobson: Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 [18:02:43] (03PS3) 10Jdlrobson: Use CSS parameter to include generated CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108886 (owner: 10Mattflaschen) [18:02:48] (03CR) 10Jdlrobson: [C: 032] Tools: Use CSS parameter to include generated CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108886 (owner: 10Mattflaschen) [18:03:34] (03PS5) 10Jdlrobson: Hygiene: Move Section to its own file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107526 [18:03:37] Jdlrobson, can yoi set up the standup in the office? [18:03:48] (03Merged) 10jenkins-bot: Tools: Use CSS parameter to include generated CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108886 (owner: 10Mattflaschen) [18:04:20] (03PS2) 10Jdlrobson: Make header title in issues and talk overlays bold [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107728 (owner: 10JGonera) [18:07:04] (03PS8) 10Jdlrobson: Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 [18:08:24] Jdlrobson? [18:10:53] dr0ptp4kt: that was productive :) [18:10:56] do write out the email though [18:10:57] hi mhurd [18:11:04] yuvipanda: heya! [18:11:17] I seem to have recovered sufficiently :) [18:11:20] mhurd: how's it going? [18:11:30] yuvipanda: glad you're feeling better! [18:11:38] mhurd: heh, me too! [18:12:03] yuvipanda: i got stuck on the lang links story (gah!). it's done as of now :) [18:12:23] (pending review of course) [18:12:40] mhurd: ah, n ice [18:12:54] mhurd: I've a number of commits for captcha done. [18:12:58] need to finish up [18:14:42] (03PS1) 10Mhurd: Added "Read in another language" link at bottom of TOC. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/109318 [18:15:21] jgonera_: you there? no one was in the office but we also couldn't connect on the chrome box [18:15:24] did anyone join? [18:16:20] Kenanwang_ nope. I've just sent an email to mobile-tech [18:16:26] ok [18:19:09] (03PS1) 10Jdlrobson: Hygiene: Don't use content_wrapper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109319 [18:20:44] yuvipanda, will do. always a pleasure working with you. [18:32:11] (03CR) 10Jdlrobson: [C: 032] Make header title in issues and talk overlays bold [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107728 (owner: 10JGonera) [18:32:13] dr0ptp4kt: likewise :D [18:32:16] dr0ptp4kt: sorry was in standup [18:32:44] hey mhurd [18:32:47] (03Merged) 10jenkins-bot: Make header title in issues and talk overlays bold [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107728 (owner: 10JGonera) [18:32:59] yuvipanda: ya! [18:33:15] mhurd: heh, I thought that was May from just the voice. [18:33:45] yuvipanda: hehe [18:34:08] mhurd: also, the captcha image can sometimes be too small, so you might have to scale it up to be a certain size [18:35:19] yuvipanda: ah. i'm guessing the easiest way to present it is as a modal view with just the image, text box and submit button? [18:35:27] yuvipanda: i was thinking, "i just talked to that guy on the standup". so at start screen: if (W0 response header present) => we would need to check the 'zeroconfig' API to get the appropriate banner message for the user. i wonder if for the sake of expediency we hit both the start screen api and the zeroconfig api. nothing else about the state graph would change in that case, it would just allow for a slightly faster toast instead of having [18:35:27] sequence the calls; the downside would be one small extra check; given that would be the last time it would check for 90% of users, i wonder if there's no harm done. what do you think? [18:35:41] mhurd: May actually did designs. it's on the card [18:35:53] yuvipanda: ah! great! [18:36:18] dr0ptp4kt: thinking... [18:36:26] dr0ptp4kt: how many of these messages would be there? [18:36:29] like, how many variants? [18:36:43] dr0ptp4kt: I'm wondering if we can just package these in the app, and have them update once a week or something [18:36:52] dr0ptp4kt: we will already be doing that for some config variables, JS and CSS [18:37:14] yuvipanda, there's one vesion per language per carrier. would the app have an inbuilt mechanism to get the messages? [18:37:35] yuvipanda: ideally we avoid the need to have app updates every time messages change [18:37:49] brion: heya! got a commit for the language links and bug fixes (https://gerrit.wikimedia.org/r/109318) i know you're busy today, so no rush :) [18:37:50] "app updates" meaning google play-based downloads [18:37:52] dr0ptp4kt: can you give me an approximate size of how big the entire blob will be, per message? [18:37:58] dr0ptp4kt: yeah, we will have another way [18:38:07] dr0ptp4kt: we don't want style changes dependent on app updates either [18:38:15] dr0ptp4kt: and we also want to have a 'kill switch' for things like anon editing [18:38:16] and such [18:38:23] so we can turn them off without updates [18:38:28] dr0ptp4kt: so the app definitely needs to have such a thing [18:38:36] yuvipanda: small, the entirety of the json would be {enabled: "true", banner: "Free access by Yuvitel"} [18:38:54] dr0ptp4kt: gah, I meant 'per language' [18:38:55] yuvipanda: the false case would just be {enabled: "false"}. [18:38:56] not per carrier [18:39:55] yuvipanda: The "Free access by Yuvitel" is sometimes a word or five longer, but not much more [18:40:14] b/c it needs to be short for the normal mdot and zerodot experience [18:40:36] yuvipanda: one thing's for sure, we wouldn't want to return that value in every api response [18:40:42] dr0ptp4kt: agreed on that [18:40:47] yuvipanda: pitch forks [18:40:51] dr0ptp4kt: how many carriers are there? [18:41:01] approximately [18:41:12] yuvipanda: i think it's around 25-30 right now. eventually it will be 200-300 probably [18:41:19] let's assume 200 [18:41:26] at what, 20 bytes each? [18:41:32] on average? [18:41:42] hmm, no [18:41:44] yuvipanda: sure, with i suppose 10-15 langs per carrier [18:41:46] let's say 60 bytes each [18:42:03] dr0ptp4kt: no, we'll re-download when the user changes UI language. Not a very common occurance [18:42:19] dr0ptp4kt: that's about 12KB [18:42:21] I think [18:42:41] dr0ptp4kt: now let's say we update that about once every month or so [18:42:49] dr0ptp4kt: without requiring an app update [18:42:51] how does that sound? [18:44:03] yuvipanda: are you talking about obtaining carriers (200) * langs (10 to 15, let's say) * 60 bytes each month? [18:44:38] dr0ptp4kt: no, just carriers (200) * 60 bytes each month. [18:44:52] dr0ptp4kt: if user changes user lang, then that's one request extra for each language change [18:44:59] yuvipanda: in other words, just getting the messages for the currently set language? [18:45:03] dr0ptp4kt: yeah [18:45:14] dr0ptp4kt: and when we ship, we will ship with current data [18:45:18] yuvipanda: is that the thought for the other parts of the app? [18:45:26] dr0ptp4kt: yeah, we are going to do that for CSS and JS [18:45:28] (i.e., getting messages for that lang) [18:45:34] yuvipanda: okay, i get it [18:45:41] dr0ptp4kt: no, not for messages. but for parts that can change dynamically [18:45:43] CSS, JS [18:45:49] and 'kill switches' [18:45:57] well, things that change dynamically, but not too often [18:47:24] yuvipanda: that works for me, too. that will let us avoid one extra api hit at app launch per app session, which is cool. i guess on the very first app launch the banners blobs all need to be pulled. but i guess that was an assumption with the other dynamic things anyway, so it's assumed to be a single batched call [18:47:45] dr0ptp4kt: we will ship a copy with the app itself, so it won't need to pull on first launch [18:47:52] dr0ptp4kt: it'll just update once a month [18:48:09] yuvipanda: the only thing is if a carrier wants to change the verbiage it won't reflect, which isn't ideal... [18:48:20] yuvipanda: in practice that doesn't turn out to happen too much. [18:48:27] dr0ptp4kt: it won't reflect for a few weeks, yeah. [18:50:45] (03PS13) 10Cmcmahon: WIP QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [18:52:54] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx) [18:53:23] (03PS8) 10Jdlrobson: Add an ability to change the copyright warning in editor and uploader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx) [18:54:23] (03CR) 10jenkins-bot: [V: 04-1] Add an ability to change the copyright warning in editor and uploader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx) [18:57:17] yuvipanda: lemme check if a (potentially) month delay is gonna be acceptable; my guess is no. on the web getting the banner changes to update within 15 minutes was an important goal that was fulfilled, so this would be a downgrade for the behavior. to be clear, i'm not opposed to doing the checks in serial whenever a response state implies NOT_ON_ZERO_CHANGED_TO_ON_ZERO; it's just a question of whether that would cause a problem for user [18:57:18] psychology. I mean, the extra second or whatever for doing it serially may not matter all that much in the grand scheme of things. once it's on, the user would be getting stuff for free anyway...it's just a question of whether by not showing it within concurrent with the start screen (i.e., waiting a second) the user would be scared away if the carrier had advertised the service as free...i doubt it. maybe that extra second would allow the us [18:57:18] enough time to get his bearings for the start screen, and the toast would thus be less jarring and more impactful. [18:57:35] yuvipanda: alternatively, instead of me checking, we can just do it serially :) [18:58:07] dr0ptp4kt: sure, we could just do it serially :D [18:58:19] dr0ptp4kt: if it is that fast and also cached, shouldn't take much time [18:58:24] s/fast/small [18:58:24] yuvipanda: you convinced me. lol [18:58:25] (03CR) 10Jdlrobson: [C: 04-1] Add an ability to change the copyright warning in editor and uploader (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx) [18:58:53] dr0ptp4kt: :P [18:59:46] dr0ptp4kt: one of my favorite things to do to code is to take a profiler to it and kick out slow parts. That logically means that I also like removing I/O wherever possible... [19:00:38] yuvipanda: waiting for you on the hangout [19:00:46] tfinc: damn, forgot. [19:00:47] on it [19:00:54] yuvipanda: your conclusion is sound based on the premise. i/o is not only slow, but sometimes buggy. [19:01:11] dr0ptp4kt: yup! [19:01:39] dr0ptp4kt: best code is code that doesn't exist. fastest IO is IO that needn't happen :D [19:01:52] tfinc: trying to connect, it doesn't let me in. [19:04:45] (03CR) 10Jdlrobson: [C: 04-1] "Marking as -1 simply as it is a WIP and I need to push this out my queue." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [19:07:06] wow .. gmail is hard down [19:17:37] (03CR) 10Jdlrobson: Use DISPLAYTITLE when rendering pages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108539 (owner: 10Theopolisme) [19:19:10] (03CR) 10Jdlrobson: [C: 031] "Just need to test" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109012 (owner: 10Kaldari) [19:41:32] (03CR) 10Siebrand: [C: 031] "i18n/L10 reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx) [19:47:27] hey violetto [19:47:44] violetto: http://etherpad.wikimedia.org/p/page-styling-zurich [19:47:53] violetto: do you see it? [19:48:08] mhurd: btw, you need to get StevenW on the iOS beta program [19:48:11] he's asked me thrice so far [19:48:13] or twice [19:50:56] yuvipanda: yep [19:51:05] violetto: ok, see the etherpad [19:51:57] violetto: want to hang out for a few minutes to talk about it first before writing? [19:52:07] yuvipanda: hang on tlaking to kenan for a bit [19:52:13] violetto: ok [19:52:15] violetto: ping when done [19:52:19] yuvipanda: ok! [20:03:00] yuvipanda: looking at ether [20:03:06] violetto: hangout? [20:03:27] violetto: I'm inviting [20:04:28] ok [20:04:41] violetto: I invited [20:04:54] violetto: https://plus.google.com/hangouts/_/72cpikli9a3lhlnl3ltf2nsq1s if gmail isn't working still [20:05:14] violetto: https://www.mediawiki.org/wiki/Amsterdam_Hackathon_2013#Interface_design_solutions_for_5_problems_in_one_hour [20:06:04] yuvipanda: now that we have enterprise dev setup, we *finally* can :) [20:06:26] mhurd: can you set him up? StevenW should be in the office [20:06:47] yuvipanda: brion can with his acct [20:07:00] I am actually at the arch summit right now. But brion is here too. [20:07:09] StevenW: yay! [20:08:50] StevenW: things are very much in flux on the ios builds - lots of refinements on the way :) [20:10:04] (03CR) 10Jdlrobson: [C: 031] "Just need to test this out" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109022 (owner: 10Kaldari) [20:13:39] (03CR) 10Jdlrobson: "We need tests that editing a page actually works so I actually want to write more tests like this which tests "editing a garbage page"." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [20:22:59] YuviPanda, like you said, running a unit test without android.test imports under the run > android test context worked just fine. magic. [20:23:06] dr0ptp4kt: :D [20:23:11] dr0ptp4kt: wheee! :) [20:23:12] aka inheritance, methinks [20:23:24] dr0ptp4kt: I think it uses a different Test runner [20:23:32] dr0ptp4kt: if you run it as JUnit it tries to run it on your laptop [20:23:41] while if you run it with the Android test runner it runs it on the phone [20:23:48] the former might work, but might not either [20:25:27] yuvipanda: yeah, saw that (the test runner class) and got ya on seemingly quantum behavior :) [20:25:36] :D [20:29:41] 01[13WikipediaMobile01] 15siebrand pushed 1 new commit to 06master: 02http://git.io/X-DG-g [20:29:41] 13WikipediaMobile/06master 14a28dbb0 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [20:49:21] (03PS2) 10Jdlrobson: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 [20:49:28] (03CR) 10jenkins-bot: [V: 04-1] QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [20:52:48] (03PS3) 10Jdlrobson: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 [21:11:07] (03PS14) 10Jhall: WIP QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [21:12:30] mhurd: heh updated project file requires Xcode 5.1 beta ;) [21:13:21] brion: ah! oh also fixing ios6 bug now. will amend soon [21:13:30] ok [21:16:43] brion: Picasso has a bug that prevents it from loading some specifically formatted PNG files. [21:16:48] brion: our captcha files fit that description :( [21:16:53] https://github.com/square/picasso/issues/249#issuecomment-33259920 [21:17:05] hah nice [21:17:23] chrismcmahon: have we written any tests for VE yet? [21:17:31] I'm not sure how to send key presses to a content editable div.. [21:17:40] yuvipanda: sure that's not just that picasso isn't using your session cookie? [21:17:48] brion: wait, waht? [21:17:51] brion: err [21:17:51] brion: also [21:17:55] brion: it works if I don't try to resize it [21:18:00] you can't share the urls [21:18:02] brion: it only doesn't work when I try to resize it to fit it [21:18:08] mmmmmm weird [21:18:10] brion: sure you can. I can curl it and get images [21:18:23] brion: try curl 'test.wikipedia.org/w/index.php?title=Special:Captcha/image&wpCaptchaId=799537085' [21:18:27] well that seems..... wrong [21:18:44] by design it's supposed to return only if you're on the same session [21:18:50] brion: I... see [21:18:54] so that's.... odd [21:18:55] brion: unrelated bug, this one [21:18:55] :D [21:19:10] brion: heh, yeah. [21:19:20] jdlrobson: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/tree/master/modules/ve-mw/test/browser/features [21:19:43] brion: either way, the issue here is Picasso [21:19:54] since it is just any form of .resize that's causing the problem [21:19:54] :( [21:19:56] works otherwise [21:20:02] chrismcmahon: looks perfect - taking a look :) [21:20:05] weird [21:20:15] also if you wanted to talk about the editing tests feel free [21:20:22] yuvipanda: any reason you're resizing it? [21:20:30] brion: it's too small by default [21:20:40] brion: because 1px != 1dp [21:20:42] ...make the view larger? [21:20:58] brion: yeah, so you make the view larger and then call .fit() to resize the image too [21:21:02] let me try another way [21:21:04] ah i see [21:21:15] so that doesn't create a scaled image and save it, that just sets the display options? [21:21:52] brion: I'm trying the display options now [21:22:31] hmm doesn't seem to work [21:22:58] 'Transform images to better fit into layouts and to reduce memory size.' hmm [21:23:17] needs better docs [21:23:23] they're so vague :) [21:23:41] anyway doesn't ImageView have options to determine how big it shows the image? [21:23:44] i'd be using those [21:23:50] brion: yeah, scaleType [21:23:54] brion: i just tried that. [21:23:58] doesn't seem to work for images smaller [21:24:01] than the size of the imageview [21:24:02] grr [21:24:22] scaleType CENTER_INSIDE ? [21:24:58] brion: ah, hmm [21:25:05] brion: I tried fit_CENTER [21:25:27] brion: I did have some patches up, with tests and succh [21:25:40] ok i'll look at em in a bit [21:25:44] been craaaaaazy here :D [21:25:53] brion: heh, I could see [21:32:19] (03CR) 10Brion VIBBER: "I'll have to download the latest xcode 5.1 beta for this, will test later :)" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/109318 (owner: 10Mhurd) [21:38:55] brion: ping? [21:39:05] brion: StevenW wanted to get on the iOS beta ;) [21:39:16] StevenW: brion's account has the superpowers, so you just need to corner him for a few minutes [21:39:20] ok lemme invite him [21:39:56] brion: whee! [21:40:05] brion: also first successful edit that required a Captcha: http://test.wikipedia.org/w/index.php?title=Humphrey_Tonkin&curid=58504&diff=192959&oldid=180516 [21:40:07] \o/ [21:40:37] now to sleep. for real [21:40:38] night [21:40:42] woooo [21:41:23] yuvipanda: ok sent [21:41:29] brion: woo, sweet :) [21:42:01] ah he has to sign up before i can whitelist him i think [21:42:04] we'll figure it out :D [21:42:13] sign up for? [21:44:27] StevenW: testflight, perhaps? brion [21:44:42] StevenW: test flight. should be a mail in your inbox [21:44:50] thx [21:44:55] once you're signed up i can add you to the permissions list and you can install through there [21:45:29] done [21:45:44] brion: https://www.dropbox.com/s/jdt3tz92ztr75p1/2014-01-24%2021.41.57.png is how it looks like now [21:45:48] seems ok other than the small size [21:45:51] of the captcha [21:45:55] yuvipanda: awesome. [21:46:05] if you can't figure out the sizing put it in gerrit and i'll poke it tomorrow [21:48:27] brion: yeah, ok [21:48:34] brion: I still need to figure out more state stuff [21:48:37] ok [21:48:51] brion: also, http://www.androiddesignpatterns.com/2013/04/retaining-objects-across-config-changes.html sounds like a good idea [21:48:57] perhapsa too late for us, idk [21:49:04] but sounds like a solution to the state management stuff [21:49:05] let's see [21:49:42] brion: ok, off for real now [21:49:48] nighty night :D [21:52:11] StevenW: ok you should have a mail with an install link now, open it on device [21:52:14] and it should work :D [21:53:04] chrismcmahon: how do i do on(ArticlePage).wait_until do [21:53:04] on(ArticlePage).submit_button_element.enabled [21:53:05] end [22:01:24] brion: it's alive! [22:01:31] woohooooo [22:01:34] many thanks [22:09:15] You guys planning a Windows Phone 8 app at any point? [22:13:08] (03CR) 10JGonera: [C: 04-1] "This completely breaks header titles on every special page." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109319 (owner: 10Jdlrobson) [22:15:00] Krenair: phone? not currently. i might play with it in my research time some day but no firm plans [22:15:10] Krenair: there's a couple apps out there for reading which are ok [22:15:31] unfortunately we can't just port the windows 8 tablet app, they're not quite compatible techs [22:15:37] (03CR) 10JGonera: [C: 032] Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 (owner: 10Jdlrobson) [22:16:22] (03Merged) 10jenkins-bot: Hygiene: Make KSS output to docs directory [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107397 (owner: 10Jdlrobson) [22:18:07] ok, thanks brion [22:19:44] (03CR) 10Jdlrobson: [C: 04-1] "Refactoring this as we speak" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108990 (owner: 10Jdlrobson) [22:19:50] (03CR) 10Jdlrobson: [C: 04-1] "Refactoring this as we speak" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [22:20:50] (03CR) 10JGonera: [C: 032] Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 (owner: 10Jdlrobson) [22:21:27] (03Merged) 10jenkins-bot: Hygiene: Change how we manage importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106843 (owner: 10Jdlrobson) [22:45:11] (03CR) 10JGonera: [C: 032] Hygiene: Share onSave code between VE and wikitext editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108989 (owner: 10Jdlrobson) [22:45:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Share onSave code between VE and wikitext editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108989 (owner: 10Jdlrobson) [22:49:29] (03CR) 10JGonera: [C: 04-1] "I still see many of the issues I mentioned in patchset 10. If we want this code to be used in future, let's fix them. If not, let's mark t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [22:50:13] (03PS15) 10Jhall: WIP QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [22:50:37] (03PS2) 10Jdlrobson: Hygiene: Share onSave code between VE and wikitext editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108989 [22:50:54] (03CR) 10Jdlrobson: [C: 032] "Rebased to deal with change from EditorNew to Editor" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108989 (owner: 10Jdlrobson) [22:51:58] (03Merged) 10jenkins-bot: Hygiene: Share onSave code between VE and wikitext editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108989 (owner: 10Jdlrobson) [22:53:20] (03CR) 10JGonera: [C: 032] Hygiene: Move Section to its own file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107526 (owner: 10Jdlrobson) [22:53:43] thanks jgonera [22:54:02] jgonera: I saw your latest comments on this Gerrit id: https://gerrit.wikimedia.org/r/#/c/106548/ [22:54:02] (03Merged) 10jenkins-bot: Hygiene: Move Section to its own file. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107526 (owner: 10Jdlrobson) [22:54:24] sure jdlrobson, I admit I didn't do much CR in the last few days [22:54:27] jgonera: If you're amenable, I'd like to scheudle a hangout for sometime next week so that you and I can review your comments together [22:55:23] JeffHall, sure. what timezone are you in? [22:56:14] jgonera: Mostly in Pacific time zone, so I'll target San Fran office hours - will see if I can grab a slot on your schedule next week. Any day you prefer? [22:57:08] JeffHall, Monday afternoon? [22:57:23] jgonera: OK, will do - thanks! [22:57:29] JeffHall, just to be sure, you're not based in SF? ;) [22:57:59] jgonera: Not for the time being - I was for a while, but not for the next couple of weeks at least [22:58:11] ok, fine, a hangout than [22:58:13] then* [23:00:08] jdlrobson, left nav is broken in beta, I suspect typography changes. width [23:00:30] jgonera: ergg how broken? what broken? [23:00:31] width is defined in ems so if left nav and center have different font-size, it gets messed up [23:00:51] jdlrobson, the nav doesn't occupy the whole gray background [23:01:45] jdlrobson, I'll look into it [23:01:47] jgonera: did you raise a bug? [23:01:56] (03PS4) 10Jdlrobson: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 [23:01:59] (03PS2) 10Jdlrobson: Make KeepGoing/toast confirmation run when editing using VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108990 [23:02:01] (03PS1) 10Jdlrobson: QA: Define expected behaviour for VisualEditor overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 [23:02:02] jdlrobson, no, if it's a quick fix I'll just do it now [23:02:08] (03CR) 10jenkins-bot: [V: 04-1] Make KeepGoing/toast confirmation run when editing using VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108990 (owner: 10Jdlrobson) [23:03:57] jdlrobson, what exactly is https://gerrit.wikimedia.org/r/#/c/108173/1 fixing? [23:05:17] jgonera: kaity / kenanwang_ were complaining about cases where the box was taller than the image inside them - seems to only effect iOS (iPhone) [23:05:23] it could do with a bug really [23:05:29] but they said they wouldn't sign off the story until that was done [23:05:48] that said they've signed it off now so i don't know whether it was important or not :) [23:07:06] based on what was decided during the sprint review i moved it to signed off but forgot to open a bug for that item, although it's kinda borderline because I wouldn't say that the feature as it stands meets specs [23:14:24] (03PS2) 10Jdlrobson: QA: Define expected behaviour for VisualEditor overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 [23:14:26] (03PS5) 10Jdlrobson: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 [23:14:28] (03PS3) 10Jdlrobson: Make KeepGoing/toast confirmation run when editing using VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108990 [23:15:41] kenanwang_: can you make a bug for the whitepsace issue with screenshot? [23:15:46] kenanwang_: will help move this along [23:15:53] (03PS8) 10Jdlrobson: Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 [23:15:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Link JSDoc and StyleGuide in README / styleguide.MD [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106315 (owner: 10Jdlrobson) [23:16:08] (03CR) 10jenkins-bot: [V: 04-1] Make KeepGoing/toast confirmation run when editing using VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108990 (owner: 10Jdlrobson) [23:17:47] (03PS4) 10Jdlrobson: Make KeepGoing/toast confirmation run when editing using VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108990 [23:22:56] yeah can do [23:35:40] (03CR) 10JGonera: [C: 04-1] Remove whitespace within UserProfile boxes on iOS (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108173 (owner: 10Jdlrobson) [23:49:46]