[02:34:34] (03CR) 10Raimond Spekking: [C: 032] Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109555 (owner: 10L10n-bot) [02:35:17] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109555 (owner: 10L10n-bot) [05:33:28] (03CR) 10Dr0ptp4kt: "I have another patchset or two (or three!) to submit on this change to make it behave nicely. That said, to respond to addressing style ch" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109501 (owner: 10Dr0ptp4kt) [08:05:13] (03CR) 10Yuvipanda: [C: 04-1] "Current behavior is that the search term goes away when you navigate to a different page. This is so that if you mis-tap a result, you don" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109504 (owner: 10Dr0ptp4kt) [09:53:06] (03PS2) 10Yuvipanda: Handle Captchas returned when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109597 [10:14:12] (03PS1) 10Yuvipanda: Fix loading spinner not spinning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109636 [15:00:20] hey MaxSem [16:42:51] brion: ping? [16:45:11] hey [16:46:04] brion: nice weekend [16:46:10] yay! [16:46:27] brion: we should get legoktm on the iOS beta [16:46:31] brion: also you have patches :) [16:47:08] \o/ [16:47:37] invite sent [16:47:40] brion: sweet! [16:52:13] Hi, someone is reporting the following: "I'm using the Android Wiki App on my Samsung Galaxy Note I. Whenever I'd like to look at photos in more detail and click on them, I do get to a different page but the photo is not displayed. What can I do?" Can someone help with that? Maybe brion or MaxSem? [16:52:33] pajz: that's a known bug with the current android app [16:52:40] we're working on a new one which won't have this bug :) [16:53:43] brion, ok, thanks, any schedule for that? [16:55:02] late februaryish? beta soonish? [16:55:10] i forget the exact dates, they may change :D [16:55:39] beta soonish! [16:55:42] alpha nowish! [16:55:55] \o/ [16:58:49] Allright, thanks. [16:59:33] brion: CR! :) [16:59:49] brion: would be interesting to see comments from you on my EditingResult inheritance hierarchy [17:07:41] cr when i get to office [17:07:44] and find my glasses [17:07:50] otherwise i gotta crank up the font sizes ;) [17:08:16] brion: :D [17:08:18] brion: ok [17:09:03] maybe i can use google glass in a zoom mode [17:09:07] "ok glass: enhance" [17:09:23] 'ok glass: reverse zoom around' [17:10:00] (03PS1) 10Cmcmahon: Maintenance for new messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109681 [17:11:59] hey mhurd [17:12:08] heya! [17:12:13] good weekend> [17:12:15] ? [17:12:15] yo yo yo [17:12:15] had a nice weekend? [17:12:17] haha :P [17:12:30] yes, mine was really good :) [17:12:38] yuvipanda: yay! [17:12:42] brion: hey! [17:14:27] greg-g: re: Extension:MobileApp, it's still not enabled on betalabs :( hashar was busy fixing the VE breakage on it and didn't have time for this the couple of times I asked him :( [17:14:40] what's the blockage? [17:14:53] brion: oh, i updated that patch on saturday - found issues with having the lang link at the bottom of the TOC, and besides i think may's design had the lang button elsewhere anyway, so i moved it to the bottom bar thingy [17:15:21] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109681 (owner: 10Cmcmahon) [17:15:28] greg-g: https://gerrit.wikimedia.org/r/#/c/106217/ just needs +2 [17:15:52] greg-g: but VE broke mediawiki/extensions.git, so that needed to be fixed before this could go out. and that took way longer than expected, I think [17:15:58] (03Merged) 10jenkins-bot: Maintenance for new messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109681 (owner: 10Cmcmahon) [17:16:03] mhurd: great we'll look em over in a bit. [17:16:03] right [17:16:08] lemme head into the office wheeeeee [17:16:31] greg-g: it was initially scheduled to get deployed this week, but I guess that can't happen now? [17:16:57] meh, beta cluster can (and should) happen whenever [17:17:13] so, the issue is resolved, so maybe it's safe to go [17:17:18] the auto-update issue [17:17:21] yeah [17:17:30] but idk if anyone other than hashar will want to +2 that patch [17:18:27] greg-g: so I guess I'll try with hashar again when he's online tomorrow? [17:18:49] greg-g: when we last talked this was supposed to ride the train later this week, but I guess that can't happen now? [17:22:48] there's confusion here [17:23:00] beta cluster is tangential to "the train" [17:23:30] enabling anything on the BC is not dependent on me or the deployments calendar or the train [17:23:49] greg-g: right, but I thought it was the *other* way around? things can't get on the train until they have been on BC for a week or so? [17:23:51] you should do it as soon as you have something you need tested, also you should do it at least 1 week before you plan on having your new extension/whatever out on production [17:24:01] oh... sorry, confusion was mine then [17:24:19] ride the train as in "we wanted it on BC a week ago so we'd stay on sched for production" [17:24:22] my bad [17:24:35] right. [17:24:39] blugh [17:24:53] I wanna jfdi, but I'm over cautious always [17:25:20] that and I don't have +2 on puppet [17:25:29] er, operations/* [17:25:29] greg-g: heh, completely understand :) [17:25:36] greg-g: I could just poke hashar tomorrow [17:25:49] and we could put this on the deployment calendar for next week. [17:26:00] k [17:26:28] greg-g: should I do any edits for the deployment calendar anywhere? [17:26:52] yeah, so, I was going to ask (but then csteipp interrupted me) [17:27:06] greg-g: :P [17:27:08] * YuviPanda waits [17:27:11] so, what's happening? 1 sentence plain english for the -ambassadors list? [17:28:03] greg-g: 'New Mobile Apps (to be launched in end Feb) will have a content styling different from mobile web, and can update styling without having to do an app store update' [17:28:19] this extension serves the styles (and some JS) via RL. [17:28:43] so when we want to update styles for the app, we can just make a commit here and have it ride the train, rather than push an app update out [17:29:22] huh, neat [17:29:29] I didn't know that's what this was for [17:29:54] heh, it is Extension:MobileApp, because Extension:MobileAppStylesAndScripts is too long [17:30:15] MobleAppPrettyThings [17:30:31] hehe [17:30:59] greg-g: we might also have minimal PHP in it later on. Like, edit tagging (which has to be done server side) if we want it. [17:31:11] but nothing for now [17:31:19] right now it is just a way for us to use RL [17:31:27] scary [17:31:59] (03PS6) 10Dr0ptp4kt: WIP: Toggle chrome in Wikipedia Zero contexts, support interstitials. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109501 [17:32:27] greg-g: http://glennmcanally.com/sarcastic/ ? [17:32:28] :) [17:34:45] actually, the php addition sounded scary, but I could be wrong (see above re cautious) [17:35:04] greg-g: true, and I'll make sure to give you two weeks or more of warning if we ever put anything non RL in there [17:37:10] * greg-g nods [17:42:10] (03PS7) 10Dr0ptp4kt: WIP: Toggle chrome in Wikipedia Zero contexts, support interstitials. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109501 [18:00:49] ok, I was going to do something here, now to do it. [18:02:32] jdlrobson: standup? [18:06:35] YuviPanda: whoever: thinking Feb 5th to have MobileAppPrettyThings deployed on production? [18:06:45] er, 6th [18:06:53] greg-g: sounds good to me! [18:07:44] cool [18:11:30] (03PS1) 10Cmcmahon: slight change to messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109695 [18:11:47] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109695 (owner: 10Cmcmahon) [18:11:55] chrismcmahon: any idea why all the mobile tests are failing? [18:12:14] chrismcmahon: also please don't self merge.. that's a terrible commit message on the patch you just +2ed [18:12:23] jdlrobson: yes, messages changed from "login and Login" to "log in" and "Log in" [18:12:41] (03Merged) 10jenkins-bot: slight change to messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109695 (owner: 10Cmcmahon) [18:13:14] chrismcmahon: a better commit message would have been QA: follow up to bug X (where X is the bug which introduced those messages) [18:13:40] Now that commit is 1) not categorized in deployment logs 2) a bit cryptic to a developer looking through git log [18:17:10] chrismcmahon: https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/222/testReport/junit/(root)/Editor/Closing_editor__browser_button_/ < not sure why this one is tailing [18:17:14] predates the message stuff [18:18:30] jdlrobson: redirected to https from http [18:19:12] oohhh that's still an issue?! [18:19:13] eek [18:19:33] chrismcmahon: what can we do to rectify that? [18:20:35] jdlrobson: I don't think test2 used to do that. I have some other stuff to do for the next few hours [18:21:07] chrismcmahon: ok [18:26:19] (03PS1) 10Jdlrobson: Switch from 'log in' to 'sign in' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109698 [18:26:36] (03PS2) 10Jdlrobson: Switch from 'log in' to 'sign in' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109698 [18:30:40] jdlrobson: that test should probably not care if it sees http or https, I'll fix that this afternoon [18:32:03] "Could not create an EGL context. eglCreateContext failed with error: EGL_SUCCESS" [18:32:28] brion: hahaha :D [18:32:40] when i start seeing GL problems i reboot the phone :P [18:33:06] a lot of time gl problems aren't gl problems [18:33:53] especially the success error :P [18:35:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] Remove superfluous files in assets dir [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109290 (owner: 10Yuvipanda) [18:35:40] brion: heh yeah [18:38:26] yuvipanda: hey, do i need to worry about captchas sometimes being math instead of image? (https://www.mediawiki.org/wiki/API:Edit#CAPTCHAs_and_extension_errors) [18:38:37] mhurd: nope, not on WMF cluster :) [18:38:42] yuvipanda: yay! [18:38:57] mhurd: you should edit that page to put an actual response there [18:39:01] since most people will be confused [18:41:02] (03CR) 10Brion VIBBER: Start using an object hierarchy to deal with Edit Results (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109292 (owner: 10Yuvipanda) [18:41:02] yuvipanda: oh, a non-math response? [18:41:16] mhurd: yeah [18:41:21] yuvipanda: will do [18:41:24] mhurd: kenanwang_ : heads up that haitham has volunteered to do RTL testing with us. we'll have to provide the device and set it to RTL [18:41:24] mhurd: i don't know of any wiki that actually uses the math captcha [18:41:36] it wouldn't hurt to accept text-style captchas as well, but we don't need em for our case so don't worry about it :D [18:42:14] (03CR) 10Yuvipanda: Start using an object hierarchy to deal with Edit Results (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109292 (owner: 10Yuvipanda) [18:44:16] (03CR) 10Brion VIBBER: Start using an object hierarchy to deal with Edit Results (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109292 (owner: 10Yuvipanda) [18:45:16] * brion hmms [18:45:37] brion: I can remove them in another patch. [18:45:39] if you want [18:45:45] (03CR) 10Yuvipanda: Start using an object hierarchy to deal with Edit Results (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109292 (owner: 10Yuvipanda) [18:46:14] YuviPanda: meh, it don't hurt anything [18:46:21] :D [18:46:30] brion: yeah, that was my thinking too [18:46:39] yuvipanda: if a second captcha is requested, is the first one still valid or only the latest one? [18:47:13] brion: only the second one, IIRC [18:47:22] well, only the second one is supposed to be valid :P [18:48:06] yuvipanda: cool [18:48:12] yuvipanda: thanks [18:48:18] mhurd: :) [18:48:46] whaaaat [18:48:51] "Sheep" article is semi-protected [18:48:54] lemme test another [18:49:16] brion: pfft, test on testwiki! [18:49:24] brion: i like testing with the "lawyer" article - the lead image is amazing [18:49:40] brion: modify getPrimaryLanguage on WikipediaApp.java to always return "test" [18:49:41] :D [18:50:32] real testers test on real sites! [18:51:29] brion: heh, don't get the office IP banned again! :P [18:51:38] yuvipanda: hey! :) [18:51:44] hehe :P [18:51:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok let's keep the result string for now, if we decide we really don't need it we can kill it later. It harms nothing. :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109292 (owner: 10Yuvipanda) [18:51:59] milimetric: want to fix the limn graphs around 1pm PST? [18:52:03] YuviPanda: i'm making legit edits [18:52:07] more or less [18:52:10] brion: hehe [18:52:33] sure jdlrobson, let's do it [18:52:49] sweet ping me at 1pm if i don't ping you first? [18:53:28] ok if i'm gonna be tripping captchas i should go to test... [18:54:37] brion: :P [18:54:38] brion: yeah [18:54:41] brion: GO! [18:56:19] dr0ptp4kt: have you seen yuri today? [18:58:58] YuviPanda: did reloading of the page after edit stop working? [18:59:11] brion: worked for me? [18:59:17] not for me [18:59:21] brion: the spinner stopped spinning, but I've a commit later that fixes it [18:59:29] ok i'll keep going :D [18:59:29] brion: hmm, grep for error lines in adb lolcat? [18:59:38] brion: the page itself loads, though [19:00:30] (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "Triggering a captcha by adding a URL to an edit leads to an immediate crash." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109293 (owner: 10Yuvipanda) [19:01:08] brion: that is handled in the next commit [19:01:14] YuviPanda: https://gist.github.com/brion/8655212 [19:01:17] brion: prior commits also crashed [19:01:17] sigh [19:01:25] brion: if you trigger abusefilter now, it will crash :) [19:01:33] ok can you put in notes like "and it crashes when you trigger it" please [19:01:38] brion: ah, ok [19:01:44] brion: I didn't put in this time because it has always crashed [19:01:48] even before this change [19:02:02] brion: but will do [19:02:04] well it shouldn't crash if you added support for captcha returns would be my expectation :) [19:02:32] brion: true, but I only added support for returns, not for handling the returns [19:02:51] or at least that is what I remember. There has been one beer filled saturday night between when I wrote that code and right now :P [19:02:56] haha [19:04:24] (03CR) 10Brion VIBBER: "On-screen keyboard in edit box needs to be fixed so enter = "done" instead of "newline"" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109597 (owner: 10Yuvipanda) [19:05:25] (03PS1) 10Yuvipanda: Make captcha text box single line only [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109703 [19:05:29] brion: ^ [19:05:41] (03CR) 10Brion VIBBER: Handle Captchas returned when editing (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109597 (owner: 10Yuvipanda) [19:06:33] (03CR) 10Yuvipanda: Handle Captchas returned when editing (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109597 (owner: 10Yuvipanda) [19:09:15] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle Captchas returned when editing (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109597 (owner: 10Yuvipanda) [19:09:32] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok the non-crash part is in the next commit.. :P :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109293 (owner: 10Yuvipanda) [19:10:09] brion: we can't really unit test solving captchas can we [19:10:20] that's what mock objects and interfaces are for [19:11:00] brion: yeah, but then we're not fully testing the flow [19:11:46] that's why they're called unit tests, not flow tests :) [19:11:52] brion: :P [19:11:53] fine, fine [19:12:00] brion: our unit tests are only partially unit tests... [19:12:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix loading spinner not spinning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109636 (owner: 10Yuvipanda) [19:16:17] brion: one more minor patch :D [19:18:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Should probably also have the 'done' button trigger the save action, but this is a definite improvement." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109703 (owner: 10Yuvipanda) [19:19:13] (03CR) 10Kaldari: [C: 031] Use DISPLAYTITLE when rendering pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108539 (owner: 10Theopolisme) [19:20:40] YuviPanda: ok any more bits? [19:20:51] brion: no, still messing around with AbuseFilter [19:20:54] ok [19:20:56] brion: expect a few in an hour or so [19:21:13] ok [19:21:14] brion: oh, brion - you should poke MaxSem and figure out a lightning deploy for the account creation stuff [19:21:19] *nod* [19:21:22] brion: last week there was no train so this won't get deployed this week [19:21:36] wat stuff? [19:21:54] MaxSem: some core changes and a confirmedit change, I think. all merged. [19:22:00] MaxSem: brion can probably give you links [19:22:29] I'm fine as long as greg-g is:) [19:24:00] MaxSem: greg-g: https://gerrit.wikimedia.org/r/#/c/108088/ & https://gerrit.wikimedia.org/r/#/c/108089/ and https://gerrit.wikimedia.org/r/#/c/106844/ & https://gerrit.wikimedia.org/r/#/c/106845/ [19:24:13] that's two each on core and ConfirmEdit [19:24:22] smallish fixes [19:26:32] bbr [19:26:34] brb [19:35:11] awjr: I pointed or.i to the vagrant discussion for zurich, he promised to respond. [19:44:37] awjr: ori responded to the vagrant thread but it didn't make it to mobile-tech. can you take a look? [19:44:46] sure thing YuviPanda, in a bit [19:44:56] awjr: thanks! [19:45:24] (03CR) 10MaxSem: [C: 04-1] "Can we keep consistency with desktop?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109698 (owner: 10Jdlrobson) [19:45:58] jdlrobson, jgonera: Currently I can't get VE to load successfully in my local instance. It just gives me a spinner with no errors. Is there anything special I have to do to get it to load on mobile? [19:46:35] It used to work for me previously [19:49:57] I bet it's because my parsoid server isn't running! [19:50:24] would be nice if it gave an error [19:53:55] brion: gah, still messing around with abusefilter bugs. [19:56:31] i'm downloading Xcode release candidates \o/ [19:56:37] liven' on the edge [19:56:44] brion: :P [19:58:39] YuviPanda: are you talking about Ori's reply starting with ' think either approach (or some combination) would be desirable and feasible.' ? [19:59:06] awjr: yeah, nevermind, it just was delayed [19:59:11] :) [20:01:08] awjr: any thoughts on what I said? [20:01:22] yeah YuviPanda, i will be responding at some point today [20:01:28] i need to give it a little more thought and eat some lunch :) [20:01:35] awjr: ok! [20:04:12] brion: ping [20:04:26] brion: I just thought of a way to get another captcha. Not sure if it would work, however [20:04:51] YuviPanda: isn't there an API module just for getting a new captcha? [20:04:52] brion: hmm, nevermind, I now see how it won't work [20:04:59] brion: afaik no? is there? [20:05:11] brion: I could only see just sending the same action=edit again and getting it back [20:05:17] ApiFancyCaptchaReload.php [20:05:32] oh [20:05:37] looking [20:05:39] i haven't tried it [20:05:47] but i hope it works :D [20:06:00] brion: heh, alright. I'll try that instead [20:06:04] :D [20:06:06] brion: it doesn't give me a URL though. grr [20:07:52] kaldari, have you got it running? was it only the parsoid server? [20:09:23] probably, I had it all set up on my old computer but I have to install the whole stack from scratch on this one (node.js, etc.) [20:09:59] In the meantime, I'm going to try to improve the error handling for cases where it doesn't load :) [20:11:48] hmmm weird [20:12:09] MaxSem: you familiar with 'languagecount' parameter in action=mobileview? we're seeing 'null' in the response for some pages [20:12:13] https://en.m.wikipedia.org/w/api.php?format=json&action=mobileview&prop=sections|text|lastmodified|lastmodifiedby|languagecount§ions=0§ionprop=toclevel|line|anchor&page=Slashdot [20:12:38] looking at the code it oughta be a number or 0 [20:13:11] (03PS1) 10Kaldari: Make sure previous.overlay is defined before using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109724 [20:13:18] looking [20:17:21] you know what i think it is [20:17:27] CACHE_VERSION didn't get bumped [20:17:33] in e35c463e [20:20:02] what am I supposed to be worried about? I have an interview in 10 minutes... [20:20:51] greg-g: shape of your nose, and your palms' color [20:21:04] greg-g: being aware that you have a tongue lying at the bottom of your mouth also helps [20:21:10] MaxSem: yeah if i re-edit the 'Slashdot' page on enwiki it comes up with the correct data [20:21:16] needs a bump [20:22:42] (03CR) 10Brion VIBBER: "ApiMobileView::CACHE_VERSION did not get incremented, leading to stale cache entries being served out with null 'languagecount' or 'hasvar" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/105988 (owner: 10Theopolisme) [20:24:21] (03PS1) 10Brion VIBBER: Bump action=mobileview's cache version since last update [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109728 [20:25:16] (03CR) 10MaxSem: [C: 032] Bump action=mobileview's cache version since last update [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109728 (owner: 10Brion VIBBER) [20:25:28] wheee [20:25:51] (03Merged) 10jenkins-bot: Bump action=mobileview's cache version since last update [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109728 (owner: 10Brion VIBBER) [20:27:19] (03CR) 10Brion VIBBER: "Ok I figured out what the problem with null languagecount was -- this is being fixed on the server side in I762ad2d." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/109318 (owner: 10Mhurd) [20:29:27] jgonera: I got the parsoid server running locally, but still no luck with VE. It's silently failing while loading the mobile.editor.ve module. [20:29:41] I'll do some more troubleshooting after lunch [20:32:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] "woo" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/109318 (owner: 10Mhurd) [20:35:46] kaldari, ok, I'll be in the office soon so if you still have problems, just let me know [20:43:16] jdlrobson, the new random feature in alpha is pretty cool .. much nicer than the first try :) [20:49:04] (03CR) 10Brion VIBBER: [C: 032 V: 032] "selfmerge \o/" [apps/glass/wikipedia] - 10https://gerrit.wikimedia.org/r/109603 (owner: 10Brion VIBBER) [20:57:33] brion: quick question about captcha error msgs when u have a sec [20:57:40] yo [20:58:01] (03PS1) 10Cmcmahon: test2wiki redirects to https from https, causing failure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109735 [20:58:15] (03PS2) 10Cmcmahon: test2wiki redirects to https from https, causing failure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109735 [20:59:28] (03PS3) 10Cmcmahon: test2wiki redirects to https from https, causing failure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109735 [21:00:41] (03PS4) 10Cmcmahon: test2wiki redirects to https from https, causing failure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109735 [21:02:25] jdlrobson: apropos of that failure on test2 earlier, this should sort it: https://gerrit.wikimedia.org/r/#/c/109735 [21:07:07] chrismcmahon: thanks [21:07:19] Eloquence: still needs to make use of the api to be quicker :-) [21:07:41] jdlrobson: thanks for pointing that one out, it had some smells [21:08:35] (03PS5) 10Cmcmahon: test2wiki redirects to https from http, causing failure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109735 [21:09:21] (03PS6) 10Jdlrobson: test2wiki redirects to https from http, causing failure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109735 (owner: 10Cmcmahon) [21:09:29] chrismcmahon: will take a look a bit later if no one else does - gonna work with milimetric to do some analytics stuff now [21:13:10] brion: off to sleep now. [21:13:13] hmm [21:13:15] gniht [21:13:16] one patch before that, mnaybe :) [21:13:18] hehe [21:15:34] night yuvipanda ! [21:15:38] milimetric: you there? [21:15:57] yea, I pinged you :) [21:15:58] jdlrobson: doing one more patch before going :) [21:16:02] in a pm [21:16:14] jdlrobson: ^ [21:19:03] (03PS1) 10Yuvipanda: Make CaptchaResult depend only on id [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109740 [21:19:05] brion: ^ [21:19:07] am off now [21:19:08] night [21:22:09] jdlrobson: any luck on sorting out the test failures? [21:23:53] awjr: chrismcmahon noticed some https issues - not sure yet if fixing those will fix test [21:24:17] jdlrobson: at quick glance, it also looks like there may be messaging inconsistencies? [21:24:40] jdlrobson: context? I think test2 is legitimately redirecting to https, since we have a legit cert for test2 domain [21:25:25] awjr: had I think four tests move from "login" to "log in" in messaging. [21:26:10] doh [21:26:26] have the tests been updated or does that still need to happen? [21:26:55] chrismcmahon: the context is all the QA failure emails we've been receiving recently [21:27:05] and the patch you provided (https://gerrit.wikimedia.org/r/#/c/109735) [21:27:09] chrismcmahon: here's an http/https one: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/268/testReport/junit/(root)/Editor/Closing_editor__browser_button_/ [21:27:17] that's on enwiki [21:27:44] the expected case should probably be https since that's what happens when you log in on enwiki [21:27:45] awjr: I updated the tests, apologies, I self-merged the trivial ones (I get up early). This one is more interesting: https://gerrit.wikimedia.org/r/#/c/109735/ I haven't looked into when test2 started doing that redirect to https again [21:28:23] awjr: https://gerrit.wikimedia.org/r/#/c/109735/ makes the test agnostic vis a vis https or http [21:28:35] ok cool [21:28:43] thanks chrismcmahon [21:29:00] awjr: thus accommodating beta and test2. and it had some smells, too, that change is an improvement [21:29:56] (03PS2) 10Jdlrobson: WIP: Make edit button permissions work on alpha lazy loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 [21:30:07] ^ MaxSem I could do with help on that patch to avoid the ajax request to getGroups... [21:30:46] jdlrobson, which file? [21:31:18] cool chrismcmahon, im reviewing now [21:31:19] thanks [21:31:54] MaxSem: so there is mw.user.getGroups which causes an ajax request to /w/api.php?action=query&format=json&meta=userinfo&uiprop=rights%7Cgroups [21:32:13] basically i want us to ship the response of that api query in a config variable to avoid a lookup on every single page [21:32:35] specifically "groups":["*","user","autoconfirmed"] [21:32:40] that part of the response [21:32:53] do we really need rights? [21:33:15] cuz it's kinda long for inclusion in every page? [21:33:57] awjr: jdlrobson still have a couple failures for Notifications, looking at those now [21:34:13] chrismcmahon: passes for me locally :( [21:35:11] jdlrobson, batch it with some other query? [21:35:39] MaxSem: basically we need to determine if a page is editable or not based on the protection property returned in the api response [21:37:50] jdlrobson, this is a use case different from what was needed for apps which can cache user info - maybe mobileview should return straightforward 'can edit' indicator? [21:38:14] CC brion cause apps [21:38:40] editable or not? well [21:38:48] that's tough technically [21:38:54] could be per-user limitations etc [21:39:17] userQuckCan() type [21:40:21] MaxSem: we ajax load pages like the app [21:40:24] thus this is not sufficient [21:40:32] so what? [21:40:47] I don't see why we can't... [21:41:56] response for a page should not be tied to the current user [21:42:01] otherwise the responses will vary [21:42:29] yep, but that's already the case [21:42:35] milimetric: https://gerrit.wikimedia.org/r/109757 [21:42:38] page views are inherently per-user [21:42:52] and mobileview follows the suit [21:43:28] $this->getMain()->setCacheMode( 'anon-public-user-private' ); [21:51:54] (03PS8) 10Dr0ptp4kt: WIP: Toggle chrome in Wikipedia Zero contexts, support interstitials. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109501 [21:53:23] (03PS9) 10Dr0ptp4kt: WIP: Toggle chrome in Wikipedia Zero contexts, support interstitials. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109501 [21:59:49] (03CR) 10Awjrichards: [C: 032] QA: test2wiki redirects to https from http, causing failure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109735 (owner: 10Cmcmahon) [22:00:24] (03Merged) 10jenkins-bot: QA: test2wiki redirects to https from http, causing failure [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109735 (owner: 10Cmcmahon) [22:11:43] jdlrobson: I don't see any especially old changes that need to be reviewed in gerrit. Have they all been reviewed or merged now? [22:14:02] seems to be better now kaldari thanks [22:16:56] 1 Fatal error: Call to a member function getFullURL() on a non-object in /usr/local/apache/common-local/php-1.23wmf10/extensions/MobileFrontend/includes/specials/SpecialMobileEditor.php on line 24 [22:17:00] That looks familiar [22:18:51] should be fixed in later branches [22:19:06] JeffHall, the ORMs I've used are Mongoid (http://mongoid.org/en/mongoid/docs/persistence.html) and ActiveRecord (http://guides.rubyonrails.org/active_record_querying.html), I think getting some inspiration from them when shaping our libraries might be a good idea [22:19:39] jgonera: Thanks for the pointers - I'll take a look! [22:19:49] also, JeffHall, the utility module pattern (which we don't need right now, but just for future reference): http://www.intridea.com/blog/2010/4/19/ruby-quick-tip-instant-utility-modules [22:20:34] (03PS5) 10Jdlrobson: QA: Define expected behaviour for VisualEditor overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 [22:22:15] (03CR) 10Kaldari: [C: 04-1] Hygiene: Add proper error reporting in lead image uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109264 (owner: 10JGonera) [22:43:21] (03PS1) 10Cmcmahon: properly wait for notifications elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109775 [22:44:48] (03PS2) 10Cmcmahon: properly wait for notifications elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109775 [22:54:04] (03PS1) 10Jdlrobson: Story 1625: Drop the preview screen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109779 [22:54:21] (03PS3) 10Jdlrobson: properly wait for notifications elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109775 (owner: 10Cmcmahon) [22:54:27]