[00:03:25] rmoen: you there? [00:03:40] jdlrobson: yes [00:03:47] jdlrobson: hi [00:03:51] rmoen: hey :D [00:03:58] jdlrobson, why is https://bugzilla.wikimedia.org/show_bug.cgi?id=60066 not fixed? [00:04:08] jgonera: i have no idea [00:04:17] either a re-regression or something else [00:04:17] jdlrobson, so why did you say it's not? [00:04:23] it's broken still [00:04:31] kaldari raised a bug this morning [00:04:36] it says so in the comments [00:04:46] Duplicate of this bug: 60480 [00:04:59] (if you haven't got full history on bugzilla enabled you should enable it) [00:05:30] jdlrobson, but what specifically? there are multiple items in this bu [00:05:31] g [00:05:37] https://bugzilla.wikimedia.org/userprefs.cgi?tab=settings make sure "When viewing a bug, show all bug activity" is set to yes [00:06:11] Bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60480 make me a less confusing version of this one [00:06:14] *may [00:06:37] the initial bug report was super confusing and listed various issues [00:06:55] rmoen: so anyway - i need to move the toolbar for VE in mobile [00:06:57] how can i do that? [00:07:01] i'm looking at setUpToolbar [00:07:16] .insertBefore( $( '#firstHeading' ).length > 0 ? '#firstHeading' : this.surface.$element ); < seems a bit limiting [00:08:17] Yeah the insert in this.surface.$element is currently how it is being added mobile [00:08:35] jdlrobson: ^ for mobile [00:09:51] but this enforces the toolbar to be inserted before the surface [00:09:56] I want to insert it into the overlay header [00:10:08] so .appendTo( this.surface.$element) [00:10:14] or something akin to that [00:11:18] jgonera: are you clear now? [00:12:18] jdlrobson: may i suggest extending the setupToolbar method ? [00:12:27] rmoen: that's what i was thinking [00:12:31] but i didn't want to duplicate it all [00:12:36] yeah so you can [00:12:38] 1 sec [00:12:41] probably needs a bit of a refactor [00:14:20] ve.init.mw.MobileViewTarget.prototype.setupToolbar = function () { ve.init.mw.Target.prototype.setUpToolbar.call( this ); //then append this.toolbar.$element wherever }; [00:14:29] jdlrobson: ^ [00:18:25] kenanwang_: In card 1621, it says "the figure element is used in place of thumbnails" in the acceptance criteria, but I have no idea what this means? What is a "figure element"? [00:33:18] kenanwang_: Nevermind [00:40:29] jdlrobson: quick question when u have a sec [00:51:02] kenanwang_: per https://bugzilla.wikimedia.org/show_bug.cgi?id=60426 there is some debate about using 'log in' vs 'sign in'. jdlrobson has an open patchset to adjust the language to 'sign in' - is that desired? [00:51:45] (it's me wrongly or rightly creating the debate - mostly it is my way to moan about a rushed +2 that was incomplete ;-)) [00:53:02] :) [00:53:55] jdlrobson: it's all good; im happy to merge your patch if kenanwang_ is ok with the change, otherwise we can just stick with cleaning up the 'log in' messaging [00:54:07] there's discussion on the bug too awjr [00:54:28] jdlrobson: yeah i've read through it but i think it's kenan's call [00:54:41] hmm [00:54:56] let me ask steven if he has an opinion [00:55:34] jdlrobson: line 15180 in https://gerrit.wikimedia.org/r/#/c/109698/2/MobileFrontend.i18n.php doesn't look right though :p [00:56:57] "log in" is good [00:57:16] thus I -1'd:P [00:57:19] (03CR) 10Awjrichards: [C: 032] Make sure previous.overlay is defined before using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109724 (owner: 10Kaldari) [00:57:55] (03CR) 10Awjrichards: "Aye, Kenan has confirmed we should stick with 'log in'" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109698 (owner: 10Jdlrobson) [00:58:14] (03Merged) 10jenkins-bot: Make sure previous.overlay is defined before using it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109724 (owner: 10Kaldari) [00:58:17] awjr and jdlrobson: on like 15180 we really need to ask a Swedish speaker [00:58:50] :p [00:58:57] I Google Translated to check, but it's probably not really good enough. Either way it did not suggest "Logga inn" was correct. [00:59:06] lol [00:59:15] those changes should happen through translatewiki regardless [00:59:18] yeah [00:59:40] (03PS1) 10Jdlrobson: QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 [01:00:17] (03CR) 10jenkins-bot: [V: 04-1] QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 (owner: 10Jdlrobson) [01:05:42] rmoen: looking at the VE code I think we're going to need to find some way to only serve the JavaScript with ve.. :-/ [01:05:52] i need to override some of the styles [01:10:22] jdlrobson: could we not have css in ext.visualEditor.mobileViewTarget ? [01:10:59] rmoen: looking at VE OOJS cannot be decoupled from css? [01:11:17] 'oojs-ui' module for instance lists "lib/ve/lib/oojs-ui/oojs-ui.svg.css" as styles [01:11:29] kaity: beta labs is fixed now: http://en.m.wikipedia.beta.wmflabs.org/wiki/San_Francisco [01:11:46] rmoen: basically i want to use mediawiki ui styles [01:12:02] kaldari: cool! [01:14:11] kenanwang_: You around? [01:14:20] yep [01:14:31] back by the hammock [01:16:01] awjr: we don't want to abandon that patch set we want to rewrite it [01:16:02] (03CR) 10Awjrichards: [C: 04-2] "Per Kenan" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109698 (owner: 10Jdlrobson) [01:16:09] awjr: it still polyfills some missing translations [01:16:40] jdlrobson: translations shouldn't be updated that way [01:17:14] 'mobile-frontend-donate-image-login-action' => 'Login to share your media.', < awjr [01:17:16] pretty sure that is wrong [01:17:44] as is 'mobile-frontend-watchlist-cta-button-login' => 'Login', ? [01:17:50] as is 'mobile-frontend-watchlist-login-action' => 'Login to see it.', ? [01:18:17] jdlrobson: those appear to already be fixed in master [01:18:21] they have? [01:18:45] so they have.. mm.. what happened there they weren't when i checked yesterday [01:18:56] * awjr shrugs [01:19:05] * jdlrobson is now super confused [01:19:15] ok abort then :) [01:19:18] :) [01:19:36] i guess we should double check the tests are ok [01:19:54] (03Abandoned) 10Jdlrobson: Switch from 'log in' to 'sign in' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109698 (owner: 10Jdlrobson) [01:19:58] grep'ing for 'login' seems to suggest that the tests are ok [01:21:02] rmoen: need some clarification on VE ontology... [01:23:18] so surface phantoms are overlay elements that lay on top of page elements than are either protected or not editable, but what is a "surface highlight"? [01:24:11] (03PS1) 10Mhurd: Added captcha support for editing. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/109819 [01:29:16] kaldari: highlights are basically faked selection for certain nodes [01:30:09] rmoen: How can I see an example of this? [01:30:49] tfinc: kenanwang_ think i'm gonna head out a bit early - although i arrive early so it all works out :) finished the captcha story a few minutes ago too [01:31:07] cool great! [03:11:50] (03PS8) 10Dr0ptp4kt: Add basic Wikipedia Zero detection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107992 [03:47:32] (03PS1) 10Dr0ptp4kt: Merge in Wikipedia Zero stuff. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109837 [03:51:18] (03Abandoned) 10Dr0ptp4kt: Merge in Wikipedia Zero stuff. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109837 (owner: 10Dr0ptp4kt) [04:26:45] (03PS16) 10Jhall: WIP QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [04:28:39] (03PS17) 10Jhall: QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [04:33:12] (03PS10) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. * If on Wikipedia Zero participating carrier, toast at startup. * If NOT on Wikipedia Zero participating carrier, don't toast. * Update search bar as appropriate. * Intercept offsite links when in Zero m [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109501 [04:34:41] (03PS1) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109844 [04:36:22] (03Abandoned) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. * If on Wikipedia Zero participating carrier, toast at startup. * If NOT on Wikipedia Zero participating carrier, don't toast. * Update search bar as appropriate. * Intercept offsite links when in Zero m [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109501 (owner: 10Dr0ptp4kt) [04:39:18] (03CR) 10Dr0ptp4kt: "Yuvi, I ran into some merge problems, so I created this branch." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109844 (owner: 10Dr0ptp4kt) [04:55:12] (03CR) 10Dr0ptp4kt: "Ah, thought that may be the case. Alright, resubmitting shortly." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109504 (owner: 10Dr0ptp4kt) [04:56:11] (03PS2) 10Dr0ptp4kt: Slide the keyboard down and clear the search bar on search result item tap. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109504 [05:02:23] (03PS3) 10Dr0ptp4kt: Slide the keyboard down on search result item tap. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109504 [06:54:36] (03PS2) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109844 [07:41:45] Hi all. Like mentioned earlier there appears to be no existing mobile /framework/, for me to write a mobile app in HTML with users' ability to upload images without me manually touching the API. [07:42:40] I found https://www.mediawiki.org/wiki/Mobile_Apps/Team, but no documentation on such framework(s) for any platform(s). [07:48:53] AFAIK none exist [07:51:03] +1 to Reedy [07:51:18] Closest you may find is to fork one of the other apps and adapt it to your eneds [07:51:31] gry: when you last asked I think I pointed out that the current apps are Java/Objective-C, and if you really want you can maybe steal some code from MobileFrontend [07:51:33] or the old app maybe [07:51:47] and also what do you even mean by 'manually touching the api' [07:58:52] yuvipanda: I'm now trying to look at multiple languages, yes. I couldn't find anything in Java when browsing the documentation. I am looking at the MobileFrontEnd. -- I mean, for a contributor to upload an image, without a framework, I would have to make API queries and fiddle with parsing errors from them manually. [07:59:12] gry: yes, that is the kind of thing that programming normally entails :) [07:59:32] gry: MobileFrontend has javascript code that handles photo uploads. You might be able to steal it, or not - I don't know (haven't worked with Mobilefrontend) [07:59:51] yuvipanda: it would seem that many app ideas could involve uploading images, and people shouldn't resort to stealing code from each-other and manually keeping it up to date. [08:00:07] gry: maybe. in that case you could write a library and release it for others to use? [08:00:21] you could also steal code from the old WLM app if you want. [08:00:42] Programing doesn't "normally entail" that sort of thing. I could do that indeed, but I sort of lack experience. [08:00:57] I will try to shape something isolated, library-like, from the bits you mentioned. [08:01:06] gry: wonderful :) [08:15:34] It would seem that such library would be in the interests of WMF and community, as it would make development of mobile apps easier. Doubt I would be the best resource to use for such task (although it's better than nothing). [08:17:49] The WMF doesnt really need random apps doing the same thing [08:26:22] Reedy: it has only a handful of apps. Each sister project may come up with its own handful, with little available to start implementing them. [08:26:40] and? [08:27:01] It's why github actively suggests forking repositories [08:27:24] gry: there also already exist commons apps for Android and iOS [08:27:50] Upload in most cases for the WMF should be to commons with appropriate licenses [08:28:00] Mobiles aren't exactly the best source for fair use or similar images [08:28:08] So to Wikipedia et al, it's not really needed [08:28:34] Wasn't it the wiktionary app that was created by forking the Wikipedia Android app? [08:30:45] it was. such a terrible idea [08:35:36] 1) Write Wikipedia app [08:35:41] 2) s/Wikipedia/Wiktionary/ [08:35:44] 3) ?????? [08:35:45] 4) Profit! [08:37:31] Reedy: don't forget the constant rebasing needed afterwards :P [08:37:48] 5) Rebase! [09:04:33] 19:28:00 Mobiles aren't exactly the best source for fair use or similar images [09:05:03] Uh huh. I expected people to upload their own photos. Wonder how much such expectations meets reality. [09:05:19] gry: are you aware of the great selfiapocalypse of 2013? [09:05:31] No [09:06:49] gry: hmm, I can't find a link, but fae would probably kjnow better [09:07:14] gry: Reedy also, deletion rates for images from mobile web and mobile apps are very different [09:07:15] http://mobile-reportcard.wmflabs.org/ [09:08:34] https://tech.dropbox.com/2014/01/retrieving-thumbnails/ [09:08:42] * yuvipanda clicks [09:10:12] gi11es: interesting! [09:10:22] nice to know that the base64 overhead is killed by gzip [09:27:23] yuvipanda: these stats do not tell me much since they don't tell the context. For example, in December, of 5K uploads, 2K were deleted; I don't /know/ why. [09:28:08] gry: indeed. there is a category, however, so you could perhaps ask an admin to check why [09:28:13] or look at some sort of logs commons has [09:28:25] gry: Fae was rather interested in this, you could ask Fae [10:24:44] (03PS1) 10Dr0ptp4kt: Obtain headers of response as well in case API consumer needs it. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 [10:32:05] (03CR) 10Yuvipanda: [C: 04-1] "wooohoo! :)" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 (owner: 10Dr0ptp4kt) [10:49:24] (03PS2) 10Dr0ptp4kt: WIP: Obtain headers of response as well in case API consumer needs it. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 [10:51:53] (03PS3) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109844 [10:53:12] (03CR) 10Dr0ptp4kt: "Alright, will do. Thanks!" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 (owner: 10Dr0ptp4kt) [10:54:25] (03PS3) 10Dr0ptp4kt: WIP: Obtain headers of response as well in case API consumer needs it. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 [13:33:06] (03PS1) 10Yuvipanda: Add AbuseFilterEditResult & a test to trigger it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109887 [13:53:24] It's too complicated. I'll have to chase down someone else who shares interest. [13:54:06] The MobileFrontEnd "Page" object has very little functions with it, for example. [15:59:01] * MaxSem bites yuvipanda greetingly [17:20:27] :( [17:20:57] sections won't open on MFE experimental. [17:23:06] and Save button in settings isn't working! [17:27:27] only on Chrome, though. FF works. [17:27:29] hi MaxSem [17:28:35] MaxSem: did we ask greg-g for an LD window? [17:28:46] or rather, did you ask for it after I went to sleep? [17:29:00] I've seen no reply from him hence no deploy [17:29:29] yuvipanda, web team needs to determine whether a page is editable without requesting user groups - would a simple editable flag work for you? [17:29:59] MaxSem: one that internally calls canEdit? [17:30:08] yep [17:30:10] MaxSem: I think so! [17:30:12] MaxSem: woo! [17:30:24] MaxSem: I was actually going to ask you for that later :P [17:31:47] MaxSem: ok :( [17:31:50] brion: around? [17:31:55] yo yo [17:32:12] brion: are you in the office? [17:32:23] yuvipanda: home office [17:32:35] brion: ok [17:32:48] brion: you should poke greg-g for a deployment window sometime this week for the confirmedit/core things [17:34:26] * greg-g looks around [17:34:29] * greg-g is in a meeting [17:35:07] greg-g: we need an LD window sometime this week to deploy a couple of patchsets (2 to core, 2 to confirmedit). enables account creation API [17:37:37] we must summon the lightning! [17:47:32] yuvipanda: go ahead and add the details to the wiki page, links to patchsets etc [18:02:20] hey brion! [18:02:27] hey hey hey [18:02:41] and yuvipanda! [18:07:16] hey mhurd [18:07:18] sorry was away [18:09:19] yuvipanda no worry :) [18:09:36] brion: oh i got the (controversial haha) captcha working yesterday: https://gerrit.wikimedia.org/r/109819 [18:09:50] \o/ [18:09:53] captchas are controversial? :P [18:10:14] the designers think captchas suck. which is true, they do. but they're there for a reason alas :) [18:10:31] hehe :P [18:10:43] brion: I was thinking if there's any way to securely identify the client to the serve [18:10:53] brion: then realized that if I found one, that would be the perfectest DRM ever :P [18:10:59] I'm still surprisd the commons app hasn't resulted in more dick pics [18:10:59] yuvipanda: not that can't be cracked. that's the DRM problem exactly :D [18:11:11] Reedy: dick pics go through mobile web [18:11:16] brion: yup! :P [18:11:16] lol [18:11:54] Reedy: look at the mobile web deletion rate! [18:11:56] clearly dic pics [18:12:03] Reedy: although, I think highest were sellfies [18:13:08] yuvipanda: any tips for the abuse filter story? [18:13:23] mhurd: oh a boatload, actually :P I still haven't figured it all out myself [18:21:42] awjr, I thought the scrum of scrums was at 10:30 so just a heads up I'll do the first few minutes listening while walking to the office [18:21:51] jgonera: it is, it's ok [18:22:09] the invite is for 10:25 to help people in the office get the a/v set up so we can actually start at 1030 [18:22:54] yuvipanda: is there an easy way to trigger abuse filter responses for testing? [18:23:25] mhurd: yup, I'm just commiting those actually [18:24:43] mhurd: gimme a moment, I'll just commit it [18:24:52] cool :) [18:26:00] (03PS2) 10Yuvipanda: Add AbuseFilterEditResult & a test to trigger it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109887 [18:26:06] mhurd: ^ [18:26:09] mhurd: so essentially [18:26:14] mhurd: you can trigger a 'disallow' response [18:26:20] mhurd: by writing 'poop' on any article [18:26:21] :P [18:26:22] mhurd: on testwiki [18:26:26] bahaha [18:26:29] mhurd: funnily this triggers abusefilter 'Number 2' [18:26:34] so that's someone with a fun sense of humor [18:26:40] lol [18:26:55] mhurd: you can trigger a warning [18:27:02] mhurd: by making an anon edit to any page in the User: namespace [18:27:06] again on testwiki [18:27:50] mhurd: I've a test that tries to write to User:Yuvipandaaaaaaaaaaa and fails with a warning :P [18:29:55] yuvipanda: awesomeness!!! [18:29:59] yuvipanda: thanks! [18:30:03] mhurd: yw :) [18:30:15] mhurd: oh, and remember that the 'descriptive message' returned by abusefilter is actually a HTML fragment [18:38:33] awjr, what is the url of mingle for this? [18:38:45] jgonera: https://wikimedia.mingle.thoughtworks.com/projects/scrum_of_scrums/cards/grid?color_by=status&filters%5B%5D=%5BShow+on+Wall%5D%5Bis%5D%5BYes%5D&group_by%5Blane%5D=team+dependency&group_by%5Brow%5D=team&lanes=Analytics%2CCore+Features%2CGrowth%2CLanguage%2CMobile%2CMobile+apps%2COperations%2CParsoid%2CPlatform%2CRelease%2FQA%2CVisual+Editor%2CZero&tab=Dependency+Wall [18:38:53] jgonera: also in the calendar invite [18:40:02] needs... longer... link! [18:42:34] (03PS4) 10Dr0ptp4kt: Obtain headers of response as well in case API consumer needs it. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 [18:46:03] k, yuvipanda, i uploaded the revised api patch: https://gerrit.wikimedia.org/r/#/c/109862/4 [18:46:12] (api client) [18:46:47] dr0ptp4kt: looking [18:49:04] (03CR) 10Yuvipanda: "Minor nitpicks :)" (033 comments) [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 (owner: 10Dr0ptp4kt) [18:49:07] there! [18:49:15] dr0ptp4kt: those are rahter minor, sorry if that's a bit irritating [18:49:27] I'd fix them myself but then I can't merge it [18:49:28] yuvipanda: a good friend is one who provides instruction [18:50:09] dr0ptp4kt: :) [18:50:23] hi violetto [18:50:42] brion: have a couple of patches, think you can take a look? [18:50:56] brion: specifically wanted to make sure that the abusefilter basics one looked okay before I moved on [18:52:20] yuvipanda: hey you [18:52:23] awjr, I updated https://wikimedia.mingle.thoughtworks.com/projects/scrum_of_scrums/cards/57, it's still in progress [18:52:25] hey you! [18:52:27] i mean, [18:52:29] violetto: hey you! [18:52:30] thanks jgonera [18:52:47] yuvipanda: meetingitis [18:52:58] violetto: I've none today :D [18:53:00] violetto: how many do you have? [18:53:02] jgonera: your first SoS was weird today; there were like 4 or 5 people who normally come who couldn't join since the hangout was capped at 10 people (usually it's 15) [18:53:05] :( [18:53:47] yuvipanda: 2 so far [18:53:57] violetto: how many more left? [18:54:14] yuvipanda: 2 more [18:54:28] violetto: hmm, that's about as many I have in a week [18:54:39] yuvipanda: very lucky [18:54:43] violetto: you should go on 'operation let us use email and irc for everything and not meet once a hour, maybe?' [18:55:11] yuvipanda: different teams :/ [18:56:29] awjr, hm, well, let's hope it'll go better next week ;) [18:57:19] violetto: 4 different teams in a day? [18:57:37] 3 [18:57:53] yuvipanda: but differnt group within a team [18:58:22] violetto: is that normal? do you have 4 meetings every day? [18:58:30] violetto: you must be incredibly good at context switching [18:58:51] yuvipanda: min 3 on average everyday [18:58:55] (03PS5) 10Dr0ptp4kt: Obtain headers of response as well in case API consumer needs it. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 [18:59:04] jdlrobson, should we remove https://www.mediawiki.org/wiki/Mobile_Browser_Regression_Tests#Scenario_Outline:_Enable_Images? it seems like it's not adding any info that's not elsewhere and will be hard to keep up to date [18:59:06] ^ yuvipanda [18:59:11] er, ^^^ now [18:59:20] dr0ptp4kt: heh :) [18:59:45] dr0ptp4kt: testing [19:05:00] * MaxSem smacks ApiFormatXml [19:05:09] horse poop [19:05:19] HORSE POOP [19:05:26] !!!HORSE POOP!!! [19:06:46] * yuvipanda adds that to quip [19:08:29] awjr: what happened to the deployment logs [19:08:40] are we still generating those? I'm a little confused to why the new UI is not on MediaWiki.org [19:09:59] jdlrobson: i dropped the ball on the deployment logs and haven't been posting them [19:10:15] we need to automate those :( [19:10:18] too easy to forget [19:10:18] awjr: can we get this automated, maybe generating an email to mobile-l every time a deployment happens [19:10:28] it's super confusing knowing when and what is being deployed :( [19:10:32] jdlrobson: yeah, totally [19:10:51] i don't know enough about the deployment process and how the logs generate but if you fill me in i'm happy to get this done if i can [19:10:54] jdlrobson: i should chat with Reedy and see what would be the best way to handle that [19:10:57] i *really* need this [19:11:19] Reedy: is in the office so maybe if he has time he could help me get this setup.. [19:11:50] jdlrobson, does https://www.mediawiki.org/wiki/MediaWiki_1.23/wmf11#MobileFrontend look sufficient? [19:11:51] jdlrobson: stay focussed on the work on the wall for now, i'll followup with Reedy. if i can't get it done i'll rope you in :) [19:12:53] (03PS6) 10Yuvipanda: Obtain headers of response as well in case API consumer needs it. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 (owner: 10Dr0ptp4kt) [19:12:54] dr0ptp4kt: I made minor changes. I'll just +2 them once you take a look [19:13:57] yuvipanda: so we're okay to assume junit4? [19:14:03] i guess it is 2014 [19:14:07] dr0ptp4kt: yeah [19:14:15] dr0ptp4kt: that didn't even cross my mind :P [19:14:21] (03CR) 10Dr0ptp4kt: [C: 031] Obtain headers of response as well in case API consumer needs it. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 (owner: 10Dr0ptp4kt) [19:14:37] yuvipanda: i +1'd ^ [19:14:46] (03CR) 10Yuvipanda: [C: 032 V: 032] Obtain headers of response as well in case API consumer needs it. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/109862 (owner: 10Dr0ptp4kt) [19:14:48] there we go [19:14:50] thanks dr0ptp4kt [19:16:43] yuvipanda: thank you [19:16:47] (03PS1) 10MaxSem: mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 [19:17:03] jdlrobson, yuvipanda, brion ^^ [19:18:09] MaxSem: hmm, so once this turns up, I can't really force our varnishes to cache this [19:18:11] (03CR) 10Brion VIBBER: [C: 031] "looks plausible, will test in a bit" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [19:18:22] uh-oh [19:18:32] yuvipanda: are the current responses meant to be cached for any user? [19:18:35] that would be a prob :( [19:18:36] yuvipanda, it's already not cached for logged in users [19:18:39] brion: they aren't [19:18:45] * brion hmms [19:18:49] brion: but you can force them with some api param [19:18:53] IP address blocks etc? [19:18:56] so no problems [19:19:32] brion, it will behave like web UI for anon blocks - you see it when you try to edit [19:19:40] aha [19:19:46] well that probably works then [19:19:49] ...probably [19:19:58] * brion goes to grab a sandwich, bbiab [19:20:27] MaxSem: maxage and smaxage aren't respected for logged in users? [19:20:35] jdlrobson: dude [19:21:08] yuvipanda, ApiMain should take care of this [19:21:19] MaxSem: ? [19:21:23] if not, it's a security bug:P [19:21:32] MaxSem: of what? maxage and smaxage not cached for logged in users? [19:23:09] awjr, how can I delete pages on mediawiki.org? I want to get rid of https://www.mediawiki.org/wiki/Mobile_Browser_Regression_Tests, I'm sure we won't keep it up to date and it doesn't add much value [19:23:09] i said this yesterday - an api that returns stuff based on the current user is fundamentally broken [19:23:22] provide the user as a parameter at the very least [19:23:31] jgonera: ?action=delete [19:23:36] though you may require particular permissions [19:23:54] awjr, "You do not have permission to delete this page, for the following reason: [19:23:54] The action you have requested is limited to users in the group: Administrators. [19:23:54] " [19:24:06] jgonera: i can do it for you i think [19:24:07] jgonera: poke Reedy [19:24:13] oh [19:25:43] jgonera: yeah it looks like a lot of the content on that page is covered on the QA pages for browser tests [19:25:53] and you can find our tests in the repo [19:25:58] brion: btw, we deployed Extension:MobileApp to betalabs yesterday :) [19:26:19] jgonera: ok, i am prepared to delete it - it will delete the history and everything. are you sure we should do it? [19:29:12] jgonera: in accordance with the mw.o policy on deletion, i've added a {{delete}} template to the page [19:29:16] awjr, pretty sure, setup info is in the readme in browser tests dir, the list of tests seems kind of pointless, you can just go to the features directory in the repo and everyone would have to update this page after writing a test (which would make writing tests even a bigger hassle) [19:29:20] ok [19:29:31] we're supposed to leavei t up for a week; if there is nothing contentious about deleting it, it can be deleted then [19:29:39] sounds god [19:29:40] good [19:29:45] :p [19:29:54] jgonera: https://www.mediawiki.org/w/index.php?title=Mobile_Browser_Regression_Tests&diff=893217&oldid=809728 [19:36:39] where's yurik, haven't seen him this week? [19:38:46] yuvipanda & brion, I'd like to try disabling Tidy for mobileview splitted sections - any objections? [19:39:11] MaxSem: hmm, does that mean we can't assume that individual section html will be self contained and closed? [19:39:27] kaity, is this still used: http://etherpad.wikimedia.org/p/design ? [19:40:10] yep yuvipanda [19:40:17] MaxSem: ugh, why? [19:40:25] speed [19:40:37] MaxSem: I mean, it probably won't break anything because we are adding it to the webview DOM one at a time [19:40:40] and that should self close them [19:40:47] MaxSem: hmm, how common are unclosed things anyway? [19:41:15]
== section ==
[19:41:35] tidying it actually affects display [19:41:44] how so? [19:41:48] it's just a

in a div... [19:41:52] so unless you have styles for all divs [19:42:16] okay,
[19:42:43] heh, fine [19:42:48] MaxSem: but how common is that? [19:43:36] e.g. https://en.wikipedia.org/wiki/Wikipedia:Articles_for_deletion/Log/2014_January_20 [19:43:43] hey yuvipanda, should it be ok to just show the short abuse filter msg from "info"? ie "Hit AbuseFilter: Contains poop" [19:44:06] mhurd: nope. we have to show the longer message since that is usually more informative [19:44:16] mhurd: also, users will have no idea wtf 'hit abusefilter' is :P [19:44:20] gah! good point [19:44:25] mhurd: May had a design for this [19:44:46] MaxSem: ah, hmm [19:45:04] MaxSem: honestly, I don't know. [19:45:19] so let's try it for a bit?:) [19:45:29] MaxSem: how hard will reverting be? :P [19:45:37] config change [19:46:07] yuvipanda: you mentioned the long abuse filter message was an html fragment. are you presenting it as such (within web view) or are you stripping html? [19:46:28] mhurd: yeah, i'll be using a webview [19:46:33] mhurd: they have links in them, for example :P [19:46:38] yuvipanda: ah [19:46:51] mhurd: a lot of times things like 'click here to read more' or somesuch [19:46:56] stripping out links is boo boo [19:46:58] yuvipanda: cool [19:47:01] hehe [19:48:24] mhurd: :) [19:48:28] mhurd: ask may for the design? [19:50:07] greg-g: just a FYI, MobileApp got deployed on betalabs earlier today :) On track to get deployed whenever you put it on the calendar, methinks. Thanks! [19:50:19] yuvipanda: i'll go see if she's here... [19:50:30] mhurd: ok :) [19:51:12] mhurd: https://www.dropbox.com/s/7p1wanzvsd3qdcf/Screenshot%202014-01-28%2001.33.51.png is what she got me yesterday [19:51:24] (03CR) 10Jdlrobson: [C: 04-1] Use DISPLAYTITLE when rendering pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108539 (owner: 10Theopolisme) [19:51:40] ooh nice and orange :D [19:51:51] brion: we have both disallows and warnings [19:51:52] thi sis a warning [19:52:06] brion: restyling this to be like this would be fun [19:52:11] yup [19:52:24] yuvipanda: ah cool. yeah jared just said may's remote this morning [19:52:26] (03CR) 10Jdlrobson: [C: 04-1] "Please provide more meaningful commit message - guess it should at least include mention of API" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [19:53:07] mhurd: ah, ok [19:53:13] brion: but not too hard. [19:53:22] brion: plus that code can probably be shared [19:53:24] across things [19:53:29] yuvipanda: thanks for the png! i can work with that :) [19:54:20] jgonera: only by me [19:54:51] mhurd: :) [19:54:59] mhurd: do remember that she said it is still a WIP [19:55:08] yuvipanda: k [19:55:33] yuvipanda: i'm a bit unclear on how to trigger a warning vs disallow... "poop" for disallow, but what do i do for warning? [19:55:47] jdlrobson: luckily I was wrong, "content" is used as both an ID and a class :) [19:55:47] mhurd: you try to edit a page in the User: namespace [19:55:55] kaity, does design have any kind of website/wiki page whatever which lists who's working on what? [19:55:57] mhurd: try edting User:Yuvipandaaa as an anon user [19:56:01] (03CR) 10MaxSem: "The "mobileview" string clearly indicates that it's API. And you didn't give me a card or anything when asking to do this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [19:56:04] jdlrobson, ^ [19:56:10] vbamba, ^ [19:56:29] and is Jared ever on IRC? [19:56:51] jgonera: no. I'm trying to push everyone to do it! [19:57:03] (03CR) 10Yuvipanda: [C: 031] "Untested, but seems ok." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [19:57:32] kaity, push harder [19:57:45] yuvipanda: cool! thanks! [19:57:49] mhurd: :) [20:03:22] jdlrobson, https://www.mediawiki.org/wiki/MobileFrontend/Dynamic_Sections - any need for this? seems to be pretty out of date too [20:04:21] yuvipanda: that's weird - if i edit "User:Yuvipandaaaaa" i get warning, but if i make the "Y" lower case the edit succeeds [20:04:41] mhurd: heh, the weird ways of abusefilter :P [20:04:50] yuvipanda: seems... odd [20:04:53] mhurd: I think maybe if you make it lowercase y it doesn't consider it to be a user namespace [20:04:55] or something? [20:04:59] ? hehe [20:05:00] mhurd: or might just be a bug in af [20:05:02] legoktm: ^? [20:05:08] yuvipanda: sounds buggy [20:05:17] yuvipanda: brb foods :) [20:05:23] ummm [20:05:38] :/ [20:05:44] legoktm: editing User:Yuvipandaaaa as anon triggers apparently, but not for User:yuvipandaaaa [20:05:45] let me try [20:05:54] the pages should be the same though? [20:06:15] legoktm: hmm, yeah. on the browser it just redirects me [20:06:19] let me try on my unit test [20:06:26] sorry, I gotta go afk [20:07:17] legoktm: ok [20:07:52] mhurd: hmm, I tried to edit User:yuvipandaaa and that also triggered for me [20:09:10] or not. [20:12:04] legoktm: hehe :P [20:12:10] legoktm: seems to be a false alarm, this one at least. [20:12:14] ok :D [20:38:43] (03PS3) 10Yuvipanda: Add AbuseFilterEditResult & a test to trigger it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109887 [21:07:59] rmoen: early feedback - i'm finding the VE toolbar extremely difficult to skin to my needs due to the DOM heaviness [21:08:20] rmoen: why is the toolbar so node deep? [21:08:58] hey mhurd [21:09:03] yuvipanda: heya! [21:09:12] mhurd: did you see my messages about not being able to replicate no-warning on User:yuvipandaaa [21:09:18] jdlrobson: probably] because every component of the toolbar is a widget inside of a widget [21:09:18] they are theoretically the same page [21:09:24] yuvipanda: ya just now. lemme try here again... [21:09:31] mhurd: oh [21:09:56] jdlrobson: inside of a widget /repeat [21:10:15] rmoen: i noticed - it's /really/ difficult to style - i'm close to tears. [21:10:23] jdlrobson: https://gerrit.wikimedia.org/r/#/c/109959/ [21:10:25] jdlrobson: sorry boss [21:10:45] there were a couple of further bugs with the graphs and how they used that new history file [21:10:52] also, with how they assumed the output directory existed [21:10:59] I think that fixes them, give it a merge [21:12:55] yuvipanda: yup. same behavior i saw before - it fails on User:Yuvipandaaaaa but succeeds for User:yuvipandaaaaa [21:13:06] mhurd: are you logged out? [21:13:14] mhurd: I just tried it, I got warnings for both [21:13:19] yuvipanda: ya no login on app yet [21:13:34] lemme check a couple things... [21:14:26] mhurd: ok [21:17:11] yuvipanda: ok something else is going on because *both* sets of parameters i'm passing to the server are identical... [21:17:33] hmmm [21:17:42] mhurd: according to mediawiki, User:Yuvipanda and User:yuvipanda are pretty much the same thing [21:17:50] mhurd: case insensitive for the first character [21:18:01] mhurd: by 'case insensitive' we mean 'it is always uppercased' :) [21:18:45] i think i confusing correlation with causation. [21:18:53] mhurd: oh? [21:19:14] mhurd: maybe your edit didn't say poop one time and said poop the other time? [21:19:44] yuvipanda: ya silly mistake on my part - if you get a warning back it doesn't save, but if you resubmit, the next time it does [21:19:54] yuvipanda: is that correct? [21:20:33] mhurd: oh yeah, it does [21:20:40] mhurd: that's why it is a warning and not a block [21:20:43] yuvipanda: yes [21:20:54] mhurd: yeah, so it is proper behavior [21:21:36] yuvipanda: so i think i got a warning, then went to lower case "yuvi", then no warning, so i thought lower case wasn't triggering warning, but it wasn't triggered because we'd already been warned [21:21:45] mhurd: hah! yeah [21:21:55] hehe oh boy [21:22:00] mhurd: although this is not how most web APIs behave, but this is mediawiki... [21:22:08] :) [21:22:19] mediawiki! it's crazy [21:22:26] don't let it bite you! [21:22:32] hahaha [21:22:41] it may be contagious [21:22:48] brion: I've been using LightTable for LESS/JS [21:22:52] brion: seems pretty decent [21:22:54] milimetric: graphs still are not updating :( [21:22:58] brion: has decent vim bindings too [21:23:13] brion: I have visions of a nice gadget/userscript writer that plugs into LightTable [21:23:22] REPL with JS on Wikipedia?!?!!! [21:23:40] oooooh [21:24:41] right, jdlrobson, hence the patchset [21:25:02] it was assuming a bunch of sort of silly things that were throwing exceptions [21:25:13] but those exceptions were swallowed [21:25:30] mhurd: for now we can just reuse the same css as the page content [21:25:32] and restyle later [21:25:34] hm, now we should probably wipe the history.json file [21:27:13] yuvipanda: maybe we could set aside some time next week to sync up on the css / js? [21:27:23] mhurd: yeah, sounds fine [21:27:43] mhurd: I already spent a day last week separating it all out, componentizing it, and cleaning it up :) [21:27:51] seriously. Styling the VisualEditor toolbar is near impossible [21:28:21] yuvipanda: cool. i imaging most of our sync time will be you showing me around what you've got :) [21:28:36] mhurd: however, for CSS we will both have to build some sort of mechanism that takes the CSS from a network request and then caches it agressively [21:28:46] mhurd: Extension:MobileApp is getting deployed to production in a week or so [21:28:47] :) [21:29:06] mhurd: so we will ship with a copy of styles and js, but then once a day or so we will need to fetch an updated version and cache it again [21:29:54] nice! is it set up to allow for common js / css to be shared ios-android, but also with ability to specify platform specific overrides for each for css / js? [21:30:06] (03PS1) 10Jdlrobson: WIP: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [21:30:13] mhurd: yup :) [21:30:17] mhurd: pretty much [21:30:17] yuvipanda: woohoo! [21:30:30] mhurd: and since it is LESS, we don't even need to rewrite it. Just set some LESS variables and we are good [21:30:49] (03CR) 10jenkins-bot: [V: 04-1] WIP: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson) [21:30:54] yuvipanda: i'll need to poke around LESS - haven't played with yet [21:31:09] whoa light table is gonna take some getting used to [21:31:18] yuvipanda: will do so before we sync up [21:31:23] brion: install the vim plugin! :D [21:31:29] mhurd: it's fairly simple if you know CSS [21:31:32] just some extra nicities [21:31:34] :q! :) [21:31:38] brion: :D [21:31:52] yuvipanda: cool. should be pretty straighforward then [21:32:12] mhurd: I am also using browserify on the client side. we'll have to split the JS clientside and serverside and load them differently. Should be interesting. [21:32:21] mhurd: do read up on that too, if you feel like :) [21:32:26] browserify + commonjs modules [21:32:37] yuvipanda: will do [21:32:41] mhurd: :) [21:34:39] (03PS1) 10Cmcmahon: Add a short pause for notification to disappear [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110068 [21:37:33] (03PS2) 10Cmcmahon: Add a short pause for notification to disappear [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110068 [21:42:43] (03PS1) 10Jdlrobson: QA: Add tests for Story 1609 captcha refresh [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110078 [21:42:45] (03PS1) 10Jdlrobson: Story 1609: Push captcha refresh to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110079 [21:42:46] milimetric: whens a good time for me to help you out with bingle stuff? [21:43:04] jdlrobson: http://mobile-reportcard.wmflabs.org/#edits_daily-graphs-tab [21:43:18] just clear your cache jdlrobson, limn doesn't cache-bust urls that go through its proxy [21:43:25] (it's a known bug that's filed) [21:43:27] yuvipanda: another question - i see "abusefilter-warning/userpage_edit" - does "abusefilter-disallowed" have error sub-types too? (like the "/userpage_edit" part of "abusefilter-warning") [21:43:28] ? [21:43:36] in other words, graphs are back [21:43:40] wow cache issues [21:43:42] but you gotta clear cache [21:43:43] i see :) [21:43:43] mhurd: possibly. I haven't encountered any [21:43:56] yuvipanda: k thx! [21:43:57] mhurd: I only use the part before the / though. -warning is ignoreable, -disallowed is not [21:44:02] thanks milimetric [21:44:08] awjr: when do you have time? [21:44:11] brion: reminder about deploying things [21:44:19] i'm free anytime [21:44:23] milimetric: how's now? [21:44:26] k :) [21:44:28] yuvipanda: snds good [21:44:46] awjr: batcave: http://goo.gl/1pm5JI [21:44:49] mhurd: although I'm not fully sure. You could perhaps look through the AbuseFilter code [21:44:56] mhurd: alternatively, bug someone from the web team :P [21:45:01] mhurd: they just finished dealing with this [21:45:08] mhurd: easier for you to do the bugging since you are in the office! [21:45:13] hehe [21:45:26] kaldari: gonna review your story 1620 patch next just as an fyi [21:45:33] jdlrobson: the cache stuff wasn't the only issue, but it didn't help [21:45:43] mhurd: but I think that's a good idea anyway. [21:45:55] mhurd: they just went through this, so.. :) [21:46:15] yuvipanda: will do [21:46:24] mhurd: and email out notes! [21:46:28] k [21:47:01] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=60542 [21:47:28] milimetric: https://wikitech.wikimedia.org/wiki/Bingle [21:48:57] milimetric: https://github.com/awjrichards/bingle [21:51:23] milimetric: /data/project/bingle/bin/bingle-analytics [21:53:25] yuvipanda: hey, who all from your team has deploy rights/ [21:53:26] ? [21:53:38] greg-g: afaik, MaxSem and kaldari and awjr [21:53:54] greg-g: for some definition of 'my team' - they all are part of mobile web, which is sortof the same team but not really. [21:54:01] k, would one of them be willing to pull the trigger on deploying MobileApps? [21:54:03] greg-g, jgonera is also applying ATM [21:54:08] heh [21:54:10] greg-g: MaxSem agreed to do it [21:54:10] greg-g: and jgonera [21:54:25] wait, he is? [21:54:40] oh, "applying" I read "deploying" [21:54:41] heh [21:54:59] heh, I also read it the same way [21:55:05] whew, not just me [21:55:13] I should apply at some point in the near to mid future. I got trained, even! :P [21:55:17] yuvipanda: alright, I'll add that on the calendar, I'm just making the cal for next week now [21:55:21] yuvipanda: yessir [21:55:22] greg-g: wheee! [21:56:30] thanks greg-g :D [21:56:36] yuvipanda: heh i just now got back to keyboard :D [21:56:48] middleman cut out ;) [21:56:49] * yuvipanda pokes brion about the confirmedit/account creation thing :P [21:57:02] mhurd: violetto https://www.dropbox.com/s/jcz38cxtx9xwbzd/2014-01-28%2021.56.24.png :) [21:57:23] greg-g: do you have our core + ConfirmEdit changes for the captcha scheduled? [21:57:34] i'll pull up the change sets ... [21:57:45] ... don't think so [21:57:51] ok lemme pull em up [21:59:29] milimetric: /data/project/bingle/ [21:59:29] shit, I need to sleep [21:59:31] night [21:59:33] folks [21:59:41] brion, do we want them on wmf10 or wmf11 would suffice? [21:59:42] greg-g: https://gist.github.com/brion/8677364 [21:59:51] MaxSem: when do they go out? [22:00:01] yuvipanda, yeah, I got trained too and I'm beginning to forget what I learned so I better deploy something under someone's supervision soon ;) [22:00:02] yuvipanda, so... https://gerrit.wikimedia.org/r/110087 ?:) [22:00:08] i know yuvi's raring to go so on wmf10 preferred if possible [22:02:57] brion, same question to you re https://gerrit.wikimedia.org/r/110087 [22:03:21] MaxSem: as long as it doesn't break the section breakdown, i think that won't explode [22:03:41] if we get misbalanced bits of html, the browser's parser should fix them up on insert [22:03:54] it won't break it cause things get tidied after breaking up [22:04:11] yuvipanda: i talked to jon and emailed mobile-tech [22:04:19] mhurd: whee [22:04:20] nice [22:04:42] commit message: "thingy" [22:10:05] so, it looks like all the right people did reviews on those changes, brion. so, what do you want? ;) ie: when and where (wmfXX)? [22:10:35] woohoo! [22:10:44] greg-g: what's the calendar look like? [22:10:53] i'm a bit fuzzy on which branches are live [22:10:58] * greg-g nods [22:11:16] greg-g, LD them? [22:11:16] as of right now, 10 and 11 are active, wikipedias on 10, all else on 11 [22:11:24] MaxSem: I'm wary of those for an LD [22:11:29] hmm [22:11:45] do they need to go out Right Now(TM) or can they wait until, eg, Monday? [22:11:53] (so they get announced on Friday) [22:11:56] (and in TechNews) [22:11:58] now would be great, but monday would be ok [22:12:19] as long as we know when to target and , thus, when to start on the create account feature that needs it :D [22:12:22] and yes we'll need on wmf10 [22:12:37] * brion looks at yuvipanda :) [22:12:53] oh, as in, this is just the backend needed stuff but the mobile app part isn't done yet? [22:13:00] right [22:13:00] wmf10 will be dead by then [22:13:02] * greg-g nods [22:13:07] ok then just wmf11 if deploying then \o/ [22:13:10] keeps life simpler [22:13:12] :) [22:13:27] you'd want it everywhere all at once? [22:13:40] if possible, but we only need it on *wikipedia (including test) [22:13:41] it will already be in wmf12 [22:14:05] right, those things are auto-branched, to the best of my knowledge (just ConfirmEdit and core, right?) [22:14:07] so wmf11 which on Monday will be on WPs is what's needed [22:14:25] * greg-g nods [22:14:25] k [22:14:28] ok [22:14:47] 2pm pacific? [22:15:07] works for me [22:15:17] MaxSem: I assume you're doing it? [22:15:22] we'll have a kickoff then [22:15:29] d'oh timing :D [22:15:36] stupid calendars [22:15:59] jgonera, have you already submitted? [22:16:00] MaxSem: 3? [22:16:10] WFM [22:16:27] \o/ [22:17:12] coolio, adding now [22:17:33] MaxSem, shell access request? yes [22:17:57] cool - so you'll be able to break^W deploy [22:19:48] jgonera, ^ [22:20:09] yep, soon marktraceur [22:20:12] MaxSem [22:20:24] * marktraceur waves [22:20:41] * awjr waves back [22:20:45] (added) [22:21:46] (03CR) 10Jdlrobson: [C: 032] Story 1620 (part 2): Promote LeftNav Signup A/B test to Stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109022 (owner: 10Kaldari) [22:21:55] (03CR) 10Jdlrobson: [C: 032] Story 1620 (part 1): Update leftNav Signup A/B test for new schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109012 (owner: 10Kaldari) [22:22:34] (03Merged) 10jenkins-bot: Story 1620 (part 1): Update leftNav Signup A/B test for new schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109012 (owner: 10Kaldari) [22:23:04] (03Merged) 10jenkins-bot: Story 1620 (part 2): Promote LeftNav Signup A/B test to Stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109022 (owner: 10Kaldari) [22:27:40] (03PS3) 10Jdlrobson: QA: Add a short pause for notification to disappear [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110068 (owner: 10Cmcmahon) [22:27:46] ^ chrismcmahon QA: prefix ;-) [22:28:06] jdlrobson: /me headdesks [22:28:23] jdlrobson: you're looking into VE in a mobile view, yes? [22:28:27] chrismcmahon: i'm getting a huge backlog of QA patches i could do with some review on.. [22:28:30] https://gerrit.wikimedia.org/r/#/c/109451/ for example [22:28:36] as a precursor for VE testing [22:29:04] jdlrobson: will do, I have to finish up one thing in the next 30 minutes or so [22:29:37] thanks :) [22:29:46] (03CR) 10Jhall: [C: 031] QA: Add a short pause for notification to disappear [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110068 (owner: 10Cmcmahon) [22:41:06] (03Abandoned) 10Jdlrobson: Remove whitespace within UserProfile boxes on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108173 (owner: 10Jdlrobson) [22:41:12] (03Abandoned) 10Jdlrobson: Hygiene: Style the styleguide to look like more like mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106316 (owner: 10Jdlrobson) [22:48:44] (03CR) 10Jdlrobson: Beta Feature: Register mobile skin, offer users the ability to change it (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [22:48:56] (03PS12) 10Jdlrobson: Beta Feature: Register mobile skin, offer users the ability to change it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 [22:52:02] yuvipanda, out of curiosity, are the Android apps developed right now compatible with Android < 4? [22:54:51] (03PS2) 10Jdlrobson: Hygiene: Don't use content_wrapper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109319 [22:55:00] (03PS3) 10Jdlrobson: Hygiene: Don't use content_wrapper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109319 [23:00:38] jgonera: we're intending to make the new app run on 2.3 and higher (2.3 is still a fairly large chunk of the pie) but at the moment it doesn't in-development, we need to do some tweaks [23:01:12] brion, interesting, that might be quite an effort... [23:01:39] a google compatibility library gives us most of the new UI controls [23:01:45] but there may be a few things that are painful yes :D [23:01:57] brion: oh, any time to poke the captcha patch? (https://gerrit.wikimedia.org/r/#/c/109819/) [23:02:05] oh yeah moment [23:02:16] cool! [23:11:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] "It woooorks :D Two main problems I see:" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/109819 (owner: 10Mhurd) [23:11:33] mhurd: i noted a couple issues in there which you can fix up later [23:11:40] but it works :D [23:13:16] Reedy: what generates https://www.mediawiki.org/wiki/MediaWiki_1.23/wmf11? [23:13:58] tools/release make-deploy-notes/make-deploy-notes [23:14:12] thanks Reedy - how does it get run? do you just do it manually? [23:14:24] Yeah [23:14:37] There's a wrapper in there to do the uploading etc [23:14:43] cool [23:15:17] Reedy: would you be opposed to augmenting the data on that page, a la https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2013-12-12, or alternatively running a second script to generate something like that? [23:15:40] brion: yay! i'll make a note of issues :) [23:15:45] brion: thx! [23:16:24] brion: oooh good points! [23:16:29] kenanwang_: jdlrobson: is something like https://www.mediawiki.org/wiki/MediaWiki_1.23/wmf11#MobileFrontend sufficient for our deployment notes, or do you need more info ilke we'd been doing with https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2013-12-12? [23:19:03] this looks sufficient but the other format would be nice :-) [23:28:00] yuvipanda: yt? [23:42:02] awjr: i think the 2nd format is much nicer but then i'm biased [23:42:12] :) [23:42:21] awjr: mostly because it forces a convention for commits\ [23:42:55] jdlrobson: once i sort out these bingle issues im going to take a look at the tool that sam uses and see if it would be trivial to link ours up. i dont want to add more overhead for him, but it may be easy to smoosh them togetehr [23:53:50] brion: yuvipanda: is it just me or does it seem like a pain to have to use a webview to show abuse filter warnings because they may contain html? [23:54:26] mhurd: here's what i'd consider: [23:54:34] convert from HTML to NSAttributedString if possible [23:54:41] then use a native UITextView or whatever [23:54:44] UILabel? [23:54:47] whichever widget [23:55:12] all we're likely to have is like bold and underline and *maybe* a link [23:55:51] hmm... can u point me to a list of these possible warning messages? [23:56:05] to see what i'd be getting in to haha [23:56:18] heh lemme see [23:56:46] oh good god [23:56:52] these may be even horrider [23:56:57] hehe uh oh [23:57:01] https://www.google.com/search?q=wikipedia+abusefilter+warning+messages [23:58:20] i'm confused [23:59:10] i think some of those messages get shown as warnings [23:59:13] i'm not really sure exactly