[00:01:23] brion: did u see may's comments about some of the abuse filter messages referring to desktop interface element locations which won't be present on app? https://trello.com/c/PKaAEAUT/28-5-as-a-mobile-app-editor-i-want-to-be-notified-if-my-edit-was-caught-by-an-abuse-filter-so-that-i-can-make-the-appropriate-chang [00:03:49] bleauuughhhhghghgh [00:03:53] that's going to be fun to deal with [00:04:06] jdlrobson: yeah, looks like diff-thank in MobileWebClickTracking is the only way to do it. [00:04:29] brion: yah. sounds like rather than creating work-around with web-view or attributed string, we need clean versions of these messages... [00:04:34] jdlrobson: but that doesn't really give you a comparison with desktop [00:05:08] as the numbers in the Echo logs are for both desktop and mobile [00:05:25] you could be clever and subtract one from the other [00:05:38] but I don't see a clean way to do it [00:06:41] brion: should i just show the terse "info" part of the abuse filter response for now until we get the verbose warning stuff sorted out? [00:07:16] yeah let's start there [00:07:50] jdlrobson: You could also add eventSource info to the Thanks Echo logging [00:08:32] brion: so based on may's findings and pesky html, should i create card for "clean no-html abuse filter warnings"? is that even something we could expect to be ready in time? [00:09:08] mhurd: i would not expect that to be ready in time but we should consider how to make it gradually available [00:09:18] there'd be a lot of rules to update in a lot of languages to improve their warnings [00:09:31] that's community work; we have to see if we have to provide them tools to do it [00:09:46] brion: ah [00:10:54] jdlrobson: Looks like it should be setting the eventSource as 'mobilediff' if you haven't already figured that out [00:12:04] andrew g. is gone, who can i ask about abuse filter consequences? [00:14:18] violetto: i don't know :( [00:14:45] violetto: how did you get that link to show the actual message? [00:15:19] i click on one of them and sometimes when you scroll down, you'll find a button that says preview filter message [00:15:30] violetto: ah! thanks! [00:16:22] mhurd: np! [00:27:44] rmoen: Why does VE parse thumbnails into figure elements (and then reproduce the Vector skin styles to make it look the same as Vector). This makes it a pain to make them look right in skins besides Vector. [00:30:53] Seems like it would be much easier to just parse them the same as normal and let the existing skin styles apply themselves. [00:48:52] (03PS1) 10Cmcmahon: Merge "Story 1620 (part 2): Promote LeftNav Signup A/B test to Stable" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110113 [00:51:18] (03PS1) 10JGonera: Make search input font size consistent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110114 [00:51:35] brion: god these are a nightmare... some of the abuse filter messages have sooooo many links, and there are a hundreds of messages... ahhh [00:53:29] (03CR) 10Cmcmahon: [C: 04-1] "I think this is a reasonable approach, but the test fails because no BetaPage is defined:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 (owner: 10Jdlrobson) [00:56:39] (03PS1) 10JGonera: Hygiene: Remove #mw-mf-page-left from menu link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110116 [00:58:07] (03CR) 10Cmcmahon: "gah, left comment on the wrong branch, meant to say this for https://gerrit.wikimedia.org/r/#/c/109011/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 (owner: 10Jdlrobson) [00:58:50] (03CR) 10Cmcmahon: [C: 04-1] "I think this is a reasonable approach, but the test fails because no BetaPage is defined:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [00:59:39] jdlrobson: did you not check in a page file? https://gerrit.wikimedia.org/r/#/c/109011/ [01:06:16] kaldari: I know there was a reason for the thumbs to be a figure. you could probably get a better answer from mooeypoo ( moriel ) [01:06:34] kaldari: ^ though i cannot remember right now [01:07:59] rmoen: any idea where the VE folks are anyway? Haven't seen them at the office and they all seem to have been away from IRC for a while [01:23:48] (03PS1) 10Jdlrobson: QA: Add browser tests for story 1610 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110117 [01:23:50] (03PS1) 10Jdlrobson: Story 1610: Promote already logged in message to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110118 [01:24:51] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove #mw-mf-page-left from menu link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110116 (owner: 10JGonera) [01:25:15] (03Abandoned) 10Jdlrobson: Merge "Story 1620 (part 2): Promote LeftNav Signup A/B test to Stable" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110113 (owner: 10Cmcmahon) [01:25:27] (03Merged) 10jenkins-bot: Hygiene: Remove #mw-mf-page-left from menu link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110116 (owner: 10JGonera) [01:26:29] (03CR) 10Jdlrobson: [C: 032] Make search input font size consistent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110114 (owner: 10JGonera) [01:27:04] (03Merged) 10jenkins-bot: Make search input font size consistent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110114 (owner: 10JGonera) [01:28:20] (03CR) 10Jdlrobson: [C: 032] QA: Add a short pause for notification to disappear [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110068 (owner: 10Cmcmahon) [01:28:54] (03Merged) 10jenkins-bot: QA: Add a short pause for notification to disappear [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110068 (owner: 10Cmcmahon) [01:31:00] (03CR) 10Jdlrobson: [WIP] Allow users to adjust the font size (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 (owner: 10Theopolisme) [01:33:16] (03Abandoned) 10Jdlrobson: Optimise external link SVGs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/107740 (owner: 10Jdlrobson) [01:35:35] (03CR) 10Theopolisme: Use DISPLAYTITLE when rendering pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108539 (owner: 10Theopolisme) [01:43:05] (03PS3) 10Jdlrobson: WIP: Use MediaWiki UI buttons in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102581 [01:45:23] (03CR) 10Jdlrobson: Use DISPLAYTITLE when rendering pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108539 (owner: 10Theopolisme) [02:26:45] (03PS1) 10Kaldari: Story 1621: Fixing VE content area typography/design for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110122 [07:27:13] (03CR) 10Yurik: [C: 032] Add COPYING [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/107768 (owner: 10Reedy) [07:27:17] (03Merged) 10jenkins-bot: Add COPYING [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/107768 (owner: 10Reedy) [07:40:08] violetto: around? [07:40:10] brion: around? [07:40:20] yuvipanda: she's here [07:40:33] violetto: since when has she started talking in third person? :P [07:41:10] yuvipanda: since right about now! [07:41:24] violetto: she sounds fun! :P [07:41:40] violetto: so monte just wants to display the short 'info' string from AbuseFilter [07:41:43] yuvipanda: she can be! [07:41:51] violetto: but that only says things like 'Hit AbuseFilter: contains poop' [07:41:54] short info string? [07:42:00] which is all sorts of eugh :( [07:42:38] violetto: https://dpaste.de/Nn8u brion and monte conversation from earlier [07:43:14] yuvipanda: /reading [07:43:19] violetto: ok [07:45:27] oh okay. so along the same thought as brion, we talked about logging a bug with character count limit so the community can help us with that. [07:46:27] violetto: right, so what I was thinking of was letting the community control which content gets shown to apps and which ones get shown to desktop [07:46:44] yuvipanda: im going to send you a comp that was the result of our convo and talking to the design team and andrew, etc etc. hang on [07:46:50] violetto: hmm, ok [07:46:57] yuvipanda: actually i'll need about 10 mins on this [07:47:03] violetto: ok! [07:47:18] it can solve some of the problems with what we have currently before we log a bug for it [07:52:02] violetto: hmm, I'm curious. Because I don't think the bug is too hard to solve [07:52:12] violetto: with community goodwill, at least [07:52:14] * yuvipanda looks at legoktm [07:53:48] violetto: there are only 36 enabled abusefilters on english wiki that result in a warn [07:53:55] violetto: that's just a few hours of work to fix them all up [07:54:11] yuvipanda: https://www.dropbox.com/s/9klgapqe9rk4xn5/Screenshot%202014-01-28%2023.57.44.png [07:54:38] yuvipanda: yep, i mean this comp will work either way [07:54:46] but i agree it should be solved anyway [07:54:53] violetto: we don't actually need to do anything for 'tag' [07:54:59] violetto: we only care about 'warn' and 'disallow' [07:55:07] violetto: with 'warn' you get to submit again. [07:55:15] violetto: with 'disallow' there's no submitting with the same content again [07:55:22] violetto: tag is just for RC patrollers, doesn't matter to the user [07:55:35] violetto: I think we can ignore tags? [07:55:44] yuvipanda: if i knew next to my edit will be a tag on the article history, i'd like to know the fact. But either way, there's still going to be a warning to the users that they will be tagged right [07:55:57] violetto: there isn't one on desktop afaik [07:56:33] yuvipanda: oh reals? [07:56:35] :S [07:56:44] violetto: yeah, I am pretty sure. [07:57:15] https://en.wikipedia.org/w/index.php?title=Special:AbuseFilter&sort=af_hit_count&limit=100&asc=&desc=1 [07:57:25] go to filter 11 [07:57:39] which has the "Tag" consequence [07:57:42] violetto: select 'hide disabled filters' as well :) [07:58:08] preview the message, that message will be shown to users right? [07:58:08] violetto: https://en.wikipedia.org/wiki/Special:AbuseFilter/11 you mean? [07:58:14] violetto: yeah, so that is a result of the 'warn' [07:58:19] violetto: so we will get back a 'warn' [07:58:26] I don't think tag is even reported in the API [07:58:30] since it is a purely server side thing [07:58:53] violetto: so what happens here is, you are warned first, but if you decide to go ahead anyway, it will be tagged in the logs [07:59:32] yeah, so within the warning, you'd see AF comp on the left [08:00:06] yuvipanda: from there, if user decides to proceed, they will get tagged, jsut like we warned them [08:00:26] violetto: yeah but warn and tag are independent [08:00:31] violetto: you can have tag without warn and warn without tag [08:01:09] violetto: and if it is 'disallow' there is no 'done in good faith, go ahead' possibility. They *must* go back and fix it [08:01:20] yuvipanda: yep [08:01:21] violetto: you should forget about 'tag' at all, and just do 'warn' and 'block'. [08:01:34] yuvipanda: oh i see [08:01:45] violetto: warn and block are the only things that result in user facing messages [08:01:57] i might not have gotten abit confused [08:02:02] *might have [08:02:12] yuvipanda: yep [08:02:16] violetto: don't worry, AbuseFilter is confusing as fuck [08:02:29] i imagine warn is orange block is red [08:02:46] cus block is more severe than the other [08:03:43] violetto: warn and disallow you mean? [08:03:58] violetto: 'block' is also used in some wikis, but they literally block your user account from making any further edits [08:04:01] warn allows you to save anyway [08:04:11] disallow, doesnt? [08:04:19] yuvipanda: i see [08:04:30] violetto: yup. warn allows you to save anyway. disallow does not [08:05:43] check the link i sent you again [08:06:46] violetto: doing [08:07:09] violetto: where is the 'go back and fix this' CTA? [08:07:15] violetto: that should be the primary action on both of them, no? [08:07:20] the back button [08:07:23] violetto: rather than just 'go ahead, hit save again' [08:07:47] violetto: that doesn't seem... important enough? Most people when seeing this will just hit 'save anyway' [08:11:05] typically the progressive button has a filled background. In this instance, I'm leaving it out to place the same emphasis to leave it to users to make that decision. I'm kinda torn to put it on the right/left. On left because you're literally going back to fix it. I originally had it on the right but i wouldn't have a problem with it if on the "warn" instances, you get [save anyway] [go back and re-edit] and on disallow [go [08:11:22] do a test and see how people react to it [08:11:55] violetto: hmm, maybe we could have a two line thing there - 'go back' and 'save' buttons? [08:12:15] err [08:12:17] two button thing? [08:12:26] on two lines even? [08:12:59] yuvipanda: https://www.dropbox.com/s/oyy76gs4ljoodoa/Screenshot%202014-01-29%2000.16.40.png [08:13:32] yuvipanda: that wouldn't be necessary [08:13:34] violetto: I like that better, but 'Oops' makes no sense :| [08:13:41] violetto: also no affirmative actionms on top left [08:13:44] on Android at least [08:13:53] violetto: why not? [08:14:04] we can try this first and get feedback. Those things are placeholders, including the additional text that isnt in the template [08:14:04] violetto: nothing in it tells me I need to hit the back button and fix it [08:14:15] violetto: we can try the two buttons thing first and get feedback :P [08:14:31] two buttons thing? [08:14:31] if people say 'I already know I have to hit back! that is just clutter!' we can remove it? [08:14:48] violetto: one to say 'go back and fix it' and one to say 'this is constructive, go on' [08:15:51] (03PS4) 10Dr0ptp4kt: Slide the keyboard down on search result item tap. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109504 [08:16:15] (03CR) 10Yuvipanda: [C: 032 V: 032] Slide the keyboard down on search result item tap. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109504 (owner: 10Dr0ptp4kt) [08:17:58] yuvipanda: we have a system going and if we ever want to break it, it has to happen on a very strong reason and have proven that nothing else worked that made that a necessary move. there's space on the right to make that happen, plus, it already exists and reusing what we have across web and web mobile is always great [08:18:12] violetto: err, what? [08:18:19] violetto: that entire sentence made no sense to me :| [08:18:22] violetto: what system? [08:18:31] violetto: what space on the right? [08:18:35] I... am so confused [08:18:49] [destructive action] Context [Progressive/Constructive action] [08:19:03] top nav [08:19:24] violetto: yeah, sure. but not on the ActionBar. Imagine if I started having desktop style 'menu' on top of every web page with the same argument. [08:19:58] yuvipanda: not sure what you mean, draw something for me! [08:20:02] violetto: plus reuse here doesn't seem right to me - I would have to go completely against the actionbar code, redo it all just do do this one thing [08:20:06] violetto: ok wait [08:23:34] violetto: I only had preview to work with, so ignore the colors. And ignore the exact text as well. http://imgur.com/EiMz14l [08:24:33] yuvipanda: oh for sure we can do that [08:24:38] violetto: :P [08:24:43] violetto: that's all I was trying to say [08:24:45] yuvipanda: i thought you were talking about messing with top nav bar [08:24:53] putting 2 buttons on the left [08:25:09] violetto: I only want it to not say 'Oops', primarily because our translators will have no idea [08:25:13] violetto: other than that it looks ok to me [08:25:16] violetto: heh, no. [08:25:33] yuvipanda: oops area can be "warning," etc [08:25:43] violetto: yeah, we can figure out exact text later on I think [08:25:48] Reason why it's not "warning!" because it's repeated on the body copy [08:26:13] violetto: right. I don't mind putting 'oops' there either, just be warned that the langeng team will probably poke me and ask me to change it [08:26:22] POOPS! [08:26:28] violetto: hahaha! :P [08:26:45] haha. [08:26:49] violetto: also, I thought *you* were talking about messing with the top nav bar :P [08:26:53] violetto: anyway, it's settled now :P [08:27:19] ok so on block and disallow consequences, there isn't a "submit anyway" button, correct? [08:27:23] violetto: can you update your mockup to have the 'two buttons' but with better colors? [08:27:28] violetto: yup, no 'submit anyway' [08:27:32] violetto: submit anyway only for warn. [08:27:36] others don't have submit anyway [08:27:40] only 'go back and edit' [08:27:40] in that case just "make changes to my edit" [08:27:47] violetto: yeah, seems fair enough [08:30:06] yuvipanda: ok koo [08:30:15] violetto: what's 'koo'? [08:30:53] haha in australia that's how i said "cool" [08:31:09] totally brought my memories back when andrew was around [08:32:18] violetto: hahaha! :D [08:32:18] violetto: right [08:32:36] violetto: I thought working with abusefilter has added words that sound like 'poop' to your vocabulary :P [08:32:45] violetto: can you update the mockup? [08:35:34] yuvipanda: completely possible [08:35:41] yeah im sending them over soon [08:35:45] violetto: wheee! [08:41:18] yuvipanda: updated trello :) [08:41:31] violetto: wooo! [08:41:33] violetto: nice [08:41:37] assets and all [08:41:48] violetto: looking [08:42:37] violetto: no CTAs for the 'warn'? [08:43:16] on the top nav, i think it's great that it's repeated for disallow at the bottom though [08:44:05] violetto: there's nothing at the bottom for warn? [08:44:18] violetto: so without reading the full thing, I don't know what actions I can do [08:44:42] violetto: this is what I drew on the image, no? The actions you can do for warn (back and edit or continue) being more prominent? [08:44:50] violetto: the edit pencil says mostly nothing at this point. [08:45:23] violetto: I drew the extra button on the disallow, should've done two buttons on warn and one on disallow. [08:45:28] violetto: that's the 'two buttons' I was talking about [08:46:32] yuvipanda: it wouldn't hurt putting it down there. the top nav is persistent and it means edit, that's how they even got into editing right, they already got the concept and not to mention it's highlighted. and by now they have already been using the tick to mean go ahead, I want to submit my edit [08:46:51] violetto: yeah, but you have to fully read the entire thing to figure out what actions you can do, no? [08:47:03] i took out the submit anyway because we just said it wouldn't appear on disallow, right? [08:47:09] violetto: so after the bright large context clues for 'hey, warning!' you sitll have to read the stuff [08:47:17] violetto: yeah. disallow looks perfect [08:47:20] violetto: just talking about warn here [08:47:26] violetto: but let's just put it down there as well? [08:50:22] yuvipanda: either way the highlighted next action is very emphasized, it's not going to do any harm to us or them. if you worry that they tap on re-edit without reading the text, we can make it so it highlights only when user is half-way scrolled down. like i said, in this event, i don't have a strong opinion about not repeating at the bottom. i'm only thinking about including sufficient amount of actions/text. [08:50:30] so sure, we can include it [08:50:56] violetto: let's include it. I also don't think the 'edit' action on top should be highlighted in any way - it should just have the usual actionbar styling [08:51:38] I mean, the 'back' would also be styled as Android's back, rather than the big iOS-like one we have on the mockup [08:51:59] violetto: can you add the bottom actions repeated in the mockup too? [08:52:31] violetto: oh, also - the actions at the bottom, will they be 'fixed' (visible while scrolling as well) or just inline (you will have to scroll to the bottom to see them)? [08:53:24] yuvipanda: scroll to bottom to see. that's the idea right, so they go to the bottom. Otherwise they already have the top nav persistent [08:53:33] violetto: yeah, sounds ok to me [08:54:06] violetto: if the response text is not long enough to require people to scroll, do we stick these at the bottom of the screen, or at the end of the message? [08:54:46] yuvipanda: at the end of the message. [08:54:50] violetto: ok [08:54:58] violetto: also, Open Sans here as well? [08:55:10] same as content styling in terms of font size and line-spacing? [08:55:24] mhm :) [08:55:48] violetto: sweet then [08:56:31] yuvipanda: oh, we should totally do a simple animation for the flag and the other pending icon [08:56:43] violetto: easy enough, I think [08:56:45] ;D [08:57:04] violetto: let me know what you want to do :) [08:57:08] yuvipanda: ok [08:57:10] as long as it isn't too distracting... [08:57:13] btw, send me a build! [08:57:23] violetto: hah! ok [08:57:26] yuvipanda: i'll make it extra distracting [08:57:38] not too, but extra [08:57:41] violetto: make it vibrate the phone and also play a loud banjo noise? :P [08:57:50] hells yea [08:58:03] vibrate the phone until you decide to re-edit [08:58:14] violetto: :P [08:58:30] if you choose not to re-edit, it'll vibrate faster, like with the seatbelt beeper in the car [08:58:37] the more you ignore it the faster it sounds [08:58:54] violetto: sent you a build. this edits textwiki [08:58:59] violetto: *testwiki [08:59:29] violetto: you should try out the captcha. ignore the issue with the captcha size being too small, but other than that, I bet you will have plenty of issues to report :P [09:00:43] violetto: you can trigger a captcha by adding an external link [09:06:08] yuvipanda: /checkin! [09:06:28] violetto: ? [09:06:51] yuvipanda: btw, how to/when to log bug for abuse filter? [09:07:54] violetto: what bug, exactly? [09:07:57] violetto: the restyling one? [09:08:03] violetto: err, the rewording-for-apps one? [09:09:29] rewording one [10:16:27] (03PS2) 10Yuvipanda: Make CaptchaResult depend only on id [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109740 [10:16:29] (03PS4) 10Yuvipanda: Add AbuseFilterEditResult & a test to trigger it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109887 [13:48:06] grrr... experimental is still broken on Android Chrome for me. [13:48:32] sections won't open, and some other buttons don't work. [18:07:14] kenanwang_: standup? [18:08:08] brion: yuvipanda: heys! [18:08:13] hey brion [18:08:14] yo yo [18:08:43] yuvipanda: brion: so i feel abused by the abuse filter... [18:09:03] ;) [18:09:09] mhurd: haha [18:09:14] mhurd: typed 'poop' enough times yet? [18:09:23] so. many. times. haha [18:09:45] mhurd: heh :) [18:09:54] (03CR) 10Jhall: "The second (VisualEditor) scenario fails for me in beta labs because the expected VE controls are not being loaded at this URL:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 (owner: 10Jdlrobson) [18:09:55] mhurd: I might change poop to warn, rather than disallow, for a while in a bit. to test my warning filter. [18:09:58] mhurd: I'll warn you beforehand [18:10:09] perhaps i'll start typing variants of 'poop' just to keep things interesting [18:12:08] p00p [18:12:45] mhurd: :P [18:12:57] WARN ALL THE POOPS! [18:13:00] brion: you need to make an iOS build today. At leats StevenW and legoktm are waiting for it :) [18:13:07] i shall do [18:13:43] brion: :) [18:18:42] hi jdlrobson if you need to sort out what VE should and should not be doing, Rummana Yasmeen in the office is an expert on VE behavior [18:19:20] jdlrobson: I mentioned to her yesterday that you and she might want to talk about VE + Mobile view [18:27:42] mhurd: I was saying 'it is not really an Issue in Android' :) [18:28:42] yuvipanda: ah cool! [18:29:50] yuvipanda: gonna go see if may's around... [18:29:56] mhurd: heh, ok :) [18:30:00] mhurd: oh yeah, we've a meeting. [18:30:28] yuvipanda: hmmm i don't see her [18:30:40] mhurd: txt her mabe? [18:32:01] yuvipanda: she's not on the hangout either... [18:32:14] violetto: hey may! [18:32:49] mhurd: she's on the hangout [18:40:49] mhurd: http://etherpad.wikimedia.org/p/design-thingies-jan-android [18:58:07] (03PS7) 10Jdlrobson: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 [18:58:09] (03PS3) 10Jdlrobson: QA: Allow browser tests in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109451 [19:04:33] mhurd: you could also just add http:// and it will trigger :P [19:05:27] i like to add http://spam.com [19:25:18] jdlrobson: It looks like the Thanks problem isn't specific to Thanks. All Echo notifications are currently being reported as Talk page notifications for some reason. [19:25:26] yep kaldari i sent a mail out [19:25:35] didn't know the latter though :) [19:29:42] actually, that's not right either. For some reason a small amount of Talk Page notifications are still being recorded (and thus show as 100% of the notifications) [19:44:56] so, when is Special:MobileDiff going to get a Thanks button? [19:45:14] I find myself needing that feature all the time. [19:49:54] mhurd: that was fine :) [19:49:55] err [19:49:55] fun [19:50:11] yuvipanda: yay! [20:01:35] jdlrobson: Do you mind if I merge bug 60550 to bug 60555? [20:03:35] fine with me [20:04:47] (03CR) 10JGonera: Hygiene: Add proper error reporting in lead image uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109264 (owner: 10JGonera) [20:05:17] yuvipanda: i just emailed you a copy of what i'm going to email mobile-l about devoting a day or 2 per sprint to polish. could you go over it for a sec and see if it sounds ok before i send to list? [20:06:10] mhurd: ok! nothing yet tho [20:06:12] brion: hey [20:07:06] brb [20:07:15] yo [20:07:47] brion: greg reminder :P [20:07:52] greg-g: ? [20:10:14] (03PS4) 10Jdlrobson: Use MediaWiki UI buttons in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102581 [20:10:51] brion: actually, we decided we didn't need him, right? [20:10:54] dr0ptp4kt, you there? [20:11:15] yuvipanda: no idea, i thought you and max and greg worked it out already :D [20:11:26] brion: heh, yeah. so nevermind, let me just send out an email [20:11:33] :D [20:11:41] (03PS5) 10Jdlrobson: Use MediaWiki UI buttons in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102581 [20:14:18] yuvipanda: got your reply... adding your suggestion now [20:14:29] mhurd: ty! [20:14:39] brion: all the patches have been merged, right? [20:14:46] brion: can you just verify that? [20:14:49] brion: no left out ones? [20:14:51] let's find out! [20:15:05] brion: ok! [20:15:11] yuvipanda: you've got a couple on android still [20:15:11] lemme finish those up [20:15:13] brion: I can compute when they will be on enwiki once you tell me that :) [20:15:24] brion: oh, no, I meant the account creation patches [20:15:28] yuvipanda: hmm, oh that? yeah those are all merged [20:15:51] brion: ok! [20:16:01] brion: I've a biggish abusefilter patch coming up, but yeah, would be nice to get the ones out of the way [20:17:07] (03CR) 10Brion VIBBER: Make CaptchaResult depend only on id (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109740 (owner: 10Yuvipanda) [20:17:26] yuvipanda: so i would prefer not to make assumptions about the internal structure of the captcha image url [20:17:43] i don't think it's really guaranteed [20:17:44] brion: yeah, but the refresh captcha thing gives me only an ID [20:17:47] ugh [20:17:49] brion: so I will have to? [20:17:54] brion: I made this change after seeing that [20:18:05] yuvipanda: so my pref would be to fix that api to return the full captcha info :) [20:18:07] or [20:18:14] we could just string-replace the old ID from the old URL ;) [20:18:38] but as long as we're willing to make updates, we can use this assumption for now [20:18:46] as it'll hold for foreseeable future [20:18:53] brion: string replace feels dirtier to me than this [20:18:55] :P [20:18:56] and nobody seems to be maintaining it ;) [20:18:57] yeah [20:18:59] brion: yeah [20:19:00] ok i'll merge it :D [20:19:12] wait lemme test it ;) [20:19:23] :D [20:25:56] ugh i hate that single quotes don't mean "string" in java [20:26:01] brion: hehe :P [20:27:10] "Hit AbuseFilter: Removal of op-tag without rights to change the page's protection level" [20:27:13] *pp-tag [20:27:19] but.... i'm not removing any tags? wtf [20:27:56] brion: huh? [20:28:10] yuvipanda: try editing https://test.wikipedia.org/w/index.php?title=Online_editing&action=edit as an anon [20:28:13] just add some text and save [20:28:21] i get back [20:28:54] brion: should be fine, right? I've the abusefilter handling commit coming up... [20:29:08] yuvipanda: well i can't see how that should even be coming up [20:29:17] if i can't edit anything without a bogus error [20:29:34] maybe someone broke a rule [20:29:35] basile: were you editing with the app? [20:29:39] err [20:29:40] brion: [20:29:43] brion: or desktop? [20:30:02] yuvipanda: both, same error [20:30:26] brion: sounds like weird abusefilter rule to me [20:30:45] yeah, i don't see a rule that says that though [20:31:06] no wait i see it [20:32:47] ok i disabled the rule and i can edit again [20:32:49] now back to testing captcha [20:33:35] brion: heh :) [20:34:11] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I still don't like hardcoding that path, but it'll do for now until we revamp ConfirmEdit to suck less :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109740 (owner: 10Yuvipanda) [20:34:54] brion: there's also a unit test for that :P [20:35:03] whee [20:36:36] "info": "Hit AbuseFilter: Contains poop", [20:36:43] \o/ [20:37:11] yuvipanda: however what i get in logs is a java.lang.RuntimeException for "null" [20:37:18] shouldn't it report back the proper exception type? [20:37:47] brion: run the unit tests? [20:37:59] brion: wait, the unit tests are failing? [20:38:03]