[00:02:16] violetto: i added some comments to the new trello board just to start using it. ignore the fact that the comments are asking you for things i already asked you on irc ;) [00:05:21] http://www.theverge.com/2014/1/29/5359068/google-keeping-motorola-advanced-technology-group-project-ara-phone [00:05:43] bad timing brion [00:05:44] http://www.theverge.com/2014/1/29/5359068/google-keeping-motorola-advanced-technology-group-project-ara-phone [00:05:53] "Google just sold Motorola to Lenovo. Project Ara will join the Android team at Google" [00:12:35] interesting [00:18:14] Lenovo should buy up HP and Dell too [00:23:15] (03PS18) 10Jhall: QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 [00:23:19] violetto: would it be ok to meet for TOC next week? i'm running down to the wire this sprint [00:23:37] mhurd: sure! [00:24:06] thanks! [00:24:38] violetto: oh, i'll be out of the office monday too [00:25:44] mhurd: changed to tuesday. [00:25:53] violetto: cool! [00:26:12] mhurd: always for monte [00:26:17] :) [00:26:36] mhurd: you gonna be away or just ooo on mondya? [00:26:42] ooo [00:26:58] working remote [00:27:14] mhurd: i see [00:55:53] tfinc: do you have a few minutes to chat? [00:56:14] mhurd: i'm in the middle of something so it would have to be async and i'll cut off @ 5:30 [00:56:55] tfinc: ya if you have a few minutes before 5:30 let me know. if not no worry! [00:57:05] mhurd: feel free to pm me [00:58:35] Brion how can I download the android build also with test flight? [01:06:14] mhurd: --^ [01:08:03] tfinc: ah. thanks. just wanted 5 to 10 min for in-person chat about the email i sent about the trello design board. doesn't matter if today. [01:13:12] mhurd: i starred it. wont get to it today as i'm in the middle of something. lets chat tomorrow unless its super pressing [01:13:25] tfinc: np! thx! [01:13:33] tfinc: not pressing :) [01:53:10] (03PS4) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109844 [02:01:41] (03PS5) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109844 [06:41:25] Is anyone involved in further development of the TranslateWiki Android Application? [06:42:50] Might be worth asking in #mediawiki-i18n too as the translatewiki guys aren't in here [06:49:59] Is anyone involved in further development of TranslateWiki Android Application? [06:52:04] No one? [06:52:33] coderbrahmin: [10:42:51 PM] Might be worth asking in #mediawiki-i18n too as the translatewiki guys aren't in here [09:46:48] (03PS2) 10Yuvipanda: Display appropriate warning when AF returns a message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110228 [12:05:56] (03PS1) 10Zfilipin: cucumber.yml is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110351 [12:13:00] (03PS2) 10Zfilipin: QA: cucumber.yml is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110351 [12:46:19] (03PS3) 10Yuvipanda: Display appropriate warning when AF returns a message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110228 [15:01:28] (03CR) 10Cmcmahon: [C: 04-1] "On beta labs, this is failing because Edit never appears. Is it trying and failing to create a user and log in?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [15:42:59] (03PS4) 10Yuvipanda: Display appropriate warning when AF returns a message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110228 [15:43:01] (03PS1) 10Yuvipanda: Handle Captcha reload appropriately [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110379 [17:46:28] hey brion [17:46:37] yo yo [17:46:52] brion: I [17:46:55] brion: I am in a bus [17:46:59] :D [17:46:59] brion: using the regular keyboard [17:47:02] so won't be up much [17:47:04] brion: review? [17:47:06] hehe ok [17:47:07] shortly [17:47:20] brion: would be nice if you can take a look before I go out of range :) [17:48:35] moving windows around so i can get at gerrit :D [17:48:45] brion: mmm! [17:50:39] * brion waits for gerrit to fetch things [17:50:44] dum dee dum [17:52:55] brion: hehe [17:57:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] Display appropriate warning when AF returns a message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110228 (owner: 10Yuvipanda) [17:58:23] brion: woo! [17:58:32] brion: you need to send out builds tho [17:58:37] brion: also there's a captcha patch [17:58:42] yeah will do once these two merge [17:58:50] brion: woo! [17:59:12] brion: I'm going to try to get a patch in that will kill all inline styling in the AF messages [17:59:14] brion: thoughts? [17:59:57] (03CR) 10Kaldari: [C: 031] Beta Feature: Register mobile skin, offer users the ability to change it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [18:01:03] YuviPanda|bus: hmm, and just show plaintext? might work ok [18:01:16] (or at least limit it to bold/italic/link/etc) [18:01:17] brion: well, it will be structured and we will have our own styling [18:01:21] ya [18:01:30] brion: we will be rewriting enwiki at least aggressively in JS [18:02:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] "It works!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110379 (owner: 10Yuvipanda) [18:03:01] brion: wooo! [18:03:17] brion: I'll move those to ready for sign off? [18:03:39] ok' [18:05:25] heyyy milimetric|away [18:05:47] wtf is https://github.com/wikimedia/limnpy [18:05:59] and why have i been manually creating graphs all this time [18:06:09] whoever set up mobile-limn has some explaining to dpo [18:06:10] jdlrobson: because we can't install limnpy on production [18:06:22] jdlrobson: I set up mobile-limn, and it used limnpy in the beginning [18:06:31] jdlrobson: and then we got screamed at by ops and had to move to doing it manually [18:06:34] why does it need to work on production [18:06:41] why can't i generate the graphs locally using it [18:06:46] instead of copying and pasting [18:07:01] i spent yesterday seemingly wasting my time to write a script to automate that process [18:07:12] https://gerrit.wikimedia.org/r/#/c/110271/2/generate-graph.py < YuviPanda|bus [18:07:19] yeah, I saw that roll by [18:07:26] so... loud... [18:07:34] lol mhurd [18:07:35] jdlrobson: I started writing that and then was frustrated enough to just give up and go with it [18:07:44] we need to sort this out [18:07:48] jdlrobson: the original json files were all generated by limnpy [18:07:57] with this script i generated 4 graphs in 15 minutes [18:08:03] compared to the 1 hour a graph it usually takes me [18:08:16] jdlrobson: limnpy at that time also did not have a way to generate just the metadata for the graphs without giving it actual data [18:08:20] I don't know if that is still the case [18:08:26] ? [18:08:43] YuviPanda|bus: hey! [18:08:43] jdlrobson: you give limnpy csv of your data and then it generated the json files [18:08:46] hey mhurd [18:09:03] YuviPanda|bus: are you really on a bus? [18:09:06] jdlrobson: personally I've given up on limn a while ago :P I'll explore alternatives when I get some breathing space [18:09:07] mhurd: yeah [18:09:10] :) [18:09:22] mhurd: IIRC I've done standups from a bus, train, walking on the road, beach... :P [18:09:50] jdlrobson: milimetric|away can probably explain more about limnpy [18:09:53] YuviPanda|bus: from a plane? [18:10:02] mhurd: no internet planes for me [18:10:44] (03PS2) 10Kaldari: Story 1621: Fixing VE content area typography/design for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110122 [18:12:58] mhurd: the AF and Captcha reload patches got merged! \o/ [18:13:22] YuviPanda|bus: woohoo!!! :) [18:14:19] brion: mhurd I won't be around for prioritization meeting today [18:14:27] YuviPanda|bus: k [18:14:48] you need one of those google buses [18:14:55] brion: heh [18:14:59] Brion: YuviPanda|bus: did you have a chance to poke the trello board? (https://trello.com/b/Id6qXKSY/mobile-app-latest-design-assets-by-page) [18:15:10] brion: either way I can't type for more than 20s at a stretch on this keyboard :( [18:15:44] mhurd: looking it over now [18:16:07] may's going to add old assets to it so the empty cards have assets [18:16:42] yay! [18:16:57] that'll make it easier for us to argue over visual details :D and hopefully agree on them :DD [18:17:06] brion: yay! [18:17:33] (03Abandoned) 10Jhall: QA: Browser test setup via API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/106548 (owner: 10Jhall) [18:17:50] brion: mhurd idk, it still feels like more process to me. I just search email for assets and find it easy enough [18:18:22] i find it hard to refer people to "that one email that one time", here we have nice links :D [18:18:32] YuviPanda|bus: can you email me the history mockup - i can't find it [18:18:36] brion: true, hence I suggested a dropbox [18:19:05] potato potato :) [18:19:09] as long as we all know how to use it [18:19:11] hehe :) [18:19:12] true [18:19:22] mhurd: I would if GMail loaded. doesn't right now (am on 2.5G) [18:19:50] mhurd: but I'll take your point :) [18:19:55] YuviPanda|bus: need more "g" [18:20:07] ;) [18:25:35] * brion pulls out old Apple Power Mac G5 [18:25:37] is that enough G? [18:26:09] brion: ETOOMANYGs [18:26:26] * brion still misses that machine [18:26:35] it was the last hurrah of the powerpc [18:26:44] well, other than the xbox 360 and PS3 [18:26:56] brion: heh [18:27:01] brion: ALL HAIL ARM [18:27:19] dual-core 2 gigahertz! in 2005/2006? this was good stuff [18:28:04] brion: heh, still probably. if you arne't running XCode [18:28:05] but IBM couldn't keep energy usage down enough to make sane laptop chips, and Motorola couldn't bump performance up enough for good laptop chips [18:28:14] yeah [18:28:22] i gotta say though i don't miss endianness issues [18:28:31] everything's LE nowadays, x86 and arm [18:29:03] brion: ppc was big? [18:29:07] yep [18:29:27] i remember making patches to Gimp to fix some of the file format plugins for endian problems running on OSX :P [18:30:03] brion: oh wow. [18:30:16] before ppc was motorola 68000 series, which was also 32-bit big-endian [18:30:20] brion: people bitch about border-radius and flexbox not working across platforms now :P [18:30:30] the 68k->ppc conversion actually had a hybrid system where code would thunk into an emulator IN THE SAME PROCESS [18:30:43] hahaha [18:30:48] going intel needed full-process emulation cause, y'know [18:30:52] that also sounds secure? [18:30:54] :P [18:30:58] big and little endian just don't mix! [18:31:00] and fun! [18:31:14] in the 90s personal computer security was pretty shit [18:31:21] memory protection? that's for fancy pants server OSs [18:31:32] brion: :D [18:35:11] and even in them it didn't quite work;) [18:35:30] MaxSem: memory protection? [18:35:36] yup [18:35:58] MaxSem: pagetables and vmem or the 'executable' bit? [18:36:17] because in addition to having it in theory, you also needed to polish OS protection levels and fix a bunch of vulnerabilities which took some time [18:36:17] (where you can't execute data) [18:37:07] MaxSem: hmm, yeah. I remember WinXP was a huge step up from 9x :P [18:37:12] but that's just NT I suppose [18:37:31] even in 2000s, it was SUDDENLY discovered that a device connected via FireWire can dump whole physical memory of its host [18:37:37] hahaha! [18:37:45] yeah windows 9x was a lot of half-assed 32-bit stuff hacked onto win16. xp was nt, 32-bit and process isolation from the beginning [18:37:47] I wonder what kinda bug causes something like *that* to happen [18:37:53] heh [18:37:56] yeah DMA is dangerous [18:38:00] DMA offsets that weren't checked I guess [18:38:01] yeah [18:38:02] but it's SO CONVENIENT [18:38:12] can you still do that with thunderbolt? [18:38:18] * brion should be careful about what he plugs in [18:38:23] brion: I guess there's some level of protection there [18:38:24] *guess* [18:38:28] olny with Cook's permission;) [18:38:34] apple wouldn't lie to us [18:38:46] not with the prophet jobs looking over their shoulder [18:38:49] hehe [18:39:03] I wonder if an SSD controller can still do it [18:39:28] just wait for wireless PCI [18:39:49] we'll never be safe again [18:40:25] brion: heh [18:50:05] (03PS1) 10Yuvipanda: Make the transformer a proper extensible module [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110411 [18:50:06] brion: JS patches on the way! [18:50:38] \o/ [18:56:38] (03PS1) 10Yuvipanda: Clear all inline styling from AF warning messages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110414 [18:56:41] brion: okay, they are at least readable now. ^ [19:01:15] brion: so I am in a bus, and don't know how long I'll be on [19:01:20] yeah that's ok :D [19:01:33] YuviPanda|bus: Being on a boat is betterer [19:01:57] boat means satellite internet [19:01:58] that can't be good [19:02:05] brion: I bet I can hear them better only because of the video issues [19:02:10] :D [19:02:12] brion: is my voice even coming through? [19:02:16] it was [19:02:18] you're mute now [19:02:21] Reedy: heh, I'm not deploying, just developing! [19:03:25] brion: mhurd https://www.dropbox.com/s/u5wvts9b0agbjmn/Screenshot_2014-01-31-00-25-37.png is how it looks like now [19:03:28] much better than before [19:03:42] how does google talk plugin eat half a cpu? sheesh [19:04:38] brion: mhurd: YuviPanda|bus http://hatjitsu.wmflabs.org/10471 [19:05:27] tfinc: looks good to me! [19:05:39] YuviPanda|bus: thanks [19:08:59] brion: log in is in this sprint :P [19:09:19] yay solved [19:09:37] brion: I don't think I should unmute yourself. Can I speak through you? :D [19:09:50] can try :D [19:09:52] brion: :D [19:10:24] brion: the design attached to the card is weird [19:11:08] brion: was that voice clear enough? [19:11:27] yeah [19:11:44] brion: okay! I'll try that again :) [19:11:58] brion: can you turn off your video as well? :D [19:12:08] YuviPanda|bus: that better? [19:12:09] brion: woo thanks [19:12:11] brion: ya [19:12:26] :D [19:12:44] (03PS1) 10Jdlrobson: Document $wgMFAnonymousEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110420 [19:16:48] brion: i think I'm losing connectivity [19:17:01] whee [19:17:44] brion: terrible connectivity, but I estimate that 'edit current section' split up card at a '3' [19:17:52] ok [19:18:16] brion: I can still hear them, at least for now. [19:18:21] heh [19:18:37] brion: tfinc looks good to me [19:18:46] brion: mhurd YuviPanda|bus http://hatjitsu.wmflabs.org/10471 [19:20:22] brion: tfinc edit token needs to be retreived properly, stored securely, and we must make sure that we do not make an extra login bit [19:20:26] brion: tfinc I can go with a 5 [19:21:08] tfinc: I think I can take that as a card for 3 rather than a spike [19:21:18] tfinc: since I talked to May extensively about it [19:21:19] brion: ^ [19:22:54] brion: tfinc yeah [19:23:25] brion: already deployed on testwiki [19:23:27] brion: by today [19:23:31] brion: enwiki by thursday [19:23:34] next thursday [19:24:59] brion: you should do that too! :) [19:25:37] brion: tfinc should we support offline event logging? [19:25:52] brion: events that are emitted when you are offline [19:26:36] brion: kenan is breaking up just for me or for everyone else? [19:26:50] it's a little of all [19:27:36] brion: I like how me on a bus I have a slightly more reliable connection than kenan :P [19:27:43] :D [19:28:50] brion: tfinc I think the checklist there is too dense - each sentence is actually 3-4 seperate events. I think a wiki page with what exactly the events we should fire will be much better for us to work with [19:29:31] YuviPanda|bus: yeah we'll have to break out more details when we actually get to it [19:29:33] mhurd: ^ [19:29:55] but that gives us enough guidance to put an initial list together [19:30:46] brion: yeah, probably [19:31:09] brion: on 1.5G now [19:31:09] no video [19:31:12] brion: I don't even know if my IRC packets are going through :P [19:31:19] YuviPanda|bus: ok we're gonna split that one up [19:31:26] into a spike to determine exactly what we're recording [19:31:28] brion: ok! [19:31:31] and a card for actually implementing them [19:31:32] :D [19:31:37] brion: yeah, that sounds much better [19:31:41] brion: so a card for EL infrastructure [19:31:46] brion: and a spike for what to record [19:31:48] ? [19:31:50] (03CR) 10Adamw: [C: 031] Document $wgMFAnonymousEditing (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110420 (owner: 10Jdlrobson) [19:32:05] YuviPanda|bus: right [19:32:21] brion: if so, a card that is just 'implement eventlogging infrastructure' is a 2 from me :) [19:32:27] :D ok [19:32:47] brion: I'm giving up on the hangout [19:32:51] ok [19:32:57] brion: and I think the remaining stories are iOS only (TOC on Android is probably going to keep its simple skin for a while) [19:33:16] brion: just like how we are experimenting with the edit UX on android, we could experiment with the ToC on iOS [19:33:20] ok. i might do a weekend experiment on crazy ui just for fun ;) but i might do something on glass instead [19:33:41] brion: Android's JS is much more mature, so easier to do the Editing experiment. Same for iOS and ToC [19:33:49] spiff [19:33:49] brion: hehe :D [19:33:54] brion: yeah [19:34:37] brion: yeah, just mention that ToC experimentation should happen purely on the iOS side for now :P [19:34:55] ok :) [19:35:01] hangout is now over [19:35:55] brion: wheee! I only missed about 5 minutes, so not bad at all! [19:36:05] brion: now code review? :P [19:36:20] :D [19:36:38] * brion remembers something about transformers [19:36:42] robots in disguise? [19:37:12] brion: heh, maybe I should name transformers that remove DOM elements to be Decepticons :P [19:37:27] lol [19:37:58] brion: but yeah, so now that I've done this separation, that means that I can move transforms.js eventually to Extension:MobileApp [19:38:03] brion: and then it can be served dynamically [19:38:06] brion: and 'just work' [19:38:13] sicne it registers with transformer, which is local [19:38:14] yessss [19:38:16] i likey [19:38:18] brion: so as long as the API fits, it will work [19:38:27] if the api fits, wear it! [19:38:32] brion: iOS has a bit of catching up to do here :P [19:38:37] brion: idk how much JS there is in iOS [19:38:57] brion: I still need to make links from there work [19:39:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make the transformer a proper extensible module [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110411 (owner: 10Yuvipanda) [19:42:54] (03PS3) 10Jdlrobson: Hygiene: cucumber.yml is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110351 (owner: 10Zfilipin) [19:42:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] "success!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110414 (owner: 10Yuvipanda) [19:42:59] (03CR) 10Jdlrobson: [C: 032] Hygiene: cucumber.yml is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110351 (owner: 10Zfilipin) [19:43:29] brion: woo! [19:43:40] YuviPanda|bus: https://gerrit.wikimedia.org/r/#/c/109939/1 is a really bad idea in my opinion [19:43:58] querying an api for a page should not return information related to the current user [19:44:06] why can't you just use permissions which is about the page? [19:44:14] protection rather [19:44:49] jdlrobson: then I also have to constantly make sure my user perms is up to date? [19:44:58] so what [19:45:01] don't be lazy [19:45:08] jdlrobson: extra requests. [19:45:12] they don't change that often [19:45:26] jdlrobson: sure, but on the app side I have no way of knowing when they have [19:45:35] should I check once a day? once a week? once every edit? [19:45:59] jdlrobson: there's also things like flaggedrevs and titleblacklist that can apparently affect it [19:46:04] * brion hmms [19:46:06] jdlrobson: (I haven't checked if they can) [19:46:09] yeah it's a tough question [19:46:15] to me it is a question of separation of concerns [19:46:19] jdlrobson: canEdit checks all those, so why shouldn't I use it? [19:46:28] but you are querying an api about a page [19:46:37] a page that should know nothing about the current user [19:46:40] jdlrobson: and I think action=mobileview stopped being a query for page contents long ago [19:46:45] just because mediawiki api allows that sort of thing i think that's terrible [19:47:00] why can't you check permissions at time of edit [19:47:07] what if you have cached a page and it wasn't editable and now is? [19:47:23] YuviPanda|bus: it still returns information about that page though [19:47:26] let's not move away from that [19:47:28] jdlrobson: I'm alson in a bus, so can lose connectivity any moment [19:47:32] np [19:47:48] at the very least it should be done by providing a username as a parameter [19:47:59] e.g. ?page=Foo&user=YuviPanda [19:48:06] then the query is about both a user and a page [19:49:16] (03Merged) 10jenkins-bot: Hygiene: cucumber.yml is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110351 (owner: 10Zfilipin) [19:49:42] jdlrobson: edit details such as blocks can also be IP-specific [19:49:59] i'm not sure we can really stick all the relevant info into the request easily other than by using the context of the request [19:50:11] (session -> user,e tc) [19:51:13] idk what discussion I lost [19:51:18] sorry [19:51:25] brion: I am going to disconnect for real now. [19:52:02] good luck finding internet again YuviPanda|bus :D [19:52:26] brion: heh [19:52:27] brion: yeah [19:52:34] brion: I'll modularize actions as well tonight [19:52:38] brion: let me see if I can push it [19:52:53] ok [19:53:32] brion: I think everything I had got merged, right? [19:53:44] ya [19:54:27] (03CR) 10Jdlrobson: [C: 04-2] "I really don't like this approach of returning information relevant to context outside the URI parameters. canEditable is about the curren" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [19:54:30] brion: ok [19:54:47] brion: minor patch coming up first [19:55:26] jdlrobson, do you realise that mobileview, just like normal views, is strictly per-user? [19:56:59] (03PS1) 10Yuvipanda: Fix minor jshint warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110436 [19:57:02] and why I wasn't pinged above? [19:58:08] (03Abandoned) 10MaxSem: mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [19:58:10] anyway, I couldn't care less [19:58:42] MaxSem: yes i do but i think that's terrible. http://sustainableman.org/wp-content/uploads/2013/07/DrIanMalcom.jpg [19:58:54] MaxSem: don [19:59:02] jdlrobson, next time full card please [19:59:04] * MaxSem we didn't seem to get to a conclusion so don't abandon it [19:59:16] MaxSem: /I/ didn't ask for this [19:59:20] you did [19:59:22] I just started a conversation about it [19:59:44] what you did sounded like an ask for a feature for me [19:59:51] so I did it:) [19:59:52] well you misunderstood me Max, you should make sure we are on the same page before you go and work on something. [20:00:04] oh yes I will [20:00:14] :evilgrin: [20:07:42] (03CR) 10Jdlrobson: Story 1621: Fixing VE content area typography/design for mobile (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110122 (owner: 10Kaldari) [20:07:51] (03CR) 10Jdlrobson: [C: 04-1] "See PS1 comments" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110122 (owner: 10Kaldari) [20:08:33] violetto: i really like this: https://trello-attachments.s3.amazonaws.com/52e98a603e6d08a53861025b/52e98cbf8ef5bbc824a0e978/888b0e79fbd63d421d326534694553c3/Screenshot_2014-01-30_11.08.13.png [20:11:38] jdlrobson: I talked to Roan briefly about the thumbnail issues, but didn't get very far. His only consolation is that they eventually plan on upsteaming the new DOM model to the core parser so that they will match again. I'll try bugging trevor instead. [20:12:15] mhurd: i've attached the icon already [20:12:28] violetto: yay! thanks! [20:13:01] violetto: hooking it up now [20:13:03] (03CR) 10Jdlrobson: "I just tried this on beta labs and it worked for me...." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [20:13:32] (03CR) 10Jdlrobson: "Are you using MEDIAWIKI_USER=Selenium_user ?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [20:16:58] (03CR) 10Jdlrobson: Use MediaWiki UI buttons in alpha (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102581 (owner: 10Jdlrobson) [20:17:07] (03PS6) 10Jdlrobson: Use MediaWiki UI buttons in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102581 [20:44:12] (03CR) 10Kaldari: Story 1621: Fixing VE content area typography/design for mobile (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110122 (owner: 10Kaldari) [20:46:16] jdlrobson: i've got a few patches that need review for the git log scripts, basically preparing them to integrate with sam's scripts - if you have some time, would you mind reviewing? they are pretty small and straightforward: https://gerrit.wikimedia.org/r/#/q/owner:Awjrichards+status:open,n,z [20:46:55] after those are done, i'm going to move the py script into make-deploy-notes and have sam's scripts run it and post the output to mw.o [20:51:06] jdlrobson: I replied to your recent email [20:51:25] and since I've got a tiny window to work on it, wanna talk about it real quick? [20:51:38] if it's a good idea I've got tonight and tomorrow night to make it happen :) [21:13:12] jdlrobson: would know a quick way to trigger abuse filter response other than the "poop" method? [21:13:26] what's the poop method? [21:13:39] jgonera is the king of AbuseFilter [21:13:41] jdlrobson: typing "poop" [21:13:47] in an edit [21:13:48] lol [21:16:44] mhurd, btw - do you handle SpamBlacklist errors? [21:17:00] (try adding a tinyurl link) [21:17:09] MaxSem: ah! will try it... [21:18:40] to be precise, use something from https://meta.wikimedia.org/wiki/Spam_blacklist - it will work on every wiki [21:19:53] (work as in fail):P [21:21:01] bbiab errands [21:21:16] MaxSem: thanks! yeah it just failed when i tried to add a tiny url. will need to make it display more than "Failure" which was all that was happening... good catch max! [21:22:01] * MaxSem prays it's not just another lame 'hookaborted' error [21:22:06] hehe [21:23:47] There should be spamblacklist... [21:29:10] jdlrobson: Left more comments at https://gerrit.wikimedia.org/r/#/c/110122/. Lemme know if we should discuss in person. [21:48:31] jgonera: hey! do you know an easy way to trigger an edit abuse filter response (i know typing "poop" will trigger a warning, but i'm looking for others to test against - especially if they are disallowed actions with long warning messages) [21:49:04] jgonera: (on testwiki) [21:49:07] mhurd on enwiki or local instance? [21:49:26] mhurd, if on testwiki, you can make some yourself;) [21:49:49] mhurd there's a special page for defining abuse filter rules [21:50:04] But I think you need admin rights [21:50:43] MaxSem: true, but i'm trying to see if the actual warnings look ok [21:54:08] mhurd you could copy some of them to your local wiki and check there. I took the longest I could find and did that ;) [21:54:35] jgonera: sounds good! [21:54:37] thx [22:12:29] kaldari: i'm camping in R33 if you need anything [22:27:17] (03PS6) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/109844 [22:35:09] zz_yuvipanda: you have time for a quick question before you go to sleep? [22:35:25] oops, nevermind :) [22:35:45] you're prolly already asleep [22:39:20] kaldari, have you seen my comment in https://gerrit.wikimedia.org/r/#/c/109264/ ? [22:40:05] (03CR) 10Kaldari: [C: 032] "fair enough" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109264 (owner: 10JGonera) [22:41:15] (03Merged) 10jenkins-bot: Hygiene: Add proper error reporting in lead image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109264 (owner: 10JGonera) [22:56:54] (03PS1) 10Mhurd: Displays abuse filter warnings. Warning links open externally. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/110471 [22:57:11] brion: ^ should be pretty solid [23:06:14] hey mhurd I found a couple bugs in the app [23:06:26] kenanwang_: cool - whatcha got? [23:06:44] first when I open the app I actually don't have the ability to search for anything... so I can't see any articles [23:07:10] second when I open the menu I can't get to any of the menu items because the keyboard seems to block the menu [23:07:27] ya that keyboard issue is annoying! [23:07:39] well I guess I could close the keyboard but it's a serious pain [23:07:48] mhurd: looking over the patch... [23:07:51] for the former, does it still happen if you delete the app then reinstall? [23:07:56] brion: thanks! [23:08:03] hmmm i could try [23:08:08] * brion looks for lightning cable in his rat's nest of cables [23:08:23] also brion I think i asked you yesterday but how do I download the android version for testing? [23:08:49] kenanwang_: ah i'll send you a url -- gimme a couple minutes to make sure it's uploaded [23:09:03] ok [23:09:05] thanks [23:09:13] kenanwang_: made note of keyboard bug [23:09:33] i might actually start using test flight for them too just for convenience of regular testers sending the download notices out [23:10:28] brion: on test wiki yuvi added an abuse filter rule which triggers on adding the word "soup" - the resulting warning has some links so you can test if they open externally properly [23:10:37] mhurd: ah nice [23:10:41] and less ...... poopy [23:10:45] hehe [23:11:19] ok, generate signed apk... [23:17:48] kenanwang_: ok you should have an email with the download link for the android version [23:17:58] cool thanks brion! [23:43:25] dr0ptp4kt: around? [23:44:10] yurikR, i'm here [23:44:49] mhurd: i hear you were looking for me, still need me? [23:45:54] violetto: ah yes, just had quick question about the abuse filter mockup [23:47:31] mhurd: do you want me to go there or do you wanna come here? [23:47:48] violetto: i'll come over there [23:48:24] dr0ptp4kt: i'm still waitintg for the goahead with the depl. [23:48:37] if you see greg around, ping him :) [23:48:39] yurikR, alright, lemme know if it happens [23:48:45] no greg in the office that i see [23:49:24] sigh [23:53:20] (03PS2) 10Jdlrobson: WIP: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [23:54:26] (03CR) 10jenkins-bot: [V: 04-1] WIP: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson)