[00:21:09] (03CR) 10JGonera: [C: 032] Document $wgMFAnonymousEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110420 (owner: 10Jdlrobson) [00:21:43] (03Merged) 10jenkins-bot: Document $wgMFAnonymousEditing [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110420 (owner: 10Jdlrobson) [00:22:45] (03CR) 10JGonera: [C: 032] Beta Feature: Register mobile skin, offer users the ability to change it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [00:23:22] (03Merged) 10jenkins-bot: Beta Feature: Register mobile skin, offer users the ability to change it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [00:42:27] rmoen|away: you still away? [00:43:04] (03CR) 10JGonera: [C: 04-1] "Breaks titles in editor overlay in stable (they now have underscores instead of spaces)." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 (owner: 10Jdlrobson) [00:44:49] (03CR) 10JGonera: [C: 032] QA: Allow browser tests in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109451 (owner: 10Jdlrobson) [00:45:28] (03Merged) 10jenkins-bot: QA: Allow browser tests in alpha mode [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109451 (owner: 10Jdlrobson) [00:54:18] (03CR) 10JGonera: [C: 04-1] QA: Add browser tests for ajax pages (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109453 (owner: 10Jdlrobson) [01:02:15] (03CR) 10JGonera: [C: 032] Hygiene: Don't use content_wrapper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109319 (owner: 10Jdlrobson) [01:03:26] (03Merged) 10jenkins-bot: Hygiene: Don't use content_wrapper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109319 (owner: 10Jdlrobson) [01:07:05] mhurd: hey! [01:07:10] I've proper internet now! :) [01:11:00] YuviPanda: shouldn't you be sleeping now ? [01:11:07] tfinc: I had slept and woken up [01:11:25] tfinc: I also had an interesting auto ride after, so well woken up :P [01:11:35] interesting good ? [01:11:52] tfinc: interesting interesting :P [01:12:22] tfinc: this entire trip I have paid more for autos than for the intercity buses themselves :) [01:12:46] YuviPanda: where are you heading that is so costly ? [01:13:12] tfinc: I went to Chennai to start the process to pick up my college certificates [01:13:16] tfinc: just came back to Bangalore [01:13:32] tfinc: the entire trip was about 20$ more expensive than it should be, but oh well. [01:13:56] worth it if it gets you the visa [01:14:12] tfinc: heh, true [01:14:39] YuviPanda: you're gonna love me more for what im about to show you. https://trello-attachments.s3.amazonaws.com/52e98a603e6d08a53861025b/52e98cbf8ef5bbc824a0e978/d1245cd998479551615a59042b0cc7e8/Screenshot_2014-01-30_17.16.34.png [01:15:06] YuviPanda: yay! [01:15:10] violetto: I like the header nav better! :) [01:15:20] violetto: were there any other changes? [01:15:20] YuviPanda: https://trello-attachments.s3.amazonaws.com/52e98a603e6d08a53861025b/52e98cbf8ef5bbc824a0e978/5414994afc79021d928e57b0e2b69e28/Screenshot_2014-01-30_17.18.49.png [01:15:49] YuviPanda: took out the bottom action cus we'd have a double if the warnings are short [01:16:01] violetto: hmm, ok! let me take it out as well [01:16:13] in the top nav now there is a call to action "Ignore or review edit" [01:16:16] basically bottom action is brought to top and will be persistent [01:16:32] violetto: makes sense [01:16:37] violetto: I'll adjust code to match [01:16:44] YuviPanda: but sorry, back filled button stay for other workflows taht needs it! [01:16:59] so i guess you love me still the same amount before [01:17:05] violetto: :P :D :) [01:17:08] im just gonna have to deal with it [01:17:58] violetto: me too :P [01:18:19] mhurd: legoktm didn't get the iOS builds that were sent out :( any idea why that might be happening? [01:19:08] hmmm have him ping brion... maybe he's not been added to the acct properly? [01:22:24] violetto: did you add an asset for the 'x' [01:22:56] YuviPanda: i did. but it's not set. I'm awaiting Pau's reply on that. [01:22:57] violetto: also, I think we should make them 144px instead of 150 - to match Android's 48px grid [01:23:16] violetto: where did you add it to? [01:23:27] YuviPanda: 144 is good [01:23:33] violetto: ok! [01:23:49] YuviPanda: https://trello.com/c/NVw38u0P/8-assets [01:24:15] violetto: ah ok! [01:24:24] violetto: yay for svgs :) [01:24:49] violetto: I'll also do an open sans run today, and convert all the things [01:25:11] YuviPanda: perfcet! [01:25:11] violetto: are you ok with using roboto serif for the places we use serif in? [01:25:19] violetto: which is so far just the page title [01:25:28] YuviPanda: that's currently what we're using right [01:25:28] violetto: or do you want to pick out another font? [01:25:30] violetto: ya [01:25:36] YuviPanda: that's great then [01:25:40] violetto: ok [01:25:44] cus i thought it looked good [01:25:54] violetto: oh can you attach the latest to the card? [01:26:22] violetto: remember we tried a build that did 'When you start scrolling search results keyboard should hide (is weird, May's playing with it now) ' [01:26:33] violetto: it still feels weird, should I just cross it off and abandon the patch? [01:27:43] YuviPanda: yeah, we've added more search results though right? [01:27:49] violetto: yeah, it's 12 now [01:28:57] violetto: awesome!!!! [01:29:30] YuviPanda: let me look at it again. the keyboard should hide though [01:29:44] violetto: the keyboard hides when you tap, but not when you scroll [01:29:44] violetto: YuviPanda: see ya tomorrow! [01:30:12] violetto: since if you start scrolling, and say item 1 is hidden, and then we show keyboard, it just comes right back, since there is now enough room to display everything [01:30:19] mhurd: cya! happy climbing! [01:30:27] violetto, you around? [01:31:08] YuviPanda: :) [01:32:05] YuviPanda: okay we'll just let it stay and see how things go [01:32:08] dr0ptp4kt: i am! [01:32:10] violetto: yeah [01:32:16] violetto: I crossed it off for now [01:32:20] violetto: wanna come over here for a mini demo? [01:32:21] YuviPanda: koo! [01:32:33] dr0ptp4kt: /going [02:08:58] Krinkle, I was kind of wrong, the elements do exist, but they're not attached, anyway I know how to fix this [02:09:41] Krinkle, do I have to specify the surface in MobileViewTarget constructor or could I do it later? [02:31:05] (03PS1) 10JGonera: Fix VE error with latest VE master [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110498 [02:49:20] hi violetto [02:50:41] YuviPanda: hey! [02:50:50] violetto: hey! [02:50:56] violetto: I can't point out why it feels odd [02:50:58] violetto: but it does! [02:52:15] violetto: do you want links to the screenshot again? [02:52:25] YuviPanda: my android batts died, can you screenshot an article? [02:52:29] sure [02:52:45] violetto: https://www.dropbox.com/s/asuk30tdlo67wgq/2014-01-31%2002.24.09.png and https://www.dropbox.com/s/2bi1j7uxkgjwns7/2014-01-31%2002.22.54.png [02:52:52] some fonts have really bad kerning that's why it's hard to find really good fonts to use [02:52:56] violetto: an article is coming up [02:53:33] violetto: [02:53:35] violetto: https://www.dropbox.com/s/w8wxkywo4w177ko/2014-01-31%2002.53.11.png [02:54:05] it's definitely the kerning [02:54:13] it's rendering fine on the article but elsewhere not [02:54:15] violetto: right. [02:54:21] violetto: it looks fine in the article, tho? [02:54:28] it looks great on the article [02:54:32] violetto: it is the same font as the article, right? [02:55:31] it's the same yea [02:55:59] violetto: tell me a font that you *know* has good kerning? I'll put it on and try it out to see if it is the font or the renderer? [02:56:06] violetto: doesn't have to be open source, is just for testing [02:56:10] the kerning is not as great as helvetica neue im thinking in the history view it's looking bad possibly because it's larger? [02:56:36] if you changed the article copy to the same as what's used on the history view lets see if it has the same problem [02:56:38] violetto: the history view and the sidebar/search stuff is exactly the same size [02:57:02] helvetica neue is a very refined set of font you can try that [02:57:22] history/sidebar vs article copy? [02:57:40] violetto: hmm, I'm not sure. let me check. [02:59:53] violetto: okay, it is 18 [03:00:22] violetto: although it is 18sp, which is a slightly different unit than 16px [03:00:29] I am trying to find a way to convert [03:01:00] YuviPanda: oki [03:03:18] violetto: let's assume for now that it is 18px [03:03:27] violetto: do you want me to make body text 18px or the UI text 16px? [03:03:42] body text 18 first [03:05:18] violetto: ok [03:05:52] violetto: https://www.dropbox.com/s/zz27y1bcpnj6eyx/2014-01-31%2003.05.34.png [03:06:39] YuviPanda: yup! [03:06:45] turns out it's just a bad kerned font [03:06:48] arghhh [03:06:58] bigger the text bigger the kerning problem [03:07:57] violetto: sigh. [03:09:02] YuviPanda: let me investigate this after my presentation tmr [03:09:17] let's see what i can do [03:09:23] violetto: I am setting UI font to Helvetica Neue to verify that it isn't the rendering engine [03:09:30] YuviPanda: okay [03:13:16] violetto: nevermind, I can't find a proper version of Helvetica Neue that'll work on Android. Licensing issues I guess [03:13:16] grr [03:13:26] violetto: so I just stash this patch for now until we find a better font? [03:13:51] YuviPanda: yeah [03:14:24] violetto: hmm, actually, I am going to send up this patch anyway. [03:14:34] violetto: will mean we are reminded constantly of the ugliness :P [03:14:39] YuviPanda: im going to start preparing for my presentation more than i have for tmr, do you need anything from me? i'll be more available after tomorrow [03:14:47] YuviPanda: lol [03:15:00] violetto: nah, that's cool! :) Good luck for the presentation! [03:15:27] YuviPanda: thanks! im going to be presenting wikitrails [03:15:38] violetto: ooooh very nice! :) [03:15:40] (03PS1) 10Yuvipanda: Make the UI use OpenSans too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110504 [03:15:53] violetto: there, patch uploaded :) [03:16:02] violetto: where are you presenting? [03:17:08] ux brown bag tomorrow at lunch [03:17:14] on 6th floor [03:17:53] violetto: oh, wait, I forgot tomorrow was not saturday [03:17:59] violetto: my days are messed up. ignore me [03:18:10] YuviPanda: hahahah [03:18:27] violetto: :) have fun! I'll consider taking a nap or doing some other cleanup work [03:18:36] violetto: do consider linking me to the presentation when you are done :) [03:20:20] YuviPanda: i will! [03:20:25] violetto: sweet! [03:22:08] YuviPanda: http://techcrunch.com/2014/01/30/facebook-paper/ [03:22:23] violetto: yeah, saw that. too bad I can't try it out (not being in the US and iOS) [03:22:50] YuviPanda: the interactions are so bad ass [03:23:03] violetto: I could guess :D [03:23:11] violetto: you should see if there's things we could steal [03:23:54] YuviPanda: see that's their first release [03:23:56] ;P [03:24:10] violetto: :) we still have about 2 months for our first release [03:24:11] wouldn't you want to be on tech crunch on first release! [03:24:19] violetto: we should stop saying 'MVP'. It is nowhere near an MVP [03:24:36] what would it be [03:24:45] plus I personally don't think the MVP paradigm fits us - we have a lot of ideas / concrete data that we know works, just needs implementation [03:24:49] violetto: 'first release'? :P [03:24:54] violetto: '1.0'? [03:25:02] YuviPanda: :) [03:25:18] YuviPanda: i know right [03:25:50] violetto: yeah. MVPs are useful in startupland when you have a super limited amount of time and have no clue at all as to what works and what doesn't [03:25:52] we dont wanna be like… oh yea that's just mvp we still have a lot of stuff to tweak [03:25:56] not true for us [03:25:58] violetto: yeah, that too [03:26:14] violetto: an MVP is not going to get pushed out to 20 million people :P [03:26:45] YuviPanda: i know right! [03:26:55] YuviPanda: https://www.facebook.com/paper [03:26:59] hot damn! [03:27:26] YuviPanda: heck i wanna be so excited i want to make a video like that [03:28:12] violetto: nice re-imagining of how their app could look [03:28:31] violetto: the current fb app is just 'oh we can reuse all our designs from our mobile website, and just make it a little faster!' [03:28:34] violetto: agreed :) [03:28:38] YuviPanda: can't let yahoo and facebook highlight 2014 [03:28:42] it's time for wikipedia [03:29:13] violetto: +1 :) [03:29:19] YuviPanda: fb app is kinda shitty [03:29:25] yahoo's been doing super awesome things [03:29:27] violetto: 'kinda' is putting it lightly, IMO [03:29:41] violetto: hmm, interesting. I've zero yahoo apps on my phone and also use zero yahoo products. [03:29:57] YuviPanda: airbnb is also doing great things [03:30:35] violetto: well, in a way so are we (Wikipedia as a whole) [03:30:39] violetto: just growing pains :) [03:31:09] violetto: I hope betafeatures will speed up now that zz_prtksxna is around to implement things [03:31:26] violetto: also I am immensely happier to be having this conversation on IRC than fb chat or hangout :P [03:33:38] YuviPanda: :) [09:28:56] (03PS2) 10Yuvipanda: Make the UI use OpenSans too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110504 [10:07:03] YuviPanda: What exactly is bugging you with the fonts? [10:07:12] prtksxna: I don't know :P [10:07:19] lol [10:07:24] prtksxna: violetto (May) doesn't like using Roboto [10:07:35] prtksxna: and Open Sans feels a bit weird on the UI text (looks fine for body text) [10:07:54] YuviPanda: And you guys are sure you want to use a sans serif? [10:08:09] prtksxna: I suppose so? [10:08:42] I see, Roboto Slab could've been an option otherwise [10:09:01] prtksxna: yeah, I don't think it was even considered [10:09:06] prtksxna: we could use any Open Source Font though [10:09:23] YuviPanda: oh, ok [10:09:33] prtksxna: I liked Arimo [10:09:38] YuviPanda: Hm. [10:09:41] * prtksxna google [10:09:43] prtksxna: but I should still continue not having any opinion on fonts [10:09:54] prtksxna: so I am just going to let violetto pick it and not say much about it [10:10:11] YuviPanda: That sounds like a good plan too :) [10:10:24] prtksxna: heh, yeah! [10:35:33] (03PS1) 10Yuvipanda: Turn off AutoSuggest/AutoCorrect for Captcha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110529 [13:45:25] (03PS2) 10Yuvipanda: Fix minor jshint warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110436 [13:45:27] (03PS2) 10Yuvipanda: Turn off AutoSuggest/AutoCorrect for Captcha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110529 [17:51:04] hey brion [17:51:11] rawr [17:52:06] YuviPanda: https://gerrit.wikimedia.org/r/#/c/110504/ <- y'all think this is ugly so .... why ? :D [17:52:40] brion: you'll note that there are no dependencies on it :P I wanted to have it up, and I think even merging it is ok [17:52:53] also isn't there a way to specify global styles that would set the fonts? [17:53:02] brion: absolutely none, sadly [17:53:03] instead of customizing every view... [17:53:06] d'oh [17:53:27] brion: I'd rather have this code in now, since we can always tweak the font we want to use later (one line code change) [17:53:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix minor jshint warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110436 (owner: 10Yuvipanda) [17:53:47] YuviPanda: ah true [17:53:51] (03PS3) 10Yuvipanda: Make the UI use OpenSans too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110504 [17:54:13] (03CR) 10Brion VIBBER: [C: 032 V: 032] Turn off AutoSuggest/AutoCorrect for Captcha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110529 (owner: 10Yuvipanda) [17:56:59] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Most importantly this gives us a single place we can now change the font for things, so that's good. :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/110504 (owner: 10Yuvipanda) [17:58:42] (03CR) 10Jdlrobson: [C: 032] "Probably should put bug number in comment but I guess git blame can be used." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110498 (owner: 10JGonera) [17:59:22] (03Merged) 10jenkins-bot: Fix VE error with latest VE master [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110498 (owner: 10JGonera) [18:00:12] (03PS2) 10Jdlrobson: QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 [18:00:14] (03PS6) 10Jdlrobson: QA: Define expected behaviour for VisualEditor overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 [18:00:16] (03PS8) 10Jdlrobson: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 [18:00:18] (03PS3) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [18:00:57] (03CR) 10jenkins-bot: [V: 04-1] QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 (owner: 10Jdlrobson) [18:01:53] (03CR) 10Brion VIBBER: "testing this shortly..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/110471 (owner: 10Mhurd) [18:02:02] first i need more coffee [18:02:31] (03CR) 10jenkins-bot: [V: 04-1] Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson) [18:06:26] oh so that's why my computer keeps going to sleep [18:06:31] cat knocked out the power supply again [18:06:38] * brion cat == home terrorist [18:07:02] if his demands of kibbles in his bowl are not met, laptop power will be depleted again! [18:07:51] brion: hehe :P [18:14:51] jdlrobson: on https://gerrit.wikimedia.org/r/#/c/109011/8/tests/browser/features/step_definitions/keep_going_steps.rb change "keep_going_element.when_present" to "keep_going_element.when_present(10)"... [18:15:30] jdlrobson: I'm getting occasional timeouts, e.g.: timed out after 5 seconds, waiting for {:class=>"overlay-bottom", :tag_name=>"div"} to become present (Watir::Wait::TimeoutError) [18:15:30] features/keepgoing.feature:12:in `Then I see the KeepGoing drawer prompting me to continue editing' [18:16:35] mm okay sure [18:17:01] chrismcmahon: doing now [18:17:04] kenanwang_, we had around 1.5% of Blackberries in June [18:17:11] kenanwang_: i know you mentioned you wont be in the office today, is there still a way folks like jdlrobson can walk you through ready for signoff items? [18:18:00] ok jgonera thanks [18:18:20] awjr i will email our some directions to the team [18:18:24] out* [18:18:28] awesome thanks kenanwang_ [18:18:31] kenanwang_: I have 2 stories waiting for sign-off right now, so let me know how you want to review those [18:18:47] kenanwang_, also, we have to talk briefly about cards 1652 and 1653 for the next iteration (we didn't get to them during the estimation meeting) [18:19:15] ok kaldari [18:19:18] JeffHall: chrismcmahon i know you guys are both super busy, but we have a a bunch of browser tests for MF stuck in code review - any chance you guys can take a look at them soon? [18:19:30] jgonera: yep [18:19:41] awjr, I'll try to review some of them today [18:19:47] cool jgonera [18:20:02] kenanwang_, do you want to do a hangout later today? [18:20:14] i should have some time late this afternoon to lend a hand with code review [18:20:17] can we talk around 1? [18:20:25] awjr: Sure, I can take a look right after lunch [18:20:29] kenanwang_, can we make it 2? [18:20:30] (03PS9) 10Jdlrobson: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 [18:20:32] ^ chrismcmahon [18:20:36] awesome JeffHall thank you :D [18:20:42] awjr: yes, actually, guess I'll paste my comment above into gerrit jdlrobson [18:20:51] chrismcmahon: :D [18:20:55] chrismcmahon: no need already fixed [18:21:08] (03CR) 10Brion VIBBER: "note: this is being updated, will review when next patchset is in :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/110471 (owner: 10Mhurd) [18:21:25] (03CR) 10Cmcmahon: "hange "keep_going_element.when_present" to "keep_going_element.when_present(10)"..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [18:21:36] chrismcmahon: i've already done that [18:21:59] jdlrobson: awesome, I think this is really close, let me bring down the lates [18:22:00] t [18:30:49] jdlrobson: wondering why this times out even after 10 seconds, looking: Then I see the KeepGoing drawer prompting me to continue editing # features/step_definitions/keep_going_steps.rb:1 [18:30:49] timed out after 10 seconds, waiting for {:class=>"overlay-bottom", :tag_name=>"div"} to become present (Watir::Wait::TimeoutError) [18:30:49] features/keepgoing.feature:12:in `Then I see the KeepGoing drawer prompting me to continue editing' [18:32:04] chrismcmahon: what is happening in your browser? [18:32:10] does the registration happen correctly? [18:32:19] jdlrobson: that's what I'm trying to figure out [18:33:06] jdlrobson: ah, I see. the new user is not always created properly, I just watched that fail, figuring out why [18:33:09] chrismcmahon: are you using chrome or firefox? [18:33:14] firefox [18:33:19] mmm beta labs issues maybe? [18:33:26] jdlrobson: no, timing or something [18:36:25] "error saving settings" upon clicking beta thingie [18:36:43] ? [18:36:50] screenshot? [18:37:59] (03CR) 10Jdlrobson: Make edit button permissions work on alpha lazy loaded pages (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 (owner: 10Jdlrobson) [18:40:50] jdlrobson: should I ping someone else about https://gerrit.wikimedia.org/r/#/c/109878/, or should I just go ahead and merge it? [18:41:52] YuviPanda: it's on my radar. I will look at it if it still needs review when i get the time, maybe later today. I have no idea if you should merge it or not as I have not looked at the code. [18:42:18] jdlrobson: ok [18:50:55] (03PS10) 10Cmcmahon: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [18:53:18] (03PS11) 10Cmcmahon: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [19:00:52] brion: legoktm didn't get the iOS build [19:00:57] brion: any idea what might have happened? [19:01:16] hmm [19:02:50] ah i had to add him in a second place [19:02:52] lemme fix that [19:02:57] brion: also StevenW? [19:03:23] YuviPanda: steven walling? he installed it already [19:03:27] brion: ah, ok! [19:03:28] or another steven w :D [19:03:31] just wanted to double check [19:03:33] ok :D [19:03:42] THE WORLD IS NOT BIG ENOUGH FOR TWO STEVENWS! [19:05:06] (03PS4) 10Jdlrobson: QA: Add browser tests for ajax pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109453 [19:05:08] (03PS5) 10Jdlrobson: Make edit button permissions work on alpha lazy loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 [19:05:10] jdlrobson: JeffHall I added some hygiene to https://gerrit.wikimedia.org/r/#/c/109011/11/tests/browser/features/step_definitions/common_steps.rb . It's not bulletproof but it's better. I'd like to merge the whole thing and see what happens. [19:06:02] (03CR) 10Jdlrobson: QA: Add browser tests for ajax pages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109453 (owner: 10Jdlrobson) [19:06:52] (03CR) 10jenkins-bot: [V: 04-1] Make edit button permissions work on alpha lazy loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 (owner: 10Jdlrobson) [19:07:02] (03CR) 10Jdlrobson: "Hey Jared. any luck?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [19:07:55] (03CR) 10Jdlrobson: "Hey Theo let me know if anything is not clear :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108539 (owner: 10Theopolisme) [19:11:28] (03CR) 10Cmcmahon: [C: 032] QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [19:12:04] (03Merged) 10jenkins-bot: QA: KeepGoing browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109011 (owner: 10Jdlrobson) [19:17:32] (03PS6) 10Jdlrobson: Make edit button permissions work on alpha lazy loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 [19:17:38] (03CR) 10jenkins-bot: [V: 04-1] Make edit button permissions work on alpha lazy loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 (owner: 10Jdlrobson) [19:17:42] chrismcmahon: WOOP :D [19:17:49] chrismcmahon: what was the issue? [19:18:19] jdlrobson: some sort of race conditions doing beta settings. I [19:19:02] jdlrobson: I'm still not sure my changes are 100% bulletproof, let's see what happens in the builds. if we get bogus failures because of settings problems, we can dig deeper. [19:27:37] (03PS5) 10Jdlrobson: QA: Add browser tests for ajax pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109453 [19:27:39] (03PS7) 10Jdlrobson: Make edit button permissions work on alpha lazy loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 [19:29:05] (03PS7) 10Jdlrobson: QA: Define expected behaviour for VisualEditor overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 [19:29:33] (03PS8) 10Jdlrobson: QA: Define expected behaviour for VisualEditor overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 [19:30:16] (03PS7) 10Jdlrobson: Make KeepGoing/toast confirmation run when editing using VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108990 [19:34:41] kenanwang_: I'm wondering if you could do the acceptance meeting with brion instead. [19:34:49] sure [19:35:08] (03PS9) 10Jdlrobson: QA: Define expected behaviour for VisualEditor overlay for bug 59932 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109436 [19:35:13] (03PS8) 10Jdlrobson: Make KeepGoing/toast confirmation run when editing using VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108990 [19:35:23] (03PS2) 10Jdlrobson: Story 1625: Drop the preview screen [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109779 [19:35:53] ok what time was that again? 12 or 12:30? [19:36:02] brion: 12:00 [19:36:08] ok [19:36:11] works for me :D [19:36:52] brion: kenanwang_ the AF story - we hit all the acceptance criteria, and the rest of the design will be finished up in the visual styling sprint (top nav, icons) [19:37:12] I have two largeish forms to fill before tomorrow :( (Visa + Zurich) [19:40:03] brion: kenanwang_ thanks! [19:43:47] aaaaah i got disoriented swiping on what i thought was the app but was actually a screenshot of the app [19:44:30] brion: hahaha! [19:44:36] brion: https://www.dropbox.com/s/nr1evpummbnlbhq/2014-01-31%2019.32.26.png is the login screen now [19:44:45] brion: the Open Sans seems to be throwing me off a little bit [19:44:52] :) [19:45:01] that kerning just feels wrong doesn't it :D [19:45:48] brion: yeah, it does [19:46:06] we're gonna have to do some kind of font shoot-out aren't we :D [19:46:15] brion: so a hacky way to fix kerning is to insert a space after every character, and set textScaleX on that character to adjust it positively or negatively [19:46:19] brion: FUCKING INSANE, that is [19:46:29] lol [19:46:39] don't do that :D [19:46:45] brion: and that breaks line wrapping, so the workaround is to use ZWNJs instead :P [19:46:53] since you can scale them to be non zero width :P [19:46:59] so they are NZWNJs :P [19:47:08] oh i'm gonna choke on my coffee :D [19:47:19] brion: :D [19:47:23] let's just pick a font we like better in the end ;) [19:47:40] brion: yeah, after eating popcorn at other people's font discussions, I am going to totally stay out of this one [19:47:46] brion: I'll just go with whatever May picks :P [19:47:48] hehe [19:50:41] ehm, I'm fulfilling my promise to fall asleep [19:52:44] brion: I updated the invite to include you [19:52:46] brion: thanks! [19:55:01] (03PS3) 10Kaldari: Story 1621: Fixing VE content area typography/design for mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110122 [19:56:25] rmoen, in VE, on desktop where can I find the code that is triggered when clicking an [edit beta] section link? [19:56:59] jgonera: in ve.init.mw.ViewPageTarget [20:01:34] man i wish i had more SSD space on this MBP [20:01:51] if/when i get a new one i'm maxing out the storage [20:01:56] brion: shit shit shit https://android.googlesource.com/platform%2Fbuild/+/08d410f53249c18d752f56a881ed2335403080d4 [20:01:57] :D [20:01:58] \o/ [20:01:59] :O [20:02:01] O_o [20:02:03] O_O [20:02:05] o_O [20:02:08] :D [20:02:21] hopefully it won't break everything \o/ [20:02:45] brion: yeah [20:02:52] brion: also did you sync up with kenanwang_? [20:02:58] i'm in the hangout [20:03:02] kenanwang_: poke poke [20:03:20] Hey brion and YuviPanda just got out of meeting [20:03:24] ok [20:03:38] brion: ok, I'll try to finish up login. tx [20:03:44] whee [20:04:01] ok brion so I gotta setup my android phone [20:04:11] ok lemme know if i can help [20:04:19] yep [20:04:27] will check back in in 10ish [20:05:05] ok [20:06:45] damn you can get em configured up to 1TB of SSD now [20:08:50] i think i'll wait until they officially support 60Hz UHD displays [20:08:55] and.... i have money for one.... [20:08:56] details [20:11:39] ah the new 15"er has two thunderbolt 2 ports, but the 13"er still has single thunderbolt (non-2) port? [20:11:45] that might get me to stick with the 15" model [20:12:13] ah well another day [20:13:30]