[09:59:47] (03PS1) 10Yuvipanda: Add a persistant cookie store backed by SharedPreferences [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111167 [10:26:01] (03PS2) 10Yuvipanda: Add a persistant cookie store backed by SharedPreferences [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111167 [11:10:44] (03PS1) 10Yuvipanda: Add a LoginTask + Tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111174 [11:35:08] (03PS1) 10Yuvipanda: Add FetchEditTokenTask + check for LoginTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111177 [13:00:14] (03CR) 10Siebrand: [C: 04-1] [WIP] Allow users to adjust the font size [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 (owner: 10Theopolisme) [16:04:09] (03Abandoned) 10Hashar: QA: profile for default settings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/97497 (owner: 10Hashar) [16:27:44] (03PS1) 10Cmcmahon: Use long random string for a safe password [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111207 [17:51:57] (03CR) 10CSteipp: Use long random string for a safe password (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111207 (owner: 10Cmcmahon) [17:58:33] YuviPanda: poke [17:59:00] any preferences on https://gerrit.wikimedia.org/r/#/c/110665 ? should we refactor things to reduce the number of switch points or does it look ok? [18:06:24] (03CR) 10Cmcmahon: "Trying it in IRB, we find a different seed each time Random is invoked, and a different result." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111207 (owner: 10Cmcmahon) [18:12:30] (03CR) 10CSteipp: [C: 031] "Cool. As long as it isn't seeded with a timestamp or something predictable. I kept reading the docs, and I think it does go to /dev/urand." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111207 (owner: 10Cmcmahon) [18:14:57] YuviPanda: brion: hey! [18:15:06] heyy [18:15:59] brion: making progress on the login stuff - having to refactor the nav bar a bit to make it more flexible / better suited to implement may's design [18:16:05] woot [18:18:25] dr0ptp4kt: per the email thread re wap deprecation, i've moved card #54 on the sos wall to be dependent/blocked on W0 [18:18:30] just wanted to give you a head's up [18:19:04] awjr, fair enough. you want to ping on the thread or want me to ping on the thread? [18:19:49] dr0ptp4kt: you or someone from W0 should drive it, but i am happy to keep an eye on it :) [18:20:26] awjr, ok, i will ping [18:21:21] (03PS2) 10Jdlrobson: QA: Use long random string for a safe password [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111207 (owner: 10Cmcmahon) [18:21:51] (03CR) 10Jdlrobson: [C: 032] QA: Use long random string for a safe password [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111207 (owner: 10Cmcmahon) [18:22:30] (03Merged) 10jenkins-bot: QA: Use long random string for a safe password [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111207 (owner: 10Cmcmahon) [18:32:34] (03PS3) 10Jdlrobson: Hygiene: Cleanup naming convention for special page RL modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111146 [18:41:13] brion: YuviPanda: may had some really good changes for the "Latest Design Assets" trello board (one card for latest ios and android screenshots) and she added assets to the stub cards i had created. if you want to take a peek: https://trello.com/b/Id6qXKSY/mobile-app-latest-design-assets-by-page [18:42:07] peeking [18:43:11] brion: look ok? any suggestions? [18:44:09] oh man if we can make those inboxes consistently pretty....... that's gonna be nice :D [18:44:33] and i really want header images to happen [18:44:46] that's gonna make things POP like hella nice ...... poptarts [18:44:52] brion: hahaha yes! [18:46:09] mhurd: which of the ToC ones is the current plan you're working with? [18:46:40] https://trello-attachments.s3.amazonaws.com/52e98a603e6d08a53861025b/52e98cbdde67f982739880af/b12ca72cd96c35919052363ae457784f/Screenshot_2014-02-04_00.38.55.png looks hella nice [18:46:44] brion: may wants to meet and chat about that later this morning. the mockups have a couple small issues [18:46:49] though i'm not sure quite how we get from the default to the image view [18:46:50] spiff [18:47:48] brion: yeah one of the issues is on, say, landscape on a tablet the left half would be waaay too wide, but if the center divider can be dragged... [18:48:52] ...that would be cool :) [18:48:58] mhurd: oh have you seen face book's new 'paper' app? iOS & phone-only, it's got some things i like and things i don't like in the interaction design [18:49:02] worth looking at for ideas [18:49:22] brion: i'll check it out! [18:49:39] you'll love it it's got swipes and animations everywhere :D [18:53:19] mhurd: brion hey [18:53:21] mhurd: brion sorry, went on a bicycle ride. still alive, though [18:53:27] yay [18:53:41] brion: trying to do 10km a day, and since I hate traffic tried at night [18:53:55] heh [18:54:03] i would not bicycle in india traffic [18:55:30] brion: yeah, me neither. plus BLR has slopes [18:57:12] (03PS4) 10Jdlrobson: Make pointer arrow responsive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110648 [18:59:11] jgonera: i forgot to ask during the sos - would you please add notes for mobile web to the etherpad? [18:59:21] usually there's a dedicated note taker but not today :) [18:59:36] awjr, sure [19:03:07] kenanwang_ kaity awjr what does "When clicking on this and the panel opens the rest of the toolbar greys out and the article gets an opacity." mean? ref https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1521 [19:03:35] Also it's not clear from the story where the button goes on the wikitext editor to switch to VisualEditor - is there an asset missing? [19:03:41] jdlrobson: sorry thats a bit out of date [19:04:10] I'll work on providing much more specific criteria and more mocks [19:04:29] jdlrobson: can I get to you by end of day? [19:05:20] kaity: sure but it means i probably won't work on it as i'll start work on something else [19:06:36] brion: did you look at the patch? [19:06:41] es [19:08:39] YuviPanda: which ones? adam's zero patches or others? [19:08:56] brion: I sent up login patches [19:09:05] great i'll look those over shortly [19:09:05] brion: and a cookei handling patch [19:09:09] brion: we got a response from siebrand [19:09:10] nom nom nom [19:09:57] lots of juicy comments to fix up [19:10:01] great [19:11:07] brion: I am trying to think of how to properly handle edit tokens for multiple sites [19:11:09] brion: also centralauth [19:11:11] brion: thoughts? [19:11:46] YuviPanda: so for edit tokens, simplest thing is to just always fetch a new token before any action [19:11:51] they could change, you never know [19:11:59] brion: nooooo sooooo manyy network requestsss [19:12:03] and easiest way to handle centralauth is to ignore it, and always auth locally ;) [19:12:04] hehehe [19:12:06] brion: they don't for now :P [19:12:15] brion: heh. [19:12:24] well luckily the way tokens usually work you can reuse your last one [19:12:30] and if it doesn't work they'll prompt you for a new one [19:12:36] so you can just do that optimistically [19:12:59] brion: yeah, but I need to save it somewhere.... [19:13:14] brion: look at the cookie store implementation, perhaps I can reuse a similar piece of code for edit tokens too [19:13:56] YuviPanda: possibly. i'll check it shortly, gotta run and get cat food before cats murder me [19:14:05] (03PS1) 10Jdlrobson: Hygiene: Distinguish between wikitext and VE editor in browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111241 [19:14:30] brion: ok! [19:14:39] mhurd: hey! how's the login stuff coming on iOS side? [19:15:25] ok good sounds like nothing too fatal in the translatewiki stuff, i'll wrap that up per comments in a bit [19:15:32] ok brb groceries [19:15:44] YuviPanda: had to refactor the nav menu to make it more flexible/reusable - should have that wrapped soon, then hooking it up to login [19:15:51] kaity: also i'm a little confused by the need of a drop down when it is a binary switch. [19:16:08] mhurd: hmm, ok. I guess you get cookie handling for free? :) [19:16:16] YuviPanda: should also make it easier to make the edit page look more like may's design [19:16:27] mhurd: hmm, right [19:16:40] YuviPanda: not sure about cookie [19:17:14] mhurd: hmm, okay. I am trying to figure out how to handle login to multiple wikis easily [19:17:34] WorstPanda: that's another story for another day haha [19:18:13] mhurd: well, we have to support it anyway, no? if I am editing something, use the 'go to other languages' to go to another wiki, and edit there, I should still be making edits as my logged in account [19:18:17] WorstPanda: good catch though. how does mobile web do that? [19:18:45] YuviPanda: ya, for sure [19:19:00] mhurd: CentralAuth! [19:19:13] mhurd: so you construct some sort of special cookies, I think. I'm trying to find someone who knows about it [19:19:26] mhurd: this is also why you can login to english wiki, go to another wiki and you are already logged in [19:19:35] YuviPanda: "special cookies"... hahah [19:19:44] mhurd: :D now I want some! [19:19:50] :) [19:19:52] vio [19:19:55] damn :P [19:20:07] YuviPanda: haha i know [19:20:13] mhurd: but yeah, these are special cookies - they fuck you up :P Mobile Web had to spend a lot of time dealing with it [19:20:23] lol [19:20:45] awjr: i added a final paragraph to the doc. take a pass on it [19:20:52] k [19:20:58] will do shortly tfinc [19:21:33] MaxSem: around? [19:21:40] yep [19:22:04] MaxSem: do you know about CentralAuth cookies? [19:22:18] nobody does:P [19:22:22] MaxSem: heh :D [19:22:30] MaxSem: know about it better than I do? :) [19:22:37] prolly [19:23:01] MaxSem: so, how do I make them work? :D Can I construct cookies to make the API count me in as logged-in without having to do the login flow on each wiki? [19:23:18] NEVER [19:23:24] ...construct cookies [19:23:25] MaxSem: :( [19:23:28] MaxSem: err, I mean [19:23:31] MaxSem: steal cookies? [19:23:48] MaxSem: well, take cookies from wiki 1 where I logged in, and then set them to be sent for other domains too? [19:23:50] this is actually an interesting problem [19:23:51] or something? [19:24:07] do you expect so much cross-wiki editing? [19:24:17] MaxSem: good question. [19:24:20] MaxSem: not too much, but a bit. [19:24:34] MaxSem: I mean, we don't have meta or commons on the list... [19:24:43] MaxSem: however, eventually we would have commons and wikidata [19:25:02] wouldn't it be easier to just login whenever needed? [19:25:15] centralauth solves that by making requests to all of the domains to set cookies [19:25:17] MaxSem: it would be, but I hate making extra HTTP requests when none are needed [19:25:25] awjr: oh? [19:25:28] you could theoretically duplicate that functionality [19:25:42] awjr: oh, wait. you mean when you first login it makes requests to all domains to set cookies? [19:25:47] awjr: what is this request? [19:25:51] yeah YuviPanda [19:25:52] awjr: and this is the images that were loaded, I presume? [19:25:54] yeah, CA makes extra requests too:P [19:26:00] awjr: I thought that was killed in CA2? [19:26:07] oh that is possible [19:26:14] if that's the case then i have no idea how it works now [19:26:19] awjr: haha! [19:26:32] :p [19:26:34] MaxSem: yeah, login on each wiki is always a possibility [19:27:17] so I recommend you to forget about CA until you need tyo implement some wiki-hopping workflow [19:27:40] YuviPanda: it sounds like it SUL2 works basically the same way, but you log in via a central login wiki (rather than directly to a specific project) [19:27:50] awjr: oh [19:27:54] https://www.mediawiki.org/wiki/Extension:CentralAuth#.22SUL2.22_behavior [19:29:13] awjr: MaxSem hmm, even with SUL2 there seems to be 1 request per project [19:29:18] so hmm, not much of a difference there [19:29:22] that is my understanding [19:29:30] im not sure how else you would do it [19:29:32] awjr: MaxSem hmm, why is it one request per *project*, not domain? [19:29:35] I only care about one project [19:29:44] like *.wikipedia.org you mean? [19:29:47] yeah? [19:29:54] the app only does *.wikipedia.org now [19:30:35] someone should really fix bug 1 [19:30:38] that's probably a design choice worth asking someonel ike chris steipp about [19:30:44] hmm, right [19:30:54] i can iagine that that would give you finer grain control over access should the need arise [19:30:55] but i dunno [19:30:56] awjr: I mean, if there's a way for me to login to all wikipedias with one request... [19:31:11] mhurd: the ToC meeting has no hangout. [19:31:11] YuviPanda: yeah, ask chris [19:31:15] awjr: ok [19:31:45] YuviPanda: ah! i'll find may and see if that meeting's still happening... brb [19:31:49] mhurd: ok! [19:32:07] awjr: but we can always fall back to just making the Login requests in the background. Unlike the web we *can* do that async :) [19:32:20] although I think mobile web can do it now too, since IIRC we are https onlY? [19:32:29] oh, nevermind. we aren't [19:32:45] YuviPanda: that is nice [19:32:47] per domain, not project [19:33:01] MaxSem: but when it loaded the images, it didn't load one for 200+ wikipedias, no? [19:33:04] or all 800+ wikis [19:33:17] no i think it does *.wikipedia.org [19:33:44] hmm, I could do that [19:34:21] you're overcomplicating [19:34:39] in 99% of cases users don'r need commons [19:34:48] YuviPanda: there should be hangout link in calendar invite [19:34:51] when they need, you'll log them in [19:37:57] MaxSem: alright. [19:38:17] tfinc lgtm [19:38:24] awjr: thanks [19:38:27] :) [19:44:42] (03PS1) 10Dr0ptp4kt: Add API check for official apps support, with verbiage. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111247 [19:47:05] ^ yurik, would you please review? [19:47:17] dr0ptp4kt, looking [19:47:41] yurik, i think it makes more sense to use the 'type' field than to introduce an 'agent' parameter. [19:49:26] dr0ptp4kt, not exactly - i think we should have an extra param for that - specifying which app needs this info. This way we could make each app pass its own value (similar to useragent), and server could take different descisions [19:49:59] yurik, alternatively we could have 'androidapp' and 'iosapp' in the type field [19:50:35] or just 'android' and 'ios' [19:51:57] dr0ptp4kt, we could do that, but why would you want to add "app" to the valid values of the config? [19:52:07] mhurd: brion YuviPanda: have you taken a pass on the candidate list? if so pm me and let me know your thoughts. dont mention candidate names in the channel [19:53:38] tfinc: i think they're still working on getting me added to the whitelist to view those [19:53:45] yurik, if we went with distinct agents, we could just add them to the 'sites' field. e.g., ["m.wikipedia", "android", "ios"]. we have a carrier that specifically does NOT want the verbiage in the app, strangely enough [19:53:54] i can log into jobvite and see the job listing but i an't do anything but apply :) [19:55:05] dr0ptp4kt, we could have an extra value "disableInApp" or something like that, but overall i think we should have the same logic for everyone. and that logic will depend on the overall params, not specific user agent [19:56:10] moizsyed: Hey moiz, I'm going to start working on the overlay tweaks today. When do you want to meet? [19:56:51] kaldari: lets meet right now [19:57:06] moizsyed: can we get lunch first? [19:58:09] yurik, i think we need to talk on hangout so that i understand better. i'll call you shortly, ok? [19:58:25] ok [20:00:09] yurik, i started the hangout [20:03:55] wee https://gerrit.wikimedia.org/r/111250 [20:15:37] brion: around?: [20:15:42] YuviPanda: yo [20:15:51] brion: patches? :D [20:16:00] got em open right here :D [20:16:59] brion: do it! [20:18:23] Set-Cookie2? oh man [20:18:51] (03PS7) 10Jdlrobson: QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 [20:18:53] (03PS2) 10Jdlrobson: Hygiene: Distinguish between wikitext and VE editor in browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111241 [20:18:55] (03PS8) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [20:18:57] (03PS1) 10Jdlrobson: QA: Make the visit page rule more generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111252 [20:18:59] (03PS1) 10Jdlrobson: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 [20:19:17] YuviPanda: Set-Cookie2 is listed as obsoleted in http://tools.ietf.org/html/rfc6265#section-9.4 [20:19:25] i don't think we have anything using it? [20:20:19] brion: hmm, probably not [20:20:27] brion: I took the code from AOSP and modified it [20:20:30] brion: I can get rid of it [20:20:33] (03CR) 10Brion VIBBER: Add a persistant cookie store backed by SharedPreferences (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111167 (owner: 10Yuvipanda) [20:21:05] brion: everything else looks ok? [20:21:06] on [20:21:07] that? [20:21:17] still looking [20:21:22] brion: ok! [20:21:30] brion: It doesn't support expiry or per-path stuff but I think that's ok [20:23:44] YuviPanda: any security implications to using shared prefs to store active session token cookies? [20:23:47] or is that reasonably safe [20:23:58] brion: well, if something has root on your device it can get it. [20:24:05] brion: but if something has root on your device you are fucked anyway [20:24:08] heh [20:24:12] brion: we will also probably end up storing passwords there [20:25:03] brion: unencrypted. [20:25:06] *cringe* [20:25:10] not going to use the android account system? or using that with the stuffs... [20:25:51] brion: no, it's far too complex. too much async stuff, and the only thing it buys us in the end is the ability to let other apps use our login [20:25:55] not any more or less secure [20:25:57] YuviPanda: so there's really no default CookieManager implementation that uses a file or whatever? [20:26:04] brion: none at all [20:26:08] wow :D [20:26:09] brion: I looked for 2 days! [20:26:09] ok [20:26:17] brion: the default one just stores it in memory [20:26:39] (03CR) 10Brion VIBBER: "Test cases?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111167 (owner: 10Yuvipanda) [20:27:00] brion: the login is a test case for this [20:27:06] brion: since the login won't work if this doesn't [20:27:15] \o/ [20:27:19] brion: I can't think of a simple way to test just this, since I can't force an app restart [20:27:25] brion: let me remove Set-Cookie2 [20:27:29] ah i see [20:27:29] ok [20:27:50] yeah if dropping the OKHTTP* session and restarting it would confirm then that's an easy unit tests case [20:27:55] YuviPanda, hi. [20:27:58] if it requires app restart then no that's tough [20:28:01] hi gry [20:28:03] YuviPanda, the mobile frontend has a hack for main pages. [20:28:05] brion: yeah [20:28:10] gry: yup! [20:28:18] YuviPanda, so the edit button is not displayed. Is this possible for non-main pages? For any other pages? [20:28:26] YuviPanda: brion: food time [20:28:30] gry: hmm, not that I can think of [20:28:34] gry: MaxSem would know more, I think? [20:28:43] nom nom [20:28:58] MaxSem, YuviPanda, I want to make a quick mobile app, like a wizard, and it doesn't /need/ an edit button visible in mobile frontend. How can I do this? [20:29:27] I... have no idea, gry :( I don't think anyone has done something similar before, so you are blazing a new path [20:29:56] That's ok, I've just mentioned you in my last line in-case you suddenly find an answer, so you would share. [20:30:07] gry: I would! [20:30:10] :) [20:30:45] YuviPanda, I don't remember. In the Android app would you want to implement this? https://commons.wikimedia.org/wiki/User:Gryllida/Galleries (I would think I already shared the link with you, but I don't remember your reaction) [20:31:25] mhurd: YuviPanda: have you guys taken a pass on the candidates? again no names in here please [20:31:54] tfinc: I logged in an hour or so ago, was looking at them when I had to run to a meeting. I'll email you tomorrow. [20:32:28] trying to sort it to see only those in consideration, seems a bit iffy (the UI) [20:32:32] YuviPanda: thanks i meet with emily @ 2 so get it to me no later then noon pst [20:32:38] what about you mhurd ? [20:32:44] tfinc: that's Wednesday 2PM PST, right? [20:32:50] YuviPanda: correct [20:32:53] tfinc: gothca [20:32:57] *gotcha [20:33:03] i'll need time to review whatever feedback you provide [20:33:29] tfinc: yeah, I'll send it in before you guys wake up [20:33:35] perfect [20:34:35] YuviPanda: ideally highlight 3-5 people you really like and what gets you excited about them. make sure you only look at the ones for in consideration. i filtered out a bunch that weren't worth our time [20:34:54] YuviPanda: brion how goes crafting a task for it [20:34:55] ? [20:34:56] tfinc: does that mean I ignore the 'New' as well? [20:35:02] (03CR) 10Brion VIBBER: "Re: CentralAuth -- in the old system at least, on login some of the cookies would be for the global session, and when you sent those cooki" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111174 (owner: 10Yuvipanda) [20:35:08] Mrrrm. [20:35:29] gry: so eventually the commons app will be rolled into the wikipedia app, and we would probably have things like that [20:35:34] gry: not in the near future though :( [20:35:35] YuviPanda: new is fine. those are new applicants that i haven't had a chance to look at yet so feel free to do a pass and flag them to me [20:35:44] tfinc: ok! [20:37:01] the'll be working closest with you so your opinion counts a lot to me on this [20:37:11] just remember to refer back to the jd if your not sure that their a good fit [20:37:15] tfinc: ok! [20:43:12] (03CR) 10Brion VIBBER: "(test case is login in next commit)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111167 (owner: 10Yuvipanda) [20:43:20] YuviPanda: you updating that or shall i merge it? [20:43:56] brion: let me update [20:44:16] k [20:45:06] (03PS3) 10Yuvipanda: Add a persistant cookie store backed by SharedPreferences [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111167 [20:45:08] (03PS2) 10Yuvipanda: Add FetchEditTokenTask + check for LoginTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111177 [20:45:09] brion: pusehed [20:45:10] *pushed [20:45:10] (03PS2) 10Yuvipanda: Add a LoginTask + Tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111174 [20:46:05] tfinc: brion responded with idea for initial task. let me know if you find that okay, and I can write it up in more detail [20:47:07] i'll be happy to once my jobvite login is sorted out :D [20:47:26] brion: pfft, this is on email :P [20:47:31] ah good i can reply :D [20:48:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add a persistant cookie store backed by SharedPreferences [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111167 (owner: 10Yuvipanda) [20:52:11] MaxSem: lol, apparently action=login doesn't touch CA at all :D Chris is investigating now [20:52:34] YuviPanda, it would seem my last message was directed at you. (I can't think of a less obnoxious way to show it to you other than to ask again, sorry.) [20:54:44] gry: I did respond after your mrrrm? [20:54:47] 02:05 YuviPanda: gry: so eventually the commons app will be rolled into the wikipedia app, and we would probably have things like that [20:54:49] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add a LoginTask + Tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111174 (owner: 10Yuvipanda) [20:54:51] 02:05 YuviPanda: gry: not in the near future though :( [21:01:35] (03CR) 10Brion VIBBER: [C: 04-1 V: 04-1] "DoEditTask fatals out and kills the process because it tries to edit with the generic \+ token, although I have a live session in cookie s" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111177 (owner: 10Yuvipanda) [21:02:00] brion: gagaggag! [21:02:01] brion: hmm [21:02:02] ok [21:02:05] :D [21:02:29] brion: well, edit token handling would be a separate commit anyway [21:02:32] you either need to clear out the cookies when you don't want them to be live, or check the available tokens... [21:02:36] but yeah, it's ok to not merge this until that comes out [21:04:08] brion: I am guessing I can take code out of SharedPreferenceCookieManager and use that for edit tokens too [21:10:25] it's kinda like a cookie :D [21:11:37] can someone export the data from *jobvite so it's readable? [21:11:50] i have to write *jobvite because if i just type it autocorrect turns it into obviate [21:11:53] which amuses me [21:15:52] ah thanks! [21:16:28] brion: :P [21:16:30] hehe [21:16:34] brion: hehe [21:37:25] yurik: can you point me to the bug [21:37:28] ? [21:37:46] mhurd: hey! [21:37:53] YuviPanda: heya! [21:38:06] mhurd: turns out there might be an easy way to do that thing ('cross wiki login'). Let me verify and get back to you [21:38:14] I just talked to chris bout it [21:38:17] YuviPanda: oh that's awesome! [21:41:00] (03CR) 10Awjrichards: [C: 04-1] "The changes themselves look OK, but as I understand it, the convention is to match the steps file name with the feature file name. Should " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111241 (owner: 10Jdlrobson) [21:43:12] (03CR) 10Awjrichards: [C: 031] "+2-ready, pending changes to dependency" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111252 (owner: 10Jdlrobson) [21:46:38] brion: how goes amending those translate patch sets? i really want us to move past them [21:47:04] kenanwang_: you about ? [21:47:20] (03CR) 10Awjrichards: "ve-editor.feature tests do not pass with this:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson) [21:50:01] tfinc: poking at 'em [21:51:34] mhurd: want to look at paper app together and video record for yuvi? [21:52:03] mhurd: holler when you have time [21:52:34] hi violetto [21:52:53] violetto: ya for sure! anytime works for me [21:52:56] YuviPanda: why hello [21:53:13] violetto: வனக்கம்! [21:53:19] violetto: better? :) [21:53:30] yurik: https://developers.google.com/speed/webp/ [21:54:30] YuviPanda: http://www.urbandictionary.com/define.php?term=why%20hello [21:54:50] violetto: hey that should have a comma! [21:54:54] yurik: https://en.m.wikipedia.org/wiki/WebP [21:55:03] YuviPanda: nobody got time for comma [21:55:03] violetto: why, helloooo! [21:55:04] :P [21:55:31] ;p digging out reference stuff for you [21:55:46] (03CR) 10Jdlrobson: "Awjr.. you will need the VE dependency..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson) [21:55:51] violetto: :D ok [21:56:07] a frick a frack. new Xcode beta [21:57:19] yurik: they even have a converter online under https://developers.google.com/speed/webp/download so it'll be a quick spike for you to see if it makes a large difference [21:59:20] violetto: okay, I should go sleep. 1.5hr past my bedtime :( [21:59:25] violetto: email? [21:59:43] YuviPanda: yes [21:59:49] violetto: ok, thanks! [21:59:59] nitenite! [22:01:12] (03CR) 10Awjrichards: "Oops. With the VE dep, I still get one failure:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson) [22:08:47] brion: another xcode beta? [22:11:26] DarTar: do we have account reg data before 2007? [22:12:34] we do but they get messy before late 2005 / early 2006 [22:13:25] kenanwang_: we have a proposal in the pipeline to infer registration dates for early years from available data [22:13:46] mhurd: yep. beta 5 [22:15:42] mhurd: nothing substantive enough in the iOS 7.1 beta for me to bother installing it, but i'm keeping Xcode 5.1 beta current for those auto layout tweaks in interface builder :) [22:16:26] yurik: http://caniuse.com/webp [22:16:50] that gives us the support map we've been looking for [22:18:06] tfinc, IE, firefox, safari, opera mini, and all i* devices not supporting it? what's the point [22:18:42] kenanwang_: I'm in a separate channel, but let me know what kind of data you're interested in and what for [22:24:05] brion: ya i'll update too [22:24:14] spiff [22:25:16] (03PS2) 10Jdlrobson: QA: Make the visit page rule more generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111252 [22:25:18] (03PS2) 10Jdlrobson: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 [22:25:20] (03PS8) 10Jdlrobson: QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 [22:25:22] (03PS9) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [22:25:24] (03PS1) 10Jdlrobson: Add unique route for Visual Editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111348 [22:27:45] (03CR) 10Jdlrobson: "editor.feature also contains the generic rule" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111241 (owner: 10Jdlrobson) [22:28:09] (03CR) 10JGonera: [C: 032] Use MediaWiki UI buttons in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102581 (owner: 10Jdlrobson) [22:28:45]