[00:00:11] tfinc still out tomorrow [00:00:18] kenanwang_: i moved it [00:00:27] kenanwang_: sprint needs trimming if you didn't see my message earleir [00:00:38] got it [00:00:48] jgonera, stroke-width="NaN" :( https://gerrit.wikimedia.org/r/#/c/109024/1/less/common/images/external-link-rtl-icon.svg [00:01:43] kenanwang_: given that your out can you move the q2 review meeting ? [00:01:57] Krinkle: so i've been attempting to untangle the RL dependency tree but essentially it looks like i'm creating a new module for each existing module which is bad [00:02:21] i could really do with help from your team maybe rmoen to strip out the styles - it's causing some serious congestion on our gerrit train... [00:04:03] (03PS1) 10Jdlrobson: Hygiene: Rename editor-ve [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111379 [00:04:22] MaxSem, thanks, if you have time, report/find it on svgo's issue tracker, if not, I'll do it later [00:05:36] jdlrobson: don't forget that Krinkle is in the office with us [00:06:00] (03PS1) 10Jdlrobson: Fix button bar in alpha - stop it looking like a link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111380 [00:06:09] tfinc: yeh i know we just spoke in person [00:06:14] k [00:06:18] he seemed busy so i don't want to bug him [00:06:35] (03PS9) 10Jdlrobson: QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 [00:07:14] (03PS1) 10Dr0ptp4kt: Suggested use of XCode 5.1 to get storyboard working. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111381 [00:08:54] (03CR) 10Jdlrobson: [C: 032] Return languages link when only variants are available in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111371 (owner: 10MaxSem) [00:09:14] kenanwang_: i'm having some trouble putting together the narrative that you wanted for http://mobile-reportcard.wmflabs.org/ ... what did you have in mind ? [00:09:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ah yes good to mention this :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111381 (owner: 10Dr0ptp4kt) [00:12:26] (03Merged) 10jenkins-bot: Return languages link when only variants are available in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111371 (owner: 10MaxSem) [00:12:29] jdlrobson, jgonera, MaxSem: VectorBeta fixes should be on testwiki now, please test [00:14:12] kaldari: confirmed to be working [00:14:40] (03CR) 10Jdlrobson: [C: 032] Fix variant URLs in beta JS language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111369 (owner: 10MaxSem) [00:16:38] (03Merged) 10jenkins-bot: Fix variant URLs in beta JS language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111369 (owner: 10MaxSem) [00:47:05] (03PS2) 10Kaldari: Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 [00:47:11] (03CR) 10jenkins-bot: [V: 04-1] Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari) [00:56:49] (03PS3) 10Kaldari: Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 [01:00:55] jdlrobson: kaldari mhurd : noticing that you guys didn't put in a proposal for Zurich or Wikimania [01:00:58] err [01:01:02] scratch jdlrobson [01:01:07] jgonera: --^ [01:01:09] yeh i was gonna say.. [01:01:10] tfinc: I'm here until the end of this week (been here 3 weeks then). So if you've got anything for me (work or non-work), shoot me :) [01:02:39] tfinc, where should we put it and what is the deadline? I did put a few things in the signup form [01:03:09] jgonera: deadline has already passed and i dont see you on the list of people who applied [01:03:28] tfinc, where is that list? [01:03:34] tfinc: hmm... would you have a bit of time to maybe chat about that after our 1:1 meeting tomorrow? [01:03:45] I mean, I submitted the form that Quim sent out [01:03:50] Tfinc key thing right now I think is readership [01:04:04] jgonera: its a private list that quim is managing for approvals [01:04:33] mhurd: lets talk about on way to DP [01:04:42] as i want to settle it quick [01:04:48] tfinc, I don't see him around, I'll talk to him tomorrow I guess? [01:04:55] tfinc: sounds good! [01:05:03] jgonera: he would be in Brussels for FOSDEM [01:06:11] jdlrobson: what was that other change you wanted me to review? [01:06:32] kaldari: any of them [01:16:01] mhurd: leave time in 15min [01:16:12] tfinc: k [01:20:11] kenanwang_: i'm getting some updated stats from toby too [01:21:10] tfinc: may and i refined the latest design assets board some more today - it's pretty fleshed out now :) https://trello.com/b/Id6qXKSY/mobile-app-latest-design-assets-by-page [01:21:38] mhurd: makes me want to have a large screen just to see those [01:22:08] tfinc: hehe yeah. thankfully each list will only have 3 cards [01:22:49] tfinc: can't speak for others, but i'm finding it insanely useful [01:23:27] mhurd: bring it up at the retrospective and lets find out if others are using it [01:23:39] tfinc: ya [01:23:45] will do [01:29:01] yurik yurikR you there? [01:34:50] anyone know how to pull up a web browser on a BlackBerry 8900? [01:35:17] nevermind, I found it [01:42:14] (03PS3) 10Jdlrobson: Hygiene: Wrap parameters in quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111124 [01:42:21] (03CR) 10Kaldari: [C: 032] Hygiene: Wrap parameters in quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111124 (owner: 10Jdlrobson) [01:43:24] (03Merged) 10jenkins-bot: Hygiene: Wrap parameters in quotes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111124 (owner: 10Jdlrobson) [01:59:28] (03CR) 10Kaldari: [C: 04-1] "Need to clean-up our use of the class "header". With this patch, some special pages like Watchlist and Preferences have two .header divs. " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 (owner: 10Jdlrobson) [02:00:52] (03PS1) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [02:28:19] (03PS1) 10Dr0ptp4kt: Add X-Zero-Rated: 1 header for API responses that are zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 [02:31:07] (03PS2) 10Dr0ptp4kt: Add X-Zero-Rated: 1 header for API responses that are zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 [02:32:44] ^yurik yurikR. heading out [14:33:36] hey brion [14:33:48] yo [17:53:01] (03CR) 10MaxSem: "What's the use case for this? Are we going to vary API responses by this header?" (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 (owner: 10Dr0ptp4kt) [17:53:18] (03PS1) 10Cmcmahon: Clicking the list item does not invoke the editor in Firefox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 [17:58:31] (03PS3) 10Dr0ptp4kt: Add X-Zero-Rated: 1 header for API responses that are zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 [18:05:32] Tfinc FYI I'm still at offsite won't make stand up [18:06:06] Awjr in case it wasn't clear I'm offsite and can't make standup [18:12:02] (03CR) 10Yurik: [C: 032] Add API check for official apps support, with verbiage. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111247 (owner: 10Dr0ptp4kt) [18:12:04] (03Merged) 10jenkins-bot: Add API check for official apps support, with verbiage. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111247 (owner: 10Dr0ptp4kt) [18:13:16] dr0ptp4kt i'm about to deploy bits stuff and the api [18:15:34] MaxSem, I forgot to ask, have you reported/investigated the stroke-width=NaN thing? [18:16:20] jgonera, it was time to sleep for me so I just googled a bit for it. seen a few similar bugs but apparently not this particular one [18:16:32] ok, thanks, MaxSem [18:17:08] brion: yo [18:17:58] kenanwang_: aye [18:18:04] (03CR) 10Dr0ptp4kt: "@MaxSem, the hope was to not vary if at all possible (assumes everything of consequence reaches origin). That said, I guess if it's absolu" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 (owner: 10Dr0ptp4kt) [18:18:10] kenanwang_: there was one bug we couldn't triage without you; i just sent an email about it [18:18:36] (03CR) 10Dr0ptp4kt: "I meant "three", not "two"...approaches." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 (owner: 10Dr0ptp4kt) [18:20:21] ergh https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#mobile_watchlist_grayed_out...or_greyed_out_if_you.27re_european.. [18:23:55] greyed out? [18:27:53] MaxSem: I can't reproduce the watchlist bug. Is it really just for Europeans?? [18:28:15] What does it look like in Russia? [18:28:19] (03PS1) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [18:28:36] kaldari, I don't have a Xoom to test [18:41:03] violetto: http://en.wikipedia.org/wiki/Special:RecentChanges [18:41:13] violetto: https://en.wikipedia.org/w/index.php?namespace=0&tagfilter=&title=Special%3ARecentChanges [18:47:44] violetto: https://en.wikipedia.org/wiki/Wikipedia:Typo_Team [18:47:50] mhurd: https://en.wikipedia.org/wiki/Wikipedia:Typo_Team [18:48:17] violetto: mhurd https://en.wikipedia.org/wiki/Wikipedia:Tyop_Contest [18:53:10] (03PS2) 10Jdlrobson: QA: Ensure edit link fires in Firefox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [18:53:25] (03CR) 10Jdlrobson: [C: 04-1] "Also amended commit message to be more descriptive and include QA prefix..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [18:58:15] violetto: mhurd https://en.wikipedia.org/wiki/User_talk:Yuvipanda [19:07:52] kaldari: ping? is there an API call or some such that tells me the last X 'wikilove' actions? [19:08:01] kaldari: similar to recentchanges, but only for wikilove? [19:08:50] YuviPanda: They are recorded in Special:Logs, which I assume has an API [19:09:13] ah, hmm [19:09:14] yes, it does [19:09:17] I wonder how fast it is [19:09:20] * YuviPanda goes to check [19:09:26] kaldari: is it also deployed on all wikis? [19:09:30] sorry Special:Log [19:09:48] Yes, should be deployed to all WMF wikis [19:09:53] ah, wonderful! [19:10:13] hmm, docs don't tell me what the name of the event is [19:10:16] * YuviPanda goes to source [19:10:24] YuviPanda: what mischief are you up to anyway? [19:10:46] I think the event is something like 'thanks-thank' [19:10:48] kaldari: we are considering a rootatingish stream of recent edits on the app's 'default' screen [19:11:04] kaldari: thank? wikilove calls its events thank? [19:11:04] (03PS2) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [19:11:06] (03PS2) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [19:11:25] kaldari: and I just showed violetto WikiLove today, so we wanted to see if we can show that in the stream as well [19:11:33] oops, sorry, for some reason I though you were talking about Thanks. Brain failure... [19:11:49] WikiLove isn't in Special:Log... [19:12:08] WikiLove is logged, but the log doesn't have an API :( [19:12:17] kaldari: ough :( [19:12:33] kaldari: any reason why it doesn't log to Special:Log? [19:13:04] no reason in particular [19:13:07] kaldari: is there any way to see the log it is logging to? [19:13:16] I suppose I could just patch it to log to Special:Log [19:13:53] (03PS3) 10Cmcmahon: QA:Clicking the list item does not invoke the editor in Firefox Also, wait properly before hitting 'Submit' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 [19:15:27] YuviPanda: It just logs to the wikilove_log table [19:15:31] right. [19:15:44] kaldari: but it's write only at this point, from what I can see in the code [19:16:03] YuviPanda: yes, although there's a limn graph somewhere that's using it [19:16:08] ah [19:16:10] hmm [19:16:12] but no API [19:16:21] well, I could add it to Special:Log, and nothing would be lost [19:16:38] kaldari: I also see your comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=58192, so I guess I could take a shot at that as well [19:16:46] and make it use mw.ui.buttons when I'm at it [19:17:06] kaldari: I suppose I won't be stepping on any toes if I try to do that? :) [19:17:20] (03PS4) 10Cmcmahon: QA:Maintenance and robustification [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 [19:17:31] YuviPanda: Go for it! [19:17:54] kaldari: sweet! Thanks :) Think you'll have time to review patches if I make them? [19:18:38] jdlrobson: https://gerrit.wikimedia.org/r/#/c/111474 should make the builds happier. [19:18:58] YuviPanda: Probably, I usually review anything that comes in for it, but sometimes I'm slow depending on other priorities. [19:19:11] kaldari: hmm, ok! I'll try get something out :) [19:19:14] a vagrant role first :) [19:19:35] jdlrobson: there may still be an issue with timing on the Submit button, but this is much better [19:19:44] chrismcmahon: you've ignored my -1 :) [19:19:50] > JavaScript as long as we could ensure the user was on http at the time [19:19:55] (03CR) 10Jdlrobson: [C: 04-1] QA:Maintenance and robustification (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [19:19:58] jdlrobson: you mean HTTPS? [19:20:09] ah it didn't publish that's why chrismcmahon my apologies :) [19:20:17] (03CR) 10Jdlrobson: QA:Maintenance and robustification (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [19:20:28] argg gerrit infuriates me sometimes [19:20:57] dr0ptp4kt: i can replicate what you were talking about [19:21:00] we could graphy fury vs. time [19:21:05] graph* [19:21:06] guys ekkk http://en.m.wikipedia.org/wiki/Main_Page has a table of contents for some reason in stable [19:21:11] jdlrobson: a bunch of us are playing with phabricator at fab.wmflabs.org, btw. Request an account if you want to play around with it too :) [19:21:16] ^ kaldari [19:21:51] jdlrobson: i don't get a TOC... [19:21:55] jdlrobson: I don't see it [19:22:04] i don't understand why [19:22:28] jdlrobson: I don't either [19:22:34] (am logged out) [19:22:45] mm.. it's only kicking in on large screens so that makes me slightly less concerned [19:23:02] hmm, it's not kicking in on my laptop or phone [19:23:08] logged in or out [19:23:23] jdlrobson: I'm not sure I understand what you mean. Want to go ahead and make the change on the branch? [19:24:12] jdlrobson: if it's an IP where we don't force HTTPS for UserLogin then I guess you can do it regardless of proto [19:27:31] chrismcmahon: sure [19:29:24] toc only shows up for me in Firefox, not Chrome or Safari [19:31:35] kaldari: super weird [19:32:17] kaldari: jgonera you wanted this so please review asap before the merge conflicts appear :) https://gerrit.wikimedia.org/r/#/c/111146/ [19:32:38] chrismcmahon: looking at your patch now [19:33:00] jdlrobson: looks like page.isMainPage() is returning false for some reason [19:33:07] kaldari: hah! [19:39:33] (03PS5) 10Jdlrobson: QA: Maintenance and robustification [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [19:39:35] ^ chrismcmahon feel free to +2 if happy [19:39:50] (03CR) 10Jdlrobson: [C: 031] "Made slight tweak to page definition. +2 if happy." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [19:41:08] jdlrobson: did you mean to include the file foo.diff? https://gerrit.wikimedia.org/r/#/c/111474/5/tests/browser/foo.diff [19:41:12] arrgg [19:41:25] didn't think so ;-) [19:41:31] (03PS6) 10Jdlrobson: QA: Maintenance and robustification [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [19:41:41] (03CR) 10Jdlrobson: [C: 031] "Goodbye foo.diff" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [19:50:43] kaldari: https://gerrit.wikimedia.org/r/#/c/111511/ :) [19:50:48] more on the way [19:55:12] violetto: do you have an announcement? [19:56:17] jdlrobson: sounds like a very ominous question :) [19:56:26] (03CR) 10Kaldari: "I think I would prefer 'mobile.special' over 'mediawiki.special' since no one's ever going to check MobileFrontend for potential module na" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111146 (owner: 10Jdlrobson) [20:01:19] jdlrobson: what kind of announcement? [20:01:59] violetto: i was just being silly. I said the phrase "i'm making it an enhancement" and kaldari heard "May has an announcement" and got excited. I was hoping you did have one as he seemed disappointed when he realized he'd misheard me [20:02:28] jdlrobson: lol, i'll think of something interesting [20:03:18] I can't wait for your big announcement! [20:03:48] haha :) [20:04:07] kaldari: making the form use agora seems to be a little tougher, I'll take a shot at it later [20:04:34] YuviPanda: Right now all of WikiLove is using jQuery.UI [20:04:51] kaldari: yeah, I guess we can make it not use any jQuery UI? except the dialog box maybe [20:05:21] YuviPanda: I would like to move it to oojs-ui, but I think moving it right now might be a bit premature [20:05:23] kaldari: I don't think mw.ui has a dialog thing [20:05:30] kaldari: I'd agree, yeah. [20:06:01] kaldari: Soon(tm). :) [20:06:35] kaldari: I am submitting a vagrant role now [20:12:01] (03CR) 10Cmcmahon: [C: 032] "The test is better but it will fail for now because of Bug 60912" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [20:12:03] (03CR) 10MaxSem: [C: 04-1] Special:MobileWebApp and Special:Manifests (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 (owner: 10Jdlrobson) [20:12:37] (03Merged) 10jenkins-bot: QA: Maintenance and robustification [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111474 (owner: 10Cmcmahon) [20:16:17] jdlrobson: bug seems to be at the intersection of VE, Parsoid, and MobileFrontend: https://bugzilla.wikimedia.org/show_bug.cgi?id=60912 [20:17:32] (03CR) 10MaxSem: "Ugh, do we vary API requests by all the usual Zero headers too?" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 (owner: 10Dr0ptp4kt) [20:18:09] MaxSem: we don't cache the API at all, do we? [20:18:27] we do - everything depends on module [20:18:45] MaxSem: o_O I thought they all hit origin servers... [20:18:52] mobileview hits vagrant? [20:19:12] err [20:19:12] varnish [20:19:13] dammit [20:19:25] see ApiMain::setCacheMode() [20:19:35] hmm [20:20:26] I'm ain't saying that it's not broken and actually works:P but it's suposed to:P [20:20:34] MaxSem: :P [20:20:44] MaxSem: I see mobileview is anon-public-user-private [20:20:49] yep [20:21:17] so if the user is logged in and I send out mobileview calls, they won't hit the varnish cache? [20:21:21] but do we hit the varnish cache otherwise? [20:21:54] basically, yes [20:23:08] YuviPanda: how is the android task coming along? [20:23:29] tfinc: I tested something with a local friend of mine, let me respond to the email again. [20:23:35] thanks [20:27:21] (03CR) 10Dr0ptp4kt: "Currently, no. For example, a request for http://en.m.wikipedia.org/w/api.php?action=query&titles=File:Albert_Einstein_Head.jpg&prop=dupli" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 (owner: 10Dr0ptp4kt) [20:35:08] brion: tfinc mhurd I responded on the android task [20:35:10] thread [20:37:46] \o/ [20:41:50] jdlrobson: apropos of https://bugzilla.wikimedia.org/show_bug.cgi?id=60912 , there is no more detail: try to use VE on beta; get spinner; go home. [20:44:26] YuviPanda (and kaldari who's not here) I'm sure Trevor would love to help you use OOjs UI. [20:44:54] James_F|Away: yeah, very probbaly. I'll take a look at the docs tomorrow [20:45:23] James_F|Away: also it might want at least some UI / UX tweaks. Most folks on the design team didn't even know this existed, so I should poke them and see what's up [20:45:59] YuviPanda: They didn't know that VE existed? :-) [20:46:11] James_F|Away: ah, I mean, WikiLove :P [20:46:27] YuviPanda: Ha, right. Yeah, WikiLove is a bit unloved… :-( [20:46:47] James_F|Away: yeah. I just submitted a patch to move the buttons to mw.ui, and get rid of jquery.ui buttons. now to find someone to merge... [20:46:58] Cool. [20:47:42] * YuviPanda adds James_F|Away to reviewers :P [20:47:49] YuviPanda: Cool. :-) [20:47:53] :) [20:50:36] YuviPanda: you got any more changes coming tonight i should review before weekly release? [20:50:52] brion: we have a weekly release? :) [20:50:56] ish [20:51:02] wait is that next week? [20:51:04] brion: I have the login change, it works for login, but not in the unit test [20:51:05] eh whatever [20:51:07] brion: it's sprintly :P [20:51:15] brion: let me send it up now anyway [20:51:21] ok :D [20:51:25] no rush [20:53:59] brion: nevermind, I think I found the bug [20:54:18] \o/ [20:56:22] kenanwang_: Hey Kenan, could you reply to https://bugzilla.wikimedia.org/show_bug.cgi?id=60103 [21:02:56] (03PS1) 10Yuvipanda: Store edit tokens properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111530 [21:02:56] brion: can you test this out? [21:03:12] brion: login in the UI works, but actual requests tell me I have an invalid token [21:03:19] hmm [21:05:49] kaldari: also, http://caniuse.com/#search=resize tells me that everything except supports autoresize. Can I just get rid of the jquery.elasticize depdency, and let IE users have a fixed width textbox? [21:05:57] seems graceful enough a degradation to me [21:08:02] hmm, that's sad that IE still doesn't support it [21:09:02] I guess it's OK to remove it anyway though [21:10:13] kaldari: it's also different functionality - it doesn't autoresize, only lets the user drag a handle to resize [21:11:19] kaldari: I guess that's okay too? [21:11:20] YuviPanda: well seems to log in and do one edit correctly :D https://test.wikipedia.org/w/index.php?title=Online_editing&diff=193924&oldid=193873 [21:11:28] brion: yeah! :D [21:11:31] brion: but the test fails. [21:11:34] brion: such confusion [21:11:43] heh [21:11:48] brion: try force closing the app and trying again? [21:12:43] YuviPanda: second edit successful after a close/reopen [21:12:48] weird eh? [21:12:51] brion: yeah, very [21:12:55] brion: idk what's up there [21:12:59] YuviPanda: editing on same wiki? [21:13:07] brion: yup, testwiki. loook at the code [21:13:11] if you're moving to a diff language it might esplode [21:13:14] hmm k [21:13:40] brion: yeah, I don't have centralauth yet [21:14:38] YuviPanda: DoEditTaskTests completes successfully for me [21:14:42] * brion looks suspicious [21:14:46] brion: oh?! [21:14:47] uhmm [21:14:51] just the abusefilter one fails [21:15:00] brion: first or second? [21:15:13] brion: because the anon edit on user page doesn't apply when you are logged in :P [21:15:21] brion: I will change that to target a different abusefilter [21:15:26] brion: we also need a way to force ourselves to be anon [21:16:30] YuviPanda: https://brionv.com/misc/wtf-tests.png [21:16:52] brion: yeah, all of them expect you to be anon, I guess [21:17:20] brion: I could uninstall app and reinstall and try, but I am scared of uninstalling, since it has lead to shitty results before [21:17:27] brion: we really need to setup jenkins to run these things [21:17:58] hehe [21:18:00] yeah [21:18:35] brion: I'll fix those in followup commits. [21:18:43] ok [21:19:37] brion: this should fix the failure in the previous commit tho [21:19:45] awesome [21:19:50] brion: do look at the code as well. EditTokenStorage in particular [21:21:23] kaldari: https://gerrit.wikimedia.org/r/#/c/111534/ [21:21:36] kaldari: -162 +1 :) [21:26:40] rmoen|away: can you ping me when you get back? [21:29:56] brion: merge? :D [21:33:38] kaldari: can you code review my stuff? otherwise i'll shoot you again... [21:34:00] hopefully with a nerf gun [21:34:35] jdlrobson: you mentioned this morning that you were going to dig into the test failures - any new insights? [21:34:44] awjr: did i not reply? [21:34:47] maybe i forgot too [21:34:52] * jdlrobson checks drafts [21:35:02] do i understand correctly that the enwiki failures should probably just go away tomorrow's enwiki deployment? [21:35:37] jdlrobson: you replied this morning where you said you'd be looking into the failures, at least that was the last i saw besides chris' response [21:36:23] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Still not sure I'm happy with use of prefs for storing these, but it'll do for now -- and most importantly it's encapsulated so we can cha" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111530 (owner: 10Yuvipanda) [21:36:37] brion: what else other than prefs? [21:36:44] (03CR) 10Brion VIBBER: [C: 032 V: 032] "some tests fixed in subsequent, others need adjusting still" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111177 (owner: 10Yuvipanda) [21:36:51] brion: they are heavily optimized for write-rarely-but-read-aa-lot scenarios [21:37:11] YuviPanda: dunno, but i would love to at least obscure them on disk :) [21:37:33] really we should have a sane token system that doesn't require us to store plaintext passwords [21:37:35] but that's for another time [21:37:38] brion: it already is protected with uid based permissions (on android each app gets its own username) [21:37:40] err [21:37:42] linux 'user' [21:37:44] right [21:37:57] jdlrobson: i have some time to help dig in to the test failures but didnt want to duplicate any efforts [21:38:02] i have no better suggestion offhand :) [21:38:14] brion: we could do some sort of crypto, but it's ultimately pointless, since there are no secrets there [21:38:24] yeah [21:38:32] DRM! ;) [21:38:45] awjr: i sent the email [21:38:51] k [21:38:54] brion: yeah. pretty much :P So anything beyond putting it in 'private' storage (protected by linux permissions) seems useless to me [21:39:23] yeah :P [21:44:18] jdlrobson: i could use some review on changes to the git log posting stuff: https://gerrit.wikimedia.org/r/#/q/mediawiki/tools/release+is:open+owner:%22Awjrichards+%253Carichards%2540wikimedia.org%253E%22,n,z [21:44:22] can you help out if you have a moment? [21:45:07] sure [21:45:22] let me sort out some ve stuff and i'll take a look [21:45:34] i'm keen to wrap up my existing patches before vacation [21:45:50] (if this can wait till friday that would be even better as that way i can just spend friday focusing on code review) [21:45:58] i don't think it's urgent jdlrobson [21:46:03] that sounds good [21:47:06] jdlrobson: head's up https://gerrit.wikimedia.org/r/#/c/110649/ needs a rebase [21:48:04] (03CR) 10Jdlrobson: [C: 04-1] "Also according to the story nothing was meant to change in stable apart from 2 things.... so I want to make sure that you are targeting al" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari) [21:48:46] awjr: will take a look [21:50:28] (03PS5) 10Jdlrobson: Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 [21:50:51] kaldari: https://gerrit.wikimedia.org/r/#/c/111380/ [21:50:54] really small change [21:51:19] awjr: really small change https://gerrit.wikimedia.org/r/#/c/111379/ [21:51:42] brion: I am considering playing with RoboElectric a bit. lets us run unit tests without an emulator. [21:51:51] (03CR) 10Kaldari: [C: 032] Fix button bar in alpha - stop it looking like a link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111380 (owner: 10Jdlrobson) [21:52:02] (03CR) 10Kaldari: [C: 032] Hygiene: Rename editor-ve [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111379 (owner: 10Jdlrobson) [21:52:27] (03Merged) 10jenkins-bot: Fix button bar in alpha - stop it looking like a link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111380 (owner: 10Jdlrobson) [21:52:58] (03Merged) 10jenkins-bot: Hygiene: Rename editor-ve [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111379 (owner: 10Jdlrobson) [21:55:19] (03CR) 10Awjrichards: [C: 032] Make pointer arrow responsive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110648 (owner: 10Jdlrobson) [21:55:54] (03Merged) 10jenkins-bot: Make pointer arrow responsive [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110648 (owner: 10Jdlrobson) [21:57:01] (03PS10) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [21:57:07] (03CR) 10jenkins-bot: [V: 04-1] Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson) [22:03:34] kaity|away: are we close to getting https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1521 unblocked? [22:03:48] brion: off to sleep now :) [22:03:50] bye [22:03:55] night night! [22:06:11] andre__: the mobile web team would like to make some changes to how MobileFrontend components are laid out in bugzilla and remove the MobileFrontend (beta) component - what's the best way for us to push forward on this? [22:10:18] kaldari: okay, changing it to 4 [22:10:23] :) [22:11:08] kaldari: done. [22:11:13] kaldari: merge, merge, merge! :) [22:11:38] kaldari: there's a a commit that one depends on [22:12:22] looking [22:18:01] kaldari: okay, am going to go head off to sleep :) too late. I hope it gets merged in time to ride tomorrow's train :) [22:18:26] YuviPanda: Just reviewed [22:19:15] kaldari: hmm, so I used 'constructive' button style for 'preview' and 'primary' for send. That seems semantically correct? [22:19:51] lemme ask design real quick. the colors are reversed for editing. [22:20:07] kaldari: ok! [22:21:14] kaldari: I could just add some margins around .submit [22:21:17] (with appropriate nesting [22:21:57] let me do that [22:23:42] kaldari: im sending you the svg icon for page issues page [22:23:46] kaldari: on email [22:26:06] moizsyed: yay [22:27:02] (03PS16) 10Jdlrobson: Story 1589: Use the same chrome on special pages as article pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 [22:27:48] YuviPanda: talked to Vibha, she said primary first, constructive second (even though that sounds backwards) [22:27:51] (03PS1) 10Jdlrobson: Hygiene: Make 'make clean' clean up all existing documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111618 [22:27:56] kaldari: lol [22:28:04] that made no sense to me, but ok [22:28:49] YuviPanda: She also said we need to create mw-ui-progressive and mw-ui-final aliases for those [22:28:55] which I'll do now... [22:29:28] kaldari: updated. also reversed order of dependencies, to make merging easier [22:33:07] jdlrobson: were in r32 [22:33:13] YuviPanda: merged [22:33:17] kaldari: woo [22:33:24] kaldari: thanks! [22:33:34] kaldari: I'll try to split things out tomorrow into different files, and also LESSify the CSS [22:33:41] now off to sleep [22:33:44] for real [22:47:43] page creation with VE in mobile does not appear to work [22:50:23] oh nevermind, i just lost the editable area i guess [22:52:44] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=60923 [22:53:24] hmm im getting a js error trying to save a VE edit: Uncaught TypeError: Cannot read property 'saveDialogSave' of undefined [22:53:29] is that a known VE issue? [22:54:13] awjr: Haven't heard of that one [22:54:29] huh, i just git pull'd for VE and now im getting a new issue [22:54:37] when trying to edit is ee TypeError: Cannot read property 'static' of undefined [22:56:44] (03CR) 10Awjrichards: [C: 032] Make edit button permissions work on alpha lazy loaded pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109455 (owner: 10Jdlrobson) [22:57:22]