[00:01:21] (03PS5) 10Dr0ptp4kt: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [00:02:24] https://www.mediawiki.org/wiki/Beta_Features/Minerva <--- this page is empty, but is linked to from "Information" at https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-betafeatures Does anyone have something they could post there? (Ideally, a short explanation, and a screenshot or 2. :) [00:05:46] (03PS6) 10Dr0ptp4kt: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [00:08:00] (03PS7) 10Dr0ptp4kt: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [00:11:26] (03PS12) 10Jdlrobson: QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 [00:11:28] (03PS14) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [00:12:01] jdlrobson, another mobile edit please:) [00:12:26] MaxSem: done [00:12:31] https://en.m.wikipedia.org/wiki/User:Jdlrobson/sandbox?action=history [00:14:43] hmm, IPv6 [00:18:38] jdlrobson, awjr: new headers are back on en.wiki, but now it's throwing JS errors :( [00:19:20] might need a touch and sync [00:19:46] are you guys seeing the same errors on stable? [00:20:08] no errors for me kaldari :) [00:20:52] jdlrobson: I get the errors about 50% of the time I hard refresh a page [00:21:15] specifically "Module not found: OverlayNew" [00:21:21] so far no errors whatsoever kaldari try again in 5 minutes - if you are still getting it probably needs touching [00:21:36] agreed [00:21:39] im not seeing errors [00:21:43] cool [00:21:46] kaldari: are you logged in? [00:21:47] I'll wait a bit [00:21:58] awjr: logged in or logged out [00:22:05] same error [00:22:16] have you tried ?debug=true? [00:22:36] MaxSem: i saw your patch go out - all better? [00:23:43] not sure actually. Jon's latest edits look different - as if the last one that's marked with mobile edit was made through desktop [00:25:39] based on the xff chain? [00:26:23] yup [00:27:06] hmm, I should just block the IP and see if it is noticeable for users [00:28:04] now someone in SF please try editing on mobile:) [00:28:10] (03PS15) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [00:30:36] jgonera: how are our page view perf stats looking after the last push? its taking me a lot more time then usual to load articles and editing [00:31:04] tfinc, let me check [00:31:29] and i'm seeing the edit interfaces fail to load [00:32:04] tfinc, on any particular page? [00:32:40] Yellow stone park, Mississippi River, and anything else that i'm trying over WIFI on my Nexus4 [00:32:52] it just spins and spins [00:33:10] tfinc, regarding perf, can't see anything suspicious at https://graphite.wikimedia.org/render/?title=navigationStart%20to%20loadEventEnd%20on%20mobile%20sites,%20last%20week&vtitle=milliseconds&from=-1week&width=1024&height=500&until=now&areaMode=none&hideLegend=false&lineWidth=1&lineMode=connected&target=alias%28color%28frontend.navtiming.totalPageLoadTime.mobile.overall.median,%22blue%22%29,%22Median%22%29&target=alias%2 [00:33:10] 8color%28frontend.navtiming.totalPageLoadTime.mobile.overall.75percentile,%22red%22%29,%2275th%20percentile%22%29 [00:33:16] wow, that's long [00:33:23] last graph at http://gdash.wikimedia.org/dashboards/frontend/ [00:34:16] tfinc, we might have some weird caching issues for office IPs today, I'm not sure why. Jon, Kaldari and I are also blocked from editing if we log in on office IP [00:34:32] jdlrobson sent an e-mail about [00:34:36] let me see if i get the same with mobile data [00:34:49] tfinc, yes, please check and let me know [00:35:24] same issue with the editing interface. it just spins [00:35:36] are we seeing a drop in editing since the last push ? [00:36:18] tfinc, regular editor? stable? just checked Mississippi River and it works, even on office WIFI [00:36:46] (03PS16) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [00:36:48] regular editor [00:37:20] i know about bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60912 but thats just alpha/beta [00:37:22] tfinc, the blocking problems are affecting only ulsfo [00:37:35] MaxSem: did you try reblocking the IP? [00:37:38] what browser? have you tried clearing the browser cache? [00:37:51] yep, waiting for you guys to try to edit [00:38:12] I still can't do shit on mobile en.wiki due to the JS errors [00:38:39] lemme ask greg if I can touch and sync real quick... [00:38:43] greg-g: ^ [00:38:46] Chrome [00:39:00] i'm also seeing no type ahead making me think that this is really busted [00:39:25] also, tfinc what do you mean by last push? today's deployment train? [00:39:35] type ahead? [00:39:54] search type ahead [00:40:30] tfinc, enwiki? I can't reproduce any of this [00:41:16] come by the hammock and lets take a look [00:41:22] kaldari: have you tried clearing your local cache? [00:41:30] yeah [00:41:42] and you're still seeing errors in stable? [00:41:52] can you walk me through how to replicatE? [00:42:22] hmm, looks like I only get the errors in Firefox for some reason [00:42:35] can you guys test in Firefox? [00:43:58] im not getting any errors in FF [00:45:52] MaxSem: still waiting on an SF edit? [00:46:00] yess [00:46:18] jdlrobson: jgonera kaldari can one of you please make a mobile edit to enwiki from the office for max? [00:46:37] im sure max would like to go to bed :) [00:49:08] or tfinc kaity moizsyed kenanwang_ ^^ [00:49:16] awjr: sorry we are busy trying to troubleshoot broken javascript on enwiki which breaks editing [00:49:23] can you grab someone else MaxSem ? [00:49:44] jdlrobson: no one else has responded yet [00:50:01] awjr: in stable/beta/alpha? [00:50:14] whatever [00:50:15] kaity i think any is fine, right MaxSem? [00:50:17] aye [00:50:39] thank kaity [00:51:01] heads up that were ringing up greg-g to let him know what's going on [00:51:20] tfinc: RE js errors around editing? [00:51:29] or the other issue? [00:51:33] yep [00:51:35] :) [00:51:44] awjr: MaxSem I was able to make an edit [00:51:49] thanks!:) [00:51:51] thanks kaity [00:51:55] i was in alpha [00:52:11] tracking these is in IRC is too hard. i'm starting an etherpad http://etherpad.wikimedia.org/p/Feb-6-Issues [00:52:37] MaxSem: What's that command to touch all the Mobile files? [00:53:05] find -type f -exec touch {} \; [00:54:50] man, i can't replicate any of the JS issues you guys are talking about, i wonder if some JS changes didn't get sync'd everywhere [00:55:04] hopefully kaldari's sync will help [00:55:14] just did the sync [00:55:29] k folks may need to wait ~5 mins [00:59:27] thanks kaity for helping MaxSem and sorry i was preoccupied! [00:59:39] sure jdlrobson [01:04:36] MaxSem: context for the Minerva feature flag patch? [01:04:58] the commit message was a bit brief [01:05:06] where was the request? what was the reason? [01:05:15] jdlrobson, see greg's comment on your change [01:05:22] link? [01:05:33] https://gerrit.wikimedia.org/r/#/c/102866/ [01:07:32] MaxSem: is the XFF issue resolved now or still questionable? [01:14:10] jdlrobson, jgonera, awjr: my Firefox JS errors are gone now :) [01:15:42] yay [01:15:47] thanks for the re-sync [01:15:54] tfinc are you still seeing issues? [01:20:02] (03PS4) 10Jdlrobson: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 [01:20:04] (03PS17) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [01:20:34] (03CR) 10JGonera: [C: 032] Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson) [01:20:44] (03CR) 10JGonera: [C: 032] QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 (owner: 10Jdlrobson) [01:21:40] (03Merged) 10jenkins-bot: QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 (owner: 10Jdlrobson) [01:21:57] tfinc: hey could we turn off the change in opacity for cards in trello? [01:22:10] (03Merged) 10jenkins-bot: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 (owner: 10Jdlrobson) [01:22:38] awjr, jdlrobson, jgonera, kaldari: does that mean that we're getting closer to resolving the editing bugs in stable? [01:23:42] kenanwang_, what is "that"? [01:24:36] Kaldari's comment that "my Firefox JS errors are gone now :)" [01:24:58] kenanwang_, no, that means we fixed the deployment that was messed up ;) [01:25:49] (03CR) 10Jdlrobson: "Hey Greg - yup Jared knows about it and James had some input. I'm merging Max's patch so you guys can coordinate about what you want to do" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [01:26:33] (03PS2) 10Jdlrobson: At Greg's request, hide Minerva on desktop behind a feature flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111933 (owner: 10MaxSem) [01:27:06] (03CR) 10Jdlrobson: [C: 031] "Feel free to +2 pending Greg's reply or lack of reply on the other commit thread." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111933 (owner: 10MaxSem) [01:34:26] tfinc made updates to the trello board [01:47:09] (03PS3) 10Theopolisme: [WIP] Allow users to adjust the font size [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 [01:47:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow users to adjust the font size [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 (owner: 10Theopolisme) [01:47:56] (03CR) 10JGonera: [C: 032] At Greg's request, hide Minerva on desktop behind a feature flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111933 (owner: 10MaxSem) [01:49:20] (03Merged) 10jenkins-bot: At Greg's request, hide Minerva on desktop behind a feature flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111933 (owner: 10MaxSem) [01:49:32] (03PS4) 10Theopolisme: [WIP] Allow users to adjust the font size [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 [01:50:29] violetto: hey wanted to check in with you about app design [01:50:48] kenanwang_: im still here, are you? [01:51:12] hey no I'm out of the office right now [01:51:33] kenanwang_: hangout? [01:53:58] (03CR) 10Theopolisme: [C: 04-1] "So, I switched to using ResourceLoader and a new LESS variable (since the scaling factor variable seems too general for our purposes; we o" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 (owner: 10Theopolisme) [01:56:38] kenanwang_: kaldari jgonera do you guys have any screenshots(even a dev one) of what ve looks like on tablet ? [01:56:52] (03PS7) 10Kaldari: Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 [01:57:19] hmm violetto now that I think about it, let me put together a revised timeline and we can talk through it [02:01:46] kaldari: let me know when you guys are leaving [02:01:49] im starvingg [02:26:48] In case it was missed above: https://www.mediawiki.org/wiki/Beta_Features/Minerva <--- this page is empty, but is linked to from "Information" at https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-betafeatures Does anyone have something they could post there? (Ideally, a short explanation, and a screenshot or 2. :) [06:59:55] I've started to set up a mediawiki in my home. We'd like an easy way to upload pictures from our Android tablet (share button). To our own wiki, not the commons. Is there a good way to do this? [07:00:49] Doing it over the LAN is fine (wifi). [08:51:29] (03PS1) 10Yuvipanda: Do not show article text in other languages page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111981 [11:29:58] MaxSem: thanks for setting up the calendar invite :) [11:31:23] :) [12:34:02] (03PS1) 10Zfilipin: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112013 [12:41:19] (03PS2) 10Zfilipin: QA: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112013 [13:25:22] (03PS1) 10Yuvipanda: Handle login errors returned when logging in [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112023 [14:43:48] hey brion [14:44:04] &yawn& [14:44:05] mornin [14:44:09] brion: mornin! :) [14:52:50] can't find my glasses, it may be a blurry day [14:57:11] Ctrl + [14:57:12] Ctrl + [14:57:12] Ctrl + [14:57:12] Ctrl + [14:57:14] MaxSem: Everyone seems to be trolling the Russians [14:57:17] Fail [14:57:42] Reedy: :P [14:58:04] Up once too many [14:58:07] It's still true though [14:59:00] Reedy: heh [14:59:05] Reedy: better this than something else :) [15:41:26] brion: I am going to try to do a cycle ride again. Hopefully my back won't complain. [15:41:31] brion: do try to review :) [15:41:34] have fun :) [15:41:34] brb [15:41:35] will do [15:42:04] brion: :) [16:08:13] (03CR) 10Cmcmahon: [C: 032] QA: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112013 (owner: 10Zfilipin) [16:08:49] (03Merged) 10jenkins-bot: QA: Renamed mediawiki-selenium Ruby gem to mediawiki_selenium [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112013 (owner: 10Zfilipin) [17:55:53] brion: i survived! Only *one* near death experience with an autorickshaw that did a U turn in the middle of the road [17:56:06] lol [17:56:44] brion: it was a very scary 2s [17:57:12] try not to die before we get you over here :) [17:57:34] brion: I will. but it looks like if I come over and as much as stub a toe, I'll be bankrupt :( [17:58:04] american health insurance super wonderful! obama solved everything! [17:58:04] well [17:58:10] not really but it's not *too bad* [17:58:35] brion: heh :P A friend had to spend like 8k over his really good insurance for foot surgery. that sounded really insane to me. [17:58:45] ouch [17:58:49] you could probably get a delicate open heart surgery done for that much here. [17:58:58] I didn't understand the concept of 'medical tourism' until that point [18:01:14] grrrrrr test phone doesn't see the wifi today [18:01:30] lemme try the 2.4ghz [18:02:10] haha [18:02:48] "authentication problem" [18:02:48] sigh [18:03:11] brion: tried turning it off and on? :) [18:03:26] ok it wants my username without the domain suffix for wifi [18:03:29] i never remember :P [18:05:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] Do not show article text in other languages page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/111981 (owner: 10Yuvipanda) [18:10:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Mmmmm, croutons! Seems to work as advertised. Yay!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112023 (owner: 10Yuvipanda) [18:11:35] YuviPanda: that reminds me at some point we need an about screen with credits for all those libraries :D [18:11:50] brion: yup, I've told May [18:12:02] whee [18:15:45] sounds like we're up [18:15:54] brion: damn. coming [18:17:24] brion: nobody there but me and kenan? [18:32:20] brion: I am going to write code to store a plaintext password. feels dirty :( [18:33:01] eww eww [18:33:13] brion: we could obfuscate it a bit later on if we want... [18:33:20] like, what, rot13 it? :P [18:33:27] hehehehe [18:33:57] brion: but seriously, we could do something simplish, like take the device ID or something and salt it with something and encrypt it. [18:34:05] easy enough to decrypt, but a casual passerby wouldn't know [18:38:35] Hey MaxSem so i spoke to dr0ptp4kt and it sounds like if we add a hook to SpecialMobileLanguages for rewriting links that will suffice [18:38:42] i can take care of the front end changes.. [18:39:15] jdlrobson, ok - I'll do the hook now [18:39:43] MaxSem: thanks MaxSem :) [18:48:37] jgonera: https://gerrit.wikimedia.org/r/#/c/94435/ can you take a look at this - kaldari has already looked at it and +1ed it [18:49:36] also MaxSem why only the +1 on https://gerrit.wikimedia.org/r/#/c/111899/ ? [18:50:14] (03CR) 10MaxSem: [C: 032] Limit blocked test to logged in users. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111899 (owner: 10Jdlrobson) [18:50:28] was hoping someone else might look too [18:50:52] (03Merged) 10jenkins-bot: Limit blocked test to logged in users. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111899 (owner: 10Jdlrobson) [18:51:58] thanks MaxSem :) one down 5 to go :) [18:55:03] (03PS8) 10Dr0ptp4kt: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [18:55:30] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks great on ios 7 & 6.1 :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111909 (owner: 10Mhurd) [19:02:51] (03PS9) 10Brion VIBBER: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 (owner: 10Dr0ptp4kt) [19:04:07] (03CR) 10Brion VIBBER: "rebased against latest merge" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 (owner: 10Dr0ptp4kt) [19:05:02] (03PS1) 10Yuvipanda: Add notification in login screen if there is no network [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112045 [19:05:06] brion: ^ [19:05:36] mhurd: can you paste me a link? [19:05:47] YuviPanda: https://www.mediawiki.org/wiki/Q3_mobile_app_timeline [19:07:43] (03PS1) 10Yuvipanda: Cleanup the croutons when you destroy [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112046 [19:08:57] YuviPanda: i'll test those after meeting :) [19:09:02] brion: ok [19:11:56] jdlrobson, I'll do that later today [19:12:18] jgonera: ok not too late though - leave me enough time to make any changes before the end of the day [19:12:29] ok, jdlrobson [19:12:34] what time are you leaving? [19:12:38] thanks. Probably around 5ish [19:12:41] ok [19:12:50] is kaldari out all day? [19:12:58] i can't find his mail [19:13:02] I thought he was going to WFH [19:14:34] dr0ptp4kt: i rebased your iOS patch, only very minor conflicts in lists of files :) will test later [19:14:53] brion, thanks. it's sort of broken. i think due to re-entrant code. bleh [19:14:58] just trying to keep moving on it [19:15:02] :( fun :D [19:15:03] (03CR) 10Jdlrobson: "Probably not worth merging until VE patch in case anything changes." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111934 (owner: 10JGonera) [19:21:22] jdlrobson: can i kill card 1664 now? [19:26:16] (03CR) 10Jforrester: "The copy needs work (to put it mildly), and this is already in production…" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [19:27:01] mhurd: link me to etherpad? :) [19:27:04] (03CR) 10Jdlrobson: [C: 04-1] "Looks and works fine but the cleanup template css is not very clean. How ironic! :D" (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari) [19:27:14] YuviPanda: https://etherpad.wikimedia.org/p/MobileAppRetrospective [19:29:19] (03CR) 10Jdlrobson: Story 1643: Improve typography for overlays (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari) [19:29:55] (03PS1) 10MaxSem: Add a hook for Zero to mangle lang/variant links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112052 [19:30:00] dr0ptp4kt & yurik ^^^^ [19:32:46] (03PS1) 10Jforrester: Put the Minerva-on-desktop Beta Feature under a feature flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112053 [19:34:51] jdlrobson: ^^^ Any chance of a quick merge? I'll ask greg-g for a quick deploy today. [19:35:23] (03CR) 10Jforrester: "Follow-up in Iada5a17c9d63a7e." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [19:38:30] James_F: jdlrobson lemme know who you want to deploy, but I'm happy with this going out today and the schedule is wide open :) [19:38:33] * greg-g goes to get some lunch [19:45:00] (03CR) 10Catrope: [C: 032] Put the Minerva-on-desktop Beta Feature under a feature flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112053 (owner: 10Jforrester) [19:45:11] (03PS1) 10Catrope: Put the Minerva-on-desktop Beta Feature under a feature flag [extensions/MobileFrontend] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112054 [19:45:35] (03Merged) 10jenkins-bot: Put the Minerva-on-desktop Beta Feature under a feature flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112053 (owner: 10Jforrester) [19:48:26] jdlrobson, what do you think of https://gerrit.wikimedia.org/r/#/c/111250/ ? [19:52:36] brion, wanted to mention that the code is no-op at the moment given that api on server isn't in place...also you won't be on a zero network. but i can talk with you on ways i deal with that when testing [19:53:02] heh ok [20:04:29] hi violetto [20:04:35] YuviPanda: yo! [20:04:42] attending our presentation? [20:04:47] violetto: i'm in the hangout [20:04:55] violetto: for the presentation [20:05:00] :) [20:05:15] did you see me wave [20:05:16] violetto: yeah, that was directed correctly :P [20:05:18] the second one [20:05:29] YuviPanda: hhaaha [20:05:40] violetto: I can see everyone. lots of nice fighting happening. wheee [20:05:49] YuviPanda: typical shiz [20:05:59] violetto: heh, yeah. [20:07:20] violetto: you guys have been on for about 10 mins now :D was fun to watch :D [20:10:18] (03CR) 10Jdlrobson: [C: 04-1] "semantic concerns.." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112052 (owner: 10MaxSem) [20:14:16] (03PS2) 10MaxSem: Add a hook for Zero to mangle lang/variant links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112052 [20:15:58] (03PS2) 10Yuvipanda: Cleanup the croutons when you destroy [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112046 [20:18:08] (03CR) 10Jdlrobson: [C: 031] Add a hook for Zero to mangle lang/variant links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112052 (owner: 10MaxSem) [20:18:29] (03CR) 10Jdlrobson: Add a hook for Zero to mangle lang/variant links (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112052 (owner: 10MaxSem) [20:19:18] (03CR) 10MaxSem: Add a hook for Zero to mangle lang/variant links (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112052 (owner: 10MaxSem) [20:21:41] jdlrobson, re https://bugzilla.wikimedia.org/show_bug.cgi?id=60852 - so not having a button is the new design? [20:22:31] MaxSem: what do you mean by not having a button? It works fine for me. are you referring to lack of style? https://gerrit.wikimedia.org/r/#/c/111836/ [20:25:21] jdlrobson, http://i62.tinypic.com/24vqq7d.png [20:25:49] MaxSem: that looks like https://gerrit.wikimedia.org/r/#/c/111836/ [20:25:56] does clicking it open the overlay for you? [20:26:01] as it did for me.. [20:26:50] what browser are you in? [20:28:55] FF [20:29:17] btw, that screenshot was made WITH this commit;) [20:42:33] MaxSem: reopen then with those details i'll take another look in a bit [20:43:40] MaxSem: also how do i use a hook in 'SpecialMobileLanguages::langLinks' ? [20:44:11] reopened [20:44:49] uh... create a handler, iterate over $links modifying['url'] where needed [20:44:51] ah wait i worked it out :) [20:46:30] (03PS1) 10Jdlrobson: Rewrite links in Special:MobileLanguages [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112061 [20:46:31] awjr, are you using vagrant for development? [20:46:33] ^ MaxSem [20:46:46] jgonera: not currently [20:47:03] were you using it before? [20:47:05] jgonera: i am using a vmware fusion vm running ubuntu [20:47:11] jgonera: i have played with it a bit before, but a while ago [20:47:33] was there something that wasn't working that made you abandon it? or was it too slow? [20:47:37] jgonera: i think YuviPanda uses vagrant, or at least has some experience with it [20:47:52] jgonera: mostly lazyness [20:48:01] awjr: vagrant is the ultimate form of laziness [20:48:08] never have to worry about your dev setup, ever! [20:48:18] YuviPanda, if it only worked! [20:48:22] jgonera: i already had a good thing set up (exactly what i have now) and didn't feel like totally configuring a new vagrant instance to achieve a similar result [20:48:28] jgonera: what's going on? [20:48:28] jgonera: what issue are you running intO? [20:49:00] I enabled the mobilefrontend role and the Mobile view link is there but does absolutely nothing (ok, reloads the page but it stays in desktop) [20:49:02] awjr: you should still try it out, it's about 3 commands and 30 mins of waiting for the first time [20:49:11] jdlrobson, you didn't test it?:) [20:49:16] (03PS2) 10Jdlrobson: Rewrite links in Special:MobileLanguages [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112061 [20:49:17] MaxSem: works for me... [20:49:22] also,. i have like no disk space left and don't want to eat it up with more VMs [20:49:29] or a new VM manager [20:49:29] MaxSem: something not working? [20:49:50] YuviPanda: but yes, i will need to start getting familiar with it soon :) [20:49:59] jgonera: interesting. using useformat=mobile works, but the 'toggle' does not [20:50:24] yeah, that's one thing. I was also hoping that it would be fast on an SSD drive, but it's not [20:50:32] (03CR) 10MaxSem: Rewrite links in Special:MobileLanguages (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112061 (owner: 10Jdlrobson) [20:50:34] I mean, loading the pages is slow [20:50:35] jgonera: might be an issue with localsettings [20:50:50] for everything to load on a main page it takes like 5 seconds... [20:51:07] jgonera: do you have apc/memcache set up? [20:51:12] that helps a lot [20:51:16] awjr: vagrant sets up apc and redis [20:51:19] ah right [20:51:29] awjr, I would hope that vagrant is configured with everything by default [20:51:48] i think vagrant has evolved a lot since i last messed with it :p [20:51:51] jgonera: it is. [20:52:09] so why is it slower than my manually set up apache without all that stuff? :( [20:52:16] jgonera: main page still is about 4s on my specc'd out machine. [20:52:20] jgonera: it is running in a VM [20:52:35] MaxSem: wait a minute this hook isn't needed.. it just seems to work already! [20:52:41] mm magic [20:52:45] well, yes, but I've been running linuxes with GUI in VMs and they were almost as snappy as my native OS [20:53:28] (03CR) 10Jdlrobson: [C: 04-1] "Actually this doesn't seem to be needed?!" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112061 (owner: 10Jdlrobson) [20:53:39] ok, YuviPanda, I'll play with it later [20:53:44] jgonera: ok. [20:54:48] MaxSem: we actually need a hook that changes the href in http://en.m.wikipedia.org/w/api.php?format=json&action=query&meta=siteinfo&siprop=general%7Clanguages&prop=langlinks&llurl=true&lllimit=max&titles=San_Francisco_Pride [20:55:00] *changes the url [20:55:11] that's the bit that's missing.. [20:55:47] YuviPanda, wgMFAutodetectMobileView => true, maybe this makes the UA detection more important than the toggle link? although it shouldn't [20:56:07] YuviPanda, if I edit the role, what do I have to do to apply changes? vagrant provision? [20:56:13] jgonera: yup, vagrant provision [20:56:14] (03CR) 10Jdlrobson: [C: 04-1] "Actually Max it seems like this hook is unnecessary - Special:MobileLanguages with zero enabled already seems to work." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112052 (owner: 10MaxSem) [20:56:47] really? [20:57:24] MaxSem: yup - weird huh [20:57:51] MaxSem: how can i force zero again and test on enwiki? [20:58:03] that is, you're receiving zero warning when clicking on these links? [20:58:57] YuviPanda, nope, that didn't fix it, OK, will check later [20:59:07] jdlrobson, X-CS: 250-99 [20:59:24] jgonera: ok [21:05:33] YuviPanda: brion mhurd: i need to get that android task out today [21:05:42] what's left to finish it? [21:06:07] YuviPanda: could give choice of the 2? [21:06:36] mhurd: we will have to evaluate those, so I think giving everyone the same one is fine [21:06:44] s/fine/what we should do/ [21:06:52] *nod* [21:07:02] tfinc: discussion's stalled there yesterday, I don't think we've settled on what task we need to give yet. [21:07:13] i need you guys to settle on one today [21:07:21] *or* [21:07:30] we can give the candidate an option and see which ones they pick [21:07:42] i like that [21:07:42] tfinc: that's what mhurd suggested, but then reviewing them would be a PITA [21:07:44] but then i need two fully fleshed out [21:07:49] correct [21:07:50] thats the cost [21:07:53] so i'd rather have one [21:07:57] me too. [21:08:05] brion: thoughts? [21:08:40] so i'm fine with including some basic networky stuff -- that confirms they know the plumbing -- but i'm most interested in their chops for the visuals [21:08:49] making something that wows us [21:09:03] +1 [21:09:07] brion: ^ [21:09:26] wow factor! [21:09:46] mhurd: it's kinda hard to build something actually 'wow' in '2-3 hours' [21:09:58] not if that's what you're obsession is [21:09:58] * brion hmmmmms [21:10:05] *your* [21:10:08] :) [21:10:11] mhurd: I'd completely agree with it if they had more time, but with the constraint of 2-3 hours, I am not sure [21:10:34] YuviPanda: so one thing we can do is give them a skeleton project [21:10:42] so they don't have to do the low-level network bits [21:10:49] brion: noooo! then they will spend 3 hours just getting our skeleton project set up! [21:10:53] heheheheh [21:11:40] mhurd: I also don't like the idea of trying to force something like that out in 2-3 hours. We would definitely have that be the second level task [21:11:45] maybe instead of "wow" we could say we're "do something creative with android.animation" [21:11:48] mhurd: this is just the initial filtering screen. [21:12:18] that would be more focused [21:12:23] YuviPanda: what's the key thing you want to test in the first screen? [21:12:54] brion: 1. they understand android, 2. they have some intuitive understanding of animation *in android* [21:13:01] *nod* [21:13:02]