[05:26:53] <grrrit-wm>	 (03PS11) 10Dr0ptp4kt: WIP: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 
[15:45:44] <grrrit-wm>	 (03PS12) 10Dr0ptp4kt: WIP: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 
[16:18:28] <yuvipanda>	 MaxSem: around?
[16:27:01] <MaxSem>	 yep
[16:41:14] <yuvipanda>	 MaxSem: I might not be around for the deployment, is at around 3:30-4:30 AM :( Is that a blocker to it being deployed?
[16:43:01] <MaxSem>	 no
[16:43:13] <MaxSem>	 because it's just a module
[16:43:36] <MaxSem>	 but in general case this would've been unfortunate indeed
[16:52:24] <yuvipanda>	 MaxSem: yeah, I understand
[16:52:26] <yuvipanda>	 MaxSem: thanks!
[17:11:13] <mhurd>	 YuviPanda: heya!
[17:11:17] <yuvipanda>	 hey mhurd
[17:11:23] <yuvipanda>	 mhurd: climby weekend? :)
[17:11:37] <mhurd>	 haha once! did u have a birthday?
[17:11:41] <yuvipanda>	 mhurd: yup!
[17:11:43] <yuvipanda>	 :)
[17:11:51] <mhurd>	 YuviPanda: yay! keep having those
[17:11:56] <yuvipanda>	 I'll try :D
[17:12:01] <mhurd>	 good
[17:12:04] <mhurd>	 ;)
[17:12:32] <mhurd>	 hey any luck with central auth? i tried duplicating the central auth cookies for each domain w no luck
[17:12:46] <yuvipanda>	 mhurd: no haven't looked into it yet. Got sidetracked with other stuff :(
[17:12:59] <yuvipanda>	 mhurd: I'll probably take a shot today. You can also grab Chris Steipp from the office if you want :)
[17:12:59] <mhurd>	 YuviPanda: no worry! it's weird
[17:13:10] <yuvipanda>	 heh, centralauth is always considered weird :)
[18:00:39] <mhurd>	 YuviPanda: i talked to chris and it looked like i was doing 2 things wrong with central auth - i was copying central auth cookies for each language wiki (only needed to top level), and i wasn't getting additional edit token for each lang wiki (if editing english and you go to french, a separate fr wiki edit token is needed)
[18:00:56] <yuvipanda>	 ah!
[18:00:56] <yuvipanda>	 right
[18:00:56] <yuvipanda>	 yeah
[18:01:09] <yuvipanda>	 mhurd: what do you mean by 'copying CA cookies for each language'?
[18:01:54] <mhurd>	 i saw a CA cookie for ".wikipedia.org" and i added one for "fr.wikipedia.org" - which was silly :)
[18:02:20] <awjr>	 kenanwang_: standup
[18:02:29] <yuvipanda>	 mhurd: aaaah! :)
[18:02:29] <yuvipanda>	 mhurd: right
[18:02:35] <mhurd>	 YuviPanda: hehe
[18:02:44] <yuvipanda>	 mhurd: hmm, although that shouldn't have affected anything, theoretically
[18:03:07] <mhurd>	 YuviPanda: it didn't. didn't work... and still didn't work
[18:03:24] <yuvipanda>	 mhurd: ah
[18:03:31] <yuvipanda>	 mhurd: hmm, yeah. CA is weird in general :)
[18:04:07] <mhurd>	 YuviPanda: ya, i guess the key take-away was the need for an edit token for each lang wiki
[18:04:13] <yuvipanda>	 right
[18:06:02] <brion>	 yuvipanda: i'm gonna be in VP Engineering interviews much of today. need anything other than review from me?
[18:06:14] <awjr>	 kaldari: standup?
[18:06:22] <yuvipanda>	 mhurd: nah, 'tis ok! :) I'll get some patches for you to look at later
[18:06:32] <yuvipanda>	 err
[18:06:33] <yuvipanda>	 i mean
[18:06:34] <yuvipanda>	 brion: ^
[18:06:37] <yuvipanda>	 goddamn autocomplete
[18:06:56] <brion>	 whee
[18:06:58] <yuvipanda>	 brion: also when I got the notification, it cut off at 'I'm goinna be VP Engineering...' and I was a bit confused
[18:06:59] <yuvipanda>	 :)
[18:07:05] <brion>	 haha
[18:07:11] <brion>	 oh no i ain't going back into management
[18:07:14] <brion>	 that is not my cup of tea
[18:07:46] <yuvipanda>	 brion: but it could be your cup of coffee!
[18:07:48] <yuvipanda>	 or vodka
[18:07:58] <brion>	 coffee and a dash of kahlua perhaps
[18:08:22] <yuvipanda>	 heh, white russian!
[18:09:06] <brion>	 the dude abides
[18:09:51] <yuvipanda>	 brion: :)
[18:09:56] <yuvipanda>	 brion: enjoy the interviews!
[18:09:59] <brion>	 oh i will
[18:11:47] <yuvipanda>	 mhurd: PM?
[18:11:56] <mhurd>	 ya
[18:16:43] <guillom>	 FYI, just saw this: http://lifehacker.com/wikiexplorer-creates-wikipedia-reading-lists-finds-loc-1519861434
[18:18:07] <yuvipanda>	 mhurd: is there standup?
[18:19:49] <awjr>	 kaldari: i just reassigned https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1628 to you. the code is merged, but from jon's email 'Re: Mobile edit toolbar' it sounds like there are still a couple of remaining issues - can you please follow up?
[18:20:09] <kaldari>	 will do
[18:20:15] <awjr>	 thanks
[18:23:09] <awjr>	 kaldari: also when you have a chance, can you send me links to the VE bugs you raised?
[18:23:21] <kaldari>	 I'll do that now...
[18:24:24] <yuvipanda>	 mhurd: http://etherpad.wikimedia.org/p/U53g0zdCtb
[18:26:25] <yuvipanda>	 mhurd: take a look and tell me if it's ok?
[18:28:11] <mhurd>	 yuvipanda: looks great!
[18:28:15] <yuvipanda>	 mhurd: ok!
[18:30:24] <kaldari>	 awjr: email sent
[18:30:40] <awjr>	 thanks kaldari!
[18:48:19] <kenanwang_>	 Jgonera: got it
[18:52:15] <grrrit-wm>	 (03PS13) 10Dr0ptp4kt: WIP: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 
[19:10:00] <awjr>	 jgonera: we need you!
[19:38:20] <kaldari>	 awjr: for the VE toolbar stuff it looks like the assets are there now, so no BLOCK. However, the actually story is only half finished, so I'm moving it back to In Development.
[19:44:35] <mhurd>	 dr0ptp4kt: UITextField *t = [((NavController *)self.navigationController) getNavBarItem:NAVBAR_TEXT_FIELD];
[19:44:35] <mhurd>	 t.backgroundColor = [UIColor redColor];
[19:54:40] <kaldari>	 awjr: actually, I think Jon may have marked it blocked due to https://gerrit.wikimedia.org/r/#/c/109940/, not because of the assets
[20:17:59] <awjr|lunch>	 ahha ok, thanks kald		
[20:18:00] <awjr|lunch>	 er
[20:18:02] <awjr|lunch>	 nm
[20:22:12] <yuvipanda>	 mhurd: around?
[20:47:10] <yuvipanda>	 MaxSem: action=logout returns an empty JSON array rather than an empty object :|
[20:47:10] <yuvipanda>	 oh well. no point filing a bug, it's probably not gonna change anyway
[20:51:19] <MaxSem>	 yep:)
[20:52:31] <yuvipanda>	 MaxSem: sigh. our API sucks, but no point complaining since you already know :P
[20:53:21] <MaxSem>	 how is json_encode() sipposed to treat array()? :)
[20:53:39] <yuvipanda>	 oh dear
[20:54:30] <MaxSem>	 it just decides one way over another and nothing you can do about that
[20:54:35] <MaxSem>	 and it's empty anyway:P
[20:55:14] <yuvipanda>	 MaxSem: heh, yeah
[20:55:20] <yuvipanda>	 MaxSem: it's just that java treats those differently and crashes when it looks for a dict and finds an array instead
[20:55:42] <MaxSem>	 add a sript to java and you'll be fine
[20:55:55] <yuvipanda>	 heh, 'java' and 'fine' in the same sentence.
[20:55:55] <yuvipanda>	 cute
[20:56:40] <MaxSem>	 after you add a script to java it's not java, right?
[20:57:35] <yuvipanda>	 MaxSem: Kotlin is JetBrains' version of 'add a script to java' 
[20:57:45] <yuvipanda>	 it seemed rather neat, but haven't had time to try it out yet
[20:57:58] <MaxSem>	 i meant JS:P
[20:58:34] <yuvipanda>	 MaxSem: wow
[20:58:40] <yuvipanda>	 MaxSem: I...  think that means I am sleepy
[20:58:47] <yuvipanda>	 MaxSem: It whooshed past me at astonishing speed
[20:59:36] <mhurd>	 yuvipanda: sry was getting lunch
[21:00:33] <yuvipanda>	 mhurd: 'tis k :) Just wanted to point out that MaxSem will be deploying the  MobileApp extension on our cluster shortly :)
[21:00:45] <mhurd>	 yuvipanda: yay!
[21:00:51] <yuvipanda>	 mhurd: http://en.wikipedia.beta.wmflabs.org/w/load.php?debug=true&lang=en&modules=mobile.app&only=styles&skin=vector&*
[21:01:07] <yuvipanda>	 mhurd: so with a similar (but non-beta!) URL, we can deliver CSS and JS into the app that can then be long-cached
[21:01:52] <mhurd>	 yuvipanda: awesomeness
[21:02:17] <yuvipanda>	 mhurd: :) Maybe also respond with a 'ya' or some such on the android tasks thread when you have the time? :)
[21:04:12] <mhurd>	 yuvipanda: done!
[21:04:20] <yuvipanda>	 mhurd: ty!
[21:04:33] <mhurd>	 yuvipanda: yw
[21:34:33] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add 'Log Out' functionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112584 
[21:37:01] <yuvipanda>	 mhurd: just saw your trello comments about me checking off acceptance criteria in the iOS card. sorry about that :)
[21:37:16] <mhurd>	 yuvipanda: no worry!
[21:37:20] <yuvipanda>	 :)
[21:37:22] <mhurd>	 yuvipanda: i swapped it for ya
[21:37:31] <yuvipanda>	 mhurd: I've login and stuff working, but nothing on centralauth yet
[21:38:05] <mhurd>	 yuvipanda: good stuff! 
[21:38:07] <yuvipanda>	 mhurd: :)
[21:38:14] <yuvipanda>	 mhurd: let me know how your CA adventures go
[21:40:19] <mhurd>	 yuvipanda: will do! presently setting things up to try requesting edit token for lang wiki if i don't have one already or if i get an invalid token response back (it expired etc). hopefully that will work :)
[21:40:38] <yuvipanda>	 mhurd: hmm, I can't think of a time where you will get back 'expired'
[21:40:55] <yuvipanda>	 mhurd: if it has logged out, I think you will just get back the default 'anonymous' token, which is +\ I think
[21:43:07] <mhurd>	 chris said they can expire even before the cookie says they will if the server needs them to free up resources. 
[21:43:36] <yuvipanda>	 mhurd: hmm, right. I just don't know what you will get back from action=tokens when you request with an expired cookie.
[21:43:46] <yuvipanda>	 oh, nevermind
[21:48:38] <mhurd>	 yuvipanda: i was thinking in the case i have previously authenticated login credentials, i could just transparently use them to get edit token for the current article's lang (with the trigger being detecting that i either don't have an edit token for that lang wiki, or that the server says the token is no longer valid), that way, if my session expired, or if i'd been editing on enwiki, then switched to frwiki, everything would just work... hehe i
[21:49:20] <yuvipanda>	 mhurd: your message cut off at 'hehe i'
[21:49:34] <mhurd>	 "hehe in theory" was the rest of it
[21:50:41] <yuvipanda>	 mhurd: yeah, that seems sane enough
[21:50:41] <yuvipanda>	 mhurd: for me, I plan on trying to edit, which requests an edit token, and if there's no current edit token it fetches one, and if it doesn't have login creds it tries to login again (since that means session expired), and if that fails it puts up the login screen (assuming they have ever logged in)
[21:50:54] <yuvipanda>	 if they have never logged in, it doesn't try to login and just edits anonymouslyy
[21:50:56] <yuvipanda>	 quite similar to yours, I guess
[21:51:07] <mhurd>	 yuvipanda: pretty much same yeah
[21:51:34] <yuvipanda>	 :)
[21:51:35] <yuvipanda>	 mhurd: are you persisting the edit tokens?
[21:51:39] <yuvipanda>	 or just keeping them in memory?
[21:52:03] <mhurd>	 yuvipanda: may as well persist i guess - keep using 'em as long as they work
[21:52:17] <mhurd>	 yuvipanda: sound ok?
[21:52:56] <yuvipanda>	 mhurd: yeah, that's what I am doing
[21:52:59] <grrrit-wm>	 (03PS1) 10Yuvipanda: Handle back button properly when no more pages are left [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112588 
[21:55:23] <MaxSem>	 awjr, I've just discovered 6657516 lines worth of Bingle/Bugello emails in my labs account:P
[21:55:32] <awjr>	 @_@
[21:55:35] <yuvipanda>	 hahaha :D
[21:55:42] <yuvipanda>	 THE LEADING CAUSE OF NFS OUTAGES!!1
[21:55:44] <awjr>	 MaxSem: cron emails, or something else?
[21:55:46] <awjr>	 hehehe
[21:56:05] <MaxSem>	 cron
[21:56:18] <MaxSem>	 nuked, 104 lines a couple of minutes later
[21:57:32] <yuvipanda>	 heh
[22:17:24] <grrrit-wm>	 (03PS1) 10Henry: Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 
[22:17:40] <awjr>	 chrismcmahon: in a given feature file for browser tests, can you specify targets for individual scenarios, or can you only target specific environmts for the whole feature?
[22:19:20] <chrismcmahon>	 awjr:  target test environments are specified in the MEDIAWIKI_URL environment variable.   it is orthogonal to anything in Cucumber or feature.  what are you trying to do? 
[22:20:03] <awjr>	 chrismcmahon: maybe i am using the wrong words to describe the situation. there is a mobilefrontend feature file (features/search-specialpages.feature) which has @en.m.wikipedia.org specified at the top
[22:20:11] <awjr>	 however, that feature is not currently on enwiki
[22:20:32] <awjr>	 there is another feature, features/login.feature which has two scenarios in it. one scenario is present on enwiki, the other is not
[22:20:41] <awjr>	 is it possible to specify that in the feature file?
[22:22:11] <chrismcmahon>	 awjr: aha, yeah.  we specify Jenkins builds per-host-per-browser.  so we have a build https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/ that at run time says "OK, get all of the tests marked with the tag "@en.m.wikipedia.org" and run them" .  If you don't want that test to run on prod, take out the tag for that environment
[22:23:02] <awjr>	 chrismcmahon: yeah, so in features/login.feature, there are two tests - can i set different tags for each individual test?
[22:23:48] <chrismcmahon>	 awjr:  that I am not sure about. 
[22:24:17] <chrismcmahon>	 awjr:  I sort of doubt we support that, but I'd ask Zeljko to be sure
[22:24:25] <awjr>	 ok chrismcmahon
[22:24:27] <awjr>	 thanks
[22:25:10] <awjr>	 chrismcmahon: it strikes me as fundamentally unmaintainable to have to keep the feature file tags up-to-date with the way that features get rolled out
[22:25:10] <chrismcmahon>	 awjr:  
[22:25:57] <chrismcmahon>	 awjr:  even if we did support target envs per-feature, I think the right solutions would be to break out each Feature into a different .feature file since they seem to be conceptually different tests. 
[22:26:00] <awjr>	 chrismcmahon: with the status quo, we either need to aggressively stay on top of the tags in the feature files with every deployment, or just live with failures in environments like enwiki (which imo is unacceptable)
[22:26:56] <chrismcmahon>	 awjr:  running login tests on prod gives me the willies.  Over time I have disabled all the ones I've had in other repos for various reasons. 
[22:27:07] <awjr>	 chrismcmahon: how come?
[22:27:43] <awjr>	 (this problem isn't unique to the login features btw)
[22:27:47] <chrismcmahon>	 awjr:  seems like Selenium_user always eventually does something to run afoul of wiki admins
[22:27:51] <awjr>	 ha
[22:28:00] <awjr>	 yeah for sure
[22:28:09] <awjr>	 but the problem remains for all of our other features
[22:28:25] <chrismcmahon>	 awjr:  someone will run a whole lot of tests and get banned, or put the wrong tags, or no tags (this just happened on Commons)
[22:29:43] <chrismcmahon>	 awjr:  is this your issue?  https://bugzilla.wikimedia.org/show_bug.cgi?id=58652
[22:30:42] <awjr>	 chrismcmahon: yeah, i think so
[22:31:05] <awjr>	 checking out browsertests for the corresponding repo would make more sense to me that trying to stay on top of the @ tags
[22:31:12] <awjr>	 s/that/than
[22:31:25] <yuvipanda>	 mhurd: if you see brion can you tell him to take a a look at the pathces for android?
[22:31:54] <mhurd>	 yuvipanda: will do!
[22:32:15] <mhurd>	 yuvipanda: have a good night!!
[22:34:16] <awjr>	 MaxSem: i took the two stories you added to Mingle and turned them into tasks - they look good tho and i also stuck them into 'ready for dev'
[22:34:48] <awjr>	 MaxSem: let's add any others as tasks for now so they don't get confused with the work getting defined by kenan et al as stories
[22:36:03] <MaxSem>	 awjr, thanks! bit busy atm, outage
[22:36:20] <awjr>	 np MaxSem, just wanted to give you a head's up
[22:38:21] <chrismcmahon>	 awjr:  yeah, I think it is a matter of pulling master branch for beta, but stopping pulling master branch for builds in later envs until some trigger.  This was a big reason to have the browser tests in the repos of the extensions being tested, so that they would track together.  I know MobileFrontend has been like that for about a year, but every other extension repo is much newer.  It's on the list to do in the next quarter or so. 
[22:40:59] <yuvipanda>	 hey brion
[22:41:09] <yuvipanda>	 heading to sleep, but I've log out and username creds storage in there :)
[22:41:10] <yuvipanda>	 as patches
[22:41:23] <yuvipanda>	 brion:  the password storage we can obfuscate it later if we want - is abstracted enough
[22:41:39] <yuvipanda>	 off for realz
[22:41:39] <yuvipanda>	 now
[22:41:41] <yuvipanda>	 bye
[22:43:29] <brion>	 whee
[23:04:01] <mhurd>	 dr0ptp4kt: have a sec?
[23:25:52] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Story 1643: Improve typography for overlays (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[23:32:46] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry)