[00:00:46] <awjr>	 tfinc: there's no hangout link on the calendar invite
[00:03:05] <kenanwang__>	 tfinc you around?
[00:04:53] <grrrit-wm>	 (03PS14) 10Dr0ptp4kt: WIP: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 
[00:17:16] <jgonera>	 kaldari, are you working on the ve toolbar story?
[00:17:30] <kaldari>	 it's assigned to me, but I'm actually working on https://bugzilla.wikimedia.org/show_bug.cgi?id=60542 at the moment, which is related to a previous card I worked on.
[00:54:07] <grrrit-wm>	 (03CR) 10JGonera: "I was going to take over this patch and fix the small mistakes, but I discovered more problems with it:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 (owner: 10Jdlrobson)
[01:06:20] <grrrit-wm>	 (03PS1) 10Kaldari: Fixing thumbnail styles on alpha and beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112616 
[01:07:35] <kaldari>	 jgonera: Can you review this quick fix of a regression: https://gerrit.wikimedia.org/r/#/c/112616
[01:28:32] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Hide edit pencils for now, make mobile langlinks list direct link. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112619 
[01:30:13] <grrrit-wm>	 (03PS2) 10Dr0ptp4kt: Hide edit pencils for now, make mobile langlinks list direct link. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112619 
[01:32:08] <grrrit-wm>	 (03PS3) 10Dr0ptp4kt: Hide edit pencils for now, make mobile langlinks list direct link. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112619 
[01:35:40] <kaldari>	 jgonera: How do I test the languages overlay locally?
[01:42:27] <dr0ptp4kt>	 kaldari, ?mobileaction=beta
[01:54:27] <grrrit-wm>	 (03PS4) 10JGonera: Hygiene: Cleanup naming convention for special page RL modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111146 (owner: 10Jdlrobson)
[01:54:59] <jgonera>	 kaldari, can you check https://gerrit.wikimedia.org/r/#/c/111146 later and merge if it works for you?
[02:03:24] <grrrit-wm>	 (03PS1) 10JGonera: Regression: Fix font size for search input [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112628 
[02:03:51] <jgonera>	 kaldari, also this small regression: https://gerrit.wikimedia.org/r/#/c/112628/ (more urgent)
[02:04:08] <kaldari>	 ok. one sec...
[02:06:55] <jgonera>	 kaldari, where can I test https://gerrit.wikimedia.org/r/#/c/112616/ ? what page?
[02:07:58] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Fixing thumbnail styles on alpha and beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112616 (owner: 10Kaldari)
[02:08:29] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Regression: Fix font size for search input [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112628 (owner: 10JGonera)
[02:09:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixing thumbnail styles on alpha and beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112616 (owner: 10Kaldari)
[02:09:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Regression: Fix font size for search input [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112628 (owner: 10JGonera)
[02:30:47] <grrrit-wm>	 (03CR) 10Kaldari: Story 1643: Improve typography for overlays (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[02:31:01] <grrrit-wm>	 (03PS9) 10Kaldari: Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 
[02:31:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[02:31:47] <grrrit-wm>	 (03PS10) 10Kaldari: Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 
[06:18:52] <grrrit-wm>	 (03PS2) 10Henry: Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 
[06:39:48] <grrrit-wm>	 (03CR) 10Henry: "Classic. I realised I'd made this mistake as soon as I shut my eyes to go to sleep last night. Somehow, because this is a non-printing cha" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry)
[06:48:52] <grrrit-wm>	 (03CR) 10Henry: "Actually, adding one normal space character between the first </li> and the second <li> does the trick just as well. Might it be nicer to " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry)
[08:51:52] <YuviPanda>	 hey MaxSem
[08:52:00] <YuviPanda>	 MaxSem:  did the mobileapp stuff go out yesterday? I don't see https://test.wikipedia.org/w/load.php?debug=true&lang=en&modules=mobile.app&only=styles&skin=vector&*
[08:52:53] <MaxSem>	 heh, a few problems were met, I'll email shortly
[09:37:51] <yurik>	 MaxSem, you are awake?
[09:37:58] <yurik>	 i thought you don't get online at this time :)
[09:37:58] <MaxSem>	 yes
[09:40:57] <yurik>	 MaxSem, hehe. Oki, want to vchat?
[09:41:08] <MaxSem>	 1 sec
[09:41:16] <MaxSem>	 got a toothbrush in my mouth
[09:42:51] <yurik>	 TMI :-P
[14:13:54] <grrrit-wm>	 (03PS1) 10Zfilipin: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 
[14:14:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin)
[14:17:51] <grrrit-wm>	 (03PS2) 10Zfilipin: QA: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 
[14:18:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] QA: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin)
[16:40:54] <YuviPanda>	 brion: around?
[16:42:17] <brion>	 yo
[16:53:34] <brion>	 brb
[17:14:14] <YuviPanda>	 brion: there's a largish login / logout patch there :)
[17:14:21] <YuviPanda>	 working on CA now
[17:14:22] <brion>	 \o/
[17:14:34] <brion>	 i'll try to peek it over before vanishing into more VPE interviews
[17:14:44] <YuviPanda>	 brion: oh, today as well? ok!
[17:15:02] <brion>	 yep
[17:15:04] <brion>	 two glorious days
[17:26:35] <mhurd>	 YuviPanda: heya!
[17:26:44] <YuviPanda>	 hey mhurd
[18:13:13] <kaldari>	 kaity: have you seen jared around?
[18:13:51] <kaity>	 kaldari:  he's in VPE interviews all day. not sure what that is
[18:14:35] <kaldari>	 ah yeah, same as yesterday :P
[18:21:05] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Couple quick notes inline, still need to test and look over the alert views and such." (036 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 (owner: 10Dr0ptp4kt)
[18:50:53] <MaxSem>	 jgonera and kaldari, can you please take a look at https://gerrit.wikimedia.org/r/#/c/111250/ ?
[18:51:14] <MaxSem>	 ...before I start the fun more publicly:)
[18:54:35] <kaldari>	 MaxSem: Personally, I would prefer a more structured approach than just including "blobs". If we define the types of data that we are including, it let's us have RL do more fun things to them, like minification, validation, etc.
[18:54:37] <jgonera>	 MaxSem, sure, will do
[18:58:03] <MaxSem>	 kaldari, that's a serious chunk of work, while I was only trying to upstream our template delivery system:)
[19:00:13] <kaldari>	 well, what if we just started with templates then, like we do in mobile? Would that be too provocative?
[19:00:15] <MaxSem>	 also, other types of modules can add their own blob handlers with minification etc
[19:00:50] <MaxSem>	 we can't start with templates because there's still no agreed upon engine
[19:01:08] <jgonera>	 MaxSem, I have one problem with it ;) for something that will probably become a pretty crucial part of MW, it's scary that it doesn't have any tests
[19:01:46] <MaxSem>	 kaldari, also I wanted an explicitly generic delivery method
[19:01:56] <kaldari>	 true, but RL doesn't have to care about what kind of template engine is used
[19:02:37] <kaldari>	 MaxSem: fair enough, I don't feel strongly about it. Just my initial impression.
[19:03:27] <MaxSem>	 jgonera, any ideas how to test this stuff which is very much on the edge of PHP and JS? of course I could compare PHP output with a predefined string but that's lame and does not verify that this string actually does what we're asking it to
[19:04:33] <kaldari>	 kenanwang__: sent you the rough deployment time for the new KeepGoing. Let me know if you need a more specific time. Also, I have 2 stories in ready for sign-off, so feel free to poke me if you want to go over them any time soon.
[19:06:23] <kaldari>	 MaxSem: You could just test that "something" gets delivered, i.e. mw.blobs.get( 'whatever' ) isn't null when it's defined.
[19:07:39] <jgonera>	 MaxSem, I think that's better than nothing. Look at current tests of templates in MF or things like testLessFileCompilation in ResourceLoaderTest.php
[19:08:40] <MaxSem>	 thanks!
[19:08:51] <jgonera>	 MaxSem, you could also add a test in QUnit, just have a test module with a test template and then see if the template content is OK in QUnit
[19:19:51] <kaldari>	 kenanwang__: I don't think KeepGoing has ever been promoted to stable
[19:20:32] <kenanwang__>	 Are you sure it should be. I thought I checked on Betalabs.
[19:20:45] <kenanwang__>	 Kaldari ^
[19:21:00] <kenanwang__>	 There was a card for it
[19:21:09] <kaldari>	 hmm, I'll check
[19:23:08] <kaldari>	 kenanwang__: ah, you're right, sorry...
[19:23:20] <kaldari>	 let me look up the deployment date for that....
[19:28:39] <kaldari>	 kenanwang__: OK, sent you a new email. Sorry I was confused
[19:28:59] <kaldari>	 arg
[19:29:03] <kaldari>	 wrong date
[19:30:28] <kaldari>	 kenanwang__: So it was deployed last Thursday apparently
[19:46:29] <grrrit-wm>	 (03PS3) 10JGonera: Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry)
[19:47:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry)
[19:48:14] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] "Let's keep &zwnj;. I only added a comment explaining why it's there. A space seems to add an unnecessary gap between those list elements." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry)
[19:49:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry)
[19:54:28] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[19:55:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[19:56:14] <grrrit-wm>	 (03CR) 10JGonera: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry)
[19:57:44] <grrrit-wm>	 (03CR) 10JGonera: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[20:05:56] <aharoni>	 Hallo. Is it supposed to be possible to edit the Hebrew Wikipedia from Android using MobileFrontend?
[20:06:38] <aharoni>	 I'm trying to do it and on all articles I get a pencil with a lock, which means that editing is impossible (as far as I understand).
[20:06:44] <aharoni>	 But it works in the English Wikipedia.
[20:06:56] <aharoni>	 WAT.
[20:06:58] <aharoni>	 It works now.
[20:07:34] <grrrit-wm>	 (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[20:07:40] <aharoni>	 BUT, I don't see anything in the top bar while I'm editing, so there's no save button and I cannot save my edits.
[20:07:53] <aharoni>	 Weird.
[20:08:36] <aharoni>	 I'm using the stock browser on Android 2.3.4.
[20:09:34] <aharoni>	 jgonera: ^ any idea?
[20:10:27] <grrrit-wm>	 (03PS11) 10Kaldari: Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 
[20:10:58] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[20:11:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[20:14:12] <kaldari>	 chrismcmalunch: having problems with jenkins and qunit: ^
[20:14:33] <YuviPanda>	 aharoni: I think you *are* supposed to be edit
[20:14:39] <YuviPanda>	 aharoni: can you try with desktop chrome?
[20:14:52] <YuviPanda>	 aharoni: It is possible that android 2.3 has been blacklisted (I do not know this for sure at all)
[20:15:24] <aharoni>	 YuviPanda: trying...
[20:15:29] <YuviPanda>	 aharoni: ok
[20:16:15] <aharoni>	 YuviPanda: works well.
[20:16:32] <aharoni>	 Maybe some JS fails on my phone's browser.
[20:16:36] <aharoni>	 I wonder how can I debug that.
[20:16:48] <aharoni>	 Is there a JS console on the stock browser or something..
[20:16:49] <aharoni>	 ?
[20:17:07] <YuviPanda>	 aharoni: heh, you wish :P
[20:17:10] <aharoni>	 :)
[20:17:12] <YuviPanda>	 aharoni: it *might* be blacklisted
[20:17:15] <YuviPanda>	 I don't know for sure
[20:17:18] <YuviPanda>	 aharoni: try enwiki?
[20:17:22] <aharoni>	 I wonder how you mobile web guys do that.
[20:17:23] <YuviPanda>	 on your phone, that is
[20:17:31] <aharoni>	 Yes - in enwiki it works.
[20:17:49] <YuviPanda>	 aharoni: when I did  similar things (PhoneGap on Android 2.3) it was a lot of hacks and swearing :)
[20:17:50] <aharoni>	 Can you try it maybe? Do you have some Android 2.3.4 device around, or something similar?
[20:18:01] <aharoni>	 (I'll also try on Android 4.)
[20:18:14] <YuviPanda>	 aharoni: I do have a couple of android 4.4 devices, around. let me try
[20:18:25] <YuviPanda>	 I will try to randomly click on things until I see an edit box :D
[20:18:55] <aharoni>	 YuviPanda: here's my favorite article for tests: he.m.wikipedia.org/wiki/ASCII
[20:19:04] <aharoni>	 http://he.m.wikipedia.org/wiki/ASCII
[20:19:08] <aharoni>	 Short Latin title :)
[20:20:23] <YuviPanda>	 aharoni: I do get an edit button
[20:20:27] <YuviPanda>	 and I seem to be able to make edits
[20:20:30] <YuviPanda>	 although I haven't made any
[20:20:40] <YuviPanda>	 violetto: around? small question
[20:20:50] <dr0ptp4kt>	 yurik, able to videoconference?
[20:21:29] <yurik>	 dr0ptp4kt, yep
[20:22:03] <aharoni>	 YuviPanda: all seems to work well on Android 4. I strongly suspect that some JS fails at some point.
[20:22:40] <YuviPanda>	 aharoni: yeah, sounds likely.
[20:22:52] <YuviPanda>	 aharoni: I'd suggest filing a bug report, since that automatically gets pulled into 'mingle'
[20:23:23] <aharoni>	 I noticed that on Android 4 the editing button initially has the lock and then it disappears.
[20:23:44] <aharoni>	 I guess that the editing is disabled initially and then some JS enables it,
[20:23:55] <aharoni>	 and on Android 2.3.4 it sometimes fails.
[20:24:22] <aharoni>	 And the top editing toolbar doesn't work at all in Hebrew.
[20:25:32] <YuviPanda>	 aharoni: yeah, I also noticed the 'lock and disappear'
[20:25:43] <YuviPanda>	 aharoni: might be a JS failure, yeah
[20:30:48] <zeljkof>	 jgonera: I have just noticed that the google calendar event does not have hangout link :)
[20:30:52] <zeljkof>	 and I can not add one
[20:31:06] <YuviPanda>	 aharoni: do file a bug!
[20:31:12] <aharoni>	 OK
[20:32:46] <jgonera>	 zeljkof, on it, just a sec
[20:34:38] <jgonera>	 zeljkof, done, shuold be there now
[20:35:30] <zeljkof>	 jgonera: reloading...
[20:42:07] <aharoni>	 very, very curious, YuviPanda : I see odd JS errors when I try to edit from desktop Firefox, too.
[20:42:16] <YuviPanda>	 aharoni: what js errors?
[20:42:28] <aharoni>	 "Exception thrown by job.error"
[20:42:33] <aharoni>	 "Error: Container must be attached to the DOM"
[20:42:33] <YuviPanda>	 ...
[20:42:35] <YuviPanda>	 job?!
[20:42:37] <YuviPanda>	 oh
[20:42:48] <YuviPanda>	 hmm
[20:42:50] <aharoni>	 This appears at https://he.m.wikipedia.org/wiki/ASCII#editor/0 .
[20:42:56] <aharoni>	 Works on Chrome.
[20:43:18] <aharoni>	 I'm pretty sure that I could edit from desktop Firefox just a couple of days ago. Was anything new deployed?
[20:43:29] <YuviPanda>	 aharoni: the entire header code changed, IIRC
[20:43:52] <aharoni>	 let me try this with debug
[20:43:58] <YuviPanda>	 aharoni: ok
[20:44:05] <YuviPanda>	 aharoni: are you talking about mobile ff?
[20:44:19] <aharoni>	 No, desktop Firefox.
[20:44:34] <aharoni>	 (I think that it's the first time I try running MF with debug=true. Is it even supposed to work? :) )
[20:45:50] <aharoni>	 ... no, it doesn't seem to work.
[20:45:53] <YuviPanda>	 aharoni: ah, right.
[20:45:53] <YuviPanda>	 aharoni: it is technically supposed to, yeah :)
[20:46:07] <aharoni>	 I guess that I'll report that as a bug as well.
[20:49:46] <NateshR>	 hello . I am interested in developing wiki news app . Please guide me how can i start ?
[20:50:04] <NateshR>	 and which libraries of android ?
[20:50:21] <dr0ptp4kt>	 yurik, so like this, please:
[20:50:43] <dr0ptp4kt>	 iif X-CS was present, then tack on X-Zero-Rated: 1
[20:50:47] <dr0ptp4kt>	 else do nothing
[20:52:03] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: "We're going to try to do this in Varnish for the time being. Yuri's working on a small patch that does the following:" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 (owner: 10Dr0ptp4kt)
[20:52:09] <YuviPanda>	 aharoni: yeah, please do
[20:52:33] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 04-2] "Holding off on this until we know one way or the other whether this can be easily done in Varnish." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/111399 (owner: 10Dr0ptp4kt)
[20:55:57] <aharoni>	 YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=61232
[20:56:02] <YuviPanda>	 aharoni: thanks! :)
[20:56:12] <YuviPanda>	 aharoni: although I don't believe I can myself help much :(
[20:56:30] <YuviPanda>	 aharoni: did I mention the android (and iOS) apps are going to have editing built in to them?
[20:57:02] <aharoni>	 YuviPanda: I heard this somewhere... maybe from Jon.
[21:00:34] <yurik>	 dr0ptp4kt, around? could you rejoin vchat pls
[21:00:46] <dr0ptp4kt>	 yurik, yeah, hang on
[21:01:01] <dr0ptp4kt>	 yurik, wanna invit me?
[21:01:07] <dr0ptp4kt>	 i'm online, just hidden
[21:01:15] <dr0ptp4kt>	 oh, i see it
[21:02:30] <YuviPanda>	 aharoni: the last release already had anon editing
[21:02:39] <YuviPanda>	 aharoni: the next one (tomorrow?) will have logged in editing
[21:03:03] <aharoni>	 YuviPanda: the app, you mean?
[21:04:30] <aharoni>	 oh, and YuviPanda: do you happen know what's the status of the app translation in translatewiki? It's silly that I'm asking you, because it should be vice versa, but it just struck me that I haven't checked what's going there for a while.
[21:05:05] <aharoni>	 I saw that the Android plurals support patch was merged a few weeks ago, but did anything else progress? And is that patch enough?
[21:05:08] <YuviPanda>	 aharoni: I think brion was supposed to get that in there?
[21:05:16] <YuviPanda>	 aharoni: I guess so, we just need to get the repos registered.
[21:05:32] <YuviPanda>	 aharoni: brion was supposed to do that, but idk what the status of that is. any help or that would be welcome, I think :)
[21:05:55] <aharoni>	 OK, I'll try to check what's happening with that some time very soon. You know how proud I am of our ultramegatranslated apps.
[21:08:15] <YuviPanda>	 aharoni: :)
[21:08:34] <YuviPanda>	 aharoni: you should maybe drop an email to brion going 'how is it going on getting thos into twn'? :)
[21:08:40] <aharoni>	 OK
[21:11:00] <dr0ptp4kt>	 yurik, per our videoconference, revised plan: just tack outbound X-CS: <value> header
[21:11:11] <yurik>	 yep
[21:18:00] <yurik>	 dr0ptp4kt, done
[21:18:04] <yurik>	 https://gerrit.wikimedia.org/r/#/c/112805/
[21:19:13] <violetto>	 YuviPanda: here now!
[21:19:51] <YuviPanda>	 violetto: just wanted to show you something, but then I broke it before taking screenshots :( will poke again when I have it working
[21:20:08] <violetto>	 YuviPanda: D:
[21:20:10] <violetto>	 okeh
[21:23:10] <grrrit-wm>	 (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari)
[21:23:14] <aharoni>	 YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=61233
[21:23:40] <YuviPanda>	 aharoni: :) ok
[21:24:25] <kaldari>	 chrismcmalunch: having problems with jenkins: https://gerrit.wikimedia.org/r/#/c/111374/
[21:24:38] <kaldari>	 chrismcmahon: ^
[21:25:08] <chrismcmahon>	 kaldari:  sorry, was afk.  I don't know much about qunit at all, looking... 
[21:25:35] <chrismcmahon>	 kaldari:  Jenkins gave you a +1 just now?
[21:25:41] <kaldari>	 also, for some reason "recheck" doesn't get jenkins to rerun all the tests
[21:26:08] <kaldari>	 chrismcmahon: Yeah, it will either give a -2 or a +1, neither of which allow me to merge it
[21:26:11] <chrismcmahon>	 kaldari:  I'm going to have to send you to hashar or Krinkle, no idea
[21:27:11] <kaldari>	 here's the qunit output from Jenkins (that's failing): https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-qunit-mobile/2029/console
[21:28:00] <kaldari>	 it seems to be failing on initialization
[21:29:11] <mhurd>	 dr0ptp4kt: https://github.com/montehurd/apps-ios-wikipedia/commit/ae6a0197d1af70abc45e7265c8f9ed13097e92e8#diff-7cac9a3f82e0e22f9613ea5889d2a6d0L5
[21:30:08] <chrismcmahon>	 kaldari: I have never used qunit, sorry to be so not helpful
[22:56:27] <grrrit-wm>	 (03PS1) 10JGonera: Fix missing overlay header in RTL languages on Android 2.3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112822 
[22:56:39] <jgonera>	 kaldari, small fix, merge when you have time ^
[22:56:46] <jgonera>	 aharoni, fixed ^
[22:57:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix missing overlay header in RTL languages on Android 2.3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112822 (owner: 10JGonera)
[23:05:30] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "Just a small concern." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin)
[23:15:20] <grrrit-wm>	 (03PS1) 10Jforrester: Regression: Fix font size for search input [extensions/MobileFrontend] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112823 
[23:16:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Regression: Fix font size for search input [extensions/MobileFrontend] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112823 (owner: 10Jforrester)
[23:17:58] <grrrit-wm>	 (03Abandoned) 10Jforrester: Regression: Fix font size for search input [extensions/MobileFrontend] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112823 (owner: 10Jforrester)
[23:24:49] <chrismcmahon>	 MaxSem:  failures are all reasonable. keepgoing, VE, and search failures, I think manybubbles was updating indexes out there today
[23:25:11] <MaxSem>	 awesome
[23:50:44] <MaxSem>	 kaldari, so why do you want to replace a customizable solution with a one-off formula?
[23:51:12] <kaldari>	 which one are you talking about?
[23:51:37] <kaldari>	 position, width, or ratio?
[23:51:58] <MaxSem>	 all of them
[23:52:49] <kaldari>	 well, in the case of width I think you're probably right. It would make more sense to do something customizable...
[23:53:37] <kaldari>	 I don't see a strong reason anyone would need to customize position or ratio though.
[23:54:14] <kaldari>	 but maybe you have a different opinion on it?
[23:54:15] <MaxSem>	 why can't someone boost first position drastically?
[23:54:42] <MaxSem>	 or even the second one, if that's how articles on their wiki are organised
[23:54:50] <kaldari>	 hmm, maybe so, but it's kind of micro-optimization
[23:55:24] <kaldari>	 OK, OK, leave position customizable then :)
[23:56:02] * MaxSem  chuckles his fingers

[23:56:06] <kaldari>	 what about ratio? Is someone really going to want to figure out what those numbers mean and create their own table for it?
[23:56:48] <kaldari>	 3, 5, 20, 30, 31 is just a mysterious sequence unless you dig in the code
[23:57:03] <MaxSem>	 it actually has a comment
[23:57:10] <MaxSem>	 explaining what it means
[23:57:25] <MaxSem>	 what about panoramas?
[23:57:42] <MaxSem>	 what if they're a valid PI somewhere?
[23:58:14] <kaldari>	 PI?
[23:58:28] <MaxSem>	 Page Image
[23:58:44] <grrrit-wm>	 (03PS1) 10JGonera: Update QUnit tests to use sinon.js from core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112826 
[23:59:02] <jgonera>	 kaldari, let us merge again ^