[00:00:15] chrismcmahon: kaldari: What's up? [00:00:17] MaxSem: OK, I guess you make a decent argument. I'll be really surprised if anyone ever customizes it, but who knows. [00:00:49] If you're going to keep the ratio table though, I think it should have 2 changes.... [00:01:05] Krinkle, your patch adding sinon.js broke all our QUnit tests ;) [00:01:26] Krinkle, but it's fine, I modified them to use sinon.js in core instead of the one we had [00:03:20] Krinkle, for some reason useFakeXMLHttpRequest() doesn't work with this.sandbox, but I'll figure it out later (unless you have an idea: https://gerrit.wikimedia.org/r/#/c/112826/1/tests/javascripts/common/test_api.js) [00:04:10] actually, gimme a sec... [00:04:30] jgonera: Make sure you're not throwing away mwEnvironemnt [00:04:57] QUnit.module( .., QUnit.newMwEnvironment( { setup: function custom() { .. [00:05:09] It's optional, but if you want core features, you need it [00:05:54] mw-core provided qunit features, that is, like this [00:13:28] MaxSem: actually, nevermind. I'm fine with it how it is. [00:14:04] MaxSem: Sorry for the bad ideas :) [00:14:27] it's okay:) discussion is always useful [00:15:39] MaxSem: It's hard for me to see a sequence that looks like an equation and not make one out of it :) [00:15:59] damn mathies:P [00:20:36] huh, Krinkle, this.sandbox seems to work without QUnit.newMwEnvironment though [00:21:19] jgonera: Well, then you're putting it there somehow [00:21:27] maybe you're loading a custom sinon built still? [00:21:31] I see it removed sinon.js [00:21:41] do you perhaps have sinon-qunit.js somewhere? [00:22:11] Krinkle, we never had sinon-qunit.js and grep -nr MwEnvironment returns no results [00:22:36] Nevermind, My commit does it in the general QUnit.module [00:22:49] no need for MwEnvironment, that's only for mw.config reset etc. [00:23:06] ok, I'll remember that anyway, might be handy some day [00:23:12] You should probably still use it, but it shouldn't matter in this case [00:23:16] jgonera: So what isn't working? [00:23:18] Can you be more specific? [00:23:23] If this.sandbox exists, what is the problem? [00:24:03] in https://gerrit.wikimedia.org/r/#/c/112826/1/tests/javascripts/common/test_api.js if I change sinon.useFakeXMLHttpRequest() to this.sandbox.useFakeXMLHttpRequest() the create event on xhr never seems to happen [00:25:00] jgonera: Beware that the sandbox provides as server instead of a mere xhr [00:25:07] Should work the same still [00:25:14] (as both have onCreate) [00:25:30] Krinkle, but don't spend too much time on it, this test needs to be refactored anyway I think [00:25:41] but if you accidentally rely on it, try this.server = this.sandbox.useFakeServer(); and then this.server.xhr.onCreate = .. [00:25:54] hm [00:25:58] ok, will check [00:26:07] thanks [00:27:11] jgonera: Also look into the $.ajax abort logic, I don't think taht should be needed. Looks like a bug. [00:27:15] btw, Krinkle, what does properties: ['spy', 'stub', 'mock', 'clock', 'sandbox'] do? can I do this.spy() and then it doesn't belong to the sandbox? [00:27:27] Don't know [00:27:34] (at this moment) [00:27:44] Krinkle, what specifically shouldn't be needed? [00:27:53] you don't know? but it's from your patch ;) [00:28:01] this.sandbox.stub( $, 'ajax', function() { var request = { abort: self.sandbox.spy() }; ... [00:28:05] that code should not exist in MF I think [00:28:29] mhm, possibly [00:29:10] it's a messy test file... [00:31:23] Krinkle, this.server.xhr.onCreate works, thanks [00:32:01] Krinkle, one more, when I need something like sinon.match should I just use sinon.match (global sinon variable)? [00:32:26] (03PS2) 10JGonera: Update QUnit tests to use sinon.js from core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112826 [00:36:24] jgonera: btw, reported upstream as https://github.com/cjohansen/Sinon.JS/issues/393 [00:36:31] it does look like a bug [00:36:51] jgonera: In the sandbox, useFakeXMLHttpRequest === useFakeServer [00:37:06] (last week) [00:37:25] oh, that explains a lot [00:37:52] any tips on things like sinon.match? [00:39:07] Krinkle, ^ [00:39:16] noep [00:39:17] nope [00:42:45] (03PS3) 10JGonera: Update QUnit tests to use sinon.js from core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112826 [00:51:51] (03CR) 10Kaldari: [C: 032] Update QUnit tests to use sinon.js from core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112826 (owner: 10JGonera) [00:52:36] (03Merged) 10jenkins-bot: Update QUnit tests to use sinon.js from core [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112826 (owner: 10JGonera) [00:55:09] (03PS2) 10JGonera: Fix missing overlay header in RTL languages on Android 2.3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112822 [00:58:19] MaxSem: Do you want to change the key names or leave them with a space? [00:58:43] hmm, I gues I can change them [01:31:23] jgonera: kaldari can you guys respond to my email about rescheduling our retro and kickoff next week? i need to figure out how we'll do it asap so we can be sure to get a functional conference room [01:31:37] sure [01:54:48] dr0ptp4kt: https://github.com/montehurd/apps-ios-wikipedia/commits/login [02:14:16] (03PS15) 10Dr0ptp4kt: WIP: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [02:15:31] (03CR) 10Dr0ptp4kt: "See comments in this patchset. Note I will look at updating the UI chrome across more places in future patchset. Wanted to address the oth" (037 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 (owner: 10Dr0ptp4kt) [10:30:23] hi matanya [10:30:24] hi [10:30:50] matanya: let me switch my phone to he [10:30:52] ok, so first thing first :the icon is just android, not the W [10:31:48] matanya: yup, that's just me being lazy :D [10:31:51] matanya: and not getting assets yet [10:31:54] matanya: let me file bugs [10:32:06] second, on hebrew, all headers and titles are left alligned [10:32:26] you may CC me on the bugs if you wish [10:32:52] matanya: sure! [10:34:42] matanya: https://bugzilla.wikimedia.org/show_bug.cgi?id=61260 [10:35:08] third: when clicking on images to see their lisence the device opens the browser [10:35:42] matanya: that's currently 'by design' until we could build a proper image viewer. [10:38:27] * matanya is still checking [10:42:13] fourth: log in doesn't work [10:42:27] oh, it does [10:42:38] but in unintuitive way [10:42:50] matanya: yes, that is still a WIP :) [10:43:00] matanya: it works only on your 'home wiki' for now [10:43:07] matanya: that's the CA issues I was talking about [10:43:13] plus needs some design fixes. [10:43:37] no, that wasn't what i refer to [10:43:58] if you type the password and then enter, nothing happens [10:44:22] matanya: oh, 'done' is not handled? [10:44:23] ok [10:44:23] you must click the envelope (or watherver that icon is) [10:44:26] let me file a bug for that [10:44:32] that icon will change [10:45:11] matanya: https://bugzilla.wikimedia.org/show_bug.cgi?id=61261 [10:45:56] fifth: parthensis are incorrect [10:46:22] in templates [10:47:05] sixth:the copyright note is not localized [10:48:44] there's a copyright notice?! [10:48:52] matanya: which template? [10:48:57] oh crash :/ [10:49:00] we haven't added the copyright notice anywhere [10:50:12] (03PS1) 10Yuvipanda: Make 'Done' perform login action [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112870 [10:50:15] on the end of every page [10:50:26] matanya: oh, that's just because this isn't in twn yet [10:50:32] brion was supposed to get that in this week [10:50:34] ok [10:50:43] matanya: aharoni did a temp. translation just for the he strings :) [10:50:46] to test out hebrew [10:51:04] hi matanya [10:51:08] hi aharoni [10:51:22] the app is not in translatewiki yet, but I hope to get it there soon. [10:51:23] oh, crashed agian [10:51:43] matanya: it should offer to send me crash reports [10:51:51] yeah, it does [10:52:00] you could send it :D [10:52:54] sent you from the freinds mail [10:53:17] matanya: oh wow :D [10:53:20] matanya: error says [10:53:21] STACK_TRACE=java.lang.RuntimeException: FIX THIS YUVI! [10:53:37] matanya: are you trying to test out the saved pages? :) [10:53:54] no [10:54:05] was just reading the article chess on he wiki [10:54:53] oh, hmm [10:54:59] matanya: I'll get that one fixed. [10:55:17] ok, i'm done with testing for now :) [10:55:22] matanya: :) [10:55:32] matanya: not too bad or very terrible? [10:55:46] no, mostly usable [10:55:52] - the crash :) [10:57:44] matanya: :D [13:16:03] (03PS1) 10Yuvipanda: Fix cookie handling to support .wikipedia.org cookies [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112886 [13:16:21] boom! [13:16:23] hey brion! [13:16:26] CA works now! [13:23:24] \o/ [13:23:35] brion: review? :) [13:23:45] shortly :) [13:23:53] gotta finish making my breakfast :D [14:04:07] YuviPanda: hello! [14:04:13] vbamba: hello! [14:04:16] vbamba: up early! [14:05:26] yes =] [14:05:33] Had a qq for you [14:05:37] vbamba: sure! [14:05:40] I can't see the changes on labs yet [14:05:51] for the stuff that Prateek submitted patches for [14:05:56] vbamba: which one? [14:05:59] Did you have a chance to merge them? [14:06:09] vbamba: I merged the design ones. not the relative time one. [14:06:10] vbamba: He has [14:06:31] vbamba: But they didn't include everything we had discussed [14:06:38] awesome, i shd just refresh labs [14:07:24] vbamba: So I'll submit another patch and have YuviPanda merge it tonight [14:07:28] (our tonight) [14:56:29] (03CR) 10Brion VIBBER: [C: 04-1] "I have a bunch of compile errors in the tests like this:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112584 (owner: 10Yuvipanda) [14:58:36] (03CR) 10Brion VIBBER: "Ugh those seem to be regressions from 27d9b2c520" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112584 (owner: 10Yuvipanda) [14:59:39] brion: it works for me? [14:59:46] brion: ohhh, doesn't [14:59:47] grr [15:01:11] ping: wmf mobile staff [15:01:13] YuviPanda: yeah feel free to fix the tests in a later commit [15:01:14] we'll ive [15:01:22] brion: yeah doing it [15:01:32] hi Steinsplitter [15:01:51] hi brion, what is the status about my request? [15:02:05] Steinsplitter: i have no idea, what's your request? [15:02:09] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1314 [15:02:34] the mobile upload filter. [15:03:25] i think that falls in the mobile web area... they don't appear to have commented on that card so no idea if it's a priority [15:03:35] the card seems a bit vague to me; what do you mean by filter? [15:04:01] stop uploading new users files with no exif [15:04:32] with ABF it is not possible to filter (bug) [15:04:36] YuviPanda: here's an interesting one -- password field changes fonts when i swap the 'display password' checkbox [15:05:13] Steinsplitter: anything mobile-specific about that? seems to me you'd want to apply to everyone [15:05:15] brion: oh wat [15:05:18] brion: that's weird [15:06:25] brion: MobileUpload-related deletion requests/deleted‎ (4258 P) [15:06:44] --> this to too much (4258 P), speedydeletions not included [15:13:51] the WMF has time to create nonsens tool, but not to mantain existing ones... congrats. [15:15:41] (03CR) 10Brion VIBBER: "I can't edit on test.wikipedia.org while logged in; I get a fatal crash with an error about an invalid token." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112584 (owner: 10Yuvipanda) [15:15:56] brion: that's fixed in the next commit [15:16:01] agh [15:16:02] fun [15:16:02] brion: that's the CA stuff [15:16:45] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok apparently that's symtompatic of other stuff and fixed later. The actual logout appears to work." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112584 (owner: 10Yuvipanda) [15:32:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle back button properly when no more pages are left [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112588 (owner: 10Yuvipanda) [15:34:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make 'Done' perform login action [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112870 (owner: 10Yuvipanda) [15:38:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix cookie handling to support .wikipedia.org cookies [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112886 (owner: 10Yuvipanda) [15:38:52] YuviPanda: also we seem to have lost the save icon on edit dialog [15:39:01] i just see an overflow menu with an item with no text [15:39:01] O_O [16:43:21] brion: oh, I just saw that [16:45:56] brion: I'll look into it [16:46:16] thx [16:48:44] brion: found it. fixing [16:48:58] so hard to type when eating a gooey chocolate brownie on the other hand [16:49:04] mmmmm [16:49:07] now i want a brownie :( [16:50:30] (03PS1) 10Yuvipanda: Fix compilation errors due to sig change [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112909 [16:50:32] (03PS1) 10Yuvipanda: Display actions properly in Edit Window [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112910 [16:50:33] brion: ^ [16:50:36] \o/ [17:00:11] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I still have some runtime failures in tests due to bad edit tokens and such, but this fixes compile errors. Yay!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112909 (owner: 10Yuvipanda) [18:01:50] dr0ptp4kt: around? [18:02:27] btw, dr0ptp4kt, you might want to get cloaking :) [18:04:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] Display actions properly in Edit Window [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112910 (owner: 10Yuvipanda) [18:08:34] yurikR, yeah i'm here [18:16:22] kaldari, https://gerrit.wikimedia.org/r/112787 :) [18:16:31] testing now [18:18:56] thanks kaldari [18:19:37] hey mhurd did you get the chance to upload latest screens to trello yet? [18:24:10] violetto1: not yet - lemme check what's changed... [18:24:36] brion: you should see https://plus.google.com/+RomanNurik/posts/h8tG8oLcTEq! [18:24:37] err [18:24:38] https://plus.google.com/+RomanNurik/posts/h8tG8oLcTEq [18:24:56] brion: I should write a POTD Commons plugin for that [18:25:55] nice [18:26:06] brion: you should try it out on your phone too [18:26:08] quite very nice [18:27:20] artsy :D [18:27:30] violetto1: i updated the main nav and sign-in landing "current on ios" cards to have screenshots of what i have at the moment [18:27:38] very nice promo video [18:27:43] we should do one for our app :D [18:29:56] brion: heh, yeah :) [18:34:32] brion: do you know if there's a tool api or something that gives you POTD? [18:35:00] dr0ptp4kt, sorry, had a connection drop [18:35:09] yurik, no prob [18:35:12] dr0ptp4kt, are there any patches we want to go out today? [18:35:27] that js/css one would be good [18:35:42] yurik ^ [18:36:06] YuviPanda: there's a feed [18:36:08] dr0ptp4kt, https://gerrit.wikimedia.org/r/#/c/112619/ ? [18:36:23] YuviPanda: https://www.mediawiki.org/wiki/Extension:FeaturedFeeds/WMF_deployment [18:36:30] yurik, yeah [18:36:51] or you could pull out of the templates used to construct it i supposes :D [18:39:16] (03CR) 10Yurik: [C: 032] Hide edit pencils for now, make mobile langlinks list direct link. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112619 (owner: 10Dr0ptp4kt) [18:39:20] (03Merged) 10jenkins-bot: Hide edit pencils for now, make mobile langlinks list direct link. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/112619 (owner: 10Dr0ptp4kt) [18:39:32] (03PS1) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 [18:39:34] (03CR) 10jenkins-bot: [V: 04-1] (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [18:43:36] (03CR) 10Brion VIBBER: "That's weird, it totally merges for me...?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [18:45:27] jgonera: looks like https://gerrit.wikimedia.org/r/#/c/112595/ isn't getting merged due to a php style checker [18:45:34] head's up that im cleaning up the file now to make it pass [18:46:12] (03CR) 10Brion VIBBER: "couple inline notes" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [18:54:18] mhurd: blue #347BFF [18:59:11] (03PS4) 10Awjrichards: Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry) [19:05:18] (03CR) 10Yuvipanda: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [19:05:51] brion: that's just jenkins being terrigble [19:06:13] damn you jenkins [19:24:16] bugagaga http://imgur.com/pu1gk3E ... happy valentine everyone :D [19:24:22] slightly off-topic. sorry [19:38:32] How can i start developing wiki news app ? [19:40:07] (03CR) 10Awjrichards: "Just a head's up that Jenkins-bot was not marking this patchset as fully verified because a PHP style checker was failing. I pulled the pa" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry) [19:40:25] jgonera: when you have a sec ^ [19:43:05] awjr, shouldn't this be a separate patch? I'm usually not very obsessive about sneaking in small unrelated changes but it was a single line patch and now it's a 50 line patch ;) [19:43:05] awjr, and the PHP style checker is non-voting, right? [19:43:05] awjr, I mean it says "https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-phpcs-HEAD/900/console : FAILURE in 7s (non-voting)" [19:43:05] so I assume we can merge it without fixing the style? [19:43:51] jgonera: the patch was sitting there unmerged with a +1 verified and a +2 for code review [19:44:16] jgonera: i know it says non-voting, but i assumed since it wasnt +2 verified, that was blocking the merge [19:44:24] uh, wouldn't a simple recheck help? [19:44:26] jgonera: i also would prefer to see the patches separated [19:44:29] jgonera: apparently not [19:44:35] since you tried to recheck it [19:44:54] awjr, I did but there was a different problem then, the QUnit tests were broken [19:44:58] ohh [19:45:22] ok let me back out my changes [19:45:26] and let's see [19:45:29] ok [19:46:03] derp actually im not sure how to roll back to the previous patchset [19:48:37] awjr, hm, maybe checkout patchset 3 and do git review? [19:53:17] how to contribute to wiki news app ? [19:56:40] (03PS5) 10Awjrichards: Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry) [19:57:34] hey kaldari [19:57:44] (03CR) 10Awjrichards: [C: 032] "OK, I misinterpreted what happened - the failure to verify was due to qunit tests being broken. I've restored ps3 and am +2ing; i will com" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry) [19:57:49] hey [19:58:19] (03Merged) 10jenkins-bot: Add zero-width non-joiner to fix Arabic ligature issue affecting Firefox users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112595 (owner: 10Henry) [19:59:10] there we go jgonera :) [19:59:13] sorry about that [19:59:36] awjr, no worries, those broken QUnit tests got kaldari and me confused too [19:59:48] heh [20:00:16] awjr, can you submit the cleanup as a separate patch? I think you should be able to do it somehow by rebasing it [20:00:22] yeah im doing that now [20:00:32] cool [20:02:33] kaldari: are you working on https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1521? [20:02:40] (03PS1) 10Awjrichards: Clean up SkinMinerva to pass mwcodesniffer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112939 [20:03:12] (03PS2) 10Awjrichards: Clean up SkinMinerva to pass mwcodesniffer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112939 [20:03:21] there you go jgonera ^ [20:03:39] thanks awjr [20:03:45] np [20:05:33] mhurd: around? [20:05:39] YuviPanda: ya! [20:05:54] mhurd: so I am wondering how to do 'shake' properly [20:06:07] mhurd: I suppose it is just animating by translating along X, but 'damped' [20:06:10] is that accurate? [20:06:57] YuviPanda: ya depends on how fancy we want it - does android let you tween from one position to another fairly easily? [20:07:03] awjr|lunch, there's still 1 warning and 1 error: https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-phpcs-HEAD/905/console [20:07:10] mhurd: yup, pretty much [20:07:20] mhurd: motion tweening is fairly simple [20:08:18] YuviPanda: cool! so you have initial location, then calculate positions maybe 5% to left and right of that [20:08:43] then tween between the left and right postions a couple times i guess... [20:08:56] then back to initial [20:09:12] mhurd: i tried that, it felt very weird. [20:09:19] mhurd: then I observed the OS X one [20:09:32] mhurd: it seems to be 'damped' - first time it is 5% left right, then 4, 3, 2, 1, 0 [20:09:35] or something like that [20:09:38] (not exact numbers) [20:09:42] YuviPanda: ah i see [20:10:05] mhurd: so I'll have to have a bunch of translates running after each other that are just manually 'damped' [20:10:36] maybe play with the tween durations and maybe a bit of a pause between them [20:10:43] hmm, ok [20:11:39] or have method that you can pass percentage for calculating tween destinations and reduce it each time - 10%, 7%, 3% etc [20:12:57] mhurd: right. I am experimenting with it now [20:14:51] YuviPanda: not sure about this - but there may be a "bounce" interpolator: http://stackoverflow.com/questions/14110512/android-scale-animation-with-bounce-interpolator [20:15:11] mhurd: there *is* a bounce interpolation - it was the first I tried. It doesn't work properly when you repeat it [20:15:30] mhurd: anyway, I'm creating my own cutom animation. let's see how it goes :) [20:15:38] YuviPanda: fun stuff! :) [20:17:29] YuviPanda: not sure how android specifically handles transforms, but on ios after an animation i can reset the "view" transform to the identity transform [20:17:56] mhurd: right. in this case I can't just set a matrix, but I can set them individually to zero [20:18:12] YuviPanda: ah. i see [20:19:21] YuviPanda: set "jiggle" = "true" [20:19:48] (i'm making that up) [20:20:41] :D [20:25:59] mhurd: I am going to let you implement that one first [20:26:06] and then just steal your tweens :) [20:26:18] YuviPanda: no worry! [20:26:18] mhurd: tweening is easy enough, but I think the damping factor needs to be experimented with [20:26:36] ok [20:27:16] YuviPanda: brb - foods! [20:27:20] ok [20:35:39] hey violetto [20:35:44] violetto: around? [20:35:52] violetto: do you have a link to the agora colors wiki page? [20:35:56] vbamba: ^ [20:37:15] https://www.mediawiki.org/wiki/File:Guide_Color.png [20:37:42] violetto: thanks! [20:38:06] vbamba: you might want to mark https://www.mediawiki.org/wiki/File:Agora_ColorPallette-01.png as deprecated [20:42:08] Ya the file I linked to is the one on the color guide [20:43:32] violetto: ping? [20:43:58] YuviPanda: http://tools.wmflabs.org/styleguide/desktop/section-2.html [20:44:17] violetto: that just has buttons, vbamba got me https://www.mediawiki.org/wiki/File:Guide_Color.png [20:44:24] violetto: also, https://www.dropbox.com/s/bmc5h7y9bj9cdow/2014-02-12%2019.04.22.png [20:44:40] violetto: i got the actionbar to be the style you got me. should I change regular background color as well? [20:46:02] YuviPanda: hang on [20:46:06] violetto: ok [20:46:27] YuviPanda: #00AF89 for green (constructive); [20:46:27] #347BFF for blue (progressive); [20:46:27] #D11D13 for red (destructive); [20:46:27] #FF5D00 for orange (med severity). [20:46:27] #FFB50D for yellow (low severity); [20:46:58] violetto: that's the same ones from https://www.mediawiki.org/wiki/File:Guide_Color.png :D [20:47:12] violetto: did you look at the dropbox link? are you okay with the colors there? [20:47:21] (not counting the icon on top right + associated colors for that) [20:48:28] YuviPanda: that should be fine. i created that guide_color a while ago and have gone through so much discussions i wasn't even keeping track anymore [20:48:46] im in another meeting now din get to open the link to cehck [20:49:13] violetto: ok. let me know when you have. no rush :) [20:49:20] YuviPanda: ok! [20:49:30] but whatever i gave you is the latest, if they match then should be good [20:52:32] (03CR) 10Awjrichards: [C: 032] "Recheck again?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari) [20:53:41] (03Merged) 10jenkins-bot: Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari) [20:55:38] YuviPanda: everything accurate except for blue [20:56:09] it's 3C68B1 on Guide_color but the one we want to use is irc://irc.freenode.net:6667/#347BFF [20:56:27] violetto: hmm, it wasn't. https://www.dropbox.com/s/kgsyqapnk0h9yur/2014-02-12%2020.55.56.png is the one with the actual background color you wanted to use (F2F2F2) [20:56:43] violetto: what blue are you talking about? the 'active text focus' blue? [20:57:33] YuviPanda: i was comparing the Guide_color dropbox link to the values i gave you [20:57:40] violetto: ah, ok! [20:57:44] violetto: right [20:58:00] violetto: you should really update https://www.mediawiki.org/wiki/File:Guide_Color.png then [20:58:47] YuviPanda: it's kinda outdated :/ we're trying to have only one place to update which is here: http://tools.wmflabs.org/styleguide/desktop/section-2.html [20:58:58] violetto: that doesn't have all the colors, no? [20:59:05] violetto: like, what do I use for background, for example [20:59:16] violetto: I only see buttons there [20:59:19] violetto: nothing else [21:00:17] YuviPanda: ok i'll do something up! [21:00:23] violetto: ok! :) [21:02:31] kaldari: kenanwang__ time for mtg! [21:14:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=60356 [21:29:33] (03PS2) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 [21:33:01] (03CR) 10Denny Vrandecic: "Inline, changed according to comments." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [21:33:37] (03CR) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [21:34:06] (03CR) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [21:35:17] (03PS1) 10Yuvipanda: Add 'Agora' styles and set them to be the default [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112982 [21:35:18] brion: ^ [21:37:44] violetto: sent you a build with the title color changes. am off to sleep now. night! [21:41:17] kaldari: jgonera MaxSem http://hatjitsu.wmflabs.org/15348 [22:17:20] (03PS1) 10Kaldari: Prevent race condition in applying CSS styles for content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113022 [22:19:17] brion: how is our build looking ? [22:37:29] (03PS3) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 [22:48:42] jgonera, awjr, MaxSem: Apparenty I can get 4MB/s DSL access to my place in Belize. Do you think that's enough to do Google Hangouts?I was hoping for 8MB, but 4 is the best I can get on a land line. I haven't investigated cellular yet. [22:49:47] kaldari: according to https://support.google.com/plus/answer/1216376?hl=en, bandwidth requirements are minimally 1mbps up, 2mbps down [22:50:12] awjr: ah, that's helpful! [22:50:22] i guess part of the challenge is that the DSL company will say 4mb/s in advertising, but of course ymmv [22:50:42] i suspect it would at least be sufficient for audio [22:51:24] awjr: true. hopefully the actual specs would at least be half the advertized specs! [22:52:03] also I have no idea what the lag would be, but it seems like it would have to be better than India or Russia [22:52:07] kaldari i pay for 50Mbps down/10up, but speedtest.net says I get 63.34Mbps down and 11.76Mbps up :p [22:52:10]