[00:01:25] DarTar, let me know when you have a few minutes [00:04:27] MaxSem, oh, that's pretty soon. sure, whenever you want then ;) [00:14:39] tfinc: can I get an expense review/approval from you? [00:14:49] kaldari: sure. leave it on my desk [00:15:19] (03PS1) 10JGonera: Hygiene: Remove a FIXME from PhotoUploaderButton [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113050 [00:16:51] tfinc: done. it's for $25 for a book on Cucumber and related Ruby libraries. Jgonera suggested it would be useful, so I bought it for the office (although mostly for myself). [00:16:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Are the 9-patches all manually built or are they generated from a master of some kind? Just want to make sure those can be maintained in a" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/112982 (owner: 10Yuvipanda) [00:17:29] tfinc: especially as all the online documentation is really poor [00:17:42] mhurd: ping me when that patch comes in and i'll prep the betas [00:17:56] kaldari: cool. if its good let me know if we should buy more [00:17:57] brion: i think i'm just about done... [00:18:01] mm betas [00:18:01] sweet [00:18:02] nom nom nom [00:18:13] i like to feast on those on wednesdays [00:19:21] :D [00:25:53] (03CR) 10Kaldari: [C: 031] Story 1626: VE section editing scrolls to section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111934 (owner: 10JGonera) [00:26:05] (03PS1) 10Mhurd: Operations for login, login token, and edit token. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113052 [00:26:28] brion: ^ hopefully i didn't break anything too spectacularly :) [00:26:37] \o/ [00:26:41] we shall see :D [00:31:35] ugh i think i mistyped my password too often and have to wait for a timeout :P [00:31:42] brion: hehe [00:31:44] i'll test the other things in the meantime :D [00:34:25] (03CR) 10JGonera: "VE dependency merged." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111934 (owner: 10JGonera) [00:34:43] (03CR) 10Brion VIBBER: "Keyboard fix on search is much-happy. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113052 (owner: 10Mhurd) [00:35:05] (03CR) 10Kaldari: [C: 032] Story 1626: VE section editing scrolls to section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111934 (owner: 10JGonera) [00:35:28] brion: ya that keyboard bug was making me want to throw my phone [00:35:32] hehe [00:36:22] brion: was able to get more of the nav stack management out of the web view controller too... pretty happy about that [00:36:35] nice [00:37:37] (03CR) 10Brion VIBBER: "Login dialog input fields should specialize the 'return' button on keyboard to Next/Done; can do that in a later commit." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113052 (owner: 10Mhurd) [00:38:11] brion: ah! good point [00:38:49] i love categories in objc.... extend ALL the classes! [00:38:58] brion: yay! [00:40:43] brion: i added the 'return' button note as a checklist for the ios login design card: https://trello.com/c/gWWKigOM/26-current-on-ios [00:40:53] *checklist item* [00:40:58] \o/ [00:41:07] brion: IT SHALL BE DONE! [00:41:34] *gandalf voice* [00:43:33] lol [00:44:35] (03Merged) 10jenkins-bot: Story 1626: VE section editing scrolls to section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111934 (owner: 10JGonera) [00:45:06] woo successful login [00:48:39] ok let's merge this and get some testers [00:52:54] (03CR) 10Brion VIBBER: [C: 032 V: 032] "login & editing across another lang works \o/" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113052 (owner: 10Mhurd) [00:54:21] (03PS17) 10Dr0ptp4kt: WIP: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [00:54:51] woot [01:00:38] brion: yay! [01:00:55] brion: cool to cut build? [01:01:06] cutting it as we speak :D [01:01:14] brion: awesome! [01:08:29] kenanwang__: i have some ios stories ready for signoff - time today? or tomorrow better? [01:09:15] mhurd: tomorrow would be good [01:09:27] kenanwang__: sounds good! [01:10:51] ok iOS on testflight, android @ https://releases.wikimedia.org/mobile/android/apps-android-wikipedia-sprint24.apk [01:11:23] brion: awesome!!! [01:11:56] nom nom nom [01:23:51] (03PS1) 10JGonera: Hygiene: Use accept attribute in uploads file input tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113067 [01:27:06] awjr, ready for signoff column is full of random bugs: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/grid?aggregate_property[column]=story+points&aggregate_type[column]=sum&color_by=type&filters[]=[Type][is][Story]&filters[]=[Type][is][Task]&filters[]=[Type][is][Bug]&filters[]=[Type][is][Infrastructure]&filters[]=[Iteration][is][%28Current+iteration%29]&group_by[lane]=status&lanes=Ready+for+Development%2CIn+Development%2CAwaiti [01:27:06] ng+Final+Code+Review%2CReady+for+Signoff%2CAccepted%2CNeeds+Analysis&tab=Story+wall [01:27:27] jgonera: oh i know why [01:27:51] remember i mentioned that script i ran to close mingle bug cards that have already been resolved in bugzilla? [01:28:02] it puts those bugs into 'ready for signoff' of the current iteration [01:28:06] ;) [01:28:25] the original idea was that it would prompt the product owner to review and make sure the bugs were actually indeed resolved [01:28:32] should kenanwang__ go through all of them? ;) [01:28:45] in a perfect world, yes [01:29:10] but if you guys wanna work something different out that's cool too [01:31:45] brion: gonna run. will work w adam more tomorrow to wrangle his zero patch [02:21:45] jgonera awjr uhh nothings perfect :-) [02:22:02] lol [02:22:18] i had a feeling that would be the response - particularly given the quantity of bugs there [02:22:24] kenanwang__: feel free to deputize someone :) [02:22:41] im happy to take a spin through some of those tomorrow [02:31:09] andre__: thanks for updating the mobile product in bugzilla! [02:31:18] do you know if there have been any API changes with this upgrade of BZ? [02:31:27] i should've asked earlier but didn't think to [02:31:35] im hoping bingle will continue to Just Work [11:17:33] (03CR) 10Zfilipin: QA: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin) [12:21:27] (03PS1) 10Venky2834: Removed the bug causing all accounts to be removed from the phone. Now, only TranslateWiki accounts are removed. [apps/android/translate] - 10https://gerrit.wikimedia.org/r/113105 [12:21:29] (03PS1) 10Venky2834: Added a dialog on Logout. [apps/android/translate] - 10https://gerrit.wikimedia.org/r/113106 [17:44:18] MaxSem: irc explode [17:44:19] err [17:44:37] hangout explode [17:44:37] good thing we were wrapping up. i'll pm you what i as saying [17:45:39] (03CR) 10Brion VIBBER: (bug 60537) Adds a deep link to a mobile app if so configured (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [17:55:19] * YuviPanda waves at brion [17:55:40] * brion waves back [18:01:25] YuviPanda: oh i wanted to ask about the agora styles for android -- is there a master size image for those 9-patches or are they all generated by hand? [18:01:31] want to make sure they're easy to update if styles change [18:02:42] brion: they are from jgilfelt.github.io/android-actionbarstylegenerator/#name=example&compat=holo&theme=light&actionbarstyle=solid&texture=0&hairline=0&neutralPressed=1&backColor=E4E4E4%2C100&secondaryColor=D6D6D6%2C100&tabColor=33B5E5%2C100&tertiaryColor=F2F2F2%2C100&accentColor=33B5E5%2C100&cabBackColor=FFFFFF%2C100&cabHighlightColor=33B5E5%2C100 [18:02:51] brion: bah [18:02:53] brion: gilfelt.github.io/android-actionbarstylegenerator [18:02:58] brion: we can regenerate pretty easily [18:03:04] brion: the only customization on that one was the 'white' [18:03:14] aha [18:03:16] spiff [18:03:34] brion: :) [18:03:37] YuviPanda: can you add an explanation of how to build them in a read me or something? be nice not to lose that if you are hit by a bus ;) [18:03:49] brion: sure! [18:03:49] or an auto rickshaw, more likely ;) [18:03:55] brion: the README requires a rewrite anyway [18:04:13] whee [18:04:20] awjr: yo. will you be joining the QA review [18:04:22] ? [18:04:52] i see you weren't added but it would be good for you to hear relative to mw webs side of things [18:05:02] tfinc when is it? [18:05:12] now [18:05:17] tfinc what kind of 'review' is this? [18:05:17] till 11:30 [18:05:21] quarterly [18:05:29] sure i can join, can you send me a hangout link? [18:05:51] awjr: i just added you to the calendar invite [18:05:55] its has the presentation [18:06:03] got it thn [18:06:04] x [18:06:10] brion: can you do the presenting on today's 'showcase'? [18:06:12] i'd love for you to bring up how beta labs has exploded on us [18:06:14] or is it not today? [18:06:27] it is! [18:06:29] nice google calendar *just now* logged me out :D [18:06:51] too bad jon is out. it would be good to hear his review as well [18:06:58] awjr: is bugello still busted ? [18:07:09] tfinc i assume so [18:07:17] i havent looked into bugello specifically yet but bingle is totally hosed atm [18:07:27] YuviPanda: i'm at home office but i can prepare a video... or you can prepare a video if you want :D [18:07:36] brion: nah, I am going to let you do that :) [18:07:40] brion: I need to fix my sleep cycle [18:07:40] it shouldve occurred to me to look at API changes and stuff with the BZ upgrade but i didnt think about it til it was too late [18:07:42] brion: again [18:07:43] hehe ok :D [18:08:01] * brion preps the nexus 5 for screen recording \o/ [18:08:23] tfinc there's a nasty echo in the room [18:08:32] tfinc chip's trick is to unplug/replug the secondary chat 150 [18:08:54] does everyone else hear it? we have a tons of other people on the call and your the first to say it [18:09:01] brion: \o/ [18:09:10] brion: I don't think I'll make it, though [18:09:19] can you ask it on the hangout chat? [18:11:33] brion: thanks for updating http://etherpad.wikimedia.org/MobileShowcase . can we get a bit more detail then "monte show lots of cool ios stuff?" ? [18:12:11] tfinc it only happens when a remote person talks [18:12:19] so far that's only been chrismcmahon [18:14:26] mhurd: poke poke [18:14:35] brion: heya! [18:14:50] mhurd: gonna demo some stuff at the showcase today? [18:15:07] add some juicey details to the ether pad :D [18:15:07] brion: ya sure [18:15:11] woo [18:15:11] k [18:19:06] https://blog.mariadb.org/jquery-and-gis-distance-in-mariadb/ [18:19:55] brion: tfinc: i updated the etherpad, then noticed i had put pretty much the same thing as android [18:23:09] awjr: can you highlight the bugello breakage on '[Wikitech-l] Wikimedia Bugzilla upgraded to 4.4.1 ' ? [18:23:58] tfinc yeah, i'd like to do a little more investigation before i do that which i can do after this [18:24:16] YuviPanda: i'm using sprint 24's build and i'm seeing that search is slow and is not coming back with results most of the time. what can i provide to help you debug this? [18:24:43] tfinc: that's weird. I heard the same thing from another user, yet was not able to reproduce that. [18:24:56] i'm going to switch to mobile data to just make sure its not the network [18:24:58] tfinc: can you tell me 1. what wiki you are on, 2. what phone you are on, 3. how it feels like with mobile web's search [18:25:49] its working much better on mobile data thus far [18:25:55] (03PS4) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 [18:26:15] (03CR) 10jenkins-bot: [V: 04-1] (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [18:26:16] tfinc: hah! that's very interesting [18:26:19] tfinc: are you in the office? [18:27:59] YuviPanda: yes [18:28:16] tfinc: you should try it on the network with the mobile web, see if there's any difference [18:28:26] try them one after the other, and also make sure they are different terms [18:28:58] (03CR) 10Denny Vrandecic: "I now removed the double defaulting, and made it use the existing scheme if one is found" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [18:29:14] (03PS5) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 [18:29:25] (03CR) 10jenkins-bot: [V: 04-1] (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [18:29:45] awjr: can you jump in after chris is done with beta cluster about what you've seen recently ? [18:30:59] YuviPanda: crashdump coming your way [18:31:09] tfinc: ok [18:31:14] tfinc: was the crash related to the search? [18:31:43] 2nd crash report coming in as well [18:31:51] YuviPanda: first one was not [18:32:00] hmm, ok [18:34:54] tfinc: got it [18:35:54] (03CR) 10MaxSem: [C: 04-1] (bug 60537) Adds a deep link to a mobile app if so configured (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [18:37:07] YuviPanda: third crash report coming at you [18:37:28] YuviPanda: thats a huge amount within only 10minutes. how are other testers doing? [18:37:38] (03PS6) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 [18:37:55] tfinc: the second one is a persistent one I'm seeing from the others. The other ones, not so much. [18:38:12] tfinc: but to be fair I only have 2 other testers who are 'not me', so. [18:38:43] YuviPanda: get some of the mobile web folks to test for you [18:39:26] tfinc: I'll try. I had terrible luck trying to get them to do that with the commons app, and I don't know if it woud've changed in the mean time. [18:41:59] tfinc: the first and the third are the same. I'm investigating that now [18:42:28] tfinc: I mean, the *second* and third are same [18:44:57] (03CR) 10Kaldari: [C: 032] Prevent race condition in applying CSS styles for content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113022 (owner: 10Kaldari) [18:45:32] YuviPanda: i'm finding more and more cases where the keyboard is not dismissed after acitons. do you want individual bugs or just one? [18:45:36] (03Merged) 10jenkins-bot: Prevent race condition in applying CSS styles for content [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113022 (owner: 10Kaldari) [18:45:44] tfinc: individual bugs please. [18:48:10] more crashes making me very nervous about the stability of this app [18:48:16] (03CR) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [18:49:12] YuviPanda: what testing services do we have available for some serious chaos monkey testing [18:49:13] ? [18:49:33] MaxSem, around? [18:49:36] tfinc: we have unit tests that ensure that our network stuff is up to date. there is some 'chaosmonkey' stuff that's available that I haven't looked into y et [18:49:50] yurik, yep [18:50:08] tfinc: the fourth crash is the exact same one as the 2nd and 3rd. [18:51:20] chaos monkey! [18:51:21] YuviPanda: what are you seeing ? [18:51:23] MaxSem, just wanted to ask you about langlinks - we are not promoting them to prod just yet, right? [18:51:45] YuviPanda: i was thinking along the lines http://developer.android.com/tools/help/monkey.html [18:51:53] yurik, nope. I'm working on making them stable-ready the way you proposed [18:51:56] tfinc: I can't reproduce it all the time, and when I 'debug' it the webview variable is no longer null. It's been around for a couple of weeks, but I haven't nailed it yet [18:52:06] tfinc: yeah, that's what I was talking about. Haven't looked into that yet [18:52:06] MaxSem, awesome, thx :) [18:53:23] YuviPanda: given that bugello isn't running note that i'm cutting bugs at the same time [18:53:49] tfinc: I do get an email everytime someone files a bug in that product, so feel free to [18:55:48] YuviPanda: i'm going to have to stop testing as its crashing far too often for me to be productive [18:55:54] u [18:55:55] ok [18:56:09] i hope this 5th crash is the same and help you fix it [18:56:15] its incredibly frustrating [19:05:35] kenanwang__: tfinc: i added a bunch of ios bugs to the backlog "in analysis" list [19:05:46] mhurd: thanks [19:06:01] cool thanks [19:06:03] mhurd: are those in bugzilla as well ? [19:06:20] tfinc: i don't think so [19:06:52] let me know if you start seeing duplicates as i don't want to have to check two sources before i cut a bug [19:07:00] tfinc: k [19:07:44] tfinc: I like keeping them in bugzilla - since that is where external users file the, [19:07:45] *them [19:21:04] andre__: i haven't had the chance to dig into this yet, but bingle/bugello is dying with an unusual excepiton: [19:21:04] requests.exceptions.SSLError: hostname 'bugzilla.wikimedia.org' doesn't match either of '*.planet.wikimedia.org', 'planet.wikimedia.org' [19:21:27] just wanted to put this on your radar and see if this stirred anything obvious in your mind before i started digging deeper [19:25:10] YuviPanda, you there? [19:25:15] hey dr0ptp4kt [19:25:25] dr0ptp4kt: sorry I haven't looked at the patches still :( [19:25:40] YuviPanda: :) you read my mind [19:25:56] dr0ptp4kt: I do, don't I :) [19:26:08] YuviPanda: ok, lemme know if you need a hand with anything [19:26:13] dr0ptp4kt: ok! [19:31:40] awjr: ah uh. we moved to a shared host yesterday that also hosts the planet: https://wikitech.wikimedia.org/wiki/Zirconium [19:31:48] (yeah, that page still needs to list Bugzilla, cough) [19:32:12] brion: kenanwang__ : waiting on you guys to start our iteration review [19:32:18] awjr: I have no idea about the magic needed to make that work, sorry. ops might know :-/ [19:37:52] ok thanks andre__, that's really helpful [19:38:08] tfinc: thanks for bringing me into that review [19:38:27] awjr: sure. let greg-g to invite you to all of those [19:38:32] know* [19:51:11] MaxSem: ping? [19:51:16] pong [19:51:26] MaxSem: how does per-section preview work on mobileview? [19:51:45] MaxSem: and i assume that is uncached and it hits the parser? [19:52:00] it's not - we use action=parse&mobileformat§ionpreview [19:52:15] MaxSem: ah! [19:52:25] MaxSem: how fast / slow is it? [19:52:34] or you meant something else? preview as in preview before saving? [19:52:53] MaxSem: preview before saving [19:53:04] yep [20:03:21] MaxSem: so I just set title, text to the new text, sectionid and then mobileformat§ionpreview and I get a JSON back? [20:03:32] MaxSem: with proper reference numbering? [20:03:34] mhurd: can you paste it? [20:03:37] http://hatjitsu.wmflabs.org/81301 [20:08:27] YuviPanda, previews are previews so this API works exactly like UI: references numbered from 1 [20:08:38] MaxSem: hmm, ok. [20:17:17] MaxSem: mobile web doesn't support editnotices, does it? [20:17:30] nah [20:17:40] MaxSem: no plans to, I suppose [20:17:52] they're soo uglily desktopish [20:32:27] brion: will you be joining us for the showcase ? [20:36:41] MaxSem: true. I need to figure a way out for AbuseFilter as well [20:36:48] MaxSem: we show the Mediawiki messages in the app. Need to clean them up [20:40:45] brion: great video [20:49:31] (03PS1) 10Dr0ptp4kt: Add basic Wikipedia Zero support for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113176 [20:50:21] (03Abandoned) 10Dr0ptp4kt: WIP: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 (owner: 10Dr0ptp4kt) [20:54:27] (03PS7) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 [20:55:23] (03CR) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [20:56:20] (03PS8) 10Denny Vrandecic: (bug 60537) Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 [21:04:25] (03PS1) 10Yuvipanda: Do not keep re-creating fragments when we rotate phone [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113181 [21:04:35] brion: ^ [21:04:44] tfinc: ^ that should fix all your crashes. I can send you an apk if you want. [21:07:00] yurik: to be clear, i should *not* be creating a PartnerPortal extension at this time? [21:07:47] dr0ptp4kt, i think it would be premature - lets do it as an extra dir in the existing ext. [21:08:02] won't be too difficult to split them up later [21:08:41] yurik, ok. what will be the entry point to the app? something like Special:ZeroRatedMobileAccess?mode=portal ? [21:21:04] dr0ptp4kt, no, Special:ZeroPortal [21:22:42] hey violetto [21:22:48] YuviPanda: sup [21:22:55] violetto: heya! [21:23:14] YuviPanda: im in a meeting so limited typing :/ [21:23:18] violetto: so, I think I got the concept - you just have things laid out 'horizontally' and just swipe between them. [21:23:24] violetto: that's ok, take your time responding :) [21:23:47] YuviPanda: yeah, i dont have all details worked out yet but that's the plan [21:24:17] plus, we wouldn't need chrome to go back! [21:24:22] or exit [21:24:35] violetto: I think the *biggest* advantage of this is that, right? [21:24:46] violetto: no need for using on-screen chrome to 'go back'? [21:24:54] violetto: but you can just swipe instead? [21:25:02] and also not to disrupt the browsing trail [21:25:08] YuviPanda: yea [21:25:16] and no modal on top of it either! [21:25:26] violetto: right, so I think that is also why it will feel really weird on Android, since there is always a back button [21:25:48] violetto: and that is provided by the OS itself, and works consistently across applications as well. [21:25:51] with the back button we can show the same interaction, we'd animate that back in [21:26:51] violetto: and re: 'modals' - that feels natural to me on Android at least, and also has another advantage - which is 'deep linking'. I can be reading an email in gmail when someone emails me a link to check my watchlist, I can click that and it will lead me directly to the Watchlist part of the app (for example) [21:27:06] violetto: that'll be much harder to do with this pattern (programmatically and hierarchy-wise) [21:27:33] violetto: it'll also mean I need to throw away a *lot* of things Android gives to me 'for free' by just integrating with the default 'back' pattern [21:27:58] violetto: and even if you go to a different activity, when you come back things are as you left them - no trail / history is interrupted [21:28:26] (and I get the 'things are the same as you left them if you press back' is a feature I get for free with Android) [21:30:29] violetto: I think the underlying principles (no interrupting, not losing your place in history/trail, consistent 'back' experience) are things we must definitely have, though [21:30:48] kenanwang__: i am free to start looking through some of the bugs in 'ready for signoff' - with your blessing i'm happy to start moving them to 'acepted' [21:33:39] kaldari: looks like code is merged for https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1643 - can you move it to ready for signoff [21:33:54] (03PS1) 10MaxSem: WIP: Zerofy lang and variant links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113255 [21:34:02] sure [21:34:09] yurik, how does it look? ^^^ [21:35:24] violetto: am off to sleep now! I've emailed you a log of the conversation in case you miss it :) [21:35:45] YuviPanda: ok sorry! talking a lot here [21:35:52] violetto: 'tis ok! :) [21:36:04] i'll read what you said later [21:36:06] and respond [21:36:09] violetto: ok! [21:36:10] violetto: ta! [21:36:33] gnite [21:38:53] that'd be great awjr! [21:39:39] kenanwang__: can you poke brion and mhurd to take care of sign off for the app as well? [22:07:07] (03PS1) 10Yuvipanda: Clear anon tokens (if any) once you log in [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113268 [22:15:15] kenanwang__: i went through all the bugs that were in ready for signoff, everything looked good. [22:26:14] (03PS1) 10MaxSem: Remove unused variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113273 [22:36:09] (03CR) 10MaxSem: [C: 032] "Trivial." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113273 (owner: 10MaxSem) [22:37:06] (03Merged) 10jenkins-bot: Remove unused variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113273 (owner: 10MaxSem) [22:42:06] (03PS1) 10MaxSem: Handle situation when user registration is unknown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113281 [22:47:52] (03PS2) 10MaxSem: Handle situation when user registration is unknown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113281 [22:50:49] kenanwang__, are we still thinking late feb for the new app release? [22:51:39] No editing has been more difficult than we originally thought [22:51:43] this is the new timeline: https://www.mediawiki.org/wiki/Q3_mobile_app_timeline [22:51:54] release is in mid april [22:53:21] ok, thanks. are we talking to communications already about prepping some press work? [23:03:37] hello [23:03:48] kaldari: i'm going to approve your request as i don't see any blockers. mail the team to let them know [23:04:01] jgonera, kaldari: ValidationError: u'page-edit-click' is not one of [u'page-impression', u'cta-impression', u'page-edit-impression', u'page-save-attempt', u'page-save-success'] (for MobileLeftNavbarEditCTA) [23:11:50] kaldari, ori that might explain what DarTar was telling me about yesterday, one of the events was not being logged [23:12:24] argg [23:12:54] ori: sounds like some schema # didn't get updated [23:13:06] I'll check... [23:13:13] i am coming around to the realization that having validation errors be reported in a file readable only by root on an obscure server in eqiad may not be optimal [23:13:34] my thinking was that validation errors would be caught before deployment if they were sufficiently visible [23:13:57] but that's probably wishful thinking. we need some form of monitoring / alerting [23:16:38] jgonera, ori: it was correctly updated at https://gerrit.wikimedia.org/r/#/c/109012/2/includes/MobileFrontend.hooks.php back in January. Lemme see if there's some config var override.... [23:16:59] thanks for investigating this kaldari [23:17:40] (03PS1) 10Awjrichards: Prevent search-specialpages.feature tests from running on enwiki [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113291 [23:18:00] I don't see any overrides [23:18:07] chrismcmahon jgonera would you mind merging ^? that should get rid of current false positive failures on enwiki [23:18:38] (03CR) 10JGonera: [C: 032] Prevent search-specialpages.feature tests from running on enwiki [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113291 (owner: 10Awjrichards) [23:19:12] (03Merged) 10jenkins-bot: Prevent search-specialpages.feature tests from running on enwiki [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113291 (owner: 10Awjrichards) [23:20:00] thanks jgonera :) [23:21:39] Eloquence: Jove from PR just contacted me about it [23:23:30] hey, my MFE notifs are in the right order! thanks, whoever fixed that. [23:23:35] jgonera: chrismcmahon the keepgoing tests continue to fail on test2 and after manually testing, the failure seems correct (https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/261/testReport/) [23:23:37] ori: That error shouldn't be possible. The change that updates the schema # is the same change that starts using 'page-edit-click'. [23:23:39] is keepgoing enabled on test2? [23:24:01] if not we should remove test2 as a target, or enable keepgoing [23:24:25] kaldari: OK, there was only one instance in the logs, now that i look [23:24:35] kaldari: so it's ok to chalk that up to spacetime anomaly [23:24:40] ori: ah, maybe it was just a caching issue then [23:24:51] 'spacetime anomaly' sounds better [23:25:20] awjr, I have no idea, I can check later if nobody knows the answer [23:25:21] kaldari? [23:25:23] awjr: guessing keepgoing is not (yet) on test2. jdlrobson would know [23:25:23] awjr: which 'keepgoing" [23:25:35] kaldari: eh er uh are there more than one? [23:25:44] the edit button keepgoing or the leftnav keepgoing? [23:26:08] edit button i presume (https://wmf.ci.cloudbees.com/job/MobileFrontend-test2.m.wikipedia.org-linux-firefox/261/testReport/) [23:26:19] they are implementent separately and only the leftnav keepgoing is promoted to stable [23:26:20] i thought it was the same thing [23:26:37] kaldari: ah oh; those tests are for alpha [23:26:50] or beta, rather [23:27:16] i presume it's just not enabled on test2 [23:27:47] probably not [23:29:14] awjr: I'll fix it [23:29:26] kaldari: neat thanks [23:29:35] yeah it looks like keepgoing is only enabled on enwiki [23:29:51] and betalabs [23:38:17] awjr: this test doesn't make any sense anyway. The KeepGoing behavior is an A/B test, so the acceptance test is going to fail 50% of the time :P [23:38:57] It also creates a new user every time the test is run, which seems like a bad idea [23:40:44] yeah chrismcmahon has mentioned some concerns about that too [23:41:11] we probably should not have that test in place if the behavior only happens 50% of the time... [23:41:25] i can't keep track of which tests have been resolved and which havent yet :p [23:41:35] maybe we need a matrix of doom. [23:42:43] i am going to mark the KeepGoing tests as @wip [23:44:38] (03PS1) 10Awjrichards: QA: Mark KeepGoing tests as WIP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113296 [23:45:56] jgonera: kaldari chrismcmahon ^ [23:46:41] awjr, sounds good [23:51:54] (03PS2) 10Cmcmahon: QA: Mark KeepGoing tests as WIP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113296 (owner: 10Awjrichards) [23:52:54] (03CR) 10Cmcmahon: [C: 032] QA: Mark KeepGoing tests as WIP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113296 (owner: 10Awjrichards) [23:53:15] awjr: merged after amending to not run in any target envs [23:53:31] (03Merged) 10jenkins-bot: QA: Mark KeepGoing tests as WIP [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113296 (owner: 10Awjrichards) [23:53:34] cool thanks chrismcmahon!